[pacman-dev] small pacman code clarification

Dan McGee dpmcgee at gmail.com
Wed Dec 31 08:33:32 EST 2008


On Wed, Dec 31, 2008 at 6:28 AM, Allan McRae <allan at archlinux.org> wrote:
> Hi,
>
> I am fixing FS#12263 (problem with umask and db creation), which only
> requires moving the creation of the db directory for the package before the
> package archive starts getting extracted.
>
> This occurs in the if loop in libalpm/add.c at line 699.  However, I am
> confused about that if loop.  The archive is extraction is in a loop:
>
>   if(!(trans->flags & PM_TRANS_FLAG_DBONLY)) {
>
> Why is there a need for that if?  As far as I can tell, PM_TRANS_FLAG_DBONLY
> only happens with a -Rk operation.  Is this here in case we want to add the
> -k flag to Sync operations?  Or am I missing its point completely...

Did we used to have it on -A/-U and it got silently lost? That would
be my best guess.

I've never really been sure that this option is needed anyway, but I
don't want to sidetrack this thread.

-Dan


More information about the pacman-dev mailing list