June 2011 - Arch-projects - lists.archlinux.org

[arch-projects] [initscripts][PATCH 2/2] rc.d: Add check to cleanly abort rc.d script if user doesn't have root privileges
by Eric Bélanger 29 Jul '11

29 Jul '11

This implements FS#24095. The check is only made for the start, stop and restart actions of the daemon scripts. This allows regular user to use the help and list functionality of rc.d and also to use rc.d for actions that doesn't require root privileges, like the status action of some daemon scripts. Signed-off-by: Eric Bélanger <snowmaniscool(a)gmail.com> --- rc.d | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/rc.d b/rc.d index 97f266a..2325623 100755 --- a/rc.d +++ b/rc.d @@ -43,6 +43,10 @@ case $1 in ;; *) action=$1 + if [[ "$EUID" != '0' ]] && [[ "$action" == 'start' || "$action" == 'stop' || "$action" == 'restart' ]] ; then + echo 'Error: this script must be run as root to use this functionality.' + exit 1 + fi shift # set same environment variables as init runlevel=$(/sbin/runlevel) -- 1.7.5.2

4 13

[arch-projects] [dbscripts] [PATCH 1/2] Make tests much more portable and usable
by Dan McGee 25 Jul '11

25 Jul '11

Using 'sudo' in a test? Not on my machine, I don't care how secure it should be, it is totally unnecessary, not to mention the annoyance of password prompts, needing the chroot setups, etc. Instead, use makepkg directly along with some very vanilla makepkg.conf config files to do the work. This makes for a more reproducable environment as far as makepkg settings goes. Also adjust the package building code in common.inc to be a bit more straightforward. Remove the need for three seperate loops, and only ever copy packages in one direction (from the local test directory to the /dev/shm/ staging area). With these changes, I didn't have too many problems running the test suite locally on my box after cloning the repository. Signed-off-by: Dan McGee <dan(a)archlinux.org> --- test/lib/common.inc | 54 ++++++++++++++++++++------------------- test/lib/makepkg.i686.conf | 10 +++++++ test/lib/makepkg.x86_64.conf | 10 +++++++ test/test.d/db-update.sh | 6 +++- test/test.d/pool-transition.sh | 3 +- test/test.d/testing2x.sh | 3 +- 6 files changed, 56 insertions(+), 30 deletions(-) create mode 100644 test/lib/makepkg.i686.conf create mode 100644 test/lib/makepkg.x86_64.conf diff --git a/test/lib/common.inc b/test/lib/common.inc index eb46508..a2ba1e0 100644 --- a/test/lib/common.inc +++ b/test/lib/common.inc @@ -10,39 +10,39 @@ oneTimeSetUp() { local pkgname local pkgarch local pkgversion - local build + origindir="$(dirname ${BASH_SOURCE[0]})/../packages" pkgdir="$(mktemp -d /dev/shm/$(basename $0).XXXXXXXXXX)" - cp -Lr $(dirname ${BASH_SOURCE[0]})/../packages/* "${pkgdir}" - msg 'Building packages...' - for d in "${pkgdir}"/*; do - pushd $d >/dev/null - pkgname=($(. PKGBUILD; echo ${pkgname[@]})) - pkgarch=($(. PKGBUILD; echo ${arch[@]})) - pkgversion=$(. PKGBUILD; echo $(get_full_version ${epoch:-0} ${pkgver} ${pkgrel})) - - build=true - for a in ${pkgarch[@]}; do - for p in ${pkgname[@]}; do - [ ! -f ${p}-${pkgversion}-${a}${PKGEXT} ] && build=false - done - done - if ! ${build}; then + if [ -f ${origindir}/packages-built ]; then + msg 'Using existing packages.' + else + msg 'Building packages...' + for d in "${origindir}"/*; do + pushd $d >/dev/null + pkgname=($(. PKGBUILD; echo ${pkgname[@]})) + pkgarch=($(. PKGBUILD; echo ${arch[@]})) + pkgversion=$(. PKGBUILD; echo $(get_full_version ${epoch:-0} ${pkgver} ${pkgrel})) + + PKGDEST=$(pwd) + export PKGDEST + echo $PKGDEST if [ "${pkgarch[0]}" == 'any' ]; then - sudo extra-x86_64-build || die 'extra-x86_64-build failed' + MAKEPKG_CONF="$(dirname ${BASH_SOURCE[0]})/makepkg.i686.conf" + makepkg --force --config "$MAKEPKG_CONF" else for a in ${pkgarch[@]}; do - sudo extra-${a}-build || die "extra-${a}-build failed" + MAKEPKG_CONF="$(dirname ${BASH_SOURCE[0]})/makepkg.$a.conf" + makepkg --force --config "$MAKEPKG_CONF" done fi - for a in ${pkgarch[@]}; do - for p in ${pkgname[@]}; do - cp ${p}-${pkgversion}-${a}${PKGEXT} $(dirname ${BASH_SOURCE[0]})/../packages/$(basename ${d}) - done - done - fi - popd >/dev/null - done + popd >/dev/null + done + + touch ${origindir}/packages-built + fi + + cp -Lr "${origindir}"/* "${pkgdir}" + rm "${pkgdir}"/packages-built } oneTimeTearDown() { @@ -229,3 +229,5 @@ checkRemovedAnyPackage() { [ -d "${TMP}/svn-packages-copy/${pkgbase}/repos/${repo}-any" ] \ && fail "svn-packages-copy/${pkgbase}/repos/${repo}-any should not exist" } + +# vim: syntax=sh: diff --git a/test/lib/makepkg.i686.conf b/test/lib/makepkg.i686.conf new file mode 100644 index 0000000..6fae31e --- /dev/null +++ b/test/lib/makepkg.i686.conf @@ -0,0 +1,10 @@ +# /etc/makepkg.conf + +CARCH="i686" + +BUILDENV=(fakeroot !distcc color !ccache check !sign) +OPTIONS=(strip docs libtool emptydirs zipman purge) + +INTEGRITY_CHECK=(md5) +PKGEXT='.pkg.tar.xz' +SRCEXT='.src.tar.gz' diff --git a/test/lib/makepkg.x86_64.conf b/test/lib/makepkg.x86_64.conf new file mode 100644 index 0000000..cdee1d7 --- /dev/null +++ b/test/lib/makepkg.x86_64.conf @@ -0,0 +1,10 @@ +# /etc/makepkg.conf + +CARCH="x86_64" + +BUILDENV=(fakeroot !distcc color !ccache check !sign) +OPTIONS=(strip docs libtool emptydirs zipman purge) + +INTEGRITY_CHECK=(md5) +PKGEXT='.pkg.tar.xz' +SRCEXT='.src.tar.gz' diff --git a/test/test.d/db-update.sh b/test/test.d/db-update.sh index e38c328..5db276b 100755 --- a/test/test.d/db-update.sh +++ b/test/test.d/db-update.sh @@ -82,7 +82,8 @@ testUpdateAnyPackage() { pushd "${TMP}/svn-packages-copy/pkg-any-a/trunk/" >/dev/null sed 's/pkgrel=1/pkgrel=2/g' -i PKGBUILD svn commit -q -m"update pkg to pkgrel=2" >/dev/null - sudo extra-i686-build >/dev/null 2>&1 + MAKEPKG_CONF="${curdir}/../lib/makepkg.i686.conf" + makepkg --force --config "$MAKEPKG_CONF" mv pkg-any-a-1-2-any.pkg.tar.xz "${pkgdir}/pkg-any-a/" popd >/dev/null @@ -100,7 +101,8 @@ testUpdateAnyPackageToDifferentRepositoriesAtOnce() { pushd "${TMP}/svn-packages-copy/pkg-any-a/trunk/" >/dev/null sed 's/pkgrel=1/pkgrel=2/g' -i PKGBUILD svn commit -q -m"update pkg to pkgrel=2" >/dev/null - sudo extra-i686-build >/dev/null 2>&1 + MAKEPKG_CONF="${curdir}/../lib/makepkg.i686.conf" + makepkg --force --config "$MAKEPKG_CONF" mv pkg-any-a-1-2-any.pkg.tar.xz "${pkgdir}/pkg-any-a/" popd >/dev/null diff --git a/test/test.d/pool-transition.sh b/test/test.d/pool-transition.sh index 5873f00..545c2a5 100755 --- a/test/test.d/pool-transition.sh +++ b/test/test.d/pool-transition.sh @@ -63,7 +63,8 @@ testUpdateAnyPackageWithoutPool() { pushd "${TMP}/svn-packages-copy/${pkgname}/trunk/" >/dev/null sed 's/pkgrel=1/pkgrel=2/g' -i PKGBUILD svn commit -q -m"update pkg to pkgrel=2" >/dev/null - sudo extra-i686-build >/dev/null 2>&1 + MAKEPKG_CONF="${curdir}/../lib/makepkg.i686.conf" + makepkg --force --config "$MAKEPKG_CONF" mv "${pkg2}" "${pkgdir}/${pkgname}/" popd >/dev/null diff --git a/test/test.d/testing2x.sh b/test/test.d/testing2x.sh index eda6cd6..bcc1b9d 100755 --- a/test/test.d/testing2x.sh +++ b/test/test.d/testing2x.sh @@ -10,7 +10,8 @@ testTesting2xAnyPackage() { pushd "${TMP}/svn-packages-copy/pkg-any-a/trunk/" >/dev/null sed 's/pkgrel=1/pkgrel=2/g' -i PKGBUILD svn commit -q -m"update pkg to pkgrel=2" >/dev/null - sudo extra-i686-build >/dev/null 2>&1 + MAKEPKG_CONF="${curdir}/../lib/makepkg.i686.conf" + makepkg --force --config "$MAKEPKG_CONF" mv pkg-any-a-1-2-any.pkg.tar.xz "${pkgdir}/pkg-any-a/" popd >/dev/null -- 1.7.6

3 3

[arch-projects] [devtools] [PATCH 1/2] archrelease: add repos/ directory if it doesn't exist
by Dan McGee 25 Jul '11

25 Jul '11

Very easy thing to forget when creating a new package, but easy enough to check for and add automatically. Signed-off-by: Dan McGee <dan(a)archlinux.org> --- archrelease | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/archrelease b/archrelease index 8ea718c..baaf6cf 100755 --- a/archrelease +++ b/archrelease @@ -29,6 +29,10 @@ if [ -d "repos/${1}" ]; then svn rm --force -q "repos/${1}" svn commit -q -m "archrelease: remove ${1}" || abort fi +if [ ! -d repos ]; then + mkdir repos + svn add repos +fi svn copy -q -r HEAD "${trunk}" "repos/${1}" svn commit -q -m "archrelease: copy ${trunk} to ${1}" || abort popd >/dev/null -- 1.7.6

3 4

[arch-projects] [PATCH] [devtools] Edit /etc/locale.gen instead of overwrite.
by Gerardo Exequiel Pozzi 25 Jul '11

25 Jul '11

I need this for archiso, instead of maintaining a private copy. Signed-off-by: Gerardo Exequiel Pozzi <vmlinuz386(a)yahoo.com.ar> --- mkarchroot | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/mkarchroot b/mkarchroot index f385731..7a7fbbe 100755 --- a/mkarchroot +++ b/mkarchroot @@ -220,7 +220,7 @@ else fi if [ -e "${working_dir}/etc/locale.gen" ]; then - echo -e 'en_US.UTF-8 UTF-8\nde_DE.UTF-8 UTF-8' > "${working_dir}/etc/locale.gen" + sed -i 's@^#$en_US\|de_DE$$\.UTF-8$@\1\2@' "${working_dir}/etc/locale.gen" chroot "${working_dir}" locale-gen fi -- 1.7.5.2

3 2

[arch-projects] [PATCH 1/2] Ensure all variables are unset before loading profile
by Dan McGee 06 Jul '11

06 Jul '11

There is a possible leak of profile info from one to the next if profiles are loaded in sequence, due to the fact that we are running all of this in a shared environment. Unset all currently known variables at the start of load_profile(). This is most apparent in several functions in `src/network` which do looping calls of profile_up or profile_down (which in turn call load_profile). The script `wpa_actiond/netcfg-wpa_actiond` is safe due to its use of subshells. Signed-off-by: Dan McGee <dan(a)archlinux.org> --- This sucks a bit, but is a big failing of netcfg I found when writing my next patch. It screams "there must be a better way", but at the moment I'm not sure what that may be. The biggest problem is there is no central collection of these variables which I had to scrape from the various setup scripts. Thoughts? -Dan src-wireless/netcfg-auto-wireless | 1 - src/network | 9 ++++++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src-wireless/netcfg-auto-wireless b/src-wireless/netcfg-auto-wireless index a3e3fb9..671d34e 100644 --- a/src-wireless/netcfg-auto-wireless +++ b/src-wireless/netcfg-auto-wireless @@ -37,7 +37,6 @@ wifi_auto() while read ap essid; do echo $AUTO_PROFILES | while read network; do ( - unset CONNECTION INTERFACE AP ESSID load_profile "$network" case "$CONNECTION" in wireless-old|wireless|wireless-dbus) diff --git a/src/network b/src/network index 87c0e77..316183e 100644 --- a/src/network +++ b/src/network @@ -8,6 +8,13 @@ # source profile, checking whether it exists and is usable load_profile() { + unset ADDR AP AUTH8021X CONNECTION DESCRIPTION + unset DHCP_OPTIONS DHCP_TIMEOUT DHCLIENT DNS DNS1 DNS2 DOMAIN + unset ESSID GATEWAY HIDDEN IFOPTS INTERFACE IP IPCFG + unset IWCONFIG + unset KEY NETMASK RFKILL RFKILL_NAME SCAN SEARCH TIMEOUT + unset VLAN_ID VLAN_PHYS_DEV + unset WPA_CONF WPA_COUNTRY WPA_DRIVER WPA_GROUP WPA_OPTS [[ -z "$1" ]] && return 1 if [[ ! -f "$PROFILE_DIR/$1" ]]; then report_err "Profile \"$1\" does not exist" @@ -24,7 +31,7 @@ load_profile() report_debug "Interface level configuration enabled: $IFACE_DIR/$INTERFACE" . "$IFACE_DIR/$INTERFACE" fi - . "$PROFILE_DIR/$1" # we want profile settings to override, so need to source profile again + . "$PROFILE_DIR/$1" if [[ ! -f "$CONN_DIR/$CONNECTION" ]]; then report_err "$CONNECTION is not a valid connection, check spelling or look at examples" return 1 -- 1.7.5.2

4 7

[arch-projects] [mkinitcpio] [GIT] The official mkinitcpio repository branch master updated. 0.7-5-g726ff1f
by thomas＠archlinux.org 30 Jun '11

30 Jun '11

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official mkinitcpio repository". The branch, master has been updated via 726ff1f9466847cbe27e807cf79560070651781c (commit) from a594ffca592612f9293454198e56d7ea72b75d14 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 726ff1f9466847cbe27e807cf79560070651781c Author: Thomas Bächler <thomas(a)archlinux.org> Date: Thu Jun 30 22:18:44 2011 +0200 init_functions/default_mount_handler: use -l option for blkid to avoid syntax errors in a later mount command Fixes FS#24969. ----------------------------------------------------------------------- Summary of changes: init_functions | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) hooks/post-receive -- The official mkinitcpio repository

1 0

[arch-projects] [mkinitcpio] [GIT] The official mkinitcpio repository branch master updated. 0.7-4-ga594ffc
by thomas＠archlinux.org 30 Jun '11

30 Jun '11

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official mkinitcpio repository". The branch, master has been updated via a594ffca592612f9293454198e56d7ea72b75d14 (commit) via ea07e5a3e7a5fd76b0eb71909ca87ad830cf1be8 (commit) via 197ee5d21d5098ccaeb1d804256ac49c0aad619f (commit) via 7f2b324b93bb152f5b9a1be6d15f12a46e5e9360 (commit) from fe2c62c3c34f67b9acc14297b00120e6f38da44d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a594ffca592612f9293454198e56d7ea72b75d14 Author: Dave Reisner <dreisner(a)archlinux.org> Date: Thu Jun 30 15:22:39 2011 -0400 function: return with 0 if we reach the end of add_binary The read loop will intentionally return 1 on EOF, but parse_hook will interpret this as an error, and trip our error handler, reporting a false positive failure. commit ea07e5a3e7a5fd76b0eb71909ca87ad830cf1be8 Author: Dave Reisner <dreisner(a)archlinux.org> Date: Sun Jun 26 23:08:06 2011 -0400 bash-completion: use a PE instead of sed Signed-off-by: Dave Reisner <dreisner(a)archlinux.org> commit 197ee5d21d5098ccaeb1d804256ac49c0aad619f Author: Dave Reisner <dreisner(a)archlinux.org> Date: Sun Jun 26 23:07:36 2011 -0400 bash-completion: match style to rest of code Signed-off-by: Dave Reisner <dreisner(a)archlinux.org> commit 7f2b324b93bb152f5b9a1be6d15f12a46e5e9360 Author: Dave Reisner <dreisner(a)archlinux.org> Date: Sun Jun 26 23:06:55 2011 -0400 bash-completion: complete -k on kernel images Signed-off-by: Dave Reisner <dreisner(a)archlinux.org> ----------------------------------------------------------------------- Summary of changes: bash-completion | 29 ++++++++++++++++++++++------- functions | 2 ++ 2 files changed, 24 insertions(+), 7 deletions(-) hooks/post-receive -- The official mkinitcpio repository

1 0

[arch-projects] [mkinitcpio] [GIT] The official mkinitcpio repository annotated tag 0.7 created. 0.7
by thomas＠archlinux.org 30 Jun '11

30 Jun '11

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official mkinitcpio repository". The annotated tag, 0.7 has been created at 5c2a67dcfa6951f93474a914d7bb3d01936f9361 (tag) tagging fe2c62c3c34f67b9acc14297b00120e6f38da44d (commit) replaces 0.6.15 tagged by Thomas Bächler on Thu Jun 30 19:34:46 2011 +0200 - Log ----------------------------------------------------------------- Release version 0.7 Dave Reisner (52): init: don't attempt modprobe if $MODULES is empty mkinitcpio.conf: s/raid/mdadm/ mkinitcpio: deprecate install() in install hooks dmesg: remove install/hook functions: cleanup and refactor add_binary functions: refactor add_module functions: remove add_device functions: remove add_symlink2 use bsdcpio to create images functions: refactor add_file functions: document hook API mkinitcpio.conf: note implicit support for lzop mkinitcpio: use simple PEs instead of externals mkinitcpio: allow specifying kernel ver as path to image lsinitcpio: new utility to dump contents of images Makefile: refactor and simplify mkinitcpio: bashify preset build loop use consistent vim modelines declare all variables in mkinitcpio mkinitcpio: refactor and bashify early path calculations declare SAVELIST, QUIET, SHOW_AUTOMODS as faux booleans mkinitcpio: remove cruft in getopts loop overhaul output, introducing color functions: refactor add_symlink functions: simplify parse_hook mkinitcpio: bashification, part 1/2 mkinitcpio: bashification, part 2/2 add -t option to specify alternate build directory install/keymap: refactor and bashify mkinitcpio: declare usage as a heredoc remove support for -m to add a startup message install/base: cleanup and simplify functions: remove get_module_name init: declare PATH, remove absolute paths init: remove unnecessary variable declarations mkinitcpio: allow overriding the compression method mkinitcpio: only show usage on request mkinitcpio.5: alphabetize options for easier nav README: update copyright year, add self as author mkinitcpio: catch errors in parse_hook add a PKGBUILD for easier testing from the repo mkinitcpio: allow absolute paths to preset files install/{sata,pata,scsi}: cleanup and simplify properly support $BASEDIR install/autodetect: refactor and simplify hook functions: support $BASEDIR in modprobe Makefile: the Makefile itself is a dep for the manpage functions: add missing 'command' before install functions: s/basedir/BASEDIR/ functions: fix pathing issue with $BASEDIR install/base: use private API call to add config mkinitcpio: fix resolution issues with RTLD Eric Bélanger (1): Added usbinput to default hooks (implements FS#19328) Gerardo Exequiel Pozzi (3): Fix some install hooks due recent change in all_modules() Add missing /etc/bash_completion.d in Makefile Add asciidoc as makedepends in private PKGBUILD. Sebastien Luttringer (6): Add bash completion to mkinitcpio Fix printing of bash usage when asking for a bad hook Print pretty message if no help is defined in hook Use error function instead of echo Add lsinitcpio bash completion Use _get_comp_words_by_ref in bash completion Thomas Bächler (7): Merge branch 'master' of https://github.com/seblu/arch-mkinitcpio into working Remove old '-m' option from bash completion. emove old '-a' option from bash completion and fix '-s' option. Merge branch 'working' Add .gitignore file install/keymap: fix installation ($buildroot -> $BUILDROOT) Release version 0.7 ----------------------------------------------------------------------- hooks/post-receive -- The official mkinitcpio repository

1 0

[arch-projects] [mkinitcpio] [GIT] The official mkinitcpio repository branch master updated. 0.6.15-69-gfe2c62c
by thomas＠archlinux.org 30 Jun '11

30 Jun '11

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official mkinitcpio repository". The branch, master has been updated via fe2c62c3c34f67b9acc14297b00120e6f38da44d (commit) via b581a6f5acad597c94827e8714c2c8483829565b (commit) via 3e873aec5f20374081581230f76eff874fe6f72c (commit) via 5827cd46456866e8f62be6d25a10d30525880cef (commit) from a745dc047d103547bed4af97c376a93fd8e3d08a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit fe2c62c3c34f67b9acc14297b00120e6f38da44d Author: Thomas Bächler <thomas(a)archlinux.org> Date: Thu Jun 30 19:34:39 2011 +0200 Release version 0.7 commit b581a6f5acad597c94827e8714c2c8483829565b Author: Thomas Bächler <thomas(a)archlinux.org> Date: Thu Jun 30 19:28:59 2011 +0200 install/keymap: fix installation ($buildroot -> $BUILDROOT) commit 3e873aec5f20374081581230f76eff874fe6f72c Author: Thomas Bächler <thomas(a)archlinux.org> Date: Thu Jun 30 19:19:32 2011 +0200 Add .gitignore file commit 5827cd46456866e8f62be6d25a10d30525880cef Author: Gerardo Exequiel Pozzi <vmlinuz386(a)yahoo.com.ar> Date: Mon Jun 27 19:34:30 2011 -0300 Add asciidoc as makedepends in private PKGBUILD. Avoid: make: a2x: Command not found Signed-off-by: Gerardo Exequiel Pozzi <vmlinuz386(a)yahoo.com.ar> ----------------------------------------------------------------------- Summary of changes: .gitignore | 4 ++++ Makefile | 2 +- PKGBUILD | 1 + install/keymap | 8 ++++---- 4 files changed, 10 insertions(+), 5 deletions(-) create mode 100644 .gitignore hooks/post-receive -- The official mkinitcpio repository

1 0

[arch-projects] [initscripts] [PATCH 00/21] Remaining patches rebaised (again)
by Kurt J. Bosch 28 Jun '11

28 Jun '11

Did some reordering/spitting to move the most important and trivial fixes in front. Also rewrote most commit messages. Actually this is my second git rebase ever. Hopefully this one is a bit better then the first. Kurt J. Bosch (21): Fix whitespace functions: Fix indentation rc.sysinit: Fix writing to /dev/urandom rc.sysinit: Fix setting locale Fix '>|' not used allways when redirecting to files Fix local statements missing in ck_depends, ck_pidfile, do_unlock, kill_everything fuctions: Define $fsckret read-only because exposed to hook Add some comments functions: Simplify ck_depends() for statement functions: Simplify kill_everything() omit_pid handling Refactor to get rid of simple if-constucts rc.sysinit: Get rid of eval Move fsck executable check into fsck_all() for consistency Move activate_vgs and crypt stat_busy to the top for consistency functions: Make activate_vgs return 0 if noop for consistency Move export PATH into functions rc.sysinit: Refactor /etc/mtab symlink detection to avoid empty if clause rc.sysinit: Add status output for mtab and dmesg.log creation functions: Clean up positions of run_hook *_{pre,post}* where in pairs functions: Simplify LC_* unsetting Add install_file() for readability functions | 109 ++++++++++++++++++++++++++++------------------------------ rc.shutdown | 6 +-- rc.sysinit | 93 +++++++++++++++++++++++--------------------------- 3 files changed, 98 insertions(+), 110 deletions(-)

2 23