May 2019 - Arch-projects - lists.archlinux.org

[arch-projects] [devtools] [PATCH] Add new tool: offload-build
by Eli Schwartz 04 Jun '19

04 Jun '19

This tool is useful for running makechrootpkg on a remote build server, and is by default hooked up to send a PKGBUILD and initiate a build on our shiny new build server "dragon". Signed-off-by: Eli Schwartz <eschwartz(a)archlinux.org> --- manpage documentation hopefully coming tonight. Makefile | 1 + offload-build | 100 ++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 101 insertions(+) create mode 100755 offload-build diff --git a/Makefile b/Makefile index ba2d3e4..2306a17 100644 --- a/Makefile +++ b/Makefile @@ -20,6 +20,7 @@ IN_PROGS = \ BINPROGS = \ $(IN_PROGS) \ + offload-build \ sogrep CONFIGFILES = \ diff --git a/offload-build b/offload-build new file mode 100755 index 0000000..66609c6 --- /dev/null +++ b/offload-build @@ -0,0 +1,100 @@ +#!/bin/bash +# +# offload-build - build a PKGBUILD on a remote server using makechrootpkg. +# +# Copyright (c) 2019 by Eli Schwartz <eschwartz(a)archlinux.org> +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see <https://www.gnu.org/licenses/>. +# + + +# global defaults suitable for use by Arch staff +repo=extra +arch=x86_64 +server=dragon.archlinux.org + +die() { printf "error: $1\n" "${@:2}"; exit 1; } + +usage() { + cat <<- _EOF_ + Usage: ${BASH_SOURCE[0]##*/} [--repo REPO] [--arch ARCHITECTURE] [--server SERVER] + + Build a PKGBUILD on a remote server using makechrootpkg. Requires a remote user + that can run archbuild without password auth. + + OPTIONS + -r, --repo Build against a specific repository (current: $repo) + -a, --arch Build against a specific architecture (current: $arch) + -s, --server Offload to a specific build server (current: $server) + -h, --help Show this help text +_EOF_ +} + +# option checking +while (( $# )); do + case $1 in + -h|--help) + usage + exit 0 + ;; + -r|--repo) + repo=$2 + shift 2 + ;; + -a|--arch) + arch=$2 + shift 2 + ;; + -s|--server) + server=$2 + shift 2 + ;; + *) + die "invalid argument: %s" "$1" + ;; + esac +done + +# multilib must be handled specially +if [[ $repo = multilib* ]]; then + arch= +fi + +trap 'rm -rf $SRCPKGDEST' EXIT + +# Use a source-only tarball as an intermediate to transfer files. This +# guarantees the checksums are okay, and guarantees that all needed files are +# transferred, including local sources, install scripts, and changelogs. +export SRCPKGDEST=$(mktemp -d) +makepkg --source || die "unable to make source package" + +mapfile -t files < <( + # This is sort of bash golfing but it allows running a mildly complex + # command over ssh with a single connection. + cat "$SRCPKGDEST"/*.src.tar.gz | + ssh $server ' + temp="${XDG_CACHE_HOME:-$HOME/.cache}/offload-build" && + mkdir -p "$temp" && + temp=$(mktemp -d -p "$temp") && + cd "$temp" && + { + bsdtar --strip-components 1 -xvf - && + script -qfc '"${repo}${arch:+-$arch}-build"' /dev/null && + printf "%s\n" "" "-> build complete" && + printf "\t%s\n" "$temp"/* + } >&2 && + makepkg --packagelist +') + +(( ${#files[@]} )) && printf '%s\n' '' '-> copying files...' && scp "${files[@]/#/$server:}" . -- 2.21.0

1 4

[arch-projects] [namcap] [PATCH 3/4] nonuniquesources: Also warn on common filenames not overriding name to be unique
by James Harvey 27 May '19

27 May '19

Filenames in source() are required to be unique. A common violation of this is from commonly named files (i.e. LICENSE) that aren't part of an upstream tarball. Warn if a source file doesn't have an overriding name, and has a commonly used name, ignoring extension and case. Signed-off-by: James P. Harvey <jamespharvey20 at gmail dot com> Namcap/rules/nonuniquesources.py | 22 ++++++++++++++++++++-- 1 file changed, 20 insertions(+), 2 deletions(-)

3 3

[arch-projects] [namcap] [PATCH] Add warning about following case of preSetUp()
by James P. Harvey 27 May '19

27 May '19

Spent too much time figuring out why I was getting an error of "object has no attribute 'rule'". Perhaps it's correct spelling and grammer for "set up" to be two words here, being used as a verb, but I wasn't expecting that. Maybe this will help someone someday. Signed off by: James P. Harvey <jamespharvey20 at gmail dot com> --- README | 3 +++ 1 file changed, 3 insertions(+) diff --git a/README b/README index c90315e..e7f07d2 100644 --- a/README +++ b/README @@ -160,6 +160,9 @@ class NamcapPkgnameInDescTest(PkgbuildTest): * the preSetUp() method sets the rule to be used in the test +* note the case, using preSetup() will cause the error "object has no attribute + 'rule'" + * the test_example1() method runs the rule on the given PKGBUILD and tests whether the results are as expected -- 2.21.0

1 0

[arch-projects] [namcap] [PATCH 0/4] Add a rule against common filenames in source() without overridden name
by James P. Harvey 27 May '19

27 May '19

There's no good way for namcap to ensure source() filenames are unique across all packages, required for users with SRCDEST. But, I think by far the most common offending filename would be LICENSE, as non-standard ones are required to be included, but sometimes there's no upstream tarball or there is but it's not in there. Mostly an issue for AUR packages, but maybe there are official ones violating this too. We can at least check that if common names are in source(), they're given an overridden name. (Personally, I'm going with "${pkgname}-LICENSE::", but this patch doesn't force this form.) While adding this, split off the recently added non-unique versioned source filenames (non-overridden versioned tarballs) from pkginfo rules. This was originally there using PkgInfoRule, but when it was switched to PkgbuildRule, it was left in pkginfo.py. Also add tests for the recently added non-unique versioned source filenames rule. James P. Harvey (4): Split warning for non-unique source filenames from pkginfo rules Add test for non-unique source filenames nonuniquesources: Also warn on common filenames not overriding name to be unique nonuniquesources: Add test for common filenames Namcap/rules/__init__.py | 1 + Namcap/rules/nonuniquesources.py | 52 ++++++++++ Namcap/rules/pkginfo.py | 11 +-- .../tests/pkgbuild/test_nonuniquesources.py | 94 +++++++++++++++++++ 4 files changed, 148 insertions(+), 10 deletions(-) create mode 100644 Namcap/rules/nonuniquesources.py create mode 100644 Namcap/tests/pkgbuild/test_nonuniquesources.py -- 2.21.0

1 4

[arch-projects] [namcap] [PATCH] Remove all trailing whitespace
by James P. Harvey 27 May '19

27 May '19

Done by: $ find . -not $ -name .git -prune $ -type f -print0 | xargs -0 sed -i -E "s/[[:space:]]*$//" And manually reviewed. Signed-off-by: James P. Harvey <jamespharvey20(a)gmail.com> --- COPYING | 10 +-- Namcap/__init__.py | 6 +- Namcap/depends.py | 6 +- Namcap/package.py | 6 +- Namcap/ruleclass.py | 4 +- Namcap/rules/__init__.py | 6 +- Namcap/rules/arrays.py | 6 +- Namcap/rules/badbackups.py | 6 +- Namcap/rules/carch.py | 6 +- Namcap/rules/emptydir.py | 6 +- Namcap/rules/externalhooks.py | 6 +- Namcap/rules/extravars.py | 6 +- Namcap/rules/fhs.py | 6 +- Namcap/rules/filenames.py | 4 +- Namcap/rules/fileownership.py | 6 +- Namcap/rules/gnomemime.py | 16 ++--- Namcap/rules/hardlinks.py | 6 +- Namcap/rules/invalidstartdir.py | 6 +- Namcap/rules/kdeprograms.py | 4 +- Namcap/rules/libtool.py | 6 +- Namcap/rules/licensepkg.py | 6 +- Namcap/rules/lotsofdocs.py | 6 +- Namcap/rules/makepkgfunctions.py | 6 +- Namcap/rules/mimefiles.py | 6 +- Namcap/rules/missingbackups.py | 6 +- Namcap/rules/missingvars.py | 4 +- Namcap/rules/pathdepends.py | 6 +- Namcap/rules/perllocal.py | 6 +- Namcap/rules/permissions.py | 6 +- Namcap/rules/pkginfo.py | 6 +- Namcap/rules/pkgnameindesc.py | 4 +- Namcap/rules/scrollkeeper.py | 6 +- Namcap/rules/sfurl.py | 6 +- Namcap/rules/shebangdepends.py | 6 +- Namcap/rules/sodepends.py | 6 +- Namcap/rules/splitpkgbuild.py | 6 +- Namcap/rules/symlink.py | 6 +- Namcap/tags.py | 6 +- Namcap/tests/makepkg.py | 4 +- Namcap/tests/package/test_anyelf.py | 4 +- Namcap/tests/package/test_elffiles.py | 4 +- Namcap/tests/package/test_emptydirs.py | 4 +- Namcap/tests/package/test_externalhooks.py | 8 +-- Namcap/tests/package/test_fhs.py | 4 +- Namcap/tests/package/test_filenames.py | 4 +- Namcap/tests/package/test_fileownership.py | 4 +- Namcap/tests/package/test_gnomemime.py | 4 +- Namcap/tests/package/test_hardlinks.py | 4 +- Namcap/tests/package/test_hicoloricons.py | 4 +- Namcap/tests/package/test_infodirectory.py | 4 +- Namcap/tests/package/test_kdeprograms.py | 4 +- Namcap/tests/package/test_libtool.py | 4 +- Namcap/tests/package/test_licensepkg.py | 4 +- Namcap/tests/package/test_lotsofdocs.py | 4 +- Namcap/tests/package/test_mimefiles.py | 4 +- Namcap/tests/package/test_missingbackups.py | 4 +- Namcap/tests/package/test_pathdepends.py | 4 +- Namcap/tests/package/test_perllocal.py | 4 +- Namcap/tests/package/test_permissions.py | 4 +- Namcap/tests/package/test_rpath.py | 4 +- Namcap/tests/package/test_scrollkeeper.py | 4 +- Namcap/tests/package/test_shebangdepends.py | 4 +- Namcap/tests/package/test_sodepends.py | 2 +- Namcap/tests/package/test_symlink.py | 4 +- Namcap/tests/pkgbuild/test_arrays.py | 4 +- Namcap/tests/pkgbuild/test_badbackups.py | 4 +- Namcap/tests/pkgbuild/test_carch.py | 4 +- Namcap/tests/pkgbuild/test_extravars.py | 4 +- Namcap/tests/pkgbuild/test_invalidstartdir.py | 4 +- Namcap/tests/pkgbuild/test_missingvars.py | 4 +- Namcap/tests/pkgbuild/test_pkginfo.py | 4 +- Namcap/tests/pkgbuild/test_pkgnameindesc.py | 4 +- Namcap/tests/pkgbuild/test_sfurl.py | 4 +- Namcap/tests/pkgbuild/test_splitpkgbuild.py | 4 +- Namcap/tests/pkgbuild_test.py | 4 +- Namcap/tests/test_depends.py | 4 +- Namcap/version.py | 6 +- README | 68 +++++++++---------- namcap-tags | 6 +- namcap.py | 14 ++-- 80 files changed, 240 insertions(+), 240 deletions(-) diff --git a/COPYING b/COPYING index b830682..022e560 100644 --- a/COPYING +++ b/COPYING @@ -55,7 +55,7 @@ patent must be licensed for everyone's free use or not licensed at all. The precise terms and conditions for copying, distribution and modification follow. - + GNU GENERAL PUBLIC LICENSE TERMS AND CONDITIONS FOR COPYING, DISTRIBUTION AND MODIFICATION @@ -110,7 +110,7 @@ above, provided that you also meet all of these conditions: License. (Exception: if the Program itself is interactive but does not normally print such an announcement, your work based on the Program is not required to print an announcement.) - + These requirements apply to the modified work as a whole. If identifiable sections of that work are not derived from the Program, and can be reasonably considered independent and separate works in @@ -168,7 +168,7 @@ access to copy from a designated place, then offering equivalent access to copy the source code from the same place counts as distribution of the source code, even though third parties are not compelled to copy the source along with the object code. - + 4. You may not copy, modify, sublicense, or distribute the Program except as expressly provided under this License. Any attempt otherwise to copy, modify, sublicense or distribute the Program is @@ -225,7 +225,7 @@ impose that choice. This section is intended to make thoroughly clear what is believed to be a consequence of the rest of this License. - + 8. If the distribution and/or use of the Program is restricted in certain countries either by patents or by copyrighted interfaces, the original copyright holder who places the Program under this License @@ -278,7 +278,7 @@ PROGRAMS), EVEN IF SUCH HOLDER OR OTHER PARTY HAS BEEN ADVISED OF THE POSSIBILITY OF SUCH DAMAGES. END OF TERMS AND CONDITIONS - + How to Apply These Terms to Your New Programs If you develop a new program, and you want it to be of the greatest diff --git a/Namcap/__init__.py b/Namcap/__init__.py index 50ecfd8..8019d74 100644 --- a/Namcap/__init__.py +++ b/Namcap/__init__.py @@ -1,7 +1,7 @@ -# +# # namcap rules - __init__ # Copyright (C) 2003-2009 Jason Chu <jason(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -15,7 +15,7 @@ # You should have received a copy of the GNU General Public License # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA -# +# from . import util, rules diff --git a/Namcap/depends.py b/Namcap/depends.py index 40d27bf..4a5d77f 100644 --- a/Namcap/depends.py +++ b/Namcap/depends.py @@ -1,9 +1,9 @@ # -*- coding: utf-8 -*- -# +# # namcap rules - depends # Copyright (C) 2003-2009 Jason Chu <jason(a)archlinux.org> # Copyright (C) 2011 Rémy Oudompheng <remy(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -17,7 +17,7 @@ # You should have received a copy of the GNU General Public License # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA -# +# """Checks dependencies semi-smartly.""" diff --git a/Namcap/package.py b/Namcap/package.py index 2da5b1d..f7be228 100644 --- a/Namcap/package.py +++ b/Namcap/package.py @@ -1,9 +1,9 @@ # -*- coding: utf-8 -*- -# +# # namcap rules - package info structure # Copyright (C) 2003-2009 Jason Chu <jason(a)archlinux.org> # Copyright (C) 2011 Rémy Oudompheng <remy(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -17,7 +17,7 @@ # You should have received a copy of the GNU General Public License # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA -# +# import os import sys diff --git a/Namcap/ruleclass.py b/Namcap/ruleclass.py index 15250ad..a68bc3d 100644 --- a/Namcap/ruleclass.py +++ b/Namcap/ruleclass.py @@ -2,7 +2,7 @@ # # namcap - Class hierarchy for rules # Copyright (C) 2011 Rémy Oudompheng <remy(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -17,7 +17,7 @@ # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA # -# +# """ This module defines the base classes from which Namcap rules are derived diff --git a/Namcap/rules/__init__.py b/Namcap/rules/__init__.py index dcc950f..e9292ab 100644 --- a/Namcap/rules/__init__.py +++ b/Namcap/rules/__init__.py @@ -1,7 +1,7 @@ -# +# # namcap rules - __init__ # Copyright (C) 2003-2009 Jason Chu <jason(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -15,7 +15,7 @@ # You should have received a copy of the GNU General Public License # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA -# +# from types import ModuleType import Namcap.ruleclass diff --git a/Namcap/rules/arrays.py b/Namcap/rules/arrays.py index 5ca33cc..2c75df8 100644 --- a/Namcap/rules/arrays.py +++ b/Namcap/rules/arrays.py @@ -1,7 +1,7 @@ -# +# # namcap rules - array # Copyright (C) 2003-2009 Jesse Young <jesseyoung(a)gmail.com> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -15,7 +15,7 @@ # You should have received a copy of the GNU General Public License # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA -# +# """Verifies that array variables are actually arrays""" diff --git a/Namcap/rules/badbackups.py b/Namcap/rules/badbackups.py index c66509b..aac8882 100644 --- a/Namcap/rules/badbackups.py +++ b/Namcap/rules/badbackups.py @@ -1,7 +1,7 @@ -# +# # namcap rules - badbackups # Copyright (C) 2004-2009 Ben Mazer <ben(a)benmazer.net> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -15,7 +15,7 @@ # You should have received a copy of the GNU General Public License # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA -# +# """Checks for bad backup entries""" diff --git a/Namcap/rules/carch.py b/Namcap/rules/carch.py index c2d4a17..7c77c08 100644 --- a/Namcap/rules/carch.py +++ b/Namcap/rules/carch.py @@ -1,7 +1,7 @@ -# +# # namcap rules - carch # Copyright (C) 2003-2009 Jason Chu <jason(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -15,7 +15,7 @@ # You should have received a copy of the GNU General Public License # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA -# +# """Verifies that no specific host type is used""" diff --git a/Namcap/rules/emptydir.py b/Namcap/rules/emptydir.py index 8195637..1141a20 100644 --- a/Namcap/rules/emptydir.py +++ b/Namcap/rules/emptydir.py @@ -1,7 +1,7 @@ -# +# # namcap rules - emptydir # Copyright (C) 2004-2009 Jason Chu <jason(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -15,7 +15,7 @@ # You should have received a copy of the GNU General Public License # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA -# +# import os from Namcap.ruleclass import * diff --git a/Namcap/rules/externalhooks.py b/Namcap/rules/externalhooks.py index 2098f5f..567fe16 100644 --- a/Namcap/rules/externalhooks.py +++ b/Namcap/rules/externalhooks.py @@ -1,7 +1,7 @@ -# +# # namcap rules - externalhooks # Copyright (C) 2016 Kyle Keen <keenerd(a)gmail.com> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -15,7 +15,7 @@ # You should have received a copy of the GNU General Public License # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA -# +# from Namcap.ruleclass import * diff --git a/Namcap/rules/extravars.py b/Namcap/rules/extravars.py index 81084f8..0094bc9 100644 --- a/Namcap/rules/extravars.py +++ b/Namcap/rules/extravars.py @@ -1,7 +1,7 @@ -# +# # namcap rules - extravars # Copyright (C) 2003-2009 Jesse Young <jesseyoung(a)gmail.com> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -15,7 +15,7 @@ # You should have received a copy of the GNU General Public License # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA -# +# from itertools import product from Namcap.ruleclass import * diff --git a/Namcap/rules/fhs.py b/Namcap/rules/fhs.py index 9213da0..aad6961 100644 --- a/Namcap/rules/fhs.py +++ b/Namcap/rules/fhs.py @@ -1,7 +1,7 @@ -# +# # namcap rules - fhs # Copyright (C) 2003-2009 Jason Chu <jason(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -15,7 +15,7 @@ # You should have received a copy of the GNU General Public License # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA -# +# import os, re from Namcap.ruleclass import * diff --git a/Namcap/rules/filenames.py b/Namcap/rules/filenames.py index c5f5f0e..60a9d06 100644 --- a/Namcap/rules/filenames.py +++ b/Namcap/rules/filenames.py @@ -2,7 +2,7 @@ # # namcap rules - filenames # Copyright (C) 2011 Rémy Oudompheng <remy(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -16,7 +16,7 @@ # You should have received a copy of the GNU General Public License # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA -# +# """Checks for invalid filenames.""" diff --git a/Namcap/rules/fileownership.py b/Namcap/rules/fileownership.py index e1dc2d0..33af8a8 100644 --- a/Namcap/rules/fileownership.py +++ b/Namcap/rules/fileownership.py @@ -1,7 +1,7 @@ -# +# # namcap rules - fileownership # Copyright (C) 2003-2009 Jason Chu <jason(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -15,7 +15,7 @@ # You should have received a copy of the GNU General Public License # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA -# +# from Namcap.ruleclass import * diff --git a/Namcap/rules/gnomemime.py b/Namcap/rules/gnomemime.py index d60c2d1..c017fb9 100644 --- a/Namcap/rules/gnomemime.py +++ b/Namcap/rules/gnomemime.py @@ -1,7 +1,7 @@ -# +# # namcap rules - gnomemime # Copyright (C) 2003-2009 Jason Chu <jason(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -15,7 +15,7 @@ # You should have received a copy of the GNU General Public License # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA -# +# from Namcap.ruleclass import * @@ -25,15 +25,15 @@ class package(TarballRule): def analyze(self, pkginfo, tar): mime_files = [ 'usr/share/applications/mimeinfo.cache', - 'usr/share/mime/XMLnamespaces', - 'usr/share/mime/aliases', - 'usr/share/mime/globs', - 'usr/share/mime/magic', + 'usr/share/mime/XMLnamespaces', + 'usr/share/mime/aliases', + 'usr/share/mime/globs', + 'usr/share/mime/magic', 'usr/share/mime/subclasses' ] for i in tar.getnames(): if i in mime_files: self.errors.append(("gnome-mime-file %s", i)) - + # vim: set ts=4 sw=4 noet: diff --git a/Namcap/rules/hardlinks.py b/Namcap/rules/hardlinks.py index e465879..cd724b4 100644 --- a/Namcap/rules/hardlinks.py +++ b/Namcap/rules/hardlinks.py @@ -1,7 +1,7 @@ -# +# # namcap rules - hardlinks # Copyright (C) 2011 Dan McGee <dan(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -15,7 +15,7 @@ # You should have received a copy of the GNU General Public License # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA -# +# from os.path import dirname from Namcap.ruleclass import * diff --git a/Namcap/rules/invalidstartdir.py b/Namcap/rules/invalidstartdir.py index 446d903..5213b59 100644 --- a/Namcap/rules/invalidstartdir.py +++ b/Namcap/rules/invalidstartdir.py @@ -1,7 +1,7 @@ -# +# # namcap rules - invalidstartdir # Copyright (C) 2003-2009 Jason Chu <jason(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -15,7 +15,7 @@ # You should have received a copy of the GNU General Public License # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA -# +# import re from Namcap.ruleclass import * diff --git a/Namcap/rules/kdeprograms.py b/Namcap/rules/kdeprograms.py index ec6e35a..35c3e07 100644 --- a/Namcap/rules/kdeprograms.py +++ b/Namcap/rules/kdeprograms.py @@ -2,7 +2,7 @@ # # namcap rules - kdeprograms # Copyright (C) 2011 Rémy Oudompheng <remy(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -16,7 +16,7 @@ # You should have received a copy of the GNU General Public License # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA -# +# from Namcap.ruleclass import * import Namcap.depends diff --git a/Namcap/rules/libtool.py b/Namcap/rules/libtool.py index bdbf293..2060bd8 100644 --- a/Namcap/rules/libtool.py +++ b/Namcap/rules/libtool.py @@ -1,7 +1,7 @@ -# +# # namcap rules - libtool # Copyright (C) 2005-2009 Simo Leone <simo(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -15,7 +15,7 @@ # You should have received a copy of the GNU General Public License # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA -# +# import re from Namcap.ruleclass import * diff --git a/Namcap/rules/licensepkg.py b/Namcap/rules/licensepkg.py index 026caf4..f849a6a 100644 --- a/Namcap/rules/licensepkg.py +++ b/Namcap/rules/licensepkg.py @@ -1,7 +1,7 @@ -# +# # namcap rules - licensepkg # Copyright (C) 2003-2009 Jason Chu <jason(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -15,7 +15,7 @@ # You should have received a copy of the GNU General Public License # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA -# +# import os.path from Namcap.ruleclass import * diff --git a/Namcap/rules/lotsofdocs.py b/Namcap/rules/lotsofdocs.py index 254d62f..28d3a19 100644 --- a/Namcap/rules/lotsofdocs.py +++ b/Namcap/rules/lotsofdocs.py @@ -1,7 +1,7 @@ -# +# # namcap rules - lotsofdocs # Copyright (C) 2009 Dan McGee <dan(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -15,7 +15,7 @@ # You should have received a copy of the GNU General Public License # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA -# +# from Namcap.ruleclass import * diff --git a/Namcap/rules/makepkgfunctions.py b/Namcap/rules/makepkgfunctions.py index fa20f5f..633846a 100644 --- a/Namcap/rules/makepkgfunctions.py +++ b/Namcap/rules/makepkgfunctions.py @@ -1,7 +1,7 @@ -# +# # namcap rules - makepkgfunctions # Copyright (C) 2017 Kyle Keen <keenerd(a)gmail.com> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -15,7 +15,7 @@ # You should have received a copy of the GNU General Public License # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA -# +# import re from Namcap.ruleclass import * diff --git a/Namcap/rules/mimefiles.py b/Namcap/rules/mimefiles.py index f9d56f4..49edd4c 100644 --- a/Namcap/rules/mimefiles.py +++ b/Namcap/rules/mimefiles.py @@ -1,8 +1,8 @@ -# +# # namcap rules - mimefiles # Copyright (C) 2009 Hugo Doria <hugo(a)archlinux.org> # Copyright (C) 2011 Rémy Oudompheng <remy(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -16,7 +16,7 @@ # You should have received a copy of the GNU General Public License # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA -# +# from Namcap.ruleclass import * diff --git a/Namcap/rules/missingbackups.py b/Namcap/rules/missingbackups.py index 5c82e15..df262b9 100644 --- a/Namcap/rules/missingbackups.py +++ b/Namcap/rules/missingbackups.py @@ -1,7 +1,7 @@ -# +# # namcap rules - missingbackups # Copyright (C) 2011 Dan McGee <dan(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -15,7 +15,7 @@ # You should have received a copy of the GNU General Public License # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA -# +# from Namcap.ruleclass import * diff --git a/Namcap/rules/missingvars.py b/Namcap/rules/missingvars.py index 25445e2..9b176fd 100644 --- a/Namcap/rules/missingvars.py +++ b/Namcap/rules/missingvars.py @@ -3,7 +3,7 @@ # namcap rules - missingvars # Copyright (C) 2003-2009 Jason Chu <jason(a)archlinux.org> # Copyright (C) 2011 Rémy Oudompheng <remy(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -17,7 +17,7 @@ # You should have received a copy of the GNU General Public License # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA -# +# """Checks for missing variables in PKGBUILD""" diff --git a/Namcap/rules/pathdepends.py b/Namcap/rules/pathdepends.py index 5bc4313..04e970c 100644 --- a/Namcap/rules/pathdepends.py +++ b/Namcap/rules/pathdepends.py @@ -1,7 +1,7 @@ -# +# # namcap rules - pathdepends # Copyright (C) 2016 Kyle Keen <keenerd(a)gmail.com> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -15,7 +15,7 @@ # You should have received a copy of the GNU General Public License # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA -# +# """ This contains a collection of essentially one-line rules: diff --git a/Namcap/rules/perllocal.py b/Namcap/rules/perllocal.py index 24923d9..bc77978 100644 --- a/Namcap/rules/perllocal.py +++ b/Namcap/rules/perllocal.py @@ -1,7 +1,7 @@ -# +# # namcap rules - perllocal # Copyright (C) 2003-2009 Jason Chu <jason(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -15,7 +15,7 @@ # You should have received a copy of the GNU General Public License # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA -# +# from Namcap.ruleclass import * diff --git a/Namcap/rules/permissions.py b/Namcap/rules/permissions.py index f7adce1..e74d8ae 100644 --- a/Namcap/rules/permissions.py +++ b/Namcap/rules/permissions.py @@ -1,7 +1,7 @@ -# +# # namcap rules - permissions # Copyright (C) 2003-2009 Jason Chu <jason(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -15,7 +15,7 @@ # You should have received a copy of the GNU General Public License # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA -# +# import stat from Namcap.ruleclass import * diff --git a/Namcap/rules/pkginfo.py b/Namcap/rules/pkginfo.py index 5a42810..8a15991 100644 --- a/Namcap/rules/pkginfo.py +++ b/Namcap/rules/pkginfo.py @@ -1,7 +1,7 @@ -# +# # namcap rules - package variables # Copyright (C) 2003-2009 Jason Chu <jason(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -15,7 +15,7 @@ # You should have received a copy of the GNU General Public License # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA -# +# "These rules checks basic sanity of package metadata" diff --git a/Namcap/rules/pkgnameindesc.py b/Namcap/rules/pkgnameindesc.py index 7fbb8a5..77185ee 100644 --- a/Namcap/rules/pkgnameindesc.py +++ b/Namcap/rules/pkgnameindesc.py @@ -1,7 +1,7 @@ -# +# # namcap rules - pkgname # Copyright (C) 2009 Hugo Doria <hugo(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or diff --git a/Namcap/rules/scrollkeeper.py b/Namcap/rules/scrollkeeper.py index 8c813b8..e2ac624 100644 --- a/Namcap/rules/scrollkeeper.py +++ b/Namcap/rules/scrollkeeper.py @@ -1,7 +1,7 @@ -# +# # namcap rules - scrollkeeper # Copyright (C) 2003-2009 Jason Chu <jason(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -15,7 +15,7 @@ # You should have received a copy of the GNU General Public License # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA -# +# import re from Namcap.ruleclass import * diff --git a/Namcap/rules/sfurl.py b/Namcap/rules/sfurl.py index f3b6874..73e3528 100644 --- a/Namcap/rules/sfurl.py +++ b/Namcap/rules/sfurl.py @@ -1,7 +1,7 @@ -# +# # namcap rules - sfurl # Copyright (C) 2004-2009 Ben Mazer <ben(a)benmazer.net> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -15,7 +15,7 @@ # You should have received a copy of the GNU General Public License # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA -# +# import re from Namcap.ruleclass import * diff --git a/Namcap/rules/shebangdepends.py b/Namcap/rules/shebangdepends.py index 07896df..1fc87fd 100644 --- a/Namcap/rules/shebangdepends.py +++ b/Namcap/rules/shebangdepends.py @@ -1,9 +1,9 @@ # -*- coding: utf-8 -*- -# +# # namcap rules - shebangdepends # Copyright (C) 2003-2009 Jason Chu <jason(a)archlinux.org> # Copyright (C) 2011 Rémy Oudompheng <remy(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -17,7 +17,7 @@ # You should have received a copy of the GNU General Public License # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA -# +# """Checks dependencies on programs specified in shebangs.""" diff --git a/Namcap/rules/sodepends.py b/Namcap/rules/sodepends.py index 2f061bb..685a17a 100644 --- a/Namcap/rules/sodepends.py +++ b/Namcap/rules/sodepends.py @@ -3,7 +3,7 @@ # namcap rules - sodepends # Copyright (C) 2003-2009 Jason Chu <jason(a)archlinux.org> # Copyright (C) 2011 Rémy Oudompheng <remy(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -17,7 +17,7 @@ # You should have received a copy of the GNU General Public License # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA -# +# """Checks dependencies resulting from linking of shared libraries.""" @@ -113,7 +113,7 @@ def finddepends(liblist): return dependlist, orphans def filllibcache(): - var = subprocess.Popen('ldconfig -p', + var = subprocess.Popen('ldconfig -p', env = {"LANG": "C"}, shell=True, stdout=subprocess.PIPE, diff --git a/Namcap/rules/splitpkgbuild.py b/Namcap/rules/splitpkgbuild.py index e253ced..8409ead 100644 --- a/Namcap/rules/splitpkgbuild.py +++ b/Namcap/rules/splitpkgbuild.py @@ -1,7 +1,7 @@ -# +# # namcap rules - split package checks # Copyright (C) 2011 Rémy Oudompheng <remy(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -15,7 +15,7 @@ # You should have received a copy of the GNU General Public License # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA -# +# "This module contains rules that check coherence of split PKGBUILDs." diff --git a/Namcap/rules/symlink.py b/Namcap/rules/symlink.py index f595bc5..3b2c5c9 100644 --- a/Namcap/rules/symlink.py +++ b/Namcap/rules/symlink.py @@ -1,7 +1,7 @@ -# +# # namcap rules - symlink # Copyright (C) 2003-2009 Jason Chu <jason(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -15,7 +15,7 @@ # You should have received a copy of the GNU General Public License # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA -# +# import os from Namcap.ruleclass import * from Namcap.package import load_from_db diff --git a/Namcap/tags.py b/Namcap/tags.py index 714885d..cad3a34 100644 --- a/Namcap/tags.py +++ b/Namcap/tags.py @@ -1,9 +1,9 @@ # -*- coding: utf-8 -*- -# +# # namcap - tags # Copyright (C) 2003-2009 Jason Chu <jason(a)archlinux.org> # Copyright (c) 2011 Rémy Oudompheng <remy(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -18,7 +18,7 @@ # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA # -# +# import os diff --git a/Namcap/tests/makepkg.py b/Namcap/tests/makepkg.py index b3b0725..10ed0bd 100644 --- a/Namcap/tests/makepkg.py +++ b/Namcap/tests/makepkg.py @@ -2,7 +2,7 @@ # # namcap tests - makepkg launcher # Copyright (C) 2011 Rémy Oudompheng <remy(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -17,7 +17,7 @@ # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 # USA -# +# import os import tempfile diff --git a/Namcap/tests/package/test_anyelf.py b/Namcap/tests/package/test_anyelf.py index e8f85f7..ef4f5b1 100644 --- a/Namcap/tests/package/test_anyelf.py +++ b/Namcap/tests/package/test_anyelf.py @@ -2,7 +2,7 @@ # # namcap tests - anyelf rule # Copyright (C) 2011 Rémy Oudompheng <remy(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -17,7 +17,7 @@ # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 # USA -# +# import os from Namcap.tests.makepkg import MakepkgTest diff --git a/Namcap/tests/package/test_elffiles.py b/Namcap/tests/package/test_elffiles.py index b11fa13..c08580e 100644 --- a/Namcap/tests/package/test_elffiles.py +++ b/Namcap/tests/package/test_elffiles.py @@ -2,7 +2,7 @@ # # namcap tests - elffiles # Copyright (C) 2011 Rémy Oudompheng <remy(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -17,7 +17,7 @@ # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 # USA -# +# import os from Namcap.tests.makepkg import MakepkgTest diff --git a/Namcap/tests/package/test_emptydirs.py b/Namcap/tests/package/test_emptydirs.py index f419594..d13e333 100644 --- a/Namcap/tests/package/test_emptydirs.py +++ b/Namcap/tests/package/test_emptydirs.py @@ -2,7 +2,7 @@ # # namcap tests - non ascii filenames # Copyright (C) 2011 Rémy Oudompheng <remy(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -17,7 +17,7 @@ # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 # USA -# +# import os from Namcap.tests.makepkg import MakepkgTest diff --git a/Namcap/tests/package/test_externalhooks.py b/Namcap/tests/package/test_externalhooks.py index 4d1cfcc..a0f871d 100644 --- a/Namcap/tests/package/test_externalhooks.py +++ b/Namcap/tests/package/test_externalhooks.py @@ -1,7 +1,7 @@ -# +# # namcap tests - externalhooks rule # Copyright (C) 2016 Kyle Keen <keenerd(a)gmail.com> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -15,7 +15,7 @@ # You should have received a copy of the GNU General Public License # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA -# +# import os from Namcap.tests.makepkg import MakepkgTest @@ -83,5 +83,5 @@ post_install() { self.assertEqual(r.errors, []) self.assertEqual(r.warnings, []) self.assertEqual(r.infos, []) - + # vim: set ts=4 sw=4 noet: diff --git a/Namcap/tests/package/test_fhs.py b/Namcap/tests/package/test_fhs.py index 8288ef5..ba8af1d 100644 --- a/Namcap/tests/package/test_fhs.py +++ b/Namcap/tests/package/test_fhs.py @@ -2,7 +2,7 @@ # # namcap tests - non ascii filenames # Copyright (C) 2011 Rémy Oudompheng <remy(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -17,7 +17,7 @@ # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 # USA -# +# import os from Namcap.tests.makepkg import MakepkgTest diff --git a/Namcap/tests/package/test_filenames.py b/Namcap/tests/package/test_filenames.py index 358a3c0..effc42d 100644 --- a/Namcap/tests/package/test_filenames.py +++ b/Namcap/tests/package/test_filenames.py @@ -2,7 +2,7 @@ # # namcap tests - non ascii filenames # Copyright (C) 2011 Rémy Oudompheng <remy(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -17,7 +17,7 @@ # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 # USA -# +# import os from Namcap.tests.makepkg import MakepkgTest diff --git a/Namcap/tests/package/test_fileownership.py b/Namcap/tests/package/test_fileownership.py index 6065394..8c7c7a2 100644 --- a/Namcap/tests/package/test_fileownership.py +++ b/Namcap/tests/package/test_fileownership.py @@ -2,7 +2,7 @@ # # namcap tests - fileownership # Copyright (C) 2011 Rémy Oudompheng <remy(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -17,7 +17,7 @@ # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 # USA -# +# import os from Namcap.tests.makepkg import MakepkgTest diff --git a/Namcap/tests/package/test_gnomemime.py b/Namcap/tests/package/test_gnomemime.py index 1f95300..ae8a026 100644 --- a/Namcap/tests/package/test_gnomemime.py +++ b/Namcap/tests/package/test_gnomemime.py @@ -2,7 +2,7 @@ # # namcap tests - gnomemime # Copyright (C) 2011 Rémy Oudompheng <remy(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -17,7 +17,7 @@ # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 # USA -# +# import os from Namcap.tests.makepkg import MakepkgTest diff --git a/Namcap/tests/package/test_hardlinks.py b/Namcap/tests/package/test_hardlinks.py index 382b244..21a4d4d 100644 --- a/Namcap/tests/package/test_hardlinks.py +++ b/Namcap/tests/package/test_hardlinks.py @@ -2,7 +2,7 @@ # # namcap tests - cross-directory hard links # Copyright (C) 2011 Rémy Oudompheng <remy(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -17,7 +17,7 @@ # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 # USA -# +# import os from Namcap.tests.makepkg import MakepkgTest diff --git a/Namcap/tests/package/test_hicoloricons.py b/Namcap/tests/package/test_hicoloricons.py index 7130e22..c640163 100644 --- a/Namcap/tests/package/test_hicoloricons.py +++ b/Namcap/tests/package/test_hicoloricons.py @@ -2,7 +2,7 @@ # # namcap tests - hicoloricons # Copyright (C) 2011 Rémy Oudompheng <remy(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -17,7 +17,7 @@ # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 # USA -# +# import os from Namcap.tests.makepkg import MakepkgTest diff --git a/Namcap/tests/package/test_infodirectory.py b/Namcap/tests/package/test_infodirectory.py index ae16f03..3f8493c 100644 --- a/Namcap/tests/package/test_infodirectory.py +++ b/Namcap/tests/package/test_infodirectory.py @@ -2,7 +2,7 @@ # # namcap tests - infodirectory # Copyright (C) 2011 Rémy Oudompheng <remy(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -17,7 +17,7 @@ # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 # USA -# +# import os from Namcap.tests.makepkg import MakepkgTest diff --git a/Namcap/tests/package/test_kdeprograms.py b/Namcap/tests/package/test_kdeprograms.py index 4e320fc..5edfe10 100644 --- a/Namcap/tests/package/test_kdeprograms.py +++ b/Namcap/tests/package/test_kdeprograms.py @@ -2,7 +2,7 @@ # # namcap tests - kdeprograms # Copyright (C) 2011 Rémy Oudompheng <remy(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -17,7 +17,7 @@ # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 # USA -# +# import os import unittest diff --git a/Namcap/tests/package/test_libtool.py b/Namcap/tests/package/test_libtool.py index d249740..ba00556 100644 --- a/Namcap/tests/package/test_libtool.py +++ b/Namcap/tests/package/test_libtool.py @@ -2,7 +2,7 @@ # # namcap tests - libtool # Copyright (C) 2011 Rémy Oudompheng <remy(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -17,7 +17,7 @@ # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 # USA -# +# import os from Namcap.tests.makepkg import MakepkgTest diff --git a/Namcap/tests/package/test_licensepkg.py b/Namcap/tests/package/test_licensepkg.py index 95acea0..a152e48 100644 --- a/Namcap/tests/package/test_licensepkg.py +++ b/Namcap/tests/package/test_licensepkg.py @@ -2,7 +2,7 @@ # # namcap tests - licensepkg # Copyright (C) 2011 Rémy Oudompheng <remy(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -17,7 +17,7 @@ # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 # USA -# +# import os from Namcap.tests.makepkg import MakepkgTest diff --git a/Namcap/tests/package/test_lotsofdocs.py b/Namcap/tests/package/test_lotsofdocs.py index 61f7016..cd21c7e 100644 --- a/Namcap/tests/package/test_lotsofdocs.py +++ b/Namcap/tests/package/test_lotsofdocs.py @@ -2,7 +2,7 @@ # # namcap tests - lotsofdocs # Copyright (C) 2011 Rémy Oudompheng <remy(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -17,7 +17,7 @@ # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 # USA -# +# import os from Namcap.tests.makepkg import MakepkgTest diff --git a/Namcap/tests/package/test_mimefiles.py b/Namcap/tests/package/test_mimefiles.py index bfed439..84955aa 100644 --- a/Namcap/tests/package/test_mimefiles.py +++ b/Namcap/tests/package/test_mimefiles.py @@ -1,7 +1,7 @@ # # namcap tests - mimefiles # Copyright (C) 2011 Rémy Oudompheng <remy(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -16,7 +16,7 @@ # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 # USA -# +# import os from Namcap.tests.makepkg import MakepkgTest diff --git a/Namcap/tests/package/test_missingbackups.py b/Namcap/tests/package/test_missingbackups.py index da8a12b..1f036ab 100644 --- a/Namcap/tests/package/test_missingbackups.py +++ b/Namcap/tests/package/test_missingbackups.py @@ -2,7 +2,7 @@ # # namcap tests - missingbackups # Copyright (C) 2011 Rémy Oudompheng <remy(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -17,7 +17,7 @@ # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 # USA -# +# import os from Namcap.tests.makepkg import MakepkgTest diff --git a/Namcap/tests/package/test_pathdepends.py b/Namcap/tests/package/test_pathdepends.py index 48f153c..f28ad7f 100644 --- a/Namcap/tests/package/test_pathdepends.py +++ b/Namcap/tests/package/test_pathdepends.py @@ -2,7 +2,7 @@ # namcap tests - glibfiles # Copyright (C) 2011 Rémy Oudompheng <remy(a)archlinux.org> # Copyright (C) 2016 Kyle Keen <keenerd(a)gmail.com> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -17,7 +17,7 @@ # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 # USA -# +# import os from Namcap.tests.makepkg import MakepkgTest diff --git a/Namcap/tests/package/test_perllocal.py b/Namcap/tests/package/test_perllocal.py index 6a6c952..5983858 100644 --- a/Namcap/tests/package/test_perllocal.py +++ b/Namcap/tests/package/test_perllocal.py @@ -2,7 +2,7 @@ # # namcap tests - perllocal # Copyright (C) 2011 Rémy Oudompheng <remy(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -17,7 +17,7 @@ # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 # USA -# +# import os from Namcap.tests.makepkg import MakepkgTest diff --git a/Namcap/tests/package/test_permissions.py b/Namcap/tests/package/test_permissions.py index edadd16..2e48c93 100644 --- a/Namcap/tests/package/test_permissions.py +++ b/Namcap/tests/package/test_permissions.py @@ -2,7 +2,7 @@ # # namcap tests - permissions # Copyright (C) 2011 Rémy Oudompheng <remy(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -17,7 +17,7 @@ # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 # USA -# +# import os from Namcap.tests.makepkg import MakepkgTest diff --git a/Namcap/tests/package/test_rpath.py b/Namcap/tests/package/test_rpath.py index 856c721..d3dce8c 100644 --- a/Namcap/tests/package/test_rpath.py +++ b/Namcap/tests/package/test_rpath.py @@ -2,7 +2,7 @@ # # namcap tests - rpath # Copyright (C) 2011 Rémy Oudompheng <remy(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -17,7 +17,7 @@ # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 # USA -# +# import os from Namcap.tests.makepkg import MakepkgTest diff --git a/Namcap/tests/package/test_scrollkeeper.py b/Namcap/tests/package/test_scrollkeeper.py index 47a70c8..5b3d9c7 100644 --- a/Namcap/tests/package/test_scrollkeeper.py +++ b/Namcap/tests/package/test_scrollkeeper.py @@ -2,7 +2,7 @@ # # namcap tests - scrollkeeper # Copyright (C) 2011 Rémy Oudompheng <remy(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -17,7 +17,7 @@ # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 # USA -# +# import os from Namcap.tests.makepkg import MakepkgTest diff --git a/Namcap/tests/package/test_shebangdepends.py b/Namcap/tests/package/test_shebangdepends.py index dbacd86..c3e17a7 100644 --- a/Namcap/tests/package/test_shebangdepends.py +++ b/Namcap/tests/package/test_shebangdepends.py @@ -1,6 +1,6 @@ # namcap tests - shebangdepends # Copyright (C) 2016 Kyle Keen <keenerd(a)gmail.com> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -15,7 +15,7 @@ # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 # USA -# +# import os from Namcap.tests.makepkg import MakepkgTest diff --git a/Namcap/tests/package/test_sodepends.py b/Namcap/tests/package/test_sodepends.py index d5537ac..f94b3e9 100644 --- a/Namcap/tests/package/test_sodepends.py +++ b/Namcap/tests/package/test_sodepends.py @@ -2,7 +2,7 @@ # # namcap tests - sodepends # Copyright (C) 2011 Rémy Oudompheng <remy(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or diff --git a/Namcap/tests/package/test_symlink.py b/Namcap/tests/package/test_symlink.py index 92c8d51..c030f7a 100644 --- a/Namcap/tests/package/test_symlink.py +++ b/Namcap/tests/package/test_symlink.py @@ -2,7 +2,7 @@ # # namcap tests - symlink # Copyright (C) 2011 Rémy Oudompheng <remy(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -17,7 +17,7 @@ # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 # USA -# +# import os from Namcap.tests.makepkg import MakepkgTest diff --git a/Namcap/tests/pkgbuild/test_arrays.py b/Namcap/tests/pkgbuild/test_arrays.py index e7515d9..bf22b28 100644 --- a/Namcap/tests/pkgbuild/test_arrays.py +++ b/Namcap/tests/pkgbuild/test_arrays.py @@ -2,7 +2,7 @@ # # namcap tests - arrays # Copyright (C) 2011 Rémy Oudompheng <remy(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -17,7 +17,7 @@ # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 # USA -# +# from Namcap.tests.pkgbuild_test import PkgbuildTest import Namcap.rules diff --git a/Namcap/tests/pkgbuild/test_badbackups.py b/Namcap/tests/pkgbuild/test_badbackups.py index 07530c9..a69dcf6 100644 --- a/Namcap/tests/pkgbuild/test_badbackups.py +++ b/Namcap/tests/pkgbuild/test_badbackups.py @@ -2,7 +2,7 @@ # # namcap tests - badbackups # Copyright (C) 2011 Rémy Oudompheng <remy(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -17,7 +17,7 @@ # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 # USA -# +# from Namcap.tests.pkgbuild_test import PkgbuildTest import Namcap.rules.badbackups as module diff --git a/Namcap/tests/pkgbuild/test_carch.py b/Namcap/tests/pkgbuild/test_carch.py index 728cbd2..411c006 100644 --- a/Namcap/tests/pkgbuild/test_carch.py +++ b/Namcap/tests/pkgbuild/test_carch.py @@ -2,7 +2,7 @@ # # namcap tests - carch # Copyright (C) 2011 Rémy Oudompheng <remy(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -17,7 +17,7 @@ # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 # USA -# +# from Namcap.tests.pkgbuild_test import PkgbuildTest import Namcap.rules.carch as module diff --git a/Namcap/tests/pkgbuild/test_extravars.py b/Namcap/tests/pkgbuild/test_extravars.py index 872848d..778a470 100644 --- a/Namcap/tests/pkgbuild/test_extravars.py +++ b/Namcap/tests/pkgbuild/test_extravars.py @@ -2,7 +2,7 @@ # # namcap tests - extravars # Copyright (C) 2011 Rémy Oudompheng <remy(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -17,7 +17,7 @@ # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 # USA -# +# import os from Namcap.tests.pkgbuild_test import PkgbuildTest diff --git a/Namcap/tests/pkgbuild/test_invalidstartdir.py b/Namcap/tests/pkgbuild/test_invalidstartdir.py index 80d03c6..ec249c0 100644 --- a/Namcap/tests/pkgbuild/test_invalidstartdir.py +++ b/Namcap/tests/pkgbuild/test_invalidstartdir.py @@ -2,7 +2,7 @@ # # namcap tests - invalidstartdir # Copyright (C) 2011 Rémy Oudompheng <remy(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -17,7 +17,7 @@ # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 # USA -# +# from Namcap.tests.pkgbuild_test import PkgbuildTest import Namcap.rules.invalidstartdir as module diff --git a/Namcap/tests/pkgbuild/test_missingvars.py b/Namcap/tests/pkgbuild/test_missingvars.py index b079651..32c9ba8 100644 --- a/Namcap/tests/pkgbuild/test_missingvars.py +++ b/Namcap/tests/pkgbuild/test_missingvars.py @@ -2,7 +2,7 @@ # # namcap tests - missingvars # Copyright (C) 2011 Rémy Oudompheng <remy(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -17,7 +17,7 @@ # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 # USA -# +# from Namcap.tests.pkgbuild_test import PkgbuildTest from Namcap.rules.missingvars import * diff --git a/Namcap/tests/pkgbuild/test_pkginfo.py b/Namcap/tests/pkgbuild/test_pkginfo.py index 7e6f9d3..540b2b7 100644 --- a/Namcap/tests/pkgbuild/test_pkginfo.py +++ b/Namcap/tests/pkgbuild/test_pkginfo.py @@ -2,7 +2,7 @@ # # namcap tests - pkginfo # Copyright (C) 2011 Rémy Oudompheng <remy(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -17,7 +17,7 @@ # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 # USA -# +# from Namcap.tests.pkgbuild_test import PkgbuildTest from Namcap.rules.pkginfo import * diff --git a/Namcap/tests/pkgbuild/test_pkgnameindesc.py b/Namcap/tests/pkgbuild/test_pkgnameindesc.py index 168ce76..eeec080 100644 --- a/Namcap/tests/pkgbuild/test_pkgnameindesc.py +++ b/Namcap/tests/pkgbuild/test_pkgnameindesc.py @@ -2,7 +2,7 @@ # # namcap tests - pkgnameindesc # Copyright (C) 2011 Rémy Oudompheng <remy(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -17,7 +17,7 @@ # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 # USA -# +# from Namcap.tests.pkgbuild_test import PkgbuildTest import Namcap.rules.pkgnameindesc as module diff --git a/Namcap/tests/pkgbuild/test_sfurl.py b/Namcap/tests/pkgbuild/test_sfurl.py index 72cd7a4..24e3b35 100644 --- a/Namcap/tests/pkgbuild/test_sfurl.py +++ b/Namcap/tests/pkgbuild/test_sfurl.py @@ -2,7 +2,7 @@ # # namcap tests - sfurl # Copyright (C) 2011 Rémy Oudompheng <remy(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -17,7 +17,7 @@ # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 # USA -# +# from Namcap.tests.pkgbuild_test import PkgbuildTest import Namcap.rules.sfurl as module diff --git a/Namcap/tests/pkgbuild/test_splitpkgbuild.py b/Namcap/tests/pkgbuild/test_splitpkgbuild.py index e57f727..ce63ec7 100644 --- a/Namcap/tests/pkgbuild/test_splitpkgbuild.py +++ b/Namcap/tests/pkgbuild/test_splitpkgbuild.py @@ -2,7 +2,7 @@ # # namcap tests - sfurl # Copyright (C) 2011 Rémy Oudompheng <remy(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -17,7 +17,7 @@ # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 # USA -# +# from Namcap.tests.pkgbuild_test import PkgbuildTest import Namcap.rules.splitpkgbuild as module diff --git a/Namcap/tests/pkgbuild_test.py b/Namcap/tests/pkgbuild_test.py index 56e9fb2..2a7809c 100644 --- a/Namcap/tests/pkgbuild_test.py +++ b/Namcap/tests/pkgbuild_test.py @@ -2,7 +2,7 @@ # # namcap tests - pkgbuild rule testing template # Copyright (C) 2011 Rémy Oudompheng <remy(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -17,7 +17,7 @@ # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 # USA -# +# import os import unittest diff --git a/Namcap/tests/test_depends.py b/Namcap/tests/test_depends.py index 8e74192..8a9b00b 100644 --- a/Namcap/tests/test_depends.py +++ b/Namcap/tests/test_depends.py @@ -2,7 +2,7 @@ # # namcap tests - tests for the depends module # Copyright (C) 2011 Rémy Oudompheng <remy(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -17,7 +17,7 @@ # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 # USA -# +# import unittest import Namcap.depends diff --git a/Namcap/version.py b/Namcap/version.py index 7705f12..8720f12 100644 --- a/Namcap/version.py +++ b/Namcap/version.py @@ -1,8 +1,8 @@ # -*- coding: utf-8 -*- -# +# # namcap - version # Copyright (c) 2015 Rikard Falkeborn <rikard.falkeborn(a)gmail.com> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -17,7 +17,7 @@ # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA # -# +# def get_version(): return '3.2.8' diff --git a/README b/README index c90315e..edcc25e 100644 --- a/README +++ b/README @@ -2,27 +2,27 @@ WHAT IS IT? ----------------------------- -Namcap is a tool for pacman checking binary packages and source PKGBUILDs for +Namcap is a tool for pacman checking binary packages and source PKGBUILDs for common packaging errors. HOW CAN I HELP? ----------------------------- -There are several ways that you can contribute and help namcap's development. +There are several ways that you can contribute and help namcap's development. You can contribute with code, patches, tests, bugs and feature requests. -To report a bug or a feature request for namcap, file a bug in the -Packages:Extra section of the Arch Linux bugtracker and the set the importance -accordingly. If you're reporting a bug, please give concrete examples of +To report a bug or a feature request for namcap, file a bug in the +Packages:Extra section of the Arch Linux bugtracker and the set the importance +accordingly. If you're reporting a bug, please give concrete examples of packages where the problem occurs. Minimal examples (very simple packages forged to exhibit unexpected behaviour from namcap) are also welcome to extend namcap's test suite. -If you've a patch (fixing a bug or a new namcap module), then you can send it +If you've a patch (fixing a bug or a new namcap module), then you can send it to the arch-projects mailing list. Namcap development is managed with git, so -git-formatted patches are preferred. +git-formatted patches are preferred. Namcap's source is available on: @@ -36,48 +36,48 @@ To run namcap on a PKGBUILD or a binary pkg.tar.xz: $ namcap FILENAME -If you want to see extra informational messages, then invoke namcap with +If you want to see extra informational messages, then invoke namcap with the -i flag: $ namcap -i FILENAME -You can also see the namcap(1) manual by typing man namcap at the command line +You can also see the namcap(1) manual by typing man namcap at the command line or see the usage help: -$ namcap -h +$ namcap -h UNDERSTANDING THE OUTPUT ----------------------------- -Namcap uses a system of tags to classify the output. Currently, tags are of -three types, errors (denoted by E), warnings (denoted by W) and informational -(denoted by I). +Namcap uses a system of tags to classify the output. Currently, tags are of +three types, errors (denoted by E), warnings (denoted by W) and informational +(denoted by I). -An error is important and should be fixed immediately; mostly they relate to +An error is important and should be fixed immediately; mostly they relate to insufficient security, missing licenses or permission problems. -Normally namcap prints a human-readable explanation (sometimes with suggestions -on how to fix the problem). If you want output which can be easily parsed by a -program, then pass the -m (machine-readable) flag to namcap. +Normally namcap prints a human-readable explanation (sometimes with suggestions +on how to fix the problem). If you want output which can be easily parsed by a +program, then pass the -m (machine-readable) flag to namcap. HOW IT WORKS ----------------------------- -Namcap takes the package name (or a PKGBUILD) as an argument that runs through -all the rules defined in Namcap.rules submodules and tests them against the argument +Namcap takes the package name (or a PKGBUILD) as an argument that runs through +all the rules defined in Namcap.rules submodules and tests them against the argument looking for flaws. HOW TO CREATE A MODULE ----------------------------- -This section documents the innards of namcap and specifies how to create a new +This section documents the innards of namcap and specifies how to create a new namcap rule. -The main namcap program namcap.py takes as parameters the filename of a package -or a PKGBUILD and makes a pkginfo object, which it passes to a list of rules +The main namcap program namcap.py takes as parameters the filename of a package +or a PKGBUILD and makes a pkginfo object, which it passes to a list of rules defined in Namcap.rules.all_rules : * a rule is a subclass of AbstractRule (defined in Namcap.ruleclass) @@ -104,25 +104,25 @@ attributes that each namcap rule must have: * base class Either PkgInfoRull, PkgbuildRule, TarballRule. - + * name Contains a string containing a short name of the module. Usually, this is the same as the basename of the module file. - + * description - A string containing a concise description of the module. This + A string containing a concise description of the module. This description is used when listing all the rules using namcap -r list. - - * analyze(self, pkginfo, tar) + + * analyze(self, pkginfo, tar) Should fill three lists self.errors, self.warnings and self.infos - with error tags, warning tags and information tags respectively. - Each member of these tag lists should be a tuple consisting of two - components: the short, hyphenated form of the tag with the appropriate - format specifiers (%s, etc.) The first word of this string must be the tag + with error tags, warning tags and information tags respectively. + Each member of these tag lists should be a tuple consisting of two + components: the short, hyphenated form of the tag with the appropriate + format specifiers (%s, etc.) The first word of this string must be the tag name. The human readable form of the tag should be put in the namcap-tags file. The format of the tags file is described below; and the parameters - which should replace the format specifier tokens in the final output. - + which should replace the format specifier tokens in the final output. + The namcap-tags file consists of lines specifying the human readable form of the hyphenated tags used in the namcap code. A line beginning with a '#' is @@ -130,7 +130,7 @@ treated as a comment. Otherwise the format of the file is: machine-parseable-tag %s :: This is machine parseable tag %s -Note that a double colon (::) is used to separate the hyphenated tag from the +Note that a double colon (::) is used to separate the hyphenated tag from the human readable description. HOW TO TEST A RULE diff --git a/namcap-tags b/namcap-tags index 17b9506..ce05a34 100644 --- a/namcap-tags +++ b/namcap-tags @@ -1,11 +1,11 @@ # namcap tags file -# The tags file consists of lines specifying the human readable form of the -# hyphenated tags used in the namcap code. A line beginning with a '#' is +# The tags file consists of lines specifying the human readable form of the +# hyphenated tags used in the namcap code. A line beginning with a '#' is # treated as a comment. Otherwise the format of the file is: # # machine-parseable-tag %s :: This is machine parseable tag %s # -# Note that a double colon (::) is used to separate the hyphenated tag from the +# Note that a double colon (::) is used to separate the hyphenated tag from the # human readable description. # rules tags diff --git a/namcap.py b/namcap.py index a7f532a..6404020 100755 --- a/namcap.py +++ b/namcap.py @@ -1,8 +1,8 @@ #! /usr/bin/env python3 -# +# # namcap - A Pacman package analyzer # Copyright (C) 2003-2009 Jason Chu <jason(a)archlinux.org> -# +# # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2 of the License, or @@ -17,7 +17,7 @@ # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA # -# +# import getopt import os @@ -61,15 +61,15 @@ def open_package(filename): return None return tar -def check_rules_exclude(optlist): +def check_rules_exclude(optlist): '''Check if the -r (--rules) and the -r (--exclude) options are being used at same time''' args_used = 0 - for i in optlist: + for i in optlist: if '-r' in i or '-e' in i: args_used += 1 if '--rules' in i or '--exclude' in i: - args_used += 1 + args_used += 1 return args_used def show_messages(name, key, messages): @@ -105,7 +105,7 @@ def process_realpackage(package, modules): show_messages(pkginfo["name"], 'W', rule.warnings) if info_reporting: show_messages(pkginfo["name"], 'I', rule.infos) - + # dependency analysis errs, warns, infos = Namcap.depends.analyze_depends(pkginfo) show_messages(pkginfo["name"], 'E', errs) -- 2.21.0

1 0

[arch-projects] [namcap] [PATCH 0/4] Add a rule against common filenames in source() without overridden name
by James Harvey 27 May '19

27 May '19

There's no good way for namcap to ensure source() filenames are unique across all packages, required for users with SRCDEST. But, I think by far the most common offending filename would be LICENSE, as non-standard ones are required to be included, but sometimes there's no upstream tarball or there is but it's not in there. Mostly an issue for AUR packages, but maybe there are official ones violating this too. We can at least check that if common names are in source(), they're given an overridden name. (Personally, I'm going with "${pkgname}-LICENSE::", but this patch doesn't force this form.) While adding this, split off the recently added non-unique versioned source filenames (non-overridden versioned tarballs) from pkginfo rules. This was originally there using PkgInfoRule, but when it was switched to PkgbuildRule, it was left in pkginfo.py. Also add tests for the recently added non-unique versioned source filenames rule.

2 2

[arch-projects] [namcap] [PATCH] Add warning about following case of preSetUp()
by James Harvey 27 May '19

27 May '19

Spent too much time figuring out why I was getting an error of "object has no attribute 'rule'". Perhaps it's correct spelling and grammer for "set up" to be two words here, being used as a verb, but I wasn't expecting that. Maybe this will help someone someday. Signed off by: James P. Harvey <jamespharvey20 at gmail dot com> --- README | 3 +++ 1 file changed, 3 insertions(+)

1 0

[arch-projects] [namcap] [PATCH 4/4] nonuniquesources: Add test for common filenames (HEAD -> nonuniquesources)
by James Harvey 27 May '19

27 May '19

Signed-off-by: James P. Harvey <jamespharvey20 at gmail dot com> .../tests/pkgbuild/test_nonuniquesources.py | 36 +++++++++++++++++++ 1 file changed, 36 insertions(+)

1 0

[arch-projects] [namcap] [PATCH 2/4] Add test for non-unique source filenames
by James Harvey 27 May '19

27 May '19

Signed-off-by: James P. Harvey <jamespharvey20 at gmail dot com> .../tests/pkgbuild/test_nonuniquesources.py | 58 +++++++++++++++++++ 1 file changed, 58 insertions(+) create mode 100644 Namcap/tests/pkgbuild/test_nonuniquesources.py

1 0

[arch-projects] [namcap] [PATCH 1/4] Split warning for non-unique source filenames from pkginfo rules
by James Harvey 27 May '19

27 May '19

This was originally here, because it used PkgInfoRule, but was changed to use PkgbuildRule and was left here. Signed-off-by: James P. Harvey <jamespharvey20 at gmail dot com> Namcap/rules/__init__.py | 1 + Namcap/rules/nonuniquesources.py | 34 ++++++++++++++++++++++++++++++++ Namcap/rules/pkginfo.py | 11 +---------- 3 files changed, 36 insertions(+), 10 deletions(-) create mode 100644 Namcap/rules/nonuniquesources.py

1 0