- Arch-projects - lists.archlinux.org

[arch-projects] [devtools] [GIT] The official devtools repository branch master updated. 20191130-5-gd4546c5
by Levente Polyak 12 Dec '19

12 Dec '19

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official devtools repository". The branch, master has been updated via d4546c59ce2731a96d336f9953108816ff4b954b (commit) from d6866e0544581840cc021e4be68c1c450fcb7963 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d4546c59ce2731a96d336f9953108816ff4b954b Author: Levente Polyak <anthraxx(a)archlinux.org> Date: Thu Dec 12 01:01:44 2019 +0100 Version 20191212 ----------------------------------------------------------------------- Summary of changes: Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- The official devtools repository

1 0

[arch-projects] [devtools] [GIT] The official devtools repository branch sogrep_redirect deleted. 20190912-11-g7f849ea
by Levente Polyak 10 Dec '19

10 Dec '19

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official devtools repository". The branch, sogrep_redirect has been deleted was 7f849ea58d6a46631017b928285ebf3ff4ce6c69 - Log ----------------------------------------------------------------- 7f849ea58d6a46631017b928285ebf3ff4ce6c69 sogrep: redirect to destination mirror ----------------------------------------------------------------------- hooks/post-receive -- The official devtools repository

1 0

[arch-projects] [devtools] [GIT] The official devtools repository branch master updated. 20191130-4-gd6866e0
by Levente Polyak 10 Dec '19

10 Dec '19

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official devtools repository". The branch, master has been updated via d6866e0544581840cc021e4be68c1c450fcb7963 (commit) via 8edad226166eb6f2888b87cf8e0a9952822c887a (commit) via f20435643f55c37e3f8274a03e7fe5e052dc8dd9 (commit) from 8d99df602d6e5fc377a37f67d0e5ce74c8facecd (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d6866e0544581840cc021e4be68c1c450fcb7963 Author: Levente Polyak <anthraxx(a)archlinux.org> Date: Wed Dec 4 12:39:34 2019 +0100 lib: support arbitrary compressed package files We need to modify the matching of valid package files to support formats like zstd. Let's try to use an eager approach instead of a simple whitelist in order to be functional for arbitrary formats that may be introduced in the future without the need to adjust any code. Allow any single fragment word as compression type but filter out known non-package content like signature files. Signed-off-by: Levente Polyak <anthraxx(a)archlinux.org> commit 8edad226166eb6f2888b87cf8e0a9952822c887a Author: Eli Schwartz <eschwartz(a)archlinux.org> Date: Mon Dec 2 15:51:21 2019 -0500 offload-build: return failure if no package files were found This means that the remote command died at some stage earlier than the printing of created files. Signed-off-by: Eli Schwartz <eschwartz(a)archlinux.org> commit f20435643f55c37e3f8274a03e7fe5e052dc8dd9 Author: Levente Polyak <anthraxx(a)archlinux.org> Date: Tue Dec 3 01:14:35 2019 +0100 makechrootpkg: sync databases for checkpkg off-site Use pacman's --dbpath feature to sync fresh databases inside an isolated location and split up the database sync and package location calls to remove the need of weird grep calls. It isn't nice of makechrootpkg to modify the host database state just by building packages. No foreign program shall automatically modify the host database other than by the explicit will of a system maintainer, which is the major reason this changes get incorporated. However, there is certain indoctrinated believe that using -Sy is the prime evil. In fact it has been declared as a social rule to a technical problem of not getting into potential partial upgrade states. This is not a proper loophole less solution as there are multiple ways and use cases that lead to such a state, like aborting a -Syu on the prompt for whatever reason, what really matters is that it is not a technically bullet proof solution to solve the problem. Databases shall have the freedom to be as up to date as databases or their owner wishes, allowing querying on latest database state without fear. The only loophole-less contract that _really_ is from importance is always using -Su instead of plain -S to install packages. Installing packages is what actually brings one into a potential partial upgrade state and by using -Su an outstanding upgrade is forced when installing a new package. This properly solves all edge cases in a technical manner instead of declaring people who abort the prompt of -Syu to be the problem. In fact, using this simple contract allows whatever system maintenance workflow a host owner wants to follow, which may still be to always use -Syu and deal with system upgrades explicitly instead of the time when installing new packages, but the -Su contract is the real safe guard to guarantee no edge case can ever slip in. This magically also opens up the freedom to people who wish to use -Sy to simply query on up to date data as the currently indoctrinated "never do -Sy" stone plates not only are not rock solid in technical terms but also make certain use cases simply impossible and hence cripple the functionality without at the very least being fully loophole free. Signed-off-by: Levente Polyak <anthraxx(a)archlinux.org> ----------------------------------------------------------------------- Summary of changes: lib/common.sh | 4 ++-- makechrootpkg.in | 15 +++++++++++++-- offload-build | 2 ++ 3 files changed, 17 insertions(+), 4 deletions(-) hooks/post-receive -- The official devtools repository

1 0

[arch-projects] [devtools] [PATCH] offload-build: return failure if no package files were found
by Eli Schwartz 02 Dec '19

02 Dec '19

This means that the remote command died at some stage earlier than the printing of created files. Signed-off-by: Eli Schwartz <eschwartz(a)archlinux.org> --- offload-build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/offload-build b/offload-build index dab036d..e607a16 100755 --- a/offload-build +++ b/offload-build @@ -116,4 +116,6 @@ if (( ${#files[@]} )); then printf '%s\n' '' '-> copying files...' load_makepkg_config scp "${files[@]/#/$server:}" "${PKGDEST:-${PWD}}/" +else + exit 1 fi -- 2.24.0

1 0

[arch-projects] [devtools] [GIT] The official devtools repository branch master updated. 20191016-20-g4c803b9
by Levente Polyak 02 Dec '19

02 Dec '19

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official devtools repository". The branch, master has been updated via 4c803b9db8f6395c610c96bd090d1ba2ced82a9c (commit) via 104c5bc90e259028f5c9352a32f8976aa0f95a8d (commit) via cee28a1b13ddd0f60b2466b20a43f04a4bf5df54 (commit) via e0f82d394717efb28537f0a366b4a5b3515354b6 (commit) via 74313db9ee243b30b48d355f88b3c8971b90161f (commit) via 2c611d20bdd04feae6ab32a7ef8947aeb4118604 (commit) via ca4d348c86de0a466d48e6d99ac390729707c317 (commit) via 2fb1cc2dd2c2171bd2c078a37f871de45b0fe118 (commit) via bcba56640536406b860fa7364357659b51d0aea5 (commit) via f8f2f0202804a7c6001a98295ec35d43ec5f809c (commit) via 68f0bff172f77390dfad798f12e4a56e0c1f35d4 (commit) via f85a58a0a630d44285532693b61d4b8a58dee495 (commit) via 20eec484fadd7212367749ee7cd37d3aa18e8c4e (commit) via 6fffbfbc8af6b1194b977582fe3cb308b550f864 (commit) from 001726337972f35e1907f6460831c3c3c9d656e4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4c803b9db8f6395c610c96bd090d1ba2ced82a9c Author: Levente Polyak <anthraxx(a)archlinux.org> Date: Sat Nov 30 13:30:34 2019 +0100 Version 20191130 commit 104c5bc90e259028f5c9352a32f8976aa0f95a8d Author: Levente Polyak <anthraxx(a)archlinux.org> Date: Sat Nov 30 13:13:49 2019 +0100 makechrootpkg: sync database for checkpkg to avoid nonexistent targets For build servers or similar infrastructure its relatively common to not sync/update the database regularly. This leads to problems properly running checkpkg duo to nonexistent target files that we try to download. As building on build servers is a very common use case, lets ensure we sync the local database before trying to resolve the package locations. commit cee28a1b13ddd0f60b2466b20a43f04a4bf5df54 Author: Levente Polyak <anthraxx(a)archlinux.org> Date: Sat Nov 30 13:09:14 2019 +0100 makechrootpkg: check local pkg versions before downloading for checkpkg Avoid always trying to download and output the according message. Add checks for packages either not being available in the repo or all variants have up to date versions stored in the local cache. commit e0f82d394717efb28537f0a366b4a5b3515354b6 Author: Levente Polyak <anthraxx(a)archlinux.org> Date: Thu Nov 28 21:50:15 2019 +0100 completion: add makerepropkg zsh completion commit 74313db9ee243b30b48d355f88b3c8971b90161f Author: Levente Polyak <anthraxx(a)archlinux.org> Date: Thu Nov 28 21:49:43 2019 +0100 completion: reflect new -U mkarchchroot option commit 2c611d20bdd04feae6ab32a7ef8947aeb4118604 Author: Ivy Foster <escondida(a)iff.ink> Date: Thu Nov 21 18:08:25 2019 -0600 lib/common.sh: do not use colors when running on a dumb terminal commit ca4d348c86de0a466d48e6d99ac390729707c317 Author: Eli Schwartz <eschwartz(a)archlinux.org> Date: Sun Nov 17 21:24:02 2019 -0500 doc: add manpage for the new makerepropkg tool Signed-off-by: Eli Schwartz <eschwartz(a)archlinux.org> commit 2fb1cc2dd2c2171bd2c078a37f871de45b0fe118 Author: Eli Schwartz <eschwartz(a)archlinux.org> Date: Wed Feb 13 17:14:00 2019 -0500 makerepropkg: add new program to try to reproducibly build a package This attempts to recreate a package that was probably created using makechrootpkg, and see if it conforms to the https://reproducible-builds.org/ specification. Signed-off-by: Eli Schwartz <eschwartz(a)archlinux.org> commit bcba56640536406b860fa7364357659b51d0aea5 Author: Eli Schwartz <eschwartz(a)archlinux.org> Date: Tue Sep 3 18:40:00 2019 -0400 mkarchroot: support wrapping pacstrap -U Needed to support reproducible builds. Signed-off-by: Eli Schwartz <eschwartz(a)archlinux.org> commit f8f2f0202804a7c6001a98295ec35d43ec5f809c Author: Eli Schwartz <eschwartz(a)archlinux.org> Date: Sat Nov 9 22:13:00 2019 -0500 archbuild: use better umask In commit 40a90e2cab479cc64903a62b42eb617a8a7e5842 we tried to protect against system umasks resulting in unreadable chroots. However, we tried to do this in a targeted manner due to not wanting to fiddle with permissions for user-owned files. Unfortuantely, mkdir -p -m755 does not actually work that way -- the parent directory is created with broken permissions. We need umask. Run umask and mkdir in a subshell to prevent leakage. Signed-off-by: Eli Schwartz <eschwartz(a)archlinux.org> commit 68f0bff172f77390dfad798f12e4a56e0c1f35d4 Author: Eli Schwartz <eschwartz(a)archlinux.org> Date: Fri Nov 8 09:40:09 2019 -0500 commitpkg: clearly delineate the commit message template and the rationale In commit 75d23eec942e7160108ee194894b6b83ed3045d5 we moved to include commitpkg arguments as the first line of the svn commit message, but we simply dumped the result after the version number without separating the two, increasing the cognitive burden of parsing the rationale. Since the whole point of the change was to make it easier to see what happened when using git log --oneline (reducing the cognitive burden of parsing 'pretty' output with author/date info), it makes sense to also delineate the reason correctly. Signed-off-by: Eli Schwartz <eschwartz(a)archlinux.org> commit f85a58a0a630d44285532693b61d4b8a58dee495 Author: Eli Schwartz <eschwartz(a)archlinux.org> Date: Wed Oct 2 11:21:33 2019 -0400 arch-nspawn: rely on deduplication to avoid making multiple host_mirror mounts Instead of comparing exact mirror urls to see if they are in host_mirrors in order to "skip" the official mirrors Signed-off-by: Eli Schwartz <eschwartz(a)archlinux.org> commit 20eec484fadd7212367749ee7cd37d3aa18e8c4e Author: Levente Polyak <anthraxx(a)archlinux.org> Date: Thu Nov 7 22:28:17 2019 +0100 offload-build: remove empty src dir when SRCDEST is set Right now there is a bug in makepkg that leaves back an empty src directory if SRCDEST is set. This is purely cosmetic, but lets just politely try to rmdir it and fail silently if its empty or non-existent. Signed-off-by: Levente Polyak <anthraxx(a)archlinux.org> commit 6fffbfbc8af6b1194b977582fe3cb308b550f864 Author: Levente Polyak <anthraxx(a)archlinux.org> Date: Thu Nov 7 22:19:12 2019 +0100 offload-build: catch more signals to be sure SRCPKGDEST gets cleaned It may be not enough to just listen on EXIT depending on the shell used so lets make sure we clean up SRCPKGDEST by listening to more sigs. Signed-off-by: Levente Polyak <anthraxx(a)archlinux.org> ----------------------------------------------------------------------- Summary of changes: .gitignore | 1 + Makefile | 4 +- arch-nspawn.in | 16 ++-- archbuild.in | 2 +- commitpkg.in | 2 +- doc/makerepropkg.1.asciidoc | 38 +++++++++ doc/mkarchroot.1.asciidoc | 3 + lib/common.sh | 2 +- makechrootpkg.in | 18 +++-- makerepropkg.in | 190 ++++++++++++++++++++++++++++++++++++++++++++ mkarchroot.in | 13 ++- offload-build | 6 +- zsh_completion.in | 10 ++- 13 files changed, 280 insertions(+), 25 deletions(-) create mode 100644 doc/makerepropkg.1.asciidoc create mode 100755 makerepropkg.in hooks/post-receive -- The official devtools repository

2 1

[arch-projects] [devtools] [GIT] The official devtools repository branch master updated. 20191130-1-g8d99df6
by Levente Polyak 30 Nov '19

30 Nov '19

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official devtools repository". The branch, master has been updated via 8d99df602d6e5fc377a37f67d0e5ce74c8facecd (commit) from 4c803b9db8f6395c610c96bd090d1ba2ced82a9c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8d99df602d6e5fc377a37f67d0e5ce74c8facecd Author: Levente Polyak <anthraxx(a)archlinux.org> Date: Sat Nov 30 13:44:02 2019 +0100 makechrootpkg: double quote array expansions for checkpkg locations Avoid re-splitting remotepkg elements used for checkpkg conditions. ----------------------------------------------------------------------- Summary of changes: makechrootpkg.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- The official devtools repository

1 0

[arch-projects] [devtools] [GIT] The official devtools repository annotated tag 20191130 created. 20191130
by Levente Polyak 30 Nov '19

30 Nov '19

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official devtools repository". The annotated tag, 20191130 has been created at fca044cc8898ae7f901274bab2da62338f6fcdc1 (tag) tagging 4c803b9db8f6395c610c96bd090d1ba2ced82a9c (commit) replaces 20191016 tagged by Levente Polyak on Sat Nov 30 13:30:39 2019 +0100 - Log ----------------------------------------------------------------- Version 20191130 -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE4kC1fixGMLp2ji8m/BtUfI2BcsgFAl3iYO8ACgkQ/BtUfI2B csg/ww/9Gt6xBhcvMgLduBbiriw+E2lpkR8Mrhv9VT/LnzMrUArvv8sTEE2aeO9P 8WqyrCzGgwTcgryinOy3KuVBxWjllh2tT6GsHp2Mn70Te7rkO2TybigPogTlyVRJ bLvGDuSdjdHUYIL680x6oOMH1vHajZfFo27KoFF1Qu09MnF/Qx6tsNxZ63MQc4oN ZxkmarQTK4/HggfmJdmWCpOyno4tUT56PVeTrS2FKSlthu1iv1+reTgh0y3Ocf7o Yl0eQED3c7bnI3+nqcJmawWTWEVn0aLX5rbWhBBGoA2ih3QZ6fEN5dsY7EjMKca4 C5lipD9ByYSHqDuWiwieHFA6eY9+E9fixCK+hsjGHTU0dhD+WOyusFj6dBhwQSyL 3pbuh84ZfLp2QISiV6VpmIQ9AgX75fIA9FxkEI8RGPGCPF70weTg2u5EJS8W7jbE YJvFmrIaC/0j5+UaYGMx4flPYuvwai6sLDpXjv0xZr5eSXq6OlXlxkZuVUQCsw0R gk1JjvT36j8KKsE0FqLuaVIvg0V8OHu0+EBwJY7DWWcnci7KuyVd9RJRlMbchPvo E5izF+u3ALTWHp/lPP1/C/7bJhYH/iOQFYnF6y2cxw503bcExinUymchIA6cCRFY gt+so+lOUTQKr3k5DJ4LoTummtlSXTJIRCDoeoyEBxGPcboYZmU= =lHvd -----END PGP SIGNATURE----- Daniel M. Capella (2): conf: Sync with pacman 5.2.0-2 commitpkg: Include commit msg arg in first line Eli Schwartz (10): arch-nspawn: restore cachedir handling for host_mirrors arch-nspawn: simplify cachedir/host_mirror parsing use libmakepkg to find and use variables in makepkg.conf Makefile: sort program names arch-nspawn: rely on deduplication to avoid making multiple host_mirror mounts commitpkg: clearly delineate the commit message template and the rationale archbuild: use better umask mkarchroot: support wrapping pacstrap -U makerepropkg: add new program to try to reproducibly build a package doc: add manpage for the new makerepropkg tool Ivy Foster (1): lib/common.sh: do not use colors when running on a dumb terminal Levente Polyak (7): offload-build: catch more signals to be sure SRCPKGDEST gets cleaned offload-build: remove empty src dir when SRCDEST is set completion: reflect new -U mkarchchroot option completion: add makerepropkg zsh completion makechrootpkg: check local pkg versions before downloading for checkpkg makechrootpkg: sync database for checkpkg to avoid nonexistent targets Version 20191130 ----------------------------------------------------------------------- hooks/post-receive -- The official devtools repository

1 0

[arch-projects] [devtools] [PATCH 0/3] New tool,
by Eli Schwartz 21 Nov '19

21 Nov '19

I've finally finished up this thing for testing if a package can be rebuilt reproducibly. It uses makechrootpkg/mkarchroot under the hood, and requires arch-install-scripts >= 23. This, and other commits recently submitted to the list, can be pulled directly from my repository at https://github.com/eli-schwartz/devtools/commits/arch-projects-review Eli Schwartz (3): mkarchroot: support wrapping pacstrap -U makerepropkg: add new program to try to reproducibly build a package doc: add manpage for the new makerepropkg tool Makefile | 2 + doc/makerepropkg.1.asciidoc | 38 ++++++++ doc/mkarchroot.1.asciidoc | 3 + makerepropkg.in | 186 ++++++++++++++++++++++++++++++++++++ mkarchroot.in | 13 ++- 5 files changed, 238 insertions(+), 4 deletions(-) create mode 100644 doc/makerepropkg.1.asciidoc create mode 100755 makerepropkg.in -- 2.24.0

3 7

[arch-projects] [devtools] [GIT] The official devtools repository branch master updated. 20191016-6-g0017263
by Levente Polyak 07 Nov '19

07 Nov '19

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official devtools repository". The branch, master has been updated via 001726337972f35e1907f6460831c3c3c9d656e4 (commit) via 751093eff2cbd0df422b69810787b4fcf3d33208 (commit) via f43a86ee8a3a3bfbdc32c2d70516d945afcd8515 (commit) via 00671765296ad598f392df7a542dbfca48a6e7b7 (commit) via 75d23eec942e7160108ee194894b6b83ed3045d5 (commit) from 6679c28625b1e48bc115290b7c41941366d44a05 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 001726337972f35e1907f6460831c3c3c9d656e4 Author: Eli Schwartz <eschwartz(a)archlinux.org> Date: Fri Aug 9 14:26:57 2019 -0400 Makefile: sort program names Signed-off-by: Eli Schwartz <eschwartz(a)archlinux.org> Signed-off-by: Levente Polyak <anthraxx(a)archlinux.org> commit 751093eff2cbd0df422b69810787b4fcf3d33208 Author: Eli Schwartz <eschwartz(a)archlinux.org> Date: Fri Aug 9 14:31:53 2019 -0400 use libmakepkg to find and use variables in makepkg.conf - drop homebrew function in makechrootpkg - use better mock to find invoking user's $HOME - make offload-build respect makepkg.conf to determine where to sync files, matching the behavior of makechrootpkg Signed-off-by: Eli Schwartz <eschwartz(a)archlinux.org> Signed-off-by: Levente Polyak <anthraxx(a)archlinux.org> commit f43a86ee8a3a3bfbdc32c2d70516d945afcd8515 Author: Eli Schwartz <eschwartz(a)archlinux.org> Date: Wed Oct 2 10:49:32 2019 -0400 arch-nspawn: simplify cachedir/host_mirror parsing consolidate logic flows in the same area for parsing and building arrays. Don't bother having a special function just to build the mount_args array, since we now use the same handling for adding any cachedir (including host mirrors) to the mount arguments, this becomes a trivial for loop -- and it really did not need to be delayed until after the sanity check, anyway. Signed-off-by: Eli Schwartz <eschwartz(a)archlinux.org> Signed-off-by: Levente Polyak <anthraxx(a)archlinux.org> commit 00671765296ad598f392df7a542dbfca48a6e7b7 Author: Eli Schwartz <eschwartz(a)archlinux.org> Date: Wed Oct 2 10:36:53 2019 -0400 arch-nspawn: restore cachedir handling for host_mirrors In commit 27ff286ee78eb2faac803e3ef67f3171ddfa0098, we moved from sourcing the primary cachedir via /etc/pacman.conf, to using the pacman.conf in the workdir. One unanticipated side effect of this was breaking the special host mirrors magic we used to turn a host mirror into a cachedir. It was still processed as a server, but we relied on it being in the host's cachedirs in order to be persisted, and this no longer occurred. Solve this by explicitly adding each host mirror root as a cachedir. Signed-off-by: Eli Schwartz <eschwartz(a)archlinux.org> Signed-off-by: Levente Polyak <anthraxx(a)archlinux.org> commit 75d23eec942e7160108ee194894b6b83ed3045d5 Author: Daniel M. Capella <polyzen(a)archlinux.org> Date: Fri Sep 27 18:55:45 2019 -0400 commitpkg: Include commit msg arg in first line Commit messages belong on the first line, with optional "explanatory text" starting after a blank line: https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html Referencing commit ee970f0bde3c90a0dff909c366d4ab1a1bff9b9d Signed-off-by: Daniel M. Capella <polyzen(a)archlinux.org> Signed-off-by: Levente Polyak <anthraxx(a)archlinux.org> ----------------------------------------------------------------------- Summary of changes: Makefile | 12 ++++++------ arch-nspawn.in | 31 ++++++++++++++----------------- commitpkg.in | 4 ++-- makechrootpkg.in | 34 ++++++---------------------------- offload-build | 9 ++++++++- 5 files changed, 36 insertions(+), 54 deletions(-) hooks/post-receive -- The official devtools repository

1 0

[arch-projects] [devtools] [PATCH] arch-nspawn: rely on deduplication to avoid making multiple host_mirror mounts
by Eli Schwartz 06 Nov '19

06 Nov '19

Instead of comparing exact mirror urls to see if they are in host_mirrors in order to "skip" the official mirrors, simply trim the expected .../os/... pattern match. We already filter duplicate cachedirs. Signed-off-by: Eli Schwartz <eschwartz(a)archlinux.org> --- I wasn't sure of the precise utility of this, but in addition to being a bit simpler, it seems to work around the case of https://github.com/archlinux/devtools/issues/14 (Even though I don't really understand why anyone is using '$repo/os/$arch' for their own Server urls.) arch-nspawn.in | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/arch-nspawn.in b/arch-nspawn.in index 7aa6fd6..198d227 100644 --- a/arch-nspawn.in +++ b/arch-nspawn.in @@ -75,15 +75,13 @@ done while read -r line; do mapfile -t lines < <($pacconf_cmd --config "${pac_conf:-$working_dir/etc/pacman.conf}" \ - --repo $line Server | sed -r 's#(.*/)[^/]+/os/.+#\1$repo/os/$arch#') - if [[ ${lines[0]} != ${host_mirrors[0]} ]]; then - for line in "${lines[@]}"; do - if [[ $line = file://* ]]; then - line=${line#file://} - in_array "$line" "${cache_dirs[@]}" || cache_dirs+=("$line") - fi - done - fi + --repo $line Server | sed -r 's#(.*/)[^/]+/os/.+#\1#') + for line in "${lines[@]}"; do + if [[ $line = file://* ]]; then + line=${line#file://} + in_array "$line" "${cache_dirs[@]}" || cache_dirs+=("$line") + fi + done done < <($pacconf_cmd --config "${pac_conf:-$working_dir/etc/pacman.conf}" --repo-list) mount_args+=("--bind=${cache_dirs[0]//:/\\:}") -- 2.24.0

1 0