- Arch-projects - lists.archlinux.org

[arch-projects] [namcap] [PATCH] Warn for non-unique source filenames
by Simon Doppler 09 Oct '18

09 Oct '18

--- Namcap/rules/pkginfo.py | 9 +++++++++ namcap-tags | 1 + 2 files changed, 10 insertions(+) diff --git a/Namcap/rules/pkginfo.py b/Namcap/rules/pkginfo.py index 216e417..5f90828 100644 --- a/Namcap/rules/pkginfo.py +++ b/Namcap/rules/pkginfo.py @@ -20,6 +20,7 @@ "These rules checks basic sanity of package metadata" import re +import os from Namcap.ruleclass import PkgInfoRule class CapsPkgnameRule(PkgInfoRule): @@ -43,4 +44,12 @@ class LicenseRule(PkgInfoRule): if "license" not in pkginfo or len(pkginfo["license"]) == 0: self.errors.append(("missing-license", ())) +class NonUniqueSourcesRule(PkgInfoRule): + name = "non-unique-source" + description = "Verifies the downloaded sources have a unique filename" + def analyze(self, pkginfo, tar): + for source_file in pkginfo["source"]: + if '::' not in source_file and re.match(r'^[vV]?(([0-9]){8}|([0-9]+\.?)+)\.', os.path.basename(source_file)): + self.warnings.append(("non-unique-source-name %s", os.path.basename(source_file))) + # vim: set ts=4 sw=4 noet: diff --git a/namcap-tags b/namcap-tags index 2133c45..5c236db 100644 --- a/namcap-tags +++ b/namcap-tags @@ -61,6 +61,7 @@ missing-makedeps %s :: Split PKGBUILD needs additional makedepends %s to work pr no-elffiles-not-any-package :: No ELF files and not an "any" package non-fhs-info-page %s :: Non-FHS info page (%s) found. Use /usr/share/info instead non-fhs-man-page %s :: Non-FHS man page (%s) found. Use /usr/share/man instead +non-unique-source-name %s :: Non-unique source name (%s). Use a unique filename. not-a-common-license %s :: %s is not a common license (it's not in /usr/share/licenses/common/) not-enough-checksums %s %i needed :: Not enough %s: %i needed package-name-in-uppercase :: No upper case letters in package names -- 2.19.0

1 1

[arch-projects] [dbscripts] [PATCH 0/4] Refactoring svn calls
by Eli Schwartz 08 Oct '18

08 Oct '18

Having svn code intertwined with everything is complicated and results in it being harder to replace svn with something else. As a first step to hopefully migrating to git, I've refactored everything that directly touched svn to be contained in db-functions-svn, and renamed to be generic enough that any alternative backend should be able to implement some VCS-specific "vcs_*" functions. Also see https://github.com/archlinux/dbscripts/pull/12 Eli Schwartz (4): Preliminary work to break out svn-specific code. Factor out the exporting of files/folders from svn. More work on refactoring svn moving into VCS-agnostic routines. Finish the svn refactor by implementing helper functions to write to the VCS config | 7 ++- cron-jobs/sourceballs | 3 +- db-functions | 50 ++++++-------------- db-functions-svn | 106 ++++++++++++++++++++++++++++++++++++++++++ db-move | 56 ++++++++-------------- db-remove | 12 ++--- db-update | 4 +- testing2x | 37 +++++---------- 8 files changed, 165 insertions(+), 110 deletions(-) create mode 100644 db-functions-svn -- 2.19.1

1 4

[arch-projects] [dbscripts] [GIT] Official repo DB scripts branch master updated. 20180603-6-g971181b
by eschwartz＠archlinux.org 08 Oct '18

08 Oct '18

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Official repo DB scripts". The branch, master has been updated via 971181bf94d5e86bd7fce41303b51d1b3befc85b (commit) via a75e4ee5b440a9d571658cd326f29a625320d777 (commit) via e712811bcacd43ee443b98ad8a03347ce3a63b69 (commit) from 0b630e25a3181d5228cbd99c9041a04b6514fc81 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 971181bf94d5e86bd7fce41303b51d1b3befc85b Author: Luke Shumaker <lukeshu(a)parabola.nu> Date: Fri Jul 13 11:23:42 2018 -0400 test: checkPackageDB(): Resolve "FIXME: We guess the location of the PKGBUILD" The problem statement: checkPackageDB and checkRemovedPackageDB need bit of information on the package they're checking: a full list of pkgnames with that pkgbase, the list of pkgarches, and (for checkPackageDB only) the full version. In dbscripts itself, we can get that directly from the .db files; however, since the test suite is checking the ability of dbscripts to edit those .db files, that's obviously not a good solution. The current solution is to get this information from the PKGBUILD... which we also count on dbscripts to correctly keep track of. Wait, that's skipping ahead, let's back up. The current solution is to get this information from the PKGBUILD. For checkRemovedPackageDB, that's easy; we just get it from trunk, as that's the most up-to-date information on the package as-it-would-have-existed (if that sounded a little hand-wavey, it was). But for checkPackageDB, it's a little trickier, because of 2 factors working together: (1) there might be different versions on different repos, and (2) unlike checkRemovedPackageDB, checkPackageDB actually cares about pkgver. So, checkPackageDB "guesses" the location in a slightly sloppy way, and is tagged with a "FIXME". What todo about it? There are a couple of things to observe: - Hidden in the hand-waving in assuming that "trunk" is fine for checkRemovedPackageDB is the assumption that neither pkgname=() nor arch=() is going to change between versions. Which is a fine assumption, because we don't change those things between versions in any of our test cases. - We're counting on dbscripts correctly keeping track of which PKGBUILD is correct for which repo... which is one of the thing's we're trying to test, we shouldn't be counting on it. That's actually a bigger problem than the original "FIXME"! So, putting those things together, let's (1) take the code under test out of the equation, and (2) remove any suggestion that the version of the PKGBUILD makes a difference to pkgnames/pkgarches: Let's have both functions that that information from the PKGBUILDs under "fixtures/", rather than getting PKGBUILDs from VCS. That just leaves one question: How to get the correct pkgver in checkPackageDB? The obvious answer is: Each test case knows what the version should be; add it as an argument, and adjust every testcase that calls it. commit a75e4ee5b440a9d571658cd326f29a625320d777 Author: Luke Shumaker <lukeshu(a)parabola.nu> Date: Fri Jul 13 18:04:29 2018 -0400 test: Don't use "! cmd" except as the last statement in a function With BATS setting up error traps, we get used to writing simple `[[ foo ]]` assertions and not having to check the result. However, using `!` to invert the result DOESN'T trigger the trap. It works OK when it is the last command in a function, as it still affects the function's return value, so then the trap triggers in the caller (rather than in the function). This means that a check may run successfully when it should fail. So, replace all uses of bare `! cmd` with `if cmd; then return 1; fi`, unless it is the final statement in a function (as it is in sourceballs.bats:__checkRemovedSourcePackage()) The mistake meant that checkRemovedPackage() was effectively equivalent to checkRemovedPackageDB(). This meant that no one noticed that db-updates's "add package with inconsistent name fails" test called checkRemovedPackage instead of checkRemovedPackageDB. Fixing the ! issue means that the test now fails, so change which function it calls. commit e712811bcacd43ee443b98ad8a03347ce3a63b69 Author: Luke Shumaker <lukeshu(a)parabola.nu> Date: Thu Jun 21 22:01:54 2018 -0400 test: db-move: Verify that it works on single-arch packages ----------------------------------------------------------------------- Summary of changes: test/cases/db-move.bats | 35 +++++++++++++++++++++++++++-------- test/cases/db-repo-add.bats | 6 +++--- test/cases/db-update.bats | 24 ++++++++++++------------ test/cases/ftpdir-cleanup.bats | 14 +++++++++----- test/cases/testing2x.bats | 2 +- test/lib/common.bash | 30 ++++++++++-------------------- 6 files changed, 62 insertions(+), 49 deletions(-) hooks/post-receive -- Official repo DB scripts

1 0

[arch-projects] [namcap] [PATCH] Ignore .so for no PIE check
by Jelle van der Waa 11 Sep '18

11 Sep '18

--- Namcap/rules/elffiles.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Namcap/rules/elffiles.py b/Namcap/rules/elffiles.py index d707a58..41fd1cd 100644 --- a/Namcap/rules/elffiles.py +++ b/Namcap/rules/elffiles.py @@ -223,6 +223,8 @@ class NoPIERule(TarballRule): for entry in tar: if not entry.isfile(): continue + if '.so' in entry.name: + continue fp = tar.extractfile(entry) if not is_elf(fp): continue -- 2.18.0

1 0

[arch-projects] [namcap] [PATCH] elffiles: also check DF_BIND_NOW when checking FULL RELRO
by Chih-Hsuan Yen 11 Sep '18

11 Sep '18

Looks like DF_BIND_NOW has the same function as DT_BIND_NOW. --- Namcap/rules/elffiles.py | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/Namcap/rules/elffiles.py b/Namcap/rules/elffiles.py index d707a58..b2ce6ec 100644 --- a/Namcap/rules/elffiles.py +++ b/Namcap/rules/elffiles.py @@ -140,11 +140,16 @@ class ELFGnuRelroRule(TarballRule): description = "Check for FULL RELRO in ELF files." def has_bind_now(self, elffile): + DF_BIND_NOW = 8 + for section in elffile.iter_sections(): if not isinstance(section, DynamicSection): continue - if any(tag.entry.d_tag == 'DT_BIND_NOW' for tag in section.iter_tags()): - return True + for tag in section.iter_tags(): + if tag.entry.d_tag == 'DT_BIND_NOW': + return True + if tag.entry.d_tag == 'DT_FLAGS' and tag.entry.d_val & DF_BIND_NOW: + return True return False def analyze(self, pkginfo, tar): -- 2.19.0

1 0

[arch-projects] [devtools] [PATCH v2 0/3] Add man pages
by Jelle van der Waa 09 Sep '18

09 Sep '18

This is v2 of my man page addition effort, I've switched from mandoc to the much easier asciidoc. Another reason to use asciidoc is that pacman/pacman-contrib also use it. So possible contributors might be more familiar with it. Thanks to Luke Shumaker for some more inspiration for the content! Jelle van der Waa (3): doc: Add lddd man page doc: Add checkpkg man page doc: add find-libprovides man page .gitignore | 1 + Makefile | 23 ++++++++++++++++++-- doc/asciidoc.conf | 37 +++++++++++++++++++++++++++++++++ doc/checkpkg.1.asciidoc | 27 ++++++++++++++++++++++++ doc/find-libprovides.1.asciidoc | 24 +++++++++++++++++++++ doc/footer.asciidoc | 28 +++++++++++++++++++++++++ doc/lddd.1.asciidoc | 25 ++++++++++++++++++++++ 7 files changed, 163 insertions(+), 2 deletions(-) create mode 100644 doc/asciidoc.conf create mode 100644 doc/checkpkg.1.asciidoc create mode 100644 doc/find-libprovides.1.asciidoc create mode 100644 doc/footer.asciidoc create mode 100644 doc/lddd.1.asciidoc -- 2.18.0

1 3

[arch-projects] [dbscripts] [GIT] Official repo DB scripts branch master updated. 20180603-3-g0b630e2
by eschwartz＠archlinux.org 09 Sep '18

09 Sep '18

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Official repo DB scripts". The branch, master has been updated via 0b630e25a3181d5228cbd99c9041a04b6514fc81 (commit) via 57a307d6620d8fbf3bf1c7d01e621022da4f3f29 (commit) from c53352c103e023727ce31e98ca9647bb918a9a5d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0b630e25a3181d5228cbd99c9041a04b6514fc81 Author: anthraxx <anthraxx(a)archlinux.org> Date: Mon Sep 3 13:50:16 2018 +0200 fix potential bsdtar stream close error by grep This silences a useless error message that confuses the user. bsdtar doesn't like it when the stream gets closed before it finishes which may be the case when grep found its match on potentially huge archives. Instead of suppressing the whole stderr , we find all matches with grep, then use a second pass with `tail` to find only the last match, which ensures the stream remains open for bsdtar but we may still catch and see useful messages on stderr. This works because tail has the useful property of not closing early. commit 57a307d6620d8fbf3bf1c7d01e621022da4f3f29 Author: anthraxx <anthraxx(a)archlinux.org> Date: Mon Sep 3 22:01:16 2018 +0200 readme: switch to travis-ci.com build status badge The old travis-ci.org is deprecated and this project was migrated. ----------------------------------------------------------------------- Summary of changes: README.md | 2 +- db-functions | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- Official repo DB scripts

1 0

[arch-projects] [dbscripts] [PATCH 1/2] readme: switch to travis-ci.com build status badge
by anthraxx＠archlinux.org 09 Sep '18

09 Sep '18

From: anthraxx <anthraxx(a)archlinux.org> The old travis-ci.org is deprecated and this project was migrated. --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index c672998..bdd958b 100644 --- a/README.md +++ b/README.md @@ -1,4 +1,4 @@ -# Arch Linux repository management scripts [![Build Status](https://travis-ci.org/archlinux/dbscripts.svg?branch=master)](https… +# Arch Linux repository management scripts [![Build Status](https://travis-ci.com/archlinux/dbscripts.svg?branch=master)](https… ## Configuration * The default configuration can be found in `config`. * An optional `config.local` may override the default configuration. -- 2.18.0

2 6

[arch-projects] [devtools] [PATCH 0/2] [RFC] Add an pages
by Jelle van der Waa 26 Aug '18

26 Aug '18

This patch series intends to be an RFC for adding man pages for every tool provided by devtools. The first man page for lddd is written in mdoc and is lacking a way to reduce duplication of common headers such as BUGS/AUTHORS. Note that the pacman bug motto was re-used, it's up for debate and the same for the bug location. Do we prefer the bugtracker of mailing lists for bug reports? Jelle van der Waa (2): Add lddd manual install man pages Makefile | 5 +++++ doc/lddd.1 | 27 +++++++++++++++++++++++++++ 2 files changed, 32 insertions(+) create mode 100644 doc/lddd.1 -- 2.18.0

3 4

[arch-projects] [dbscripts] [GIT] Official repo DB scripts branch master updated. 20180603-1-gc53352c
by eschwartz＠archlinux.org 26 Aug '18

26 Aug '18

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Official repo DB scripts". The branch, master has been updated via c53352c103e023727ce31e98ca9647bb918a9a5d (commit) from 08995618eb606523b7d05ac987b1243981290839 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c53352c103e023727ce31e98ca9647bb918a9a5d Author: Jelle van der Waa <jelle(a)vdwaa.nl> Date: Sun Aug 26 14:52:59 2018 +0200 cron-jobs: remove unused cron jobs Updating the archweb database is now handled by archweb itself and deployed on the server using a systemd unit/service. These scripts are no longer used. Signed-off-by: Jelle van der Waa <jelle(a)vdwaa.nl> ----------------------------------------------------------------------- Summary of changes: README.md | 6 +--- cron-jobs/update-web-db | 78 ------------------------------------------- cron-jobs/update-web-files-db | 1 - 3 files changed, 1 insertion(+), 84 deletions(-) delete mode 100755 cron-jobs/update-web-db delete mode 120000 cron-jobs/update-web-files-db hooks/post-receive -- Official repo DB scripts

1 0