- Arch-projects - lists.archlinux.org

[arch-projects] [dbscripts] [PATCH 0/1] Update tests to check for glob regression
by Luke Shumaker 16 Feb '18

16 Feb '18

From: Luke Shumaker <lukeshu(a)parabola.nu> This updates the tests to check for the regression we've been discussing. This doesn't include a fix. I haven't looked too closely, or actually tested them, but Eli's fix LGTM so far. Luke Shumaker (1): test: db-update: @test "update same any package to same repository fails": change PKGEXT test/cases/db-update.bats | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) -- 2.16.1

2 4

[arch-projects] [dbscripts] [PATCH] test: fix misuse of $PKGEXT
by Eli Schwartz 16 Feb '18

16 Feb '18

As per the previous commits, this never worked and nobody noticed because the use of globbing was undocumented. Fortunately, we can fix that now, by using the new is_globfile() proxy function. Signed-off-by: Eli Schwartz <eschwartz(a)archlinux.org> --- test/cases/ftpdir-cleanup.bats | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/cases/ftpdir-cleanup.bats b/test/cases/ftpdir-cleanup.bats index 6280ce0..63eed03 100644 --- a/test/cases/ftpdir-cleanup.bats +++ b/test/cases/ftpdir-cleanup.bats @@ -13,8 +13,8 @@ __checkRepoRemovedPackage() { local pkgname for pkgname in $(__getPackageNamesFromPackageBase ${pkgbase}); do - [[ ! -f ${FTP_BASE}/${PKGPOOL}/${pkgname}-*${PKGEXT} ]] - [[ ! -f ${FTP_BASE}/${repo}/os/${repoarch}/${pkgname}-*${PKGEXT} ]] + ! is_globfile "${FTP_BASE}/${PKGPOOL}/${pkgname}"-*${PKGEXT} + ! is_globfile "${FTP_BASE}/${repo}/os/${repoarch}/${pkgname}"-*${PKGEXT} done } -- 2.16.1

1 0

[arch-projects] [dbscripts] [PATCH] Do not support wildcards in PKGEXT, and standardize on xz compression.
by Eli Schwartz 16 Feb '18

16 Feb '18

This results in unpredictable behavior when used across, variously, bash [[, POSIX sh [, and find -name Its usage depended on matching only one result, which is bad practice. Moreover, it never worked in the first place as - The majority of alternative compression extensions available in makepkg do not use *exactly* two chars. - It accepted lots of extensions that aren't valid at all, like for example .pkg.tar.💩z (which is what I think of using nonstandard compression schemes). Since devtools pushes xz, and every single package currently in the repos uses xz, and AFAIK we haven't actually used any others, it makes sense to just assume xz as the only supported PKGEXT. Signed-off-by: Eli Schwartz <eschwartz(a)archlinux.org> --- config | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config b/config index d2c1942..d292c9f 100644 --- a/config +++ b/config @@ -25,7 +25,7 @@ TMPDIR="/var/tmp" ARCHES=(x86_64) DBEXT=".db.tar.gz" FILESEXT=".files.tar.gz" -PKGEXT=".pkg.tar.?z" +PKGEXT=".pkg.tar.xz" SRCEXT=".src.tar.gz" # Allowed licenses: get sourceballs only for licenses in this array -- 2.16.1

2 1

[arch-projects] [dbscripts] [PATCH 0/2] Better handling of PKGEXT
by Luke Shumaker 15 Feb '18

15 Feb '18

From: Luke Shumaker <lukeshu(a)parabola.nu> This fixes a mistake introduced in b61a714 around quoting PKGEXT, then renames PKGEXT to PKGEXT_glob to avoid that type of confusion in the future. Luke Shumaker (2): Don't quote $PKGEXT config: Rename PKGEXT to PKGEXT_glob config | 4 +++- cron-jobs/ftpdir-cleanup | 6 +++--- db-functions | 4 ++-- db-move | 4 ++-- db-update | 8 ++++---- test/cases/db-repo-add.bats | 6 +++--- test/cases/db-update.bats | 2 +- test/cases/ftpdir-cleanup.bats | 4 ++-- test/lib/common.bash | 6 ++++-- 9 files changed, 24 insertions(+), 20 deletions(-) -- Happy hacking, ~ Luke Shumaker

3 10

[arch-projects] [dbscripts] [GIT] Official repo DB scripts branch master updated. 20131102-59-g36b71d3
by eschwartz＠archlinux.org 15 Feb '18

15 Feb '18

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Official repo DB scripts". The branch, master has been updated discards be2971eca4cb08aa5c128d8b206f6943d58a7dd9 (commit) via 36b71d3231aca071ad635b995342b786676ef8fe (commit) via b61a7148eaf546a31597b74d9dd8948e4a39dea1 (commit) via f4f9d1a0099c1f784c4a964e2b5651b56f629b82 (commit) via a7b497e8347fc964f8738d4dfc3c3ef23806fdc7 (commit) via 5afac1ed83479c5ff7aab134b54245ec4f5b59fe (commit) via eec8e35eba84658bdd03230c83f449d2bb437b10 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (be2971eca4cb08aa5c128d8b206f6943d58a7dd9) \ N -- N -- N (36b71d3231aca071ad635b995342b786676ef8fe) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 36b71d3231aca071ad635b995342b786676ef8fe Author: Eli Schwartz <eschwartz(a)archlinux.org> Date: Mon Feb 12 20:53:06 2018 -0500 db-functions: deduplicate some repeated logic reuse getpkgfile() in getpkgfiles() commit b61a7148eaf546a31597b74d9dd8948e4a39dea1 Author: Eli Schwartz <eschwartz(a)archlinux.org> Date: Mon Feb 12 20:50:57 2018 -0500 Use more bashisms Fix numerous instances of POSIX `[ ... ]`, including reliance on ugly deprecated constructs like POSIX `-a`. Since we require bash regardless, it makes sense to take full advantage of it. bash `[[ ... ]]` does not require quoting variables as the shell natively recognizes them as variables rather than expanded strings. Use shell arithmetic rather than test, when checking numerical values. commit f4f9d1a0099c1f784c4a964e2b5651b56f629b82 Author: Eli Schwartz <eschwartz(a)archlinux.org> Date: Mon Feb 12 20:39:30 2018 -0500 Use modern bash to append to strings/arrays. Rather than using ugly hacks like arr[${#arr[*]}]="foo", bash 3.1 has the += operator. Update strings to use the same operator while we are at it. commit a7b497e8347fc964f8738d4dfc3c3ef23806fdc7 Author: Eli Schwartz <eschwartz(a)archlinux.org> Date: Mon Feb 12 19:41:29 2018 -0500 ARCHES is an array, do not attempt to call it as a string This meant only the first array element was checked in check_repo_permission(). Although arguably this should never cause real issues as something else would have to be broken if multiple architectures have different permissions, we should catch this now anyway. commit 5afac1ed83479c5ff7aab134b54245ec4f5b59fe Author: Eli Schwartz <eschwartz(a)archlinux.org> Date: Mon Feb 12 17:53:10 2018 -0500 Update messages to make full use of printf formatters libmakepkg messaging functions provide automatic access to gettext (which we do not currently make use of) in addition to cleanly separating data from message strings. In order for this to work properly, pass argv correctly from die() to libmakepkg's error() commit eec8e35eba84658bdd03230c83f449d2bb437b10 Author: Eli Schwartz <eschwartz(a)archlinux.org> Date: Mon Feb 12 17:21:39 2018 -0500 Use return codes properly when checking for failed commands. Rather than doing a test(1) on the numerical value of the return code, use the `if !` and `||` operators during control flow. ----------------------------------------------------------------------- Summary of changes: config | 2 +- cron-jobs/ftpdir-cleanup | 4 +- cron-jobs/sourceballs | 4 +- cron-jobs/update-web-db | 4 +- db-functions | 177 ++++++++++++++++++++------------------------ db-move | 28 +++---- db-remove | 18 ++--- db-repo-add | 12 +-- db-repo-remove | 8 +- db-update | 47 ++++++------ test/cases/db-repo-add.bats | 2 +- testing2x | 16 ++-- 12 files changed, 151 insertions(+), 171 deletions(-) hooks/post-receive -- Official repo DB scripts

3 3

[arch-projects] [dbscripts] [GIT] Official repo DB scripts branch master updated. 20131102-63-g134aff7
by pierre＠archlinux.org 15 Feb '18

15 Feb '18

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Official repo DB scripts". The branch, master has been updated via 134aff74d16331231ed94f34d8417d1325d4600f (commit) via c7f1d85c0e11aaf3c9acd944388f664aea40037b (commit) via 24671e6cb2fa343fd6f15fe54b16840aed091ad4 (commit) via 883005f5450ed6a278b5cef46be1245783840b29 (commit) from 36b71d3231aca071ad635b995342b786676ef8fe (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 134aff74d16331231ed94f34d8417d1325d4600f Author: Pierre Schmitz <pierre(a)archlinux.de> Date: Thu Feb 15 17:29:57 2018 +0100 Add usage tests commit c7f1d85c0e11aaf3c9acd944388f664aea40037b Author: Pierre Schmitz <pierre(a)archlinux.de> Date: Thu Feb 15 17:07:02 2018 +0100 PR-2: Default to x86_64 for check_packages commit 24671e6cb2fa343fd6f15fe54b16840aed091ad4 Author: Pierre Schmitz <pierre(a)archlinux.de> Date: Thu Feb 15 17:04:29 2018 +0100 PR-2: Allow i686 for tests commit 883005f5450ed6a278b5cef46be1245783840b29 Author: Florian Pritz <bluewind(a)xinu.at> Date: Thu Feb 15 16:01:07 2018 +0100 Remove i686 from config We dropped it long ago and this should be reflected here rather than being changed on our servers only. Signed-off-by: Florian Pritz <bluewind(a)xinu.at> ----------------------------------------------------------------------- Summary of changes: config | 2 +- cron-jobs/check_archlinux/check_packages.py | 8 ++++---- cron-jobs/check_archlinux/parse_pkgbuilds.sh | 2 +- test/cases/common.bats | 10 ++++++++++ test/lib/common.bash | 1 + 5 files changed, 17 insertions(+), 6 deletions(-) create mode 100644 test/cases/common.bats hooks/post-receive -- Official repo DB scripts

1 0

[arch-projects] [dbscripts] [GIT] Official repo DB scripts branch master updated. 20131102-54-gbe2971e
by eschwartz＠archlinux.org 15 Feb '18

15 Feb '18

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Official repo DB scripts". The branch, master has been updated via be2971eca4cb08aa5c128d8b206f6943d58a7dd9 (commit) from 1cad51c5af4b0aa1e1196d737edaa00938af937f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit be2971eca4cb08aa5c128d8b206f6943d58a7dd9 Author: Luke Shumaker <LukeShu(a)sbcglobal.net> Date: Sun May 17 19:44:11 2015 -0400 Use += instead of jumping through hoops. The += operator was introduced in Bash 3.1, and was already used in some places in dbscripts, but not everywhere. For normal strings, this isn't a big deal, but appending to an array without using += is nasty. [gabrielfrancosouza(a)gmail.com: Adjust for removed files] Signed-off-by: Gabriel Souza Franco <gabrielfrancosouza(a)gmail.com> ----------------------------------------------------------------------- Summary of changes: cron-jobs/sourceballs | 6 +++--- db-functions | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) hooks/post-receive -- Official repo DB scripts

1 0

[arch-projects] [dbscripts] [GIT] Official repo DB scripts branch eschwartz/bash-cleanup created. 20131102-59-g3555edf
by eschwartz＠archlinux.org 14 Feb '18

14 Feb '18

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Official repo DB scripts". The branch, eschwartz/bash-cleanup has been created at 3555edf50a5f6ef32f870f7a9199df168bb3d929 (commit) - Log ----------------------------------------------------------------- commit 3555edf50a5f6ef32f870f7a9199df168bb3d929 Author: Eli Schwartz <eschwartz(a)archlinux.org> Date: Mon Feb 12 20:53:06 2018 -0500 db-functions: deduplicate some repeated logic reuse getpkgfile() in getpkgfiles() commit 653056f43d73de53b4fb39ab24afe621f7361cbc Author: Eli Schwartz <eschwartz(a)archlinux.org> Date: Mon Feb 12 20:50:57 2018 -0500 Use more bashisms commit 45d696b3b0bcdf55e53422e2cb9010a017b2153b Author: Eli Schwartz <eschwartz(a)archlinux.org> Date: Mon Feb 12 20:39:30 2018 -0500 Use modern bash to append to strings/arrays. Rather than using ugly hacks like arr[${#arr[*]}]="foo", bash 3.1 has the += operator. Update strings to use the same operator while we are at it. commit f281c1ca6658112ef920792ca208aea7ed81dc7a Author: Luke Shumaker <lukeshu(a)sbcglobal.net> Date: Sun May 17 19:44:18 2015 -0400 db-functions: Fix check_repo_permission checking all architectures It mistakenly looped over just the first element of the ARCHES array, instead of the entire array. This meant that it only checked the permissions for one architecture. Signed-off-by: Gabriel Souza Franco <gabrielfrancosouza(a)gmail.com> commit 86f925da35e50acf62c941a74b47f3bfdb2d9ec3 Author: Eli Schwartz <eschwartz(a)archlinux.org> Date: Mon Feb 12 17:53:10 2018 -0500 Update messages to make full use of printf formatters libmakepkg messaging functions provide automatic access to gettext (which we do not currently make use of) in addition to cleanly separating data from message strings. In order for this to work properly, pass argv correctly from die() to libmakepkg's error() commit c953b0bea48726f9bcd735bde7c1483ddf616195 Author: Eli Schwartz <eschwartz(a)archlinux.org> Date: Mon Feb 12 17:21:39 2018 -0500 Use return codes properly when checking for failed commands. Rather than doing a test(1) on the numerical value of the return code, use the `if !` and `||` operators during control flow. ----------------------------------------------------------------------- hooks/post-receive -- Official repo DB scripts

1 0

[arch-projects] [mkinitcpio] fsck install hook improvements
by Marcos Mello 13 Feb '18

13 Feb '18

- EXT, JFS and ReiserFS cleanup (install main tools and create required symlinks). - Only install /etc/e2fsck.conf for EXT filesystems. - Btrfs and XFS are special: their fscks do nothing (well, at least they show what tool to run). Users need xfs_repair and btrfs installed to try to fix the filesystem from initramfs. These tools do not have a "preen" mode. - Adapt the non-autodetect case accordingly.

2 2

[arch-projects] [devtools] [GIT] The official devtools repository branch bpiotrowski/debug created. 20171108-13-g73b9f7b
by bpiotrowski＠archlinux.org 29 Jan '18

29 Jan '18

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official devtools repository". The branch, bpiotrowski/debug has been created at 73b9f7bfccf277e45f921920cc53d1cfb1331ca7 (commit) - Log ----------------------------------------------------------------- commit 73b9f7bfccf277e45f921920cc53d1cfb1331ca7 Author: Bartłomiej Piotrowski <bpiotrowski(a)archlinux.org> Date: Tue Jan 23 09:46:05 2018 +0100 commitpkg: Use printf format strings for messages about debug packages commit 8455bb165969cccbdb823f3023417ad36299e83b Author: Bartłomiej Piotrowski <bpiotrowski(a)archlinux.org> Date: Mon Jan 15 17:28:17 2018 +0100 commitpkg: Warn about missing debug packages commit 1b9cca80d4ca55f7712dbcaa02172e0d920197cc Author: dequis <dx(a)dxzone.com.ar> Date: Sun Mar 12 21:15:49 2017 -0300 commitpkg: Fix typo in debug package check commit c47fd11bab81f34f62e2e067e5e497cd862e434f Author: Allan McRae <allan(a)archlinux.org> Date: Sun Mar 12 19:20:48 2017 -0300 commitpkg: Upload debug packages if available Debug packages are uploaded to staging/$repo-debug ----------------------------------------------------------------------- hooks/post-receive -- The official devtools repository

1 0