October 2007 - Pacman-dev - lists.archlinux.org

[pacman-dev] [PATCH] Copy pmdelta_t objects in _alpm_pkg_dup().
by Nathan Jones 29 Oct '07

29 Oct '07

_alpm_pkg_dup() should create copies of all objects inside the pmpkg_t struct. I missed this function when adding the delta list to pmpkg_t. Signed-off-by: Nathan Jones <nathanj(a)insightbb.com> --- lib/libalpm/package.c | 19 +++++++++++++++++++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/lib/libalpm/package.c b/lib/libalpm/package.c index 4f6f5a9..7829d48 100644 --- a/lib/libalpm/package.c +++ b/lib/libalpm/package.c @@ -49,6 +49,7 @@ #include "provide.h" #include "handle.h" #include "alpm.h" +#include "delta.h" /** \addtogroup alpm_packages Package Functions * @brief Functions to manipulate libalpm packages @@ -689,6 +690,7 @@ pmpkg_t *_alpm_pkg_new(const char *name, const char *version) pmpkg_t *_alpm_pkg_dup(pmpkg_t *pkg) { pmpkg_t* newpkg; + alpm_list_t *deltas; ALPM_LOG_FUNC; @@ -708,6 +710,23 @@ pmpkg_t *_alpm_pkg_dup(pmpkg_t *pkg) newpkg->groups = alpm_list_strdup(alpm_pkg_get_groups(pkg)); newpkg->provides = alpm_list_strdup(alpm_pkg_get_provides(pkg)); newpkg->replaces = alpm_list_strdup(alpm_pkg_get_replaces(pkg)); + + /* copy all the delta objects */ + newpkg->deltas = NULL; + deltas = alpm_pkg_get_deltas(pkg); + while(deltas) { + pmdelta_t *d = malloc(sizeof(pmdelta_t)); + + if(d == NULL) { + _alpm_log(PM_LOG_ERROR, _("malloc failure: could not allocate %d bytes\n"), sizeof(pmdelta_t)); + RET_ERR(PM_ERR_MEMORY, NULL); + } + + memcpy(d, alpm_list_getdata(deltas), sizeof(pmdelta_t)); + newpkg->deltas = alpm_list_add(newpkg->deltas, d); + deltas = alpm_list_next(deltas); + } + /* internal */ if(newpkg->origin == PKG_FROM_FILE) { newpkg->origin_data.file = strdup(pkg->origin_data.file); -- 1.5.3.4

3 5

[pacman-dev] [GIT] The official pacman repository annotated tag, v3.0.1 now at v3.0.0-16-gef578e7
by Aaron Griffin 29 Oct '07

29 Oct '07

Hello, This is an automated email from the git hooks/update script, it was generated because a ref change was pushed to the repository. Updating annotated tag, v3.0.1, to 23789e0c4ef99bf81235864b287c8ba7f3ec2090 (tag) replaces v3.0.0-15 tagged by Dan McGee <dan(a)archlinux.org> on 2007-10-28 23:48 -0400 - Log ----------------------------------------------------------------- ----------------------------------------------------------------------- hooks/update --- Git Source Code Management System hooks/update refs/tags/v3.0.1 \ 0000000000000000000000000000000000000000 \ 23789e0c4ef99bf81235864b287c8ba7f3ec2090

3 2

[pacman-dev] [GIT] The official pacman repository annotated tag, v3.0.2 now at v3.0.1-17-g75b2001
by Dan McGee 28 Oct '07

28 Oct '07

Hello, This is an automated email from the git hooks/update script, it was generated because a ref change was pushed to the repository. Updating annotated tag, v3.0.2, to 705aa06553481fb8ec452ca0a7c520fdbc8ef345 (tag) replaces v3.0.1-16 tagged by Dan McGee <dan(a)archlinux.org> on 2007-10-28 23:48 -0400 - Log ----------------------------------------------------------------- ----------------------------------------------------------------------- hooks/update --- Git Source Code Management System hooks/update refs/tags/v3.0.2 \ 0000000000000000000000000000000000000000 \ 705aa06553481fb8ec452ca0a7c520fdbc8ef345

1 0

[pacman-dev] [GIT] The official pacman repository annotated tag, v3.0.3 now at v3.0.2-4-gafec5e4
by Dan McGee 28 Oct '07

28 Oct '07

Hello, This is an automated email from the git hooks/update script, it was generated because a ref change was pushed to the repository. Updating annotated tag, v3.0.3, to 1d4251d2ad645bf319b27d8d16db70474fffff93 (tag) replaces v3.0.2-3 tagged by Dan McGee <dan(a)archlinux.org> on 2007-10-28 23:50 -0400 - Log ----------------------------------------------------------------- ----------------------------------------------------------------------- hooks/update --- Git Source Code Management System hooks/update refs/tags/v3.0.3 \ 0000000000000000000000000000000000000000 \ 1d4251d2ad645bf319b27d8d16db70474fffff93

1 0

[pacman-dev] [GIT] The official pacman repository annotated tag, v3.0.4 now at v3.0.3-4-g8be3f1f
by Aaron Griffin 28 Oct '07

28 Oct '07

Hello, This is an automated email from the git hooks/update script, it was generated because a ref change was pushed to the repository. Updating annotated tag, v3.0.4, to 7bc12516cd16636dbdeef222b453f72b1706b0e9 (tag) replaces v3.0.3-3 tagged by Dan McGee <dan(a)archlinux.org> on 2007-10-28 23:50 -0400 - Log ----------------------------------------------------------------- ----------------------------------------------------------------------- hooks/update --- Git Source Code Management System hooks/update refs/tags/v3.0.4 \ 0000000000000000000000000000000000000000 \ 7bc12516cd16636dbdeef222b453f72b1706b0e9

1 0

[pacman-dev] [GIT] The official pacman repository annotated tag, v3.0.5 now at v3.0.4-5-g0cfb412
by Dan McGee 28 Oct '07

28 Oct '07

Hello, This is an automated email from the git hooks/update script, it was generated because a ref change was pushed to the repository. Updating annotated tag, v3.0.5, to 77fa42dd001ecf309af7f72faeccd101f0d7c9f4 (tag) replaces v3.0.4-4 tagged by Dan McGee <dan(a)archlinux.org> on 2007-10-28 23:50 -0400 - Log ----------------------------------------------------------------- ----------------------------------------------------------------------- hooks/update --- Git Source Code Management System hooks/update refs/tags/v3.0.5 \ 0000000000000000000000000000000000000000 \ 77fa42dd001ecf309af7f72faeccd101f0d7c9f4

1 0

[pacman-dev] [GIT] The official pacman repository annotated tag, v3.0.6 now at v3.0.5-7-ga06d91f
by Dan McGee 28 Oct '07

28 Oct '07

Hello, This is an automated email from the git hooks/update script, it was generated because a ref change was pushed to the repository. Updating annotated tag, v3.0.6, to 723b37f6fac724405d9fe5abf75b46d0e7a0adda (tag) replaces v3.0.5-6 tagged by Dan McGee <dan(a)archlinux.org> on 2007-10-28 23:51 -0400 - Log ----------------------------------------------------------------- ----------------------------------------------------------------------- hooks/update --- Git Source Code Management System hooks/update refs/tags/v3.0.6 \ 0000000000000000000000000000000000000000 \ 723b37f6fac724405d9fe5abf75b46d0e7a0adda

1 0

[pacman-dev] [GIT] The official pacman repository branch, master now at v3.0.0-492-g671224b
by Dan McGee 28 Oct '07

28 Oct '07

Hello, This is an automated email from the git hooks/update script, it was generated because a ref change was pushed to the repository. Updating branch, master, via 671224b64c9478644125deec1496a27e8f579da9 (commit) via 0dc34f496dca3d916eae85a0357049b8b9d711bb (commit) via 3e3e7a97a629cc86a53044766039c66d85cf67cb (commit) via 8a9c83dd4bffff575a21207248e7acaae5a0d6f9 (commit) via 3e1b72f4f2b3f8766f9ad3493ad736d81263c9c1 (commit) via a8731ff2f7be564b745a4447df9c2157c5ee0777 (commit) via b38e046621e173a1194eb354e6b8d2525fa60242 (commit) via 17f99a0f0042efeb4c5822a6446918f1ac852e32 (commit) via d903fc607ee2aa2527202f1e54a44be325eabe48 (commit) via b609cb0a5dfe595318975dfe4c6c37a168b7d979 (commit) from 0cff7c6bdf5461c3286edc940aabb88d63345381 (commit) - Log ----------------------------------------------------------------- commit 671224b64c9478644125deec1496a27e8f579da9 Author: Dan McGee <dan(a)archlinux.org> Date: Sun Oct 28 22:24:11 2007 -0500 pactest: generate the filelist the correct way Actually use python commands to generate the filelist instead of os.system calls that don't necessarily work everywhere. Noticed when running "make check" on FreeBSD where the tar program is actually bsdtar. Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 0dc34f496dca3d916eae85a0357049b8b9d711bb Author: Chantry Xavier <shiningxc(a)gmail.com> Date: Sun Oct 28 13:37:49 2007 +0100 extend type001 pactest with a symlink. Signed-off-by: Chantry Xavier <shiningxc(a)gmail.com> commit 3e3e7a97a629cc86a53044766039c66d85cf67cb Author: Dan McGee <dan(a)archlinux.org> Date: Sun Oct 28 21:18:39 2007 -0500 makepkg: add explicit dir to find calls Some of the find calls did not have a path, which isn't valid in some versions of the find utility. Add a . for compatibility. Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 8a9c83dd4bffff575a21207248e7acaae5a0d6f9 Author: Scott Horowitz <stonecrest(a)gmail.com> Date: Fri Oct 26 20:32:09 2007 -0600 Integrate versionpkg into makepkg If PKGBUILDs use the correct svn/cvs/etc variables, determine the latest revision number and force this as the pkgver for building. Signed-off-by: Scott Horowitz <stonecrest(a)gmail.com> Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 3e1b72f4f2b3f8766f9ad3493ad736d81263c9c1 Author: Dan McGee <dan(a)archlinux.org> Date: Fri Oct 26 20:40:20 2007 -0500 Clean up LDADD usage We had a lot of unnecessary overstatements of libraries to include on linking, and autoconf/automake takes care of this for us. This also helps some compilation issues on other platforms. Signed-off-by: Dan McGee <dan(a)archlinux.org> commit a8731ff2f7be564b745a4447df9c2157c5ee0777 Author: Dan McGee <dan(a)archlinux.org> Date: Fri Oct 26 20:31:25 2007 -0500 Fix mcheck detection and usage Signed-off-by: Dan McGee <dan(a)archlinux.org> commit b38e046621e173a1194eb354e6b8d2525fa60242 Author: Dan McGee <dan(a)archlinux.org> Date: Fri Oct 26 19:09:21 2007 -0500 Explicitly cast void* to char* during printf call If we don't have an explicit cast, make fails during -Wall -Werror. Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 17f99a0f0042efeb4c5822a6446918f1ac852e32 Author: Nagy Gabor <ngaba(a)bibl.u-szeged.hu> Date: Fri Oct 26 16:37:47 2007 +0200 dependency error message fix in libalpm/remove.c Normally you must never see that error message. Signed-off-by: Dan McGee <dan(a)archlinux.org> commit d903fc607ee2aa2527202f1e54a44be325eabe48 Author: Nagy Gabor <ngaba(a)bibl.u-szeged.hu> Date: Sat Oct 27 01:14:35 2007 +0200 Dependency error/log messages fix The old code used only the depend.name in messages, which might have not been informative. The new code uses the whole dependency string in %DEPENDS% format. (Dan: slight English clarification in one of the messages) Signed-off-by: Dan McGee <dan(a)archlinux.org> commit b609cb0a5dfe595318975dfe4c6c37a168b7d979 Author: Dan McGee <dan(a)archlinux.org> Date: Fri Oct 26 18:36:08 2007 -0500 makepkg: readd -p option that was lost in getopt conversion The -p option was accidentally dropped in commit 54b71f0427e87e6d525423df06f8a06f2b71c518. Readd it. Signed-off-by: Dan McGee <dan(a)archlinux.org> ----------------------------------------------------------------------- Diffstat: configure.ac | 12 +++-- lib/libalpm/Makefile.am | 1 - lib/libalpm/deps.c | 18 +++++--- lib/libalpm/remove.c | 2 +- lib/libalpm/sync.c | 4 +- pactest/pmpkg.py | 22 ++++++++--- pactest/tests/type001.py | 14 ++++-- scripts/makepkg.sh.in | 97 ++++++++++++++++++++++++++++++++++++++++++--- src/pacman/Makefile.am | 6 +-- src/pacman/pacman.c | 4 +- src/util/testdb.c | 4 +- 11 files changed, 144 insertions(+), 40 deletions(-) hooks/update --- Git Source Code Management System hooks/update refs/heads/master \ 0cff7c6bdf5461c3286edc940aabb88d63345381 \ 671224b64c9478644125deec1496a27e8f579da9

1 0

Re: [pacman-dev] [tur-users] A Note about Groups
by Jeff 'codemac' Mickey 28 Oct '07

28 Oct '07

* On Sunday, October 28 2007, Alessio 'mOLOk' Bolognino wrote: >On Mon 2007-10-22 11:21 , Aaron Griffin wrote: >> This is just a note for all of you guys. >> Please DO NOT stick community packages in official groups. This is >> ESPECIALLY important for the base and base-devel groups. >> [...] > >So we can't use, say "vim-plugins' ? That's exactly what I was thinking... I think the stance should be DO NOT put community packages in official groups unless we developers know about it. There are some very "crucial" groups that should not be messed with as the selinux packages make proof of, but why can't packages in [community] be part of something like vim-pulgins? I think this is actually a design flaw in how pacman handles repositories. I think groups should not span repositories. But maybe this is a discussion for the pacman-dev list. Cc'd! // jeff -- .: [ + carpe diem totus tuus + ] :.

1 0

[pacman-dev] dbs should be locked between _alpm_db_open and _alpm_db_close
by Nagy Gabor 27 Oct '07

27 Oct '07

Hi! The problem bellow doesn't appear with the current dummy front-end, but if you want to design a flexible alpm lib, you have to deal with it. The main problem, that the whole pkgcache concept _assumes_ that the db won't be modified by other processes. However, pacman locks db iff he modifies it, so he cannot trust his assumption. Let me explain. Imagine a nice pacman GUI which starts with alpm_initialize, opens the databases and let user do multiple operations. pacman_gui can run all the day, without unregistering the databases, alpm_release etc. etc. The main problem, that if pacman_gui (== libalpm) let an other pacman instance to modify the local db, he should always reload the pkgcache, because it may be outdated! So the following situation can happen: pacman_gui loaded the pkgcache to list the available local packages to the user, and now he is waiting. During this an other pacman instance removed lot of packages (he could lock anf unlock the db, since pacman_gui didn't lock anything yet) and exited. pacman_gui didn't detect anything from this. Now the user ask pacman_gui to install some packages: now he locks the dbs, but he trust its outdated pkgcache: for example its depchecks will use this outdated information... So _alpm_db_open should lock database, and _alpm_db_close should unlock it. The problem here, that now a non-root user cannot write /var/lib/pacman/local/db.lck, but we can solve this somehow. (Note, that I'm suggesting a lock-per-db method here.) Another (not-so-strict but slower) possible solution a .lastupdate-like method to detect if the database was modified or not after pkgcache load, and reload if needed. Bye, ngaba ---------------------------------------------------- SZTE Egyetemi Könyvtár - http://www.bibl.u-szeged.hu This mail sent through IMP: http://horde.org/imp/

2 2