July 2008 - Pacman-dev - lists.archlinux.org

[pacman-dev] [PATCH] sync_addtarget rework
by Nagy Gabor 08 Jul '08

08 Jul '08

From 6541daa508b3f4d050db61f7212fcedf45ab0120 Mon Sep 17 00:00:00 2001 From: Nagy Gabor <ngaba(a)bibl.u-szeged.hu> Date: Sat, 5 Jul 2008 12:53:55 +0200 Subject: [PATCH] sync_addtarget rework Now '-S provision' handling is done in the back-end. In case of multiple providers, the first one is selected (behavior change: deleted provision002.py). The old processing order was: literal, group, provision; the new one: literal, provision, group; this is more rational, but "pacman -S group" will be slower now. Now "pacman -S repo/provision" also works. Provision was generalized to dependencies, so "pacman -S 'bash>2.0'" or "pacman -S 'core/bash>2.0'" also works; this can be useful in makepkg dependency resolving. Signed-off-by: Nagy Gabor <ngaba(a)bibl.u-szeged.hu> --- lib/libalpm/deps.c | 19 +++++++++-- lib/libalpm/sync.c | 68 +++++++++++++++-------------------------- pactest/tests/provision002.py | 15 --------- src/pacman/sync.c | 38 ++--------------------- 4 files changed, 43 insertions(+), 97 deletions(-) delete mode 100644 pactest/tests/provision002.py diff --git a/lib/libalpm/deps.c b/lib/libalpm/deps.c index 1a6da96..e042166 100644 --- a/lib/libalpm/deps.c +++ b/lib/libalpm/deps.c @@ -544,8 +544,14 @@ pmpkg_t *_alpm_resolvedep(pmdepend_t *dep, alpm_list_t *dbs, alpm_list_t *exclud if(pkg && alpm_depcmp(pkg, dep) && !_alpm_pkg_find(excluding, pkg->name)) { if(_alpm_pkg_should_ignore(pkg)) { int install; - QUESTION(handle->trans, PM_TRANS_CONV_INSTALL_IGNOREPKG, tpkg, - pkg, NULL, &install); + /* wow, we have a very stupid callback API here */ + if(tpkg) { + QUESTION(handle->trans, PM_TRANS_CONV_INSTALL_IGNOREPKG, tpkg, + pkg, NULL, &install); + } else { + QUESTION(handle->trans, PM_TRANS_CONV_INSTALL_IGNOREPKG, pkg, + NULL, NULL, &install); + } if(!install) { continue; } @@ -561,8 +567,13 @@ pmpkg_t *_alpm_resolvedep(pmdepend_t *dep, alpm_list_t *dbs, alpm_list_t *exclud !_alpm_pkg_find(excluding, pkg->name)) { if(_alpm_pkg_should_ignore(pkg)) { int install; - QUESTION(handle->trans, PM_TRANS_CONV_INSTALL_IGNOREPKG, tpkg, - pkg, NULL, &install); + if(tpkg) { + QUESTION(handle->trans, PM_TRANS_CONV_INSTALL_IGNOREPKG, tpkg, + pkg, NULL, &install); + } else { + QUESTION(handle->trans, PM_TRANS_CONV_INSTALL_IGNOREPKG, pkg, + NULL, NULL, &install); + } if(!install) { continue; } diff --git a/lib/libalpm/sync.c b/lib/libalpm/sync.c index 9336a2e..74fb7b1 100644 --- a/lib/libalpm/sync.c +++ b/lib/libalpm/sync.c @@ -272,65 +272,54 @@ int _alpm_sync_addtarget(pmtrans_t *trans, pmdb_t *db_local, alpm_list_t *dbs_sy char *targline; char *targ; alpm_list_t *j; - pmpkg_t *local; - pmpkg_t *spkg = NULL; - pmsyncpkg_t *sync; - int repo_found = 0; + pmpkg_t *local, *spkg; + pmdepend_t *dep; /* provisions and dependencies are also allowed */ ALPM_LOG_FUNC; ASSERT(db_local != NULL, RET_ERR(PM_ERR_DB_NULL, -1)); ASSERT(trans != NULL, RET_ERR(PM_ERR_TRANS_NULL, -1)); ASSERT(name != NULL, RET_ERR(PM_ERR_WRONG_ARGS, -1)); - STRDUP(targline, name, RET_ERR(PM_ERR_MEMORY, -1)); + STRDUP(targline, name, RET_ERR(PM_ERR_MEMORY, -1)); targ = strchr(targline, '/'); if(targ) { /* we are looking for a package in a specific database */ + alpm_list_t *dbs = NULL; *targ = '\0'; targ++; - _alpm_log(PM_LOG_DEBUG, "searching for target '%s' in repo\n", targ); - for(j = dbs_sync; j && !spkg; j = j->next) { + _alpm_log(PM_LOG_DEBUG, "searching for target '%s' in repo '%s'\n", targ, targline); + for(j = dbs_sync; j; j = j->next) { pmdb_t *db = j->data; if(strcmp(db->treename, targline) == 0) { - repo_found = 1; - spkg = _alpm_db_get_pkgfromcache(db, targ); - if(spkg == NULL) { - pm_errno = PM_ERR_PKG_NOT_FOUND; - goto error; - } + dbs = alpm_list_add(NULL, db); + break; } } - if(!repo_found) { + if(dbs == NULL) { _alpm_log(PM_LOG_ERROR, _("repository '%s' not found\n"), targline); - pm_errno = PM_ERR_PKG_REPO_NOT_FOUND; - goto error; + FREE(targline); + RET_ERR(PM_ERR_PKG_REPO_NOT_FOUND, -1); } + dep = _alpm_splitdep(targ); + spkg = _alpm_resolvedep(dep, dbs, NULL, NULL); + _alpm_dep_free(dep); + alpm_list_free(dbs); } else { - targ = targline; - for(j = dbs_sync; j && !spkg; j = j->next) { - pmdb_t *db = j->data; - spkg = _alpm_db_get_pkgfromcache(db, targ); - } - if(spkg == NULL) { - pm_errno = PM_ERR_PKG_NOT_FOUND; - goto error; - } + dep = _alpm_splitdep(targline); + spkg = _alpm_resolvedep(dep, dbs_sync, NULL, NULL); + _alpm_dep_free(dep); } + FREE(targline); + if(spkg == NULL) { + RET_ERR(PM_ERR_PKG_NOT_FOUND, -1); + } + if(_alpm_sync_find(trans->packages, alpm_pkg_get_name(spkg))) { - FREE(targline); RET_ERR(PM_ERR_TRANS_DUP_TARGET, -1); } - if(_alpm_pkg_should_ignore(spkg)) { - int resp; - QUESTION(trans, PM_TRANS_CONV_INSTALL_IGNOREPKG, spkg, NULL, NULL, &resp); - if (!resp) { - return(0); - } - } - local = _alpm_db_get_pkgfromcache(db_local, alpm_pkg_get_name(spkg)); if(local) { if(_alpm_pkg_compare_versions(local, spkg) == 0) { @@ -349,22 +338,15 @@ int _alpm_sync_addtarget(pmtrans_t *trans, pmdb_t *db_local, alpm_list_t *dbs_sy } /* add the package to the transaction */ - sync = _alpm_sync_new(PM_PKG_REASON_EXPLICIT, spkg, NULL); + pmsyncpkg_t *sync = _alpm_sync_new(PM_PKG_REASON_EXPLICIT, spkg, NULL); if(sync == NULL) { - goto error; + return(-1); } _alpm_log(PM_LOG_DEBUG, "adding target '%s' to the transaction set\n", alpm_pkg_get_name(spkg)); trans->packages = alpm_list_add(trans->packages, sync); - FREE(targline); return(0); - -error: - if(targline) { - FREE(targline); - } - return(-1); } /* Helper functions for alpm_list_remove diff --git a/pactest/tests/provision002.py b/pactest/tests/provision002.py deleted file mode 100644 index 32bc4b8..0000000 --- a/pactest/tests/provision002.py +++ /dev/null @@ -1,15 +0,0 @@ -self.description = "-S provision" - -sp = pmpkg("pkg1") -sp.provides = ["provision=1.0-1"] -self.addpkg2db("sync", sp) - -sp = pmpkg("pkg2") -sp.provides = ["provision=1.0-1"] -self.addpkg2db("sync", sp) - -self.args = "-S provision" - -self.addrule("PACMAN_RETCODE=1") -self.addrule("!PKG_EXIST=pkg1") -self.addrule("!PKG_EXIST=pkg2") diff --git a/src/pacman/sync.c b/src/pacman/sync.c index 47ab4eb..6877d85 100644 --- a/src/pacman/sync.c +++ b/src/pacman/sync.c @@ -617,41 +617,9 @@ static int sync_trans(alpm_list_t *targets) } } if(!found) { - /* targ not found in sync db, searching for providers... */ - alpm_list_t *prov = NULL; - for(j = sync_dbs; j; j = alpm_list_next(j)) { - pmdb_t *db = alpm_list_getdata(j); - alpm_list_t *dblist = alpm_db_getpkgcache(db); - alpm_list_t *satisfiers = alpm_find_pkg_satisfiers(dblist, targ); - prov = alpm_list_join(prov, satisfiers); - } - if(prov != NULL) { - if(alpm_list_count(prov) == 1) { - const char *pname = NULL; - pmpkg_t *pkg = alpm_list_getdata(prov); - pname = alpm_pkg_get_name(pkg); - alpm_list_free(prov); - printf(_("Warning: %s provides %s\n"), pname, targ); - targets = alpm_list_add(targets, strdup(pname)); - } else { - alpm_list_t *k; - pm_fprintf(stderr, PM_LOG_ERROR, - _("several packages provide %s, please specify one :\n"), targ); - for(k = prov; k; k = alpm_list_next(k)) { - pmpkg_t *pkg = alpm_list_getdata(k); - printf("%s ", alpm_pkg_get_name(pkg)); - } - printf("\n"); - alpm_list_free(prov); - retval = 1; - goto cleanup; - } - } else { - pm_fprintf(stderr, PM_LOG_ERROR, - _("'%s': not found in sync db\n"), targ); - retval = 1; - goto cleanup; - } + pm_fprintf(stderr, PM_LOG_ERROR, _("'%s': not found in sync db\n"), targ); + retval = 1; + goto cleanup; } } } -- 1.5.6.1

3 2

[pacman-dev] [PATCH] Add some verbosity to "-S provision" and "-S group"
by Nagy Gabor 08 Jul '08

08 Jul '08

From f96b366e8b0e2fb3a74e3647e5e07ecd5b78430e Mon Sep 17 00:00:00 2001 From: Nagy Gabor <ngaba(a)bibl.u-szeged.hu> Date: Sat, 5 Jul 2008 14:55:18 +0200 Subject: [PATCH] Add some verbosity to "-S provision" and "-S group" sync_addtarget rework removed the "warning: foo provides bar" message. This was reimplemented (which means, that resolvedeps will also print this message), and "fallback to group" message was also added. Signed-off-by: Nagy Gabor <ngaba(a)bibl.u-szeged.hu> --- lib/libalpm/deps.c | 2 ++ src/pacman/sync.c | 2 +- 2 files changed, 3 insertions(+), 1 deletions(-) diff --git a/lib/libalpm/deps.c b/lib/libalpm/deps.c index b58deea..4b99f5f 100644 --- a/lib/libalpm/deps.c +++ b/lib/libalpm/deps.c @@ -552,6 +552,8 @@ pmpkg_t *_alpm_resolvedep(pmdepend_t *dep, alpm_list_t *dbs, alpm_list_t *exclud continue; } } + _alpm_log(PM_LOG_WARNING, _("provider package was selected (%s provides %s)\n"), + pkg->name, dep->name); return(pkg); } } diff --git a/src/pacman/sync.c b/src/pacman/sync.c index 6877d85..1e2af45 100644 --- a/src/pacman/sync.c +++ b/src/pacman/sync.c @@ -583,7 +583,7 @@ static int sync_trans(alpm_list_t *targets) goto cleanup; } /* target not found: check if it's a group */ - + printf(_("%s package not found, searching for group...\n"), targ); for(j = sync_dbs; j; j = alpm_list_next(j)) { pmdb_t *db = alpm_list_getdata(j); grp = alpm_db_readgrp(db, targ); -- 1.5.6.1

2 1

[pacman-dev] vercmp behavior changed on "1.5b versus 1.5" compare
by Nagy Gabor 07 Jul '08

07 Jul '08

Hi! I hope this wasn't discussed here earlier, I haven't followed this thread lately. I think I said everything in subject, the old vercmp said that 1.5b<1.5, the new one says 1.5b>1.5. The same for 1.5b versus 1.5. Bye ---------------------------------------------------- SZTE Egyetemi Könyvtár - http://www.bibl.u-szeged.hu This mail sent through IMP: http://horde.org/imp/

4 7

[pacman-dev] [PATCH] Resolvedeps rework
by Nagy Gabor 05 Jul '08

05 Jul '08

From 08ea7d37ae38f26d24ba2d3aba5f7272dee2ab73 Mon Sep 17 00:00:00 2001 From: Nagy Gabor <ngaba(a)bibl.u-szeged.hu> Date: Fri, 4 Jul 2008 20:18:00 +0200 Subject: [PATCH] Resolvedeps rework I divided resolvedeps into 2 functions. The new _alpm_resolvedep function will resolve one dependency, for example the 'foo>=1.0-1' dependency. It can be useful in sync_addtarget refactoring. The resolvedeps parameters were changed, to be coherent with recursedeps: * the target-list is an alpm_list* instead of alpm_list**. This is OK, because alpm_list_add == alpm_list_add_last * syncpkg param was removed. list contains the to-be-installed packages, resolvedeps will add the required dependencies into this list * trans param was removed, it was used in QUESTION() only, which can be used on the main (handle->trans) transaction only (because the front-end cannot access our pseudo-transactions at all!) The patch fixes some wrong dynamic pmdepmissing_t usage. sync1003.py now fails. This is not a bug, but a behavior change, which needs some explanation: The old resolvedeps didn't elect packages from 'remove' list. I've dropped this (but can be reimplemented trivially by adding a 2nd excluding list param to _alpm_resolvedep), because I don't want that 2nd excluding list param. In fact, in real life, we ~never need this rule. Resolvedeps is called before checkconflicts, so only -Su's %REPLACES% packages are sitting in 'remove' list. This means, that we have the replacement packages in our target list. Usually "foo replaces bar" means, that bar isn't in our repos any more, so resolvedeps *cannot* elect it; but usually it won't try it at all, because foo is in the target list, and it is expected to satisfy 'bar>=1.0-1'-like dependencies too. In exotic cases this is not true (like in sync1003.py), then resolvedeps elect bar (new version). Since checkdeps and checkconflicts is done after resolvedeps, this cannot cause any harm. (In sync1003.py pacman simply removes and reinstalls pkg2 now.) Signed-off-by: Nagy Gabor <ngaba(a)bibl.u-szeged.hu> --- lib/libalpm/deps.c | 189 ++++++++++++++++++++++------------------------------ lib/libalpm/deps.h | 6 +- lib/libalpm/sync.c | 12 +-- 3 files changed, 86 insertions(+), 121 deletions(-) diff --git a/lib/libalpm/deps.c b/lib/libalpm/deps.c index e67b008..1a6da96 100644 --- a/lib/libalpm/deps.c +++ b/lib/libalpm/deps.c @@ -534,137 +534,106 @@ void _alpm_recursedeps(pmdb_t *db, alpm_list_t *targs, int include_explicit) } } -/* populates *list with packages that need to be installed to satisfy all - * dependencies (recursive) for syncpkg +/* helper function for resolvedeps: search for dep satisfier in dbs */ +pmpkg_t *_alpm_resolvedep(pmdepend_t *dep, alpm_list_t *dbs, alpm_list_t *excluding, pmpkg_t *tpkg) +{ + alpm_list_t *i, *j; + /* 1. literals */ + for(i = dbs; i; i = i->next) { + pmpkg_t *pkg = _alpm_db_get_pkgfromcache(i->data, dep->name); + if(pkg && alpm_depcmp(pkg, dep) && !_alpm_pkg_find(excluding, pkg->name)) { + if(_alpm_pkg_should_ignore(pkg)) { + int install; + QUESTION(handle->trans, PM_TRANS_CONV_INSTALL_IGNOREPKG, tpkg, + pkg, NULL, &install); + if(!install) { + continue; + } + } + return(pkg); + } + } + /* 2. satisfiers (skip literals here) */ + for(i = dbs; i; i = i->next) { + for(j = _alpm_db_get_pkgcache(i->data); j; j = j->next) { + pmpkg_t *pkg = j->data; + if(alpm_depcmp(pkg, dep) && strcmp(pkg->name, dep->name) && + !_alpm_pkg_find(excluding, pkg->name)) { + if(_alpm_pkg_should_ignore(pkg)) { + int install; + QUESTION(handle->trans, PM_TRANS_CONV_INSTALL_IGNOREPKG, tpkg, + pkg, NULL, &install); + if(!install) { + continue; + } + } + return(pkg); + } + } + } + return(NULL); +} + +/* populates list with packages that need to be installed to satisfy all + * dependencies of packages in list * * @param remove contains packages elected for removal - * make sure **list is already initialized */ -int _alpm_resolvedeps(pmdb_t *local, alpm_list_t *dbs_sync, pmpkg_t *syncpkg, - alpm_list_t **list, alpm_list_t *remove, pmtrans_t *trans, alpm_list_t **data) +int _alpm_resolvedeps(pmdb_t *local, alpm_list_t *dbs_sync, alpm_list_t *list, + alpm_list_t *remove, alpm_list_t **data) { - alpm_list_t *i, *j, *k; + alpm_list_t *i, *j; alpm_list_t *targ; alpm_list_t *deps = NULL; ALPM_LOG_FUNC; - if(local == NULL || dbs_sync == NULL || syncpkg == NULL || list == NULL) { + if(local == NULL || dbs_sync == NULL) { return(-1); } _alpm_log(PM_LOG_DEBUG, "started resolving dependencies\n"); - targ = alpm_list_add(NULL, syncpkg); - deps = alpm_checkdeps(local, 0, remove, targ); - alpm_list_free(targ); - - if(deps == NULL) { - return(0); - } - - for(i = deps; i; i = i->next) { - int found = 0; - pmdepmissing_t *miss = i->data; - pmdepend_t *missdep = alpm_miss_get_dep(miss); - pmpkg_t *sync = NULL; - - /* check if one of the packages in *list already satisfies this dependency */ - for(j = *list; j && !found; j = j->next) { - pmpkg_t *sp = j->data; - if(alpm_depcmp(sp, missdep)) { - char *missdepstring = alpm_dep_get_string(missdep); - _alpm_log(PM_LOG_DEBUG, "%s satisfies dependency %s -- skipping\n", - alpm_pkg_get_name(sp), missdepstring); - free(missdepstring); - found = 1; - } - } - if(found) { - continue; - } - - /* find the package in one of the repositories */ - /* check literals */ - for(j = dbs_sync; j && !found; j = j->next) { - sync = _alpm_db_get_pkgfromcache(j->data, missdep->name); - if(!sync) { + for(i = list; i; i = i->next) { + pmpkg_t *tpkg = i->data; + targ = alpm_list_add(NULL, tpkg); + deps = alpm_checkdeps(local, 0, remove, targ); + alpm_list_free(targ); + for(j = deps; j; j = j->next) { + pmdepmissing_t *miss = j->data; + pmdepend_t *missdep = alpm_miss_get_dep(miss); + /* check if one of the packages in list already satisfies this dependency */ + if(_alpm_find_dep_satisfier(list, missdep)) { continue; } - found = alpm_depcmp(sync, missdep) && !_alpm_pkg_find(remove, alpm_pkg_get_name(sync)) - && !_alpm_pkg_find(*list, alpm_pkg_get_name(sync)); - if(!found) { - continue; - } - /* If package is in the ignorepkg list, ask before we pull it */ - if(_alpm_pkg_should_ignore(sync)) { - pmpkg_t *dummypkg = _alpm_pkg_new(); - STRDUP(dummypkg->name, miss->target, RET_ERR(PM_ERR_MEMORY, -1)); - QUESTION(trans, PM_TRANS_CONV_INSTALL_IGNOREPKG, dummypkg, sync, NULL, &found); - _alpm_pkg_free(dummypkg); - } - } - /*TODO this autoresolves the first 'satisfier' package... we should fix this - * somehow */ - /* check provides */ - /* we don't check literals again to avoid duplicated PM_TRANS_CONV_INSTALL_IGNOREPKG messages */ - for(j = dbs_sync; j && !found; j = j->next) { - for(k = _alpm_db_get_pkgcache(j->data); k && !found; k = k->next) { - sync = k->data; - if(!sync) { - continue; - } - found = alpm_depcmp(sync, missdep) && strcmp(sync->name, missdep->name) - && !_alpm_pkg_find(remove, alpm_pkg_get_name(sync)) - && !_alpm_pkg_find(*list, alpm_pkg_get_name(sync)); - if(!found) { - continue; - } - if(_alpm_pkg_should_ignore(sync)) { - pmpkg_t *dummypkg = _alpm_pkg_new(); - STRDUP(dummypkg->name, miss->target, RET_ERR(PM_ERR_MEMORY, -1)); - QUESTION(trans, PM_TRANS_CONV_INSTALL_IGNOREPKG, dummypkg, sync, NULL, &found); - _alpm_pkg_free(dummypkg); - } - } - } - - if(!found) { - char *missdepstring = alpm_dep_get_string(missdep); - _alpm_log(PM_LOG_ERROR, _("cannot resolve \"%s\", a dependency of \"%s\"\n"), - missdepstring, miss->target); - free(missdepstring); - if(data) { - MALLOC(miss, sizeof(pmdepmissing_t),/*nothing*/); - if(!miss) { - pm_errno = PM_ERR_MEMORY; - FREELIST(*data); - goto error; + /* find a satisfier package in the given repositories */ + pmpkg_t *spkg = _alpm_resolvedep(missdep, dbs_sync, list, tpkg); + if(!spkg) { + pm_errno = PM_ERR_UNSATISFIED_DEPS; + char *missdepstring = alpm_dep_get_string(missdep); + _alpm_log(PM_LOG_ERROR, _("cannot resolve \"%s\", a dependency of \"%s\"\n"), + missdepstring, tpkg->name); + free(missdepstring); + if(data) { + pmdepmissing_t *missd = _alpm_depmiss_new(miss->target, + miss->depend, miss->causingpkg); + if(missd) { + *data = alpm_list_add(*data, missd); + } } - *miss = *(pmdepmissing_t *)i->data; - *data = alpm_list_add(*data, miss); - } - pm_errno = PM_ERR_UNSATISFIED_DEPS; - goto error; - } else { - _alpm_log(PM_LOG_DEBUG, "pulling dependency %s (needed by %s)\n", - alpm_pkg_get_name(sync), alpm_pkg_get_name(syncpkg)); - *list = alpm_list_add(*list, sync); - if(_alpm_resolvedeps(local, dbs_sync, sync, list, remove, trans, data)) { - goto error; + alpm_list_free_inner(deps, (alpm_list_fn_free)_alpm_depmiss_free); + alpm_list_free(deps); + return(-1); + } else { + _alpm_log(PM_LOG_DEBUG, "pulling dependency %s (needed by %s)\n", + alpm_pkg_get_name(spkg), alpm_pkg_get_name(tpkg)); + list = alpm_list_add(list, spkg); } } + alpm_list_free_inner(deps, (alpm_list_fn_free)_alpm_depmiss_free); + alpm_list_free(deps); } - _alpm_log(PM_LOG_DEBUG, "finished resolving dependencies\n"); - - alpm_list_free_inner(deps, (alpm_list_fn_free)_alpm_depmiss_free); - alpm_list_free(deps); - return(0); - -error: - FREELIST(deps); - return(-1); } /* Does pkg1 depend on pkg2, ie. does pkg2 satisfy a dependency of pkg1? */ diff --git a/lib/libalpm/deps.h b/lib/libalpm/deps.h index 1e539b7..2997ab6 100644 --- a/lib/libalpm/deps.h +++ b/lib/libalpm/deps.h @@ -47,9 +47,9 @@ pmdepmissing_t *_alpm_depmiss_new(const char *target, pmdepend_t *dep, void _alpm_depmiss_free(pmdepmissing_t *miss); alpm_list_t *_alpm_sortbydeps(alpm_list_t *targets, int reverse); void _alpm_recursedeps(pmdb_t *db, alpm_list_t *targs, int include_explicit); -int _alpm_resolvedeps(pmdb_t *local, alpm_list_t *dbs_sync, pmpkg_t *syncpkg, - alpm_list_t **list, alpm_list_t *remove, pmtrans_t *trans, alpm_list_t - **data); +pmpkg_t *alpm_resolvedep(pmdepend_t *dep, alpm_list_t *dbs, alpm_list_t *excluding, pmpkg_t *tpkg); +int _alpm_resolvedeps(pmdb_t *local, alpm_list_t *dbs_sync, alpm_list_t *list, + alpm_list_t *remove, alpm_list_t **data); int _alpm_dep_edge(pmpkg_t *pkg1, pmpkg_t *pkg2); pmdepend_t *_alpm_splitdep(const char *depstring); pmpkg_t *_alpm_find_dep_satisfier(alpm_list_t *pkgs, pmdepend_t *dep); diff --git a/lib/libalpm/sync.c b/lib/libalpm/sync.c index 3dc54d0..9336a2e 100644 --- a/lib/libalpm/sync.c +++ b/lib/libalpm/sync.c @@ -462,14 +462,10 @@ int _alpm_sync_prepare(pmtrans_t *trans, pmdb_t *db_local, alpm_list_t *dbs_sync } } - for(i = trans->packages; i; i = i->next) { - pmpkg_t *spkg = ((pmsyncpkg_t *)i->data)->pkg; - if(_alpm_resolvedeps(db_local, dbs_sync, spkg, &list, - remove, trans, data) == -1) { - /* pm_errno is set by resolvedeps */ - ret = -1; - goto cleanup; - } + if(_alpm_resolvedeps(db_local, dbs_sync, list, remove, data) == -1) { + /* pm_errno is set by resolvedeps */ + ret = -1; + goto cleanup; } for(i = pulled->next; i; i = i->next) { -- 1.5.6.1

2 5

[pacman-dev] [PATCH] Document "pacman -S 'foo>=1.0'"
by Nagy Gabor 05 Jul '08

05 Jul '08

From 4a3d961fa1c8cdb4f841940e36fd8ed8a34482c4 Mon Sep 17 00:00:00 2001 From: Nagy Gabor <ngaba(a)bibl.u-szeged.hu> Date: Sat, 5 Jul 2008 13:58:09 +0200 Subject: [PATCH] Document "pacman -S 'foo>=1.0'" Signed-off-by: Nagy Gabor <ngaba(a)bibl.u-szeged.hu> --- doc/pacman.8.txt | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/doc/pacman.8.txt b/doc/pacman.8.txt index 5594ac6..0fbabc7 100644 --- a/doc/pacman.8.txt +++ b/doc/pacman.8.txt @@ -49,7 +49,9 @@ Operations example, `pacman -S qt` will download and install qt and all the packages it depends on. If a package name exists in more than one repo, the repo can be explicitly specified to clarify the package to install: - `pacman -S testing/qt`. + `pacman -S testing/qt`. You can also specify version requirement: + `pacman -S "bash>=3.2"` (Quotes are needed, otherwise your shell + interprets ">" as redirection to file.) + In addition to packages, groups can be specified as well. For example, if gnome is a defined package group, then `pacman -S gnome` will install every -- 1.5.6.1

1 0

[pacman-dev] [PATCH] Remove alpm_find_pkg_satisfiers and _alpm_find_dep_satisfiers
by Nagy Gabor 05 Jul '08

05 Jul '08

From 9a84f6ca501492441948a5c22ce73416f5a817f3 Mon Sep 17 00:00:00 2001 From: Nagy Gabor <ngaba(a)bibl.u-szeged.hu> Date: Sat, 5 Jul 2008 13:06:02 +0200 Subject: [PATCH] Remove alpm_find_pkg_satisfiers and _alpm_find_dep_satisfiers After sync_addtarget reworks, these functions weren't used. Signed-off-by: Nagy Gabor <ngaba(a)bibl.u-szeged.hu> --- lib/libalpm/alpm.h | 1 - lib/libalpm/deps.c | 26 -------------------------- lib/libalpm/deps.h | 1 - 3 files changed, 0 insertions(+), 28 deletions(-) diff --git a/lib/libalpm/alpm.h b/lib/libalpm/alpm.h index 9ed2c67..fbef057 100644 --- a/lib/libalpm/alpm.h +++ b/lib/libalpm/alpm.h @@ -433,7 +433,6 @@ int alpm_depcmp(pmpkg_t *pkg, pmdepend_t *dep); alpm_list_t *alpm_checkdeps(pmdb_t *db, int reversedeps, alpm_list_t *remove, alpm_list_t *upgrade); alpm_list_t *alpm_deptest(pmdb_t *db, alpm_list_t *targets); -alpm_list_t *alpm_find_pkg_satisfiers(alpm_list_t *pkgs, const char *pkgname); const char *alpm_miss_get_target(const pmdepmissing_t *miss); pmdepend_t *alpm_miss_get_dep(pmdepmissing_t *miss); diff --git a/lib/libalpm/deps.c b/lib/libalpm/deps.c index e042166..b58deea 100644 --- a/lib/libalpm/deps.c +++ b/lib/libalpm/deps.c @@ -202,32 +202,6 @@ pmpkg_t *_alpm_find_dep_satisfier(alpm_list_t *pkgs, pmdepend_t *dep) return(NULL); } -alpm_list_t *_alpm_find_dep_satisfiers(alpm_list_t *pkgs, pmdepend_t *dep) -{ - alpm_list_t *i, *ret = NULL; - - for(i = pkgs; i; i = alpm_list_next(i)) { - pmpkg_t *pkg = i->data; - if(alpm_depcmp(pkg, dep)) { - ret = alpm_list_add(ret, pkg); - } - } - return(ret); -} - -/** Find packages in a list that provide a given package. - * @param pkgs an alpm_list_t* of package to search - * @param pkgname the name of the package - * @return an alpm_list_t* of packages that provide pkgname - */ -alpm_list_t SYMEXPORT *alpm_find_pkg_satisfiers(alpm_list_t *pkgs, const char *pkgname) -{ - pmdepend_t *dep = _alpm_splitdep(pkgname); - alpm_list_t *res = _alpm_find_dep_satisfiers(pkgs, dep); - _alpm_dep_free(dep); - return(res); -} - /** Checks dependencies and returns missing ones in a list. * Dependencies can include versions with depmod operators. * @param db pointer to the local package database diff --git a/lib/libalpm/deps.h b/lib/libalpm/deps.h index 0b93951..6cd4c63 100644 --- a/lib/libalpm/deps.h +++ b/lib/libalpm/deps.h @@ -53,7 +53,6 @@ int _alpm_resolvedeps(pmdb_t *local, alpm_list_t *dbs_sync, alpm_list_t *list, int _alpm_dep_edge(pmpkg_t *pkg1, pmpkg_t *pkg2); pmdepend_t *_alpm_splitdep(const char *depstring); pmpkg_t *_alpm_find_dep_satisfier(alpm_list_t *pkgs, pmdepend_t *dep); -alpm_list_t *_alpm_find_dep_satisfiers(alpm_list_t *pkgs, pmdepend_t *dep); #endif /* _ALPM_DEPS_H */ -- 1.5.6.1

1 0

[pacman-dev] [PATCH] Modify sync1003.py pactest
by Nagy Gabor 05 Jul '08

05 Jul '08

From 6ef3a1f84dca7559506a6ab4b94b92c4ac746df6 Mon Sep 17 00:00:00 2001 From: Nagy Gabor <ngaba(a)bibl.u-szeged.hu> Date: Sat, 5 Jul 2008 11:08:03 +0200 Subject: [PATCH] Modify sync1003.py pactest Now it tests a more interesting case. (The old version failed with the new resolvedeps.) Signed-off-by: Nagy Gabor <ngaba(a)bibl.u-szeged.hu> --- pactest/tests/sync1003.py | 17 ++++++----------- 1 files changed, 6 insertions(+), 11 deletions(-) diff --git a/pactest/tests/sync1003.py b/pactest/tests/sync1003.py index 3fd9799..cd98063 100644 --- a/pactest/tests/sync1003.py +++ b/pactest/tests/sync1003.py @@ -4,23 +4,18 @@ sp1 = pmpkg("pkg1", "1.0-2") sp1.replaces = [ "pkg2" ] self.addpkg2db("sync", sp1) -sp2 = pmpkg("pkg2", "1.0-2") -self.addpkg2db("sync", sp2) - -sp3 = pmpkg("pkg3", "1.0-2") -sp3.depends = ["pkg2=1.0-2"] -self.addpkg2db("sync", sp3) - -lp1 = pmpkg("pkg1", "1.0-1") -self.addpkg2db("local", lp1) - -lp2 = pmpkg("pkg2", "1.0-2") +lp2 = pmpkg("pkg2", "1.0-1") self.addpkg2db("local", lp2) lp3 = pmpkg("pkg3", "1.0-1") +lp3.depends = [ "pkg2=1.0" ] self.addpkg2db("local", lp3) self.args = "-Su" self.addrule("PACMAN_RETCODE=1") +self.addrule("!PKG_EXIST=pkg1") self.addrule("PKG_EXIST=pkg2") +self.addrule("PKG_EXIST=pkg3") +self.addrule("PKG_VERSION=pkg2|1.0-1") +self.addrule("PKG_VERSION=pkg3|1.0-1") -- 1.5.6.1

1 0

[pacman-dev] [PATCH] Remove requiredby from pactests
by Nagy Gabor 05 Jul '08

05 Jul '08

From 2adc17767b1af4e46502f21f5061e19d7a60a4b2 Mon Sep 17 00:00:00 2001 From: Nagy Gabor <ngaba(a)bibl.u-szeged.hu> Date: Sat, 5 Jul 2008 10:48:26 +0200 Subject: [PATCH] Remove requiredby from pactests Also remove some meaningless pactests (broken requiredby, requiredby*.py tests) requiredby001.py was renamed to upgrade076.py Signed-off-by: Nagy Gabor <ngaba(a)bibl.u-szeged.hu> --- pactest/tests/remove040.py | 3 --- pactest/tests/remove041.py | 2 -- pactest/tests/remove042.py | 2 -- pactest/tests/remove043.py | 3 --- pactest/tests/remove045.py | 3 --- pactest/tests/remove046.py | 10 ---------- pactest/tests/remove047.py | 1 - pactest/tests/remove048.py | 10 ---------- pactest/tests/remove049.py | 1 - pactest/tests/requiredby001.py | 20 -------------------- pactest/tests/requiredby002.py | 16 ---------------- pactest/tests/requiredby003.py | 16 ---------------- pactest/tests/requiredby004.py | 20 -------------------- pactest/tests/requiredby005.py | 21 --------------------- pactest/tests/requiredby006.py | 21 --------------------- pactest/tests/sync010.py | 2 -- pactest/tests/sync060.py | 15 --------------- pactest/tests/sync1000.py | 2 -- pactest/tests/sync300.py | 1 - pactest/tests/sync400.py | 1 - pactest/tests/sync895.py | 2 -- pactest/tests/sync896.py | 2 -- pactest/tests/sync900.py | 3 --- pactest/tests/sync901.py | 3 --- pactest/tests/upgrade052.py | 1 - pactest/tests/upgrade053.py | 1 - pactest/tests/upgrade054.py | 1 - pactest/tests/upgrade055.py | 3 --- pactest/tests/upgrade056.py | 4 ---- pactest/tests/upgrade057.py | 2 -- pactest/tests/upgrade058.py | 1 - pactest/tests/upgrade059.py | 2 -- pactest/tests/upgrade060.py | 1 - pactest/tests/upgrade061.py | 1 - pactest/tests/upgrade073.py | 2 -- pactest/tests/upgrade076.py | 18 ++++++++++++++++++ 36 files changed, 18 insertions(+), 199 deletions(-) delete mode 100644 pactest/tests/remove046.py delete mode 100644 pactest/tests/remove048.py delete mode 100644 pactest/tests/requiredby001.py delete mode 100644 pactest/tests/requiredby002.py delete mode 100644 pactest/tests/requiredby003.py delete mode 100644 pactest/tests/requiredby004.py delete mode 100644 pactest/tests/requiredby005.py delete mode 100644 pactest/tests/requiredby006.py delete mode 100644 pactest/tests/sync060.py create mode 100644 pactest/tests/upgrade076.py diff --git a/pactest/tests/remove040.py b/pactest/tests/remove040.py index 07d3e67..9d95b60 100644 --- a/pactest/tests/remove040.py +++ b/pactest/tests/remove040.py @@ -6,13 +6,10 @@ self.addpkg2db("local", lp1) lp2 = pmpkg("pkg2") lp2.provides = ["imaginary"] -lp2.requiredby = [ "pkg1" ] self.addpkg2db("local", lp2) - self.args = "-R %s" % lp1.name self.addrule("PACMAN_RETCODE=0") self.addrule("!PKG_EXIST=pkg1") self.addrule("PKG_EXIST=pkg2") -self.addrule("!PKG_REQUIREDBY=pkg2|pkg1") diff --git a/pactest/tests/remove041.py b/pactest/tests/remove041.py index 9ab7bf7..be27fd4 100644 --- a/pactest/tests/remove041.py +++ b/pactest/tests/remove041.py @@ -2,12 +2,10 @@ self.description = "Remove a no longer needed package (multiple provision)" lp1 = pmpkg("pkg1") lp1.provides = ["imaginary"] -lp1.requiredby = ["pkg3"] self.addpkg2db("local", lp1) lp2 = pmpkg("pkg2") lp2.provides = ["imaginary"] -lp2.requiredby = ["pkg3"] self.addpkg2db("local", lp2) lp3 = pmpkg("pkg3") diff --git a/pactest/tests/remove042.py b/pactest/tests/remove042.py index 5de1fb4..796d040 100644 --- a/pactest/tests/remove042.py +++ b/pactest/tests/remove042.py @@ -6,10 +6,8 @@ self.addpkg2db("local", lp1) lp2 = pmpkg("pkg2") lp2.provides = ["imaginary"] -lp2.requiredby = [ "pkg1" ] self.addpkg2db("local", lp2) - self.args = "-Rc %s" % lp2.name self.addrule("PACMAN_RETCODE=0") diff --git a/pactest/tests/remove043.py b/pactest/tests/remove043.py index a377c58..0d448d0 100644 --- a/pactest/tests/remove043.py +++ b/pactest/tests/remove043.py @@ -6,13 +6,10 @@ self.addpkg2db("local", lp1) lp2 = pmpkg("pkg2") lp2.provides = ["imaginary"] -lp2.requiredby = [ "pkg1" ] self.addpkg2db("local", lp2) - self.args = "-R %s" % lp2.name self.addrule("!PACMAN_RETCODE=0") self.addrule("PKG_EXIST=pkg1") self.addrule("PKG_EXIST=pkg2") -self.addrule("PKG_REQUIREDBY=pkg2|pkg1") diff --git a/pactest/tests/remove045.py b/pactest/tests/remove045.py index d8b7845..f42e58f 100644 --- a/pactest/tests/remove045.py +++ b/pactest/tests/remove045.py @@ -7,18 +7,15 @@ self.addpkg2db("local", lp1) lp2 = pmpkg("pkg2") lp2.reason = 1 lp2.depends = ["pkg4"] -lp2.requiredby = ["pkg1"] self.addpkg2db("local", lp2) lp3 = pmpkg("pkg3") lp3.reason = 1 -lp3.requiredby = ["pkg1", "pkg4"] self.addpkg2db("local", lp3) lp4 = pmpkg("pkg4") lp4.reason = 1 lp4.depends = ["pkg3"] -lp4.requiredby = ["pkg2"] self.addpkg2db("local", lp4) self.args = "-Rs %s" % lp1.name diff --git a/pactest/tests/remove046.py b/pactest/tests/remove046.py deleted file mode 100644 index 1ee8be1..0000000 --- a/pactest/tests/remove046.py +++ /dev/null @@ -1,10 +0,0 @@ -self.description = "Cascade remove a package with a broken required by" - -lp1 = pmpkg("pkg1") -lp1.requiredby = [ "fake" ] -self.addpkg2db("local", lp1) - -self.args = "-Rc %s" % lp1.name - -self.addrule("PACMAN_RETCODE=0") -self.addrule("!PKG_EXIST=pkg1") diff --git a/pactest/tests/remove047.py b/pactest/tests/remove047.py index 9606c2e..8bb1a63 100644 --- a/pactest/tests/remove047.py +++ b/pactest/tests/remove047.py @@ -1,7 +1,6 @@ self.description = "Remove a package required by other packages" lp1 = pmpkg("pkg1") -lp1.requiredby = ["pkg2", "pkg3", "pkg4"] self.addpkg2db("local", lp1) lp2 = pmpkg("pkg2") diff --git a/pactest/tests/remove048.py b/pactest/tests/remove048.py deleted file mode 100644 index 2d9b480..0000000 --- a/pactest/tests/remove048.py +++ /dev/null @@ -1,10 +0,0 @@ -self.description = "Remove a package with a broken required by" - -lp1 = pmpkg("pkg1") -lp1.requiredby = [ "dep" ] -self.addpkg2db("local", lp1) - -self.args = "-R %s" % lp1.name - -self.addrule("PACMAN_RETCODE=0") -self.addrule("!PKG_EXIST=pkg1") diff --git a/pactest/tests/remove049.py b/pactest/tests/remove049.py index 724f8da..a033629 100644 --- a/pactest/tests/remove049.py +++ b/pactest/tests/remove049.py @@ -1,7 +1,6 @@ self.description = "-Ru test" lp1 = pmpkg("pkg1") -lp1.requiredby = [ "pkg3" ] self.addpkg2db("local", lp1) lp2 = pmpkg("pkg2") diff --git a/pactest/tests/requiredby001.py b/pactest/tests/requiredby001.py deleted file mode 100644 index 0f05d82..0000000 --- a/pactest/tests/requiredby001.py +++ /dev/null @@ -1,20 +0,0 @@ -self.description = "A package is downgraded no longer satisfying a depend" - -lp1 = pmpkg("pkg1") -lp1.depends = ["pkg2=1.1"] -self.addpkg2db("local", lp1) - -lp2 = pmpkg("pkg2", "1.1-1") -lp2.requiredby = ["pkg1"] -self.addpkg2db("local", lp2) - -p = pmpkg("pkg2", "1.0-1") -self.addpkg(p) - -self.args = "-U %s" % p.filename() - -self.addrule("PACMAN_RETCODE=1") -self.addrule("PKG_EXIST=pkg1") -self.addrule("PKG_VERSION=pkg2|1.1-1") -self.addrule("PKG_EXIST=pkg2") -self.addrule("PKG_REQUIREDBY=pkg2|pkg1") diff --git a/pactest/tests/requiredby002.py b/pactest/tests/requiredby002.py deleted file mode 100644 index 299ec88..0000000 --- a/pactest/tests/requiredby002.py +++ /dev/null @@ -1,16 +0,0 @@ -self.description = "A package was removed with -Rd, then downgraded" - -lp1 = pmpkg("pkg1") -lp1.depends = ["pkg2=1.1"] -self.addpkg2db("local", lp1) - -p = pmpkg("pkg2", "1.0-1") -self.addpkg(p) - -self.args = "-U %s" % p.filename() - -self.addrule("PACMAN_RETCODE=0") -self.addrule("PKG_EXIST=pkg1") -self.addrule("PKG_VERSION=pkg2|1.0-1") -self.addrule("PKG_EXIST=pkg2") -self.addrule("!PKG_REQUIREDBY=pkg2|pkg1") diff --git a/pactest/tests/requiredby003.py b/pactest/tests/requiredby003.py deleted file mode 100644 index 3279c2a..0000000 --- a/pactest/tests/requiredby003.py +++ /dev/null @@ -1,16 +0,0 @@ -self.description = "A package was removed with -Rd, then upgraded" - -lp1 = pmpkg("pkg1") -lp1.depends = ["pkg2>=1.1"] -self.addpkg2db("local", lp1) - -p = pmpkg("pkg2", "1.2-1") -self.addpkg(p) - -self.args = "-U %s" % p.filename() - -self.addrule("PACMAN_RETCODE=0") -self.addrule("PKG_EXIST=pkg1") -self.addrule("PKG_VERSION=pkg2|1.2-1") -self.addrule("PKG_EXIST=pkg2") -self.addrule("PKG_REQUIREDBY=pkg2|pkg1") diff --git a/pactest/tests/requiredby004.py b/pactest/tests/requiredby004.py deleted file mode 100644 index c4fe768..0000000 --- a/pactest/tests/requiredby004.py +++ /dev/null @@ -1,20 +0,0 @@ -self.description = "Upgrade a package that no longer needs a depend" - -lp1 = pmpkg("pkg1") -lp1.depends = ["pkg2"] -self.addpkg2db("local", lp1) - -lp2 = pmpkg("pkg2") -lp2.requiredby = ["pkg1"] -self.addpkg2db("local", lp2) - -p = pmpkg("pkg1", "1.1-1") -self.addpkg(p) - -self.args = "-U %s" % p.filename() - -self.addrule("PACMAN_RETCODE=0") -self.addrule("PKG_EXIST=pkg1") -self.addrule("PKG_VERSION=pkg1|1.1-1") -self.addrule("PKG_EXIST=pkg2") -self.addrule("!PKG_REQUIREDBY=pkg2|pkg1") diff --git a/pactest/tests/requiredby005.py b/pactest/tests/requiredby005.py deleted file mode 100644 index 5b2ce16..0000000 --- a/pactest/tests/requiredby005.py +++ /dev/null @@ -1,21 +0,0 @@ -self.description = "Remove lp1, requiredby should move from lp1 to lp2" - -lp1 = pmpkg("foo") -lp1.requiredby = ["pkg3"] -self.addpkg2db("local", lp1) - -lp2 = pmpkg("pkg2") -lp2.provides = ["foo"] -self.addpkg2db("local", lp2) - -lp3 = pmpkg("pkg3") -lp3.depends = ["foo"] -self.addpkg2db("local", lp3) - - -self.args = "-R %s" % lp1.name - -self.addrule("PACMAN_RETCODE=0") -self.addrule("!PKG_EXIST=foo") -self.addrule("PKG_EXIST=pkg2") -self.addrule("PKG_REQUIREDBY=pkg2|pkg3") diff --git a/pactest/tests/requiredby006.py b/pactest/tests/requiredby006.py deleted file mode 100644 index ea14cde..0000000 --- a/pactest/tests/requiredby006.py +++ /dev/null @@ -1,21 +0,0 @@ -self.description = "Broken requiredby/depends list" - -lp1 = pmpkg("pkg1") -lp1.depends = ["pkg2"] -self.addpkg2db("local", lp1) - -lp2 = pmpkg("pkg2") -lp2.requiredby = ["foo", "pkg1"] -self.addpkg2db("local", lp2) - -p = pmpkg("pkg1", "1.1-1") -p.depends = ["pkg2"] -self.addpkg(p) - -self.args = "-U %s" % p.filename() - -self.addrule("PACMAN_RETCODE=0") -self.addrule("PKG_EXIST=pkg1") -self.addrule("PKG_VERSION=pkg1|1.1-1") -self.addrule("PKG_EXIST=pkg2") -self.addrule("PKG_REQUIREDBY=pkg2|pkg1") diff --git a/pactest/tests/sync010.py b/pactest/tests/sync010.py index 7ddc149..df407a3 100644 --- a/pactest/tests/sync010.py +++ b/pactest/tests/sync010.py @@ -25,5 +25,3 @@ for p in sp1, sp2, sp3: for f in p.files: self.addrule("FILE_EXIST=%s" % f) self.addrule("PKG_DEPENDS=dep1|dep2") -self.addrule("PKG_REQUIREDBY=dep1|dummy") -self.addrule("PKG_REQUIREDBY=dep2|dep1") diff --git a/pactest/tests/sync060.py b/pactest/tests/sync060.py deleted file mode 100644 index 45f0c3e..0000000 --- a/pactest/tests/sync060.py +++ /dev/null @@ -1,15 +0,0 @@ -self.description = "Replace a package with a broken required by" - -lp1 = pmpkg("pkg1") -lp1.replaces = [ "pkg2" ] -self.addpkg2db("sync", lp1) - -lp2 = pmpkg("pkg2") -lp2.requiredby = [ "fake" ] -self.addpkg2db("local", lp2) - -self.args = "-Su" - -self.addrule("PACMAN_RETCODE=0") -self.addrule("PKG_EXIST=pkg1") -self.addrule("!PKG_EXIST=pkg2") diff --git a/pactest/tests/sync1000.py b/pactest/tests/sync1000.py index be1254b..e7f4326 100644 --- a/pactest/tests/sync1000.py +++ b/pactest/tests/sync1000.py @@ -2,11 +2,9 @@ self.description = "stonecrest's problem" sp = pmpkg("dummy", "1.1-1") -sp.requiredby = [ "pkg" ] self.addpkg2db("sync", sp) lp1 = pmpkg("dummy", "1.0-1") -lp1.requiredby = [ "pkg" ] self.addpkg2db("local", lp1) lp2 = pmpkg("pkg") diff --git a/pactest/tests/sync300.py b/pactest/tests/sync300.py index 85fb850..31b520a 100644 --- a/pactest/tests/sync300.py +++ b/pactest/tests/sync300.py @@ -12,4 +12,3 @@ self.args = "-S %s" % sp1.name self.addrule("PACMAN_RETCODE=1") self.addrule("!PKG_EXIST=pkg1") self.addrule("!PKG_EXIST=pkg2") -self.addrule("!PKG_REQUIREDBY=pkg2|pkg1") diff --git a/pactest/tests/sync400.py b/pactest/tests/sync400.py index 2ee1095..dd6aaf4 100644 --- a/pactest/tests/sync400.py +++ b/pactest/tests/sync400.py @@ -13,7 +13,6 @@ lp1.depends = ["pkg2=1.0-1"] self.addpkg2db("local", lp1) lp2 = pmpkg("pkg2", "1.0-1") -lp2.requiredby = [ "pkg1" ] self.addpkg2db("local", lp2) self.args = "-S pkg1" diff --git a/pactest/tests/sync895.py b/pactest/tests/sync895.py index 03ddc74..1b348c1 100644 --- a/pactest/tests/sync895.py +++ b/pactest/tests/sync895.py @@ -6,7 +6,6 @@ self.addpkg2db("sync", sp) lp1 = pmpkg("pkg1") lp1.provides = ["foo"] -lp1.requiredby = ["pkg2"] self.addpkg2db("local", lp1) lp2 = pmpkg("pkg2") @@ -19,4 +18,3 @@ self.addrule("PACMAN_RETCODE=1") self.addrule("PKG_EXIST=pkg1") self.addrule("PKG_EXIST=pkg2") self.addrule("!PKG_EXIST=pkg3") -self.addrule("PKG_REQUIREDBY=pkg1|pkg2") diff --git a/pactest/tests/sync896.py b/pactest/tests/sync896.py index 830b719..a89b5c7 100644 --- a/pactest/tests/sync896.py +++ b/pactest/tests/sync896.py @@ -7,7 +7,6 @@ self.addpkg2db("sync", sp) lp1 = pmpkg("pkg1") lp1.provides = ["foo"] -lp1.requiredby = ["pkg2"] self.addpkg2db("local", lp1) lp2 = pmpkg("pkg2") @@ -20,4 +19,3 @@ self.addrule("PACMAN_RETCODE=0") self.addrule("!PKG_EXIST=pkg1") self.addrule("PKG_EXIST=pkg2") self.addrule("PKG_EXIST=pkg3") -self.addrule("PKG_REQUIREDBY=pkg3|pkg2") diff --git a/pactest/tests/sync900.py b/pactest/tests/sync900.py index f21af06..16dfee1 100644 --- a/pactest/tests/sync900.py +++ b/pactest/tests/sync900.py @@ -6,7 +6,6 @@ sp.conflicts = ["foo"] self.addpkg2db("sync", sp) lp = pmpkg("foo") -lp.requiredby = ["lp1", "lp2"] self.addpkg2db("local", lp) lp1 = pmpkg("pkg1") @@ -23,6 +22,4 @@ self.addrule("PACMAN_RETCODE=0") self.addrule("!PKG_EXIST=foo") self.addrule("PKG_EXIST=bar") self.addrule("PKG_EXIST=pkg1") -self.addrule("PKG_REQUIREDBY=bar|pkg1") self.addrule("PKG_EXIST=pkg2") -self.addrule("PKG_REQUIREDBY=bar|pkg2") diff --git a/pactest/tests/sync901.py b/pactest/tests/sync901.py index 423fe42..bb420b7 100644 --- a/pactest/tests/sync901.py +++ b/pactest/tests/sync901.py @@ -6,7 +6,6 @@ self.addpkg2db("sync", sp) lp = pmpkg("bar") lp.provides = ["foo"] lp.conflicts = ["foo"] -lp.requiredby = ["lp1", "lp2"] self.addpkg2db("local", lp) lp1 = pmpkg("pkg1") @@ -23,6 +22,4 @@ self.addrule("PACMAN_RETCODE=0") self.addrule("PKG_EXIST=foo") self.addrule("!PKG_EXIST=bar") self.addrule("PKG_EXIST=pkg1") -self.addrule("PKG_REQUIREDBY=foo|pkg1") self.addrule("PKG_EXIST=pkg2") -self.addrule("PKG_REQUIREDBY=foo|pkg2") diff --git a/pactest/tests/upgrade052.py b/pactest/tests/upgrade052.py index 7db85df..7000a12 100644 --- a/pactest/tests/upgrade052.py +++ b/pactest/tests/upgrade052.py @@ -6,7 +6,6 @@ self.addpkg2db("local", lp1) lp2 = pmpkg("pkg2") lp2.provides = ["imaginary", "real"] -lp2.requiredby = [ "pkg1" ] self.addpkg2db("local", lp2) p = pmpkg("pkg2", "1.0-2") diff --git a/pactest/tests/upgrade053.py b/pactest/tests/upgrade053.py index 4cbaa1f..78de0b5 100644 --- a/pactest/tests/upgrade053.py +++ b/pactest/tests/upgrade053.py @@ -17,4 +17,3 @@ self.args = "-U %s" % p.filename() self.addrule("PACMAN_RETCODE=0") self.addrule("PKG_VERSION=pkg1|1.0-2") self.addrule("PKG_EXIST=pkg2") -self.addrule("PKG_REQUIREDBY=pkg2|pkg1") diff --git a/pactest/tests/upgrade054.py b/pactest/tests/upgrade054.py index b60f15f..817d1b3 100644 --- a/pactest/tests/upgrade054.py +++ b/pactest/tests/upgrade054.py @@ -17,4 +17,3 @@ self.args = "-U %s" % p.filename() self.addrule("PACMAN_RETCODE=0") self.addrule("PKG_VERSION=pkg1|1.0-2") self.addrule("PKG_EXIST=pkg2") -self.addrule("PKG_REQUIREDBY=pkg2|pkg1") diff --git a/pactest/tests/upgrade055.py b/pactest/tests/upgrade055.py index 7cdf6b5..2508396 100644 --- a/pactest/tests/upgrade055.py +++ b/pactest/tests/upgrade055.py @@ -6,12 +6,10 @@ self.addpkg2db("local", lp1) lp2 = pmpkg("pkg2") lp2.provides = ["imaginary"] -lp2.requiredby = [ "pkg1" ] self.addpkg2db("local", lp2) lp3 = pmpkg("pkg3") lp3.provides = ["imaginary2"] -lp3.requiredby = [ "pkg1" ] self.addpkg2db("local", lp3) p = pmpkg("pkg2", "1.0-2") @@ -24,5 +22,4 @@ self.addrule("PACMAN_RETCODE=0") self.addrule("PKG_EXIST=pkg1") self.addrule("PKG_VERSION=pkg2|1.0-2") self.addrule("PKG_EXIST=pkg3") -self.addrule("PKG_REQUIREDBY=pkg2|pkg1") self.addrule("PKG_DEPENDS=pkg1|imaginary") diff --git a/pactest/tests/upgrade056.py b/pactest/tests/upgrade056.py index b92c38a..908fa30 100644 --- a/pactest/tests/upgrade056.py +++ b/pactest/tests/upgrade056.py @@ -6,12 +6,10 @@ self.addpkg2db("local", lp1) lp2 = pmpkg("pkg2") lp2.provides = ["imaginary"] -lp2.requiredby = [ "pkg1" ] self.addpkg2db("local", lp2) lp3 = pmpkg("pkg3") lp3.provides = ["imaginary"] -lp3.requiredby = [ "pkg1" ] self.addpkg2db("local", lp3) p = pmpkg("pkg2", "1.0-2") @@ -23,5 +21,3 @@ self.addrule("PACMAN_RETCODE=0") self.addrule("PKG_EXIST=pkg1") self.addrule("PKG_VERSION=pkg2|1.0-2") self.addrule("PKG_EXIST=pkg3") -self.addrule("!PKG_REQUIREDBY=pkg2|pkg1") -self.addrule("PKG_REQUIREDBY=pkg3|pkg1") diff --git a/pactest/tests/upgrade057.py b/pactest/tests/upgrade057.py index fd3e713..b1eb502 100644 --- a/pactest/tests/upgrade057.py +++ b/pactest/tests/upgrade057.py @@ -6,7 +6,6 @@ self.addpkg2db("local", lp1) lp2 = pmpkg("pkg2") lp2.provides = ["imag3"] -lp2.requiredby = ["pkg1"] self.addpkg2db("local", lp2) p = pmpkg("pkg2", "1.0-2") @@ -18,6 +17,5 @@ self.args = "-U %s" % p.filename() self.addrule("PACMAN_RETCODE=0") self.addrule("PKG_EXIST=pkg1") self.addrule("PKG_VERSION=pkg2|1.0-2") -self.addrule("PKG_REQUIREDBY=pkg2|pkg1") self.addrule("PKG_DEPENDS=pkg1|pkg2") self.addrule("PKG_DEPENDS=pkg1|imag3") diff --git a/pactest/tests/upgrade058.py b/pactest/tests/upgrade058.py index 109289e..38576ff 100644 --- a/pactest/tests/upgrade058.py +++ b/pactest/tests/upgrade058.py @@ -5,7 +5,6 @@ lp1.depends = [ "pkg2=1.0" ] self.addpkg2db("local", lp1) lp2 = pmpkg("pkg2", "1.0-1") -lp2.requiredby = [ "pkg1" ] self.addpkg2db("local", lp2) p = pmpkg("pkg2", "1.1-1") diff --git a/pactest/tests/upgrade059.py b/pactest/tests/upgrade059.py index 933e4e7..9cd9f1f 100644 --- a/pactest/tests/upgrade059.py +++ b/pactest/tests/upgrade059.py @@ -6,12 +6,10 @@ self.addpkg2db("local", lp1) lp2 = pmpkg("pkg2", "1.0-1") lp2.provides = ["imaginary"] -lp2.requiredby = [ "pkg1" ] self.addpkg2db("local", lp2) lp3 = pmpkg("pkg3", "1.0-1") lp3.provides = ["imaginary"] -lp3.requiredby = [ "pkg1" ] self.addpkg2db("local", lp3) p2 = pmpkg("pkg2", "1.0-2") diff --git a/pactest/tests/upgrade060.py b/pactest/tests/upgrade060.py index dd78bba..7a28f3e 100644 --- a/pactest/tests/upgrade060.py +++ b/pactest/tests/upgrade060.py @@ -5,7 +5,6 @@ lp1.depends = ["pkg2=1.0"] self.addpkg2db("local", lp1) lp2 = pmpkg("pkg2", "1.0-1") -lp2.requiredby = [ "pkg1" ] self.addpkg2db("local", lp2) p1 = pmpkg("pkg1", "1.1-1") diff --git a/pactest/tests/upgrade061.py b/pactest/tests/upgrade061.py index 0b1ed4e..310e504 100644 --- a/pactest/tests/upgrade061.py +++ b/pactest/tests/upgrade061.py @@ -5,7 +5,6 @@ lp1.depends = ["imaginary"] self.addpkg2db("local", lp1) lp2 = pmpkg("pkg2", "1.0-1") -lp2.requiredby = [ "pkg1" ] lp2.provides = ["imaginary"] self.addpkg2db("local", lp2) diff --git a/pactest/tests/upgrade073.py b/pactest/tests/upgrade073.py index 3486c41..752a233 100644 --- a/pactest/tests/upgrade073.py +++ b/pactest/tests/upgrade073.py @@ -21,8 +21,6 @@ self.addrule("PACMAN_RETCODE=0") self.addrule("PKG_VERSION=dummy|1.0-2") self.addrule("PKG_DEPENDS=dummy|dep1") self.addrule("PKG_DEPENDS=dep1|dep2") -self.addrule("PKG_REQUIREDBY=dep1|dummy") -self.addrule("PKG_REQUIREDBY=dep2|dep1") for p in p1, p2, p3: self.addrule("PKG_EXIST=%s" % p.name) for f in p.files: diff --git a/pactest/tests/upgrade076.py b/pactest/tests/upgrade076.py new file mode 100644 index 0000000..87ccbdd --- /dev/null +++ b/pactest/tests/upgrade076.py @@ -0,0 +1,18 @@ +self.description = "Package downgrade (failure)" + +lp1 = pmpkg("pkg1") +lp1.depends = ["pkg2=1.1"] +self.addpkg2db("local", lp1) + +lp2 = pmpkg("pkg2", "1.1-1") +self.addpkg2db("local", lp2) + +p = pmpkg("pkg2", "1.0-1") +self.addpkg(p) + +self.args = "-U %s" % p.filename() + +self.addrule("PACMAN_RETCODE=1") +self.addrule("PKG_EXIST=pkg1") +self.addrule("PKG_EXIST=pkg2") +self.addrule("PKG_VERSION=pkg2|1.1-1") -- 1.5.6.1

1 0

[pacman-dev] [PATCH] New _alpm_find_dep_satisfier function
by Nagy Gabor 04 Jul '08

04 Jul '08

From d199269813180d4a034fea54d025280aef3e4853 Mon Sep 17 00:00:00 2001 From: Nagy Gabor <ngaba(a)bibl.u-szeged.hu> Date: Fri, 4 Jul 2008 15:39:26 +0200 Subject: [PATCH] New _alpm_find_dep_satisfier function This function finds the first satisfier package in a pkglist. Using it instead of _alpm_find_dep_satisfiers eliminates some memleaks and it is faster. (_alpm_find_dep_satisfiers and _alpm_find_pkg_satisfiers will be removed soon.) Signed-off-by: Nagy Gabor <ngaba(a)bibl.u-szeged.hu> --- lib/libalpm/deps.c | 25 +++++++++++++++++++------ lib/libalpm/deps.h | 1 + 2 files changed, 20 insertions(+), 6 deletions(-) diff --git a/lib/libalpm/deps.c b/lib/libalpm/deps.c index 410e22d..e67b008 100644 --- a/lib/libalpm/deps.c +++ b/lib/libalpm/deps.c @@ -189,6 +189,19 @@ alpm_list_t *_alpm_sortbydeps(alpm_list_t *targets, int reverse) return(newtargs); } +pmpkg_t *_alpm_find_dep_satisfier(alpm_list_t *pkgs, pmdepend_t *dep) +{ + alpm_list_t *i; + + for(i = pkgs; i; i = alpm_list_next(i)) { + pmpkg_t *pkg = i->data; + if(alpm_depcmp(pkg, dep)) { + return(pkg); + } + } + return(NULL); +} + alpm_list_t *_alpm_find_dep_satisfiers(alpm_list_t *pkgs, pmdepend_t *dep) { alpm_list_t *i, *ret = NULL; @@ -232,7 +245,7 @@ alpm_list_t SYMEXPORT *alpm_deptest(pmdb_t *db, alpm_list_t *targets) target = alpm_list_getdata(i); dep = _alpm_splitdep(target); - if(!_alpm_find_dep_satisfiers(_alpm_db_get_pkgcache(db), dep)) { + if(!_alpm_find_dep_satisfier(_alpm_db_get_pkgcache(db), dep)) { ret = alpm_list_add(ret, target); } _alpm_dep_free(dep); @@ -283,8 +296,8 @@ alpm_list_t SYMEXPORT *alpm_checkdeps(pmdb_t *db, int reversedeps, pmdepend_t *depend = j->data; /* 1. we check the upgrade list */ /* 2. we check database for untouched satisfying packages */ - if(!_alpm_find_dep_satisfiers(upgrade, depend) && - !_alpm_find_dep_satisfiers(dblist, depend)) { + if(!_alpm_find_dep_satisfier(upgrade, depend) && + !_alpm_find_dep_satisfier(dblist, depend)) { /* Unsatisfied dependency in the upgrade list */ char *missdepstring = alpm_dep_get_string(depend); _alpm_log(PM_LOG_DEBUG, "checkdeps: missing dependency '%s' for package '%s'\n", @@ -303,13 +316,13 @@ alpm_list_t SYMEXPORT *alpm_checkdeps(pmdb_t *db, int reversedeps, pmpkg_t *lp = i->data; for(j = alpm_pkg_get_depends(lp); j; j = j->next) { pmdepend_t *depend = j->data; - pmpkg_t *causingpkg = alpm_list_getdata(_alpm_find_dep_satisfiers(modified, depend)); + pmpkg_t *causingpkg = _alpm_find_dep_satisfier(modified, depend); /* we won't break this depend, if it is already broken, we ignore it */ /* 1. check upgrade list for satisfiers */ /* 2. check dblist for satisfiers */ if(causingpkg && - !_alpm_find_dep_satisfiers(upgrade, depend) && - !_alpm_find_dep_satisfiers(dblist, depend)) { + !_alpm_find_dep_satisfier(upgrade, depend) && + !_alpm_find_dep_satisfier(dblist, depend)) { char *missdepstring = alpm_dep_get_string(depend); _alpm_log(PM_LOG_DEBUG, "checkdeps: transaction would break '%s' dependency of '%s'\n", missdepstring, alpm_pkg_get_name(lp)); diff --git a/lib/libalpm/deps.h b/lib/libalpm/deps.h index 7bf178d..1e539b7 100644 --- a/lib/libalpm/deps.h +++ b/lib/libalpm/deps.h @@ -52,6 +52,7 @@ int _alpm_resolvedeps(pmdb_t *local, alpm_list_t *dbs_sync, pmpkg_t *syncpkg, **data); int _alpm_dep_edge(pmpkg_t *pkg1, pmpkg_t *pkg2); pmdepend_t *_alpm_splitdep(const char *depstring); +pmpkg_t *_alpm_find_dep_satisfier(alpm_list_t *pkgs, pmdepend_t *dep); alpm_list_t *_alpm_find_dep_satisfiers(alpm_list_t *pkgs, pmdepend_t *dep); #endif /* _ALPM_DEPS_H */ -- 1.5.6.1

1 0

[pacman-dev] [PATCH] Fix a bogus message in Hungarian translation (maint)
by Nagy Gabor 04 Jul '08

04 Jul '08

From 4d8c96d44b70ed4e89449d72641239ffaf2226c0 Mon Sep 17 00:00:00 2001 From: Nagy Gabor <ngaba(a)bibl.u-szeged.hu> Date: Fri, 4 Jul 2008 19:34:55 +0200 Subject: [PATCH] Fix a bogus message in Hungarian translation (maint) Signed-off-by: Nagy Gabor <ngaba(a)bibl.u-szeged.hu> --- lib/libalpm/po/hu.po | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/libalpm/po/hu.po b/lib/libalpm/po/hu.po index c9fd870..9039146 100644 --- a/lib/libalpm/po/hu.po +++ b/lib/libalpm/po/hu.po @@ -139,7 +139,7 @@ msgstr "a(z) %s csomag saját %s függősége előtt lesz telepítve\n" #, c-format msgid "cannot resolve \"%s\", a dependency of \"%s\"\n" -msgstr "nem sikerült a(z) \"%s\" csomag \"%s\" függőségét feloldani\n" +msgstr "nem sikerült a(z) \"%2$s\" csomag \"%1$s\" függőségét feloldani\n" #, c-format msgid "out of memory!" -- 1.5.6.1

1 0