July 2012 - Pacman-dev - lists.archlinux.org

[pacman-dev] [IDEA | WHISH] Give pacman the ability to fetch latest news from website before critical updates/upgrades
by Martin Cigorraga 17 Jul '12

17 Jul '12

Hi guys! I was thinking it could be a cool feature if pacman can warn the user every time news are published on our main page by issuing an alert when: 1. issuing a pacman -Syu -- which involves full system upgrade 2. issuing a pacman -S {package} -- providing the package being installed or upgraded is named in the latest news. Furthermore, the alert type could be customized within pacman.conf to show a simple alert message, to actually show the full news or to not show anything at all: 1. Simple message example: "There are some important news you should be aware, please consider visiting: http://www.archlinux.org/\n\n", or "[...] please consider visiting Arch Linux front page.", etc. I myself prefer the first option since most X consoles/terminals can convert the url to a clickable link. 2. Full news shown: "Latest news from 2012-07-14: The /lib directory becomes a symlink\nAll Arch Linux packages have had their files in[...]" A flag in -for example- /var/lib/pacman/sync can be set once the warning or full news are displayed to avoid showing them again if there isn't fresh news to show. I want to make it clear I _do_ check out our front page regularly, I do navigate the forums and I do read our mailing lists for both request help myself and -to try- to help fellow archers as much as my meager free time let me do that, but I still think this would be a great addition to pacman than can make its use a smoother and streamlined experience. Please let me know ff this list isn't the right place to post this feature request so I can post it again in the right place. Best wishes, Martín Cigorraga -- -msx

2 2

[pacman-dev] [PATCH] Do not remove symlink to directory if an installed package use it
by Allan McRae 17 Jul '12

17 Jul '12

If a packge has a directory (e.g. /lib -> usr/lib), do not allow it to be removed if any other package is trying to install a file into that path (e.g. /lib/foo). This is because the local database can become invalidated if the symlink is removed after then package with file /lib/foo is installed (sync702.py). If the symlink is removed before the file is installed (sync701.py), the upgrade is actually a success, but we can not guarantee the ordering so both cases should fail. Signed-off-by: Allan McRae <allan(a)archlinux.org> --- test/pacman/tests/sync701.py | 22 ++++++++++++++++++++++ test/pacman/tests/sync702.py | 22 ++++++++++++++++++++++ 2 files changed, 44 insertions(+) create mode 100644 test/pacman/tests/sync701.py create mode 100644 test/pacman/tests/sync702.py diff --git a/test/pacman/tests/sync701.py b/test/pacman/tests/sync701.py new file mode 100644 index 0000000..201f602 --- /dev/null +++ b/test/pacman/tests/sync701.py @@ -0,0 +1,22 @@ +self.description = "do not remove directory symlink if incoming package has file in its path (order 1)" + +lp = pmpkg("pkg1") +lp.files = ["usr/lib/foo", + "lib -> usr/lib"] +self.addpkg2db("local", lp) + +p1 = pmpkg("pkg1", "1.0-2") +p1.files = ["usr/lib/foo"] +self.addpkg2db("sync", p1) + +p2 = pmpkg("pkg2") +p2.files = ["lib/bar"] +self.addpkg2db("sync", p2) + +self.args = "-S pkg1 pkg2" + +self.addrule("PACMAN_RETCODE=1") +self.addrule("PKG_VERSION=pkg1|1.0-1") +self.addrule("!PKG_EXIST=pkg2") + +self.expectfailure = True diff --git a/test/pacman/tests/sync702.py b/test/pacman/tests/sync702.py new file mode 100644 index 0000000..ee4eef9 --- /dev/null +++ b/test/pacman/tests/sync702.py @@ -0,0 +1,22 @@ +self.description = "do not remove directory symlink if incoming package has file in its path (order 2)" + +lp = pmpkg("pkg2") +lp.files = ["usr/lib/foo", + "lib -> usr/lib"] +self.addpkg2db("local", lp) + +p1 = pmpkg("pkg1") +p1.files = ["lib/bar"] +self.addpkg2db("sync", p1) + +p2 = pmpkg("pkg2", "1.0-2") +p2.files = ["usr/lib/foo"] +self.addpkg2db("sync", p2) + +self.args = "-S pkg1 pkg2" + +self.addrule("PACMAN_RETCODE=1") +self.addrule("PKG_VERSION=pkg2|1.0-1") +self.addrule("!PKG_EXIST=pkg1") + +self.expectfailure = True -- 1.7.11.2

1 1

[pacman-dev] [PATCH] Do not remove symlink to directory if local package uses that path
by Allan McRae 17 Jul '12

17 Jul '12

If we have a symlink to a directory (e.g. /lib -> usr/lib), then we can not remove it if a local package thinks it has files in the symlink directory (e.g. /lib/foo), because this will invalidate the local file database. Signed-off-by: Allan McRae <allan(a)archlinux.org> --- test/pacman/tests/sync700.py | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) create mode 100644 test/pacman/tests/sync700.py diff --git a/test/pacman/tests/sync700.py b/test/pacman/tests/sync700.py new file mode 100644 index 0000000..0002b64 --- /dev/null +++ b/test/pacman/tests/sync700.py @@ -0,0 +1,22 @@ +self.description = "do not remove directory symlink if another package has file in its path" + +lp1 = pmpkg("pkg1") +lp1.files = ["usr/lib/foo", + "lib -> usr/lib"] +self.addpkg2db("local", lp1) + +lp2 = pmpkg("pkg2") +lp2.files = ["lib/bar"] +self.addpkg2db("local", lp2) + +p = pmpkg("pkg1", "1.0-2") +p.files = ["usr/lib/foo"] +self.addpkg2db("sync", p) + +self.args = "-S pkg1" + +self.addrule("PACMAN_RETCODE=1") +self.addrule("PKG_VERSION=pkg1|1.0-1") +self.addrule("FILE_EXIST=/lib/bar") + +self.expectfailure = True -- 1.7.11.2

1 0

[pacman-dev] [PATCH] Split filelist_operation function
by Allan McRae 17 Jul '12

17 Jul '12

To improve conflict checking, we will need to make these functions diverge to an extent where having two separate functions will be preferable. Signed-off-by: Allan McRae <allan(a)archlinux.org> --- lib/libalpm/conflict.c | 79 +++++++++++++++++++++++++++++++++----------------- 1 file changed, 53 insertions(+), 26 deletions(-) diff --git a/lib/libalpm/conflict.c b/lib/libalpm/conflict.c index 7494fd7..f3b269f 100644 --- a/lib/libalpm/conflict.c +++ b/lib/libalpm/conflict.c @@ -213,18 +213,12 @@ alpm_list_t SYMEXPORT *alpm_checkconflicts(alpm_handle_t *handle, return _alpm_innerconflicts(handle, pkglist); } -static const int DIFFERENCE = 0; -static const int INTERSECT = 1; -/* Returns a set operation on the provided two lists of files. +/* Returns the difference of the provided two lists of files. * Pre-condition: both lists are sorted! * When done, free the list but NOT the contained data. - * - * Operations: - * DIFFERENCE - a difference operation is performed. filesA - filesB. - * INTERSECT - an intersection operation is performed. filesA & filesB. */ -static alpm_list_t *filelist_operation(alpm_filelist_t *filesA, - alpm_filelist_t *filesB, int operation) +static alpm_list_t *filelist_difference(alpm_filelist_t *filesA, + alpm_filelist_t *filesB) { alpm_list_t *ret = NULL; size_t ctrA = 0, ctrB = 0; @@ -242,26 +236,20 @@ static alpm_list_t *filelist_operation(alpm_filelist_t *filesA, } else { int cmp = strcmp(strA, strB); if(cmp < 0) { - if(operation == DIFFERENCE) { - /* item only in filesA, qualifies as a difference */ - ret = alpm_list_add(ret, fileA); - } + /* item only in filesA, qualifies as a difference */ + ret = alpm_list_add(ret, fileA); ctrA++; } else if(cmp > 0) { ctrB++; } else { - if(operation == INTERSECT) { - /* item in both, qualifies as an intersect */ - ret = alpm_list_add(ret, fileA); - } ctrA++; ctrB++; } - } + } } - /* if doing a difference, ensure we have completely emptied pA */ - while(operation == DIFFERENCE && ctrA < filesA->count) { + /* ensure we have completely emptied pA */ + while(ctrA < filesA->count) { alpm_file_t *fileA = filesA->files + ctrA; const char *strA = fileA->name; /* skip directories */ @@ -274,6 +262,45 @@ static alpm_list_t *filelist_operation(alpm_filelist_t *filesA, return ret; } +/* Returns the intersection of the provided two lists of files. + * Pre-condition: both lists are sorted! + * When done, free the list but NOT the contained data. + */ + +static alpm_list_t *filelist_intersection(alpm_filelist_t *filesA, + alpm_filelist_t *filesB) +{ + alpm_list_t *ret = NULL; + size_t ctrA = 0, ctrB = 0; + + while(ctrA < filesA->count && ctrB < filesB->count) { + alpm_file_t *fileA = filesA->files + ctrA; + alpm_file_t *fileB = filesB->files + ctrB; + const char *strA = fileA->name; + const char *strB = fileB->name; + /* skip directories, we don't care about them */ + if(strA[strlen(strA)-1] == '/') { + ctrA++; + } else if(strB[strlen(strB)-1] == '/') { + ctrB++; + } else { + int cmp = strcmp(strA, strB); + if(cmp < 0) { + ctrA++; + } else if(cmp > 0) { + ctrB++; + } else { + /* item in both, qualifies as an intersect */ + ret = alpm_list_add(ret, fileA); + ctrA++; + ctrB++; + } + } + } + + return ret; +} + /* Adds alpm_fileconflict_t to a conflicts list. Pass the conflicts list, the * conflicting file path, and either two packages or one package and NULL. */ @@ -438,8 +465,8 @@ alpm_list_t *_alpm_db_find_fileconflicts(alpm_handle_t *handle, for(j = i->next; j; j = j->next) { alpm_list_t *common_files; alpm_pkg_t *p2 = j->data; - common_files = filelist_operation(alpm_pkg_get_files(p1), - alpm_pkg_get_files(p2), INTERSECT); + common_files = filelist_intersection(alpm_pkg_get_files(p1), + alpm_pkg_get_files(p2)); if(common_files) { alpm_list_t *k; @@ -471,8 +498,8 @@ alpm_list_t *_alpm_db_find_fileconflicts(alpm_handle_t *handle, if(dbpkg) { alpm_list_t *difference; /* older ver of package currently installed */ - difference = filelist_operation(alpm_pkg_get_files(p1), - alpm_pkg_get_files(dbpkg), DIFFERENCE); + difference = filelist_difference(alpm_pkg_get_files(p1), + alpm_pkg_get_files(dbpkg)); tmpfiles.count = alpm_list_count(difference); tmpfiles.files = alpm_list_to_array(difference, tmpfiles.count, sizeof(alpm_file_t)); @@ -604,7 +631,7 @@ alpm_list_t *_alpm_db_find_fileconflicts(alpm_handle_t *handle, if(handle->pm_errno == ALPM_ERR_MEMORY) { FREELIST(conflicts); if(dbpkg) { - /* only freed if it was generated from filelist_operation() */ + /* only freed if it was generated from filelist_difference() */ free(tmpfiles.files); } return NULL; @@ -612,7 +639,7 @@ alpm_list_t *_alpm_db_find_fileconflicts(alpm_handle_t *handle, } } if(dbpkg) { - /* only freed if it was generated from filelist_operation() */ + /* only freed if it was generated from filelist_difference() */ free(tmpfiles.files); } } -- 1.7.11.2

1 0

[pacman-dev] [PATCH] squelch output of installed new optdeps
by Clemens Buchacher 16 Jul '12

16 Jul '12

If an upgraded package version contains new optdeps, the user is notified of that. If the new optdep is already installed, that information is redundant. Instead, do not output new optdeps if they are already installed. Signed-off-by: Clemens Buchacher <drizzd(a)aon.at> --- src/pacman/util.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/src/pacman/util.c b/src/pacman/util.c index 7f7f6a7..e774fa8 100644 --- a/src/pacman/util.c +++ b/src/pacman/util.c @@ -1192,6 +1192,20 @@ static int depend_cmp(const void *d1, const void *d2) return ret; } +static alpm_list_t *filter_out_installed(alpm_list_t *list) +{ + alpm_list_t *i, *not_installed = NULL; + alpm_db_t *db_local = alpm_get_localdb(config->handle); + + for(i = list; i; i = alpm_list_next(i)) { + if(!alpm_db_get_pkg(db_local, i->data)) + not_installed = alpm_list_add(not_installed, i->data); + } + alpm_list_free(list); + + return not_installed; +} + void display_new_optdepends(alpm_pkg_t *oldpkg, alpm_pkg_t *newpkg) { alpm_list_t *i, *old, *new, *optdeps, *optstrings = NULL; @@ -1206,6 +1220,8 @@ void display_new_optdepends(alpm_pkg_t *oldpkg, alpm_pkg_t *newpkg) optstrings = alpm_list_add(optstrings, alpm_dep_compute_string(optdep)); } + optstrings = filter_out_installed(optstrings); + if(optstrings) { printf(_("New optional dependencies for %s\n"), alpm_pkg_get_name(newpkg)); unsigned short cols = getcols(fileno(stdout)); -- 1.7.11.2

2 2

[pacman-dev] [PATCH] pactest: conflict between files having same effective path
by Allan McRae 16 Jul '12

16 Jul '12

Note failure to detect a conflict between files having the same effective path across packages due to a directory symlink. Signed-off-by: Allan McRae <allan(a)archlinux.org> --- test/pacman/tests/fileconflict016.py | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) create mode 100644 test/pacman/tests/fileconflict016.py diff --git a/test/pacman/tests/fileconflict016.py b/test/pacman/tests/fileconflict016.py new file mode 100644 index 0000000..93797f6 --- /dev/null +++ b/test/pacman/tests/fileconflict016.py @@ -0,0 +1,23 @@ +self.description = "file conflict with same effective path across packages (directory symlink)" + +lp1 = pmpkg("filesystem", "1.0-1") +lp1.files = ["usr/", + "usr/lib/", + "lib -> usr/lib/"] +self.addpkg2db("local", lp1) + +p1 = pmpkg("pkg1") +p1.files = ["lib/foo"] +self.addpkg2db("sync", p1) + +p2 = pmpkg("pkg2") +p2.files = ["usr/lib/foo"] +self.addpkg2db("sync", p2) + +self.args = "-S pkg1 pkg2" + +self.addrule("PACMAN_RETCODE=1") +self.addrule("!PKG_EXIST=pkg1") +self.addrule("!PKG_EXIST=pkg2") + +self.expectfailure = True -- 1.7.11.2

1 0

[pacman-dev] [PATCH] pactest: conflict between directory and a file
by Allan McRae 16 Jul '12

16 Jul '12

Note failure to detect a conflict between a directory in one package and a file in the other when the directory is not currently on the filesystem. Signed-off-by: Allan McRae <allan(a)archlinux.org> --- test/pacman/tests/fileconflict015.py | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) create mode 100644 test/pacman/tests/fileconflict015.py diff --git a/test/pacman/tests/fileconflict015.py b/test/pacman/tests/fileconflict015.py new file mode 100644 index 0000000..78634d7 --- /dev/null +++ b/test/pacman/tests/fileconflict015.py @@ -0,0 +1,17 @@ +self.description = "conflict between a directory and a file" + +p1 = pmpkg("pkg1") +p1.files = ["foo/"] +self.addpkg2db("sync", p1) + +p2 = pmpkg("pkg2") +p2.files = ["foo"] +self.addpkg2db("sync", p2) + +self.args = "-S pkg1 pkg2" + +self.addrule("PACMAN_RETCODE=1") +self.addrule("!PKG_EXIST=pkg1") +self.addrule("!PKG_EXIST=pkg2") + +self.expectfailure = True -- 1.7.11.2

1 0

[pacman-dev] [PATCH] lib/conflict: avoid conflict with unchanged effective path
by Dave Reisner 16 Jul '12

16 Jul '12

This applies to a case such as when /lib is a symlink to /usr/lib. If a package is installed which contains /lib/libfoo.so, pacman will complain if this package is then "fixed" to contain /usr/lib/libfoo.so. Since these have the same effective path and it exists within the same package, ignore the conflict. Fixes FS#30681. Signed-off-by: Dave Reisner <dreisner(a)archlinux.org> --- Written against maint. lib/libalpm/conflict.c | 34 ++++++++++++++++++++++++++++++++++ test/pacman/tests/fileconflict013.py | 20 ++++++++++++++++++++ 2 files changed, 54 insertions(+) create mode 100644 test/pacman/tests/fileconflict013.py diff --git a/lib/libalpm/conflict.c b/lib/libalpm/conflict.c index d6e5d8c..64dd5b0 100644 --- a/lib/libalpm/conflict.c +++ b/lib/libalpm/conflict.c @@ -314,6 +314,28 @@ void _alpm_fileconflict_free(alpm_fileconflict_t *conflict) FREE(conflict); } +static const alpm_file_t *_alpm_filelist_contains_resolved(alpm_filelist_t *filelist, + const char *name, const char *root, size_t rootlen) +{ + size_t i; + const alpm_file_t *file; + + if(!filelist) { + return NULL; + } + + for(file = filelist->files, i = 0; i < filelist->count; file++, i++) { + char fullpath[PATH_MAX], abspath[PATH_MAX]; + snprintf(fullpath, sizeof(fullpath), "%s%s", root, file->name); + if(realpath(fullpath, abspath)) { + if(strcmp(&abspath[rootlen], name) == 0) { + return file; + } + } + } + return NULL; +} + const alpm_file_t *_alpm_filelist_contains(alpm_filelist_t *filelist, const char *name) { @@ -579,6 +601,18 @@ alpm_list_t *_alpm_db_find_fileconflicts(alpm_handle_t *handle, free(rpath); } + /* check if any of the package's own files resolve to the conflict to + * prevent problems with, e.g. /lib/liba.so moving to /usr/lib/liba.so + * when /lib is a symlink to usr/lib */ + if(!resolved_conflict && dbpkg && !S_ISDIR(lsbuf.st_mode)) { + if(_alpm_filelist_contains_resolved(alpm_pkg_get_files(dbpkg), + relative_path, handle->root, rootlen)) { + _alpm_log(handle, ALPM_LOG_DEBUG, + "package contained a realpath resolved to a package file\n"); + resolved_conflict = 1; + } + } + /* is the file unowned and in the backup list of the new package? */ if(!resolved_conflict && _alpm_needbackup(filestr, p1)) { alpm_list_t *local_pkgs = _alpm_db_get_pkgcache(handle->db_local); diff --git a/test/pacman/tests/fileconflict013.py b/test/pacman/tests/fileconflict013.py new file mode 100644 index 0000000..a83923c --- /dev/null +++ b/test/pacman/tests/fileconflict013.py @@ -0,0 +1,20 @@ +self.description = "file->file path change with same effective path (/lib as symlink)" + +lp1 = pmpkg("filesystem", "1.0-1") +lp1.files = ["usr/", + "usr/lib/", + "lib -> usr/lib/"] +self.addpkg2db("local", lp1) + +lp2 = pmpkg("pkg1", "1.0-1") +lp2.files = ["lib/libfoo.so"] +self.addpkg2db("local", lp2) + +sp1 = pmpkg("pkg1", "1.0-2") +sp1.files = ["usr/lib/libfoo.so"] +self.addpkg2db("sync", sp1) + +self.args = "-Su" + +self.addrule("PACMAN_RETCODE=0") +self.addrule("PKG_VERSION=pkg1|1.0-2") -- 1.7.11.2

3 2

[pacman-dev] [PATCH] makepkg: always build when pkgver function used
by Allan McRae 16 Jul '12

16 Jul '12

If a pkgver() function is specified, always build the package even if a package with the current pkgver is found as this pkgver may change. The only exception is when installing with -i. If a new build is required then, -f must be used. Signed-off-by: Allan McRae <allan(a)archlinux.org> --- I thought this was a reasonable compromise in terms of complexity and what I would expect makepkg to do. Having makepkg download all the sources, update pkgver, then check if a package with the same pkgver is already built did not seem the right approach to me. scripts/makepkg.sh.in | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index ed14577..d7d40de 100644 --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in @@ -74,6 +74,7 @@ IGNOREARCH=0 BUILDFUNC=0 CHECKFUNC=0 PKGFUNC=0 +PKGVERFUNC=0 SPLITPKG=0 PKGLIST=() SIGNPKG='' @@ -545,7 +546,7 @@ download_sources() { esac done - if declare -f pkgver >/dev/null && (( GET_VCS )); then + if (( PKGVERFUNC && GET_VCS )); then update_pkgver check_pkgver || exit 1 fi @@ -1807,7 +1808,7 @@ check_sanity() { ret=1 fi - if ! declare -f pkgver >/dev/null; then + if (( ! PKGVERFUNC )) ; then check_pkgver || ret=1 fi @@ -2406,6 +2407,10 @@ if (( GENINTEG )); then exit 0 # $E_OK fi +if declare -f pkgver >/dev/null; then + PKGVERFUNC=1 +fi + # check the PKGBUILD for some basic requirements check_sanity || exit 1 @@ -2482,12 +2487,12 @@ else warning "$(gettext "The package group has already been built, installing existing packages...")" install_package exit $? - else + elif (( ! PKGVERFUNC )); then error "$(gettext "The package group has already been built. (use %s to overwrite)")" "-f" exit 1 fi fi - if (( somepkgbuilt )); then + if (( somepkgbuilt && ! PKGVERFUNC )); then error "$(gettext "Part of the package group has already been built. (use %s to overwrite)")" "-f" exit 1 fi -- 1.7.11.2

1 0

[pacman-dev] [PATCH] makepkg: check pkgver validity after updating
by Allan McRae 16 Jul '12

16 Jul '12

If a PKGBUILD has a pkgver() function, skip checking the pkgver validity until it has been updated. Signed-off-by: Allan McRae <allan(a)archlinux.org> --- scripts/makepkg.sh.in | 34 +++++++++++++++++++++++++--------- 1 file changed, 25 insertions(+), 9 deletions(-) diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index 8f14418..ed14577 100644 --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in @@ -547,6 +547,7 @@ download_sources() { if declare -f pkgver >/dev/null && (( GET_VCS )); then update_pkgver + check_pkgver || exit 1 fi popd &>/dev/null @@ -1782,7 +1783,7 @@ check_sanity() { # check for no-no's in the build script local i local ret=0 - for i in 'pkgname' 'pkgrel' 'pkgver'; do + for i in 'pkgname' 'pkgrel'; do if [[ -z ${!i} ]]; then error "$(gettext "%s is not allowed to be empty.")" "$i" ret=1 @@ -1806,14 +1807,9 @@ check_sanity() { ret=1 fi - awk -F'=' '$1 ~ /^[[:space:]]*pkgver$/' "$BUILDFILE" | sed "s/[[:space:]]*#.*//" | - while IFS='=' read -r _ i; do - eval i=\"$(sed 's/^$['\''"]$$.*$\1$/\2/' <<< "${i%%+([[:space:]])}")\" - if [[ $i = *[[:space:]:-]* ]]; then - error "$(gettext "%s is not allowed to contain colons, hyphens or whitespace.")" "pkgver" - return 1 - fi - done || ret=1 + if ! declare -f pkgver >/dev/null; then + check_pkgver || ret=1 + fi awk -F'=' '$1 ~ /^[[:space:]]*pkgrel$/' "$BUILDFILE" | sed "s/[[:space:]]*#.*//" | while IFS='=' read -r _ i; do @@ -1943,6 +1939,26 @@ check_sanity() { return $ret } +check_pkgver() { + local ret=0 + + if [[ -z ${pkgver} ]]; then + error "$(gettext "%s is not allowed to be empty.")" "$i" + ret=1 + fi + + awk -F'=' '$1 ~ /^[[:space:]]*pkgver$/' "$BUILDFILE" | sed "s/[[:space:]]*#.*//" | + while IFS='=' read -r _ i; do + eval i=\"$(sed 's/^$['\''"]$$.*$\1$/\2/' <<< "${i%%+([[:space:]])}")\" + if [[ $i = *[[:space:]:-]* ]]; then + error "$(gettext "%s is not allowed to contain colons, hyphens or whitespace.")" "pkgver" + return 1 + fi + done || ret=1 + + return $ret +} + check_software() { # check for needed software local ret=0 -- 1.7.11.2

1 0