October 2019 - Pacman-dev - lists.archlinux.org

[pacman-dev] [PATCH] Fix distribution of meson files
by Allan McRae 21 Oct '19

21 Oct '19

Signed-off-by: Allan McRae <allan(a)archlinux.org> --- Also caught not distributing source for one of the man pages... I would have expected people that are interested in meson to have tested the patch that ensured these files were distributed! doc/Makefile.am | 1 + scripts/Makefile.am | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/doc/Makefile.am b/doc/Makefile.am index a8dbbe05..195f0b14 100644 --- a/doc/Makefile.am +++ b/doc/Makefile.am @@ -48,6 +48,7 @@ EXTRA_DIST = \ makepkg.conf.5.asciidoc \ pacman.conf.5.asciidoc \ BUILDINFO.5.asciidoc \ + pacman-conf.8.asciidoc \ libalpm.3.asciidoc \ footer.asciidoc \ index.asciidoc \ diff --git a/scripts/Makefile.am b/scripts/Makefile.am index 7b6cd00c..88e9612d 100644 --- a/scripts/Makefile.am +++ b/scripts/Makefile.am @@ -32,7 +32,8 @@ EXTRA_DIST = \ wrapper.sh.in \ $(COMPLETION_DIST) \ $(LIBRARY) \ - $(LIBMAKEPKG_DIST) + $(LIBMAKEPKG_DIST) \ + po/meson.build LIBRARY = \ library/human_to_size.sh @@ -136,6 +137,7 @@ LIBMAKEPKG_IN = \ libmakepkg/util/util.sh LIBMAKEPKG_DIST = \ + libmakepkg/meson.build \ $(addprefix libmakepkg/, $(addsuffix /meson.build, $(LIBMAKEPKGDIRS))) \ $(addsuffix .in, $(LIBMAKEPKG_IN)) -- 2.23.0

1 0

[pacman-dev] [GIT] The official pacman repository annotated tag, v5.2.0, created. v5.2.0
by Allan McRae 21 Oct '19

21 Oct '19

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The annotated tag, v5.2.0 has been created at 577ac132f917a0e974138f4f0e804d39b74d6a19 (tag) tagging 8ce20d3754769845f0b3452b06db2e1792108ec9 (commit) replaces v5.1.1 tagged by Allan McRae on Mon Oct 21 19:54:32 2019 +1000 - Log ----------------------------------------------------------------- Deltas were overrated -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEZkWwqMcAXnjbHXhk+Z/+D+rpmb0FAl2tgFgACgkQ+Z/+D+rp mb1H7Af/Q4x5lYRl97HGqnYJu7JR/bMB7Is4i+ticWOVNUIy09afSBgt0CzYFj7S YLx4YGHijWU2+hCH9N0a7tq+m1gpbzHo/f6yp/DXa6R3VQCF9tWDFmREsrnfaOtA Zr6mOGreozcVxbXlKD2AXj1lGmJ9AGfyqECdOAX3xbtaB0kFLVLIE9895oUqbX6D bRpsUj1436cAhCuVmWAExAKKHwWeBRIRt0mzesmoLCHkjJ1hXGSVkoHsKibHFHTv 4fk+7dAS5BEjAEHWQ8BeK3biAOrzKZbW+heHa3yHRAgmCzbkPIdZgPUMSSw/IgS1 WfSK8MsJsWD6kP9B4GN+J0Lf3DJHTA== =xGl+ -----END PGP SIGNATURE----- Alad Wenter (1): makepkg: propagate E_REMOVE_BUILD_DEPS Alex Butler (1): Add lz4 compression support to makepkg Allan McRae (27): Remove the last traces of the pacman --force option Remove Doxyfile from EXTRA_DIST configure.ac: use $datarootdir instead of $prefix/share be_local.c: remove aligment in local_pkg_ops Add -fstack-clash-protection to CFLAGS in debug builds if available libalpm/sync.c: change alpm_sync_newversion() to alpm_sync_get_new_version() Add [ignored] to -Qu output for packages in repos that are not Usage = Upgrade Fix typo in pacman man page makepkg: use --unneeded for pacman call in remove_deps() I blame everyone but me for this Add implicit fall through warning Remove delta support from repo-add Remove pkgdelta Remove cleanupdelta Make pacman forget deltas exist Remove support for deltas from libalpm Use bug tracker to track bugs Fix compiler warnings with gcc-9.1 makepkg: do not exit immediately on dependency install failures Prepare translations for next release makepkg.conf.5: Document PACKAGER format requirements makepkg: wait for process to finish Pull and push translation changes in preparation for 5.2 Translation updates Update README for pacman 5.2.0 release Final translation updates for pacman-5.2.0 Release v5.2.0 Andrew Gregory (24): reset signal handlers before running scripts/hooks handle EINTR while polling scripts/hooks add specific error for missing gpg support always allow explicit empty siglevel for sync dbs require actual siglevel for default common/ini: remove unnecessary alpm include add missing tests to meson.build check localdb before upgrading package update NEWS for v5.0.2 update NEWS for v5.1.2 silence warning when built without curl remove unused test summary code tap.py: add skip_all function allow tests for disabled features to be skipped Sanitize file name received from Content-Disposition header makepkg: restrict pkgname and pkgver to ascii hooks: rename type File to Path use consistent time notation for the log sighandler: block signals while handling SIGSEGV create coredump on segfault move wordsplit into common for sharing add arg_to_string helper run XferCommand via exec remove: improve broken dependency error message Austin Lund (2): makepkg: Ignore "<artificial>" source files makepkg: Delete logpipe when exiting Chloe Kudryavtsev (1): libmakepkg: Add lzip ext support Christian Hesse (2): signing: modify question text with unknwon uid signing: handle unknown uid in key import Dave Reisner (19): common/ini: Depend on util-common, not util Remove unused checks for strcoll and mktime doc: use more implicit rules to build manpages pacman/conf: Remove unused include Port pactest to python3 Drop vestiges of SIZECMD Dynamically generate Doxyfile from input Add meson.build files to build with meson meson: add a wrapper to bootstrap scripts from within build dir meson: separate out wrapped from non-wrapped scripts buildsys: remove size_to_human scripts/meson: ensure wrapper scripts are executable Enable additional debug flags/logging with debugoptimized builds free makedepends/checkdepends when freeing packages meson: drop checks for things we don't use meson: port over checks for types used from sys/types.h build-aux: detect build dir based on build.ninja meson: remove tap-driver.py, use meson's TAP protocol dload: never return NULL from get_filename David Phillips (2): Change if-else chain to switch User-visible log when validity check fails due to access Eli Schwartz (95): scripts/completion: derive the bash completion directory from pkg-config makepkg: when signing packages, report package filename on failure configure: bump the minimum version of bash to 4.4 libmakepkg/util: use parameter transformation when checking variable type scripts: pass on options such as set -x to child processes makepkg: don't save the same shopts twice makepkg: fix pkgver() function not aborting on errors makepkg: don't print status for run_function when in a subshell Revert "makepkg: add whirlpool to the list of hashing algorithms" scripts: deduplicate localized copyright messages pacman: check versioned optdepends in -Qi operation libmakepkg/lint_config: fix lint_variable actually running the PKGBUILD lint makepkg: reject PKGBUILDs with both split and non-split package functions makepkg: add support for the zst format repo-add: add support for the zst format bash-completion: don't complete filenames when they're not wanted bash-completion: disable completions for pacman --search operations makepkg: use bash 4.4 to localize `set` without explicitly saving/restoring makepkg: use builtin globbing to print files in package makepkg: send messages to stdout rather than stderr message.sh: add modifications from output_format.sh Port scripts to use libmakepkg's messaging code. pacman-key: just accept one file to verify, and enforce detached sigs makepkg: fix .PKGINFO/.BUILDINFO files swallowing status printing repo-add: print the name of the database when extracting makepkg: if "!buildflags" and "debug" coincide, unset the debug buildflags too build-aux: rm annoying and useless file meson: be more accurate in comments when generating processed scripts scripts: fix repo-remove/elephant Makefile targets scripts: fix some inaccurate Makefile targets, and be more templated autotools: be more accurate in comments when generating processed scripts scripts: make repo-add utilize a wrapper as well Make `make distcheck` work when bash-completion is installed. libmakepkg/executable: don't rely on scoped value of $ret to flag outcomes meson: remove useless mkdir -p meson: install the directories needed for successful pacman operation meson: add trailing slashes to directory components in configuration defines repo-remove: fix removing packages with deltas repo-add: don't break if delta package sources contain epoch makepkg: add internal variable to track when we're building a package makepkg: fix broken check for the fakeroot binary libmakepkg/lint_pkgbuild: check for invalid variables even if they're empty makepkg: fix unguarded use of printf libmakepkg: add routine for linting $SOURCE_DATE_EPOCH libmakepkg: simplify splitting command output into array makepkg: return E_PKGBUILD_ERROR for nonexistent PKGBUILD meson: fix regression that broke building libmakepkg doc: keep manpages and html pages in sync doc: add a couple missing manpages from the html index update a bunch of links for https and to adapt to changing domains meson: fix website target libmakepkg: make gettext replacements more templated libmakepkg: optimize get_protocol to always return proto, not proto+uri libmakepkg: implement extendable source protocols libmakepkg: Implement extendable signature verification build: link vercmp with a static copy of libalpm makepkg: implement locking for pacman commands makepkg: simplify run_pacman logic libmakepkg: migrate to schema.sh for integsums meson: fix static/shared split again makepkg: add new checksum algorithm via coreutils b2sum build: remove references to variable replacements from pacman-optimize build: check for gpgme with pkg-config before gpgme-config makepkg: use "shared" git clones when checking out sources libmakepkg: fix reporting of invalid archive extensions in compress.sh doc: generalize description of the bash nature of PKGBUILD functions bash-completion: support file redirection completions libmakepkg: fix migration to schema.sh for integsums makepkg: correctly handle hg sources with updates on a non-default branch makepkg: fix bash 5 compatibility when packaging symlinks to a directory meson: fix build of executables with nonstandard libarchive path makepkg: use more schema.sh to clean the environment of special variables scripts: protect against unintended glob matching in [[ ]] RHS libmakepkg: fix missing or inaccurate interdependencies libmakepkg: install pkg-config file makepkg: propagate error codes when package failed to sign correctly libmakepkg: add lint_config to validate SRCEXT/PKGEXT doc: update SRCEXT/PKGEXT to reduce needlessly scary warnings makepkg: move config loading into libmakepkg makepkg: also move restore_envvars handling into libmakepkg bash-completion: use POSIX character classes in regular expressions meson: bump the minimum supported version of meson to 0.51 meson: use not_found_message when dependencies are not found meson: use dependency('gpgme') exclusively autotools: distribute meson files makepkg: add rust support for *FLAGS and debug-prefix-map pacman-key: when refreshing gpg.conf, don't truncate option checking pacman-key: make sure we actually use the Web of Trust, which GnuPG doesn't. pacman-key: clean keys on import to remove unknown signatures Support file with seccomp enabled meson: fix libcommon being publicly exposed as a static link dependency meson: fix incorrect libalpm version meson: work around broken pkg-config file with private requires makepkg: do not save fflags when creating packages document changes between 5.1 and 5.2 Erich Eckner (1): makepkg: remove makedepends before installing built package Florian Wehner (1): Reformatting log timestamp to include time-zone Jan Steffens (7): makepkg: Simplify SPLITPKG check makepkg: Simplify run_package libmakepkg/util/option: Refactor checking to reduce code duplication scripts: Remove trailing semicolons makepkg: Only backup package variables once makepkg: Create a single-package packaging function makepkg: Make pkgdir a local Jelle van der Waa (2): doc: set rootdir correctly in man pages doc: add man page for pacman-conf Jonas Witschel (4): libmakepkg: check if PACKAGER has the expected format for WKD lookup signing: move key import confirmation before key_search signing: add ability to import keys using a WKD pacman-key: receive keys from WKD with -r/--recv-keys Jouke Witteveen (1): libalpm: ignore .hook suffix when sorting hooks Kevin Mihelich (1): Support application/gzip MIME type in extraction Luke Shumaker (3): makepkg: lint_pkgver: Run even if PKGVERFUNC makepkg: Better error messages for versions in (check, make, opt)depends/provides/conflicts makepkg: check_pkgrel: Don't say "decimal" in the error message László Várady (1): pacman/callback: fix buffer over-read Mark Ulrich (1): libalpm: prevent 301 redirect loop from hanging the process Matthew Sexton (2): pacman: pacman-conf: removed hputs macro for usage display pacman/pacman-conf, testpkg: Added translatable strings Michael Straube (4): libalpm/dload.c: add case for CURLE_COULDNT_RESOLVE_HOST scripts/library: fix typo in README Move skipping of duplicate sync/remove targets into libalpm libalpm/add.c: move assignment into conditional in alpm_add_pkg Olivier Brunel (2): alpm: Do not raise SIGINT when filesize goes over limit alpm: Fix SIGINT handling re: aborting download Que Quotion (3): Split check_software() to libmakepkg Split prepare_buildenv() to libmakepkg Clarify that build_options only apply during build() Rikard Falkeborn (2): doc: Remove double spaces Fix clang 8 string-plus-int warnings Santiago Torres (2): Make makepkg compute sizes properly drop DU* config variables Sever Oraz (1): Use standard, consistent units in the download progress. ekardnam (1): repo-add: Add --prevent-downgrade option morganamilo (29): libmakepkg: add pkgbase to linted variables Show install status during file search pacman-conf: add missing DisableDownloadTimeout Show group status during file search pacman: don't error when a group exists but all packages are ignored libalpm: process needed before group selection libmakepkg: fix linting arrays of empty strings libalpm: parse {check, make}depends when reading database libmakepkg: disallow using 'any' with other arches libalpm: fix minor typo in _alpm_db_usage_ libmakepkg: move checkdepends to the correct array libmakepkg: centralise random arrays of pkgbuild variables libmakepkg: lint disallowed variables in package() libmakepkg: lint disallowed architecture specific variables fix various typos pacman: fix segfault when Usage is specified without a value pacman: refactor file match printing to their own functions pacman: rework the UI of -F pacman: fix error during -Fy pacman: correctly free lists Correctly report a download failiure for 404s libmakepkg: fix typo libalpm: resolvedep(): don't compare names twice libalpm: fix incorrect documentation libalpm: short circuit alpm_find_dbs_satisfier pacman: speed up deptest pacman: return 1 when -F <target> has no results libalpm: fix segfault when -Qip'ing a package libalpm: set errno in signing dummy functions ----------------------------------------------------------------------- hooks/post-receive -- The official pacman repository

1 0

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v5.1.1-242-g8ce20d37
by Allan McRae 21 Oct '19

21 Oct '19

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, master has been updated via 8ce20d3754769845f0b3452b06db2e1792108ec9 (commit) via de24f644f4d2cbd874a511389e83a3fdd39c1773 (commit) from 9ddd0be02776f3b08cc3adc8a65f0630c05574f8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8ce20d3754769845f0b3452b06db2e1792108ec9 Author: Allan McRae <allan(a)archlinux.org> Date: Mon Oct 21 17:56:25 2019 +1000 Release v5.2.0 Signed-off-by: Allan McRae <allan(a)archlinux.org> commit de24f644f4d2cbd874a511389e83a3fdd39c1773 Author: Allan McRae <allan(a)archlinux.org> Date: Mon Oct 21 17:25:29 2019 +1000 Final translation updates for pacman-5.2.0 Signed-off-by: Allan McRae <allan(a)archlinux.org> ----------------------------------------------------------------------- Summary of changes: configure.ac | 8 +- doc/index.asciidoc | 2 + lib/libalpm/po/ar.po | 26 +- lib/libalpm/po/ast.po | 26 +- lib/libalpm/po/bg.po | 26 +- lib/libalpm/po/br.po | 26 +- lib/libalpm/po/ca.po | 26 +- lib/libalpm/po/cs.po | 26 +- lib/libalpm/po/da.po | 30 +- lib/libalpm/po/de.po | 26 +- lib/libalpm/po/el.po | 26 +- lib/libalpm/po/en_GB.po | 26 +- lib/libalpm/po/eo.po | 26 +- lib/libalpm/po/es.po | 26 +- lib/libalpm/po/es_419.po | 26 +- lib/libalpm/po/eu.po | 26 +- lib/libalpm/po/eu_ES.po | 26 +- lib/libalpm/po/fi.po | 26 +- lib/libalpm/po/fr.po | 30 +- lib/libalpm/po/gl.po | 26 +- lib/libalpm/po/hr.po | 26 +- lib/libalpm/po/hu.po | 27 +- lib/libalpm/po/id.po | 26 +- lib/libalpm/po/it.po | 26 +- lib/libalpm/po/ja.po | 26 +- lib/libalpm/po/kk.po | 26 +- lib/libalpm/po/ko.po | 26 +- lib/libalpm/po/libalpm.pot | 26 +- lib/libalpm/po/lt.po | 26 +- lib/libalpm/po/nb.po | 26 +- lib/libalpm/po/nl.po | 26 +- lib/libalpm/po/pl.po | 26 +- lib/libalpm/po/pt.po | 26 +- lib/libalpm/po/pt_BR.po | 26 +- lib/libalpm/po/ro.po | 26 +- lib/libalpm/po/ru.po | 26 +- lib/libalpm/po/sk.po | 26 +- lib/libalpm/po/sl.po | 26 +- lib/libalpm/po/sr.po | 26 +- lib/libalpm/po/sr(a)latin.po | 26 +- lib/libalpm/po/sv.po | 26 +- lib/libalpm/po/tr.po | 27 +- lib/libalpm/po/uk.po | 26 +- lib/libalpm/po/zh_CN.po | 26 +- lib/libalpm/po/zh_TW.po | 26 +- meson.build | 4 +- scripts/po/bg.po | 5 +- scripts/po/br.po | 5 +- scripts/po/ca.po | 7 +- scripts/po/cs.po | 5 +- scripts/po/da.po | 7 +- scripts/po/de.po | 5 +- scripts/po/el.po | 5 +- scripts/po/en_GB.po | 5 +- scripts/po/eo.po | 5 +- scripts/po/es.po | 6 +- scripts/po/es_419.po | 4 +- scripts/po/eu.po | 5 +- scripts/po/eu_ES.po | 5 +- scripts/po/fi.po | 5 +- scripts/po/fr.po | 9 +- scripts/po/gl.po | 5 +- scripts/po/hu.po | 8 +- scripts/po/id.po | 5 +- scripts/po/it.po | 7 +- scripts/po/ja.po | 5 +- scripts/po/ko.po | 5 +- scripts/po/lt.po | 7 +- scripts/po/nb.po | 6 +- scripts/po/nl.po | 7 +- scripts/po/pl.po | 5 +- scripts/po/pt.po | 4 +- scripts/po/pt_BR.po | 5 +- scripts/po/ro.po | 5 +- scripts/po/ru.po | 5 +- scripts/po/sk.po | 5 +- scripts/po/sl.po | 2 +- scripts/po/sr.po | 5 +- scripts/po/sr(a)latin.po | 5 +- scripts/po/sv.po | 5 +- scripts/po/tr.po | 11 +- scripts/po/uk.po | 5 +- scripts/po/zh_CN.po | 9 +- scripts/po/zh_TW.po | 5 +- src/pacman/po/LINGUAS | 1 + src/pacman/po/ar.po | 2 +- src/pacman/po/ast.po | 6 +- src/pacman/po/bg.po | 10 +- src/pacman/po/br.po | 6 +- src/pacman/po/ca.po | 10 +- src/pacman/po/cs.po | 6 +- src/pacman/po/da.po | 12 +- src/pacman/po/de.po | 6 +- src/pacman/po/el.po | 11 +- src/pacman/po/en_GB.po | 10 +- src/pacman/po/eo.po | 6 +- src/pacman/po/es.po | 10 +- src/pacman/po/es_419.po | 6 +- src/pacman/po/eu.po | 6 +- src/pacman/po/eu_ES.po | 6 +- src/pacman/po/fi.po | 6 +- src/pacman/po/fr.po | 14 +- src/pacman/po/gl.po | 6 +- src/pacman/po/hr.po | 12 +- src/pacman/po/hu.po | 12 +- src/pacman/po/id.po | 6 +- src/pacman/po/it.po | 10 +- src/pacman/po/ja.po | 10 +- src/pacman/po/ko.po | 10 +- src/pacman/po/lt.po | 32 +- src/pacman/po/nb.po | 10 +- src/pacman/po/nl.po | 12 +- src/pacman/po/pl.po | 6 +- src/pacman/po/pt.po | 6 +- src/pacman/po/pt_BR.po | 10 +- src/pacman/po/ro.po | 6 +- src/pacman/po/ru.po | 6 +- src/pacman/po/sk.po | 6 +- src/pacman/po/{pacman.pot => sl.po} | 575 +++++++++++++++++++++--------------- src/pacman/po/sr.po | 6 +- src/pacman/po/sr(a)latin.po | 6 +- src/pacman/po/sv.po | 6 +- src/pacman/po/tr.po | 12 +- src/pacman/po/uk.po | 6 +- src/pacman/po/zh_CN.po | 8 +- src/pacman/po/zh_TW.po | 10 +- 126 files changed, 1098 insertions(+), 1181 deletions(-) copy src/pacman/po/{pacman.pot => sl.po} (69%) hooks/post-receive -- The official pacman repository

1 0

[pacman-dev] configure syntax error even after issuing autogen.sh
by Saul Tigh 18 Oct '19

18 Oct '19

Dear pacman developers, First time poster here, so please be gentle. I've been trying to compile pacman from git and I constantly run into an issue. First I issue ./autogen.sh and then ./configure but this error always pops up: ./configure: line 14968: syntax error near unexpected token `$file_version,' ./configure: line 14968: ` AX_COMPARE_VERSION($file_version, ge, 5.38, with_file_seccomp=yes)' What am I doing wrong?

3 2

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v5.1.1-240-g9ddd0be0
by Allan McRae 18 Oct '19

18 Oct '19

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, master has been updated via 9ddd0be02776f3b08cc3adc8a65f0630c05574f8 (commit) from b05a3c10bff000a498e8f3dbfc161cce44776181 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9ddd0be02776f3b08cc3adc8a65f0630c05574f8 Author: Eli Schwartz <eschwartz(a)archlinux.org> Date: Tue Mar 12 15:56:19 2019 -0400 document changes between 5.1 and 5.2 Signed-off-by: Eli Schwartz <eschwartz(a)archlinux.org> ----------------------------------------------------------------------- Summary of changes: NEWS | 116 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 116 insertions(+) hooks/post-receive -- The official pacman repository

1 0

[pacman-dev] [PATCH 1/2] [WIP] move wordsplit into ini for sharing
by Andrew Gregory 17 Oct '19

17 Oct '19

Not technically related to INI parsing, but we use it with INI files. --- lib/libalpm/hook.c | 113 --------------------------------------------- src/common/ini.c | 113 +++++++++++++++++++++++++++++++++++++++++++++ src/common/ini.h | 3 ++ 3 files changed, 116 insertions(+), 113 deletions(-) diff --git a/lib/libalpm/hook.c b/lib/libalpm/hook.c index 6143ea0f..c385b5d5 100644 --- a/lib/libalpm/hook.c +++ b/lib/libalpm/hook.c @@ -17,7 +17,6 @@ * along with this program. If not, see <http://www.gnu.org/licenses/>. */ -#include <ctype.h> #include <dirent.h> #include <errno.h> #include <limits.h> @@ -71,17 +70,6 @@ static void _alpm_trigger_free(struct _alpm_trigger_t *trigger) } } -static void _alpm_wordsplit_free(char **ws) -{ - if(ws) { - char **c; - for(c = ws; *c; c++) { - free(*c); - } - free(ws); - } -} - static void _alpm_hook_free(struct _alpm_hook_t *hook) { if(hook) { @@ -158,107 +146,6 @@ static int _alpm_hook_validate(alpm_handle_t *handle, return ret; } -static char **_alpm_wordsplit(char *str) -{ - char *c = str, *end; - char **out = NULL, **outsave; - size_t count = 0; - - if(str == NULL) { - errno = EINVAL; - return NULL; - } - - for(c = str; isspace(*c); c++); - while(*c) { - size_t wordlen = 0; - - /* extend our array */ - outsave = out; - if((out = realloc(out, (count + 1) * sizeof(char*))) == NULL) { - out = outsave; - goto error; - } - - /* calculate word length and check for unbalanced quotes */ - for(end = c; *end && !isspace(*end); end++) { - if(*end == '\'' || *end == '"') { - char quote = *end; - while(*(++end) && *end != quote) { - if(*end == '\\' && *(end + 1) == quote) { - end++; - } - wordlen++; - } - if(*end != quote) { - errno = EINVAL; - goto error; - } - } else { - if(*end == '\\' && (end[1] == '\'' || end[1] == '"')) { - end++; /* skip the '\\' */ - } - wordlen++; - } - } - - if(wordlen == (size_t) (end - c)) { - /* no internal quotes or escapes, copy it the easy way */ - if((out[count++] = strndup(c, wordlen)) == NULL) { - goto error; - } - } else { - /* manually copy to remove quotes and escapes */ - char *dest = out[count++] = malloc(wordlen + 1); - if(dest == NULL) { goto error; } - while(c < end) { - if(*c == '\'' || *c == '"') { - char quote = *c; - /* we know there must be a matching end quote, - * no need to check for '\0' */ - for(c++; *c != quote; c++) { - if(*c == '\\' && *(c + 1) == quote) { - c++; - } - *(dest++) = *c; - } - c++; - } else { - if(*c == '\\' && (c[1] == '\'' || c[1] == '"')) { - c++; /* skip the '\\' */ - } - *(dest++) = *(c++); - } - } - *dest = '\0'; - } - - if(*end == '\0') { - break; - } else { - for(c = end + 1; isspace(*c); c++); - } - } - - outsave = out; - if((out = realloc(out, (count + 1) * sizeof(char*))) == NULL) { - out = outsave; - goto error; - } - - out[count++] = NULL; - - return out; - -error: - /* can't use wordsplit_free here because NULL has not been appended */ - while(count) { - free(out[--count]); - } - free(out); - return NULL; -} - static int _alpm_hook_parse_cb(const char *file, int line, const char *section, char *key, char *value, void *data) { diff --git a/src/common/ini.c b/src/common/ini.c index 30f1fac8..9cdd5c47 100644 --- a/src/common/ini.c +++ b/src/common/ini.c @@ -17,6 +17,7 @@ * along with this program. If not, see <http://www.gnu.org/licenses/>. */ +#include <ctype.h> #include <errno.h> #include <limits.h> #include <stdlib.h> @@ -106,3 +107,115 @@ cleanup: free(section_name); return ret; } + +void _alpm_wordsplit_free(char **ws) +{ + if(ws) { + char **c; + for(c = ws; *c; c++) { + free(*c); + } + free(ws); + } +} + +char **_alpm_wordsplit(const char *str) +{ + const char *c = str, *end; + char **out = NULL, **outsave; + size_t count = 0; + + if(str == NULL) { + errno = EINVAL; + return NULL; + } + + for(c = str; isspace(*c); c++); + while(*c) { + size_t wordlen = 0; + + /* extend our array */ + outsave = out; + if((out = realloc(out, (count + 1) * sizeof(char*))) == NULL) { + out = outsave; + goto error; + } + + /* calculate word length and check for unbalanced quotes */ + for(end = c; *end && !isspace(*end); end++) { + if(*end == '\'' || *end == '"') { + char quote = *end; + while(*(++end) && *end != quote) { + if(*end == '\\' && *(end + 1) == quote) { + end++; + } + wordlen++; + } + if(*end != quote) { + errno = EINVAL; + goto error; + } + } else { + if(*end == '\\' && (end[1] == '\'' || end[1] == '"')) { + end++; /* skip the '\\' */ + } + wordlen++; + } + } + + if(wordlen == (size_t) (end - c)) { + /* no internal quotes or escapes, copy it the easy way */ + if((out[count++] = strndup(c, wordlen)) == NULL) { + goto error; + } + } else { + /* manually copy to remove quotes and escapes */ + char *dest = out[count++] = malloc(wordlen + 1); + if(dest == NULL) { goto error; } + while(c < end) { + if(*c == '\'' || *c == '"') { + char quote = *c; + /* we know there must be a matching end quote, + * no need to check for '\0' */ + for(c++; *c != quote; c++) { + if(*c == '\\' && *(c + 1) == quote) { + c++; + } + *(dest++) = *c; + } + c++; + } else { + if(*c == '\\' && (c[1] == '\'' || c[1] == '"')) { + c++; /* skip the '\\' */ + } + *(dest++) = *(c++); + } + } + *dest = '\0'; + } + + if(*end == '\0') { + break; + } else { + for(c = end + 1; isspace(*c); c++); + } + } + + outsave = out; + if((out = realloc(out, (count + 1) * sizeof(char*))) == NULL) { + out = outsave; + goto error; + } + + out[count++] = NULL; + + return out; + +error: + /* can't use wordsplit_free here because NULL has not been appended */ + while(count) { + free(out[--count]); + } + free(out); + return NULL; +} diff --git a/src/common/ini.h b/src/common/ini.h index 6d2b264a..b7c40f2c 100644 --- a/src/common/ini.h +++ b/src/common/ini.h @@ -25,4 +25,7 @@ typedef int (ini_parser_fn)(const char *file, int line, const char *section, int parse_ini(const char *file, ini_parser_fn cb, void *data); +void _alpm_wordsplit_free(char **ws); +char **_alpm_wordsplit(const char *str); + #endif /* PM_INI_H */ -- 2.21.0

5 18

[pacman-dev] [PATCH 0/5][RFC] Die delta, die!
by Allan McRae 17 Oct '19

17 Oct '19

Deltas are broken. So much so that I would strongly recommend never using a delta from a repo that you did not generate yourself. In short, we call "system(command)", with a command that includes the name of a delta file, and the name of the package file before and after applying the delta. The name of the delta and the package files is controlled by the information in the repo, and could contain a malicious command to be run as root. We could possibly work around this, but it is a very risky piece of code and I believe it would be very hard to fully secure. Instead, I propose to remove delta support completely. Allan McRae (5): Remove delta support from repo-add Remove pkgdelta Remove cleanupdelta Make pacman forget deltas exist Remove support for deltas from libalpm doc/Makefile.am | 2 - doc/index.asciidoc | 1 - doc/meson.build | 1 - doc/pacman.conf.5.asciidoc | 8 - doc/pkgdelta.8.asciidoc | 53 ------ doc/repo-add.8.asciidoc | 22 +-- lib/libalpm/Makefile.am | 1 - lib/libalpm/alpm.h | 53 ------ lib/libalpm/be_sync.c | 21 +-- lib/libalpm/delta.c | 361 ------------------------------------- lib/libalpm/delta.h | 33 ---- lib/libalpm/error.c | 5 - lib/libalpm/handle.c | 20 -- lib/libalpm/handle.h | 5 - lib/libalpm/meson.build | 1 - lib/libalpm/package.c | 14 -- lib/libalpm/package.h | 2 - lib/libalpm/po/POTFILES.in | 1 - lib/libalpm/sync.c | 207 +-------------------- meson.build | 8 - scripts/.gitignore | 1 - scripts/Makefile.am | 3 - scripts/meson.build | 1 - scripts/pkgdelta.sh.in | 234 ------------------------ scripts/po/POTFILES.in | 1 - scripts/repo-add.sh.in | 168 +---------------- src/pacman/callback.c | 19 -- src/pacman/conf.c | 25 --- src/pacman/conf.h | 1 - src/pacman/pacman-conf.c | 13 -- src/pacman/po/POTFILES.in | 1 - src/pacman/sync.c | 5 +- src/util/.gitignore | 2 - src/util/Makefile.am | 5 +- src/util/cleanupdelta.c | 135 -------------- src/util/meson.build | 1 - 36 files changed, 27 insertions(+), 1407 deletions(-) delete mode 100644 doc/pkgdelta.8.asciidoc delete mode 100644 lib/libalpm/delta.c delete mode 100644 lib/libalpm/delta.h delete mode 100644 scripts/pkgdelta.sh.in delete mode 100644 src/util/cleanupdelta.c -- 2.20.1

3 9

[pacman-dev] [PATCH] Document changes between 5.1 and 5.2
by Allan McRae 16 Oct '19

16 Oct '19

From: Eli Schwartz <eschwartz(a)archlinux.org> Signed-off-by: Eli Schwartz <eschwartz(a)archlinux.org> --- Allan: rearranged some of the entries to put more newsworthy stuff at the top. NEWS | 116 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 116 insertions(+) diff --git a/NEWS b/NEWS index ce39e0c5..a55dac85 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,121 @@ VERSION DESCRIPTION ----------------------------------------------------------------------------- +5.2.0 - completely remove delta support + - add support to pacman and pacman-key for downloading PGP + signing keys using the WKD protocol (FS#63171) + - completely remove the --force option + - renovate and simplify the UI for -F (FS#47949) + - hooks: rename type File to Path, for accuracy + - add the meson build system as an alternative to autotools, and + distribute it in autotools dist tarballs + - switch from system() to exec() when using alternative download + agents for XferCommand; this prevents a potential source of + shell injection + - ignore .hook suffix when sorting libalpm hooks + - update the minimum requirement of bash to 4.4 + - scripts: pass on options such as set -x to child processes + - show group and installed status during -Fs + - user-visible log when validity check fails due to access + - port pactest to python3 + - process --needed before group selection when resolving the + dependencies to prompt for (FS#22870) + - don't error when a group exists but all packages are ignored + - bash completion now completes when it should, and doesn't + complete when it shouldn't (FS#59965) + - improve error message when gpg support is missing (FS#60880) + - don't emit confusing errors when a package is simultaneously + replaced and upgraded (FS#50875, FS#55534) + - better warning message when skipping duplicate targets + (FS#49377) + - libalpm: parse {check, make}depends when reading database + (FS#60347) + - add [ignored] to -Qu output for packages in repos that are not + Usage = Upgrade (FS#59854) + - prevent 301 redirect loop from hanging libalpm + - use standard, consistent units in the download progress + (FS#59201) + - fix segfault when Usage is specified without a value + - include timezones in pacman.log + - bash-completion: use POSIX character classes for portability + - correctly report a download failiure for 404s + - fix handling of signals during SIGSEGV + - fix buffer overread in pacman/callback + - fix crash when downloading files with a Content-Disposition + that has no directory component + - pacman-conf, testpkg are now properly localized + - when -F returns zero results, set a failing exit code + - improve wording for the error message when a package cannot be + removed due to dependencies + - fix segfaults and other incorrect behavior when using -Qip if + pacman was compiled without GPGME support + - makepkg: + - implement extendable source/signature verification routines + within libmakepkg (FS#49076) + - if pacman is in use, wait until it is available before + continuing (FS#28840) + - add support for lzip, lz4 and zst compressed packages + (FS#56676, FS#59081) + - add new checksum algorithm, b2sum + - various improvements to PKGBUILD linting + - when signing packages, report package filename on failure + - fix pkgver() function not aborting on errors + - remove checksum algorithm whirlpoolsum as it has not worked + for a long time + - reject PKGBUILDs with both split and non-split package + functions + - send status messages to stderr rather than stdout (FS#17173) + - ensure debug buildflags are unset when they are supposed to be + - buildenv and executable detection, definitions for the + PKGBUILD schema, and makepkg.conf loading are now part of + libmakepkg + - fix broken check for the fakeroot binary + - improve the error message for invalid dependency versioning + - add routine for linting $SOURCE_DATE_EPOCH + - fix the error code when no PKGBUILD exists + - use --unneeded when removing build deps to allow runtime-only + deps to work well with makepkg -sir (FS#32723) + - compute package sizes correctly across different filesystems + - use shared clones for git sources to save space when building + - fix reporting of invalid archive extensions + - correctly handle hg sources with updates on a non-default + branch + - install pkg-config file for libmakepkg's library directory + - propagate error codes when package failed to sign correctly + - be compatible with file 5.37's application/gzip MIME type + - forbid non-ASCII pkgname and pkgver (FS#49342) + - fix exiting on failure without ensuring dependencies are + prompted for removal (FS#63000) + - quiet superfluous warnings for missing debug source files for + artificial symbols + - add routine for linting $PACKAGER to check that it has a + valid name and email address, and document the desired format + in makepkg.conf(5) + - add rust support for *FLAGS and debug-prefix-map + - correctly handle a system file command with seccomp enabled + (FS#58626) + - try to more thoroughly clean up logpipe during unusual exit + states such as CTRL-C + - when installing packages with -sir, be more robust against + conflicting makedepends by always uninstalling them first + - fix exit code when removing deps fails + - reproducible builds: suppress filesystem-specific archive + metadata from built packages as they are not needed + - pacman-key: + - just accept one file to verify, and enforce detached sigs + (FS#52022) + - after recent GnuPG updates, ensure the Web of Trust is still + used + - clean keys during import to reduce size consumed by unusable + signatures + - repo-add: + - add support for zst compressed databases + - print the name of the database when extracting + - do not infinitely loop on malformed arguments with embedded + globs + - add option to prevent downgrading (FS#17752) + - various documentation updates +5.1.3 - Sanitize file name received from Content-Disposition header + during -U 5.1.2 - pacman-conf: add missing DisableDownloadTimeout support - Include version when checking optdepend install status during -Qi (FS#60106) -- 2.23.0

1 0

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v5.1.1-239-gb05a3c10
by Allan McRae 15 Oct '19

15 Oct '19

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, master has been updated via b05a3c10bff000a498e8f3dbfc161cce44776181 (commit) via 719efe19c7372ee7acc243d3d16180163f0bc132 (commit) via 54b6d689e5aaa56058e0c95223319221fa735821 (commit) from 27ccd6897640f3dab76624825504a7ae02ddda26 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b05a3c10bff000a498e8f3dbfc161cce44776181 Author: Allan McRae <allan(a)archlinux.org> Date: Tue Oct 15 21:29:22 2019 +1000 Update README for pacman 5.2.0 release This is the first major release without any additions to the libalpm API! Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 719efe19c7372ee7acc243d3d16180163f0bc132 Author: morganamilo <morganamilo(a)gmail.com> Date: Tue Oct 15 10:30:02 2019 +0100 libalpm: set errno in signing dummy functions This allows pacman to print the correct error message when checking keys and libalpm has been compiled without gpgme support. Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 54b6d689e5aaa56058e0c95223319221fa735821 Author: morganamilo <morganamilo(a)gmail.com> Date: Tue Oct 15 10:30:01 2019 +0100 libalpm: fix segfault when -Qip'ing a package The dummy checksigs function never sets count to 0, leaving it unitialized. This caused the siglist cleanup to try and free the empty list. Signed-off-by: Allan McRae <allan(a)archlinux.org> ----------------------------------------------------------------------- Summary of changes: README | 25 +++++++++++++++++++++++++ lib/libalpm/signing.c | 12 ++++++++---- 2 files changed, 33 insertions(+), 4 deletions(-) hooks/post-receive -- The official pacman repository

1 0

[pacman-dev] [PATCH] Update README for pacman 5.2.0 release
by Allan McRae 15 Oct '19

15 Oct '19

This is the first major release without any additions to the libalpm API! Signed-off-by: Allan McRae <allan(a)archlinux.org> --- README | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/README b/README index d96eae21..6818ef70 100644 --- a/README +++ b/README @@ -630,3 +630,28 @@ API CHANGES BETWEEN 5.0 AND 5.1 - alpm_capabilities() - duplicate and add to list - alpm_list_append_strdup() + + +API CHANGES BETWEEN 5.1 AND 5.2 +=============================== + +[REMOVED] +- package delta support + - alpm_delta_t + - alpm_event_delta_patch_t + - alpm_event_t union - removed alpm_event_delta_patch_t + - ALPM_EVENT_DELTA_INTEGRITY_START, ALPM_EVENT_DELTA_INTEGRITY_DONE, + ALPM_EVENT_DELTA_PATCHES_START, ALPM_EVENT_DELTA_PATCHES_DONE, + ALPM_EVENT_DELTA_PATCH_START, ALPM_EVENT_DELTA_PATCH_DONE, + ALPM_EVENT_DELTA_PATCH_FAILED + - ALPM_ERR_DLT_INVALID, ALPM_ERR_DLT_PATCHFAILED + - alpm_option_get_deltaratio() + - alpm_option_set_deltaratio() + - alpm_pkg_get_deltas() + - alpm_pkg_unused_deltas() +- alpm_transflag_t - removed member ALPM_TRANS_FLAG_FORCE + +[CHANGED] +- alpm_errno_t - added member ALPM_ERR_MISSING_CAPABILITY_SIGNATURES +- alpm_sync_newversion() replaced with alpm_sync_get_new_version() which + does not filter on any ALPM_DB_USAGE_*. -- 2.23.0

1 0