April 2021 - Pacman-dev - lists.archlinux.org

[pacman-dev] [PATCH] add front-end provided context to callbacks
by Andrew Gregory 26 Apr '21

26 Apr '21

Our callbacks require front-ends to maintain state in order to provide reasonable output. The new download callback in particular requires much more complex state information to be saved. Without the ability to provide context, state must be saved globally, which may not be possible for all front-ends. Scripting language bindings in particular have no way to register per-handle callbacks without some form of context. Implements: FS#12721 Signed-off-by: Andrew Gregory <andrew.gregory.8(a)gmail.com> --- lib/libalpm/alpm.h | 73 +++++++++++++++++++++++++++++++++++-------- lib/libalpm/dload.c | 11 ++++--- lib/libalpm/handle.c | 54 ++++++++++++++++++++++++++++---- lib/libalpm/handle.h | 12 +++++-- lib/libalpm/log.c | 2 +- src/pacman/callback.c | 18 +++++++---- src/pacman/callback.h | 14 ++++----- src/pacman/conf.c | 18 ++++++----- src/util/testpkg.c | 7 +++-- 9 files changed, 157 insertions(+), 52 deletions(-) diff --git a/lib/libalpm/alpm.h b/lib/libalpm/alpm.h index 833df829..496732d7 100644 --- a/lib/libalpm/alpm.h +++ b/lib/libalpm/alpm.h @@ -971,8 +971,9 @@ typedef union _alpm_event_t { /** Event callback. * * Called when an event occurs + * @param ctx user-provided context * @param event the event that occurred */ -typedef void (*alpm_cb_event)(alpm_event_t *); +typedef void (*alpm_cb_event)(void *ctx, alpm_event_t *); /** * Type of question. @@ -1114,9 +1115,10 @@ typedef union _alpm_question_t { /** Question callback. * * This callback allows user to give input and decide what to do during certain events + * @param ctx user-provided context * @param question the question being asked. */ -typedef void (*alpm_cb_question)(alpm_question_t *); +typedef void (*alpm_cb_question)(void *ctx, alpm_question_t *); /** An enum over different kinds of progress alerts. */ typedef enum _alpm_progress_t { @@ -1147,6 +1149,7 @@ typedef enum _alpm_progress_t { * Alert the front end about the progress of certain events. * Allows the implementation of loading bars for events that * make take a while to complete. + * @param ctx user-provided context * @param progress the kind of event that is progressing * @param pkg for package operations, the name of the package being operated on * @param percent the percent completion of the action @@ -1154,7 +1157,7 @@ typedef enum _alpm_progress_t { * @param current the current amount of items completed */ /** Progress callback */ -typedef void (*alpm_cb_progress)(alpm_progress_t progress, const char *pkg, +typedef void (*alpm_cb_progress)(void *ctx, alpm_progress_t progress, const char *pkg, int percent, size_t howmany, size_t current); /* @@ -1201,22 +1204,24 @@ typedef struct _alpm_download_event_completed_t { } alpm_download_event_completed_t; /** Type of download progress callbacks. + * @param ctx user-provided context * @param filename the name of the file being downloaded * @param event the event type * @param data the event data of type alpm_download_event_*_t */ -typedef void (*alpm_cb_download)(const char *filename, +typedef void (*alpm_cb_download)(void *ctx, const char *filename, alpm_download_event_type_t event, void *data); /** A callback for downloading files + * @param ctx user-provided context * @param url the URL of the file to be downloaded * @param localpath the directory to which the file should be downloaded * @param force whether to force an update, even if the file is the same * @return 0 on success, 1 if the file exists and is identical, -1 on * error. */ -typedef int (*alpm_cb_fetch)(const char *url, const char *localpath, +typedef int (*alpm_cb_fetch)(void *ctx, const char *url, const char *localpath, int force); /* End of libalpm_cb */ @@ -1464,11 +1469,12 @@ typedef enum _alpm_loglevel_t { * libalpm will call this function whenever something is to be logged. * many libalpm will produce log output. Additionally any calls to \link alpm_logaction * \endlink will also call this callback. + * @param ctx user-provided context * @param level the currently set loglevel * @param fmt the printf like format string * @param args printf like arguments */ -typedef void (*alpm_cb_log)(alpm_loglevel_t level, const char *fmt, va_list args); +typedef void (*alpm_cb_log)(void *ctx, alpm_loglevel_t level, const char *fmt, va_list args); /** A printf-like function for logging. * @param handle the context handle @@ -1498,12 +1504,19 @@ int alpm_logaction(alpm_handle_t *handle, const char *prefix, */ alpm_cb_log alpm_option_get_logcb(alpm_handle_t *handle); +/** Returns the callback used for logging. + * @param handle the context handle + * @return the currently set log callback context + */ +void *alpm_option_get_logcb_ctx(alpm_handle_t *handle); + /** Sets the callback used for logging. * @param handle the context handle * @param cb the cb to use + * @param ctx user-provided context to pass to cb * @return 0 on success, -1 on error (pm_errno is set accordingly) */ -int alpm_option_set_logcb(alpm_handle_t *handle, alpm_cb_log cb); +int alpm_option_set_logcb(alpm_handle_t *handle, alpm_cb_log cb, void *ctx); /** Returns the callback used to report download progress. * @param handle the context handle @@ -1511,12 +1524,19 @@ int alpm_option_set_logcb(alpm_handle_t *handle, alpm_cb_log cb); */ alpm_cb_download alpm_option_get_dlcb(alpm_handle_t *handle); +/** Returns the callback used to report download progress. + * @param handle the context handle + * @return the currently set download callback context + */ +void *alpm_option_get_dlcb_ctx(alpm_handle_t *handle); + /** Sets the callback used to report download progress. * @param handle the context handle * @param cb the cb to use + * @param ctx user-provided context to pass to cb * @return 0 on success, -1 on error (pm_errno is set accordingly) */ -int alpm_option_set_dlcb(alpm_handle_t *handle, alpm_cb_download cb); +int alpm_option_set_dlcb(alpm_handle_t *handle, alpm_cb_download cb, void *ctx); /** Returns the downloading callback. * @param handle the context handle @@ -1524,12 +1544,19 @@ int alpm_option_set_dlcb(alpm_handle_t *handle, alpm_cb_download cb); */ alpm_cb_fetch alpm_option_get_fetchcb(alpm_handle_t *handle); +/** Returns the downloading callback. + * @param handle the context handle + * @return the currently set fetch callback context + */ +void *alpm_option_get_fetchcb_ctx(alpm_handle_t *handle); + /** Sets the downloading callback. * @param handle the context handle * @param cb the cb to use + * @param ctx user-provided context to pass to cb * @return 0 on success, -1 on error (pm_errno is set accordingly) */ -int alpm_option_set_fetchcb(alpm_handle_t *handle, alpm_cb_fetch cb); +int alpm_option_set_fetchcb(alpm_handle_t *handle, alpm_cb_fetch cb, void *ctx); /** Returns the callback used for events. * @param handle the context handle @@ -1537,12 +1564,19 @@ int alpm_option_set_fetchcb(alpm_handle_t *handle, alpm_cb_fetch cb); */ alpm_cb_event alpm_option_get_eventcb(alpm_handle_t *handle); +/** Returns the callback used for events. + * @param handle the context handle + * @return the currently set event callback context + */ +void *alpm_option_get_eventcb_ctx(alpm_handle_t *handle); + /** Sets the callback used for events. * @param handle the context handle * @param cb the cb to use + * @param ctx user-provided context to pass to cb * @return 0 on success, -1 on error (pm_errno is set accordingly) */ -int alpm_option_set_eventcb(alpm_handle_t *handle, alpm_cb_event cb); +int alpm_option_set_eventcb(alpm_handle_t *handle, alpm_cb_event cb, void *ctx); /** Returns the callback used for questions. * @param handle the context handle @@ -1550,13 +1584,19 @@ int alpm_option_set_eventcb(alpm_handle_t *handle, alpm_cb_event cb); */ alpm_cb_question alpm_option_get_questioncb(alpm_handle_t *handle); +/** Returns the callback used for questions. + * @param handle the context handle + * @return the currently set question callback context + */ +void *alpm_option_get_questioncb_ctx(alpm_handle_t *handle); + /** Sets the callback used for questions. * @param handle the context handle * @param cb the cb to use + * @param ctx user-provided context to pass to cb * @return 0 on success, -1 on error (pm_errno is set accordingly) */ -int alpm_option_set_questioncb(alpm_handle_t *handle, alpm_cb_question cb); - +int alpm_option_set_questioncb(alpm_handle_t *handle, alpm_cb_question cb, void *ctx); /**Returns the callback used for operation progress. * @param handle the context handle @@ -1564,12 +1604,19 @@ int alpm_option_set_questioncb(alpm_handle_t *handle, alpm_cb_question cb); */ alpm_cb_progress alpm_option_get_progresscb(alpm_handle_t *handle); +/**Returns the callback used for operation progress. + * @param handle the context handle + * @return the currently set progress callback context + */ +void *alpm_option_get_progresscb_ctx(alpm_handle_t *handle); + /** Sets the callback used for operation progress. * @param handle the context handle * @param cb the cb to use + * @param ctx user-provided context to pass to cb * @return 0 on success, -1 on error (pm_errno is set accordingly) */ -int alpm_option_set_progresscb(alpm_handle_t *handle, alpm_cb_progress cb); +int alpm_option_set_progresscb(alpm_handle_t *handle, alpm_cb_progress cb, void *ctx); /* End of callback accessors */ /** @} */ diff --git a/lib/libalpm/dload.c b/lib/libalpm/dload.c index a4c42f8d..70ec318a 100644 --- a/lib/libalpm/dload.c +++ b/lib/libalpm/dload.c @@ -209,7 +209,8 @@ static int dload_progress_cb(void *file, curl_off_t dltotal, curl_off_t dlnow, * download_size (nor included in the total download size callback) */ cb_data.total = dltotal; cb_data.downloaded = dlnow; - payload->handle->dlcb(payload->remote_name, ALPM_DOWNLOAD_PROGRESS, &cb_data); + payload->handle->dlcb(payload->handle->dlcb_ctx, + payload->remote_name, ALPM_DOWNLOAD_PROGRESS, &cb_data); payload->prevprogress = current_size; return 0; @@ -672,7 +673,7 @@ cleanup: alpm_download_event_completed_t cb_data = {0}; cb_data.total = bytes_dl; cb_data.result = ret; - handle->dlcb(payload->remote_name, ALPM_DOWNLOAD_COMPLETED, &cb_data); + handle->dlcb(handle->dlcb_ctx, payload->remote_name, ALPM_DOWNLOAD_COMPLETED, &cb_data); } curl_multi_remove_handle(curlm, curl); @@ -806,7 +807,7 @@ static int curl_download_internal(alpm_handle_t *handle, if(curl_add_payload(handle, curlm, payload, localpath) == 0) { if(handle->dlcb && !payload->signature) { alpm_download_event_init_t cb_data = {.optional = payload->errors_ok}; - handle->dlcb(payload->remote_name, ALPM_DOWNLOAD_INIT, &cb_data); + handle->dlcb(handle->dlcb_ctx, payload->remote_name, ALPM_DOWNLOAD_INIT, &cb_data); } payloads = payloads->next; @@ -877,7 +878,7 @@ int _alpm_download(alpm_handle_t *handle, int success = 0; if(payload->fileurl) { - if (handle->fetchcb(payload->fileurl, localpath, payload->force) != -1) { + if (handle->fetchcb(handle->fetchcb_ctx, payload->fileurl, localpath, payload->force) != -1) { success = 1; break; } @@ -891,7 +892,7 @@ int _alpm_download(alpm_handle_t *handle, MALLOC(fileurl, len, RET_ERR(handle, ALPM_ERR_MEMORY, -1)); snprintf(fileurl, len, "%s/%s", server, payload->filepath); - ret = handle->fetchcb(fileurl, localpath, payload->force); + ret = handle->fetchcb(handle->fetchcb_ctx, fileurl, localpath, payload->force); free(fileurl); if (ret != -1) { diff --git a/lib/libalpm/handle.c b/lib/libalpm/handle.c index 7b8cb1da..86361070 100644 --- a/lib/libalpm/handle.c +++ b/lib/libalpm/handle.c @@ -162,36 +162,72 @@ alpm_cb_log SYMEXPORT alpm_option_get_logcb(alpm_handle_t *handle) return handle->logcb; } +void SYMEXPORT *alpm_option_get_logcb_ctx(alpm_handle_t *handle) +{ + CHECK_HANDLE(handle, return NULL); + return handle->logcb_ctx; +} + alpm_cb_download SYMEXPORT alpm_option_get_dlcb(alpm_handle_t *handle) { CHECK_HANDLE(handle, return NULL); return handle->dlcb; } +void SYMEXPORT *alpm_option_get_dlcb_ctx(alpm_handle_t *handle) +{ + CHECK_HANDLE(handle, return NULL); + return handle->dlcb_ctx; +} + alpm_cb_fetch SYMEXPORT alpm_option_get_fetchcb(alpm_handle_t *handle) { CHECK_HANDLE(handle, return NULL); return handle->fetchcb; } +void SYMEXPORT *alpm_option_get_fetchcb_ctx(alpm_handle_t *handle) +{ + CHECK_HANDLE(handle, return NULL); + return handle->fetchcb_ctx; +} + alpm_cb_event SYMEXPORT alpm_option_get_eventcb(alpm_handle_t *handle) { CHECK_HANDLE(handle, return NULL); return handle->eventcb; } +void SYMEXPORT *alpm_option_get_eventcb_ctx(alpm_handle_t *handle) +{ + CHECK_HANDLE(handle, return NULL); + return handle->eventcb_ctx; +} + alpm_cb_question SYMEXPORT alpm_option_get_questioncb(alpm_handle_t *handle) { CHECK_HANDLE(handle, return NULL); return handle->questioncb; } +void SYMEXPORT *alpm_option_get_questioncb_ctx(alpm_handle_t *handle) +{ + CHECK_HANDLE(handle, return NULL); + return handle->questioncb_ctx; +} + alpm_cb_progress SYMEXPORT alpm_option_get_progresscb(alpm_handle_t *handle) { CHECK_HANDLE(handle, return NULL); return handle->progresscb; } +void SYMEXPORT *alpm_option_get_progresscb_ctx(alpm_handle_t *handle) +{ + CHECK_HANDLE(handle, return NULL); + return handle->progresscb_ctx; +} + const char SYMEXPORT *alpm_option_get_root(alpm_handle_t *handle) { CHECK_HANDLE(handle, return NULL); @@ -300,45 +336,51 @@ int SYMEXPORT alpm_option_get_parallel_downloads(alpm_handle_t *handle) return handle->parallel_downloads; } -int SYMEXPORT alpm_option_set_logcb(alpm_handle_t *handle, alpm_cb_log cb) +int SYMEXPORT alpm_option_set_logcb(alpm_handle_t *handle, alpm_cb_log cb, void *ctx) { CHECK_HANDLE(handle, return -1); handle->logcb = cb; + handle->logcb_ctx = ctx; return 0; } -int SYMEXPORT alpm_option_set_dlcb(alpm_handle_t *handle, alpm_cb_download cb) +int SYMEXPORT alpm_option_set_dlcb(alpm_handle_t *handle, alpm_cb_download cb, void *ctx) { CHECK_HANDLE(handle, return -1); handle->dlcb = cb; + handle->dlcb_ctx = ctx; return 0; } -int SYMEXPORT alpm_option_set_fetchcb(alpm_handle_t *handle, alpm_cb_fetch cb) +int SYMEXPORT alpm_option_set_fetchcb(alpm_handle_t *handle, alpm_cb_fetch cb, void *ctx) { CHECK_HANDLE(handle, return -1); handle->fetchcb = cb; + handle->fetchcb_ctx = ctx; return 0; } -int SYMEXPORT alpm_option_set_eventcb(alpm_handle_t *handle, alpm_cb_event cb) +int SYMEXPORT alpm_option_set_eventcb(alpm_handle_t *handle, alpm_cb_event cb, void *ctx) { CHECK_HANDLE(handle, return -1); handle->eventcb = cb; + handle->eventcb_ctx = ctx; return 0; } -int SYMEXPORT alpm_option_set_questioncb(alpm_handle_t *handle, alpm_cb_question cb) +int SYMEXPORT alpm_option_set_questioncb(alpm_handle_t *handle, alpm_cb_question cb, void *ctx) { CHECK_HANDLE(handle, return -1); handle->questioncb = cb; + handle->questioncb_ctx = ctx; return 0; } -int SYMEXPORT alpm_option_set_progresscb(alpm_handle_t *handle, alpm_cb_progress cb) +int SYMEXPORT alpm_option_set_progresscb(alpm_handle_t *handle, alpm_cb_progress cb, void *ctx) { CHECK_HANDLE(handle, return -1); handle->progresscb = cb; + handle->progresscb_ctx = ctx; return 0; } diff --git a/lib/libalpm/handle.h b/lib/libalpm/handle.h index 2d8d0f9e..9d938d18 100644 --- a/lib/libalpm/handle.h +++ b/lib/libalpm/handle.h @@ -34,19 +34,19 @@ #define EVENT(h, e) \ do { \ if((h)->eventcb) { \ - (h)->eventcb((alpm_event_t *) (e)); \ + (h)->eventcb((h)->eventcb_ctx, (alpm_event_t *) (e)); \ } \ } while(0) #define QUESTION(h, q) \ do { \ if((h)->questioncb) { \ - (h)->questioncb((alpm_question_t *) (q)); \ + (h)->questioncb((h)->questioncb_ctx, (alpm_question_t *) (q)); \ } \ } while(0) #define PROGRESS(h, e, p, per, n, r) \ do { \ if((h)->progresscb) { \ - (h)->progresscb(e, p, per, n, r); \ + (h)->progresscb((h)->progresscb_ctx, e, p, per, n, r); \ } \ } while(0) @@ -72,11 +72,17 @@ struct __alpm_handle_t { /* callback functions */ alpm_cb_log logcb; /* Log callback function */ + void *logcb_ctx; alpm_cb_download dlcb; /* Download callback function */ + void *dlcb_ctx; alpm_cb_fetch fetchcb; /* Download file callback function */ + void *fetchcb_ctx; alpm_cb_event eventcb; + void *eventcb_ctx; alpm_cb_question questioncb; + void *questioncb_ctx; alpm_cb_progress progresscb; + void *progresscb_ctx; /* filesystem paths */ char *root; /* Root path, default '/' */ diff --git a/lib/libalpm/log.c b/lib/libalpm/log.c index 4c781ea2..c4d291cb 100644 --- a/lib/libalpm/log.c +++ b/lib/libalpm/log.c @@ -107,6 +107,6 @@ void _alpm_log(alpm_handle_t *handle, alpm_loglevel_t flag, const char *fmt, ... } va_start(args, fmt); - handle->logcb(flag, fmt, args); + handle->logcb(handle->logcb_ctx, flag, fmt, args); va_end(args); } diff --git a/src/pacman/callback.c b/src/pacman/callback.c index a28a79a9..13e38122 100644 --- a/src/pacman/callback.c +++ b/src/pacman/callback.c @@ -232,8 +232,9 @@ static int number_length(size_t n) } /* callback to handle messages/notifications from libalpm transactions */ -void cb_event(alpm_event_t *event) +void cb_event(void *ctx, alpm_event_t *event) { + (void)ctx; if(config->print) { console_cursor_move_end(); return; @@ -434,8 +435,9 @@ void cb_event(alpm_event_t *event) } /* callback to handle questions from libalpm transactions (yes/no) */ -void cb_question(alpm_question_t *question) +void cb_question(void *ctx, alpm_question_t *question) { + (void)ctx; if(config->print) { switch(question->type) { case ALPM_QUESTION_INSTALL_IGNOREPKG: @@ -556,8 +558,8 @@ void cb_question(alpm_question_t *question) } /* callback to handle display of transaction progress */ -void cb_progress(alpm_progress_t event, const char *pkgname, int percent, - size_t howmany, size_t current) +void cb_progress(void *ctx, alpm_progress_t event, const char *pkgname, + int percent, size_t howmany, size_t current) { static int prevpercent; static size_t prevcurrent; @@ -571,6 +573,8 @@ void cb_progress(alpm_progress_t event, const char *pkgname, int percent, const unsigned short cols = getcols(); + (void)ctx; + if(config->noprogressbar || cols == 0) { return; } @@ -1069,8 +1073,9 @@ static void dload_complete_event(const char *filename, alpm_download_event_compl } /* Callback to handle display of download progress */ -void cb_download(const char *filename, alpm_download_event_type_t event, void *data) +void cb_download(void *ctx, const char *filename, alpm_download_event_type_t event, void *data) { + (void)ctx; if(event == ALPM_DOWNLOAD_INIT) { dload_init_event(filename, data); } else if(event == ALPM_DOWNLOAD_PROGRESS) { @@ -1084,8 +1089,9 @@ void cb_download(const char *filename, alpm_download_event_type_t event, void *d } /* Callback to handle notifications from the library */ -void cb_log(alpm_loglevel_t level, const char *fmt, va_list args) +void cb_log(void *ctx, alpm_loglevel_t level, const char *fmt, va_list args) { + (void)ctx; if(!fmt || strlen(fmt) == 0) { return; } diff --git a/src/pacman/callback.h b/src/pacman/callback.h index 8ac9d960..83cf8cdd 100644 --- a/src/pacman/callback.h +++ b/src/pacman/callback.h @@ -26,22 +26,22 @@ #include <alpm.h> /* callback to handle messages/notifications from libalpm */ -void cb_event(alpm_event_t *event); +void cb_event(void *ctx, alpm_event_t *event); /* callback to handle questions from libalpm (yes/no) */ -void cb_question(alpm_question_t *question); +void cb_question(void *ctx, alpm_question_t *question); /* callback to handle display of progress */ -void cb_progress(alpm_progress_t event, const char *pkgname, int percent, - size_t howmany, size_t remain); +void cb_progress(void *ctx, alpm_progress_t event, const char *pkgname, + int percent, size_t howmany, size_t remain); /* callback to handle display of download progress */ -void cb_download(const char *filename, alpm_download_event_type_t event, +void cb_download(void *ctx, const char *filename, alpm_download_event_type_t event, void *data); /* callback to handle messages/notifications from pacman library */ -__attribute__((format(printf, 2, 0))) -void cb_log(alpm_loglevel_t level, const char *fmt, va_list args); +__attribute__((format(printf, 3, 0))) +void cb_log(void *ctx, alpm_loglevel_t level, const char *fmt, va_list args); /* specify if multibar UI should move completed bars to the top of the screen */ void multibar_move_completed_up(bool value); diff --git a/src/pacman/conf.c b/src/pacman/conf.c index a4f2ba35..877913b0 100644 --- a/src/pacman/conf.c +++ b/src/pacman/conf.c @@ -277,8 +277,8 @@ static int systemvp(const char *file, char *const argv[]) } /** External fetch callback */ -static int download_with_xfercommand(const char *url, const char *localpath, - int force) +static int download_with_xfercommand(void *ctx, const char *url, + const char *localpath, int force) { int ret = 0, retval; int usepart = 0; @@ -288,6 +288,8 @@ static int download_with_xfercommand(const char *url, const char *localpath, const char **argv; size_t i; + (void)ctx; + if(!config->xfercommand_argv) { return -1; } @@ -836,11 +838,11 @@ static int setup_libalpm(void) } config->handle = handle; - alpm_option_set_logcb(handle, cb_log); - alpm_option_set_dlcb(handle, cb_download); - alpm_option_set_eventcb(handle, cb_event); - alpm_option_set_questioncb(handle, cb_question); - alpm_option_set_progresscb(handle, cb_progress); + alpm_option_set_logcb(handle, cb_log, NULL); + alpm_option_set_dlcb(handle, cb_download, NULL); + alpm_option_set_eventcb(handle, cb_event, NULL); + alpm_option_set_questioncb(handle, cb_question, NULL); + alpm_option_set_progresscb(handle, cb_progress, NULL); if(config->op == PM_OP_FILES) { alpm_option_set_dbext(handle, ".files"); @@ -887,7 +889,7 @@ static int setup_libalpm(void) } if(config->xfercommand) { - alpm_option_set_fetchcb(handle, download_with_xfercommand); + alpm_option_set_fetchcb(handle, download_with_xfercommand, NULL); } else if(!(alpm_capabilities() & ALPM_CAPABILITY_DOWNLOADER)) { pm_printf(ALPM_LOG_WARNING, _("no '%s' configured\n"), "XferCommand"); } diff --git a/src/util/testpkg.c b/src/util/testpkg.c index 28dcdc50..26600a9d 100644 --- a/src/util/testpkg.c +++ b/src/util/testpkg.c @@ -24,9 +24,10 @@ #include <alpm.h> #include "util.h" /* For Localization */ -__attribute__((format(printf, 2, 0))) -static void output_cb(alpm_loglevel_t level, const char *fmt, va_list args) +__attribute__((format(printf, 3, 0))) +static void output_cb(void *ctx, alpm_loglevel_t level, const char *fmt, va_list args) { + (void)ctx; if(fmt[0] == '\0') { return; } @@ -64,7 +65,7 @@ int main(int argc, char *argv[]) } /* let us get log messages from libalpm */ - alpm_option_set_logcb(handle, output_cb); + alpm_option_set_logcb(handle, output_cb, NULL); /* set gpgdir to default */ alpm_option_set_gpgdir(handle, GPGDIR); -- 2.31.1

2 1

[pacman-dev] [PATCH] document commit a33cdac10bf1a68279ea1b9baa26aa09126f1ca4
by Eli Schwartz 26 Apr '21

26 Apr '21

Signed-off-by: Eli Schwartz <eschwartz(a)archlinux.org> --- doc/makepkg.8.asciidoc | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/doc/makepkg.8.asciidoc b/doc/makepkg.8.asciidoc index 3b5e61b31..38032e7bb 100644 --- a/doc/makepkg.8.asciidoc +++ b/doc/makepkg.8.asciidoc @@ -279,6 +279,14 @@ Environment Variables **SOURCE_DATE_EPOCH=**"<date>":: Used for link:https://reproducible-builds.org/docs/[Reproducible Builds]. +**BUILDTOOL=**"<name>":: + The name of a tool ecosystem used to set up the build environment. Used for + defining a spec for reproducible builds, e.g. the linkman:makepkg.conf[5] + used. + +**BUILDTOOLVER=**"<version>":: + The version of the '$BUILDTOOL' used. + Configuration ------------- See linkman:makepkg.conf[5] for more details on configuring makepkg using the -- 2.31.1

2 1

[pacman-dev] [PATCH] makepkg: add tool details to buildinfo to aid determining flags
by anthraxx＠archlinux.org 23 Apr '21

23 Apr '21

From: Levente Polyak <anthraxx(a)archlinux.org> If a makepkg consumer uses a build wrapper to override compiler flags this may lead to unreproducible packages as there is no way to know which exact files were used for tooling that tries to reproduce said package. Instead of vendoring the whole used makepkg.conf file into buildinfo, this patch adds two new properties to the .BUILDINFO file named BUILDTOOL and BUILDTOOLVER which by default are simply makepkg's own values. Downstream consumers may override those values: For example in Arch Linux the devtools package can set those values and allow reproducible builds tooling to fetch the appropriate makepkg.conf. Signed-off-by: Levente Polyak <anthraxx(a)archlinux.org> --- scripts/makepkg.sh.in | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index 92cb6398..e58edfa1 100644 --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in @@ -651,6 +651,8 @@ write_buildinfo() { write_kv_pair "builddate" "${SOURCE_DATE_EPOCH}" write_kv_pair "builddir" "${BUILDDIR}" write_kv_pair "startdir" "${startdir}" + write_kv_pair "buildtool" "${BUILDTOOL:-makepkg}" + write_kv_pair "buildtoolver" "${BUILDTOOLVER:-$makepkg_version}" write_kv_pair "buildenv" "${BUILDENV[@]}" write_kv_pair "options" "${OPTIONS[@]}" -- 2.31.1

6 12

[pacman-dev] [PATCH 1/2] libmakepkg: always remap debug prefix
by morganamilo 23 Apr '21

23 Apr '21

Sometimes non debug flags still generate debug symbols. So always remap them. diff --git a/scripts/libmakepkg/buildenv/debugflags.sh.in b/scripts/libmakepkg/buildenv/debugflags.sh.in index 60913080..52ff4750 100644 --- a/scripts/libmakepkg/buildenv/debugflags.sh.in +++ b/scripts/libmakepkg/buildenv/debugflags.sh.in @@ -30,9 +30,6 @@ buildenv_functions+=('buildenv_debugflags') buildenv_debugflags() { if check_option "debug" "y"; then - DEBUG_CFLAGS+=" -fdebug-prefix-map=$srcdir=${DBGSRCDIR:-/usr/src/debug}" - DEBUG_CXXFLAGS+=" -fdebug-prefix-map=$srcdir=${DBGSRCDIR:-/usr/src/debug}" - DEBUG_RUSTFLAGS+=" --remap-path-prefix=$srcdir=${DBGSRCDIR:-/usr/src/debug}" CFLAGS+=" $DEBUG_CFLAGS" CXXFLAGS+=" $DEBUG_CXXFLAGS" RUSTFLAGS+=" $DEBUG_RUSTFLAGS" diff --git a/scripts/libmakepkg/buildenv/flags.sh.in b/scripts/libmakepkg/buildenv/flags.sh.in new file mode 100644 index 00000000..d41556d3 --- /dev/null +++ b/scripts/libmakepkg/buildenv/flags.sh.in @@ -0,0 +1,34 @@ +#!/usr/bin/bash +# +# debugflags.sh - Specify default flags for building a package +# +# Copyright (c) 2012-2021 Pacman Development Team <pacman-dev(a)archlinux.org> +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see <http://www.gnu.org/licenses/>. +# + +[[ -n "$LIBMAKEPKG_BUILDENV_FLAGS_SH" ]] && return +LIBMAKEPKG_BUILDENV_FLAGS_SH=1 + +LIBRARY=${LIBRARY:-'@libmakepkgdir@'} + +source "$LIBRARY/util/option.sh" + +buildenv_functions+=('buildenv_flags') + +buildenv_flags() { + CFLAGS+=" -fdebug-prefix-map=$srcdir=${DBGSRCDIR:-/usr/src/debug}" + CXXFLAGS+=" -fdebug-prefix-map=$srcdir=${DBGSRCDIR:-/usr/src/debug}" + RUSTFLAGS+=" --remap-path-prefix=$srcdir=${DBGSRCDIR:-/usr/src/debug}" +} diff --git a/scripts/libmakepkg/buildenv/meson.build b/scripts/libmakepkg/buildenv/meson.build index b72d91c0..a69accb7 100644 --- a/scripts/libmakepkg/buildenv/meson.build +++ b/scripts/libmakepkg/buildenv/meson.build @@ -4,6 +4,7 @@ sources = [ 'buildflags.sh.in', 'compiler.sh.in', 'debugflags.sh.in', + 'flags.sh.in', 'lto.sh.in', 'makeflags.sh.in', ] -- 2.31.1

3 7

[pacman-dev] Fwd: pacman-6.0 slushy freeze
by Luna Jernberg 23 Apr '21

23 Apr '21

Started helping with the Swedish translation today ---------- Forwarded message --------- From: Luna Jernberg <droidbittin(a)gmail.com> Date: Fri, Apr 23, 2021 at 5:00 AM Subject: Re: [pacman-dev] pacman-6.0 slushy freeze To: <allan(a)archlinux.org> 2 strings left i am unsure of at the moment On Fri, Apr 23, 2021 at 4:41 AM Luna Jernberg <droidbittin(a)gmail.com> wrote: > Started with the Swedish translation now > > On Fri, Apr 23, 2021 at 2:04 AM Allan McRae <allan(a)archlinux.org> wrote: > >> Hi all, >> >> We are now in a slushy freeze for pacman-6.0. >> >> This means I will not look at new patches unless they fix a breakage. >> However, I aim to get through the few patches I have not looked at that >> were submitted before now (and revisions of those patches if quickly >> done). >> >> I will also pull the final 5.2.x translation files from Transifex, and >> push the 6.0 strings (again noting, slushy freeze, so strings may change). >> >> Allan >> >

2 1

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v6.0.0alpha1-99-g558d08d8
by Allan McRae 23 Apr '21

23 Apr '21

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, master has been updated via 558d08d821a6797c972acdf02e03aa1a1ff49917 (commit) via 15270d4a344a5d5cbf992aac58913c9356a80927 (commit) from 8fe552070945561a0cd4dc24d3fcb22ed377f1a0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 558d08d821a6797c972acdf02e03aa1a1ff49917 Author: Allan McRae <allan(a)archlinux.org> Date: Fri Apr 23 10:44:27 2021 +1000 Prepare translations for next release Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 15270d4a344a5d5cbf992aac58913c9356a80927 Author: Andrew Gregory <andrew(a)archlinux.org> Date: Mon Jun 22 02:12:41 2020 -0700 update NEWS for 5.2.2 Signed-off-by: Andrew Gregory <andrew(a)archlinux.org> ----------------------------------------------------------------------- Summary of changes: NEWS | 30 + lib/libalpm/po/LINGUAS | 1 + lib/libalpm/po/ar.po | 267 +++--- lib/libalpm/po/ast.po | 267 +++--- lib/libalpm/po/bg.po | 267 +++--- lib/libalpm/po/br.po | 267 +++--- lib/libalpm/po/ca.po | 267 +++--- lib/libalpm/po/cs.po | 282 +++--- lib/libalpm/po/da.po | 267 +++--- lib/libalpm/po/de.po | 284 +++--- lib/libalpm/po/el.po | 295 ++++--- lib/libalpm/po/en_GB.po | 267 +++--- lib/libalpm/po/eo.po | 499 +++++------ lib/libalpm/po/es.po | 267 +++--- lib/libalpm/po/es_419.po | 271 +++--- lib/libalpm/po/eu.po | 271 +++--- lib/libalpm/po/eu_ES.po | 271 +++--- lib/libalpm/po/fi.po | 267 +++--- lib/libalpm/po/fr.po | 275 +++--- lib/libalpm/po/gl.po | 267 +++--- lib/libalpm/po/hi.po | 1038 ++++++++++++++++++++++ lib/libalpm/po/hr.po | 267 +++--- lib/libalpm/po/hu.po | 267 +++--- lib/libalpm/po/id.po | 267 +++--- lib/libalpm/po/it.po | 273 +++--- lib/libalpm/po/ja.po | 271 +++--- lib/libalpm/po/kk.po | 267 +++--- lib/libalpm/po/ko.po | 267 +++--- lib/libalpm/po/libalpm.pot | 271 +++--- lib/libalpm/po/lt.po | 267 +++--- lib/libalpm/po/nb.po | 281 +++--- lib/libalpm/po/nl.po | 269 +++--- lib/libalpm/po/pl.po | 280 +++--- lib/libalpm/po/pt.po | 267 +++--- lib/libalpm/po/pt_BR.po | 267 +++--- lib/libalpm/po/ro.po | 271 +++--- lib/libalpm/po/ru.po | 267 +++--- lib/libalpm/po/sk.po | 290 ++++--- lib/libalpm/po/sl.po | 269 +++--- lib/libalpm/po/sr.po | 277 +++--- lib/libalpm/po/sr(a)latin.po | 277 +++--- lib/libalpm/po/sv.po | 340 ++++---- lib/libalpm/po/tr.po | 275 +++--- lib/libalpm/po/uk.po | 267 +++--- lib/libalpm/po/zh_CN.po | 286 ++++--- lib/libalpm/po/zh_TW.po | 267 +++--- scripts/po/LINGUAS | 1 + scripts/po/bg.po | 645 +++++++------- scripts/po/br.po | 636 +++++++------- scripts/po/ca.po | 676 ++++++++------- scripts/po/cs.po | 686 +++++++-------- scripts/po/da.po | 649 +++++++------- scripts/po/de.po | 701 +++++++-------- scripts/po/el.po | 688 +++++++-------- scripts/po/en_GB.po | 648 +++++++------- scripts/po/eo.po | 662 +++++++------- scripts/po/es.po | 673 ++++++++------- scripts/po/es_419.po | 662 +++++++------- scripts/po/eu.po | 645 +++++++------- scripts/po/eu_ES.po | 645 +++++++------- scripts/po/fi.po | 589 ++++++------- scripts/po/fr.po | 668 ++++++++------- scripts/po/gl.po | 659 +++++++------- scripts/po/hi.po | 1609 ++++++++++++++++++++++++++++++++++ scripts/po/hu.po | 659 +++++++------- scripts/po/id.po | 633 +++++++------- scripts/po/it.po | 661 +++++++------- scripts/po/ja.po | 672 ++++++++------- scripts/po/ko.po | 650 +++++++------- scripts/po/lt.po | 667 ++++++++------- scripts/po/nb.po | 664 +++++++------- scripts/po/nl.po | 656 +++++++------- scripts/po/pacman-scripts.pot | 564 ++++++------ scripts/po/pl.po | 687 +++++++-------- scripts/po/pt.po | 646 +++++++------- scripts/po/pt_BR.po | 660 +++++++------- scripts/po/ro.po | 643 +++++++------- scripts/po/ru.po | 653 +++++++------- scripts/po/sk.po | 642 +++++++------- scripts/po/sl.po | 620 +++++++------- scripts/po/sr.po | 658 +++++++------- scripts/po/sr(a)latin.po | 658 +++++++------- scripts/po/sv.po | 732 ++++++++-------- scripts/po/tr.po | 662 +++++++------- scripts/po/uk.po | 653 +++++++------- scripts/po/zh_CN.po | 714 ++++++++-------- scripts/po/zh_TW.po | 667 ++++++++------- src/pacman/po/LINGUAS | 1 + src/pacman/po/ar.po | 565 ++++++------ src/pacman/po/ast.po | 565 ++++++------ src/pacman/po/bg.po | 565 ++++++------ src/pacman/po/br.po | 569 ++++++------ src/pacman/po/ca.po | 569 ++++++------ src/pacman/po/cs.po | 643 +++++++------- src/pacman/po/da.po | 567 ++++++------ src/pacman/po/de.po | 1052 ++++++++++++----------- src/pacman/po/el.po | 632 +++++++------- src/pacman/po/en_GB.po | 567 ++++++------ src/pacman/po/eo.po | 603 +++++++------ src/pacman/po/es.po | 577 +++++++------ src/pacman/po/es_419.po | 594 +++++++------ src/pacman/po/eu.po | 570 ++++++------ src/pacman/po/eu_ES.po | 570 ++++++------ src/pacman/po/fi.po | 568 ++++++------ src/pacman/po/fr.po | 610 +++++++------ src/pacman/po/gl.po | 573 +++++++------ src/pacman/po/hi.po | 1902 +++++++++++++++++++++++++++++++++++++++++ src/pacman/po/hr.po | 588 +++++++------ src/pacman/po/hu.po | 563 ++++++------ src/pacman/po/id.po | 567 ++++++------ src/pacman/po/it.po | 573 +++++++------ src/pacman/po/ja.po | 571 +++++++------ src/pacman/po/ko.po | 573 +++++++------ src/pacman/po/lt.po | 577 +++++++------ src/pacman/po/nb.po | 625 +++++++------- src/pacman/po/nl.po | 717 ++++++++-------- src/pacman/po/pacman.pot | 561 ++++++------ src/pacman/po/pl.po | 628 +++++++------- src/pacman/po/pt.po | 570 ++++++------ src/pacman/po/pt_BR.po | 569 ++++++------ src/pacman/po/ro.po | 576 +++++++------ src/pacman/po/ru.po | 563 ++++++------ src/pacman/po/sk.po | 569 ++++++------ src/pacman/po/sl.po | 594 +++++++------ src/pacman/po/sr.po | 575 +++++++------ src/pacman/po/sr(a)latin.po | 575 +++++++------ src/pacman/po/sv.po | 655 +++++++------- src/pacman/po/tr.po | 575 +++++++------ src/pacman/po/uk.po | 573 +++++++------ src/pacman/po/zh_CN.po | 625 +++++++------- src/pacman/po/zh_TW.po | 563 ++++++------ 131 files changed, 37438 insertions(+), 29866 deletions(-) create mode 100644 lib/libalpm/po/hi.po create mode 100644 scripts/po/hi.po create mode 100644 src/pacman/po/hi.po hooks/post-receive -- The official pacman repository

1 0

[pacman-dev] [GIT] The official pacman repository branch, release/5.2.x, updated. v5.2.2-1-gf55c9f30
by Allan McRae 23 Apr '21

23 Apr '21

1 0

[pacman-dev] pacman-6.0 slushy freeze
by Allan McRae 23 Apr '21

23 Apr '21

Hi all, We are now in a slushy freeze for pacman-6.0. This means I will not look at new patches unless they fix a breakage. However, I aim to get through the few patches I have not looked at that were submitted before now (and revisions of those patches if quickly done). I will also pull the final 5.2.x translation files from Transifex, and push the 6.0 strings (again noting, slushy freeze, so strings may change). Allan

1 0

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v6.0.0alpha1-97-g8fe55207
by Allan McRae 22 Apr '21

22 Apr '21

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, master has been updated via 8fe552070945561a0cd4dc24d3fcb22ed377f1a0 (commit) via 079b9d44e2faadd83856de07f890bae5cc51c5a4 (commit) via 41f9c50abf08e71aa5fd03568934ab80abc7715c (commit) via 63ad8b8b7639ac29fad6c4e0dcc699510c47d587 (commit) via a33cdac10bf1a68279ea1b9baa26aa09126f1ca4 (commit) via 3179db108a83104d9de6d1d607f55f8118e92160 (commit) via abdb4d7fa699ae3b8ff09ba79656f6853b9a1357 (commit) via 0699321b3ce71c46fbd0a10fede3959d0fac7009 (commit) via 288cd1c74afc5ff2e28b9a45a76d2146da583903 (commit) via 3688c947f86f1ddbb24d6bf3b8b42fbe0be6fd0e (commit) via 207f0439eeecb505f74590af481236ec60c09876 (commit) from c294b7cb4c3a160cbbbe404baeaa23a3c8290a99 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8fe552070945561a0cd4dc24d3fcb22ed377f1a0 Author: Eli Schwartz <eschwartz(a)archlinux.org> Date: Mon Apr 19 22:25:51 2021 -0400 meson: make our symlinking script more portable We do not need the --relative case as it is dead code (we only ever link a filename without directory components). For the rest, GNU-specific ln -T does two things: - if the link name is an existing directory, ln fails instead of creating a surprising link inside the directory - if the link name is a symlink to a directory, ln treats it as a file, and due to -f, unlinks it The second case can be portably solved by ln -n, and both cases can be solved by doing what the original autotools Makefile did: rm -f && ln -s If the file exists, it will be removed. If it cannot be removed, it must be an ordinary directory, and the script aborts with an error. Signed-off-by: Eli Schwartz <eschwartz(a)archlinux.org> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 079b9d44e2faadd83856de07f890bae5cc51c5a4 Author: morganamilo <morganamilo(a)archlinux.org> Date: Sun Apr 18 20:59:44 2021 +0100 Only enable total progress when downloads > 1 Otherwise the total progress will just match the one package and be pretty useless. commit 41f9c50abf08e71aa5fd03568934ab80abc7715c Author: morganamilo <morganamilo(a)archlinux.org> Date: Sun Apr 18 20:59:43 2021 +0100 Always enable TotalDownload Previously TotalDownload would switch the % download from per package to overall. Meaning you had a choice of which information to dispplay. Now with parallel downloads TotalDownload adds an extra progress bar. There's no reason to have this an off by default feature. Let's just make it always on. Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 63ad8b8b7639ac29fad6c4e0dcc699510c47d587 Author: morganamilo <morganamilo(a)archlinux.org> Date: Tue Apr 20 09:48:20 2021 +0100 pacman: fix total bar leaking Signed-off-by: Allan McRae <allan(a)archlinux.org> commit a33cdac10bf1a68279ea1b9baa26aa09126f1ca4 Author: Levente Polyak <anthraxx(a)archlinux.org> Date: Thu Apr 22 21:46:56 2021 +0200 makepkg: add tool details to buildinfo to aid determining flags If a makepkg consumer uses a build wrapper to override compiler flags this may lead to unreproducible packages as there is no way to know which exact files were used for tooling that tries to reproduce said package. Instead of vendoring the whole used makepkg.conf file into buildinfo, this patch adds two new properties to the .BUILDINFO file named BUILDTOOL and BUILDTOOLVER which by default are simply makepkg's own values. Downstream consumers may override those values: For example in Arch Linux the devtools package can set those values and allow reproducible builds tooling to fetch the appropriate makepkg.conf. Signed-off-by: Levente Polyak <anthraxx(a)archlinux.org> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 3179db108a83104d9de6d1d607f55f8118e92160 Author: Dan McGee <dan(a)archlinux.org> Date: Wed Apr 21 22:47:13 2021 +1000 Add support for multiple 'Architecture' values This allows architecture to be multivalued. On x86-64 machines, this could be something like: Architecture = x86-64-v3 x86-64 We use the first specified Architecture value in mirrorlist $arch variable replacement, as this is backwards-compatible and sane. Original-patch-by: Dan McGee <dan(a)archlinux.org> Patch-updated-by: Allan McRae <allan(a)archlinux.org> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit abdb4d7fa699ae3b8ff09ba79656f6853b9a1357 Author: morganamilo <morganamilo(a)archlinux.org> Date: Mon Apr 19 10:36:14 2021 +0100 pacman: stop eta timer breaking allignment When the download estimate is over an hour the format displayed changes from mm:ss to hh:mm:ss. This causes everything to be out of alignment due to the extra characters. So instead lets just go back to --:-- when the download => 100 minutes. Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 0699321b3ce71c46fbd0a10fede3959d0fac7009 Author: Eli Schwartz <eschwartz(a)archlinux.org> Date: Sun Apr 18 23:25:13 2021 -0400 meson: make -uninstalled.pc correct This pkg-config file is automatically created in the meson-uninstalled/ directory of the build tree, and points to the built artifacts there. If this directory is added to PKG_CONFIG_PATH, it will be preferred over an installed copy. Making this work properly means it becomes trivially possible to build a private copy of libalpm, and then compile other projects using it rather than the system copy. Signed-off-by: Eli Schwartz <eschwartz(a)archlinux.org> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 288cd1c74afc5ff2e28b9a45a76d2146da583903 Author: Mark Weiman <mark.weiman(a)markzz.com> Date: Fri Apr 16 23:45:23 2021 -0400 Fix build error when SIGPOLL is not available On Linux, SIGPOLL is a valid signal, but on systems like FreeBSD, it is not. This patch does a preprocessor check to see if SIGPOLL is available or not. Signed-off-by: Mark Weiman <mark.weiman(a)markzz.com> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 3688c947f86f1ddbb24d6bf3b8b42fbe0be6fd0e Author: Mark Weiman <mark.weiman(a)markzz.com> Date: Fri Apr 16 23:45:22 2021 -0400 Add an include for signal.h when needed On Linux, signal.h is not required to have access to the signal constants. On FreeBSD, this is not the case and requires signal.h to be explicitly included. This patch adds an include for signal.h in any source file that uses it. Signed-off-by: Mark Weiman <mark.weiman(a)markzz.com> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 207f0439eeecb505f74590af481236ec60c09876 Author: Mark Weiman <mark.weiman(a)markzz.com> Date: Fri Apr 16 23:45:21 2021 -0400 meson.build: Fix detection of symbols This patch changes the behavior of meson to define configuration options *only* when the symbol checked is present. Currently, it defines all of them in config.h whether the symbol exists or not and the code that looks for it doesn't check the macro's value, but whether it's defined. Signed-off-by: Mark Weiman <mark.weiman(a)markzz.com> Signed-off-by: Allan McRae <allan(a)archlinux.org> ----------------------------------------------------------------------- Summary of changes: README | 4 +-- build-aux/meson-make-symlink.sh | 8 ++--- doc/pacman.conf.5.asciidoc | 15 +++------ etc/pacman.conf.in | 1 - lib/libalpm/alpm.h | 30 ++++++++++++------ lib/libalpm/handle.c | 30 ++++++++++++++---- lib/libalpm/handle.h | 2 +- lib/libalpm/trans.c | 21 ++++++++++-- lib/libalpm/util.c | 9 ++++-- meson.build | 5 ++- scripts/completion/zsh_completion.in | 1 - scripts/makepkg.sh.in | 2 ++ src/pacman/callback.c | 18 +++++------ src/pacman/conf.c | 37 +++++++++++++--------- src/pacman/conf.h | 7 ++-- src/pacman/pacman-conf.c | 7 ++-- src/pacman/pacman.c | 2 +- test/pacman/meson.build | 2 ++ .../{upgrade071.py => multiple-architectures01.py} | 8 ++--- .../{upgrade084.py => multiple-architectures02.py} | 8 ++--- 20 files changed, 132 insertions(+), 85 deletions(-) copy test/pacman/tests/{upgrade071.py => multiple-architectures01.py} (57%) copy test/pacman/tests/{upgrade084.py => multiple-architectures02.py} (54%) hooks/post-receive -- The official pacman repository

1 0

[pacman-dev] [PATCH] pacman: fix total bar leaking
by morganamilo 22 Apr '21

22 Apr '21

diff --git a/src/pacman/callback.c b/src/pacman/callback.c index 5e910136..faecbc5b 100644 --- a/src/pacman/callback.c +++ b/src/pacman/callback.c @@ -340,7 +340,7 @@ void cb_event(alpm_event_t *event) on_progress = 1; list_total_pkgs = event->pkg_retrieve.num; list_total = event->pkg_retrieve.total_size; - total_enabled = config->totaldownload && list_total; + total_enabled = config->totaldownload && list_total && dload_progressbar_enabled(); if(total_enabled) { init_total_progressbar(); } @@ -405,9 +405,10 @@ void cb_event(alpm_event_t *event) case ALPM_EVENT_PKG_RETRIEVE_DONE: case ALPM_EVENT_PKG_RETRIEVE_FAILED: console_cursor_move_end(); - if(total_enabled && dload_progressbar_enabled()) { + if(total_enabled) { update_bar_finalstats(totalbar); draw_pacman_progress_bar(totalbar); + free(totalbar); printf("\n"); } total_enabled = 0; -- 2.31.1

2 1