- Pacman-dev - lists.archlinux.org

[Git][pacman/pacman][master] pacman-key: allow overriding KEYRING_IMPORT_DIR with --populate-from
by Allan McRae (＠allan) 06 Sep '23

06 Sep '23

Allan McRae pushed to branch master at Pacman / Pacman Commits: 36d70a93 by InsanePrawn at 2023-09-07T00:12:41+10:00 pacman-key: allow overriding KEYRING_IMPORT_DIR with --populate-from Signed-off-by: InsanePrawn <insane.prawny(a)gmail.com> Signed-off-by: Allan McRae <allan(a)archlinux.org> - - - - - 1 changed file: - scripts/pacman-key.sh.in View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/36d70a93e20fb88c77397f2… -- View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/36d70a93e20fb88c77397f2… You're receiving this email because of your account on gitlab.archlinux.org.

1 0

[Git][pacman/pacman][master] 11 commits: Generalise concat_alpm_depends for any list
by Allan McRae (＠allan) 06 Sep '23

06 Sep '23

Allan McRae pushed to branch master at Pacman / Pacman Commits: e58d799c by Allan McRae at 2023-09-06T14:39:00+10:00 Generalise concat_alpm_depends for any list Replace concat_alpm_depends() with concat_list() which takes an additional parameter to handle the formatting of non-string data types. Signed-off-by: Allan McRae <allan(a)archlinux.org> - - - - - 5473c9fd by Allan McRae at 2023-09-06T17:56:55+10:00 squash Signed-off-by: Allan McRae <allan(a)archlinux.org> - - - - - f5af66f1 by Allan McRae at 2023-09-06T17:56:55+10:00 Remove unnecessary check Signed-off-by: Allan McRae <allan(a)archlinux.org> - - - - - c1d4a619 by Jelle van der Waa at 2023-09-06T17:56:55+10:00 Extend --print-format with %L Add format attribute for licenses. Signed-off-by: Allan McRae <allan(a)archlinux.org> - - - - - 5bd0b98b by Jelle van der Waa at 2023-09-06T17:56:55+10:00 util.c: extend --print-format with %R and %P Add provides "%P" and replaces "%R" as format attribute. Signed-off-by: Jelle van der Waa <jelle(a)archlinux.org> Signed-off-by: Allan McRae <allan(a)archlinux.org> - - - - - 909f2e86 by Jelle van der Waa at 2023-09-06T17:56:55+10:00 util.c: add "%O" to --print-format Add the option to print optional depends with "%O". Signed-off-by: Jelle van der Waa <jelle(a)archlinux.org> - - - - - 06db927a by Jelle van der Waa at 2023-09-06T17:56:55+10:00 util.c: extend --print-format with "%H" Add a new print attribute "%H" which shows conflicts. Signed-off-by: Jelle van der Waa <jelle(a)archlinux.org> - - - - - 6968f770 by Jelle van der Waa at 2023-09-06T17:56:55+10:00 util.c: extend --print-format with "%G" Add a new print attribute "%G" which prints groups. Signed-off-by: Allan McRae <allan(a)archlinux.org> - - - - - e2106349 by Jelle van der Waa at 2023-09-06T17:56:55+10:00 util.c: extend --print-format with "%m" Add md5sum as printable format string. Signed-off-by: Allan McRae <allan(a)archlinux.org> - - - - - e7d7433b by Allan McRae at 2023-09-06T17:56:55+10:00 Rename macro for print-format handling of strings Signed-off-by: Allan McRae <allan(a)archlinux.org> - - - - - 717e5e91 by Allan McRae at 2023-09-06T17:56:55+10:00 Add PRINT_FORMAT_LIST define to remove repetitive code Signed-off-by: Allan McRae <allan(a)archlinux.org> - - - - - 2 changed files: - doc/pacman.8.asciidoc - src/pacman/util.c View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/compare/366b527757529bd9b107fc… -- View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/compare/366b527757529bd9b107fc… You're receiving this email because of your account on gitlab.archlinux.org.

1 0

[Git][pacman/pacman][master] libmakepkg: make sure git cloned repo's remote is named origin
by Allan McRae (＠allan) 06 Sep '23

06 Sep '23

Allan McRae pushed to branch master at Pacman / Pacman Commits: 366b5277 by Matthias Kurz at 2023-09-06T13:51:32+10:00 libmakepkg: make sure git cloned repo's remote is named origin makepkg assumes that the remote git repo is named "origin" at several places in its handling of git sources. It is possible to set the remote repo name since git v2.30.0 (with bug fix for bare checkouts in v2.30.2). Add "--origin=origin" to all git clone commands. Signed-off-by: Allan McRae <allan(a)archlinux.org> - - - - - 1 changed file: - scripts/libmakepkg/source/git.sh.in View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/366b527757529bd9b107fce… -- View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/366b527757529bd9b107fce… You're receiving this email because of your account on gitlab.archlinux.org.

1 0

[Git][pacman/pacman][master] makepkg: lint empty arrays
by Allan McRae (＠allan) 06 Sep '23

06 Sep '23

Allan McRae pushed to branch master at Pacman / Pacman Commits: e83e53f3 by morganamilo at 2023-09-06T12:14:55+10:00 makepkg: lint empty arrays While depend arrays are already linted, many array kinds are still not. An empty string is never a valid array value so check all arrays for it. - - - - - 1 changed file: - scripts/libmakepkg/lint_pkgbuild/variable.sh.in View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/e83e53f3f9f50b316c44886… -- View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/e83e53f3f9f50b316c44886… You're receiving this email because of your account on gitlab.archlinux.org.

1 0

[Git][pacman/pacman][master] pacman+libalpm: print version names for conflicting packages
by Allan McRae (＠allan) 06 Sep '23

06 Sep '23

Allan McRae pushed to branch master at Pacman / Pacman Commits: 2348dcab by morganamilo at 2023-09-05T01:57:01+00:00 pacman+libalpm: print version names for conflicting packages When ever pacman prints a conflict, it now prints pkgname-version, instead of just pkgname. alpm_conflict_t now carries *alpm_pkg_ts instead of just the names of each package. Fixes FS#12536 (point 2) - - - - - 6 changed files: - lib/libalpm/alpm.h - lib/libalpm/conflict.c - lib/libalpm/sync.c - src/pacman/callback.c - src/pacman/database.c - src/pacman/sync.c View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/2348dcab22562d04359ae69… -- View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/2348dcab22562d04359ae69… You're receiving this email because of your account on gitlab.archlinux.org.

1 0

[Git][pacman/pacman][master] 2 commits: Fix compile on some platforms
by Morgan Adamiec (＠morganamilo) 04 Sep '23

04 Sep '23

Morgan Adamiec pushed to branch master at Pacman / Pacman Commits: 85ab0307 by morganamilo at 2023-09-04T22:00:48+02:00 Fix compile on some platforms Controlling the type of getmntinfo's param was decided by whether or not we had the statvfs type avaliable. But getmntinfo uses statfs regardless of this except on netbsd where it uses statvfs. Add a check to detect which type our version of the function uses. - - - - - f9d8beef by morganamilo at 2023-09-04T22:00:51+02:00 Add meson log to artifacts - - - - - 2 changed files: - .gitlab-ci.yml - meson.build View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/compare/ffde12cebdd146ac524649… -- View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/compare/ffde12cebdd146ac524649… You're receiving this email because of your account on gitlab.archlinux.org.

1 0

[Git][pacman/pacman][master] repo-add: fix exit on mktemp failure
by Allan McRae (＠allan) 28 Aug '23

28 Aug '23

Allan McRae pushed to branch master at Pacman / Pacman Commits: ffde12ce by Nicolas Rolans at 2023-08-28T12:43:56+00:00 repo-add: fix exit on mktemp failure - - - - - 1 changed file: - scripts/repo-add.sh.in View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/ffde12cebdd146ac5246490… -- View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/ffde12cebdd146ac5246490… You're receiving this email because of your account on gitlab.archlinux.org.

1 0

[Git][pacman/pacman][master] Replace md5sums with sha256sums in documentation
by Allan McRae (＠allan) 28 Aug '23

28 Aug '23

Allan McRae pushed to branch master at Pacman / Pacman Commits: 37dae721 by Jouke Witteveen at 2023-08-28T12:27:28+00:00 Replace md5sums with sha256sums in documentation As noted in !24, md5sums are outdated. - - - - - 2 changed files: - doc/PKGBUILD-example.txt - doc/makepkg-template.1.asciidoc View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/37dae721d37647981514557… -- View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/37dae721d37647981514557… You're receiving this email because of your account on gitlab.archlinux.org.

1 0

[Git][pacman/pacman][master] proto: Change the default checksum from md5 to sha256
by Allan McRae (＠allan) 28 Aug '23

28 Aug '23

Allan McRae pushed to branch master at Pacman / Pacman Commits: aa3a1bc3 by Ben Westover at 2023-08-28T22:25:10+10:00 proto: Change the default checksum from md5 to sha256 MD5 isn't a very good checksum, and the PKGBUILD page on the Arch Wiki states that it should not be used, instead recommending sha256 or b2. This patch changes the default from md5 to sha256 because that seems to be the most commonly used checksum today. Signed-off-by: Ben Westover <kwestover.kw(a)gmail.com> - - - - - 3 changed files: - proto/PKGBUILD-split.proto - proto/PKGBUILD-vcs.proto - proto/PKGBUILD.proto View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/aa3a1bc3b50d797fb75278f… -- View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/aa3a1bc3b50d797fb75278f… You're receiving this email because of your account on gitlab.archlinux.org.

1 0

[Git][pacman/pacman][master] pacman: do not check file md5sums
by Allan McRae (＠allan) 28 Aug '23

28 Aug '23

Allan McRae pushed to branch master at Pacman / Pacman Commits: 298755c9 by Allan McRae at 2023-08-28T22:17:51+10:00 pacman: do not check file md5sums The file md5sums are removed from the .MTREE file, so pacman should not attempt to check them. Signed-off-by: Allan McRae <allan(a)archlinux.org> - - - - - 1 changed file: - src/pacman/check.c View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/298755c905fdd40f9611abe… -- View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/298755c905fdd40f9611abe… You're receiving this email because of your account on gitlab.archlinux.org.

1 0

[Git][pacman/pacman][master] 3 commits: makepkg: immutable git sources by hashing the checkout content
by Allan McRae (＠allan) 28 Aug '23

28 Aug '23

Allan McRae pushed to branch master at Pacman / Pacman Commits: 2fc2ab6c by Levente Polyak at 2023-08-28T22:15:03+10:00 makepkg: immutable git sources by hashing the checkout content This feature makes Git VCS build inputs immutable by adding support for pinning a Git checkout by a hash of its content using the deterministic export functionality `git archive`. This feature aids packagers by allowing them to use simple and convenient refnames (instead of full commit hashes) in the `PKGBUILD` while still preserving security implications of immutable build inputs using a trusted cryptographic hash function of the content. Previously VCS source downloads have been skipped for `--geninteg` and `--source` as both options did not need a checkout. This commit changes this behavior by forcing the download of all sources as integrity checks and generation requires to have an up to date state. Signed-off-by: Levente Polyak <anthraxx(a)archlinux.org> - - - - - ca3c873d by Levente Polyak at 2023-08-28T22:15:03+10:00 makepkg: immutable mercurial sources by hashing the checkout content This feature makes Mercurial VCS build inputs immutable by adding support for pinning a Mercurial checkout by a hash of its content using the deterministic export functionality `hg archive`. This feature aids packagers by allowing them to use simple and convenient refnames (instead of full commit hashes) in the `PKGBUILD` while still preserving security implications of immutable build inputs using a trusted cryptographic hash function of the content. Signed-off-by: Levente Polyak <anthraxx(a)archlinux.org> - - - - - ee933acf by Levente Polyak at 2023-08-28T22:15:03+10:00 makepkg: immutable bzr by hashing the checkout content This feature makes bzr VCS build inputs immutable by adding support for pinning a bzr checkout by a hash of its content using the deterministic export functionality `bzr export`. This feature allows to preserve security implications of immutable build inputs using a trusted cryptographic hash function of the content. Signed-off-by: Levente Polyak <anthraxx(a)archlinux.org> - - - - - 8 changed files: - doc/PKGBUILD.5.asciidoc - scripts/libmakepkg/integrity/generate_checksum.sh.in - scripts/libmakepkg/integrity/verify_checksum.sh.in - scripts/libmakepkg/source/bzr.sh.in - scripts/libmakepkg/source/file.sh.in - scripts/libmakepkg/source/git.sh.in - scripts/libmakepkg/source/hg.sh.in - scripts/makepkg.sh.in View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/compare/843bf21e794c79c5b3bcf8… -- View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/compare/843bf21e794c79c5b3bcf8… You're receiving this email because of your account on gitlab.archlinux.org.

1 0

[Git][pacman/pacman][master] libmakepkg: Fix non-reproducible binaries by processing debuginfo in order
by Allan McRae (＠allan) 28 Aug '23

28 Aug '23

Allan McRae pushed to branch master at Pacman / Pacman Commits: 843bf21e by kpcyrd at 2023-08-27T13:03:40+02:00 libmakepkg: Fix non-reproducible binaries by processing debuginfo in order - - - - - 1 changed file: - scripts/libmakepkg/tidy/strip.sh.in View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/843bf21e794c79c5b3bcf8a… -- View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/843bf21e794c79c5b3bcf8a… You're receiving this email because of your account on gitlab.archlinux.org.

1 0

[PATCH] alpm_run_chroot: Fix the execution of pacman hooks
by Dragan Simic 21 Aug '23

21 Aug '23

During a full system update of a Manjaro ARM installation, on an ARM-based computer, of course, I spotted a highly conspicuous error message in the output of pacman: ( 3/18) Creating temporary files... Assertion 'fd' failed at src/tmpfiles/tmpfiles.c:843, function fd_set_perms(). Aborting. /usr/share/libalpm/scripts/systemd-hook: line 28: 1735 Aborted (core dumped) /usr/bin/systemd-tmpfiles --create error: command failed to execute correctly Here's also an excerpt from /var/log/pacman.log (the stack trace was rather unusable, so I'll skip it for the sake of brevity): [ALPM] running '30-systemd-tmpfiles.hook'... [ALPM-SCRIPTLET] Assertion 'fd' failed at src/tmpfiles/tmpfiles.c:843, function fd_set_perms(). Aborting. [ALPM-SCRIPTLET] /usr/share/libalpm/scripts/systemd-hook: line 28: 1735 Aborted (core dumped) /usr/bin/systemd-tmpfiles --create Running "systemd-tmpfiles --create" manually afterwards resulted in no errors, which made the error message even more conspicuous. Thus, executing /usr/share/libalpm/hooks/30-systemd-tmpfiles.hook failed, but only when it was run from within pacman. I also saw a few people complaining about the same error message on Manjaro and Arch Linux forums, even with one complaint dating more than a few years ago, but nobody came through with a fix or workaround. After a detailed and rather lengthy investigation, it turned out that the root cause was twofold, as described below: 1) For its pacman package, Arch Linux ARM applies a patch named 0003-Revert-alpm_run_chroot-always-connect-parent2child-p.patch that reverts rather old pacman commit 1d6583a5, for an unknown reason. This patch causes the error like clockwork. 2) The code in pacman's lib/libalpm/util.c that executes the hooks by forking a child has some rather subtle bugs that allow the error to occur under certain circumstances. Regarding the first point, the patch from Arch Linux ARM creates a condition in which the file descriptor 0 is closed by calling close(0) and left closed when the executed hook has no option "NeedsTargets" specified, which is the case for the hook mentioned above, /usr/share/libalpm/hooks/30-systemd-tmpfiles.hook. As a result, the first call to open() during the execution of the hook returns 0 as the file descriptor, because 0 is the lowest currently available value. It would all go unnoticed, but systemd-tmpfiles performed assert(fd) checks in its file src/tmpfiles/tmpfiles.c, which failed because fd equaled 0. These checks seem to have been removed in the meantime, which effectively made the error go away, but the original issue still remains. Regarding the second point, function _alpm_run_chroot() that executes hooks in a fork()ed child does not execute dup2() properly, but instead executes close() followed by dup2(). The man page for dup2() clearly states that such attempts to re-implement the equivalent functionality must be avoided, as visible in this quotation: The dup2() system call performs the same task as dup(), but instead of using the lowest-numbered unused file descriptor, it uses the file descriptor number specified in newfd. In other words, the file descriptor newfd is adjusted so that it now refers to the same open file description as oldfd. If the file descriptor newfd was previously open, it is closed before being reused; the close is performed silently (i.e., any errors during the close are not reported by dup2()). The steps of closing and reusing the file descriptor newfd are performed atomically. This is important, because trying to implement equivalent functionality using close(2) and dup() would be subject to race conditions, whereby newfd might be reused between the two steps. Such reuse could happen because the main program is interrupted by a signal handler that allocates a file descriptor, or because a parallel thread allocates a file descriptor. As a result, a condition can occur in which the file descriptor 0 is closed by calling close(0), and left closed after the while loop that fails to execute dup2() because of receiving EBUSY, resulting in the original issue. On top of that, failed attempts to execute dup2() should be treated as fatal errors instead of being silently ignored. Let's improve the code to prevent the issues described in the second point, while not applying the above-mentioned Arch Linux ARM package patch fixes the issues decribed in the first point. While there, perform a minor cleanup as well, to make the formatting of the code a tiny bit more consistent. Signed-off-by: Dragan Simic <dsimic(a)manjaro.org> --- lib/libalpm/util.c | 31 +++++++++++++++++++++---------- 1 file changed, 21 insertions(+), 10 deletions(-) diff --git a/lib/libalpm/util.c b/lib/libalpm/util.c index dffa3b51..97e87c6c 100644 --- a/lib/libalpm/util.c +++ b/lib/libalpm/util.c @@ -639,28 +639,39 @@ int _alpm_run_chroot(alpm_handle_t *handle, const char *cmd, char *const argv[], if(pid == 0) { /* this code runs for the child only (the actual chroot/exec) */ - close(0); - close(1); - close(2); - while(dup2(child2parent_pipefd[HEAD], 1) == -1 && errno == EINTR); - while(dup2(child2parent_pipefd[HEAD], 2) == -1 && errno == EINTR); - while(dup2(parent2child_pipefd[TAIL], 0) == -1 && errno == EINTR); - close(parent2child_pipefd[TAIL]); close(parent2child_pipefd[HEAD]); close(child2parent_pipefd[TAIL]); + while(dup2(child2parent_pipefd[HEAD], STDERR_FILENO) == -1) { + if(errno != EINTR) { + /* at this point, the child cannot talk through the parent */ + exit(1); + } + } + while(dup2(parent2child_pipefd[TAIL], STDIN_FILENO) == -1) { + if(errno != EINTR) { + /* use fprintf() instead of _alpm_log() to send output through the parent */ + fprintf(stderr, _("could not redirect standard input (%s)\n"), strerror(errno)); + exit(1); + } + } + close(parent2child_pipefd[TAIL]); + while(dup2(child2parent_pipefd[HEAD], STDOUT_FILENO) == -1) { + if(errno != EINTR) { + fprintf(stderr, _("could not redirect standard output (%s)\n"), strerror(errno)); + exit(1); + } + } close(child2parent_pipefd[HEAD]); if(cwdfd >= 0) { close(cwdfd); } - /* use fprintf instead of _alpm_log to send output through the parent */ if(chroot(handle->root) != 0) { fprintf(stderr, _("could not change the root directory (%s)\n"), strerror(errno)); exit(1); } if(chdir("/") != 0) { - fprintf(stderr, _("could not change directory to %s (%s)\n"), - "/", strerror(errno)); + fprintf(stderr, _("could not change directory to %s (%s)\n"), "/", strerror(errno)); exit(1); } /* bash assumes it's being run under rsh/ssh if stdin is a socket and -- 2.33.1

3 6

[PATCH v2] alpm_run_chroot: Fix the execution of pacman hooks
by Dragan Simic 20 Aug '23

20 Aug '23

Running "pacman -Syyu" to perform a full system update resulted in a rather conspicuous error message in the output of pacman: ( 3/18) Creating temporary files... Assertion 'fd' failed at src/tmpfiles/tmpfiles.c:843, function fd_set_perms(). Aborting. /usr/share/libalpm/scripts/systemd-hook: line 28: 1735 Aborted (core dumped) /usr/bin/systemd-tmpfiles --create error: command failed to execute correctly Expectedly, running "systemd-tmpfiles --create" manually afterwards went just fine and resulted in no errors, leading to a conclusion that executing /usr/share/libalpm/hooks/30-systemd-tmpfiles.hook failed, but only when it was run from within pacman. After a detailed and rather lengthy investigation, it turned out the code in lib/libalpm/util.c that executes the hooks by forking a child has some bugs that allow the error to occur under certain circumstances. In particular, function _alpm_run_chroot() that executes hooks in a fork()ed child does not employ dup2() properly, but instead executes close() followed by dup2(). The man page for dup2() clearly states in the quotation below that attempts to re-implement the equivalent functionality, which is the case in function _alpm_run_chroot(), must be avoided: The dup2() system call performs the same task as dup(), but instead of using the lowest-numbered unused file descriptor, it uses the file descriptor number specified in newfd. In other words, the file descriptor newfd is adjusted so that it now refers to the same open file description as oldfd. If the file descriptor newfd was previously open, it is closed before being reused; the close is performed silently (i.e., any errors during the close are not reported by dup2()). The steps of closing and reusing the file descriptor newfd are performed atomically. This is important, because trying to implement equivalent functionality using close(2) and dup() would be subject to race conditions, whereby newfd might be reused between the two steps. Such reuse could happen because the main program is interrupted by a signal handler that allocates a file descriptor, or because a parallel thread allocates a file descriptor. As a result, a condition can occur in which the file descriptor 0 is closed by calling close(0), and left closed after the while loop that fails to execute dup2() because of receiving EBUSY, resulting in the described issues. Also, failed attempts to execute dup2() should be treated as fatal errors instead of being silently ignored. Let's improve the code to prevent the described issues. While there, perform a minor cleanup as well, to make the formatting of the code a tiny bit more consistent. Signed-off-by: Dragan Simic <dsimic(a)manjaro.org> --- lib/libalpm/util.c | 31 +++++++++++++++++++++---------- 1 file changed, 21 insertions(+), 10 deletions(-) diff --git a/lib/libalpm/util.c b/lib/libalpm/util.c index dffa3b51..97e87c6c 100644 --- a/lib/libalpm/util.c +++ b/lib/libalpm/util.c @@ -639,28 +639,39 @@ int _alpm_run_chroot(alpm_handle_t *handle, const char *cmd, char *const argv[], if(pid == 0) { /* this code runs for the child only (the actual chroot/exec) */ - close(0); - close(1); - close(2); - while(dup2(child2parent_pipefd[HEAD], 1) == -1 && errno == EINTR); - while(dup2(child2parent_pipefd[HEAD], 2) == -1 && errno == EINTR); - while(dup2(parent2child_pipefd[TAIL], 0) == -1 && errno == EINTR); - close(parent2child_pipefd[TAIL]); close(parent2child_pipefd[HEAD]); close(child2parent_pipefd[TAIL]); + while(dup2(child2parent_pipefd[HEAD], STDERR_FILENO) == -1) { + if(errno != EINTR) { + /* at this point, the child cannot talk through the parent */ + exit(1); + } + } + while(dup2(parent2child_pipefd[TAIL], STDIN_FILENO) == -1) { + if(errno != EINTR) { + /* use fprintf() instead of _alpm_log() to send output through the parent */ + fprintf(stderr, _("could not redirect standard input (%s)\n"), strerror(errno)); + exit(1); + } + } + close(parent2child_pipefd[TAIL]); + while(dup2(child2parent_pipefd[HEAD], STDOUT_FILENO) == -1) { + if(errno != EINTR) { + fprintf(stderr, _("could not redirect standard output (%s)\n"), strerror(errno)); + exit(1); + } + } close(child2parent_pipefd[HEAD]); if(cwdfd >= 0) { close(cwdfd); } - /* use fprintf instead of _alpm_log to send output through the parent */ if(chroot(handle->root) != 0) { fprintf(stderr, _("could not change the root directory (%s)\n"), strerror(errno)); exit(1); } if(chdir("/") != 0) { - fprintf(stderr, _("could not change directory to %s (%s)\n"), - "/", strerror(errno)); + fprintf(stderr, _("could not change directory to %s (%s)\n"), "/", strerror(errno)); exit(1); } /* bash assumes it's being run under rsh/ssh if stdin is a socket and

1 0

[PATCH v3] query: permit filter options with --owns
by Ronan Pigott 20 Aug '23

20 Aug '23

Signed-off-by: Ronan Pigott <ronan(a)rjp.ie> --- Changes in v2: - Use forward declarations - Drop the unnecessary error message Changes in v3: - Remove one unnecessary forward decl src/pacman/pacman.c | 1 - src/pacman/query.c | 5 +++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/pacman/pacman.c b/src/pacman/pacman.c index e5c6e4200932..320c7654e0a7 100644 --- a/src/pacman/pacman.c +++ b/src/pacman/pacman.c @@ -608,7 +608,6 @@ static void checkargs_query(void) } else if(config->op_q_owns) { invalid_opt(config->group, "--owns", "--groups"); checkargs_query_display_opts("--owns"); - checkargs_query_filter_opts("--owns"); } else if(config->group) { checkargs_query_display_opts("--groups"); } diff --git a/src/pacman/query.c b/src/pacman/query.c index d75c4c801be5..bcf948514ca3 100644 --- a/src/pacman/query.c +++ b/src/pacman/query.c @@ -135,6 +135,8 @@ cleanup: return (success ? resolved_path : NULL); } +static int filter(alpm_pkg_t *pkg); + static int query_fileowner(alpm_list_t *targets) { int ret = 0; @@ -210,6 +212,9 @@ static int query_fileowner(alpm_list_t *targets) } for(i = packages; i && (!found || is_dir); i = alpm_list_next(i)) { + if (!filter(i->data)) { + continue; + } if(alpm_filelist_contains(alpm_pkg_get_files(i->data), rel_path)) { print_query_fileowner(rpath, i->data); found = 1; -- 2.41.0

2 1

[PATCH] Leverage the U+EE00..U+EE05 unicode characters to make pretty progress bars
by Lénaïc Huard 17 Jun '23

17 Jun '23

Some unicode fonts are now implementing special glyph to render pretty progress bars. Here are some examples: * FiraCode [1] [2] * Iosevka [3] [4] [5] * JuliaMono [3] This change introduces a new parameter, `PrettyProgressBar` that triggers the use of those characters to render progress bars. Here is an example of how it renders with this new option and the FiraCode font: [6] [1] https://github.com/tonsky/FiraCode/releases/tag/6 [2] https://github.com/tonsky/FiraCode/issues/1182 [3] https://github.com/tonsky/FiraCode/issues/1182#issuecomment-1525953517 [4] https://github.com/be5invis/Iosevka/releases/tag/v11.2.0 [5] https://github.com/be5invis/Iosevka/issues/1327 [6] https://i2.paste.pics/OK03I.png Signed-off-by: Lénaïc Huard <lenaic(a)lhuard.fr> --- doc/pacman.conf.5.asciidoc | 3 + etc/pacman.conf.in | 1 + scripts/completion/zsh_completion.in | 1 + src/pacman/callback.c | 108 ++++++++++++++++----------- src/pacman/conf.c | 3 + src/pacman/conf.h | 2 + src/pacman/pacman-conf.c | 3 + 7 files changed, 76 insertions(+), 45 deletions(-) diff --git a/doc/pacman.conf.5.asciidoc b/doc/pacman.conf.5.asciidoc index 77a3907f..daab30d4 100644 --- a/doc/pacman.conf.5.asciidoc +++ b/doc/pacman.conf.5.asciidoc @@ -186,6 +186,9 @@ Options *Color*:: Automatically enable colors only when pacman's output is on a tty. +*PrettyProgressBar*:: + Use specific U+EE00..U+EE05 unicode characters to render pretty progress bars. + *NoProgressBar*:: Disables progress bars. This is useful for terminals which do not support escape characters. diff --git a/etc/pacman.conf.in b/etc/pacman.conf.in index 1799efc7..9ce2b938 100644 --- a/etc/pacman.conf.in +++ b/etc/pacman.conf.in @@ -31,6 +31,7 @@ Architecture = auto # Misc options #UseSyslog #Color +#PrettyProgressBar #NoProgressBar CheckSpace #VerbosePkgLists diff --git a/scripts/completion/zsh_completion.in b/scripts/completion/zsh_completion.in index 5fd8aebc..e64a603e 100644 --- a/scripts/completion/zsh_completion.in +++ b/scripts/completion/zsh_completion.in @@ -514,6 +514,7 @@ _pacman_conf_general_directives=( 'CheckSpace' 'VerbosePkgLists' 'DisableDownloadTimeout' + 'PrettyProgressBar' 'NoProgressBar' 'ParallelDownloads' 'CleanMethod' diff --git a/src/pacman/callback.c b/src/pacman/callback.c index 75c74f8b..f72a91cf 100644 --- a/src/pacman/callback.c +++ b/src/pacman/callback.c @@ -153,54 +153,72 @@ static int64_t get_update_timediff(int first_call) static void fill_progress(const int bar_percent, const int disp_percent, const int proglen) { - /* 8 = 1 space + 1 [ + 1 ] + 5 for percent */ - const int hashlen = proglen > 8 ? proglen - 8 : 0; - const int hash = bar_percent * hashlen / 100; - static int lasthash = 0, mouth = 0; int i; - if(bar_percent == 0) { - lasthash = 0; - mouth = 0; + /* if pretty progress bar enabled */ + if(config->pretty) { + /* 8 = 1 space + 1  + 1  + 5 for percent */ + const int hashlen = proglen > 8 ? proglen - 6 : 0; + const int hash = bar_percent * hashlen / 100; + + if(hashlen > 2) { + fputs(hash > 0 ? " " : " ", stdout); + for(i = hashlen - 1; i > 1; --i) { + fputs(i > hashlen - hash ? "" : "", stdout); + } + fputs(hash == hashlen ? "" : "", stdout); + } + + } else { + /* 8 = 1 space + 1 [ + 1 ] + 5 for percent */ + const int hashlen = proglen > 8 ? proglen - 8 : 0; + const int hash = bar_percent * hashlen / 100; + static int lasthash = 0, mouth = 0; + + if(bar_percent == 0) { + lasthash = 0; + mouth = 0; + } + + if(hashlen > 0) { + fputs(" [", stdout); + for(i = hashlen; i > 0; --i) { + /* if special progress bar enabled */ + if(config->chomp) { + if(i > hashlen - hash) { + putchar('-'); + } else if(i == hashlen - hash) { + if(lasthash == hash) { + if(mouth) { + fputs("\033[1;33mC\033[m", stdout); + } else { + fputs("\033[1;33mc\033[m", stdout); + } + } else { + lasthash = hash; + mouth = mouth == 1 ? 0 : 1; + if(mouth) { + fputs("\033[1;33mC\033[m", stdout); + } else { + fputs("\033[1;33mc\033[m", stdout); + } + } + } else if(i % 3 == 0) { + fputs("\033[0;37mo\033[m", stdout); + } else { + fputs("\033[0;37m \033[m", stdout); + } + } /* else regular progress bar */ + else if(i > hashlen - hash) { + putchar('#'); + } else { + putchar('-'); + } + } + putchar(']'); + } } - if(hashlen > 0) { - fputs(" [", stdout); - for(i = hashlen; i > 0; --i) { - /* if special progress bar enabled */ - if(config->chomp) { - if(i > hashlen - hash) { - putchar('-'); - } else if(i == hashlen - hash) { - if(lasthash == hash) { - if(mouth) { - fputs("\033[1;33mC\033[m", stdout); - } else { - fputs("\033[1;33mc\033[m", stdout); - } - } else { - lasthash = hash; - mouth = mouth == 1 ? 0 : 1; - if(mouth) { - fputs("\033[1;33mC\033[m", stdout); - } else { - fputs("\033[1;33mc\033[m", stdout); - } - } - } else if(i % 3 == 0) { - fputs("\033[0;37mo\033[m", stdout); - } else { - fputs("\033[0;37m \033[m", stdout); - } - } /* else regular progress bar */ - else if(i > hashlen - hash) { - putchar('#'); - } else { - putchar('-'); - } - } - putchar(']'); - } /* print display percent after progress bar */ /* 5 = 1 space + 3 digits + 1 % */ if(proglen >= 5) { @@ -252,7 +270,7 @@ void cb_event(void *ctx, alpm_event_t *event) alpm_event_hook_run_t *e = &event->hook_run; int digits = number_length(e->total); printf("(%*zu/%*zu) %s\n", digits, e->position, - digits, e->total, + digits, e->total, e->desc ? e->desc : e->name); } break; diff --git a/src/pacman/conf.c b/src/pacman/conf.c index 12fee64c..fa38930c 100644 --- a/src/pacman/conf.c +++ b/src/pacman/conf.c @@ -604,6 +604,9 @@ static int _parse_options(const char *key, char *value, } else if(strcmp(key, "ILoveCandy") == 0) { config->chomp = 1; pm_printf(ALPM_LOG_DEBUG, "config: chomp\n"); + } else if(strcmp(key, "PrettyProgressBar") == 0 ) { + config->pretty = 1; + pm_printf(ALPM_LOG_DEBUG, "config: pretty\n"); } else if(strcmp(key, "VerbosePkgLists") == 0) { config->verbosepkglists = 1; pm_printf(ALPM_LOG_DEBUG, "config: verbosepkglists\n"); diff --git a/src/pacman/conf.h b/src/pacman/conf.h index 04350d39..1ac6806f 100644 --- a/src/pacman/conf.h +++ b/src/pacman/conf.h @@ -111,6 +111,8 @@ typedef struct __config_t { /* conf file options */ /* I Love Candy! */ unsigned short chomp; + /* Pretty progress bar */ + unsigned short pretty; /* format target pkg lists as table */ unsigned short verbosepkglists; /* number of parallel download streams */ diff --git a/src/pacman/pacman-conf.c b/src/pacman/pacman-conf.c index 600f1622..3ea4816a 100644 --- a/src/pacman/pacman-conf.c +++ b/src/pacman/pacman-conf.c @@ -267,6 +267,7 @@ static void dump_config(void) show_bool("VerbosePkgLists", config->verbosepkglists); show_bool("DisableDownloadTimeout", config->disable_dl_timeout); show_bool("ILoveCandy", config->chomp); + show_bool("PrettyProgressBar", config->pretty); show_bool("NoProgressBar", config->noprogressbar); show_int("ParallelDownloads", config->parallel_downloads); @@ -379,6 +380,8 @@ static int list_directives(void) show_bool("DisableDownloadTimeout", config->disable_dl_timeout); } else if(strcasecmp(i->data, "ILoveCandy") == 0) { show_bool("ILoveCandy", config->chomp); + } else if(strcasecmp(i->data, "PrettyProgressBar") == 0) { + show_bool("PrettyProgressBar", config->pretty); } else if(strcasecmp(i->data, "NoProgressBar") == 0) { show_bool("NoProgressBar", config->noprogressbar); -- 2.40.1

1 0

Minor annoyance with paths
by Ronan Pigott 07 Jun '23

07 Jun '23

So I have a minor annoyance with pacman that $(pacman-conf CacheDir)/somefile evaluates to /var/cache/pacman/pkg//somefile, with two //. That's because the default value of CacheDir (and several other path-valued variables) ends with a trailing slash. The normalized path name is of course the same but I'd like it to look pretty. Would it be acceptable to either change the default values of these variables to drop the trailing slash or have pacman-conf silently drop them when printing?

1 0

[PATCH v2] query: permit filter options with --owns
by Ronan Pigott 02 Jun '23

02 Jun '23

Signed-off-by: Ronan Pigott <ronan(a)rjp.ie> --- Changes from v1: 1. Use forward declarations 2. Drop the unnecessary error message src/pacman/pacman.c | 1 - src/pacman/query.c | 6 ++++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/pacman/pacman.c b/src/pacman/pacman.c index e5c6e4200932..320c7654e0a7 100644 --- a/src/pacman/pacman.c +++ b/src/pacman/pacman.c @@ -608,7 +608,6 @@ static void checkargs_query(void) } else if(config->op_q_owns) { invalid_opt(config->group, "--owns", "--groups"); checkargs_query_display_opts("--owns"); - checkargs_query_filter_opts("--owns"); } else if(config->group) { checkargs_query_display_opts("--groups"); } diff --git a/src/pacman/query.c b/src/pacman/query.c index d75c4c801be5..e79b956838a0 100644 --- a/src/pacman/query.c +++ b/src/pacman/query.c @@ -135,6 +135,9 @@ cleanup: return (success ? resolved_path : NULL); } +static int is_unrequired(alpm_pkg_t *pkg, unsigned short level); +static int filter(alpm_pkg_t *pkg); + static int query_fileowner(alpm_list_t *targets) { int ret = 0; @@ -210,6 +213,9 @@ static int query_fileowner(alpm_list_t *targets) } for(i = packages; i && (!found || is_dir); i = alpm_list_next(i)) { + if (!filter(i->data)) { + continue; + } if(alpm_filelist_contains(alpm_pkg_get_files(i->data), rel_path)) { print_query_fileowner(rpath, i->data); found = 1; -- 2.41.0

1 0

[PATCH 0/2] Permit query filter options with --owns
by Ronan Pigott 01 Jun '23

01 Jun '23

Recently I wanted to find foreign packages that own a path and found that pacman -Qmoq /my/path gives an error. I don't see any reason in principle why this should not be allowed, so I'd like to change it. Ronan Pigott (2): query: move declarations of filter related functions query: permit filter options with --owns src/pacman/pacman.c | 1 - src/pacman/query.c | 131 ++++++++++++++++++++++++-------------------- 2 files changed, 71 insertions(+), 61 deletions(-) -- 2.40.1

4 8

[PATCH] doc/submitting-patches: helpfully mention the list address
by Ronan Pigott 29 May '23

29 May '23

--- I think it would be helpful to mention the list address in the documentation. doc/submitting-patches.asciidoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/submitting-patches.asciidoc b/doc/submitting-patches.asciidoc index 14b80b61a643..7988b250f539 100644 --- a/doc/submitting-patches.asciidoc +++ b/doc/submitting-patches.asciidoc @@ -57,7 +57,7 @@ Submitting your patch --------------------- -- -* Send the patch to the pacman-dev mailing list +* Send the patch to the pacman-dev mailing list <pacman-dev(a)lists.archlinux.org> The mailing list is the primary queue for review and acceptance. Here you will get feedback, and let the reviewers know the details of your patch. -- 2.40.1

1 0

[Git][pacman/pacman][master] Disable brittle valgrind test in CI
by Allan McRae (＠allan) 22 May '23

22 May '23

Allan McRae pushed to branch master at Pacman / Pacman Commits: 2c45e854 by Allan McRae at 2023-05-22T19:32:47+10:00 Disable brittle valgrind test in CI Signed-off-by: Allan McRae <allan(a)archlinux.org> - - - - - 1 changed file: - .gitlab-ci.yml View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/2c45e854ab405101fc13f6b… -- View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/2c45e854ab405101fc13f6b… You're receiving this email because of your account on gitlab.archlinux.org.

1 0

[Git][pacman/pacman][master] Update pactest README
by Allan McRae (＠allan) 22 May '23

22 May '23

Allan McRae pushed to branch master at Pacman / Pacman Commits: a81ec016 by Allan McRae at 2023-05-22T19:25:23+10:00 Update pactest README Signed-off-by: Allan McRae <allan(a)archlinux.org> - - - - - 1 changed file: - test/pacman/README View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/a81ec016d7d845cc8e14efe… -- View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/a81ec016d7d845cc8e14efe… You're receiving this email because of your account on gitlab.archlinux.org.

1 0

[Git][pacman/pacman][master] 2 commits: makepkg.conf.5: correction option name
by Allan McRae (＠allan) 22 May '23

22 May '23

Allan McRae pushed to branch master at Pacman / Pacman Commits: 5e947524 by Allan McRae at 2023-05-22T18:54:01+10:00 makepkg.conf.5: correction option name Also fix typo "librarys" Signed-off-by: Allan McRae <allan(a)archlinux.org> - - - - - 55da1a01 by Allan McRae at 2023-05-22T18:55:23+10:00 makepkg.conf.in: strip leading slash from LIB_DIRS Signed-off-by: Allan McRae <allan(a)archlinux.org> - - - - - 2 changed files: - doc/makepkg.conf.5.asciidoc - etc/makepkg.conf.in View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/compare/262aa6c24ee85f96882c37… -- View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/compare/262aa6c24ee85f96882c37… You're receiving this email because of your account on gitlab.archlinux.org.

1 0

[RFC] Add post-package test() function to PKGBUILD
by Lamarr Rikskringen 07 Apr '23

07 Apr '23

Hi, PKGBUILDs include the check() function which allows one to run tests on the software after it has been built, but before it has been packaged. This message proposes to add a test() function, which essentially allows to run tests after package(), and in particular after the package has been installed in a chroot (for these testing purposes). This allows the packager to run tests against the final installation (or as final as can be in a chroot). Between package() and test(), the resulting pkg is installed in a chroot like on the regular system (i.e. /usr/bin instead of $pkgdir/usr/bin). Everything but the pkg files and the test files is removed, so only the installation is under test. The idea for this came from the issue that Python packages usually don't need a build or rather, that that build can't be tested without fully installing it. This installation however isn't really possible since /usr/ is inaccessible for obvious reasons. Workarounds usually involve setting the PYTHONPATH, but that's tedious at best and ultimately unnecessary. Because Python has an extensive auto-detection of libraries and dependencies, the tests can be executed easily, if Python can find them. And after installation (in /usr/lib/python*/site-packages/), the package is easily found. This of course is in contrast to most compiled languages, who would require lots of paths and links in order to be able to compile the tests. It shouldn't be this way, but it is. A slight complication arises from the fact that tests can theoretically be anywhere in the python source code. So either makepkg figures out what is a test, or the packager specifies that. In most cases though, all tests are in a single directory, and the edge cases are vast, so the latter case with some boilerplate is probably better. In total, a PKGBUILD might look something like this (names are subject to change): ``` build() { cd ${pkgname}-${pkgver}/ python -m build --wheel --no-isolation } check() { cd ${pkgname}-${pkgver}/ python -m pytest } package() { cd ${pkgname}-${pkgver}/ python -m installer --destdir="$pkgdir" dist/*.whl } collect() { cd ${pkgname}-${pkgver}/ # collects the tests and puts them into $testdir python -m pytest --co | grep -o "[^ ]*\.py" | xargs cp -t $testdir } # inbetween collect() and test(), the package is installed in the chroot and $testdir is copied test() { # we are in $testdir (e.g. /home/builduser) pytest } ``` Notice the line in collect() which is responsible to collect the tests. We basically ask pytest what it wants to run, then filter out the files, and lastly copy them into $testdir, which is ultimately copied over and run. In most cases, this line might just be something like `cp tests/ $testdir/`. ------------ Makepkg ------------ This post is already quite long, so I'll make it quick with some implementation thoughts. Since collect() and test() always run together or don't run together (test() needs collect() and only collect() has no effect), only a single option is necessary to toggle whether to run the post-package tests. The order of package() and collect() conceptually doesn't matter, but collect() should probably run after to guarantee that it does not influence package(). Either case, the packager is responsible. This is a pure addition, so if collect() and test() are missing, then just nothing happens. If only collect() is implemented, that might be ignored too. If only test() exists, then an error is probably most helpful, since no packages are copied. Alternatively, maybe makepkg does some limited test identification (like looking for tests/ folder). Or just nothing happens because the packager made a mistake. Should be obvious enough. In conclusion, two new methods are introduced to allow for better and more precise testing of the final output, as well as easier testing in case of Python. The first function - collect() - collects all the tests in the codebase and copies them into $testdir, while package() creates the pkg in $pkgdir. After that, a chroot with all depends packages is created and the pkg installed therein. $testdir is also copied there. Lastly, the second function - test() - is called and executed to test the installation. Thanks for your attention, if you have further ideas or questions, I'd like to hear them. If something similar has already been discussed, feel free to point out that thread. AFAICT, it hasn't been before. - Lamarrrk

1 0

[Git][pacman/pacman][master] 2 commits: makepkg: do not recurse into LIB_DIRS when looking for library provides
by Allan McRae (＠allan) 13 Feb '23

13 Feb '23

Allan McRae pushed to branch master at Pacman / Pacman Commits: 3323662e by Allan McRae at 2023-02-13T12:09:11+00:00 makepkg: do not recurse into LIB_DIRS when looking for library provides We should only find library provides in the configured directories, and not their subdirectories. Signed-off-by: Allan McRae <allan(a)archlinux.org> - - - - - 262aa6c2 by Allan McRae at 2023-02-13T12:09:11+00:00 Fix comment Signed-off-by: Allan McRae <allan(a)archlinux.org> - - - - - 1 changed file: - scripts/libmakepkg/autodep/library_provides.sh.in View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/compare/6c913af95d24fd9bca8c42… -- View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/compare/6c913af95d24fd9bca8c42… You're receiving this email because of your account on gitlab.archlinux.org.

1 0