- Pacman-dev - lists.archlinux.org

[pacman-dev] [PATCH] makepkg: install deps with --repackage
by Allan McRae 07 Jun '12

07 Jun '12

I have noticed that quite a number of packages fail with "makepkg -R" when their (make)dependencies are not installed. Adjust makepkg to check for dependencies when used with -R. This can still be avoided by using --nodeps/-d. Signed-off-by: Allan McRae <allan(a)archlinux.org> --- scripts/makepkg.sh.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index c055691..63cdd4d 100644 --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in @@ -2424,9 +2424,9 @@ if (( SOURCEONLY )); then exit 0 fi -if (( NODEPS || ( (NOBUILD || REPKG) && !DEP_BIN ) )); then - # no warning message needed for nobuild, repkg - if (( NODEPS || ( REPKG && PKGFUNC ) )); then +if (( NODEPS || (NOBUILD && !DEP_BIN ) )); then + # no warning message needed for nobuild + if (( NODEPS )); then warning "$(gettext "Skipping dependency checks.")" fi elif type -p "${PACMAN%% *}" >/dev/null; then -- 1.7.10.3

1 0

[pacman-dev] [PATCH] pacman: print version information in debug output
by Allan McRae 07 Jun '12

07 Jun '12

Signed-off-by: Allan McRae <allan(a)archlinux.org> --- scripts/po/ca.po | 45 ++++++++++++++++++++++++++++++++++----------- scripts/po/cs.po | 42 +++++++++++++++++++++++++++++++----------- scripts/po/da.po | 45 ++++++++++++++++++++++++++++++++++----------- scripts/po/de.po | 45 ++++++++++++++++++++++++++++++++++----------- scripts/po/el.po | 45 ++++++++++++++++++++++++++++++++++----------- scripts/po/es.po | 45 ++++++++++++++++++++++++++++++++++----------- scripts/po/fi.po | 45 ++++++++++++++++++++++++++++++++++----------- scripts/po/fr.po | 45 ++++++++++++++++++++++++++++++++++----------- src/pacman/pacman.c | 2 ++ 9 files changed, 271 insertions(+), 88 deletions(-) diff --git a/scripts/po/ca.po b/scripts/po/ca.po index 79e219a..f179d3e 100644 --- a/scripts/po/ca.po +++ b/scripts/po/ca.po @@ -8,7 +8,7 @@ msgid "" msgstr "" "Project-Id-Version: Arch Linux Pacman package manager\n" "Report-Msgid-Bugs-To: http://bugs.archlinux.org/index.php?project=3\n" -"POT-Creation-Date: 2012-03-28 18:00-0500\n" +"POT-Creation-Date: 2012-05-20 11:26-0500\n" "PO-Revision-Date: 2012-02-06 13:22+0000\n" "Last-Translator: Hector Mtz-Seara <hseara(a)gmail.com>\n" "Language-Team: Catalan (http://www.transifex.net/projects/p/archlinux-pacman/" @@ -271,6 +271,9 @@ msgstr "%s no pot estar buit." msgid "%s is not allowed to start with a hyphen." msgstr "%s no pot començar amb un guionet." +msgid "%s contains invalid characters: '%s'" +msgstr "" + msgid "%s is not allowed to contain colons, hyphens or whitespace." msgstr "%s no pot contenir dos punts, guions o espais en blanc." @@ -826,18 +829,21 @@ msgstr "Dashabilitant claus revocades del clauer..." msgid "Disabling key %s..." msgstr "Deshabilitant clau %s..." -msgid "A specified keyfile could not be added to the gpg keychain." +#, fuzzy +msgid "A specified keyfile could not be added to the keyring." msgstr "" "No s'ha pogut incorporar un arxiu de claus especificat al anell de claus " "gpg." -msgid "A specified key could not be removed from the gpg keychain." +#, fuzzy +msgid "A specified key could not be removed from the keyring." msgstr "No ha pogut esborrar una clau especificada del anell de claus gpg." msgid "The key identified by %s could not be edited." msgstr "No s'ha pogut editar la clau identificada per %s ." -msgid "A specified key could not be exported from the gpg keychain." +#, fuzzy +msgid "A specified key could not be exported from the keyring." msgstr "No s'ha pogut exportar una clau especificada del anell de claus gpg." msgid "The fingerprint of a specified key could not be determined." @@ -957,7 +963,8 @@ msgstr "S'està rotant la base de dades en l'emplaçament..." msgid "Finished. Your pacman database has been optimized." msgstr "Ha finalitzat. S'ha optimitzat la base de dades del pacman." -msgid "Usage: pkgdelta [-q] <package1> <package2>\\n" +#, fuzzy +msgid "Usage: pkgdelta [options] <package1> <package2>\\n" msgstr "Ús: pkgdelta [q] <package1><package2>\\n" msgid "" @@ -970,6 +977,22 @@ msgstr "" msgid "Example: pkgdelta pacman-3.0.0.pkg.tar.gz pacman-3.0.1.pkg.tar.gz" msgstr "Exemple: pkgdelta pacman-3.0.0.pkg.tar.gz pacman-3.0.1.pkg.tar.gz" +msgid "Options:\\n" +msgstr "Opcions:\\n" + +msgid " -q, --quiet minimize output\\n" +msgstr " -q, --quiet minimitza sortida\\n" + +msgid "" +" --min-pkg-size minimum package size before deltas are generated " +"(bytes)\\n" +msgstr "" + +msgid "" +" --max-delta-size percent of package size above which deltas will be " +"discarded\\n" +msgstr "" + msgid "" "Copyright (c) 2009 Xavier Chantry <shiningxc(a)gmail.com>.\\n\\nThis is free " "software; see the source for copying conditions.\\nThere is NO WARRANTY, to " @@ -982,6 +1005,9 @@ msgstr "" msgid "Invalid package file '%s'." msgstr "Fitxer de paquet invàlid '%'." +msgid "Skipping delta creation for small package: %s - size %s" +msgstr "" + msgid "The package names don't match : '%s' and '%s'" msgstr "Els noms dels paquets no coincideixen: '%s' i '%s'" @@ -997,6 +1023,9 @@ msgstr "Generant delta de la versió %s a la versió %s" msgid "Delta could not be created." msgstr "No s'ha pogut generar delta." +msgid "Delta package larger than maximum size. Removing." +msgstr "" + msgid "Generated delta : '%s'" msgstr "Delta generada: '%s'" @@ -1017,9 +1046,6 @@ msgstr "" "arxiu paquet.\\nMultiples paquets poden ser afegits poden especificant-los " "en la línia de comandes.\\n" -msgid "Options:\\n" -msgstr "Opcions:\\n" - msgid " -d, --delta generate and add delta for package update\\n" msgstr "" " -d, --delta genera i afegeix delta per l'actualització del packet\\n" @@ -1045,9 +1071,6 @@ msgstr "" msgid "Please move along, there is nothing to see here.\\n" msgstr "No hi ha res a veure en aquest punt, si us plau continua.\\n" -msgid " -q, --quiet minimize output\\n" -msgstr " -q, --quiet minimitza sortida\\n" - msgid " -s, --sign sign database with GnuPG after update\\n" msgstr "" " -s, --sign signa la base de dades amb GnuPG després de " diff --git a/scripts/po/cs.po b/scripts/po/cs.po index 5bf0447..9b71bb8 100644 --- a/scripts/po/cs.po +++ b/scripts/po/cs.po @@ -11,7 +11,7 @@ msgid "" msgstr "" "Project-Id-Version: Arch Linux Pacman package manager\n" "Report-Msgid-Bugs-To: http://bugs.archlinux.org/index.php?project=3\n" -"POT-Creation-Date: 2012-03-28 18:00-0500\n" +"POT-Creation-Date: 2012-05-20 11:26-0500\n" "PO-Revision-Date: 2012-02-02 06:07+0000\n" "Last-Translator: Dan McGee <dpmcgee(a)gmail.com>\n" "Language-Team: Czech (http://www.transifex.net/projects/p/archlinux-pacman/" @@ -270,6 +270,9 @@ msgstr "%s nemůže být prázdné." msgid "%s is not allowed to start with a hyphen." msgstr "%s nemůže začínat pomlčkou." +msgid "%s contains invalid characters: '%s'" +msgstr "" + msgid "%s is not allowed to contain colons, hyphens or whitespace." msgstr "%s nesmí obsahovat dvojtečky, pomlčky nebo mezery." @@ -778,16 +781,16 @@ msgstr "Rušení odvolaných klíčů v klíčence..." msgid "Disabling key %s..." msgstr "Rušení klíče %s..." -msgid "A specified keyfile could not be added to the gpg keychain." +msgid "A specified keyfile could not be added to the keyring." msgstr "" -msgid "A specified key could not be removed from the gpg keychain." +msgid "A specified key could not be removed from the keyring." msgstr "" msgid "The key identified by %s could not be edited." msgstr "" -msgid "A specified key could not be exported from the gpg keychain." +msgid "A specified key could not be exported from the keyring." msgstr "" msgid "The fingerprint of a specified key could not be determined." @@ -901,7 +904,8 @@ msgstr "Vyměňují se databáze..." msgid "Finished. Your pacman database has been optimized." msgstr "Dokončeno. Databáze pacmana byla optimalizována." -msgid "Usage: pkgdelta [-q] <package1> <package2>\\n" +#, fuzzy +msgid "Usage: pkgdelta [options] <package1> <package2>\\n" msgstr "Použití: pkgdelta [-q] <balíček1><balíček2>\\n" msgid "" @@ -914,6 +918,22 @@ msgstr "" msgid "Example: pkgdelta pacman-3.0.0.pkg.tar.gz pacman-3.0.1.pkg.tar.gz" msgstr "Příklad: pkgdelta pacman-3.0.0.pkg.tar.gz pacman-3.0.1.pkg.tar.gz" +msgid "Options:\\n" +msgstr "Volby:\\n" + +msgid " -q, --quiet minimize output\\n" +msgstr " -q, --quiet omezí výpisy\\n" + +msgid "" +" --min-pkg-size minimum package size before deltas are generated " +"(bytes)\\n" +msgstr "" + +msgid "" +" --max-delta-size percent of package size above which deltas will be " +"discarded\\n" +msgstr "" + msgid "" "Copyright (c) 2009 Xavier Chantry <shiningxc(a)gmail.com>.\\n\\nThis is free " "software; see the source for copying conditions.\\nThere is NO WARRANTY, to " @@ -926,6 +946,9 @@ msgstr "" msgid "Invalid package file '%s'." msgstr "Neplatný soubor balíčku '%s'." +msgid "Skipping delta creation for small package: %s - size %s" +msgstr "" + msgid "The package names don't match : '%s' and '%s'" msgstr "Jména balíčků nesouhlasí: '%s' a '%s'" @@ -941,6 +964,9 @@ msgstr "Generuje se delta z verze %s na verzi %s" msgid "Delta could not be created." msgstr "Delta rozdíl nemohl být vytvořen." +msgid "Delta package larger than maximum size. Removing." +msgstr "" + msgid "Generated delta : '%s'" msgstr "Vygenerován delta rozdíl: '%s'" @@ -958,9 +984,6 @@ msgid "" "\\nMultiple packages to add can be specified on the command line.\\n" msgstr "" -msgid "Options:\\n" -msgstr "Volby:\\n" - msgid " -d, --delta generate and add delta for package update\\n" msgstr " -d, --delta vytvoří a přidá rozdíly (delta) pro update balíčků\\n" @@ -980,9 +1003,6 @@ msgstr "" msgid "Please move along, there is nothing to see here.\\n" msgstr "" -msgid " -q, --quiet minimize output\\n" -msgstr " -q, --quiet omezí výpisy\\n" - msgid " -s, --sign sign database with GnuPG after update\\n" msgstr " -s, --sign po update podepíše databázi pomocí GnuPG\\n" diff --git a/scripts/po/da.po b/scripts/po/da.po index a654b1b..96cfa2f 100644 --- a/scripts/po/da.po +++ b/scripts/po/da.po @@ -8,7 +8,7 @@ msgid "" msgstr "" "Project-Id-Version: Arch Linux Pacman package manager\n" "Report-Msgid-Bugs-To: http://bugs.archlinux.org/index.php?project=3\n" -"POT-Creation-Date: 2012-03-28 18:00-0500\n" +"POT-Creation-Date: 2012-05-20 11:26-0500\n" "PO-Revision-Date: 2012-03-31 16:48+0000\n" "Last-Translator: jakobw <jakob.wadsager(a)gmail.com>\n" "Language-Team: Danish (http://www.transifex.net/projects/p/archlinux-pacman/" @@ -267,6 +267,9 @@ msgstr "%s må ikke være tom." msgid "%s is not allowed to start with a hyphen." msgstr "%s må ikke starte med en bindestreg." +msgid "%s contains invalid characters: '%s'" +msgstr "" + msgid "%s is not allowed to contain colons, hyphens or whitespace." msgstr "%s må ikke indeholde koloner, bindestreger eller mellemrum." @@ -799,16 +802,19 @@ msgstr "Deaktiverer tilbagekaldte nøgler i nøglering..." msgid "Disabling key %s..." msgstr "Deaktiverer nøgle %s..." -msgid "A specified keyfile could not be added to the gpg keychain." +#, fuzzy +msgid "A specified keyfile could not be added to the keyring." msgstr "En angivet nøglefil kunne ikke tilføjes til gpg-nøgleringen." -msgid "A specified key could not be removed from the gpg keychain." +#, fuzzy +msgid "A specified key could not be removed from the keyring." msgstr "En angivet nøgle kunne ikke fjernes fra gpg-nøgleringen." msgid "The key identified by %s could not be edited." msgstr "Nøglen identificeret ved %s kunne ikke redigeres." -msgid "A specified key could not be exported from the gpg keychain." +#, fuzzy +msgid "A specified key could not be exported from the keyring." msgstr "En angivet nøgle kunne ikke blive eksporteret fra gpg-nøgleringen." msgid "The fingerprint of a specified key could not be determined." @@ -923,7 +929,8 @@ msgstr "Roterer database på plads..." msgid "Finished. Your pacman database has been optimized." msgstr "Færdig. Din pacman-database er blevet optimeret." -msgid "Usage: pkgdelta [-q] <package1> <package2>\\n" +#, fuzzy +msgid "Usage: pkgdelta [options] <package1> <package2>\\n" msgstr "Brug: pkgdelta [-q] <pakke1> <pakke2>\\n" msgid "" @@ -936,6 +943,22 @@ msgstr "" msgid "Example: pkgdelta pacman-3.0.0.pkg.tar.gz pacman-3.0.1.pkg.tar.gz" msgstr "Eksempel: pkgdelta pacman-3.0.0.pkg.tar.gz pacman-3.0.1.pkg.tar.gz" +msgid "Options:\\n" +msgstr "Valgmuligheder:\\n" + +msgid " -q, --quiet minimize output\\n" +msgstr " -q, --quiet minimer uddata\\n" + +msgid "" +" --min-pkg-size minimum package size before deltas are generated " +"(bytes)\\n" +msgstr "" + +msgid "" +" --max-delta-size percent of package size above which deltas will be " +"discarded\\n" +msgstr "" + msgid "" "Copyright (c) 2009 Xavier Chantry <shiningxc(a)gmail.com>.\\n\\nThis is free " "software; see the source for copying conditions.\\nThere is NO WARRANTY, to " @@ -948,6 +971,9 @@ msgstr "" msgid "Invalid package file '%s'." msgstr "Ugyldig pakkefil '%s'." +msgid "Skipping delta creation for small package: %s - size %s" +msgstr "" + msgid "The package names don't match : '%s' and '%s'" msgstr "Pakkenavnene er ikke ens: '%s' og '%s'" @@ -963,6 +989,9 @@ msgstr "Genererer delta fra version %s til version %s" msgid "Delta could not be created." msgstr "Delta kunne ikke oprettes." +msgid "Delta package larger than maximum size. Removing." +msgstr "" + msgid "Generated delta : '%s'" msgstr "Genereret delta : '%s'" @@ -982,9 +1011,6 @@ msgstr "" "repo-add opdaterer en pakkedatabase ved at læse en pakkefil. \\nFlere pakker " "kan tilføjes ved at angive disse på kommandolinien.\\n" -msgid "Options:\\n" -msgstr "Valgmuligheder:\\n" - msgid " -d, --delta generate and add delta for package update\\n" msgstr " -d, --delta generer og tilføj delta for pakkeopdatering\\n" @@ -1007,9 +1033,6 @@ msgstr "" msgid "Please move along, there is nothing to see here.\\n" msgstr "Fortsæt venligst, der er ikke noget at se her.\\n" -msgid " -q, --quiet minimize output\\n" -msgstr " -q, --quiet minimer uddata\\n" - msgid " -s, --sign sign database with GnuPG after update\\n" msgstr " -s, --sign signer database med GnuPG efter opdatering\\n" diff --git a/scripts/po/de.po b/scripts/po/de.po index d1bd9ae..fc2015c 100644 --- a/scripts/po/de.po +++ b/scripts/po/de.po @@ -14,7 +14,7 @@ msgid "" msgstr "" "Project-Id-Version: Arch Linux Pacman package manager\n" "Report-Msgid-Bugs-To: http://bugs.archlinux.org/index.php?project=3\n" -"POT-Creation-Date: 2012-03-28 18:00-0500\n" +"POT-Creation-Date: 2012-05-20 11:26-0500\n" "PO-Revision-Date: 2012-03-29 10:22+0000\n" "Last-Translator: Matthias Gorissen <matthias(a)archlinux.de>\n" "Language-Team: German (http://www.transifex.net/projects/p/archlinux-pacman/" @@ -276,6 +276,9 @@ msgstr "%s darf nicht leer sein." msgid "%s is not allowed to start with a hyphen." msgstr "%s darf nicht mit einem Bindestrich beginnen." +msgid "%s contains invalid characters: '%s'" +msgstr "" + msgid "%s is not allowed to contain colons, hyphens or whitespace." msgstr "%s darf keine Doppelpunkte, Bindestriche oder Leerzeichen enthalten." @@ -858,12 +861,14 @@ msgstr "Mache widerrufene Schlüssel im Schlüsselbund unbrauchbar ..." msgid "Disabling key %s..." msgstr "Mache Schlüssel %s unbrauchbar ..." -msgid "A specified keyfile could not be added to the gpg keychain." +#, fuzzy +msgid "A specified keyfile could not be added to the keyring." msgstr "" "Eine spezifizierte Schlüsseldatei konnte nicht zum GPG-Schlüsselbund " "hinzugefügt werden." -msgid "A specified key could not be removed from the gpg keychain." +#, fuzzy +msgid "A specified key could not be removed from the keyring." msgstr "" "Ein spezifizierter Schlüssel konnte nicht vom GPG-Schlüsselbund entfernt " "werden." @@ -871,7 +876,8 @@ msgstr "" msgid "The key identified by %s could not be edited." msgstr "Der von %s identifizierte Schlüssel konnte nicht bearbeitet werden." -msgid "A specified key could not be exported from the gpg keychain." +#, fuzzy +msgid "A specified key could not be exported from the keyring." msgstr "" "Ein bestimmter Schlüssel konnte nicht vom GPG-Schlüsselbund exportiert " "werden." @@ -996,7 +1002,8 @@ msgstr "Verschiebe neue Datenbank an ihren Ort..." msgid "Finished. Your pacman database has been optimized." msgstr "Fertig. Ihre Pacman-Datenbank wurde optimiert." -msgid "Usage: pkgdelta [-q] <package1> <package2>\\n" +#, fuzzy +msgid "Usage: pkgdelta [options] <package1> <package2>\\n" msgstr "Verwendung: pkgdelta [-q] <Paket1> <Paket2>\\n" msgid "" @@ -1010,6 +1017,22 @@ msgstr "" msgid "Example: pkgdelta pacman-3.0.0.pkg.tar.gz pacman-3.0.1.pkg.tar.gz" msgstr "Beispiel: pkgdelta pacman-3.0.0.pkg.tar.gz pacman-3.0.1.pkg.tar.gz" +msgid "Options:\\n" +msgstr "Optionen:\\n" + +msgid " -q, --quiet minimize output\\n" +msgstr " -q, --quiet minimiere Ausgaben\\n" + +msgid "" +" --min-pkg-size minimum package size before deltas are generated " +"(bytes)\\n" +msgstr "" + +msgid "" +" --max-delta-size percent of package size above which deltas will be " +"discarded\\n" +msgstr "" + msgid "" "Copyright (c) 2009 Xavier Chantry <shiningxc(a)gmail.com>.\\n\\nThis is free " "software; see the source for copying conditions.\\nThere is NO WARRANTY, to " @@ -1022,6 +1045,9 @@ msgstr "" msgid "Invalid package file '%s'." msgstr "Ungültige Paket-Datei '%s'." +msgid "Skipping delta creation for small package: %s - size %s" +msgstr "" + msgid "The package names don't match : '%s' and '%s'" msgstr "Die Paketnamen stimmen nicht überein: '%s' und '%s'" @@ -1037,6 +1063,9 @@ msgstr "Erstelle Delta von Version %s zu Version %s" msgid "Delta could not be created." msgstr "Delta konnte nicht erstellt werden." +msgid "Delta package larger than maximum size. Removing." +msgstr "" + msgid "Generated delta : '%s'" msgstr "Erstellte Delta: '%s'" @@ -1058,9 +1087,6 @@ msgstr "" "ausliest.\\nWenn mehrere Pakete hinzugefügt werden sollen, kann dies auf der " "Kommando-Zeile spezifiziert werden.\\n" -msgid "Options:\\n" -msgstr "Optionen:\\n" - msgid " -d, --delta generate and add delta for package update\\n" msgstr "" " -d, --delta erzeuge und füge Delta-Datei für Paket-Update hinzu" @@ -1085,9 +1111,6 @@ msgstr "" msgid "Please move along, there is nothing to see here.\\n" msgstr "Bitte weiter gehen. Hier gibt es nichts zu sehen.\\n" -msgid " -q, --quiet minimize output\\n" -msgstr " -q, --quiet minimiere Ausgaben\\n" - msgid " -s, --sign sign database with GnuPG after update\\n" msgstr " -s, --sign signiere Datenbank mit GnuPG nach dem Update\\n" diff --git a/scripts/po/el.po b/scripts/po/el.po index 5a6dc88..b6ac674 100644 --- a/scripts/po/el.po +++ b/scripts/po/el.po @@ -9,7 +9,7 @@ msgid "" msgstr "" "Project-Id-Version: Arch Linux Pacman package manager\n" "Report-Msgid-Bugs-To: http://bugs.archlinux.org/index.php?project=3\n" -"POT-Creation-Date: 2012-03-28 18:00-0500\n" +"POT-Creation-Date: 2012-05-20 11:26-0500\n" "PO-Revision-Date: 2012-02-02 08:19+0000\n" "Last-Translator: Christos Nouskas <nous(a)archlinux.us>\n" "Language-Team: Greek (http://www.transifex.net/projects/p/archlinux-pacman/" @@ -267,6 +267,9 @@ msgstr "Το %s δεν επιτρέπεται να είναι κενό." msgid "%s is not allowed to start with a hyphen." msgstr "Το %s δεν επιτρέπεται να ξεκινά με παύλα." +msgid "%s contains invalid characters: '%s'" +msgstr "" + msgid "%s is not allowed to contain colons, hyphens or whitespace." msgstr "Δεν επιτρέπεται η χρήση ερωτηματικού, παύλας ή διαστήματος στο %s." @@ -798,16 +801,19 @@ msgstr "Απενεργοποίηση ανακληθέντων κλειδιών msgid "Disabling key %s..." msgstr "Απενεργοποίηση κλειδιού %s..." -msgid "A specified keyfile could not be added to the gpg keychain." +#, fuzzy +msgid "A specified keyfile could not be added to the keyring." msgstr "Αδυναμία προσθήκης αρχείου κλειδιών στην κλειδοθήκη gpg." -msgid "A specified key could not be removed from the gpg keychain." +#, fuzzy +msgid "A specified key could not be removed from the keyring." msgstr "Αδυναμία διαγραφής κλειδιού από την κλειδοθήκη gpg." msgid "The key identified by %s could not be edited." msgstr "Αδυναμία επεξεργασίας κλειδιού %s." -msgid "A specified key could not be exported from the gpg keychain." +#, fuzzy +msgid "A specified key could not be exported from the keyring." msgstr "Αδυναμία εξαγωγής κλειδιού από την κλειδοθήκη gpg." msgid "The fingerprint of a specified key could not be determined." @@ -923,7 +929,8 @@ msgstr "Μεταστροφή βάσης..." msgid "Finished. Your pacman database has been optimized." msgstr "Τέλος. Η βάση πακέτων του pacman βελτιστοποιήθηκε." -msgid "Usage: pkgdelta [-q] <package1> <package2>\\n" +#, fuzzy +msgid "Usage: pkgdelta [options] <package1> <package2>\\n" msgstr "Χρήση: pkgdelta [-q] <πακέτο1> <πακέτο2>\\n" msgid "" @@ -936,6 +943,22 @@ msgstr "" msgid "Example: pkgdelta pacman-3.0.0.pkg.tar.gz pacman-3.0.1.pkg.tar.gz" msgstr "Παράδειγμα: pkgdelta pacman-3.0.0.pkg.tar.gz pacman-3.0.1.pkg.tar.gz" +msgid "Options:\\n" +msgstr "Επιλογές:\\n" + +msgid " -q, --quiet minimize output\\n" +msgstr " -q, --quiet περιστολή πληροφορίας\\n" + +msgid "" +" --min-pkg-size minimum package size before deltas are generated " +"(bytes)\\n" +msgstr "" + +msgid "" +" --max-delta-size percent of package size above which deltas will be " +"discarded\\n" +msgstr "" + msgid "" "Copyright (c) 2009 Xavier Chantry <shiningxc(a)gmail.com>.\\n\\nThis is free " "software; see the source for copying conditions.\\nThere is NO WARRANTY, to " @@ -949,6 +972,9 @@ msgstr "" msgid "Invalid package file '%s'." msgstr "Άκυρο όνομα πακέτου '%s'." +msgid "Skipping delta creation for small package: %s - size %s" +msgstr "" + msgid "The package names don't match : '%s' and '%s'" msgstr "Τα ονόματα των πακέτων δεν ταιριάζουν: '%s' και '%s'" @@ -964,6 +990,9 @@ msgstr "Δημιουργία delta από έκδοση %s σε %s" msgid "Delta could not be created." msgstr "Αδυναμία δημιουργίας delta." +msgid "Delta package larger than maximum size. Removing." +msgstr "" + msgid "Generated delta : '%s'" msgstr "Δημιουργία delta: '%s'" @@ -983,9 +1012,6 @@ msgstr "" "Το repo-add ενημερώνει μια βάση διαβάζοντας ένα αρχείο πακέτου.\\nΜπορούν να " "καθορισθούν στην γραμμή εντολών πολλαπλά πακέτα προς προσθήκη.\\n" -msgid "Options:\\n" -msgstr "Επιλογές:\\n" - msgid " -d, --delta generate and add delta for package update\\n" msgstr "" " -d, --delta παραγωγή και προσθήκη delta για αναβάθμιση πακέτου\\n" @@ -1008,9 +1034,6 @@ msgstr "" msgid "Please move along, there is nothing to see here.\\n" msgstr "Συνέχισε παρακάτω, δεν υπάρχει τίποτε να δεις εδώ.\\n" -msgid " -q, --quiet minimize output\\n" -msgstr " -q, --quiet περιστολή πληροφορίας\\n" - msgid " -s, --sign sign database with GnuPG after update\\n" msgstr " -s, --sign υπογραφή βάσης με GnuPG μετά την ενημέρωση\\n" diff --git a/scripts/po/es.po b/scripts/po/es.po index 0e47f4a..c43bc24 100644 --- a/scripts/po/es.po +++ b/scripts/po/es.po @@ -9,7 +9,7 @@ msgid "" msgstr "" "Project-Id-Version: Arch Linux Pacman package manager\n" "Report-Msgid-Bugs-To: http://bugs.archlinux.org/index.php?project=3\n" -"POT-Creation-Date: 2012-03-28 18:00-0500\n" +"POT-Creation-Date: 2012-05-20 11:26-0500\n" "PO-Revision-Date: 2012-04-01 16:26+0000\n" "Last-Translator: Angel Velasquez <angvp(a)archlinux.org>\n" "Language-Team: Spanish (Castilian) (http://www.transifex.net/projects/p/" @@ -270,6 +270,9 @@ msgstr "No está permitido que %s esté vacío." msgid "%s is not allowed to start with a hyphen." msgstr "No está permitido que %s comience con un guion." +msgid "%s contains invalid characters: '%s'" +msgstr "" + msgid "%s is not allowed to contain colons, hyphens or whitespace." msgstr "%s no puede tener dos puntos, guiones o espacios en blanco." @@ -833,17 +836,20 @@ msgstr "Desactivación de las llaves revocadas en llavero ..." msgid "Disabling key %s..." msgstr "Deshabilitando llave %s..." -msgid "A specified keyfile could not be added to the gpg keychain." +#, fuzzy +msgid "A specified keyfile could not be added to the keyring." msgstr "La llave especificada no puede ser añadida a la cadena de llaves gpg." -msgid "A specified key could not be removed from the gpg keychain." +#, fuzzy +msgid "A specified key could not be removed from the keyring." msgstr "" "La llave especificada no puede ser removida de la cadena de llaves gpg." msgid "The key identified by %s could not be edited." msgstr "La llave identificada por %s no puede ser editada." -msgid "A specified key could not be exported from the gpg keychain." +#, fuzzy +msgid "A specified key could not be exported from the keyring." msgstr "" "La llave especificada no puede ser exportada de la cadena de llaves gpg." @@ -964,7 +970,8 @@ msgstr "Rotando el sitio de la base de datos..." msgid "Finished. Your pacman database has been optimized." msgstr "Finalizado. Su base de datos de Pacman ha sido optimizada." -msgid "Usage: pkgdelta [-q] <package1> <package2>\\n" +#, fuzzy +msgid "Usage: pkgdelta [options] <package1> <package2>\\n" msgstr "Uso: pkgdelta [-q] <paquete1> <paquete2>\\n" msgid "" @@ -977,6 +984,22 @@ msgstr "" msgid "Example: pkgdelta pacman-3.0.0.pkg.tar.gz pacman-3.0.1.pkg.tar.gz" msgstr "Ejemplo: pkgdelta pacman-3.0.0.pkg.tar.gz pacman-3.0.1.pkg.tar.gz" +msgid "Options:\\n" +msgstr "Opciones:\\n" + +msgid " -q, --quiet minimize output\\n" +msgstr " -q, --quiet reducir salida\\n" + +msgid "" +" --min-pkg-size minimum package size before deltas are generated " +"(bytes)\\n" +msgstr "" + +msgid "" +" --max-delta-size percent of package size above which deltas will be " +"discarded\\n" +msgstr "" + msgid "" "Copyright (c) 2009 Xavier Chantry <shiningxc(a)gmail.com>.\\n\\nThis is free " "software; see the source for copying conditions.\\nThere is NO WARRANTY, to " @@ -989,6 +1012,9 @@ msgstr "" msgid "Invalid package file '%s'." msgstr "Archivo de paquete no válido '%s'." +msgid "Skipping delta creation for small package: %s - size %s" +msgstr "" + msgid "The package names don't match : '%s' and '%s'" msgstr "Los nombres de los paquetes no coinciden: '%s' y '%s'" @@ -1004,6 +1030,9 @@ msgstr "Generando delta de versión %s a la versión %s" msgid "Delta could not be created." msgstr "No se pudo crear delta." +msgid "Delta package larger than maximum size. Removing." +msgstr "" + msgid "Generated delta : '%s'" msgstr "Delta generado: '%s'" @@ -1024,9 +1053,6 @@ msgstr "" "\\nPueden ser agregados multiples paquetes especificandolo en la linea de " "comandos.\\n" -msgid "Options:\\n" -msgstr "Opciones:\\n" - msgid " -d, --delta generate and add delta for package update\\n" msgstr "" " -d, --delta genera y añade un diferencia para la actualización del" @@ -1053,9 +1079,6 @@ msgstr "" msgid "Please move along, there is nothing to see here.\\n" msgstr "Por favor siga, no hay nada que ver aquí.\\n" -msgid " -q, --quiet minimize output\\n" -msgstr " -q, --quiet reducir salida\\n" - msgid " -s, --sign sign database with GnuPG after update\\n" msgstr "" " -s, --sign firmar la base de datos con GnuPG tras la actualización" diff --git a/scripts/po/fi.po b/scripts/po/fi.po index bdc671c..76743b4 100644 --- a/scripts/po/fi.po +++ b/scripts/po/fi.po @@ -9,7 +9,7 @@ msgid "" msgstr "" "Project-Id-Version: Arch Linux Pacman package manager\n" "Report-Msgid-Bugs-To: http://bugs.archlinux.org/index.php?project=3\n" -"POT-Creation-Date: 2012-03-28 18:00-0500\n" +"POT-Creation-Date: 2012-05-20 11:26-0500\n" "PO-Revision-Date: 2012-02-10 22:06+0000\n" "Last-Translator: Larso <larso(a)gmx.com>\n" "Language-Team: Finnish (http://www.transifex.net/projects/p/archlinux-pacman/" @@ -267,6 +267,9 @@ msgstr "%s ei saa olla tyhjä." msgid "%s is not allowed to start with a hyphen." msgstr "%s ei saa alkaa tavuviivalla." +msgid "%s contains invalid characters: '%s'" +msgstr "" + msgid "%s is not allowed to contain colons, hyphens or whitespace." msgstr "%s ei saa sisältää tavuviivoja, kaksoispisteitä eikä tyhjiä välejä." @@ -810,16 +813,19 @@ msgstr "Poistetaan avainnipun mitätöidyt avaimet käytöstä..." msgid "Disabling key %s..." msgstr "Poistetaan avain %s käytöstä..." -msgid "A specified keyfile could not be added to the gpg keychain." +#, fuzzy +msgid "A specified keyfile could not be added to the keyring." msgstr "Määritettyä avaintiedostoa ei voitu lisätä gpg-avainketjuun." -msgid "A specified key could not be removed from the gpg keychain." +#, fuzzy +msgid "A specified key could not be removed from the keyring." msgstr "Määritettyä avainta ei voitu poistaa gpg-avainketjusta." msgid "The key identified by %s could not be edited." msgstr "Avainta tunnisteella %s ei voitu muokata." -msgid "A specified key could not be exported from the gpg keychain." +#, fuzzy +msgid "A specified key could not be exported from the keyring." msgstr "Määritettyä avainta ei voitu viedä gpg-avainketjusta." msgid "The fingerprint of a specified key could not be determined." @@ -934,7 +940,8 @@ msgstr "Pyöritellään tietokantaa paikalleen..." msgid "Finished. Your pacman database has been optimized." msgstr "Valmis. Pakettitietokantasi on nyt optimoitu." -msgid "Usage: pkgdelta [-q] <package1> <package2>\\n" +#, fuzzy +msgid "Usage: pkgdelta [options] <package1> <package2>\\n" msgstr "Käyttö: pkgdelta [-q] <paketti1> <paketti2>\\n" msgid "" @@ -947,6 +954,22 @@ msgstr "" msgid "Example: pkgdelta pacman-3.0.0.pkg.tar.gz pacman-3.0.1.pkg.tar.gz" msgstr "Esimerkki: pkgdelta pacman-3.0.0.pkg.tar.gz pacman-3.0.1.pkg.tar.gz" +msgid "Options:\\n" +msgstr "Valinnat:\\n" + +msgid " -q, --quiet minimize output\\n" +msgstr " -q, --quiet minimoi viestien määrä\\n" + +msgid "" +" --min-pkg-size minimum package size before deltas are generated " +"(bytes)\\n" +msgstr "" + +msgid "" +" --max-delta-size percent of package size above which deltas will be " +"discarded\\n" +msgstr "" + msgid "" "Copyright (c) 2009 Xavier Chantry <shiningxc(a)gmail.com>.\\n\\nThis is free " "software; see the source for copying conditions.\\nThere is NO WARRANTY, to " @@ -959,6 +982,9 @@ msgstr "" msgid "Invalid package file '%s'." msgstr "Pakettitiedosto '%s' ei ole kelvollinen." +msgid "Skipping delta creation for small package: %s - size %s" +msgstr "" + msgid "The package names don't match : '%s' and '%s'" msgstr "Pakettien nimet eivät täsmää: '%s' ja '%s'" @@ -974,6 +1000,9 @@ msgstr "Luodaan deltaa versiosta %s versioon %s" msgid "Delta could not be created." msgstr "Deltaa ei voitu luoda." +msgid "Delta package larger than maximum size. Removing." +msgstr "" + msgid "Generated delta : '%s'" msgstr "Luotiin delta: '%s'" @@ -994,9 +1023,6 @@ msgstr "" "repo-add päivittää pakettitietokannan lukemalla pakettitiedoston." "\\nKomentorivillä voi antaa useita päivitettäviä paketteja.\\n" -msgid "Options:\\n" -msgstr "Valinnat:\\n" - msgid " -d, --delta generate and add delta for package update\\n" msgstr " -d, --delta luo ja lisää delta paketti\\n" @@ -1018,9 +1044,6 @@ msgstr "" msgid "Please move along, there is nothing to see here.\\n" msgstr "Jatkakaa matkaanne, täällä ei ole mitään nähtävää.\\n" -msgid " -q, --quiet minimize output\\n" -msgstr " -q, --quiet minimoi viestien määrä\\n" - msgid " -s, --sign sign database with GnuPG after update\\n" msgstr " -s, --sign allekirjoita tietokanta GnuGP:llä\\n" diff --git a/scripts/po/fr.po b/scripts/po/fr.po index daac032..a3dd57e 100644 --- a/scripts/po/fr.po +++ b/scripts/po/fr.po @@ -12,7 +12,7 @@ msgid "" msgstr "" "Project-Id-Version: Arch Linux Pacman package manager\n" "Report-Msgid-Bugs-To: http://bugs.archlinux.org/index.php?project=3\n" -"POT-Creation-Date: 2012-03-28 18:00-0500\n" +"POT-Creation-Date: 2012-05-20 11:26-0500\n" "PO-Revision-Date: 2012-02-07 03:54+0000\n" "Last-Translator: Dan McGee <dpmcgee(a)gmail.com>\n" "Language-Team: French (http://www.transifex.net/projects/p/archlinux-pacman/" @@ -276,6 +276,9 @@ msgstr "%s ne peut pas être vide." msgid "%s is not allowed to start with a hyphen." msgstr "%s ne peut pas commencer par un tiret." +msgid "%s contains invalid characters: '%s'" +msgstr "" + msgid "%s is not allowed to contain colons, hyphens or whitespace." msgstr "%s ne peut pas contenir de deux-points, de tirets ou d'espaces." @@ -869,18 +872,21 @@ msgstr "Désactivation des clefs révoquées du porte-clefs…" msgid "Disabling key %s..." msgstr "Désactivation de la clef %s…" -msgid "A specified keyfile could not be added to the gpg keychain." +#, fuzzy +msgid "A specified keyfile could not be added to the keyring." msgstr "" "Un fichier de clefs spécifié n'a pas pu être ajouté au porte-clefs GPG." -msgid "A specified key could not be removed from the gpg keychain." +#, fuzzy +msgid "A specified key could not be removed from the keyring." msgstr "" "Un fichier de clefs spécifié n'a pas pu être supprimé du porte-clefs GPG." msgid "The key identified by %s could not be edited." msgstr "La clef identifiée par %s n'a pas pu être éditée." -msgid "A specified key could not be exported from the gpg keychain." +#, fuzzy +msgid "A specified key could not be exported from the keyring." msgstr "Une clef spécifiée n'a pas pu être exporté du porte-clef GPG." msgid "The fingerprint of a specified key could not be determined." @@ -1008,7 +1014,8 @@ msgstr "Mise en place de la base de données..." msgid "Finished. Your pacman database has been optimized." msgstr "Fini. La base de données de pacman a été optimisée." -msgid "Usage: pkgdelta [-q] <package1> <package2>\\n" +#, fuzzy +msgid "Usage: pkgdelta [options] <package1> <package2>\\n" msgstr "Utilisation : pkgdelta [-q] <package1> <package2>\\n" msgid "" @@ -1021,6 +1028,22 @@ msgstr "" msgid "Example: pkgdelta pacman-3.0.0.pkg.tar.gz pacman-3.0.1.pkg.tar.gz" msgstr "Exemple : pkgdelta pacman-3.0.0.pkg.tar.gz pacman-3.0.1.pkg.tar.gz" +msgid "Options:\\n" +msgstr "Options :\\n" + +msgid " -q, --quiet minimize output\\n" +msgstr " -q, --quiet minimise la sortie\\n" + +msgid "" +" --min-pkg-size minimum package size before deltas are generated " +"(bytes)\\n" +msgstr "" + +msgid "" +" --max-delta-size percent of package size above which deltas will be " +"discarded\\n" +msgstr "" + msgid "" "Copyright (c) 2009 Xavier Chantry <shiningxc(a)gmail.com>.\\n\\nThis is free " "software; see the source for copying conditions.\\nThere is NO WARRANTY, to " @@ -1033,6 +1056,9 @@ msgstr "" msgid "Invalid package file '%s'." msgstr "Le paquet « %s » est invalide." +msgid "Skipping delta creation for small package: %s - size %s" +msgstr "" + msgid "The package names don't match : '%s' and '%s'" msgstr "Les nom du paquet n'est pas cohérent : « %s » et « %s »" @@ -1048,6 +1074,9 @@ msgstr "Génération du delta de la version %s vers la version %s" msgid "Delta could not be created." msgstr "Impossible de créer le delta." +msgid "Delta package larger than maximum size. Removing." +msgstr "" + msgid "Generated delta : '%s'" msgstr "Delta généré : « %s »" @@ -1070,9 +1099,6 @@ msgstr "" "« repo-add » va mêttre à jour un dépot à partir d'un paquet.\\nIl est " "possible de spécifier plusieurs paquets à ajouter.\\n" -msgid "Options:\\n" -msgstr "Options :\\n" - msgid " -d, --delta generate and add delta for package update\\n" msgstr "" " -d, --delta génère et ajoute un delta pour la mise à jour des paquets" @@ -1100,9 +1126,6 @@ msgstr "" msgid "Please move along, there is nothing to see here.\\n" msgstr "Veuillez partir, il n'y a rien à voir ici.\\n" -msgid " -q, --quiet minimize output\\n" -msgstr " -q, --quiet minimise la sortie\\n" - msgid " -s, --sign sign database with GnuPG after update\\n" msgstr "" " -s, --sign signer la base de données avec GnuPG après la mise à jour" diff --git a/src/pacman/pacman.c b/src/pacman/pacman.c index 73d5be9..6226ee1 100644 --- a/src/pacman/pacman.c +++ b/src/pacman/pacman.c @@ -857,6 +857,8 @@ int main(int argc, char *argv[]) } } + pm_printf(ALPM_LOG_DEBUG, "pacman v%s - libalpm v%s\n", PACKAGE_VERSION, alpm_version()); + /* parse the config file */ ret = parseconfig(config->configfile); if(ret != 0) { -- 1.7.10.3

1 1

[pacman-dev] [PATCH] Create repo-remove symlink in scripts dir
by Allan McRae 07 Jun '12

07 Jun '12

Fix the creation of the repo-remove symlink in the scripts/ dir on building. Signed-off-by: Allan McRae <allan(a)archlinux.org> --- scripts/Makefile.am | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/scripts/Makefile.am b/scripts/Makefile.am index 9a08524..29c81aa 100644 --- a/scripts/Makefile.am +++ b/scripts/Makefile.am @@ -4,7 +4,9 @@ AUTOMAKE_OPTIONS = std-options SUBDIRS = po bin_SCRIPTS = \ - $(OURSCRIPTS) + $(OURSCRIPTS) \ + repo-remove \ + repo-elephant OURSCRIPTS = \ makepkg \ @@ -94,12 +96,12 @@ repo-add: \ $(srcdir)/library/output_format.sh repo-remove: $(srcdir)/repo-add.sh.in - $(RM) repo-remove - $(LN_S) repo-add repo-remove + $(AM_V_at)$(RM) repo-remove + $(AM_V_at)$(LN_S) repo-add repo-remove repo-elephant: $(srcdir)/repo-add.sh.in - $(RM) repo-elephant - $(LN_S) repo-add repo-elephant + $(AM_V_at)$(RM) repo-elephant + $(AM_V_at)$(LN_S) repo-add repo-elephant install-data-hook: cd $(DESTDIR)$(bindir) && \ -- 1.7.10.3

1 0

[pacman-dev] [RFC] [PATCH] makepkg: provide mechanism for auto-updating pkgver
by Allan McRae 05 Jun '12

05 Jun '12

Now that VCS repos are provided in the source array, it becomes too complicated to have automatic updating pkgver as was the case with the old VCS PKGBUILDs (there can be multiple repos of different types in the source array, the VCS repo may not be the package primary source, etc). Instead provide an optional way for a PKGBUILD to update the pkgver value through the specifing of a pkgver() function that returns the new version string. This is run after all source files are downloaded so can access the VCS repo if needed. Signed-off-by: Allan McRae <allan(a)archlinux.org> --- Note that this means that now makepkg in no way modifies your PKGBUILD unless requested. For example... in a PKGBUILD: pkgver=1 source=('git+https://projects.archlinux.org/git/pacman.git#branch=maint') pkgver() { cd $srcdir/pacman ver=$(git describe | sed 's/-/_/g') printf "%s\n" "${ver##v}" } will set the pkgver to something like "4.0.3_17_g5de465d". scripts/makepkg.sh.in | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index 689a2f6..7d4636f 100644 --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in @@ -462,9 +462,30 @@ download_sources() { esac done + if declare -f pkgver >/dev/null; then + update_pkgver + fi + popd &>/dev/null } +# Automatically update pkgver variable if a pkgver() function is provided +# Re-sources the PKGBUILD afterwards to allow for other variables that use $pkgver +update_pkgver() { + newpkgver=$(pkgver) + + if [[ -n $newpkgver && $newpkgver != "$pkgver" ]]; then + if [[ -f $BUILDFILE && -w $BUILDFILE ]]; then + @SEDINPLACE@ "s/^pkgver=[^ ]*/pkgver=$newpkgver/" "$BUILDFILE" + @SEDINPLACE@ "s/^pkgrel=[^ ]*/pkgrel=1/" "$BUILDFILE" + source "$BUILDFILE" + else + warning "$(gettext "%s is not writeable -- pkgver will not be updated")" \ + "$BUILDFILE" + fi + fi +} + # Print 'source not found' error message and exit makepkg missing_source_file() { error "$(gettext "Unable to find source file %s.")" "$(get_filename "$1")" -- 1.7.10.3

1 0

[pacman-dev] [RFC] [PATCH 0/4] makepkg: VCS package overhaul
by Allan McRae 04 Jun '12

04 Jun '12

This is my first attempt at overhauling the really crap VCS PKGBUILD support in makepkg. So far only git is implemented. This is for initial comments. There is still much to tidy up (apart from reinstating all the other VCS...), but using git works. E.g. to make a package for pacman-git from the maint branch: source=('git+https://projects.archlinux.org/git/pacman.git#branch=maint') Currently you need to use --skipinteg, as integrity checking is broken. So is generating the integrity checks. Also, I would like ideas on how to stop the git repo being updated. This is a common request for having VCS PKGBUILDs work offline (assumably after an initial checkout...). Should I add a new flag, or just not error out when updating the repo fails? Allan McRae (4): makepkg: remove VCS package support makepkg: reorder source handling functions makepkg: generalize download_sources makepkg: allow using GIT source URLs scripts/makepkg.sh.in | 467 ++++++++++++++++++++++++------------------------- 1 file changed, 230 insertions(+), 237 deletions(-) -- 1.7.10.3

1 5

[pacman-dev] [PATCH] makepkg patch for scp
by William J. Bowman 03 Jun '12

03 Jun '12

Hello all, I recently tried to specify a source URL in a PKGBUILD of the form "scp://host:file". This caused all kinds of problem because, despite a DLAGENT for scp existing in the default makepkg.conf, that is an invalid URL for scp. After a bit of discussion in #archlinux, the correct solution seemed to be patching makepkg to seperate the protocol from the URL. So here's a patch. William Bowman From 4d0b60a4108bb71835553d0aafa70ba327bac036 Mon Sep 17 00:00:00 2001 From: "William J. Bowman" <wjb(a)williamjbowman.com> Date: Sat, 2 Jun 2012 17:17:18 -0400 Subject: [PATCH] Modified makepkg so DLAGENT can work with scp. Require %p to be specified in the DLAGENT agent string for the protocol to be included in the agent string, and changed the makepkg.conf to use it as part of the URL for all except scp. This change is because "scp://host:file" is not a valid URL for scp. Instead, scp expects only "host:file" (or user@host:file), without the protocol. Signed-off-by: William J. Bowman <wjb(a)williamjbowman.com> --- etc/makepkg.conf.in | 8 ++++---- scripts/makepkg.sh.in | 12 +++++++++++- 2 files changed, 15 insertions(+), 5 deletions(-) diff --git a/etc/makepkg.conf.in b/etc/makepkg.conf.in index 51df493..433fd5d 100644 --- a/etc/makepkg.conf.in +++ b/etc/makepkg.conf.in @@ -8,10 +8,10 @@ # #-- The download utilities that makepkg should use to acquire sources # Format: 'protocol::agent' -DLAGENTS=('ftp::/usr/bin/curl -fC - --ftp-pasv --retry 3 --retry-delay 3 -o %o %u' - 'http::/usr/bin/curl -b "" -fLC - --retry 3 --retry-delay 3 -o %o %u' - 'https::/usr/bin/curl -b "" -fLC - --retry 3 --retry-delay 3 -o %o %u' - 'rsync::/usr/bin/rsync --no-motd -z %u %o' +DLAGENTS=('ftp::/usr/bin/curl -fC - --ftp-pasv --retry 3 --retry-delay 3 -o %o %p://%u' + 'http::/usr/bin/curl -b "" -fLC - --retry 3 --retry-delay 3 -o %o %p://%u' + 'https::/usr/bin/curl -b "" -fLC - --retry 3 --retry-delay 3 -o %o %p://%u' + 'rsync::/usr/bin/rsync --no-motd -z %p://%u %o' 'scp::/usr/bin/scp -C %u %o') # Other common tools: diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index 718b4e9..dccad87 100644 --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in @@ -433,6 +433,12 @@ download_file() { local url=$2 # destination file local file=$3 + + # To use scp, we can't have the protocol as part of the URL, so we + # seperate them and let the DLAGENT decide what to do with them. + local proto="${url%%://*}" + url="${url##*://}" + # temporary download file, default to last component of the URL local dlfile="${url##*/}" @@ -441,11 +447,15 @@ download_file() { dlcmd=${dlcmd//\%o/\"$file.part\"} dlfile="$file.part" fi + # add the protocol, or don't + if [[ $dlcmd = *%p* ]]; then + dlcmd=${dlcmd//\%p/\"$proto\"} + fi # add the URL, either in place of %u or at the end if [[ $dlcmd = *%u* ]]; then dlcmd=${dlcmd//\%u/\"$url\"} else - dlcmd="$dlcmd \"$url\"" + dlcmd="$dlcmd \"$proto://$url\"" fi local ret=0 -- 1.7.10.3

2 1

[pacman-dev] [PATCH] makepkg: allow url to be overridden in split packages
by Allan McRae 02 Jun '12

02 Jun '12

This is already being used (despite not working...) in packages in the Arch Linux repos. Signed-off-by: Allan McRae <allan(a)archlinux.org> --- doc/PKGBUILD.5.txt | 6 +++--- proto/PKGBUILD-split.proto | 1 + scripts/makepkg.sh.in | 2 +- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/doc/PKGBUILD.5.txt b/doc/PKGBUILD.5.txt index 384af7c..404a55c 100644 --- a/doc/PKGBUILD.5.txt +++ b/doc/PKGBUILD.5.txt @@ -324,9 +324,9 @@ Each split package uses a corresponding packaging function with name All options and directives for the split packages default to the global values given in the PKGBUILD. Nevertheless, the following ones can be overridden within each split package's packaging function: -`pkgver`, `pkgrel`, `epoch`, `pkgdesc`, `arch`, `license`, `groups`, `depends`, -`optdepends`, `provides`, `conflicts`, `replaces`, `backup`, `options`, -`install` and `changelog`. +`pkgver`, `pkgrel`, `epoch`, `pkgdesc`, `arch`, `url`, `license`, `groups`, +`depends`, `optdepends`, `provides`, `conflicts`, `replaces`, `backup`, +`options`, `install` and `changelog`. An optional global directive is available when building a split package: diff --git a/proto/PKGBUILD-split.proto b/proto/PKGBUILD-split.proto index 763cb86..f873db6 100644 --- a/proto/PKGBUILD-split.proto +++ b/proto/PKGBUILD-split.proto @@ -46,6 +46,7 @@ package_pkg1() { epoch= pkgdesc="" arch=() + url="" license=() groups=() depends=() diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index b0918ae..bd7a44f 100644 --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in @@ -46,7 +46,7 @@ declare -r startdir="$PWD" packaging_options=('strip' 'docs' 'libtool' 'emptydirs' 'zipman' 'purge' 'upx') other_options=('ccache' 'distcc' 'buildflags' 'makeflags') -splitpkg_overrides=('pkgver' 'pkgrel' 'epoch' 'pkgdesc' 'arch' 'license' \ +splitpkg_overrides=('pkgver' 'pkgrel' 'epoch' 'pkgdesc' 'arch' 'url' 'license' \ 'groups' 'depends' 'optdepends' 'provides' 'conflicts' \ 'replaces' 'backup' 'options' 'install' 'changelog') readonly -a packaging_options other_options splitpkg_overrides -- 1.7.10.3

1 0

[pacman-dev] [RFC] [PATCH] makepkg: run locally with libtool style wrapper
by Allan McRae 28 May '12

28 May '12

Build makepkg to scripts/.lib/makepkg and add a wrapper script to call it. This is not useful at the moment, but is the first step to allowing makepkg to be split into smaller pieces. Signed-off-by: Allan McRae <allan(a)archlinux.org> --- This seems somewhat horrid, but I could not find a better way to do this. Once this splitting is started, it will be easy(er) to overhaul the VCS PKGBUILD system, and perhaps debugging symbol packages too... Tested that building and running "makepkg" in the usual way works, "make install" and "make distcheck" work. scripts/.gitignore | 1 + scripts/Makefile.am | 27 ++++++++++++++++++++++++++- scripts/makepkg-wrapper.sh.in | 23 +++++++++++++++++++++++ 3 files changed, 50 insertions(+), 1 deletion(-) create mode 100644 scripts/makepkg-wrapper.sh.in diff --git a/scripts/.gitignore b/scripts/.gitignore index 9e403bf..0310b9b 100644 --- a/scripts/.gitignore +++ b/scripts/.gitignore @@ -1,4 +1,5 @@ makepkg +makepkg-wrapper pacman-db-upgrade pacman-key pacman-optimize diff --git a/scripts/Makefile.am b/scripts/Makefile.am index 9a08524..71d6cc4 100644 --- a/scripts/Makefile.am +++ b/scripts/Makefile.am @@ -4,7 +4,8 @@ AUTOMAKE_OPTIONS = std-options SUBDIRS = po bin_SCRIPTS = \ - $(OURSCRIPTS) + $(OURSCRIPTS) \ + makepkg-wrapper OURSCRIPTS = \ makepkg \ @@ -16,6 +17,7 @@ OURSCRIPTS = \ EXTRA_DIST = \ makepkg.sh.in \ + makepkg-wrapper.sh.in \ pacman-db-upgrade.sh.in \ pacman-key.sh.in \ pacman-optimize.sh.in \ @@ -32,6 +34,9 @@ LIBRARY = \ # Files that should be removed, but which Automake does not know. MOSTLYCLEANFILES = $(bin_SCRIPTS) +clean-local: + $(AM_V_at)rm -rf .lib + if USE_GIT_VERSION GIT_VERSION := $(shell sh -c 'git describe --abbrev=4 --dirty | sed s/^v//') REAL_PACKAGE_VERSION = $(GIT_VERSION) @@ -69,6 +74,7 @@ $(OURSCRIPTS): Makefile makepkg: \ $(srcdir)/makepkg.sh.in \ + $(srcdir)/makepkg-wrapper.sh.in \ $(srcdir)/library/parseopts.sh pacman-db-upgrade: \ @@ -101,8 +107,27 @@ repo-elephant: $(srcdir)/repo-add.sh.in $(RM) repo-elephant $(LN_S) repo-add repo-elephant +makepkg-wrapper: \ + Makefile \ + $(srcdir)/makepkg-wrapper.sh.in \ + $(srcdir)/makepkg.sh.in \ + $(srcdir)/library/parseopts.sh \ + | makepkg + $(AM_V_at)$(MKDIR_P) .lib + $(AM_V_at)mv -f makepkg .lib + $(AM_V_at)$(RM) $@ + $(AM_V_GEN)sed \ + -e "s|@PWD[@]|$$(pwd)|" \ + -e '1s|!/bin/bash|!$(BASH_SHELL)|g' \ + $(srcdir)/$@.sh.in > $@ + $(AM_V_at)chmod +x,a-w $@ + $(AM_V_at)$(LN_S) makepkg-wrapper makepkg + install-data-hook: cd $(DESTDIR)$(bindir) && \ + $(RM) makepkg makepkg-wrapper + $(INSTALL) .lib/makepkg $(DESTDIR)$(bindir)/makepkg + cd $(DESTDIR)$(bindir) && \ $(RM) repo-elephant && \ ( $(LN_S) repo-add repo-elephant || \ ln repo-add repo-elephant || \ diff --git a/scripts/makepkg-wrapper.sh.in b/scripts/makepkg-wrapper.sh.in new file mode 100644 index 0000000..70cda93 --- /dev/null +++ b/scripts/makepkg-wrapper.sh.in @@ -0,0 +1,23 @@ +#!/bin/bash +# +# makepkg - a wrapper for running the real makepkg in the source tree +# +# Copyright (c) 2012 Pacman Development Team <pacman-dev(a)archlinux.org> +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see <http://www.gnu.org/licenses/>. +# + +DIR=@PWD@ + +LIBRARY=$DIR/libmakepkg $DIR/.lib/makepkg "$@" -- 1.7.10.2

1 0

[pacman-dev] [PATCH] Allow querying directory ownership
by andrew.gregory.8＠gmail.com 25 May '12

25 May '12

From: Andrew Gregory <andrew.gregory.8(a)gmail.com> The restriction of not checking the ownership of a directory is unnecessary given that all the package filelists contain this information. Additional Changes: * mbasename/mdirname behave more like their posix counterparts * check that files are in root before looking for an owner * only compare package files of the same type as the target file * add lrealpath, like realpath but for symlinks * resolve root and make sure it ends with '/' * removed resolve_path() Signed-off-by: Andrew Gregory <andrew.gregory.8(a)gmail.com> --- This is an alternative to Allan's recent patch. This pretty thoroughly rewrites query_fileowner() and attempts to simplify the process in addition to allowing querying directories. I mentioned before that my version assumed that package file paths didn't contain symlinks; that assumption has been removed. My public repo is available at: https://bitbucket.org/andrewgregory/pacman/changesets/tip/dir_own_final It includes a perl script in src/pacan used to test this patch against various file/directory/symlink situations. src/pacman/query.c | 185 ++++++++++++++++++++++++++++------------------------ src/pacman/util.c | 128 ++++++++++++++++++++++++++++-------- src/pacman/util.h | 4 +- 3 files changed, 205 insertions(+), 112 deletions(-) diff --git a/src/pacman/query.c b/src/pacman/query.c index a1cc1cf..6ef0744 100644 --- a/src/pacman/query.c +++ b/src/pacman/query.c @@ -36,23 +36,6 @@ #include "conf.h" #include "util.h" -static char *resolve_path(const char *file) -{ - char *str = NULL; - - str = calloc(PATH_MAX, sizeof(char)); - if(!str) { - return NULL; - } - - if(!realpath(file, str)) { - free(str); - return NULL; - } - - return str; -} - /* check if filename exists in PATH */ static int search_path(char **filename, struct stat *bufptr) { @@ -107,134 +90,166 @@ static void print_query_fileowner(const char *filename, alpm_pkg_t *info) static int query_fileowner(alpm_list_t *targets) { - int ret = 0; - char path[PATH_MAX]; - const char *root; - size_t rootlen; - alpm_list_t *t; - alpm_db_t *db_local; - - /* This code is here for safety only */ if(targets == NULL) { pm_printf(ALPM_LOG_ERROR, _("no file was specified for --owns\n")); return 1; } - /* Set up our root path buffer. We only need to copy the location of root in - * once, then we can just overwrite whatever file was there on the previous - * iteration. */ - root = alpm_option_get_root(config->handle); + struct stat buf; + char root[PATH_MAX]; + size_t rootlen; + char path[PATH_MAX]; /* absolute real path of the target */ + char ppath[PATH_MAX]; /* absolute real path of the package file */ + int ret = 0; + + /* make sure root is a real path */ + if(realpath(alpm_option_get_root(config->handle), root) == NULL) { + pm_printf(ALPM_LOG_ERROR, + _("cannot determine real path for '%s': %s\n"), + alpm_option_get_root(config->handle), strerror(errno)); + return 1; + }; rootlen = strlen(root); - if(rootlen + 1 > PATH_MAX) { - /* we are in trouble here */ + /* make sure root ends with '/' */ + if(root[rootlen - 1] != '/' && rootlen < PATH_MAX) { + root[rootlen] = '/'; + rootlen++; + root[rootlen] = '\0'; + } + /* make sure we actually have room to append the package files */ + if(rootlen >= PATH_MAX) { pm_printf(ALPM_LOG_ERROR, _("path too long: %s%s\n"), root, ""); return 1; } - strcpy(path, root); - db_local = alpm_get_localdb(config->handle); + alpm_db_t *db_local = alpm_get_localdb(config->handle); + alpm_list_t *packages = alpm_db_get_pkgcache(db_local); + /* loop through targets */ + alpm_list_t *t; for(t = targets; t; t = alpm_list_next(t)) { - char *filename, *dname, *rpath; - const char *bname; - struct stat buf; - alpm_list_t *i; + char *filename = strdup(t->data); + char *bname; int found = 0; + int is_dir = 0; - filename = strdup(t->data); - + /* read target */ if(lstat(filename, &buf) == -1) { - /* if it is not a path but a program name, then check in PATH */ if(strchr(filename, '/') == NULL) { + /* if it is not a path but a program name, then check in PATH */ if(search_path(&filename, &buf) == -1) { - pm_printf(ALPM_LOG_ERROR, _("failed to find '%s' in PATH: %s\n"), + pm_printf(ALPM_LOG_ERROR, + _("failed to find '%s' in PATH: %s\n"), filename, strerror(errno)); ret++; free(filename); continue; } } else { + /* filename is a path we can't read so bail */ + pm_printf(ALPM_LOG_ERROR, _("failed to read file '%s': %s\n"), + filename, strerror(errno)); + ret++; + free(filename); + continue; + } + } + if((is_dir = S_ISDIR(buf.st_mode))){ + /* make sure filename doesn't end with '/' because + * lstat('/var/mail') is not the same as lstat("/var/mail/") */ + size_t flast = strlen(filename) - 1; + while(filename[flast] == '/' && flast > 0) { + filename[flast] = '\0'; + flast--; + } + if(lstat(filename, &buf) == -1) { pm_printf(ALPM_LOG_ERROR, _("failed to read file '%s': %s\n"), filename, strerror(errno)); ret++; free(filename); continue; } + /* check if filename is actually a symlink */ + is_dir = S_ISDIR(buf.st_mode); } - if(S_ISDIR(buf.st_mode)) { + /* convert filename to its real path */ + if(lrealpath(filename, path) == NULL) { pm_printf(ALPM_LOG_ERROR, - _("cannot determine ownership of directory '%s'\n"), filename); + _("cannot determine real path for '%s': %s\n"), + filename, strerror(errno)); ret++; free(filename); continue; } - bname = mbasename(filename); - dname = mdirname(filename); - /* for files in '/', there is no directory name to match */ - if(strcmp(dname, "") == 0) { - rpath = NULL; - } else { - rpath = resolve_path(dname); - - if(!rpath) { - pm_printf(ALPM_LOG_ERROR, _("cannot determine real path for '%s': %s\n"), - filename, strerror(errno)); - free(filename); - free(dname); - free(rpath); - ret++; - continue; - } + /* make sure target is inside root */ + if( strlen(path) <= rootlen || strncmp(path, root, rootlen) != 0) { + pm_printf(ALPM_LOG_ERROR, + _("cannot determine ownership of file outside of root\n")); + ret++; + free(filename); + continue; } - free(dname); - for(i = alpm_db_get_pkgcache(db_local); i && !found; i = alpm_list_next(i)) { + bname = mbasename(path); + + /* loop through installed packages */ + alpm_list_t *i; + for(i = packages; i && (!found || is_dir); i = alpm_list_next(i)) { alpm_pkg_t *info = i->data; alpm_filelist_t *filelist = alpm_pkg_get_files(info); - size_t j; - for(j = 0; j < filelist->count; j++) { + /* loop through package files */ + size_t j; + for(j = 0; j < filelist->count && (!found || is_dir); j++) { const alpm_file_t *file = filelist->files + j; - char *ppath, *pdname; - const char *pkgfile = file->name; + size_t flen = strlen(file->name); - /* avoid the costly resolve_path usage if the basenames don't match */ - if(strcmp(mbasename(pkgfile), bname) != 0) { + if(rootlen + flen >= PATH_MAX) { + pm_printf(ALPM_LOG_ERROR, _("path too long: %s%s\n"), + root, file->name); + ret++; continue; - } + }; - /* for files in '/', there is no directory name to match */ - if(!rpath) { - print_query_fileowner(filename, info); - found = 1; + /* continue if target and file are not the same type */ + if(!is_dir == (file->name[flen - 1] == '/')) { continue; } - if(rootlen + 1 + strlen(pkgfile) > PATH_MAX) { - pm_printf(ALPM_LOG_ERROR, _("path too long: %s%s\n"), root, pkgfile); + /* check basenames before we bother resolving the path */ + char *pbname = mbasename(file->name); + if(pbname && strcmp(pbname, bname) != 0) { + free(pbname); + continue; } - /* concatenate our file and the root path */ - strcpy(path + rootlen, pkgfile); + free(pbname); - pdname = mdirname(path); - ppath = resolve_path(pdname); - free(pdname); + /* resolve and compare the path */ + strcpy(root + rootlen, file->name); + if(lrealpath(root, ppath) == NULL) { + pm_printf(ALPM_LOG_ERROR, + _("cannot determine real path for '%s': %s\n"), + file->name, strerror(errno)); + ret++; + continue; + }; - if(ppath && strcmp(ppath, rpath) == 0) { - print_query_fileowner(filename, info); + if(strcmp(ppath, path) == 0) { + print_query_fileowner(path, info); found = 1; } - free(ppath); } } + if(!found) { - pm_printf(ALPM_LOG_ERROR, _("No package owns %s\n"), filename); + pm_printf(ALPM_LOG_ERROR, _("No package owns %s\n"), path); ret++; } + + free(bname); free(filename); - free(rpath); } return ret; diff --git a/src/pacman/util.c b/src/pacman/util.c index 7f7f6a7..733da9f 100644 --- a/src/pacman/util.c +++ b/src/pacman/util.c @@ -211,45 +211,121 @@ int rmrf(const char *path) } /** Parse the basename of a program from a path. +* Equivalent to posix basename except \a path is never modified and the +* returned string needs to be freed. +* * @param path path to parse basename from * -* @return everything following the final '/' +* @return final component of \a path */ -const char *mbasename(const char *path) +char *mbasename(const char *path) { - const char *last = strrchr(path, '/'); - if(last) { - return last + 1; - } - return path; + char *tmp = strdup(path); + char *bname = strdup(basename(tmp)); + free(tmp); + return bname; } /** Parse the dirname of a program from a path. -* The path returned should be freed. +* Equivalent to posix dirname except \a path is never modified and the +* returned string needs to be freed. +* * @param path path to parse dirname from * -* @return everything preceding the final '/' +* @return everything preceding the final component of \a path */ char *mdirname(const char *path) { - char *ret, *last; + char *tmp = strdup(path); + char *dname = strdup(dirname(tmp)); + free(tmp); + return dname; +} - /* null or empty path */ - if(path == NULL || path == '\0') { - return strdup("."); +/** Resolve a path to its canonicalized absolute pathname. +* Equivalent to posix realpath except that if \a path points to a symlink the +* parent directory is resolved rather than the symlink itself. +* +* @param path path to resolve +* @param resolved_path string to hold resolved path, will be malloc'd if NULL +* +* @return pointer to resolved_path on success, NULL on error +*/ +char *lrealpath(const char *path, char *resolved_path) +{ + char *bname = NULL; + char *dname = NULL; + int need_free = 0; /* did we calloc resolved_path? */ + + bname = mbasename(path); + if(bname == NULL) { + goto error; + } else if(strcmp(bname, "..") == 0 + || strcmp(bname, ".") == 0 + || strcmp(bname, "/") == 0) { + /* handle a few special cases of bname */ + dname = strdup(path); + bname = NULL; + free(bname); + } else { + dname = mdirname(path); + } + if(dname == NULL) { + goto error; } - ret = strdup(path); - last = strrchr(ret, '/'); + if(resolved_path == NULL) { + resolved_path = calloc(PATH_MAX, sizeof(char)); + if(resolved_path == NULL) { + goto error; + } + need_free = 1; + } - if(last != NULL) { - /* we found a '/', so terminate our string */ - *last = '\0'; - return ret; + if(realpath(dname, resolved_path) == NULL) { + goto error; } - /* no slash found */ - free(ret); - return strdup("."); + + /* add bname back if we have a valid one */ + if(bname) { + size_t rlen = strlen(resolved_path); + + /* error out if resolved_path is too long to append bname */ + if((rlen + strlen(bname) + 2) >= PATH_MAX) { + goto error; + } + + /* append trailing '/' if needed */ + if(resolved_path[rlen - 1] != '/') { + resolved_path[rlen] = '/'; + resolved_path[rlen+1] = '\0'; + rlen++; + } + + strcpy(resolved_path + rlen, bname); + } + + if(bname) { + free(bname); + } + if(dname) { + free(dname); + } + + return resolved_path; + +error: + if(need_free) { + free(resolved_path); + } + if(bname) { + free(bname); + } + if(dname) { + free(dname); + } + + return NULL; } /* output a string, but wrap words properly with a specified indentation @@ -1661,9 +1737,9 @@ int pm_vfprintf(FILE *stream, alpm_loglevel_t level, const char *format, va_list /* A quick and dirty implementation derived from glibc */ static size_t strnlen(const char *s, size_t max) { - register const char *p; - for(p = s; *p && max--; ++p); - return (p - s); + register const char *p; + for(p = s; *p && max--; ++p); + return (p - s); } char *strndup(const char *s, size_t n) @@ -1672,7 +1748,7 @@ char *strndup(const char *s, size_t n) char *new = (char *) malloc(len + 1); if(new == NULL) - return NULL; + return NULL; new[len] = '\0'; return (char *)memcpy(new, s, len); diff --git a/src/pacman/util.h b/src/pacman/util.h index 0dfdc85..b51505a 100644 --- a/src/pacman/util.h +++ b/src/pacman/util.h @@ -23,6 +23,7 @@ #include <stdlib.h> #include <stdarg.h> #include <string.h> +#include <libgen.h> #include <alpm_list.h> @@ -49,8 +50,9 @@ int needs_root(void); int check_syncdbs(size_t need_repos, int check_valid); unsigned short getcols(int fd); int rmrf(const char *path); -const char *mbasename(const char *path); +char *mbasename(const char *path); char *mdirname(const char *path); +char *lrealpath(const char *path, char *resolved_path); void indentprint(const char *str, unsigned short indent, unsigned short cols); size_t strtrim(char *str); char *strreplace(const char *str, const char *needle, const char *replace); -- 1.7.10.2

1 0

[pacman-dev] [PATCH][RFC] packages ignored based on provides w/ needed flag
by Daniel Wallace 23 May '12

23 May '12

for FS#29935 https://bugs.archlinux.org/task/29935 This patch will cause packages like notification-daemon to be ignored if something providing notification-daemon is installed, mostly useful for when installing groups like pacman -Syu gnome. It also causes packages to be ignored based on if the things it provides are already installed, tested on jre7 from aur and then trying to install jre7-openjdk with the --needed flag. This also works with sysv and initscripts, if you have removed them in favor of sysvcompat, pacman -Syu base --needed should ignore those packages Signed-off-by: Daniel Wallace <daniel.wallace(a)gatech.edu> --- lib/libalpm/add.c | 11 ++++++++++- lib/libalpm/package.c | 23 +++++++++++++++++++++++ lib/libalpm/package.h | 2 ++ 3 files changed, 35 insertions(+), 1 deletion(-) diff --git a/lib/libalpm/add.c b/lib/libalpm/add.c index edddc31..6ebd9cf 100644 --- a/lib/libalpm/add.c +++ b/lib/libalpm/add.c @@ -93,7 +93,16 @@ int SYMEXPORT alpm_add_pkg(alpm_handle_t *handle, alpm_pkg_t *pkg) localpkgname, localpkgver, pkgver); } } - + /* find if the package is provided by something else and */ + int provided = _alpm_pkg_is_provided(handle, pkg); + int provisionprovided=_alpm_pkg_provision_provided(handle,pkg->provides); + if(provided==0||provisionprovided==0){ + if(trans->flags & ALPM_TRANS_FLAG_NEEDED){ + _alpm_log(handle, ALPM_LOG_WARNING, _("%s-%s is up to date -- skipping\n"), + pkgname, pkgver); + return 0; + } + } /* add the package to the transaction */ pkg->reason = ALPM_PKG_REASON_EXPLICIT; _alpm_log(handle, ALPM_LOG_DEBUG, "adding package %s-%s to the transaction add list\n", diff --git a/lib/libalpm/package.c b/lib/libalpm/package.c index 46d1473..d346c70 100644 --- a/lib/libalpm/package.c +++ b/lib/libalpm/package.c @@ -646,6 +646,29 @@ int _alpm_pkg_compare_versions(alpm_pkg_t *spkg, alpm_pkg_t *localpkg) return alpm_pkg_vercmp(spkg->version, localpkg->version); } +int _alpm_pkg_is_provided(alpm_handle_t *handle,alpm_pkg_t *pkg) +{ + alpm_db_t *localdb = alpm_get_localdb(handle); + if(alpm_find_satisfier(alpm_db_get_pkgcache(localdb), pkg->name)) { + return 0; + } + return 1; +} +int _alpm_pkg_provision_provided(alpm_handle_t *handle,alpm_list_t *provs) +{ + if(provs==NULL){ + return 1; + } + const alpm_list_t *i; + alpm_db_t *localdb = alpm_get_localdb(handle); + for (i=provs;i;i=i->next){ + if(!(alpm_find_satisfier(alpm_db_get_pkgcache(localdb),(char *)i->data))) { + return 1; + } + } + return 0; +} + /* Helper function for comparing packages */ int _alpm_pkg_cmp(const void *p1, const void *p2) diff --git a/lib/libalpm/package.h b/lib/libalpm/package.h index c473549..b3c56f3 100644 --- a/lib/libalpm/package.h +++ b/lib/libalpm/package.h @@ -141,6 +141,8 @@ alpm_pkg_t *_alpm_pkg_load_internal(alpm_handle_t *handle, int _alpm_pkg_cmp(const void *p1, const void *p2); int _alpm_pkg_compare_versions(alpm_pkg_t *local_pkg, alpm_pkg_t *pkg); +int _alpm_pkg_is_provided(alpm_handle_t *handle,alpm_pkg_t *pkg); +int _alpm_pkg_provision_provided(alpm_handle_t *handle,alpm_list_t *provs); alpm_pkg_t *_alpm_pkg_find(alpm_list_t *haystack, const char *needle); int _alpm_pkg_should_ignore(alpm_handle_t *handle, alpm_pkg_t *pkg); -- 1.7.10.2

2 1

[pacman-dev] Purging symlinks
by Jeremy Huntwork 23 May '12

23 May '12

Hi, In current makepkg, file name patterns specified in PURGE_TARGETS will only match files (and not symlinks) due to: find . -type f -name "${pt}" -exec rm -f -- '{}' \; Is this intentional? Thanks, JH

2 4

[pacman-dev] [PATCH] Portability fixes for makepkg
by jhuntwork＠lightcubesolutions.com 23 May '12

23 May '12

From: Jeremy Huntwork <jhuntwork(a)lightcubesolutions.com> Allow makepkg to work correctly when used with find from busybox. Fix handling of cross directory symlinks. Signed-off-by: Jeremy Huntwork <jhuntwork(a)lightcubesolutions.com> --- configure.ac | 5 ++++ scripts/Makefile.am | 1 + scripts/makepkg.sh.in | 51 +++++++++++++++++++++--------------------------- 3 files changed, 28 insertions(+), 29 deletions(-) diff --git a/configure.ac b/configure.ac index 15e93e7..5483ee1 100644 --- a/configure.ac +++ b/configure.ac @@ -287,6 +287,7 @@ GCC_VISIBILITY_CC GCC_GNU89_INLINE_CC # Host-dependant definitions +INODECMD="stat -c '%i %n'" SIZECMD="stat -c %s" SEDINPLACE="sed -i" STRIP_BINARIES="--strip-all" @@ -294,6 +295,7 @@ STRIP_SHARED="--strip-unneeded" STRIP_STATIC="--strip-debug" case "${host_os}" in *bsd*) + INODECMD="stat -f '%i %n'" SIZECMD="stat -f %z" SEDINPLACE="sed -i \"\"" ;; @@ -303,6 +305,7 @@ case "${host_os}" in ;; darwin*) host_os_darwin=yes + INODECMD="/usr/bin/stat -f '%i %n'" SIZECMD="/usr/bin/stat -f %z" SEDINPLACE="/usr/bin/sed -i ''" STRIP_BINARIES="" @@ -314,6 +317,7 @@ esac AM_CONDITIONAL([CYGWIN], test "x$host_os_cygwin" = "xyes") AM_CONDITIONAL([DARWIN], test "x$host_os_darwin" = "xyes") AC_PATH_PROGS([DUPATH], [du], [du], [/usr/bin$PATH_SEPARATOR/bin] ) +AC_SUBST(INODECMD) AC_SUBST(SIZECMD) AC_SUBST(SEDINPLACE) AC_SUBST(STRIP_BINARIES) @@ -487,6 +491,7 @@ ${PACKAGE_NAME}: Architecture : ${CARCH} Host Type : ${CHOST} + File inode command : ${INODECMD} Filesize command : ${SIZECMD} In-place sed command : ${SEDINPLACE} diff --git a/scripts/Makefile.am b/scripts/Makefile.am index ae36624..4747074 100644 --- a/scripts/Makefile.am +++ b/scripts/Makefile.am @@ -49,6 +49,7 @@ edit = sed \ -e 's|@PACKAGE_BUGREPORT[@]|$(PACKAGE_BUGREPORT)|g' \ -e 's|@PACKAGE_NAME[@]|$(PACKAGE_NAME)|g' \ -e 's|@BUILDSCRIPT[@]|$(BUILDSCRIPT)|g' \ + -e "s|@INODECMD[@]|$(INODECMD)|g" \ -e 's|@SIZECMD[@]|$(SIZECMD)|g' \ -e 's|@SEDINPLACE[@]|$(SEDINPLACE)|g' \ -e 's|@DUPATH[@]|$(DUPATH)|g' \ diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index 718b4e9..b0918ae 100644 --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in @@ -1057,37 +1057,30 @@ tidy_install() { if check_option "zipman" "y" && [[ -n ${MAN_DIRS[*]} ]]; then msg2 "$(gettext "Compressing man and info pages...")" - local manpage ext file link hardlinks hl - find ${MAN_DIRS[@]} -type f 2>/dev/null | - while read manpage ; do - ext="${manpage##*.}" - file="${manpage##*/}" - if [[ $ext != gz && $ext != bz2 ]]; then - # update symlinks to this manpage - find ${MAN_DIRS[@]} -lname "$file" 2>/dev/null | - while read link ; do + local file files inode link + while read -rd ' ' inode; do + read file + find ${MAN_DIRS[@]} -type l 2>/dev/null | + while read link ; do + if [[ "${file}" -ef "${link}" ]] ; then rm -f "$link" "${link}.gz" - ln -s -- "${file}.gz" "${link}.gz" - done - - # check file still exists (potentially already compressed due to hardlink) - if [[ -f ${manpage} ]]; then - # find hard links and remove them - # the '|| true' part keeps the script from bailing on the EOF returned - # by read at the end of the find output - mapfile -t hardlinks < \ - <(find ${MAN_DIRS[@]} ! -name "$file" -samefile "$manpage" 2>/dev/null) - rm -f "${hardlinks[@]}" - # compress the original - gzip -9 "$manpage" - # recreate hard links removed earlier - for hl in "${hardlinks[@]}"; do - ln "${manpage}.gz" "${hl}.gz" - chmod 644 ${hl}.gz - done + if [[ ${file%/*} = ${link%/*} ]]; then + ln -s -- "${file##*/}.gz" "${link}.gz" + else + ln -s -- "/${file}.gz" "${link}.gz" + fi fi + done + if [[ -z ${files[$inode]} ]]; then + files[$inode]=$file + gzip -9 -f "$file" + else + rm -f "$file" + ln "${files[$inode]}.gz" "${file}.gz" + chmod 644 "${file}.gz" fi - done + done < <(find ${MAN_DIRS[@]} -type f \! -name "*.gz" \! -name "*.bz2" \ + -exec @INODECMD@ '{}' + 2>/dev/null) fi if check_option "strip" "y"; then @@ -1115,7 +1108,7 @@ tidy_install() { if check_option "emptydirs" "n"; then msg2 "$(gettext "Removing empty directories...")" - find . -depth -type d -empty -delete + find . -depth -type d -exec rmdir '{}' + 2>/dev/null fi if check_option "upx" "y"; then -- 1.7.1

1 0

[pacman-dev] [PATCH] Portability fixes for makepkg
by jhuntwork＠lightcubesolutions.com 23 May '12

23 May '12

From: Jeremy Huntwork <jhuntwork(a)lightcubesolutions.com> Allow makepkg to work correctly when used with find from busybox. Update to last submitted patch to use basename value of file path for symlinks. Signed-off-by: Jeremy Huntwork <jhuntwork(a)lightcubesolutions.com> --- configure.ac | 5 +++++ scripts/Makefile.am | 1 + scripts/makepkg.sh.in | 47 ++++++++++++++++++----------------------------- 3 files changed, 24 insertions(+), 29 deletions(-) diff --git a/configure.ac b/configure.ac index 15e93e7..5483ee1 100644 --- a/configure.ac +++ b/configure.ac @@ -287,6 +287,7 @@ GCC_VISIBILITY_CC GCC_GNU89_INLINE_CC # Host-dependant definitions +INODECMD="stat -c '%i %n'" SIZECMD="stat -c %s" SEDINPLACE="sed -i" STRIP_BINARIES="--strip-all" @@ -294,6 +295,7 @@ STRIP_SHARED="--strip-unneeded" STRIP_STATIC="--strip-debug" case "${host_os}" in *bsd*) + INODECMD="stat -f '%i %n'" SIZECMD="stat -f %z" SEDINPLACE="sed -i \"\"" ;; @@ -303,6 +305,7 @@ case "${host_os}" in ;; darwin*) host_os_darwin=yes + INODECMD="/usr/bin/stat -f '%i %n'" SIZECMD="/usr/bin/stat -f %z" SEDINPLACE="/usr/bin/sed -i ''" STRIP_BINARIES="" @@ -314,6 +317,7 @@ esac AM_CONDITIONAL([CYGWIN], test "x$host_os_cygwin" = "xyes") AM_CONDITIONAL([DARWIN], test "x$host_os_darwin" = "xyes") AC_PATH_PROGS([DUPATH], [du], [du], [/usr/bin$PATH_SEPARATOR/bin] ) +AC_SUBST(INODECMD) AC_SUBST(SIZECMD) AC_SUBST(SEDINPLACE) AC_SUBST(STRIP_BINARIES) @@ -487,6 +491,7 @@ ${PACKAGE_NAME}: Architecture : ${CARCH} Host Type : ${CHOST} + File inode command : ${INODECMD} Filesize command : ${SIZECMD} In-place sed command : ${SEDINPLACE} diff --git a/scripts/Makefile.am b/scripts/Makefile.am index ae36624..4747074 100644 --- a/scripts/Makefile.am +++ b/scripts/Makefile.am @@ -49,6 +49,7 @@ edit = sed \ -e 's|@PACKAGE_BUGREPORT[@]|$(PACKAGE_BUGREPORT)|g' \ -e 's|@PACKAGE_NAME[@]|$(PACKAGE_NAME)|g' \ -e 's|@BUILDSCRIPT[@]|$(BUILDSCRIPT)|g' \ + -e "s|@INODECMD[@]|$(INODECMD)|g" \ -e 's|@SIZECMD[@]|$(SIZECMD)|g' \ -e 's|@SEDINPLACE[@]|$(SEDINPLACE)|g' \ -e 's|@DUPATH[@]|$(DUPATH)|g' \ diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index 718b4e9..a73fcf3 100644 --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in @@ -1057,37 +1057,26 @@ tidy_install() { if check_option "zipman" "y" && [[ -n ${MAN_DIRS[*]} ]]; then msg2 "$(gettext "Compressing man and info pages...")" - local manpage ext file link hardlinks hl - find ${MAN_DIRS[@]} -type f 2>/dev/null | - while read manpage ; do - ext="${manpage##*.}" - file="${manpage##*/}" - if [[ $ext != gz && $ext != bz2 ]]; then - # update symlinks to this manpage - find ${MAN_DIRS[@]} -lname "$file" 2>/dev/null | - while read link ; do + local file files inode link + while read -rd ' ' inode; do + read file + find ${MAN_DIRS[@]} -type l 2>/dev/null | + while read link ; do + if [[ "${file}" -ef "${link}" ]] ; then rm -f "$link" "${link}.gz" - ln -s -- "${file}.gz" "${link}.gz" - done - - # check file still exists (potentially already compressed due to hardlink) - if [[ -f ${manpage} ]]; then - # find hard links and remove them - # the '|| true' part keeps the script from bailing on the EOF returned - # by read at the end of the find output - mapfile -t hardlinks < \ - <(find ${MAN_DIRS[@]} ! -name "$file" -samefile "$manpage" 2>/dev/null) - rm -f "${hardlinks[@]}" - # compress the original - gzip -9 "$manpage" - # recreate hard links removed earlier - for hl in "${hardlinks[@]}"; do - ln "${manpage}.gz" "${hl}.gz" - chmod 644 ${hl}.gz - done + ln -s -- "${file##*/}.gz" "${link}.gz" fi + done + if [[ -z ${files[$inode]} ]]; then + files[$inode]=$file + gzip -9 -f "$file" + else + rm -f "$file" + ln "${files[$inode]}.gz" "${file}.gz" + chmod 644 "${file}.gz" fi - done + done < <(find ${MAN_DIRS[@]} -type f \! -name "*.gz" \! -name "*.bz2" \ + -exec @INODECMD@ '{}' + 2>/dev/null) fi if check_option "strip" "y"; then @@ -1115,7 +1104,7 @@ tidy_install() { if check_option "emptydirs" "n"; then msg2 "$(gettext "Removing empty directories...")" - find . -depth -type d -empty -delete + find . -mindepth 1 -depth -type d -exec rmdir '{}' + 2>/dev/null fi if check_option "upx" "y"; then -- 1.7.1

3 4

[pacman-dev] [PATCH v3] Allow querying directory ownership
by Allan McRae 22 May '12

22 May '12

The restriction of not checking the ownership of a directory is unnecessary given that all the package filelists contain this information. Remove this restriction, with the expectation that you might get multiple packages returned for a given directory. Additionally attempt to minimise the number of files getting through to the slow realpath call. This combines ideas from two patches that have been around for a long time. Original-work-by: Andrew Gregory <andrew.gregory.8(a)gmail.com> Original-work-by: Dan McGee <dan(a)archlinux.org> Signed-off-by: Allan McRae <allan(a)archlinux.org> --- v3 - Now with less segfaults on the rather silly "pacman -Qo /"... src/pacman/query.c | 70 +++++++++++++++++++++++++++++++++++++++++----------- 1 file changed, 55 insertions(+), 15 deletions(-) diff --git a/src/pacman/query.c b/src/pacman/query.c index 07509fa..67dd11c 100644 --- a/src/pacman/query.c +++ b/src/pacman/query.c @@ -113,6 +113,7 @@ static int query_fileowner(alpm_list_t *targets) size_t rootlen; alpm_list_t *t; alpm_db_t *db_local; + alpm_list_t *packages; /* This code is here for safety only */ if(targets == NULL) { @@ -133,13 +134,14 @@ static int query_fileowner(alpm_list_t *targets) strcpy(path, root); db_local = alpm_get_localdb(config->handle); + packages = alpm_db_get_pkgcache(db_local); for(t = targets; t; t = alpm_list_next(t)) { char *filename, *dname, *rpath; - const char *bname; + const char *bname, *rpath_bname = NULL; struct stat buf; alpm_list_t *i; - int found = 0; + size_t found = 0, isdir, bname_len, rpath_len = 0, rpath_bname_len = 0; filename = strdup(t->data); @@ -162,16 +164,19 @@ static int query_fileowner(alpm_list_t *targets) } } - if(S_ISDIR(buf.st_mode)) { - pm_printf(ALPM_LOG_ERROR, - _("cannot determine ownership of directory '%s'\n"), filename); - ret++; - free(filename); - continue; + /* make sure directories have a trailing '/' */ + if((isdir = S_ISDIR(buf.st_mode))) { + size_t len = strlen(filename); + if(filename[len-1] != '/') { + filename = realloc(filename, sizeof(char) * (len + 2)); + strcat(filename, "/"); + } } bname = mbasename(filename); + bname_len = strlen(bname); dname = mdirname(filename); + /* for files in '/', there is no directory name to match */ if(strcmp(dname, "") == 0) { rpath = NULL; @@ -181,16 +186,26 @@ static int query_fileowner(alpm_list_t *targets) if(!rpath) { pm_printf(ALPM_LOG_ERROR, _("cannot determine real path for '%s': %s\n"), filename, strerror(errno)); - free(filename); free(dname); - free(rpath); ret++; - continue; + goto cleanup; } } free(dname); - for(i = alpm_db_get_pkgcache(db_local); i && !found; i = alpm_list_next(i)) { + if(isdir) { + if(!rpath) { + pm_printf(ALPM_LOG_ERROR, _("cannot determine ownership of root directory\n")); + ret++; + goto cleanup; + } else { + rpath_len = strlen(rpath); + rpath_bname = mbasename(rpath); + rpath_bname_len = strlen(rpath_bname); + } + } + + for(i = packages; i && (!found || isdir); i = alpm_list_next(i)) { alpm_pkg_t *info = i->data; alpm_filelist_t *filelist = alpm_pkg_get_files(info); size_t j; @@ -199,17 +214,40 @@ static int query_fileowner(alpm_list_t *targets) const alpm_file_t *file = filelist->files + j; char *ppath, *pdname; const char *pkgfile = file->name; + size_t pkgfile_len = strlen(pkgfile); - /* avoid the costly resolve_path usage if the basenames don't match */ - if(strcmp(mbasename(pkgfile), bname) != 0) { + /* avoid the costly resolve_path usage if the basenames don't match; + * we can also cheat by comparing the final characters first and avoid + * a full string comparison */ + if(!isdir && (pkgfile[pkgfile_len - 1] != bname[bname_len - 1] || + strcmp(mbasename(pkgfile), bname) != 0)) { continue; } + if(isdir) { + /* check the filelist entry is a directory using its + * trailing '/' and compare final characters of directory + * names. */ + if(pkgfile[pkgfile_len - 1] != '/' || + pkgfile[pkgfile_len - 2] != rpath[rpath_len - 1]) { + continue; + } + + /* compare final directory portion */ + if(pkgfile_len - 1 < rpath_bname_len || + (pkgfile_len - 2 >= rpath_bname_len && + pkgfile[pkgfile_len - 2 - rpath_bname_len] != '/') || + strncmp(pkgfile + pkgfile_len - 1 - rpath_bname_len, + rpath_bname, rpath_bname_len)) { + continue; + } + } + /* for files in '/', there is no directory name to match */ if(!rpath) { print_query_fileowner(filename, info); found = 1; - continue; + break; } if(rootlen + 1 + strlen(pkgfile) > PATH_MAX) { @@ -233,6 +271,8 @@ static int query_fileowner(alpm_list_t *targets) pm_printf(ALPM_LOG_ERROR, _("No package owns %s\n"), filename); ret++; } + +cleanup: free(filename); free(rpath); } -- 1.7.10.2

2 1

[pacman-dev] [PATCH] Allow querying directory ownership
by Allan McRae 22 May '12

22 May '12

The restriction of not checking the ownership of a directory is unnecessary given that all the package filelists contain this information. Remove this restriction, with the expectation that you might get multiple packages returned for a given directory. Additionally attempt to minimise the number of files getting through to the slow realpath call. This combines ideas from two patches that have been around for a long time. Original-work-by: Andrew Gregory <andrew.gregory.8(a)gmail.com> Original-work-by: Dan McGee <dan(a)archlinux.org> Signed-off-by: Allan McRae <allan(a)archlinux.org> --- src/pacman/query.c | 58 +++++++++++++++++++++++++++++++++++++++++----------- 1 file changed, 46 insertions(+), 12 deletions(-) diff --git a/src/pacman/query.c b/src/pacman/query.c index 07509fa..cf14fab 100644 --- a/src/pacman/query.c +++ b/src/pacman/query.c @@ -113,6 +113,7 @@ static int query_fileowner(alpm_list_t *targets) size_t rootlen; alpm_list_t *t; alpm_db_t *db_local; + alpm_list_t *packages; /* This code is here for safety only */ if(targets == NULL) { @@ -133,13 +134,14 @@ static int query_fileowner(alpm_list_t *targets) strcpy(path, root); db_local = alpm_get_localdb(config->handle); + packages = alpm_db_get_pkgcache(db_local); for(t = targets; t; t = alpm_list_next(t)) { char *filename, *dname, *rpath; - const char *bname; + const char *bname, *rpath_bname = NULL; struct stat buf; alpm_list_t *i; - int found = 0; + size_t found = 0, isdir, bname_len, rpath_len, rpath_bname_len = 0; filename = strdup(t->data); @@ -162,16 +164,19 @@ static int query_fileowner(alpm_list_t *targets) } } - if(S_ISDIR(buf.st_mode)) { - pm_printf(ALPM_LOG_ERROR, - _("cannot determine ownership of directory '%s'\n"), filename); - ret++; - free(filename); - continue; + /* make sure directories have a trailing '/' */ + if((isdir = S_ISDIR(buf.st_mode))) { + size_t len = strlen(filename); + if(filename[len-1] != '/') { + filename = realloc(filename, sizeof(char) * (len + 2)); + strcat(filename, "/"); + } } bname = mbasename(filename); + bname_len = strlen(bname); dname = mdirname(filename); + /* for files in '/', there is no directory name to match */ if(strcmp(dname, "") == 0) { rpath = NULL; @@ -189,8 +194,14 @@ static int query_fileowner(alpm_list_t *targets) } } free(dname); + rpath_len = strlen(rpath); - for(i = alpm_db_get_pkgcache(db_local); i && !found; i = alpm_list_next(i)) { + if(isdir) { + rpath_bname = mbasename(rpath); + rpath_bname_len = strlen(rpath_bname); + } + + for(i = packages; i && (!found || isdir); i = alpm_list_next(i)) { alpm_pkg_t *info = i->data; alpm_filelist_t *filelist = alpm_pkg_get_files(info); size_t j; @@ -199,17 +210,40 @@ static int query_fileowner(alpm_list_t *targets) const alpm_file_t *file = filelist->files + j; char *ppath, *pdname; const char *pkgfile = file->name; + size_t pkgfile_len = strlen(pkgfile); - /* avoid the costly resolve_path usage if the basenames don't match */ - if(strcmp(mbasename(pkgfile), bname) != 0) { + /* avoid the costly resolve_path usage if the basenames don't match; + * we can also cheat by comparing the final characters first and avoid + * a full string comparison */ + if(!isdir && (pkgfile[pkgfile_len - 1] != bname[bname_len - 1] || + strcmp(mbasename(pkgfile), bname) != 0)) { continue; } + if(isdir) { + /* check the filelist entry is a directory using its + * trailing '/' and compare final characters of directory + * names. */ + if(pkgfile[pkgfile_len - 1] != '/' || + pkgfile[pkgfile_len - 2] != rpath[rpath_len - 1]) { + continue; + } + + /* compare final directory portion */ + if(pkgfile_len - 1 < rpath_bname_len || + (pkgfile_len - 2 >= rpath_bname_len && + pkgfile[pkgfile_len - 2 - rpath_bname_len] != '/') || + strncmp(pkgfile + pkgfile_len - 1 - rpath_bname_len, + rpath_bname, rpath_bname_len)) { + continue; + } + } + /* for files in '/', there is no directory name to match */ if(!rpath) { print_query_fileowner(filename, info); found = 1; - continue; + break; } if(rootlen + 1 + strlen(pkgfile) > PATH_MAX) { -- 1.7.10.2

2 3

[pacman-dev] [PATCH] Allow querying directory ownership
by Allan McRae 21 May '12

21 May '12

The restriction of not checking the ownership of a directory is unnecessary given that all the package filelists contain this information. Remove this restriction, with the expectation that you might get multiple packages returned for a given directory. Additionally attempt to minimise the number of files getting through to the slow realpath call. This combines ideas from two patches that have been around for a long time. Original-work-by: Andrew Gregory <andrew.gregory.8(a)gmail.com> Original-work-by: Dan McGee <dan(a)archlinux.org> Signed-off-by: Allan McRae <allan(a)archlinux.org> --- Not having this feature is beginning to annoy me! Hopefully I have captured the important bits of both patches... src/pacman/query.c | 38 +++++++++++++++++++++++++++----------- 1 file changed, 27 insertions(+), 11 deletions(-) diff --git a/src/pacman/query.c b/src/pacman/query.c index 464efbf..beaf76c 100644 --- a/src/pacman/query.c +++ b/src/pacman/query.c @@ -113,6 +113,7 @@ static int query_fileowner(alpm_list_t *targets) size_t rootlen; alpm_list_t *t; alpm_db_t *db_local; + alpm_list_t *packages; /* This code is here for safety only */ if(targets == NULL) { @@ -133,13 +134,14 @@ static int query_fileowner(alpm_list_t *targets) strcpy(path, root); db_local = alpm_get_localdb(config->handle); + packages = alpm_db_get_pkgcache(db_local); for(t = targets; t; t = alpm_list_next(t)) { char *filename, *dname, *rpath; const char *bname; struct stat buf; alpm_list_t *i; - int found = 0; + size_t found = 0, isdir, bname_len, dname_len; filename = strdup(t->data); @@ -162,16 +164,20 @@ static int query_fileowner(alpm_list_t *targets) } } - if(S_ISDIR(buf.st_mode)) { - pm_printf(ALPM_LOG_ERROR, - _("cannot determine ownership of directory '%s'\n"), filename); - ret++; - free(filename); - continue; + /* make sure directories have a trailing '/' */ + if((isdir = S_ISDIR(buf.st_mode))) { + size_t len = strlen(filename); + if(filename[len-1] != '/') { + filename = realloc(filename, sizeof(char) * (len + 2)); + strcat(filename, "/"); + } } bname = mbasename(filename); + bname_len = strlen(bname); dname = mdirname(filename); + dname_len = strlen(dname); + /* for files in '/', there is no directory name to match */ if(strcmp(dname, "") == 0) { rpath = NULL; @@ -190,7 +196,7 @@ static int query_fileowner(alpm_list_t *targets) } free(dname); - for(i = alpm_db_get_pkgcache(db_local); i && !found; i = alpm_list_next(i)) { + for(i = packages; i && (!found || isdir); i = alpm_list_next(i)) { alpm_pkg_t *info = i->data; alpm_filelist_t *filelist = alpm_pkg_get_files(info); size_t j; @@ -199,17 +205,27 @@ static int query_fileowner(alpm_list_t *targets) const alpm_file_t *file = filelist->files + j; char *ppath, *pdname; const char *pkgfile = file->name; + size_t pkgfile_len = strlen(pkgfile); - /* avoid the costly resolve_path usage if the basenames don't match */ - if(strcmp(mbasename(pkgfile), bname) != 0) { + /* avoid the costly resolve_path usage if the basenames don't match; + * we can also cheat by comparing the final characters first and avoid + * a full string comparison */ + if(!isdir && (pkgfile[pkgfile_len - 1] != bname[bname_len - 1] || + strcmp(mbasename(pkgfile), bname) != 0)) { continue; + } else if(isdir) { + /* database path needs trailing slash */ + if(pkgfile[pkgfile_len - 1] != '/' && + pkgfile[pkgfile_len - 2] != dname[dname_len - 2]) { + continue; + } } /* for files in '/', there is no directory name to match */ if(!rpath) { print_query_fileowner(filename, info); found = 1; - continue; + break; } if(rootlen + 1 + strlen(pkgfile) > PATH_MAX) { -- 1.7.10.2

1 1

[pacman-dev] [PATCH] libalpm/remove.c - add doxygen
by andrew.gregory.8＠gmail.com 21 May '12

21 May '12

From: Andrew Gregory <andrew.gregory.8(a)gmail.com> Signed-off-by: Andrew Gregory <andrew.gregory.8(a)gmail.com> --- lib/libalpm/remove.c | 100 +++++++++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 95 insertions(+), 5 deletions(-) diff --git a/lib/libalpm/remove.c b/lib/libalpm/remove.c index 469ce9b..dfbad00 100644 --- a/lib/libalpm/remove.c +++ b/lib/libalpm/remove.c @@ -43,6 +43,15 @@ #include "handle.h" #include "conflict.h" +/** + * @brief Add a package removal action to the transaction. + * + * @param handle the context handle + * @param pkg the package to uninstall + * + * @return 0: success + * -1: error (pm_errno is set accordingly) + */ int SYMEXPORT alpm_remove_pkg(alpm_handle_t *handle, alpm_pkg_t *pkg) { const char *pkgname; @@ -73,6 +82,15 @@ int SYMEXPORT alpm_remove_pkg(alpm_handle_t *handle, alpm_pkg_t *pkg) return 0; } +/** + * @brief Add dependencies to the removal transaction for cascading. + * + * @param handle the context handle + * @param lp TODO + * + * @return 0: on success + * -1: on error + */ static int remove_prepare_cascade(alpm_handle_t *handle, alpm_list_t *lp) { alpm_trans_t *trans = handle->trans; @@ -105,6 +123,12 @@ static int remove_prepare_cascade(alpm_handle_t *handle, alpm_list_t *lp) return 0; } +/** + * @brief Remove needed packages from the removal transaction. + * + * @param handle the context handle + * @param lp TODO + */ static void remove_prepare_keep_needed(alpm_handle_t *handle, alpm_list_t *lp) { alpm_trans_t *trans = handle->trans; @@ -135,13 +159,18 @@ static void remove_prepare_keep_needed(alpm_handle_t *handle, alpm_list_t *lp) } } -/** Transaction preparation for remove actions. +/** + * @brief Transaction preparation for remove actions. + * * This functions takes a pointer to a alpm_list_t which will be * filled with a list of alpm_depmissing_t* objects representing * the packages blocking the transaction. + * * @param handle the context handle * @param data a pointer to an alpm_list_t* to fill - * @return 0 on success, -1 on error + * + * @return 0: on success + * -1: on error */ int _alpm_remove_prepare(alpm_handle_t *handle, alpm_list_t **data) { @@ -209,6 +238,16 @@ int _alpm_remove_prepare(alpm_handle_t *handle, alpm_list_t **data) return 0; } +/** + * @brief Check if alpm can delete a file. + * + * @param handle the context handle + * @param file file to be removed + * @param skip_remove list of files that will not be removed + * + * @return 1: the file can be deleted + * 0: the file cannot be deleted + */ static int can_remove_file(alpm_handle_t *handle, const alpm_file_t *file, alpm_list_t *skip_remove) { @@ -235,8 +274,24 @@ static int can_remove_file(alpm_handle_t *handle, const alpm_file_t *file, return 1; } -/* Helper function for iterating through a package's file and deleting them - * Used by _alpm_remove_commit. */ +/** + * @brief Unlink a package file, backing it up if necessary. + * + * @note Helper function for iterating through a package's file and deleting + * them. + * @note Used by _alpm_remove_commit. + * + * @param handle the context handle + * @param oldpkg the package being removed + * @param newpkg the package replacing \a oldpkg + * @param fileobj file to remove + * @param skip_remove list of files that shouldn't be removed + * @param nosave whether files should be backed up + * + * @return 0: success + * -1: error unlinking file + * 1: file was skipped or did not exist + */ static int unlink_file(alpm_handle_t *handle, alpm_pkg_t *oldpkg, alpm_pkg_t *newpkg, const alpm_file_t *fileobj, alpm_list_t *skip_remove, int nosave) @@ -354,6 +409,20 @@ static int unlink_file(alpm_handle_t *handle, alpm_pkg_t *oldpkg, return 0; } +/** + * @brief Remove a package's files, optionally skipping its replacement's + * files. + * + * @param handle the context handle + * @param oldpkg package to remove + * @param newpkg package to replace \a oldpkg (optional) + * @param targ_count current index within the transaction (1-based) + * @param pkg_count the number of packages affected by the transaction + * + * @return 0: success + * -1: some files could not be deleted + * >0: the number of files that were not deleted + */ static int remove_package_files(alpm_handle_t *handle, alpm_pkg_t *oldpkg, alpm_pkg_t *newpkg, size_t targ_count, size_t pkg_count) @@ -433,6 +502,17 @@ static int remove_package_files(alpm_handle_t *handle, return err; } +/** + * @brief Remove a package from the filesystem. + * + * @param handle the context handle + * @param oldpkg package to remove + * @param newpkg package to replace \a oldpkg (optional) + * @param targ_count current index within the transaction (1-based) + * @param pkg_count the number of packages affected by the transaction + * + * @return 0 + */ int _alpm_remove_single_package(alpm_handle_t *handle, alpm_pkg_t *oldpkg, alpm_pkg_t *newpkg, size_t targ_count, size_t pkg_count) @@ -488,9 +568,18 @@ int _alpm_remove_single_package(alpm_handle_t *handle, pkgname); } - return 0; + return 0; /* TODO: useful return values */ } +/** + * @brief Remove packages in the current transaction. + * + * @param handle the context handle + * @param run_ldconfig whether to run ld_config after removing the packages + * + * @return 0: success + * -1: errors occurred while removing files + */ int _alpm_remove_packages(alpm_handle_t *handle, int run_ldconfig) { alpm_list_t *targ; @@ -508,6 +597,7 @@ int _alpm_remove_packages(alpm_handle_t *handle, int run_ldconfig) return ret; } + /* TODO: _alpm_remove_single_package can't actually return -1 */ if(_alpm_remove_single_package(handle, pkg, NULL, targ_count, pkg_count) == -1) { handle->pm_errno = ALPM_ERR_TRANS_ABORT; -- 1.7.10.2

3 5

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v4.0.3-278-g9a76a45
by dan＠archlinux.org 21 May '12

21 May '12

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, master has been updated via 9a76a458b898ea462666491cb74cd95372462da4 (commit) via 81bc390dc1a66841a332948fd906c2257720f37a (commit) via 18e0a972094d7c4bc874ba87ce3be6b2b308a832 (commit) via 7eb6dc2a9c2ecb723b07598b14cd24359004ef9e (commit) via 8abef73ba99d183c191732686b4feab75a644b32 (commit) via c4ea4e017fc35fe8c5057b86bab0a95dac75fc6f (commit) via e533478e02882170653d79b756ae3d5690d076e9 (commit) from 363894e27b07f00d7b1cd9f92214f3f457ac4c48 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9a76a458b898ea462666491cb74cd95372462da4 Author: Allan McRae <allan(a)archlinux.org> Date: Sat May 19 23:09:22 2012 +1000 makepkg: rework libdepends Rewrite the handling of libdepends. The primary advantage are: - Moves functionality from write_pkginfo() to find_libdepends(). - The order of the depends array in the PKGBUILD is kept in the package. - An unneeded libdepends is only a warning and not an error. This allows putting a libdepend on a library that is dlopened. - It is now modular so can be extended to library types other than ELF *.so. - Finding the list of libraries a package depends only occurs when a libdepend is specified in the depends array. Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 81bc390dc1a66841a332948fd906c2257720f37a Author: Allan McRae <allan(a)archlinux.org> Date: Sat May 19 21:00:18 2012 +1000 repo-add: add makedepends information This is useful for tools that automatically rebuild packages and thus require to generate a build order. These entries are skipped by pacman. Signed-off-by: Allan McRae <allan(a)archlinux.org> Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 18e0a972094d7c4bc874ba87ce3be6b2b308a832 Author: Allan McRae <allan(a)archlinux.org> Date: Sat May 19 20:38:12 2012 +1000 makepkg: write makedepends into .PKGINFO Currently there is no way to access the makedepends for a package apart from parsing its PKGBUILD. Put these into the .PKGINFO file with the idea of making them available in the repo dbs so that automated build tools can readily determine build order. Signed-off-by: Allan McRae <allan(a)archlinux.org> Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 7eb6dc2a9c2ecb723b07598b14cd24359004ef9e Author: Allan McRae <allan(a)archlinux.org> Date: Tue May 8 17:05:11 2012 +1000 Define _FORTIFY_SOURCE in CPPFLAGS The -D_FORTIFY_SOURCE=2 define should be in CPPFLAGS and not CFLAGS Signed-off-by: Allan McRae <allan(a)archlinux.org> Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 8abef73ba99d183c191732686b4feab75a644b32 Author: Allan McRae <allan(a)archlinux.org> Date: Thu Dec 22 20:19:18 2011 +1000 makepkg: Add CPPFLAGS support Add CPPFLAGS support in addition to the current CFLAGS and CXXFLAGS. This keeps compiler flags split up in the same logical way done everywhere else. Signed-off-by: Allan McRae <allan(a)archlinux.org> Signed-off-by: Dan McGee <dan(a)archlinux.org> commit c4ea4e017fc35fe8c5057b86bab0a95dac75fc6f Author: Dave Reisner <dreisner(a)archlinux.org> Date: Mon Jan 9 16:01:48 2012 -0500 updpkgsums: add new contrib script This updates checksums in a PKGBUILD in-place. If no sums are found, they are appended to the end. commit e533478e02882170653d79b756ae3d5690d076e9 Author: Dave Reisner <dreisner(a)archlinux.org> Date: Tue May 8 17:23:58 2012 -0400 fix -Wshadow warnings as reported by gcc 4.4.3 Apparently gcc 4.7 has decided that -Wshadow warnings aren't worth reporting anymore even with the flag enabled. These were found on an Ubuntu 10.04 install. Signed-off-by: Dave Reisner <dreisner(a)archlinux.org> Signed-off-by: Dan McGee <dan(a)archlinux.org> ----------------------------------------------------------------------- Summary of changes: contrib/.gitignore | 1 + contrib/Makefile.am | 5 ++- contrib/updpkgsums.sh.in | 93 ++++++++++++++++++++++++++++++++++++++++++ doc/PKGBUILD.5.txt | 8 ++-- doc/makepkg.conf.5.txt | 3 ++ etc/makepkg.conf.in | 1 + lib/libalpm/be_sync.c | 6 +++ lib/libalpm/conflict.c | 4 +- lib/libalpm/deps.c | 16 ++++---- lib/libalpm/dload.c | 20 ++++----- m4/acinclude.m4 | 2 +- scripts/makepkg.sh.in | 102 ++++++++++++++++++++++++++++------------------ scripts/repo-add.sh.in | 23 ++++++----- 13 files changed, 209 insertions(+), 75 deletions(-) create mode 100755 contrib/updpkgsums.sh.in hooks/post-receive -- The official pacman repository

1 0

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v4.0.3-271-g363894e
by dan＠archlinux.org 20 May '12

20 May '12

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, master has been updated via 363894e27b07f00d7b1cd9f92214f3f457ac4c48 (commit) via 9f6a67fee71a63848f958212c1b5a2abd0f735a5 (commit) via fc9002188b588cda1f5362d6d15bd6996c532982 (commit) via 9d3e59e311a863e140699dd2eaec7c0b0bf632f4 (commit) via c2fdc38b78d9b83e783ff2ec3f8c4d53e7f45634 (commit) via ceb23622097bb59ef568fd2565d71148069664c8 (commit) via 5de465d63efbb82da6127ac927ad29b9c8b1b542 (commit) via 233e5f610c409052d4f88382ce5fe97f54fd6e6c (commit) via 26abe8f6004777ba49777eaaec3bc0a47f50fcb2 (commit) via 267158112317b0696c210006fb216ce7dae5cac3 (commit) via 951d23e3ec03fbd7faa3fad910a664365f75b3c4 (commit) via 9e2078b1796dbc8dee201710b4680fb79114cbf3 (commit) via 3f202c780834557557baa4b3503690b629bf4222 (commit) via 1bf05e706b5edac92e9c913a69ca8686c6440f8b (commit) from 9d9c12e4e2dc92dfb6582ea7f79087e382348e71 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 363894e27b07f00d7b1cd9f92214f3f457ac4c48 Author: Dave Reisner <dreisner(a)archlinux.org> Date: Sun May 6 19:53:00 2012 -0400 contrib/pacsysclean: use a standard vim modeline Fix indenting to something more familiar with the rest of the codebase. Signed-off-by: Dave Reisner <dreisner(a)archlinux.org> Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 9f6a67fee71a63848f958212c1b5a2abd0f735a5 Merge: fc90021 5de465d Author: Dan McGee <dan(a)archlinux.org> Date: Sun May 20 17:41:21 2012 -0500 Merge branch 'maint' Conflicts: scripts/pacman-key.sh.in commit fc9002188b588cda1f5362d6d15bd6996c532982 Author: Dave Reisner <dreisner(a)archlinux.org> Date: Sat May 12 22:15:09 2012 -0400 pacman-key: use mapfile over read Signed-off-by: Dave Reisner <dreisner(a)archlinux.org> commit 9d3e59e311a863e140699dd2eaec7c0b0bf632f4 Author: Dave Reisner <dreisner(a)archlinux.org> Date: Sat May 12 22:13:11 2012 -0400 makepkg: use mapfile where plausible With bash4 as a requirement, we can use mapfile when reading command output into an array. mapfile has the advantage of using block buffered I/O rather than line buffered I/O, making it slightly faster for most jobs. Signed-off-by: Dave Reisner <dreisner(a)archlinux.org> commit c2fdc38b78d9b83e783ff2ec3f8c4d53e7f45634 Author: Dave Reisner <dreisner(a)archlinux.org> Date: Sat May 5 13:34:07 2012 -0400 pacman: support group selection delimited by commas We support multiple arguments being comma separated elsewhere, so this seems like a natural extension to support in our multiparse selection code. Signed-off-by: Dave Reisner <dreisner(a)archlinux.org> Signed-off-by: Dan McGee <dan(a)archlinux.org> commit ceb23622097bb59ef568fd2565d71148069664c8 Author: Dave Reisner <dreisner(a)archlinux.org> Date: Wed Apr 25 22:00:00 2012 -0400 pkgdelta: adopt parseopts for option parsing Signed-off-by: Dave Reisner <dreisner(a)archlinux.org> Signed-off-by: Dan McGee <dan(a)archlinux.org> ----------------------------------------------------------------------- Summary of changes: contrib/pacsysclean.sh.in | 62 ++++---- doc/index.txt | 26 +--- doc/pacman.8.txt | 15 +- lib/libalpm/add.c | 5 +- scripts/Makefile.am | 3 +- scripts/makepkg.sh.in | 11 +- scripts/pacman-key.sh.in | 18 +-- scripts/pkgdelta.sh.in | 44 +++--- scripts/po/en_GB.po | 324 ++++++++++++++++++++--------------------- scripts/po/pacman-scripts.pot | 43 ++++-- src/pacman/util.c | 2 +- 11 files changed, 276 insertions(+), 277 deletions(-) hooks/post-receive -- The official pacman repository

1 0

[pacman-dev] [GIT] The official pacman repository branch, maint, updated. v4.0.3-17-g5de465d
by dan＠archlinux.org 20 May '12

20 May '12

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, maint has been updated via 5de465d63efbb82da6127ac927ad29b9c8b1b542 (commit) via 233e5f610c409052d4f88382ce5fe97f54fd6e6c (commit) via 26abe8f6004777ba49777eaaec3bc0a47f50fcb2 (commit) via 267158112317b0696c210006fb216ce7dae5cac3 (commit) via 951d23e3ec03fbd7faa3fad910a664365f75b3c4 (commit) via 9e2078b1796dbc8dee201710b4680fb79114cbf3 (commit) via 3f202c780834557557baa4b3503690b629bf4222 (commit) via 1bf05e706b5edac92e9c913a69ca8686c6440f8b (commit) from 5f71570ec48588bf24bfe786f40b500216084d07 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5de465d63efbb82da6127ac927ad29b9c8b1b542 Author: Dave Reisner <dreisner(a)archlinux.org> Date: Sun May 13 13:05:58 2012 -0400 pacman-key: test for content in keyring files Test for file content (-s) rather than just existance (-f). This fixes a bug that manifests itself in the case of an empty -revoked file. A zero element 'keys' array would be passed to gpg, forcing it to list and, subsequently, revoke all known keys. Bug introduced in d1240f67eab6. Signed-off-by: Dave Reisner <dreisner(a)archlinux.org> Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 233e5f610c409052d4f88382ce5fe97f54fd6e6c Author: Dave Reisner <dreisner(a)archlinux.org> Date: Sun May 6 19:49:43 2012 -0400 contrib/pacsysclean: avoid setting bogus PACMAN_OPTS PACMAN_OPTS would be erroneously set when it was undefined, causing pacsysclean to error out. Signed-off-by: Dave Reisner <dreisner(a)archlinux.org> Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 26abe8f6004777ba49777eaaec3bc0a47f50fcb2 Author: Dan McGee <dan(a)archlinux.org> Date: Sun May 20 11:27:36 2012 -0500 Fix gettext usage in pkgdelta help instructions Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 267158112317b0696c210006fb216ce7dae5cac3 Author: Dan McGee <dan(a)archlinux.org> Date: Sun May 20 11:22:51 2012 -0500 Update pacman-scripts message catalog Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 951d23e3ec03fbd7faa3fad910a664365f75b3c4 Author: Dan McGee <dan(a)archlinux.org> Date: Fri May 18 10:04:27 2012 -0500 docs: remove 'in the wild' section We haven't updated this info in years and it is out of date. Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 9e2078b1796dbc8dee201710b4680fb79114cbf3 Author: Dan McGee <dan(a)archlinux.org> Date: Thu Feb 2 08:29:50 2012 -0600 pacman-key: clarify messages, s/keychain/keyring/ Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 3f202c780834557557baa4b3503690b629bf4222 Author: Dan McGee <dan(a)archlinux.org> Date: Fri May 4 14:37:48 2012 -0500 doc: remove --recursive documentation for non-remove operations This documentation was added in commit 857357f9 so was not caught in the removal of this option in commit 85712814. Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 1bf05e706b5edac92e9c913a69ca8686c6440f8b Author: Dan McGee <dan(a)archlinux.org> Date: Fri May 4 11:41:40 2012 -0500 Ensure pre_upgrade scriptlet gets old package version This was accidentally broken in the refactor done in commit 73139ccb. Fixes FS#29371. Signed-off-by: Dan McGee <dan(a)archlinux.org> ----------------------------------------------------------------------- Summary of changes: contrib/pacsysclean.in | 2 +- doc/index.txt | 26 +--- doc/pacman.8.txt | 7 - lib/libalpm/add.c | 5 +- scripts/pacman-key.sh.in | 16 +- scripts/pkgdelta.sh.in | 6 +- scripts/po/en_GB.po | 324 ++++++++++++++++++++--------------------- scripts/po/pacman-scripts.pot | 43 ++++-- 8 files changed, 208 insertions(+), 221 deletions(-) hooks/post-receive -- The official pacman repository

1 0

[pacman-dev] [PATCH 1/2] makepkg: write makedepends into .PKGINFO
by Allan McRae 20 May '12

20 May '12

Currently there is no way to access the makedepends for a package apart from parsing its PKGBUILD. Put these into the .PKGINFO file with the idea of making them available in the repo dbs so that automated build tools can readily determine build order. Signed-off-by: Allan McRae <allan(a)archlinux.org> --- scripts/makepkg.sh.in | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index 28d9073..8d018c0 100644 --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in @@ -1276,6 +1276,8 @@ write_pkginfo() { fi done + [[ $makedepends ]] && printf "makedepend = %s\n" "${makedepends[@]}" + for it in "${packaging_options[@]}"; do check_option "$it" "y" case $? in -- 1.7.10.2

2 3

[pacman-dev] [PATCH] makepkg: rework libdepends
by Allan McRae 20 May '12

20 May '12

Rewrite the handling of libdepends. The primary advantage are: - Moves functionality from write_pkginfo() to find_libdepends(). - The order of the depends array in the PKGBUILD is kept in the package. - An unneeded libdepends is only a warning and not an error. This allows putting a libdepend on a library that is dlopened. - It is now modular so can be extended to library types other than ELF *.so. - Finding the list of libraries a package depends only occurs when a libdepend is specified in the depends array. Signed-off-by: Allan McRae <allan(a)archlinux.org> --- scripts/makepkg.sh.in | 126 +++++++++++++++++++++++++++++-------------------- 1 file changed, 76 insertions(+), 50 deletions(-) diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index 8d018c0..8930ec4 100644 --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in @@ -1131,32 +1131,76 @@ tidy_install() { } find_libdepends() { - local libdepends - find "$pkgdir" -type f -perm -u+x | while read filename - do - # get architecture of the file; if soarch is empty it's not an ELF binary - soarch=$(LC_ALL=C readelf -h "$filename" 2>/dev/null | sed -n 's/.*Class.*ELF$32\|64$/\1/p') - [ -n "$soarch" ] || continue - # process all libraries needed by the binary - for sofile in $(LC_ALL=C readelf -d "$filename" 2>/dev/null | sed -nr 's/.*Shared library: \[(.*)\].*/\1/p') - do - # extract the library name: libfoo.so - soname="${sofile%.so?(+(.+([0-9])))}".so - # extract the major version: 1 - soversion="${sofile##*\.so\.}" - if in_array "${soname}" ${depends[@]}; then - if ! in_array "${soname}=${soversion}-${soarch}" ${libdepends[@]}; then - # libfoo.so=1-64 - printf "%s" "${soname}=${soversion}-${soarch}" - libdepends+=("${soname}=${soversion}-${soarch}") + local d sodepends; + + sodepends=0; + for d in "${depends[@]}"; do + if [[ $d = *.so ]]; then + sodepends=1; + break; + fi + done + + if (( sodepends == 0 )); then + printf '%s\n' "${depends[@]}" + return; + fi + + local libdeps; + declare -A libdeps; + + if (( sodepends == 1 )); then + local filename soarch sofile soname soversion + + while read filename; do + # get architecture of the file; if soarch is empty it's not an ELF binary + soarch=$(LC_ALL=C readelf -h "$filename" 2>/dev/null | sed -n 's/.*Class.*ELF$32\|64$/\1/p') + [[ -n "$soarch" ]] || continue + + # process all libraries needed by the binary + for sofile in $(LC_ALL=C readelf -d "$filename" 2>/dev/null | sed -nr 's/.*Shared library: \[(.*)\].*/\1/p') + do + # extract the library name: libfoo.so + soname="${sofile%.so?(+(.+([0-9])))}".so + # extract the major version: 1 + soversion="${sofile##*\.so\.}" + + if [[ ${libdeps[$soname]} ]]; then + if [[ ! ${libdeps[$soname]} = *${soversion}-${soarch}* ]]; then + libdeps[$soname]+=" ${soversion}-${soarch}" + fi + else + libdeps[$soname]="${soversion}-${soarch}" fi - fi - done + done + done < <(find "$pkgdir" -type f -perm -u+x) + fi + + local libdepends v + for d in "${depends[@]}"; do + case "$d" in + *.so) + if [[ ${libdeps[$d]} ]]; then + for v in ${libdeps[$d]}; do + libdepends+=("$d=$v") + done + else + warning "$(gettext "Library listed in %s is not required by any files: %s")" "'depends'" "$d" + libdepends+=("$d") + fi + ;; + *) + libdepends+=("$d") + ;; + esac done + + printf '%s\n' "${libdepends[@]}" } + find_libprovides() { - local libprovides missing + local p libprovides missing for p in "${provides[@]}"; do missing=0 case "$p" in @@ -1246,38 +1290,20 @@ write_pkginfo() { printf "size = %s\n" "$size" printf "arch = %s\n" "$pkgarch" - [[ $license ]] && printf "license = %s\n" "${license[@]}" - [[ $replaces ]] && printf "replaces = %s\n" "${replaces[@]}" - [[ $groups ]] && printf "group = %s\n" "${groups[@]}" - [[ $optdepends ]] && printf "optdepend = %s\n" "${optdepends[@]//+([[:space:]])/ }" - [[ $conflicts ]] && printf "conflict = %s\n" "${conflicts[@]}" - mapfile -t provides < <(find_libprovides) - [[ $provides ]] && printf "provides = %s\n" "${provides[@]}" - - [[ $backup ]] && printf "backup = %s\n" "${backup[@]}" - + mapfile -t depends < <(find_libdepends) + + [[ $license ]] && printf "license = %s\n" "${license[@]}" + [[ $replaces ]] && printf "replaces = %s\n" "${replaces[@]}" + [[ $groups ]] && printf "group = %s\n" "${groups[@]}" + [[ $conflicts ]] && printf "conflict = %s\n" "${conflicts[@]}" + [[ $provides ]] && printf "provides = %s\n" "${provides[@]}" + [[ $backup ]] && printf "backup = %s\n" "${backup[@]}" + [[ $depends ]] && printf "depend = %s\n" "${depends[@]}" + [[ $optdepends ]] && printf "optdepend = %s\n" "${optdepends[@]//+([[:space:]])/ }" + [[ $makedepends ]] && printf "makedepend = %s\n" "${makedepends[@]}" local it - mapfile -t libdepends < <(find_libdepends) - depends+=("${libdepends[@]}") - - for it in "${depends[@]}"; do - if [[ $it = *.so ]]; then - # check if the entry has been found by find_libdepends - # if not, it's unneeded; tell the user so he can remove it - printf -v re '(^|\s)%s=.*' "$it" - if [[ ! $libdepends =~ $re ]]; then - error "$(gettext "Cannot find library listed in %s: %s")" "'depends'" "$it" - return 1 - fi - else - printf "depend = %s\n" "$it" - fi - done - - [[ $makedepends ]] && printf "makedepend = %s\n" "${makedepends[@]}" - for it in "${packaging_options[@]}"; do check_option "$it" "y" case $? in -- 1.7.10.2

2 2

[pacman-dev] [PATCH] Allow leading "local/" in query operations
by Allan McRae 19 May '12

19 May '12

I find that when copying the output of "pacman -Qs foo" into a "pacman -Qi" operation to get more information on the packages, I consistently copy the "local/" prefix. It is a minor usability improvement to strip this if present. Signed-off-by: Allan McRae <allan(a)archlinux.org> --- src/pacman/query.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/pacman/query.c b/src/pacman/query.c index a1cc1cf..07509fa 100644 --- a/src/pacman/query.c +++ b/src/pacman/query.c @@ -554,6 +554,11 @@ int pacman_query(alpm_list_t *targets) for(i = targets; i; i = alpm_list_next(i)) { const char *strname = i->data; + /* strip leading "local/" */ + if(strncmp(strname, "local/", 6) == 0) { + strname+=6; + } + if(config->op_q_isfile) { alpm_pkg_load(config->handle, strname, 1, 0, &pkg); } else { -- 1.7.10.2

1 0

[pacman-dev] [PATCH] pacman-key: test for content in keyring files
by Dave Reisner 13 May '12

13 May '12

Test for file content (-s) rather than just existance (-f). This fixes a bug that manifests itself in the case of an empty -revoked file. A zero element 'keys' array would be passed to gpg, forcing it to list and, subsequently, revoke all known keys. Bug introduced in d1240f67eab6. Signed-off-by: Dave Reisner <dreisner(a)archlinux.org> --- I figured I should call this out on the list since a few people ran into it on IRC. Currently, running 'pacman-key --populate archlinux' with the archlinux-keyring package exhibits this bug. scripts/pacman-key.sh.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/pacman-key.sh.in b/scripts/pacman-key.sh.in index fb790f6..70117bb 100644 --- a/scripts/pacman-key.sh.in +++ b/scripts/pacman-key.sh.in @@ -287,7 +287,7 @@ populate_keyring() { # 40CHARFINGERPRINTXXXXXXXXXXXXXXXXXXXXXXX:5: local -A trusted_ids for keyring in "${KEYRINGIDS[@]}"; do - if [[ -f "${KEYRING_IMPORT_DIR}/${keyring}-trusted" ]]; then + if [[ -s "${KEYRING_IMPORT_DIR}/${keyring}-trusted" ]]; then while IFS=: read key_id _; do # skip blank lines, comments; these are valid in this file [[ -z $key_id || ${key_id:0:1} = \# ]] && continue @@ -306,7 +306,7 @@ populate_keyring() { done msg "$(gettext "Importing owner trust values...")" for keyring in "${KEYRINGIDS[@]}"; do - if [[ -f "${KEYRING_IMPORT_DIR}/${keyring}-trusted" ]]; then + if [[ -s "${KEYRING_IMPORT_DIR}/${keyring}-trusted" ]]; then "${GPG_PACMAN[@]}" --import-ownertrust "${KEYRING_IMPORT_DIR}/${keyring}-trusted" fi done @@ -317,7 +317,7 @@ populate_keyring() { # guarantee of identification for the keys. local -A revoked_ids for keyring in "${KEYRINGIDS[@]}"; do - if [[ -f "${KEYRING_IMPORT_DIR}/${keyring}-revoked" ]]; then + if [[ -s "${KEYRING_IMPORT_DIR}/${keyring}-revoked" ]]; then mapfile -t keys < "${KEYRING_IMPORT_DIR}/${keyring}-revoked" while IFS=: read _ _ _ _ key_id _; do if [[ -n $key_id ]]; then -- 1.7.10.2

1 0

[pacman-dev] [PATCH] makepkg: Add CPPFLAGS support
by Allan McRae 08 May '12

08 May '12

Add CPPFLAGS support in addition to the current CFLAGS and CXXFLAGS. This keeps compiler flags split up in the same logical way done everywhere else. Signed-off-by: Allan McRae <allan(a)archlinux.org> --- This will allow a certian disrtibution to put -D_FORTIFY_SOURCE where it should be... doc/PKGBUILD.5.txt | 8 ++++---- doc/makepkg.conf.5.txt | 3 +++ etc/makepkg.conf.in | 1 + scripts/makepkg.sh.in | 4 ++-- 4 files changed, 10 insertions(+), 6 deletions(-) diff --git a/doc/PKGBUILD.5.txt b/doc/PKGBUILD.5.txt index eefdbd4..384af7c 100644 --- a/doc/PKGBUILD.5.txt +++ b/doc/PKGBUILD.5.txt @@ -254,10 +254,10 @@ A normal sync or upgrade will not use its value. with distcc. *buildflags*;; - Allow the use of user-specific buildflags (CFLAGS, CXXFLAGS, LDFLAGS) - during build as specified in linkman:makepkg.conf[5]. More useful in - its negative form `!buildflags` with select packages that have problems - building with custom buildflags. + Allow the use of user-specific buildflags (CPPFLAGS, CFLAGS, CXXFLAGS, + LDFLAGS) during build as specified in linkman:makepkg.conf[5]. More + useful in its negative form `!buildflags` with select packages that + have problems building with custom buildflags. *makeflags*;; Allow the use of user-specific makeflags during build as specified diff --git a/doc/makepkg.conf.5.txt b/doc/makepkg.conf.5.txt index 5970946..de2b4b4 100644 --- a/doc/makepkg.conf.5.txt +++ b/doc/makepkg.conf.5.txt @@ -51,6 +51,9 @@ Options A string such as ``i686-pc-linux-gnu'', do not touch unless you know what you are doing. This can be commented out by most users if desired. +**CPPFLAGS=**"cppflags":: + Flags used for the C preprocessor; see CFLAGS for more info. + **CFLAGS=**"cflags":: Flags used for the C compiler. This is a key part to the use of makepkg. Usually several options are specified, and the most common string resembles diff --git a/etc/makepkg.conf.in b/etc/makepkg.conf.in index d8117a3..51df493 100644 --- a/etc/makepkg.conf.in +++ b/etc/makepkg.conf.in @@ -27,6 +27,7 @@ CARCH="@CARCH@" CHOST="@CHOST@" #-- Compiler and Linker Flags +#CPPFLAGS="" #CFLAGS="-O2 -pipe" #CXXFLAGS="-O2 -pipe" #LDFLAGS="" diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index d36dbd6..c7baa97 100644 --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in @@ -955,7 +955,7 @@ run_function() { # clear user-specified buildflags if requested if check_option "buildflags" "n"; then - unset CFLAGS CXXFLAGS LDFLAGS + unset CPPFLAGS CFLAGS CXXFLAGS LDFLAGS fi # clear user-specified makeflags if requested @@ -967,7 +967,7 @@ run_function() { cd_safe "$srcdir" # ensure all necessary build variables are exported - export CFLAGS CXXFLAGS LDFLAGS MAKEFLAGS CHOST + export CPPFLAGS CFLAGS CXXFLAGS LDFLAGS MAKEFLAGS CHOST # save our shell options so pkgfunc() can't override what we need local shellopts=$(shopt -p) -- 1.7.10.1

3 3