- Pacman-dev - lists.archlinux.org

[pacman-dev] little error when installing/upgrading the first package in a new database
by Xavier 09 Jul '07

09 Jul '07

There was an odd error when the first package installed in a database had a scriptlet : LANG=C sudo src/pacman/pacman --conf pacman.conf -Ud /var/cache/pacman/pkg/filesystem-0.8-3.pkg.tar.gz loading package data... done. (1/1) checking for file conflicts [####################################################################################################] 100% error: could not open file /home/xav/dev/pacman/foo/var/lib/pacman/local//filesystem-0.8-3/depends: No such file or directory----------------------------] 0% (1/1) installing filesystem [####################################################################################################] 100% This doesn't happen with package that doesn't have a scriptlet, and it doesn't happen either when there is at least one other package in the database. But it still happened after running the same pacman command several times (ie upgrading the single package in the database). I finally found why. in add.c, alpm_add_commit function : 366 _alpm_log(PM_LOG_DEBUG, _("removing old package first (%s-%s)"), oldpkg->name, oldpkg->version); That part will remove the filesystem package if it existed (in case of an upgrade), and will also remove the entry from the database (filesystem directory in $dbpath/local) 473 } else if(strcmp(entryname, ".INSTALL") == 0) { 474 /* the install script goes inside the db */ 475 snprintf(filename, PATH_MAX, "%s/%s-%s/install", db->path, 476 newpkg->name, newpkg->version); That extracts the scriptlet to $dbpath/local//filesystem-0.8-3/install . then later, we have this : 778 /* Update the requiredby field by scanning the whole database 779 * looking for packages depending on the package to add */ 780 _alpm_pkg_update_requiredby(newpkg); and later, this : 821 _alpm_log(PM_LOG_DEBUG, _("updating database")); 822 _alpm_log(PM_LOG_DEBUG, _("adding database entry '%s'"), newpkg->name); So when update_requiredby is called, the entry hasn't been totally written in the database, we only have the install file, but no depends or desc file. and some code from update_requiredby in package.c : 756 pmdb_t *localdb = alpm_option_get_localdb(); 757 for(i = _alpm_db_get_pkgcache(localdb); i; i = i->next) { ... 764 for(j = alpm_pkg_get_depends(cachepkg); j; j = j->next) { So _alpm_get_pkgcache will return the filesystem package, because the directory exists in $dbpath/local/ , but alpm_pkg_get_depends will try to read the depends file which doesn't exist yet, resulting in the error message. Finding this didn't take too long, but this error should then appear in every cases, as long as the package has a scriptlet. But it didn't, as soon as there were more than one package in the db, the error disappeared. That's because of the pkg cache. in package.c , _alpm_db_get_pkgcache function, we have : 106 if(!db->pkgcache) { 107 _alpm_db_load_pkgcache(db); 108 } so the package database is loaded again only if db->pkgcache is NULL. The first time we install filesystem, pkgcache will be NULL when that function is called, so it'll read the database, finding the partial filesystem entry. And when we upgrade filesystem, it removes the old filesystem package first and at this moment _alpm_db_remove_pkgfromcache function from cache.c will be called, doing this : 152 _alpm_log(PM_LOG_DEBUG, _("removing entry '%s' from '%s' cache"), 153 alpm_pkg_get_name(pkg), db->treename); 154 155 db->pkgcache = alpm_list_remove(db->pkgcache, pkg, _alpm_pkg_cmp, &vdata); which will result in a NULL db->pkgcache too. There is no differences between an uninitialized list and an empty list, unfortunately ... When there is another package in the database, pkgcache won't be NULL after the current package being upgraded is removed from pkgcache list. So the pkgcache won't be updated by reading the database again when update_requiredby is called, and so it won't fail on a broken partial filesystem entry, because it has been removed from pkgcache ealier. While that issue was totally harmless, and never happens, because there is always more than one package in the db, it was annoying to get it every time when debugging, without knowing where it came from. For fixing it, it shouldn't be too hard, but I'm not sure yet. Maybe we can delay the extraction of the scriptlet to $dbpath/ , and only installs it in the same time than the dabase entry is created. Or maybe we can just call requiredby after the database entry is fully created, I'm not sure.. Or maybe we can make the difference between an empty pkgcache and a not initialized one.

3 5

Re: [pacman-dev] FS#7525: Permissions of .pacnew files
by Andrew Fyfe 08 Jul '07

08 Jul '07

Move the discussion to the ML... Pacman wrote: > THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. > > The following task has a new comment added: > > FS#7525 - Permissions of .pacnew files > User who did this - Xavier (shining) > > ---------- > Well then, maybe we could read the whole archive a first time, for > determining how to handle backup files (on the fly md5 computation), > and we record this information somehow. > And then a second time, where we actually extract the files. > > Otherwise, the files in backup array are always small config files > afaik, but well, it could be indeed be safer > to avoid putting the whole file in memory. > > Oh well, finally, the current behavior is alright I guess, and this is > probably not the correct place for discussing about things anyway (silly > me). > So I think this bug could be closed now :) > ---------- I've been thinking of another solution, include some more information in .FILELIST eg: # directory name d usr d usr/bin # file name checksum f usr/bin/foo md5sum # link name target l usr/bin/bar foo This way we can get the md5sum from the file list rather than having to extract the file to get it's md5sum. Andrew

2 2

[pacman-dev] [GIT] pacman branch, master now at v3.0.0-270-ga501b72
by Dan McGee 07 Jul '07

07 Jul '07

Hello, This is an automated email from the git hooks/update script, it was generated because a ref change was pushed to the repository. Updating branch, master, via a501b72e40062c9e606a787657582d1859c35d35 (commit) via b5f8a44bebc906bf6a29d30c159802b0c1a7dbb1 (commit) via 49f447d02c803e5a2f63582ce78cabb850ebfa89 (commit) via 15e1ce2e709e0a16dd54ea3b5eaab0003e32b62d (commit) from 6b7b9743181078aa7152daffdfc1eaeb46304c0f (commit) - Log ----------------------------------------------------------------- commit a501b72e40062c9e606a787657582d1859c35d35 Author: Dan McGee <dan(a)archlinux.org> Date: Fri Jul 6 19:35:32 2007 -0400 Make paragraph text in scripts single strings It is much easier for translators to deal with paragraphs as strings rather than by lines. Take all usage and version information and convert it to this format. Signed-off-by: Dan McGee <dan(a)archlinux.org> commit b5f8a44bebc906bf6a29d30c159802b0c1a7dbb1 Author: Dan McGee <dan(a)archlinux.org> Date: Fri Jul 6 18:43:24 2007 -0400 Move scripts from *.in to *.sh.in so gettext can determine type If we move the scripts from *.in to *.sh.in and *.py.in, gettext can pull the required strings to translate a whole lot easier. Do this. Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 49f447d02c803e5a2f63582ce78cabb850ebfa89 Author: Dan McGee <dan(a)archlinux.org> Date: Fri Jul 6 17:59:08 2007 -0400 First step of moving translations from src/pacman/po to po/ Move the translations from src/pacman/po to just po/ so we can include the scripts gettext translations in the same message catalog as that of the pacman frontend. The libalpm message catalog, for now, will remain a separate existence. Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 15e1ce2e709e0a16dd54ea3b5eaab0003e32b62d Author: Dan McGee <dan(a)archlinux.org> Date: Fri Jul 6 12:11:55 2007 -0400 Various small fixes as suggested by some static code checkers I ran flawfinder and sparse over the pacman source code and found a few things that were worth fixing (and were quick fixes). Signed-off-by: Dan McGee <dan(a)archlinux.org> ----------------------------------------------------------------------- Diffstat: Makefile.am | 4 +- configure.ac | 2 +- lib/libalpm/add.c | 7 - lib/libalpm/alpm.c | 5 +- lib/libalpm/alpm.h | 2 +- lib/libalpm/util.c | 8 +- {lib/libalpm/po => po}/.gitignore | 0 {lib/libalpm/po => po}/LINGUAS | 0 {lib/libalpm/po => po}/Makefile.in.in | 0 {src/pacman/po => po}/Makevars | 2 +- po/POTFILES.in | 22 ++ {src/pacman/po => po}/de.po | 0 {src/pacman/po => po}/en_GB.po | 0 {src/pacman/po => po}/es.po | 0 {src/pacman/po => po}/fr.po | 0 {src/pacman/po => po}/hu.po | 0 {src/pacman/po => po}/it.po | 0 {src/pacman/po => po}/pacman.pot | 0 {src/pacman/po => po}/pl_PL.po | 0 {src/pacman/po => po}/pt_BR.po | 0 {lib/libalpm/po => po}/remove-potcdate.sin | 0 {src/pacman/po => po}/ru_RU.po | 0 scripts/Makefile.am | 44 ++-- scripts/{abs.in => abs.sh.in} | 26 +- scripts/{gensync.in => gensync.sh.in} | 44 ++-- scripts/{makepkg.in => makepkg.sh.in} | 13 +- scripts/{makeworld.in => makeworld.sh.in} | 9 +- .../{pacman-optimize.in => pacman-optimize.sh.in} | 35 +- scripts/{rankmirrors.in => rankmirrors.py.in} | 8 +- scripts/{repo-add.in => repo-add.sh.in} | 33 +- scripts/{repo-remove.in => repo-remove.sh.in} | 29 +- scripts/{updatesync.in => updatesync.sh.in} | 41 +-- src/pacman/Makefile.am | 2 - src/pacman/po/.gitignore | 6 - src/pacman/po/LINGUAS | 10 - src/pacman/po/Makefile.in.in | 355 -------------------- src/pacman/po/POTFILES.in | 12 - src/pacman/po/remove-potcdate.sin | 19 - 38 files changed, 162 insertions(+), 576 deletions(-) hooks/update --- Git Source Code Management System hooks/update refs/heads/master \ 6b7b9743181078aa7152daffdfc1eaeb46304c0f \ a501b72e40062c9e606a787657582d1859c35d35

1 0

[pacman-dev] [GIT] pacman branch, master now at v3.0.0-266-g6b7b974
by Dan McGee 06 Jul '07

06 Jul '07

Hello, This is an automated email from the git hooks/update script, it was generated because a ref change was pushed to the repository. Updating branch, master, via 6b7b9743181078aa7152daffdfc1eaeb46304c0f (commit) from 59d9ccf48d84fd1e59f78cb4dcf428e53d1c6911 (commit) - Log ----------------------------------------------------------------- commit 6b7b9743181078aa7152daffdfc1eaeb46304c0f Author: Dan McGee <dan(a)archlinux.org> Date: Fri Jul 6 00:33:26 2007 -0400 Fix up pactest TODO Signed-off-by: Dan McGee <dan(a)archlinux.org> ----------------------------------------------------------------------- Diffstat: pactest/TODO | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) hooks/update --- Git Source Code Management System hooks/update refs/heads/master \ 59d9ccf48d84fd1e59f78cb4dcf428e53d1c6911 \ 6b7b9743181078aa7152daffdfc1eaeb46304c0f

1 0

[pacman-dev] makepkg -L fails
by Andreas Radke 03 Jul '07

03 Jul '07

while makepkg without the logging works when compiling udev: http://bugs.archlinux.org/task/7507 pacman 3.0.5-1 on x86_64 AndyRTR

5 4

[pacman-dev] [PATCH] Change the exit code for pacman_deptest().
by Andrew Fyfe 02 Jul '07

02 Jul '07

Changed the exit code for missing deps from 1 to 127 because 1 is used for other errors. makepkg breaks if pacman exits with 1 for any reason other than a missing dep. Signed-off-by: Andrew Fyfe <andrew(a)neptune-one.net> --- scripts/makepkg.in | 2 +- src/pacman/deptest.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/makepkg.in b/scripts/makepkg.in index 8be44c6..96c94ea 100644 --- a/scripts/makepkg.in +++ b/scripts/makepkg.in @@ -296,7 +296,7 @@ check_deps() { pmout=$(pacman $PACMAN_OPTS -T $*) ret=$? - if [ $ret -eq 1 ]; then #unresolved deps + if [ $ret -eq 127 ]; then #unresolved deps echo "$pmout" elif [ $ret -ne 0 ]; then error "$(gettext "Pacman returned a fatal error (%i): %s")" "$ret" "$pmout" diff --git a/src/pacman/deptest.c b/src/pacman/deptest.c index 264ba1c..5addfb3 100644 --- a/src/pacman/deptest.c +++ b/src/pacman/deptest.c @@ -79,7 +79,7 @@ int pacman_deptest(alpm_list_t *targets) if(!found) { printf("%s\n", saved_target); - retval = 1; + retval = 127; } free(saved_target); } -- 1.5.2.2

2 2

[pacman-dev] [GIT] pacman branch, master now at v3.0.0-265-g59d9ccf
by Dan McGee 02 Jul '07

02 Jul '07

Hello, This is an automated email from the git hooks/update script, it was generated because a ref change was pushed to the repository. Updating branch, master, via 59d9ccf48d84fd1e59f78cb4dcf428e53d1c6911 (commit) via 4d9b5d4a2a4cf96de8d6b4afa34a4d3424bf96b4 (commit) via 4d286e567b18a44715cb5dee37e7179a79cdef87 (commit) from 89ed15c9c2dd5449d50e5ec2283a4d6ebac5f328 (commit) - Log ----------------------------------------------------------------- commit 59d9ccf48d84fd1e59f78cb4dcf428e53d1c6911 Author: Dan McGee <dan(a)archlinux.org> Date: Mon Jul 2 10:06:03 2007 -0400 Reduce delay in pactest when running MODIFIED tests pactest was sleeping for 3 seconds, which is unnecessary. Reduce it to 1.5 seconds and clean up the code a bit anyway. Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 4d9b5d4a2a4cf96de8d6b4afa34a4d3424bf96b4 Author: Chantry Xavier <shiningxc(a)gmail.com> Date: Mon Jul 2 11:29:05 2007 +0200 pacman/query.c : return after a query on all packages. Previously, the following error was displayed even after a valid and successful query operation on all packages, like -Q , -Ql, -Qi, -Qil : no targets specified (use -h for help) Signed-off-by: Chantry Xavier <shiningxc(a)gmail.com> commit 4d286e567b18a44715cb5dee37e7179a79cdef87 Author: Dan McGee <dan(a)archlinux.org> Date: Sun Jul 1 23:27:20 2007 -0400 Update 'submitting-patches' Signed-off-by: Dan McGee <dan(a)archlinux.org> ----------------------------------------------------------------------- Diffstat: pactest/pmenv.py | 6 ++---- src/pacman/query.c | 1 + submitting-patches | 20 ++++++++++++++++---- 3 files changed, 19 insertions(+), 8 deletions(-) hooks/update --- Git Source Code Management System hooks/update refs/heads/master \ 89ed15c9c2dd5449d50e5ec2283a4d6ebac5f328 \ 59d9ccf48d84fd1e59f78cb4dcf428e53d1c6911

1 0

[pacman-dev] [GIT] pacman branch, master now at v3.0.0-262-g89ed15c
by Dan McGee 02 Jul '07

02 Jul '07

Hello, This is an automated email from the git hooks/update script, it was generated because a ref change was pushed to the repository. Updating branch, master, via 89ed15c9c2dd5449d50e5ec2283a4d6ebac5f328 (commit) via 7a42e24400499873c3b9e1e2315edc808d753734 (commit) via f55f7f100f650ff040f8721cf761a060af1c05fe (commit) via cd3a63681338b7510846837dcc169d276cf75458 (commit) via 19f66083f0aef92af84761fd62245270e97c6f33 (commit) via d70116bfbc535cac9eb941a570c34479e68a1b8d (commit) from 2657a2bfb7847c8ac4dd5875979400d0d3fd89f6 (commit) - Log ----------------------------------------------------------------- commit 89ed15c9c2dd5449d50e5ec2283a4d6ebac5f328 Author: Chantry Xavier <shiningxc(a)gmail.com> Date: Mon Jul 2 00:57:47 2007 +0200 pacman/packages.c : print an error for files that can't be stated. The -Ql operation is supposed to print all files but directories. stat was used for detecting directories. However, when stat failed, (because the file doesn't exist or is not readable), the files were still displayed just like the others. Now, these files are printed on stderr, with the corresponding error message. Signed-off-by: Chantry Xavier <shiningxc(a)gmail.com> commit 7a42e24400499873c3b9e1e2315edc808d753734 Author: Chantry Xavier <shiningxc(a)gmail.com> Date: Sat Jun 30 00:49:17 2007 +0200 libalpm/add.c : fix for FS #7484 Adds the ARCHIVE_EXTRACT_NO_OVERWRITE libarchive flags for extracting files and directories. This will prevent symlinks for being overwritten by directories. All other files that need to be extracted should already have been deleted previously by pacman. This flag is not used for extracting files in backup array to /tmp/alpm_XXXX, because this file is created by mkstemp first, and so needs to be overwritten by the file from the archive. Signed-off-by: Chantry Xavier <shiningxc(a)gmail.com> commit f55f7f100f650ff040f8721cf761a060af1c05fe Author: Chantry Xavier <shiningxc(a)gmail.com> Date: Mon Jul 2 02:12:36 2007 +0200 libalpm/add.c,util.c : log ARCHIVE_WARN warning to debug output. Signed-off-by: Chantry Xavier <shiningxc(a)gmail.com> commit cd3a63681338b7510846837dcc169d276cf75458 Author: Dan McGee <dan(a)archlinux.org> Date: Sun Jul 1 20:22:42 2007 -0400 Remove unnecessary and extra includes Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 19f66083f0aef92af84761fd62245270e97c6f33 Author: Dan McGee <dan(a)archlinux.org> Date: Sun Jul 1 20:03:15 2007 -0400 Add mode and type checking to pactest for files Add the ability to check the permissions and type of a file within the framework of pactest. Two new rules can be used: self.addrule("FILE_TYPE=bin/foo|file") self.addrule("FILE_MODE=bin/bar|644") TODO: add the ability to add different types of files (eg links) via the test package building framework, and add the ability to change the modes on files. Signed-off-by: Dan McGee <dan(a)archlinux.org> commit d70116bfbc535cac9eb941a570c34479e68a1b8d Author: Dan McGee <dan(a)archlinux.org> Date: Sun Jul 1 18:40:43 2007 -0400 Move Doxygen manpage generation to doc/ directory Instead of doing the doxygen work in the libalpm/ dir, do it with the rest of the docs in the doc/ dir. Signed-off-by: Dan McGee <dan(a)archlinux.org> ----------------------------------------------------------------------- Diffstat: {lib/libalpm => doc}/Doxyfile | 25 +++------------------- doc/Makefile.am | 9 +++++++- lib/libalpm/Makefile.am | 10 --------- lib/libalpm/add.c | 22 +++++++++++++++++-- lib/libalpm/db.c | 7 ------ lib/libalpm/remove.c | 7 ------ lib/libalpm/server.c | 1 - lib/libalpm/sync.c | 2 - lib/libalpm/util.c | 17 +++++++++++--- pactest/pmrule.py | 45 ++++++++++++++++++++++++++-------------- pactest/tests/mode001.py | 12 +++++++++++ pactest/tests/type001.py | 13 +++++++++++ src/pacman/package.c | 11 +++++++-- 13 files changed, 106 insertions(+), 75 deletions(-) hooks/update --- Git Source Code Management System hooks/update refs/heads/master \ 2657a2bfb7847c8ac4dd5875979400d0d3fd89f6 \ 89ed15c9c2dd5449d50e5ec2283a4d6ebac5f328

1 0

[pacman-dev] pacman -Ql
by Xavier 02 Jul '07

02 Jul '07

I found it weird that pacman -Ql listed two directories : pacman -Ql | grep "/$" cups /var/spool/cups/tmp/ ttf-ms-fonts /tmp/ttf-ms-fonts/ I found the explanation here : http://bbs.archlinux.org/viewtopic.php?pid=259654#p259654 I think this code is wrong, but don't know how to fix it.. Why does it have to use stat for dir though ? Can't it just check for the trailing slash ? And then, stat could be used for the feature request of this thread, ie checking that all files from package actually exist on the filesystem. But in this case, root access will be needed here, otherwise it'll get it wrong..

2 3

[pacman-dev] [PATCH] Change the exit code for pacman_deptest() and some clean up.
by Andrew Fyfe 30 Jun '07

30 Jun '07

Changed the exit code for missing deps from 1 to 128 because 1 is used for other errors. makepkg breaks if pacman exits with 1 for any reason other than a missing dep. Changed alpm_splitdeps( deptest ) so it doesn't change the value of deptest. Signed-off-by: Andrew Fyfe <andrew(a)neptune-one.net> --- lib/libalpm/deps.c | 4 +++- scripts/makepkg.in | 2 +- src/pacman/deptest.c | 16 +++++----------- 3 files changed, 9 insertions(+), 13 deletions(-) diff --git a/lib/libalpm/deps.c b/lib/libalpm/deps.c index 524136b..b259c4b 100644 --- a/lib/libalpm/deps.c +++ b/lib/libalpm/deps.c @@ -442,7 +442,9 @@ pmdepend_t SYMEXPORT *alpm_splitdep(const char *depstring) if(depstring == NULL) { return(NULL); } - newstr = strdup(depstring); + + newstr = calloc(strlen(depstring)+1, sizeof(char)); + strncpy(newstr, depstring, strlen(depstring)); depend = malloc(sizeof(pmdepend_t)); if(depend == NULL) { diff --git a/scripts/makepkg.in b/scripts/makepkg.in index 8be44c6..12459f9 100644 --- a/scripts/makepkg.in +++ b/scripts/makepkg.in @@ -296,7 +296,7 @@ check_deps() { pmout=$(pacman $PACMAN_OPTS -T $*) ret=$? - if [ $ret -eq 1 ]; then #unresolved deps + if [ $ret -eq 128 ]; then #unresolved deps echo "$pmout" elif [ $ret -ne 0 ]; then error "$(gettext "Pacman returned a fatal error (%i): %s")" "$ret" "$pmout" diff --git a/src/pacman/deptest.c b/src/pacman/deptest.c index 264ba1c..8a731ae 100644 --- a/src/pacman/deptest.c +++ b/src/pacman/deptest.c @@ -27,6 +27,7 @@ #include <alpm.h> #include <alpm_list.h> +#include <deps.h> /* pacman */ #include "pacman.h" @@ -52,20 +53,14 @@ int pacman_deptest(alpm_list_t *targets) alpm_list_t *j, *provides; target = alpm_list_getdata(i); - - /* splitdep modifies the string... we'll compensate for now */ - char *saved_target = NULL; - saved_target = calloc(strlen(target)+1, sizeof(char)); - strncpy(saved_target, target, strlen(target)); - dep = alpm_splitdep(target); - pkg = alpm_db_get_pkg(alpm_option_get_localdb(), target); + pkg = alpm_db_get_pkg(alpm_option_get_localdb(), dep->name); if(pkg && alpm_depcmp(pkg, dep)) { found = 1; } else { /* not found, can we find anything that provides this in the local DB? */ - provides = alpm_db_whatprovides(alpm_option_get_localdb(), target); + provides = alpm_db_whatprovides(alpm_option_get_localdb(), dep->name); for(j = provides; j; j = alpm_list_next(j)) { pmpkg_t *pkg; pkg = alpm_list_getdata(j); @@ -78,10 +73,9 @@ int pacman_deptest(alpm_list_t *targets) } if(!found) { - printf("%s\n", saved_target); - retval = 1; + printf("%s\n", target); + retval = 128; } - free(saved_target); } return(retval); } -- 1.5.2.2

3 12

[pacman-dev] [GIT] pacman branch, master now at v3.0.0-256-g2657a2b
by Chantry Xavier 29 Jun '07

29 Jun '07

Hello, This is an automated email from the git hooks/update script, it was generated because a ref change was pushed to the repository. Updating branch, master, via 2657a2bfb7847c8ac4dd5875979400d0d3fd89f6 (commit) via 1a3b3bc1300b42dc2f554a6faa09b5ece2d3321c (commit) from 78bac81a58355a6d42760e1974005dbcdd8e8dcf (commit) - Log ----------------------------------------------------------------- commit 2657a2bfb7847c8ac4dd5875979400d0d3fd89f6 Author: Chantry Xavier <shiningxc(a)gmail.com> Date: Thu Jun 28 19:28:34 2007 +0200 libalpm/add.c : ignore libarchive warning. With libarchive 2.2.3 (previously 1.3.1), archive_read_extract now returns ARCHIVE_WARN when a package is extracted as user, because for example, UID=0 or SUID bit can't be set. This patch makes pacman not treating these warnings as errors anymore, but simply ignoring them. Signed-off-by: Chantry Xavier <shiningxc(a)gmail.com> commit 1a3b3bc1300b42dc2f554a6faa09b5ece2d3321c Author: Chantry Xavier <shiningxc(a)gmail.com> Date: Thu Jun 28 16:59:34 2007 +0200 libalpm/util.c : stat returns 0 on success Signed-off-by: Chantry Xavier <shiningxc(a)gmail.com> ----------------------------------------------------------------------- Diffstat: lib/libalpm/add.c | 17 +++++++++++------ lib/libalpm/util.c | 2 +- 2 files changed, 12 insertions(+), 7 deletions(-) hooks/update --- Git Source Code Management System hooks/update refs/heads/master \ 78bac81a58355a6d42760e1974005dbcdd8e8dcf \ 2657a2bfb7847c8ac4dd5875979400d0d3fd89f6

1 0

[pacman-dev] difficult symlink "puzzle"
by Nagy Gabor 29 Jun '07

29 Jun '07

Hi! I ran into a difficult problem: What about symlink directories, if an other package wants to pull some new files to them? Let me explain with an example: See packages git (it contains: /usr/lib/perl5/site_perl/5.8.8/Git.pm). However, /usr/lib/perl5/site_perl/5.8.8/ is a symlink to /usr/lib/perl5/site_perl/current/. What should the package manager do here? The current situation: git package simply overwrites /usr/lib/perl5/site_perl/5.8.8/ symlink with a regular directory, so the dir 5.8.8 contains only git.pm now :-( If we install git first then perl's install script cannot do anything useful with the existing 5.8.8 dir: result is the same :-( The problem main problem, that currently I cannot solve this problem: if pacman treated the 5.8.8 symlink as an existing dir (in the first example), then Git.pm would be copied to current, which easily can run out of pacman's control (if the 5.8.8 symlink will be deleted later with a forced -Rd perl). It's hard to find a good solution imho, pacman should follow dir symlink during package install, and something should be recorded into db (to FILES: 5.8.8/file->current/file), but the precise handling of this would cause big overhead, and is not easy... Bye, ngaba

3 4

[pacman-dev] What I'm working on- feedback welcome
by Dan McGee 29 Jun '07

29 Jun '07

I've got quite a few branches going on my GIT tree at the moment, and I'd appreciate any feedback from some of you on the list. They are all accessible here: http://code.toofishes.net/gitweb.cgi. * alpm.c_cleanup- move all of the alpm_pkg functions to package.c, alpm_db functions to db.c, etc. Basically put things where they logically belong leaving only the library initialization functions in alpm.c. This is ready to merge; I'm waiting because it could potentially break a lot for anyone else that has something that touched this file. * alpm_list_speed- this was just a test branch to see how much we were losing in efficiency by not having O(1) access to both ends of a list. Answer: a lot. pacman -Qo operations are a lot faster on this branch. However, this isn't meant for merge, it was more of a quick hack-job. * db_test- Add a pacman -Qt operation which tests the integrity of your database; ported over from the Frugalware pacman-g2. * frontend_config- move the pacman.conf parsing to the frontend where it belongs. Move a few pacman-only settings out of the library. In general, try to clean up where options and configs are stored. * gettext- gettext the remaining scripts in the scripts/ directory. I've had these patches sitting around for a while but never got them applied. Ready to be merged. * working- remove some hardcoded paths from the pacman binary, making everything configurable at runtime instead of compile time through pacman.conf. This means the only path now hardcoded into the pacman binary is that to pacman.conf, and no paths are compiled into libalpm. As I said, feedback on any of these is welcome and appreciated. -Dan

2 1

[pacman-dev] Pacman depending on package naming scheme
by Dan McGee 29 Jun '07

29 Jun '07

If anyone on the list wants to look this commit/branch of mine over and review it, I'd appreciate it: http://code.toofishes.net/gitweb.cgi?p=pacman.git;a=shortlog;h=pkgname_check I know Andrew just had a commit dealing with a very similar thing in the xdelta creation in makepkg, and he removed the dependency on a package having a certain name. This is the same sort of issue, and I think it would be wise for us to fix it everywhere we can. Not only does this free us up from the CARCH issue, note the amount of code we can remove because of it. (For a side note- I challenge anyone to start submitting patches to the list that result in a net removal rather than addition of code. They are a lot more helpful than you would think.) Does anyone have concerns with this, and does anyone have some great ideas how to (re)implement partial cache cleaning functionality correctly? The old way wasn't phenomenal, and I just got rid of it in this first commit here. There were also many shortcomings in it as you can see in the comments throughout that section. -Dan

2 1

[pacman-dev] My git repo and development snapshots
by Andrew Fyfe 29 Jun '07

29 Jun '07

I've finally got round to getting my self a vps server @ slicehost.com, so I've now got all my git stuff running on the new server. I'll keep my repo at repo.or.cz up to date. Also for those that want to get the latest source without git I've now got git generating snapshots of the master branch. They're automatically updated when new updates are posted.* git: git://neptune-one.homeip.net/pacman gitweb: http://neptune-one.homeip.net/cgi-bin/gitweb.cgi?p=pacman snapshots: http://neptune-one.homeip.net/~andrew/pacman/ Andrew * More specifically when I push updates, there doesn't seem to be a hook for git pull :(

2 1

[pacman-dev] [GIT] pacman branch, master now at v3.0.0-254-g78bac81
by Andrew Fyfe 29 Jun '07

29 Jun '07

Hello, This is an automated email from the git hooks/update script, it was generated because a ref change was pushed to the repository. Updating branch, master, via 78bac81a58355a6d42760e1974005dbcdd8e8dcf (commit) from 7daa6708d2afc710bebbb2dc30f4371f9d67120c (commit) - Log ----------------------------------------------------------------- commit 78bac81a58355a6d42760e1974005dbcdd8e8dcf Author: Andrew Fyfe <andrew(a)neptune-one.net> Date: Thu Jun 28 10:48:32 2007 +0100 scripts/makepkg.in: Don't include .PKGINFO etc in .FILELIST And move .PKGINFO and .FILELIST to be the first to files included in the package. Signed-off-by: Andrew Fyfe <andrew(a)neptune-one.net> ----------------------------------------------------------------------- Diffstat: scripts/makepkg.in | 11 +++++++---- 1 files changed, 7 insertions(+), 4 deletions(-) hooks/update --- Git Source Code Management System hooks/update refs/heads/master \ 7daa6708d2afc710bebbb2dc30f4371f9d67120c \ 78bac81a58355a6d42760e1974005dbcdd8e8dcf

3 3

[pacman-dev] libarchive warning output
by Xavier 28 Jun '07

28 Jun '07

There is one more change with libarchive 2.2.3 vs 1.3.1 When installing a package as user, archive_read_extract now returns ARCHIVE_WARN instead of ARCHIVE_OK , because it cant set uid to 0, and also, it can't set suid for the files that have it. Currently, pacman considers it as errors, instead of warnings. I don't think it should, but I'm not sure how to handle the warning output either. Also, strerror(errno) displayed either "File exists" or "No such file or directory", I've no idea why... And archive_error_string(archive) still displays that part, but also adds more helpful message like : "Can't set UID=0: File exists" "Can't set UID=0: No such file or directoryCan't make file SUID" Since with old libarchive, these warnings weren't returned, and so not displayed, I adpated pacman to keep the same behavior for now. But if these warnings are useful, they can easily be displayed. >From 2657a2bfb7847c8ac4dd5875979400d0d3fd89f6 Mon Sep 17 00:00:00 2001 From: Chantry Xavier <shiningxc(a)gmail.com> Date: Thu, 28 Jun 2007 19:28:34 +0200 Subject: [PATCH] libalpm/add.c : ignore libarchive warning. With libarchive 2.2.3 (previously 1.3.1), archive_read_extract now returns ARCHIVE_WARN when a package is extracted as user, because for example, UID=0 or SUID bit can't be set. This patch makes pacman not treating these warnings as errors anymore, but simply ignoring them. Signed-off-by: Chantry Xavier <shiningxc(a)gmail.com> --- lib/libalpm/add.c | 17 +++++++++++------ 1 files changed, 11 insertions(+), 6 deletions(-) diff --git a/lib/libalpm/add.c b/lib/libalpm/add.c index b6a54b7..1ebf455 100644 --- a/lib/libalpm/add.c +++ b/lib/libalpm/add.c @@ -544,11 +544,12 @@ int _alpm_add_commit(pmtrans_t *trans, pmdb_t *db) archive_entry_set_pathname(entry, tempfile); - if(archive_read_extract(archive, entry, archive_flags) != ARCHIVE_OK) { + int ret = archive_read_extract(archive, entry, archive_flags); + if(ret != ARCHIVE_OK && ret != ARCHIVE_WARN) { _alpm_log(PM_LOG_ERROR, _("could not extract %s (%s)"), - entryname, strerror(errno)); + entryname, archive_error_string(archive)); alpm_logaction(_("could not extract %s (%s)"), - entryname, strerror(errno)); + entryname, archive_error_string(archive)); errors++; unlink(tempfile); FREE(hash_orig); @@ -699,10 +700,14 @@ int _alpm_add_commit(pmtrans_t *trans, pmdb_t *db) archive_entry_set_pathname(entry, filename); - if(archive_read_extract(archive, entry, archive_flags) != ARCHIVE_OK) { - _alpm_log(PM_LOG_ERROR, _("could not extract %s (%s)"), filename, strerror(errno)); - alpm_logaction(_("error: could not extract %s (%s)"), filename, strerror(errno)); + int ret = archive_read_extract(archive, entry, archive_flags); + if(ret != ARCHIVE_OK && ret != ARCHIVE_WARN) { + _alpm_log(PM_LOG_ERROR, _("could not extract %s (%s)"), + entryname, archive_error_string(archive)); + alpm_logaction(_("could not extract %s (%s)"), + entryname, archive_error_string(archive)); errors++; + continue; } /* calculate an hash if this is in newpkg's backup */ -- 1.5.2.2

1 0

[pacman-dev] Pulled changes and other things
by Dan McGee 28 Jun '07

28 Jun '07

I pulled in Andrew's bsdtar branch today, and Xavier's ready_to_pull branch, so those changes have all been pushed to the al.org tree. Thanks guys! Other things: 1. For you guys that I am pulling GIT repos from, can you do me a favor? I added some more descriptive tags to the GIT repo (v3.0.0) instead of the older uglier CVS tags (R_3_0_0). If you wouldn't mind deleting those old tags in your pushed repo, I would appreciate it so I don't keep pulling them in. By default GIT does not push tags, but it does pull them. I got rid of them on my public repo and the al.org tree; if you do the same that would be awesome. 2. What is on people's minds for a 3.1 release? I don't think its too early to start at least getting some thoughts on paper, and see what kind of timeframe we can make for ourselves. I know at least the following things are true- I've made a lot of changes recently and they need some refinement, to say the least. In addition, we seem to have a lot of outstanding libarchive issues that we should take a look at and ensure are fixed. If we need to extend the pactest framework to be able to test this better, then we should do that. Thanks to everyone that has been contributing to pacman, we definitely appreciate it, and you can see the wide variety of authors that are now in the GIT history. Hopefully some of you will venture into the big bad libalpm after dipping your toes in makepkg changes. It is what I did. :) -Dan

3 2

[pacman-dev] Color patch again
by Vojtěch Gondžala 28 Jun '07

28 Jun '07

Hi all, I rewrite the color patch from 3.0.x version. Colors are reconfigurable in pacman.conf in section [colors], if isn't anything explicity named then is using default color. Option --nocolor disable colorized output. yours opinion? :) --vogo

3 3

[pacman-dev] [GIT] pacman branch, master now at v3.0.0-253-g7daa670
by Dan McGee 28 Jun '07

28 Jun '07

Hello, This is an automated email from the git hooks/update script, it was generated because a ref change was pushed to the repository. Updating branch, master, via 7daa6708d2afc710bebbb2dc30f4371f9d67120c (commit) via 7bdb904af5b664c1d6e47977f21f0e6bc3f8e3b0 (commit) via ad691001e20272b794d2ed574b556f520e3555c0 (commit) from 1e56e41d638fcdddc291d9a8ea183b40f4802aae (commit) - Log ----------------------------------------------------------------- commit 7daa6708d2afc710bebbb2dc30f4371f9d67120c Author: Dan McGee <dan(a)archlinux.org> Date: Wed Jun 27 23:25:04 2007 -0400 Remove lockfile configuration from frontend, make it job of libalpm I previously introduced some patches to make just about every path in pacman/libalpm configurable; doing this with the lockfile seemed a bit too far and we really should just place the lockfile where it belongs- with the DB that needs locking. More details in this thread: http://archlinux.org/pipermail/pacman-dev/2007-June/008499.html Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 7bdb904af5b664c1d6e47977f21f0e6bc3f8e3b0 Author: Dan McGee <dan(a)archlinux.org> Date: Wed Jun 27 22:58:21 2007 -0400 pacman.c: make parseconfig a bit more robust Don't let parseconfig overwrite settings that parseargs already made. Signed-off-by: Dan McGee <dan(a)archlinux.org> commit ad691001e20272b794d2ed574b556f520e3555c0 Author: Dan McGee <dan(a)archlinux.org> Date: Wed Jun 27 22:12:59 2007 -0400 Remove scriptlet START and DONE commands that we don't use The scriptlet calling had some unneeded complexity for the time being which we aren't using here. Let's get rid of it until we find a good way to implement it correctly. Signed-off-by: Dan McGee <dan(a)archlinux.org> ----------------------------------------------------------------------- Diffstat: configure.ac | 1 - etc/pacman.conf.in | 1 - lib/libalpm/Makefile.am | 5 ----- lib/libalpm/alpm.h | 5 +---- lib/libalpm/handle.c | 17 +++++++---------- lib/libalpm/trans.c | 33 +-------------------------------- lib/libalpm/util.c | 9 +++------ lib/libalpm/util.h | 4 ---- pactest/pmtest.py | 5 ++--- pactest/util.py | 2 +- scripts/pacman-optimize.in | 2 +- src/pacman/Makefile.am | 1 - src/pacman/callback.c | 14 -------------- src/pacman/pacman.c | 35 +++++++++++++++++------------------ 14 files changed, 33 insertions(+), 101 deletions(-) hooks/update --- Git Source Code Management System hooks/update refs/heads/master \ 1e56e41d638fcdddc291d9a8ea183b40f4802aae \ 7daa6708d2afc710bebbb2dc30f4371f9d67120c

1 0

[pacman-dev] [GIT] pacman branch, master now at v3.0.0-250-g1e56e41
by Dan McGee 28 Jun '07

28 Jun '07

Hello, This is an automated email from the git hooks/update script, it was generated because a ref change was pushed to the repository. Updating branch, master, via 1e56e41d638fcdddc291d9a8ea183b40f4802aae (commit) via 269022ccae921ae7f7caa1aca4a7d40cb0773985 (commit) via 24c41f5190974e68444466d0d8563dbe9ab06768 (commit) via 5a3b59583740c033a5e27b61c3c38bebfd580acc (commit) via 77bbe581973d41d57edb96488fa2cf73fddc1641 (commit) via 3a27fbaae40869d513cf117609d3a56c07863cae (commit) from d821d75e255207bf84f58532e2ff65a8a2a79d42 (commit) - Log ----------------------------------------------------------------- commit 1e56e41d638fcdddc291d9a8ea183b40f4802aae Author: Andrew Fyfe <andrew(a)neptune-one.net> Date: Wed Jun 27 12:04:33 2007 +0100 scripts/makepkg.in: Use bsdtar to find packages for xdelta. When looking for old packages to create a delta from used bsdtar to read the packages .PKGINFO to check it's name and arch instead of depending on the filename of th package. Signed-off-by: Andrew Fyfe <andrew(a)neptune-one.net> commit 269022ccae921ae7f7caa1aca4a7d40cb0773985 Author: Chantry Xavier <chantry.xavier(a)gmail.com> Date: Fri Jun 22 22:09:55 2007 +0100 scripts/makepkg.in: Fix creation of .FILELIST Signed-off-by: Andrew Fyfe <andrew(a)neptune-one.net> commit 24c41f5190974e68444466d0d8563dbe9ab06768 Author: Baptiste Daroussin <baptiste.daroussin(a)gmail.com> Date: Fri Jun 22 19:23:28 2007 +0100 FS7485: Replace tar/cpio/unzip with bsdtar for extracting/creating packages. Signed-off-by: Andrew Fyfe <andrew(a)neptune-one.net> commit 5a3b59583740c033a5e27b61c3c38bebfd580acc Author: Dan McGee <dan(a)archlinux.org> Date: Wed Jun 27 19:27:26 2007 -0400 Fix wrong permissions on pacnew extraction First reported here: http://bbs.archlinux.org/viewtopic.php?pid=261861 Newly created files were done with the standard umask, so those that are extracted seperately and copied to a .pacnew extension will have the wrong permissions. This should hopefully fix this. Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 77bbe581973d41d57edb96488fa2cf73fddc1641 Author: Dan McGee <dan(a)archlinux.org> Date: Wed Jun 27 16:33:27 2007 -0400 Remove TODO items that have been taken care of. Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 3a27fbaae40869d513cf117609d3a56c07863cae Author: Chantry Xavier <shiningxc(a)gmail.com> Date: Thu Jun 28 01:20:30 2007 +0200 libalpm/remove.c : file variable used before being initialized. Signed-off-by: Chantry Xavier <shiningxc(a)gmail.com> ----------------------------------------------------------------------- Diffstat: TODO.aaron | 16 ---------------- TODO.dan | 17 ----------------- lib/libalpm/remove.c | 3 ++- lib/libalpm/util.c | 15 +++++++++++++++ scripts/makepkg.in | 44 +++++++++++++++++--------------------------- 5 files changed, 34 insertions(+), 61 deletions(-) hooks/update --- Git Source Code Management System hooks/update refs/heads/master \ d821d75e255207bf84f58532e2ff65a8a2a79d42 \ 1e56e41d638fcdddc291d9a8ea183b40f4802aae

1 0

[pacman-dev] makepkg creates bad .FILELIST
by Andrew Fyfe 27 Jun '07

27 Jun '07

This patch[1] breaks the creation of .FILELIST, directories don't end with / so pacman treats them as files and does conflict checks and bails out because /usr (or any other dir) has already been installed by another package. Posted a patch[2] to my ready_to_pull branch. [1] http://projects.archlinux.org/git/?p=pacman.git;a=commit;h=430a19c604e474e9… [2] http://repo.or.cz/w/pacman.git?a=shortlog;h=ready_to_pull Andrew

4 11

[pacman-dev] [GIT] pacman branch, master now at v3.0.0-244-gd821d75
by Dan McGee 27 Jun '07

27 Jun '07

Hello, This is an automated email from the git hooks/update script, it was generated because a ref change was pushed to the repository. Updating branch, master, via d821d75e255207bf84f58532e2ff65a8a2a79d42 (commit) via 31cbbbf95365e5b821e3f93301e808a973035b2d (commit) from 0e4c1e86ed16c4793b9521e8152b30cc166aae68 (commit) - Log ----------------------------------------------------------------- commit d821d75e255207bf84f58532e2ff65a8a2a79d42 Author: Dan McGee <dan(a)archlinux.org> Date: Wed Jun 27 09:55:20 2007 -0400 Add archlinux.de mirror Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 31cbbbf95365e5b821e3f93301e808a973035b2d Author: Chantry Xavier <shiningxc(a)gmail.com> Date: Tue Jun 26 15:27:56 2007 -0400 Add pactest to help debug FS #7415 Signed-off-by: Dan McGee <dan(a)archlinux.org> ----------------------------------------------------------------------- Diffstat: etc/pacman.d/mirrorlist.in | 1 + pactest/tests/sync022.py | 22 ++++++++++++++++++++++ 2 files changed, 23 insertions(+), 0 deletions(-) hooks/update --- Git Source Code Management System hooks/update refs/heads/master \ 0e4c1e86ed16c4793b9521e8152b30cc166aae68 \ d821d75e255207bf84f58532e2ff65a8a2a79d42

1 0

[pacman-dev] libarchive issue
by Xavier 27 Jun '07

27 Jun '07

Upgrading to the last libarchive fixed some problems, but also caused a new one : http://bugs.archlinux.org/task/7484 I tried to look at it, since Dan was away, but miserably failed. I'm afraid this one is way too hard for me, I found all libarchive related stuff very confusing, and couldn't make any sense of it. All that is left is even more questions. Sorry about that :( Maybe I'll keep trying, if we can take the time to fix this, and if no one else can figure it out. The main questions I've (already in the bug comments) are : 1) why pacman got permission of /tmp wrong with old libarchive, while old bsdtar gets them right? 2) is the ARCHIVE_EXTRACT_NO_OVERWRITE option the only way in libarchive to avoid losing symlinks ? And does this option do what we want? I'm afraid both questions require some investigations for being answered.

2 4

[pacman-dev] CVS update of pacman-lib/lib/libalpm (alpm.c)
by Dan McGee 26 Jun '07

26 Jun '07

Date: Tuesday, June 26, 2007 @ 15:35:00 Author: dan Path: /home/cvs-pacman/pacman-lib/lib/libalpm Modified: alpm.c (1.128 -> 1.129) Add fix for config parsing issue in case of another pacman 3.0.X release --------+ alpm.c | 1 + 1 file changed, 1 insertion(+) Index: pacman-lib/lib/libalpm/alpm.c diff -u pacman-lib/lib/libalpm/alpm.c:1.128 pacman-lib/lib/libalpm/alpm.c:1.129 --- pacman-lib/lib/libalpm/alpm.c:1.128 Tue Apr 3 23:59:36 2007 +++ pacman-lib/lib/libalpm/alpm.c Tue Jun 26 15:35:00 2007 @@ -940,6 +940,7 @@ } _alpm_strtrim(key); strncpy(origkey, key, min(255, strlen(key))); + origkey[min(255, strlen(key))] = '\0'; key = _alpm_strtoupper(key); if(!strlen(section) && strcmp(key, "INCLUDE")) { RET_ERR(PM_ERR_CONF_DIRECTIVE_OUTSIDE_SECTION, -1);

1 0