- Pacman-dev - lists.archlinux.org

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v5.1.0-23-gacef70c1
by Allan McRae 19 Jul '18

19 Jul '18

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, master has been updated via acef70c1036e3234fe07f2dd1d105f0f59480baa (commit) via 8b4be66a3006abe209f6f6a8ef13991cfa57fe34 (commit) via 9a8c7154b1b5842a08db27bd3c3a1607fa0c8f0f (commit) via 4fe9adf418467505884dcc6e9a6ae9239c06c5f8 (commit) from 0d6e82d3748653a2b61ea34b940011ef97350768 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit acef70c1036e3234fe07f2dd1d105f0f59480baa Author: Allan McRae <allan(a)archlinux.org> Date: Thu Jun 21 15:36:05 2018 +1000 libmakepkg: remove accidentally added file A blank file slipped into libmakepkg in commit 2c94118d. Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 8b4be66a3006abe209f6f6a8ef13991cfa57fe34 Author: Eli Schwartz <eschwartz(a)archlinux.org> Date: Tue Jun 12 21:17:18 2018 -0400 libmakepkg/tidy: fix debug sources not being properly detected sometimes DW_AT_comp_dir is meant to contain the directory in which the compiler was run DW_AT_name contains the source file the compiler was told to use. In the event that DW_AT_name is an absolute path, it is (obviously) not meant to be computed relative to DW_AT_comp_dir. However, we did not handle this correctly, and as a result tried to copy source files using doubled-up filepaths. The correct approach should be to use DW_AT_name on its own, in the event that it is an absolute path. See http://wiki.dwarfstd.org/index.php?title=Best_Practices. This fixes debug package generation for many packages that use absolute paths in their build systems... like CMake. Reported-by: Jagannathan Tiruvallur Eachambadi <jagannathante(a)gmail.com> Signed-off-by: Eli Schwartz <eschwartz(a)archlinux.org> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 9a8c7154b1b5842a08db27bd3c3a1607fa0c8f0f Author: Allan McRae <allan(a)archlinux.org> Date: Tue Jun 19 21:08:28 2018 +1000 Revert "makepkg: use the `declare` builtin when backing up variables to eval" This reverts commit 9e52a36794552b77ecf26f7f34b226d096978f1e. The change to use declare for the split package metadata backup/restore resulted in variables being declared at a local scope. When these variables were unset (mostly noticed with debug packaging) this left the variable at global scope defined. Revert back to the known good state. Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 4fe9adf418467505884dcc6e9a6ae9239c06c5f8 Author: Allan McRae <allan(a)archlinux.org> Date: Tue Jun 19 20:44:14 2018 +1000 PKGBUILD(5): Remove reference to ChangeLog prototype inclusion We do not distribute a ChangeLog prototype, so should not reference it in the man page. Signed-off-by: Allan McRae <allan(a)archlinux.org> ----------------------------------------------------------------------- Summary of changes: doc/PKGBUILD.5.asciidoc | 6 +++--- scripts/libmakepkg/lint_pkgbuild/3 | 0 scripts/libmakepkg/tidy/strip.sh.in | 2 +- scripts/makepkg.sh.in | 20 ++++++++++++++++---- 4 files changed, 20 insertions(+), 8 deletions(-) delete mode 100644 scripts/libmakepkg/lint_pkgbuild/3 hooks/post-receive -- The official pacman repository

1 0

[pacman-dev] [RFC PATCH] makepkg: extend the .BUILDINFO for enhanced reproducible support
by Eli Schwartz 18 Jul '18

18 Jul '18

Encode information about the compiler and strip flags used, as these will impact the resulting generated binaries. Signed-off-by: Eli Schwartz <eschwartz(a)archlinux.org> --- See https://kanboard.archlinux.org/public/task/40/7359bddc6311e0c07c31e421b6b49… for details. I've left out MAKEFLAGS as I'm unsure how this would actually affect the build. Also the various COMPRESS* options I simply don't know what to do with since we periodically add new ones and this results in updating them all over the place. Plus this isn't typically modified anyway and e.g. multithreaded compression tends to not be reproducible between two identical runs regardless, so I'm not sure we should be solving it... scripts/makepkg.sh.in | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index 548feb91..3d6277d1 100644 --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in @@ -680,7 +680,7 @@ write_pkginfo() { write_buildinfo() { msg2 "$(gettext "Generating %s file...")" ".BUILDINFO" - write_kv_pair "format" "1" + write_kv_pair "format" "2" write_kv_pair "pkgname" "$pkgname" write_kv_pair "pkgbase" "$pkgbase" @@ -699,6 +699,13 @@ write_buildinfo() { write_kv_pair "builddir" "${BUILDDIR}" write_kv_pair "buildenv" "${BUILDENV[@]}" write_kv_pair "options" "${OPTIONS[@]}" + write_kv_pair "cppflags" "$CPPFLAGS" + write_kv_pair "cflags" "$CFLAGS" + write_kv_pair "cxxflags" "$CXXFLAGS" + write_kv_pair "ldflags" "$LDFLAGS" + write_kv_pair "strip_binaries" "$STRIP_BINARIES" + write_kv_pair "strip_shared" "$STRIP_SHARED" + write_kv_pair "strip_static" "$STRIP_STATIC" local pkglist=($(run_pacman -Qq)) local pkginfos="$(LC_ALL=C run_pacman -Qi ${pkglist[@]})" -- 2.18.0

3 5

[pacman-dev] [PATCH v2 1/3] configure: bump the minimum version of bash to 4.4
by Eli Schwartz 12 Jul '18

12 Jul '18

This is required in order to use declare -g and ${var@a} Signed-off-by: Eli Schwartz <eschwartz(a)archlinux.org> --- configure.ac | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index fb9d18e1..6ba9d737 100644 --- a/configure.ac +++ b/configure.ac @@ -193,18 +193,18 @@ AC_DEFUN([AX_PROG_PERL_VERSION], AX_PROG_PERL_VERSION([5.10.1], [], [AC_MSG_ERROR([perl is too old])]) AS_IF([test "x$BASH_SHELL" = "xfalse"], - AC_MSG_WARN([*** bash >= 4.1.0 is required for pacman scripts]), + AC_MSG_WARN([*** bash >= 4.4.0 is required for pacman scripts]), [bash_version_major=`$BASH_SHELL -c 'echo "${BASH_VERSINFO[[0]]}"'` bash_version_minor=`$BASH_SHELL -c 'echo "${BASH_VERSINFO[[1]]}"'` ok=yes if test "$bash_version_major" -lt 4; then ok=no fi - if test "$bash_version_major" -eq 4 && test "$bash_version_minor" -lt 1; then + if test "$bash_version_major" -eq 4 && test "$bash_version_minor" -lt 4; then ok=no fi if test "$ok" = "no"; then - AC_MSG_ERROR([*** bash >= 4.1.0 is required for pacman scripts]) + AC_MSG_ERROR([*** bash >= 4.4.0 is required for pacman scripts]) fi unset bash_version_major bash_version_minor ok]) -- 2.17.1

3 6

[pacman-dev] Add --nolist option for transactions
by me＠dk0.us 09 Jul '18

09 Jul '18

From: Dmitry Kudriavtsev <me(a)dk0.us> Adds a --nolist option for package transactions. This option removes the list display of packages to be installed or removed. Signed-off-by: Dmitry Kudriavtsev <me(a)dk0.us> --- src/pacman/conf.h | 4 +++- src/pacman/pacman.c | 5 +++++ src/pacman/remove.c | 7 +++++-- src/pacman/sync.c | 6 ++++-- 4 files changed, 17 insertions(+), 5 deletions(-) diff --git a/src/pacman/conf.h b/src/pacman/conf.h index ababf2e0..1615d974 100644 --- a/src/pacman/conf.h +++ b/src/pacman/conf.h @@ -50,6 +50,7 @@ typedef struct __config_t { unsigned short help; unsigned short noconfirm; unsigned short noprogressbar; + unsigned short nolist; unsigned short logmask; unsigned short print; unsigned short checkspace; @@ -209,7 +210,8 @@ enum { OP_DOWNLOADONLY, OP_REFRESH, OP_ASSUMEINSTALLED, - OP_DISABLEDLTIMEOUT + OP_DISABLEDLTIMEOUT, + OP_NOLIST }; /* clean method */ diff --git a/src/pacman/pacman.c b/src/pacman/pacman.c index fe54793e..18505bf6 100644 --- a/src/pacman/pacman.c +++ b/src/pacman/pacman.c @@ -204,6 +204,7 @@ static void usage(int op, const char * const myname) addlist(_(" --dbonly only modify database entries, not package files\n")); addlist(_(" --noprogressbar do not show a progress bar when downloading files\n")); addlist(_(" --noscriptlet do not execute the install scriptlet if one exists\n")); + addlist(_(" --nolist do not list packages before performing operation\n")); addlist(_(" -p, --print print the targets instead of performing the operation\n")); addlist(_(" --print-format <string>\n" " specify how the targets should be printed\n")); @@ -652,6 +653,9 @@ static int parsearg_trans(int opt) case OP_ASSUMEINSTALLED: parsearg_util_addlist(&(config->assumeinstalled)); break; + case OP_NOLIST: + config->nolist = 1; + break; default: return 1; } @@ -964,6 +968,7 @@ static int parseargs(int argc, char *argv[]) {"dbonly", no_argument, 0, OP_DBONLY}, {"color", required_argument, 0, OP_COLOR}, {"disable-download-timeout", no_argument, 0, OP_DISABLEDLTIMEOUT}, + {"nolist", no_argument, 0, OP_NOLIST}, {0, 0, 0, 0} }; diff --git a/src/pacman/remove.c b/src/pacman/remove.c index a2269ed8..5df45c69 100644 --- a/src/pacman/remove.c +++ b/src/pacman/remove.c @@ -164,8 +164,11 @@ int pacman_remove(alpm_list_t *targets) } /* print targets and ask user confirmation */ - display_targets(); - printf("\n"); + if(!config->nolist) { + display_targets(); + printf("\n"); + } + if(yesno(_("Do you want to remove these packages?")) == 0) { retval = 1; goto cleanup; diff --git a/src/pacman/sync.c b/src/pacman/sync.c index 3c6be89d..1e0c6c91 100644 --- a/src/pacman/sync.c +++ b/src/pacman/sync.c @@ -793,8 +793,10 @@ int sync_prepare_execute(void) goto cleanup; } - display_targets(); - printf("\n"); + if(!config->nolist) { + display_targets(); + printf("\n"); + } int confirm; if(config->op_s_downloadonly) { -- 2.18.0

5 7

[pacman-dev] interest in using meson over autotools?
by Andreas Baumann 08 Jul '18

08 Jul '18

Hi, Sorry, if this message is a little bit out of order, I only just subscribed to the pacman-dev group. I want to raise the issue of bootstrapping: - automake, autoconf, libtool and friends need m4 and perl and bash - meson needs python Bootstrapping m4 and perl is comparatively easy to bootstrapping python. Porting to other architectures is easier if there are not too many dependencies. See also my experiments here: https://git.archlinux32.org/archlinux32/bootstrap32 and some porting work from oaken-source (Parabola): https://github.com/oaken-source/parabola-riscv64-bootstrap Cheers Andreas -- Andreas Baumann Trottenstrasse 20 CH-8037 Zuerich Telefon: +41(0)76/373 01 29 E-mail: mail(a)andreasbaumann.cc Homepage: www.andreasbaumann.cc

3 3

[pacman-dev] interest in using meson over autotools?
by Dave Reisner 08 Jul '18

08 Jul '18

Hi, I'm probably not the first to suggest that Autotools is slow and terrible, but here it is: Autotools is slow and terrible. Concretely, a few things I find highly annoying about our current use of Autotools: * We have to carry hacks to the build system itself just to ensure that our binaries aren't overlinked. * Data is duplicated across Makefiles -- derived path configurations such as LOCALEDIR or CONFFILE. * Code is duplicated across directories (symlinked to src/common). As a result, we have poor isolation and rebuild the code multiple times. * './configure && make -C src/pacman pacman' fails. It seems absurd that the user at the command line should have to know to build libalpm first. Isn't that the whole point of a dependency-tracking build system? Subjectively, the configuration itself is archaic and verbose. Does anyone *really* want to spend time understanding the quoting semantics of m4, or figure out where things like $ac_cv_sys_file_offset_bits come from? Yes, some of this could be resolved by fixing/rewriting the autotools madness to not use recursive make, but I'd suggest we just drop autotools and adopt meson. Meson can easily fix all of the above. Why meson? * It's fast. I wrote the initial meson.build files to compile libalpm.so and pacman (this took me under an hour). The resulting build takes 1/3 of the time of the equivalent autotools build. The ./configure equivalent in meson will be faster too, but I can't compare that yet because my meson-equivalent is incomplete. Trust me, it'll be faster. * It's modular. You can still constrain lots of subdirectory specifics in subdirectory meson.build files. * It's easy to read. The config is python-ish, and it's very concise. The documentation is comprehensive and has plenty of examples. * There's lots of upstream support, and the community is growing. In Arch Linux, 175 packages are built using meson (largely because gnome has decided to adopt meson). We would not be an early adopter of meson. * It's portable. meson supports all the targets where we currently have actual users. Would there be interest in accepting patches to make these changes? I propose we would carry both build systems in parallel for a major release before eventually dropping autotools. Feedback wanted, dR

5 5

[pacman-dev] [PATCH] makepkg.conf: add missing sha224 sums
by Michael Straube 01 Jul '18

01 Jul '18

Add missing sha224 sums to makepkg.conf and it's man page. Signed-off-by: Michael Straube <michael.straube(a)posteo.de> --- doc/makepkg.conf.5.asciidoc | 2 +- etc/makepkg.conf.in | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/makepkg.conf.5.asciidoc b/doc/makepkg.conf.5.asciidoc index 3b596a91..ec543db8 100644 --- a/doc/makepkg.conf.5.asciidoc +++ b/doc/makepkg.conf.5.asciidoc @@ -183,7 +183,7 @@ Options **INTEGRITY_CHECK=(**check1 ...**)**:: File integrity checks to use. Multiple checks may be specified; this affects both generation and checking. The current valid options are: - `md5`, `sha1`, `sha256`, `sha384`, and `sha512`. + `md5`, `sha1`, `sha224`, `sha256`, `sha384`, and `sha512`. **STRIP_BINARIES=**"--strip-all":: Options to be used when stripping binaries. See linkman:strip[1] diff --git a/etc/makepkg.conf.in b/etc/makepkg.conf.in index 1cf79664..e2f9b5fd 100644 --- a/etc/makepkg.conf.in +++ b/etc/makepkg.conf.in @@ -87,7 +87,7 @@ BUILDENV=(!distcc color !ccache check !sign) # OPTIONS=(strip docs libtool staticlibs emptydirs zipman purge !debug) -#-- File integrity checks to use. Valid: md5, sha1, sha256, sha384, sha512 +#-- File integrity checks to use. Valid: md5, sha1, sha224, sha256, sha384, sha512 INTEGRITY_CHECK=(md5) #-- Options to be used when stripping binaries. See `man strip' for details. STRIP_BINARIES="@STRIP_BINARIES@" -- 2.18.0

1 0

[pacman-dev] Regarding pacman's "No database errors have been found!"-message.
by Peter Krauß 25 Jun '18

25 Jun '18

Hello! I suggest to remove pacman's "No database errors have been found!" message and instead have it replaced by an actual error message in case an error has been found. The expected behavior of pacman is that there are no database errors and thus it's less confusing for users to show the message only in cases of something unexpected happening. Any opinions on this? Cheers, Peter

2 1

[pacman-dev] [PATCH] makepkg: reject PKGBUILDs with both split and non-split package functions
by Eli Schwartz 21 Jun '18

21 Jun '18

We accept package_foo() in non-split packages, because it's easier to switch to/from a split package just by removing a pkgname element. But it makes no sense to have both in one PKGBUILD. Signed-off-by: Eli Schwartz <eschwartz(a)archlinux.org> --- scripts/libmakepkg/lint_pkgbuild/package_function.sh.in | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/scripts/libmakepkg/lint_pkgbuild/package_function.sh.in b/scripts/libmakepkg/lint_pkgbuild/package_function.sh.in index e52f1325..457b8f67 100644 --- a/scripts/libmakepkg/lint_pkgbuild/package_function.sh.in +++ b/scripts/libmakepkg/lint_pkgbuild/package_function.sh.in @@ -34,11 +34,18 @@ lint_package_function() { local i ret=0 if (( ${#pkgname[@]} == 1 )); then - if have_function 'build' && ! { have_function 'package' || have_function "package_$pkgname"; }; then + if have_function 'package' && have_function "package_$pkgname"; then + error "$(gettext "Duplicate %s and %s functions in %s")" "package()" "package_$pkgname()" "$BUILDFILE" + ret=1 + elif have_function 'build' && ! { have_function 'package' || have_function "package_$pkgname"; }; then error "$(gettext "Missing %s function in %s")" "package()" "$BUILDFILE" ret=1 fi else + if have_function "package"; then + error "$(gettext "Extra %s function for split package '%s'")" "package()" "$pkgbase" + ret=1 + fi for i in "${pkgname[@]}"; do if ! have_function "package_$i"; then error "$(gettext "Missing %s function for split package '%s'")" "package_$i()" "$i" -- 2.17.1

2 2

[pacman-dev] pacman 5.1.1 and the "final" makepkg bug
by Allan McRae 21 Jun '18

21 Jun '18

Hi all, I think we are near the point for a pacman-5.1.1 release. My intention is for it to be basically what on master current + the couple of patches in my patchqueue branch. The final thing that needs addressing is: https://bugs.archlinux.org/task/58776 The gist of this bug is makepkg --printsrcinfo was giving entries like "depends = perl>=". We caught these entries because they could be a genuine mistake. It turns out this also happens when the version used requires some bash that calls a function or variable that is not at a global scope. While this is fairly easily worked around, it breaks all perl PKGBUILDs that use the makepkg-template in Arch Linux, and removes the "anything correct bash is OK" mantra of PKGBUILDs. I see some choices here: 1) back out the change 2) partially back out the change 3) "hide" the change 4) document the change For 2), I could see changing the error to a warning, documenting the change and including it for next release. For 3), we could print a warning, then strip these empty "<=" at the end. Note libprovides and libdepends have dynamcially generated versions that are not in --sourceinfo so this would align with them. We should document that limitation. Opinions? (I'm leaning towards #3) Allan

2 2