- Pacman-dev - lists.archlinux.org

[Git][pacman/pacman][master] libmakepkg: do not unset CHOST with !buildflags
by Allan McRae (＠allan) 22 Apr '24

22 Apr '24

Allan McRae pushed to branch master at Pacman / Pacman Commits: 7dcf9a2b by Allan McRae at 2024-04-20T11:37:54+10:00 libmakepkg: do not unset CHOST with !buildflags Also ensure CHOST and MAKEFLAGS are exported. Signed-off-by: Allan McRae <allan(a)archlinux.org> - - - - - 1 changed file: - scripts/libmakepkg/buildenv.sh.in View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/7dcf9a2b49226af8fcb4320… -- This project does not include diff previews in email notifications. View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/7dcf9a2b49226af8fcb4320… You're receiving this email because of your account on gitlab.archlinux.org.

1 0

[Git][pacman/pacman][master] _alpm_archive_fgets(): bail early if reached end of block
by Allan McRae (＠allan) 08 Apr '24

08 Apr '24

Allan McRae pushed to branch master at Pacman / Pacman Commits: 4dc21b96 by Allan McRae at 2024-04-08T10:34:10+00:00 _alpm_archive_fgets(): bail early if reached end of block Bailing early when there are 0 blocks remaining means that we do not call memchr on a NULL string (although with a 0 size parameter). Fixes issues reported using -fsanitise=address,undefined Signed-off-by: Allan McRae <allan(a)archlinux.org> - - - - - 1 changed file: - lib/libalpm/util.c View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/4dc21b965b891042edc951d… -- View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/4dc21b965b891042edc951d… You're receiving this email because of your account on gitlab.archlinux.org.

1 0

[Git][pacman/pacman][master] Add guidelines for managing release branches
by Allan McRae (＠allan) 07 Apr '24

07 Apr '24

Allan McRae pushed to branch master at Pacman / Pacman Commits: 936eff63 by Allan McRae at 2024-04-05T12:02:40+10:00 Add guidelines for managing release branches Signed-off-by: Allan McRae <allan(a)archlinux.org> - - - - - 1 changed file: - RELEASE View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/936eff63bf814ffb95139c7… -- View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/936eff63bf814ffb95139c7… You're receiving this email because of your account on gitlab.archlinux.org.

1 0

[Git][pacman/pacman][master] unlink_file: restore trailing slash on directory before checking mountpoint
by Allan McRae (＠allan) 05 Apr '24

05 Apr '24

Allan McRae pushed to branch master at Pacman / Pacman Commits: f86c15e7 by Allan McRae at 2024-04-05T00:51:13+00:00 unlink_file: restore trailing slash on directory before checking mountpoint The dir_is_mountpoint() function has the explicit requirement that the trailing slash of the directory is present. We strip the trailing slash in unlink_file() to handle directories replaced with symlinks, but that then affects the dir_is_mountpoint() check. Add the trailing slash when we have established we are dealing with a directory. Note this may fail in the case of a file managed by pacmane with name length of PATH_MAX that has been replaced by a directory on the file system. Bail on this unlikely scenario. In addtion, be less fancy with adjusting length of the file char array. Signed-off-by: Allan McRae <allan(a)archlinux.org> - - - - - 1 changed file: - lib/libalpm/remove.c View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/f86c15e7804311df6469e02… -- View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/f86c15e7804311df6469e02… You're receiving this email because of your account on gitlab.archlinux.org.

1 0

[Git][pacman/pacman][master] pacman-key: fix permission checks for non-root operations
by Allan McRae (＠allan) 05 Apr '24

05 Apr '24

Allan McRae pushed to branch master at Pacman / Pacman Commits: 49ebd856 by Allan McRae at 2024-04-05T00:47:45+00:00 pacman-key: fix permission checks for non-root operations Removing lock-never from the default gpg.conf file exposed a couple of bugs in the permission checks in pacman-key. Signed-off-by: Allan McRae <allan(a)archlinux.org> - - - - - 1 changed file: - scripts/pacman-key.sh.in View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/49ebd856ec09b2a7d87d36d… -- View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/49ebd856ec09b2a7d87d36d… You're receiving this email because of your account on gitlab.archlinux.org.

1 0

[Git][pacman/pacman][master] libmakepkg: remove MAKEFLAGS from buildenv_vars
by Allan McRae (＠allan) 05 Apr '24

05 Apr '24

Allan McRae pushed to branch master at Pacman / Pacman Commits: 027ecbc7 by Allan McRae at 2024-04-05T00:43:57+00:00 libmakepkg: remove MAKEFLAGS from buildenv_vars MAKEFLAGS should not be cleared by options=(!buildenv). Regression introduced in commit 09e82f01ea824f9203b0ed7238d98b612669b1a9 Signed-off-by: Allan McRae <allan(a)archlinux.org> - - - - - 1 changed file: - scripts/libmakepkg/buildenv.sh.in View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/027ecbc7b8503b58eb055ad… -- View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/027ecbc7b8503b58eb055ad… You're receiving this email because of your account on gitlab.archlinux.org.

1 0

[Git][pacman/pacman][master] Fix leak in total progress bar
by Allan McRae (＠allan) 05 Apr '24

05 Apr '24

Allan McRae pushed to branch master at Pacman / Pacman Commits: f763ff77 by Allan McRae at 2024-04-05T00:39:29+00:00 Fix leak in total progress bar Signed-off-by: Allan McRae <allan(a)archlinux.org> - - - - - 1 changed file: - src/pacman/callback.c View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/f763ff774a5c3f7db89b010… -- View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/f763ff774a5c3f7db89b010… You're receiving this email because of your account on gitlab.archlinux.org.

1 0

[Git][pacman/pacman][master] Do not pass NULL paramenter to bsearch with empty filelist
by Allan McRae (＠allan) 05 Apr '24

05 Apr '24

Allan McRae pushed to branch master at Pacman / Pacman Commits: 0ccb5842 by Allan McRae at 2024-04-05T00:35:08+00:00 Do not pass NULL paramenter to bsearch with empty filelist A filelist can be non-NULL but empty (particularly with a lot of NoExtract entries). Handle this in alpm_filelist_contains() Identified using the undefined behaviour sanitizer. Signed-off-by: Allan McRae <allan(a)archlinux.org> - - - - - 1 changed file: - lib/libalpm/filelist.c View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/0ccb584262cefdd09674cdf… -- View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/0ccb584262cefdd09674cdf… You're receiving this email because of your account on gitlab.archlinux.org.

1 0

[Git][pacman/pacman][master] Fix typo in cb_progress
by Allan McRae (＠allan) 05 Apr '24

05 Apr '24

Allan McRae pushed to branch master at Pacman / Pacman Commits: 27eba855 by Allan McRae at 2024-04-02T23:18:34+10:00 Fix typo in cb_progress Introduced in 74deada511358a4ce9c10ee0c6ae216e2c6c6b73. Signed-off-by: Allan McRae <allan(a)archlinux.org> - - - - - 1 changed file: - src/pacman/callback.c View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/27eba85594932a6e14faeca… -- View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/27eba85594932a6e14faeca… You're receiving this email because of your account on gitlab.archlinux.org.

1 0

[Git][pacman/pacman][master] 14 commits: Add DownloadUser configuration option
by Allan McRae (＠allan) 02 Apr '24

02 Apr '24

Allan McRae pushed to branch master at Pacman / Pacman Commits: 56eb8728 by Remi Gacogne at 2024-04-01T20:52:55+00:00 Add DownloadUser configuration option The DownloadUser option will be used to drop privledges to the specified user when downloading files. The intention is for this to be extended in the future to a more general sandbox configuration to cover operating on package and database files prior to verification. Add this option to pacman configuration and the various accessors into the libalpm backend. Signed-off-by: Allan McRae <allan(a)archlinux.org> - - - - - ce83cf63 by Remi Gacogne at 2024-04-01T20:52:55+00:00 Provide function for switching user in child processes Add alpm_sandbox_child() function that will be used for switching to a less priviledged user to run child processes. Signed-off-by: Allan McRae <allan(a)archlinux.org> - - - - - 62c68746 by Remi Gacogne at 2024-04-01T20:52:55+00:00 Add callbacks for sandboxed operations Add log and download callbacks to use within a sandbox. These are designed to be passed from the sandbox to the parent through a file descriptor and then processed into alpm callbacks to be passed to the frontend. Note, only callbacks used in libalpm are added. Other callbacks should be set to NULL in the child process. - - - - - 9667bc6b by Allan McRae at 2024-04-01T20:52:55+00:00 Expose _alpm_reset_signals() to library Signed-off-by: Allan McRae <allan(a)archlinux.org> - - - - - 93a796aa by Remi Gacogne at 2024-04-01T20:52:55+00:00 Add sandboxed download for the internal downloader If the SandboxUser configure option is set, the internal downloader will fork of a child process and drop to the specified user to download the files. Signed-off-by: Remi Gacogne <rgacogne(a)archlinux.org> Signed-off-by: Allan McRae <allan(a)archlinux.org> - - - - - cf359b0d by Remi Gacogne at 2024-04-01T20:52:55+00:00 Add support for DownloadUser with XferCommand Signed-off-by: Allan McRae <allan(a)archlinux.org> - - - - - 49d51226 by Remi Gacogne at 2024-04-01T20:52:55+00:00 Document DownloadUser Signed-off-by: Allan McRae <allan(a)archlinux.org> - - - - - 04d04381 by Allan McRae at 2024-04-01T20:52:55+00:00 libalpm: fill in more payload information before passing to downloader Filling in more of the payload fields before passing to the downloader ensures that the these fields do not get lost during sandboxed operations. It also fixes the use of -U with XferCommand, but testsuite still fails due to "404" page being downloaded for the signature. Given we can not identify this as being a non-signature download with the XferCommand, we can just turn off signature checking in this test. Signed-off-by: Allan McRae <allan(a)archlinux.org> - - - - - 26b7b353 by Allan McRae at 2024-04-01T20:52:55+00:00 Remove random_partfile from payload struct It is not used any more due to filling the payload structure earlier. Signed-off-by: Allan McRae <allan(a)archlinux.org> - - - - - 5e9bff62 by Remi Gacogne at 2024-04-01T20:52:55+00:00 Stop trusting the Content-Disposition HTTP header - - - - - 0b6df551 by Andrew Gregory at 2024-04-01T20:52:55+00:00 pactest: Add basic sandboxed download tests Signed-off-by: Allan McRae <allan(a)archlinux.org> - - - - - 11c8eca9 by Andrew Gregory at 2024-04-01T20:52:55+00:00 pactest: test database downloads with optional signatures Signed-off-by: Allan McRae <allan(a)archlinux.org> - - - - - e1a7b83e by Remi Gacogne at 2024-04-01T20:52:55+00:00 Download to a temporary directory owned by the Download user Signed-off-by: Remi Gacogne <rgacogne(a)archlinux.org> Signed-off-by: Allan McRae <allan(a)archlinux.org> - - - - - cfa68f7b by Remi Gacogne at 2024-04-01T20:52:55+00:00 Restore partially downloaded files to the temporary directory This allows downloads to be continued. Signed-off-by: Allan McRae <allan(a)archlinux.org> - - - - - 24 changed files: - doc/pacman.conf.5.asciidoc - lib/libalpm/alpm.h - lib/libalpm/be_sync.c - lib/libalpm/dload.c - lib/libalpm/dload.h - lib/libalpm/handle.c - lib/libalpm/handle.h - lib/libalpm/meson.build - + lib/libalpm/sandbox.c - + lib/libalpm/sandbox.h - lib/libalpm/sync.c - lib/libalpm/util.c - lib/libalpm/util.h - src/pacman/callback.c - src/pacman/conf.c - src/pacman/conf.h - src/pacman/pacman-conf.c - test/pacman/meson.build - + test/pacman/tests/database-refresh-optional-siglevel.py - + test/pacman/tests/sandbox-download-basic.py - + test/pacman/tests/sandbox-download-upgrade.py - test/pacman/tests/upgrade-download-pkg-and-sig-with-filename.py - − test/pacman/tests/upgrade-download-pkg-and-sig-without-filename.py - test/pacman/tests/upgrade-download-with-xfercommand.py View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/compare/01e64e8b6a25f94b13dc92… -- View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/compare/01e64e8b6a25f94b13dc92… You're receiving this email because of your account on gitlab.archlinux.org.

1 0