- Pacman-dev - lists.archlinux.org

[Git][pacman/pacman][master] Fix -D in package()
by Allan McRae (＠allan) 20 Oct '23

20 Oct '23

Allan McRae pushed to branch master at Pacman / Pacman Commits: 917b67f5 by morganamilo at 2023-10-20T22:40:44+01:00 Fix -D in package() When entering fakeroot makepkg calls itself with it's original args causing it to cd again and error - - - - - 1 changed file: - scripts/makepkg.sh.in View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/917b67f5d13c94446d59d32… -- View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/917b67f5d13c94446d59d32… You're receiving this email because of your account on gitlab.archlinux.org.

1 0

[PATCH v3] alpm_run_chroot: Fix the execution of pacman hooks
by Dragan Simic 19 Oct '23

19 Oct '23

Running "pacman -Syyu" to perform a full system update resulted in a rather conspicuous error message in the output of pacman: ( 3/18) Creating temporary files... Assertion 'fd' failed at src/tmpfiles/tmpfiles.c:843, function fd_set_perms(). Aborting. /usr/share/libalpm/scripts/systemd-hook: line 28: 1735 Aborted (core dumped) /usr/bin/systemd-tmpfiles --create error: command failed to execute correctly Expectedly, running "systemd-tmpfiles --create" manually afterwards went just fine and resulted in no errors, leading to a conclusion that executing /usr/share/libalpm/hooks/30-systemd-tmpfiles.hook failed, but only when it was run from within pacman. After a detailed and rather lengthy investigation, it turned out the code in lib/libalpm/util.c that executes the hooks by forking a child has some bugs that allow the error to occur under certain circumstances. In particular, function _alpm_run_chroot() that executes hooks in a fork()ed child does not employ dup2() properly, but instead executes close() followed by dup2(). The man page for dup2() clearly states in the quotation below that attempts to re-implement the equivalent functionality, which is the case in function _alpm_run_chroot(), must be avoided: The dup2() system call performs the same task as dup(), but instead of using the lowest-numbered unused file descriptor, it uses the file descriptor number specified in newfd. In other words, the file descriptor newfd is adjusted so that it now refers to the same open file description as oldfd. If the file descriptor newfd was previously open, it is closed before being reused; the close is performed silently (i.e., any errors during the close are not reported by dup2()). The steps of closing and reusing the file descriptor newfd are performed atomically. This is important, because trying to implement equivalent functionality using close(2) and dup() would be subject to race conditions, whereby newfd might be reused between the two steps. Such reuse could happen because the main program is interrupted by a signal handler that allocates a file descriptor, or because a parallel thread allocates a file descriptor. As a result, a condition can occur in which the file descriptor 0 is closed by calling close(0), and left closed after the while loop that fails to execute dup2() because of receiving EBUSY, resulting in the described issues. Also, failed attempts to execute dup2() should be treated as fatal errors instead of being silently ignored. Let's improve the code to prevent the described issues. While there, perform a minor cleanup as well, to make the formatting of the code a tiny bit more consistent. Signed-off-by: Dragan Simic <dsimic(a)manjaro.org> --- lib/libalpm/util.c | 32 ++++++++++++++++++++++---------- 1 file changed, 22 insertions(+), 10 deletions(-) diff --git a/lib/libalpm/util.c b/lib/libalpm/util.c index dffa3b51..0897c5ea 100644 --- a/lib/libalpm/util.c +++ b/lib/libalpm/util.c @@ -639,28 +639,40 @@ int _alpm_run_chroot(alpm_handle_t *handle, const char *cmd, char *const argv[], if(pid == 0) { /* this code runs for the child only (the actual chroot/exec) */ - close(0); - close(1); - close(2); - while(dup2(child2parent_pipefd[HEAD], 1) == -1 && errno == EINTR); - while(dup2(child2parent_pipefd[HEAD], 2) == -1 && errno == EINTR); - while(dup2(parent2child_pipefd[TAIL], 0) == -1 && errno == EINTR); - close(parent2child_pipefd[TAIL]); close(parent2child_pipefd[HEAD]); close(child2parent_pipefd[TAIL]); + while(dup2(child2parent_pipefd[HEAD], STDERR_FILENO) == -1) { + if(errno != EINTR) { + /* the child cannot talk through the parent at this point, but try yelling anyway */ + fprintf(stderr, _("could not redirect standard error (%s)\n"), strerror(errno)); + exit(1); + } + } + while(dup2(parent2child_pipefd[TAIL], STDIN_FILENO) == -1) { + if(errno != EINTR) { + /* use fprintf() instead of _alpm_log() to send output through the parent */ + fprintf(stderr, _("could not redirect standard input (%s)\n"), strerror(errno)); + exit(1); + } + } + close(parent2child_pipefd[TAIL]); + while(dup2(child2parent_pipefd[HEAD], STDOUT_FILENO) == -1) { + if(errno != EINTR) { + fprintf(stderr, _("could not redirect standard output (%s)\n"), strerror(errno)); + exit(1); + } + } close(child2parent_pipefd[HEAD]); if(cwdfd >= 0) { close(cwdfd); } - /* use fprintf instead of _alpm_log to send output through the parent */ if(chroot(handle->root) != 0) { fprintf(stderr, _("could not change the root directory (%s)\n"), strerror(errno)); exit(1); } if(chdir("/") != 0) { - fprintf(stderr, _("could not change directory to %s (%s)\n"), - "/", strerror(errno)); + fprintf(stderr, _("could not change directory to %s (%s)\n"), "/", strerror(errno)); exit(1); } /* bash assumes it's being run under rsh/ssh if stdin is a socket and

2 5

[Git][pacman/pacman][master] makepkg: Implement the verify function
by Allan McRae (＠allan) 02 Oct '23

02 Oct '23

Allan McRae pushed to branch master at Pacman / Pacman Commits: 331b277e by Morten Linderud at 2023-10-02T05:12:12+00:00 makepkg: Implement the verify function This patch implements a new verify function in makepkg. It allows us to do arbitrary authentication on sources before extraction. There are several new signing and validation methods being implemented and it would be hard to have `makepkg` implement support for things such as sequoia, cosign or minisign. This would allow us to distribute generic validation functions. Signed-off-by: Morten Linderud <morten(a)linderud.pw> - - - - - 4 changed files: - doc/PKGBUILD.5.asciidoc - doc/makepkg.8.asciidoc - scripts/libmakepkg/integrity.sh.in - scripts/makepkg.sh.in View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/331b277eea9cf1be8928986… -- View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/331b277eea9cf1be8928986… You're receiving this email because of your account on gitlab.archlinux.org.

1 0

[Git][pacman/pacman][master] Correct typos in zsh_completion.in
by Allan McRae (＠allan) 02 Oct '23

02 Oct '23

Allan McRae pushed to branch master at Pacman / Pacman Commits: 30f9a2e2 by Felix Yan at 2023-10-02T04:34:24+00:00 Correct typos in zsh_completion.in - - - - - 1 changed file: - scripts/completion/zsh_completion.in View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/30f9a2e263485e23b0ae948… -- View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/30f9a2e263485e23b0ae948… You're receiving this email because of your account on gitlab.archlinux.org.

1 0

[Git][pacman/pacman][master] libalpm: check filecache_find return and log errors
by Allan McRae (＠allan) 30 Sep '23

30 Sep '23

Allan McRae pushed to branch master at Pacman / Pacman Commits: aff12189 by morganamilo at 2023-09-30T13:28:31+00:00 libalpm: check filecache_find return and log errors Some user had erros while updating their system. :: Proceed with installation? [Y/n] :: Retrieving packages... checking keyring... checking package integrity... error: failed to commit transaction (invalid or corrupted package) Errors occurred, no packages were upgraded. The issue was filecache_find returning null and alpm passing that null path to check validity. How this happened I have no idea. It may be something to do with the user's cachedir being a network drive. Also warn when the file exists but it is not a regular file or can not be opened. - - - - - 2 changed files: - lib/libalpm/sync.c - lib/libalpm/util.c View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/aff12189d85d562c39e3708… -- View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/aff12189d85d562c39e3708… You're receiving this email because of your account on gitlab.archlinux.org.

1 0

[Git][pacman/pacman][master] 2 commits: repo-add: do not recreate the database if nothing was changed
by Allan McRae (＠allan) 30 Sep '23

30 Sep '23

Allan McRae pushed to branch master at Pacman / Pacman Commits: f91fa546 by Ivan Shapovalov at 2023-09-30T23:18:41+10:00 repo-add: do not recreate the database if nothing was changed Signed-off-by: Ivan Shapovalov <intelfx(a)intelfx.name> Signed-off-by: Allan McRae <allan(a)archlinux.org> - - - - - 332d2a19 by Allan McRae at 2023-09-30T23:27:04+10:00 repo-add: clarify exit messages Clarify if repo-add does not create a new database due to failures or due to there being nothing to do. Signed-off-by: Allan McRae <allan(a)archlinux.org> - - - - - 1 changed file: - scripts/repo-add.sh.in View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/compare/b4f11d5496a9f638278c89… -- View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/compare/b4f11d5496a9f638278c89… You're receiving this email because of your account on gitlab.archlinux.org.

1 0

[Git][pacman/pacman][master] alpm: test access of symlinks not where they point
by Allan McRae (＠allan) 26 Sep '23

26 Sep '23

Allan McRae pushed to branch master at Pacman / Pacman Commits: b4f11d54 by morganamilo at 2023-09-26T03:37:49+00:00 alpm: test access of symlinks not where they point On platforms that have AT_SYMLINK_NOFOLLOW Fixes FS#69720 - - - - - 1 changed file: - lib/libalpm/util.c View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/b4f11d5496a9f638278c892… -- View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/b4f11d5496a9f638278c892… You're receiving this email because of your account on gitlab.archlinux.org.

1 0

[Git][pacman/pacman][master] Fix unused variable warning
by Allan McRae (＠allan) 20 Sep '23

20 Sep '23

Allan McRae pushed to branch master at Pacman / Pacman Commits: 015cdb21 by morganamilo at 2023-09-20T04:32:21+01:00 Fix unused variable warning - - - - - 1 changed file: - lib/libalpm/add.c View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/015cdb21bd5527706859b7e… -- View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/015cdb21bd5527706859b7e… You're receiving this email because of your account on gitlab.archlinux.org.

1 0

[Git][pacman/pacman][master] tests: fix order of fakechroot + fakeroot nesting
by Allan McRae (＠allan) 19 Sep '23

19 Sep '23

Allan McRae pushed to branch master at Pacman / Pacman Commits: 05f283b5 by Xiretza at 2023-09-19T17:55:24+10:00 tests: fix order of fakechroot + fakeroot nesting As noted in the fakechroot(1) man page, fakeroot and fakechroot might wrap the same C library functions. Arch Linux hit this recently with calls to stat(). It is important to start the fake environment in proper order - fakeroot should be started inside fakechroot. Signed-off-by: Allan McRae <allan(a)archlinux.org> - - - - - 1 changed file: - test/pacman/pmtest.py View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/05f283b5ad8f5b8f995076e… -- View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/05f283b5ad8f5b8f995076e… You're receiving this email because of your account on gitlab.archlinux.org.

1 0

[Git][pacman/pacman][master] Avoid double slash when explicitly passing --root or --rootdir
by Allan McRae (＠allan) 12 Sep '23

12 Sep '23

Allan McRae pushed to branch master at Pacman / Pacman Commits: 34611a66 by Finlay Maroney at 2023-09-12T14:22:36+10:00 Avoid double slash when explicitly passing --root or --rootdir Passing a path with a trailing slash to --root or --rootdir can lead to a double slash at the start of paths. e.g. $ pacman --root / -v 2>1 | grep " //" Log File : //var/log/pacman.log In MSYS2, paths starting with // will hit the network and fail. Avoid this be explicitly stripping the trailing / from paths passed to these flags. Signed-off-by: Allan McRae <allan(a)archlinux.org> - - - - - 1 changed file: - src/pacman/conf.c View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/34611a66436ce259625ba3a… -- View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/34611a66436ce259625ba3a… You're receiving this email because of your account on gitlab.archlinux.org.

1 0