- Pacman-dev - lists.archlinux.org

[pacman-dev] [PATCH] makepkg.conf.5: document option arguments in DLAGENTS need spaces escaped
by Allan McRae 26 Jan '16

26 Jan '16

Fixes FS#43304. Signed-off-by: Allan McRae <allan(a)archlinux.org> --- doc/makepkg.conf.5.txt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/doc/makepkg.conf.5.txt b/doc/makepkg.conf.5.txt index ac5791f..e35eb8a 100644 --- a/doc/makepkg.conf.5.txt +++ b/doc/makepkg.conf.5.txt @@ -39,8 +39,9 @@ Options **DLAGENTS=(**\'protocol::/path/to/command [options]' ...**)**:: Sets the download agents used to fetch source files specified with a URL in the linkman:PKGBUILD[5] file. Options can be specified for each command as - well, and any protocol can have a download agent. Several examples are provided - in the default makepkg.conf. + well, and any protocol can have a download agent. Any spaces in option + arguments are required to be escaped to avoid being split. Several + examples are provided in the default makepkg.conf. + If present, `%u` will be replaced with the download URL. Otherwise, the download URL will be placed on the end of the command. If present, `%o` will -- 2.7.0

1 0

[pacman-dev] [PATCH] PKGBUILD.5: document split package depends are not used during packaging
by Allan McRae 26 Jan '16

26 Jan '16

makepkg only considers global {make,}depends when checking require packages are installed before building. Signed-off-by: Allan McRae <allan(a)archlinux.org> --- doc/PKGBUILD.5.txt | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/doc/PKGBUILD.5.txt b/doc/PKGBUILD.5.txt index 4ff3b02..e410481 100644 --- a/doc/PKGBUILD.5.txt +++ b/doc/PKGBUILD.5.txt @@ -402,6 +402,11 @@ each split package's packaging function: `provides`, `conflicts`, `replaces`, `backup`, `options`, `install`, and `changelog`. +Note that makepkg does not consider split package `depends` when checking +if dependencies are installed before package building and with `--syncdeps`. +All packages required to make the package are required to be specified in +the global `depends` and `makedepends` arrays. + An optional global directive is available when building a split package: *pkgbase*:: -- 2.7.0

1 0

[pacman-dev] [PATCH] zsh_completion: add -q/--quiet for -Q/-S
by genml+pacman-dev＠thequod.de 26 Jan '16

26 Jan '16

From: Daniel Hahler <git(a)thequod.de> This should also be added for "-Fh", but that is missing completely in zsh_completion. 1: https://lists.archlinux.org/pipermail/pacman-dev/2015-November/020538.html Signed-off-by: Daniel Hahler <git(a)thequod.de> --- contrib/zsh_completion.in | 2 ++ 1 file changed, 2 insertions(+) diff --git a/contrib/zsh_completion.in b/contrib/zsh_completion.in index 0db26b2..58d409a 100644 --- a/contrib/zsh_completion.in +++ b/contrib/zsh_completion.in @@ -65,6 +65,7 @@ _pacman_opts_query_modifiers=( {-l,--list}'[List package contents]' {-m,--foreign}'[List installed packages not found in sync db(s)]' {-n,--native}'[List installed packages found in sync db(s)]' + {-q,--quiet}'[Show less information for query and search]' {-t,--unrequired}'[List packages not required by any package]' {-u,--upgrades}'[List packages that can be upgraded]' ) @@ -104,6 +105,7 @@ _pacman_opts_sync_modifiers=( {\*-i,\*--info}'[View package information]' {-l,--list}'[List all packages in a repository]' {-p,--print}'[Print download URIs for each package to be installed]' + {-q,--quiet}'[Show less information for query and search]' {\*-u,\*--sysupgrade}'[Upgrade all out-of-date packages]' {-w,--downloadonly}'[Download packages only]' {\*-y,\*--refresh}'[Download fresh package databases]' -- 2.6.4

3 3

[pacman-dev] [PATCH] makepkg: do not run prepare() and pkgver() with --repackage
by Allan McRae 26 Jan '16

26 Jan '16

Bug introduced with commit 8454daa7. Reported-by: Zuyi Hu <hzy068808(a)gmail.com> Signed-off-by: Allan McRae <allan(a)archlinux.org> --- scripts/makepkg.sh.in | 40 +++++++++++++++++++++------------------- 1 file changed, 21 insertions(+), 19 deletions(-) diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index 753621b..80b95f4 100644 --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in @@ -2192,28 +2192,30 @@ mkdir -p "$srcdir" chmod a-s "$srcdir" cd_safe "$srcdir" -if (( NOEXTRACT && ! VERIFYSOURCE )); then - warning "$(gettext "Using existing %s tree")" "\$srcdir/" -elif (( !REPKG )); then - download_sources - check_source_integrity - (( VERIFYSOURCE )) && exit 0 # $E_OK +if (( !REPKG )); then + if (( NOEXTRACT && ! VERIFYSOURCE )); then + warning "$(gettext "Using existing %s tree")" "\$srcdir/" + else + download_sources + check_source_integrity + (( VERIFYSOURCE )) && exit 0 # $E_OK - if (( CLEANBUILD )); then - msg "$(gettext "Removing existing %s directory...")" "\$srcdir/" - rm -rf "$srcdir"/* - fi + if (( CLEANBUILD )); then + msg "$(gettext "Removing existing %s directory...")" "\$srcdir/" + rm -rf "$srcdir"/* + fi - extract_sources -fi + extract_sources + fi -if (( PKGVERFUNC )); then - update_pkgver - basever=$(get_full_version) - check_build_status -fi -if (( PREPAREFUNC )); then - run_prepare + if (( PKGVERFUNC )); then + update_pkgver + basever=$(get_full_version) + check_build_status + fi + if (( PREPAREFUNC )); then + run_prepare + fi fi if (( NOBUILD )); then -- 2.7.0

2 2

[pacman-dev] Fix/enforce PATH with makepkg (required for Python packages)
by Daniel Hahler 25 Jan '16

25 Jan '16

Usually Python packages use `python` in their PKGBUILD, which results in any activated virtualenv to be used, e.g. from `pep257`: ``` package() { cd "${srcdir}/${pkgname}-${pkgver}" python setup.py install --root="${pkgdir}" --optimize=1 install -m 755 -d "${pkgdir}/usr/share/licenses/${pkgname}" install -m 644 -t "${pkgdir}/usr/share/licenses/${pkgname}" LICENSE-MIT } ``` Activating a virtualenv will add the "python" binary in front of $PATH. I've reported this initially for pacaur at https://github.com/rmarquis/pacaur/issues/400, but it's a problem with makepkg after all. I am using this workaround in /etc/xdg/pacaur/config currently: PATH=/usr/bin:$PATH Cheers, Daniel.

2 4

[pacman-dev] [PATCH] Remove spacing when outputting package sizes
by Allan McRae 25 Jan '16

25 Jan '16

This spacing appears to have been added to align sizes. It sometimes worked... $ pacman -Si glibc | grep Size Download Size : 8.03 MiB Installed Size : 35.08 MiB And it sometimes failed... $ pacman -Si pacman | grep Size Download Size : 662.82 KiB Installed Size : 4045.00 KiB Remove the spaces for a consistent output. Signed-off-by: Allan McRae <allan(a)archlinux.org> --- src/pacman/package.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/pacman/package.c b/src/pacman/package.c index 23dfc27..ac47493 100644 --- a/src/pacman/package.c +++ b/src/pacman/package.c @@ -275,10 +275,10 @@ void dump_pkg_full(alpm_pkg_t *pkg, int extra) size = humanize_size(alpm_pkg_get_size(pkg), '\0', 2, &label); if(from == ALPM_PKG_FROM_SYNCDB) { - printf("%s%s%s %6.2f %s\n", config->colstr.title, titles[T_DOWNLOAD_SIZE], + printf("%s%s%s %.2f %s\n", config->colstr.title, titles[T_DOWNLOAD_SIZE], config->colstr.nocolor, size, label); } else if(from == ALPM_PKG_FROM_FILE) { - printf("%s%s%s %6.2f %s\n", config->colstr.title, titles[T_COMPRESSED_SIZE], + printf("%s%s%s %.2f %s\n", config->colstr.title, titles[T_COMPRESSED_SIZE], config->colstr.nocolor, size, label); } else { /* autodetect size for "Installed Size" */ @@ -286,7 +286,7 @@ void dump_pkg_full(alpm_pkg_t *pkg, int extra) } size = humanize_size(alpm_pkg_get_isize(pkg), label[0], 2, &label); - printf("%s%s%s %6.2f %s\n", config->colstr.title, titles[T_INSTALLED_SIZE], + printf("%s%s%s %.2f %s\n", config->colstr.title, titles[T_INSTALLED_SIZE], config->colstr.nocolor, size, label); string_display(titles[T_PACKAGER], alpm_pkg_get_packager(pkg), cols); -- 2.7.0

1 1

[pacman-dev] pacman-5.0:Should pkgver() and prepare() run when repackage?
by Zuyi Hu 25 Jan '16

25 Jan '16

I am using the pacman's latest master branch, when I run 'makepkg -R' to repackage packages, it will run pkgver() and prepare(), if there are some patch command in prepare(), it will fail. should pkgver() and prepare() run when repackage? This problem may be introduced by this commit: https://projects.archlinux.org/pacman.git/commit/?id=8454daa7feef14b660561f… An ugly working patch is: diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index 753621b..57302a0 100644 --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in @@ -2207,12 +2207,12 @@ elif (( !REPKG )); then extract_sources fi -if (( PKGVERFUNC )); then +if (( PKGVERFUNC && !REPKG )); then update_pkgver basever=$(get_full_version) check_build_status fi -if (( PREPAREFUNC )); then +if (( PREPAREFUNC && !REPKG )); then run_prepare fi

3 3

[pacman-dev] pacman-5.0:error run updpkgsums when there is source_i686 or source_x86_64 in PKGBUILD
by Zuyi Hu 25 Jan '16

25 Jan '16

I am using the pacman's latest master branch,When I run updpkgsums when there is source_i686 or source_x86_64 in PKGBUILD. it will complain: /usr/share/makepkg/lint_pkgbuild/variable.sh: line 60: declare: sha512sums: not found ==> ERROR: sha512sums_i686 should be an array /usr/share/makepkg/lint_pkgbuild/variable.sh: line 60: declare: source: not found ==> ERROR: source_i686 should be an array /usr/share/makepkg/lint_pkgbuild/variable.sh: line 60: declare: sha512sums: not found ==> ERROR: sha512sums_x86_64 should be an array /usr/share/makepkg/lint_pkgbuild/variable.sh: line 60: declare: source: not found ==> ERROR: source_x86_64 should be an array ==> ERROR: Failed to generate new checksums for example, you can use nvidia's PKGBUILD in extra repo, and try run updpkgsums. I think this bug is introduced by this commit: https://projects.archlinux.org/pacman.git/commit/?id=23f128ad5e2b26733376d1… a simple workaround patch is: diff --git a/scripts/libmakepkg/lint_pkgbuild/variable.sh.in b/scripts/libmakepkg/lint_pkgbuild/variable.sh.in index 4943c50..183e740 100644 --- a/scripts/libmakepkg/lint_pkgbuild/variable.sh.in +++ b/scripts/libmakepkg/lint_pkgbuild/variable.sh.in @@ -57,7 +57,7 @@ lint_variable() { v="${i}_${a}" eval "keys=(\"\${!${v}[@]}\")" if (( ${#keys[*]} > 0 )); then - if [[ "$(declare -p $i)" != "declare -a "* ]]; then + if [[ "$(declare -p $v)" != "declare -a "* ]]; then error "$(gettext "%s_%s should be an array")" "$i" "$a" ret=1 fi

2 1

[pacman-dev] Redundant spaces in package information.
by Viacheslav Chimishuk 21 Jan '16

21 Jan '16

Hi there. I have noticed that pacman package information output has a redundant spaces. Let me show you an example. $ pacman -Qi pacman | grep Install Installed Size : 3.95 MiB Install Date : Tue 27 Oct 2015 03:46:31 PM EET Install Reason : Explicitly installed Install Script : No [vchimishuk@latitude pixel-submitter] $ As you can most of lines have only one space after ':' character, but "Installed Size" has three spaces. It depends of the size value itself. Here is a code that prints the line: printf("%s%s%s %6.2f %s\n", config->colstr.title, titles[T_INSTALLED_SIZE], config->colstr.nocolor, size, label); My question is next. Why do we need "6." here? It will works just fine without this extra space formatting. Is this is a bug or feature? :) Best regards, Viacheslav.

3 5

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v4.2.1-312-gad65462
by allan＠archlinux.org 17 Jan '16

17 Jan '16

1 0