- Pacman-dev - lists.archlinux.org

[pacman-dev] [PATCH] makepkg: avoid expansion of var in arithmetic context
by Dave Reisner 30 Dec '14

30 Dec '14

This bombs out when "$trusted" expands to the empty string. We're better off passing the var by name and letting bash default to "0" when the var is empty Fixes: https://bugs.archlinux.org/task/43269 --- Written against maint, naturally. scripts/makepkg.sh.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index 18b2822..1cd8756 100644 --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in @@ -1498,7 +1498,7 @@ check_pgpsigs() { esac errors=1 else - if (( ${#validpgpkeys[@]} == 0 && ! $trusted )); then + if (( ${#validpgpkeys[@]} == 0 && !trusted )); then printf "%s ($(gettext "the public key %s is not trusted"))" $(gettext "FAILED") "$fingerprint" >&2 errors=1 elif (( ${#validpgpkeys[@]} > 0 )) && ! in_array "$fingerprint" "${validpgpkeys[@]}"; then -- 2.2.1

1 0

[pacman-dev] [PATCH 1/2] makepkg: respect package depends for dep checks
by Dave Reisner 29 Dec '14

29 Dec '14

Include package-specific and arch-specific dependencies when checking dependencies prior to the build. Fixes: https://bugs.archlinux.org/task/42191 --- scripts/makepkg.sh.in | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index 0db9912..6565809 100644 --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in @@ -2537,6 +2537,22 @@ pkgbuild_get_attribute() { fi } +pkgbuild_get_all_for_arch() { + # $1: attribute name + # $2: architecture + # $3: output variable + local pkg __all l + + array_build __all "$1" + for pkg in "${pkgname[@]}"; do + pkgbuild_get_attribute "$pkg" "$1" 1 l && __all+=("${l[@]}") + pkgbuild_get_attribute "$pkg" "$1_$2" 1 l && __all+=("${l[@]}") + done + + mapfile -t __all < <(printf '%s\n' "${__all[@]}" | awk '!_[$0]++') + array_build "$3" __all +} + lint_pkgbase() { if [[ ${pkgbase:0:1} = "-" ]]; then error "$(gettext "%s is not allowed to start with a hyphen.")" "pkgname" @@ -3626,7 +3642,8 @@ else deperr=0 msg "$(gettext "Checking runtime dependencies...")" - resolve_deps ${depends[@]} || deperr=1 + pkgbuild_get_all_for_arch 'depends' "$CARCH" all_deps + resolve_deps "${all_deps[@]}" || deperr=1 if (( RMDEPS && INSTALL )); then original_pkglist=($(run_pacman -Qq)) # required by remove_dep -- 2.2.1

3 3

[pacman-dev] [PATCH] Fix typo in a comment in makepkg.conf
by Jason St. John 29 Dec '14

29 Dec '14

Signed-off-by: Jason St. John <jstjohn(a)purdue.edu> --- etc/makepkg.conf.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/etc/makepkg.conf.in b/etc/makepkg.conf.in index 9ed7ef9..19f673d 100644 --- a/etc/makepkg.conf.in +++ b/etc/makepkg.conf.in @@ -19,7 +19,7 @@ DLAGENTS=('ftp::/usr/bin/curl -qfC - --ftp-pasv --retry 3 --retry-delay 3 -o %o # /usr/bin/lftpget -c # /usr/bin/wget -#-- The the package required by makepkg to download VCS sources +#-- The package required by makepkg to download VCS sources # Format: 'protocol::package' VCSCLIENTS=('bzr::bzr' 'git::git' -- 2.2.1

1 0

[pacman-dev] [PATCH 1/1] libalpm: add version information to alpm.h
by Christian Hesse 29 Dec '14

29 Dec '14

From: Christian Hesse <mail(a)eworm.de> Programs linked against libalpm (for example packagekit) may want to use preprocessor macros to check version and choose correct API. This adds version information to alpm.h. Signed-off-by: Christian Hesse <mail(a)eworm.de> --- lib/libalpm/alpm.h | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/lib/libalpm/alpm.h b/lib/libalpm/alpm.h index 91b9461..e3f6e67 100644 --- a/lib/libalpm/alpm.h +++ b/lib/libalpm/alpm.h @@ -23,6 +23,14 @@ #ifndef _ALPM_H #define _ALPM_H +#define ALPM_VERSION "9.0.0" + +#define ALPM_VERSION_MAJOR 9 +#define ALPM_VERSION_MINOR 0 +#define ALPM_VERSION_PATCH 0 + +#define ALPM_VERSION_NUMBER 0x090000 + #ifdef __cplusplus extern "C" { #endif -- 2.2.1

3 3

[pacman-dev] [PATCH 0/9] refactor ini/config parser
by Andrew Gregory 29 Dec '14

29 Dec '14

As the first step to back-end hook support, this patchset makes the ini parser suitable for sharing between alpm and pacman by moving all error handling from the ini parser to the _parse_directive callback. This involves: * moving debug output to the callback * allowing empty section names (alpm already rejects empty db names) * moving Include handling to the callback * notifying the callback of read errors In order to do that I also refactored the config callback to use only a single pass by storing repo information until alpm is initialized and using bitmasks instead of the ALPM_SIG_*_SET enums to handle siglevel inheritance. apg Andrew Gregory (9): conf.c: store repo settings in dedicated struct conf.c: use masks for siglevel inheritance conf.c: parse config in a single pass ini.c: remove final callback call ini.c: move Include parsing to conf.c ini.c: remove unnecessary helper function ini.c: remove empty section name restriction ini.c: remove useless key check ini.c: move error output into conf.c lib/libalpm/alpm.h | 3 - lib/libalpm/be_sync.c | 2 +- src/pacman/conf.c | 304 ++++++++++++++++++++++++++++---------------------- src/pacman/conf.h | 16 +++ src/pacman/ini.c | 147 ++++-------------------- 5 files changed, 208 insertions(+), 264 deletions(-) -- 1.9.2

3 22

[pacman-dev] [PATCH] makepkg-template: Remove linenumber/file from errors
by Florian Pritz 28 Dec '14

28 Dec '14

die prints "at $scriptname line $linenumber." if the string does not end with "\n". This information is not of much use for us and it makes testing harder because we'd to remove it there. Signed-off-by: Florian Pritz <bluewind(a)xinu.at> --- scripts/makepkg-template.pl.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/makepkg-template.pl.in b/scripts/makepkg-template.pl.in index d9da167..4bfd4d6 100755 --- a/scripts/makepkg-template.pl.in +++ b/scripts/makepkg-template.pl.in @@ -109,7 +109,7 @@ sub load_template { my ($version) = (abs_path($path) =~ /-([0-9.]+)[.]template$/); if (!$version) { - die sprintf(gettext("Couldn't detect version for template '%s'"), $values->{name}); + die sprintf(gettext("Couldn't detect version for template '%s'\n"), $values->{name}); } my $parsed = process_file($path); @@ -128,7 +128,7 @@ sub process_file { my $nesting_level = 0; my $linenumber = 0; - open (my $fh, "<", $filename) or die sprintf(gettext("failed to open '%s': %s"), $filename, $!); + open (my $fh, "<", $filename) or die sprintf(gettext("failed to open '%s': %s\n"), $filename, $!); my @lines = <$fh>; close $fh; -- 2.2.1

1 0

[pacman-dev] [PATCH 1/5] Split install reason changing into its own function
by Allan McRae 28 Dec '14

28 Dec '14

Prepare for other functions to be added to the --database option. Signed-off-by: Allan McRae <allan(a)archlinux.org> --- src/pacman/database.c | 22 ++++++++++++++++++---- 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/src/pacman/database.c b/src/pacman/database.c index e858e0c..dac0ab1 100644 --- a/src/pacman/database.c +++ b/src/pacman/database.c @@ -35,11 +35,12 @@ * * @return 0 on success, 1 on failure */ -int pacman_database(alpm_list_t *targets) +static int change_install_reason(alpm_list_t *targets) { alpm_list_t *i; alpm_db_t *db_local; - int retval = 0; + int ret = 0; + alpm_pkgreason_t reason; if(targets == NULL) { @@ -68,7 +69,7 @@ int pacman_database(alpm_list_t *targets) if(!pkg || alpm_pkg_set_reason(pkg, reason)) { pm_printf(ALPM_LOG_ERROR, _("could not set install reason for package %s (%s)\n"), pkgname, alpm_strerror(alpm_errno(config->handle))); - retval = 1; + ret = 1; } else { if(reason == ALPM_PKG_REASON_DEPEND) { printf(_("%s: install reason has been set to 'installed as dependency'\n"), pkgname); @@ -82,7 +83,20 @@ int pacman_database(alpm_list_t *targets) if(trans_release() == -1) { return 1; } - return retval; + return ret; +} + + +int pacman_database(alpm_list_t *targets) +{ + int ret = 0; + + if(config->flags & (ALPM_TRANS_FLAG_ALLDEPS | ALPM_TRANS_FLAG_ALLEXPLICIT)) { + ret = change_install_reason(targets); + return ret; + } + + return ret; } /* vim: set noet: */ -- 2.2.1

1 4

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v4.2.0-51-gf1e010a
by allan＠archlinux.org 28 Dec '14

28 Dec '14

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, master has been updated via f1e010a5a7c562da02a74ffb043520760db49ba3 (commit) via 29c0d8233b32ab3ad1dcd7c3bf1161449a386dea (commit) via 4c4890dd1cad52a420788e6c30a8e6eca8f83c38 (commit) via 2759858e8c784dbce6fd60bf032efe96b40a9032 (commit) via acc639adf20da077ed6f0141289d953997be92f8 (commit) from 6356567ae0fb9927c80811642e7d949270fd5784 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f1e010a5a7c562da02a74ffb043520760db49ba3 Author: Andrew Gregory <andrew.gregory.8(a)gmail.com> Date: Tue Dec 23 16:16:08 2014 -0500 add tap_ prefix to test helper functions Allows tap.sh to show the line number where the helper function was called on failures. Signed-off-by: Andrew Gregory <andrew.gregory.8(a)gmail.com> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 29c0d8233b32ab3ad1dcd7c3bf1161449a386dea Author: Andrew Gregory <andrew.gregory.8(a)gmail.com> Date: Tue Dec 23 16:09:58 2014 -0500 use tap.sh for bash tests tap.sh is a reusable TAP library that handles test counting and provides useful diagnostic messages on test failures. Signed-off-by: Andrew Gregory <andrew.gregory.8(a)gmail.com> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 4c4890dd1cad52a420788e6c30a8e6eca8f83c38 Author: Allan McRae <allan(a)archlinux.org> Date: Mon Nov 24 15:45:27 2014 +1000 Clarify "assume installed" error message The error message on failing to add an "assume installed" entry to the backend was not clear. Clarify by making "assume-installed" none translatable and adding a hyphen to match calling flag. Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 2759858e8c784dbce6fd60bf032efe96b40a9032 Merge: 6356567 acc639a Author: Allan McRae <allan(a)archlinux.org> Date: Sun Dec 28 13:06:04 2014 +1000 Merge branch 'maint' ----------------------------------------------------------------------- Summary of changes: Makefile.am | 2 +- scripts/makepkg.sh.in | 7 +- src/pacman/conf.c | 2 +- test/scripts/human_to_size_test.sh | 73 ++++++----------- test/scripts/parseopts_test.sh | 100 ++++++++--------------- test/tap.sh | 163 +++++++++++++++++++++++++++++++++++++ test/util/pacsorttest.sh | 90 ++++++++------------ test/util/vercmptest.sh | 151 +++++++++++++--------------------- 8 files changed, 318 insertions(+), 270 deletions(-) create mode 100644 test/tap.sh hooks/post-receive -- The official pacman repository

1 0

[pacman-dev] [GIT] The official pacman repository branch, maint, updated. v4.2.0-13-gacc639a
by allan＠archlinux.org 28 Dec '14

28 Dec '14

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, maint has been updated via acc639adf20da077ed6f0141289d953997be92f8 (commit) from 5221440b6bd0520762026a24abdde50d60552f99 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit acc639adf20da077ed6f0141289d953997be92f8 Author: Allan McRae <allan(a)archlinux.org> Date: Sat Dec 27 23:20:36 2014 +1000 Fix .SRCINFO output with architecture specific fields Do not merge the architecture specific fields when creating a .SRCINFO file. Signed-off-by: Allan McRae <allan(a)archlinux.org> ----------------------------------------------------------------------- Summary of changes: scripts/makepkg.sh.in | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) hooks/post-receive -- The official pacman repository

1 0

[pacman-dev] [PATCH 1/3] add vim modeline to test files
by Andrew Gregory 27 Dec '14

27 Dec '14

Signed-off-by: Andrew Gregory <andrew.gregory.8(a)gmail.com> --- test/scripts/human_to_size_test.sh | 2 ++ test/scripts/parseopts_test.sh | 2 ++ test/util/pacsorttest.sh | 2 ++ test/util/vercmptest.sh | 2 ++ 4 files changed, 8 insertions(+) diff --git a/test/scripts/human_to_size_test.sh b/test/scripts/human_to_size_test.sh index dfa01f7..2dacfd1 100755 --- a/test/scripts/human_to_size_test.sh +++ b/test/scripts/human_to_size_test.sh @@ -80,3 +80,5 @@ parse_hts '1M' 1048576 parse_hts ' 1 G ' 1073741824 parse_hts '1Q' '' + +# vim: set noet: diff --git a/test/scripts/parseopts_test.sh b/test/scripts/parseopts_test.sh index 2c055b1..97679c4 100755 --- a/test/scripts/parseopts_test.sh +++ b/test/scripts/parseopts_test.sh @@ -140,3 +140,5 @@ parse '--force --' 2 --force # exact match on possible stem (opt has optarg) parse '--clean foo --' 3 --clean=foo + +# vim: set noet: diff --git a/test/util/pacsorttest.sh b/test/util/pacsorttest.sh index 49d6d8e..a29d8f1 100755 --- a/test/util/pacsorttest.sh +++ b/test/util/pacsorttest.sh @@ -133,3 +133,5 @@ fi echo "# $failure of $run tests failed" exit 1 + +# vim: set noet: diff --git a/test/util/vercmptest.sh b/test/util/vercmptest.sh index 9032cbf..ba279a7 100755 --- a/test/util/vercmptest.sh +++ b/test/util/vercmptest.sh @@ -151,3 +151,5 @@ fi echo "# $failure of $run tests failed" exit 1 + +# vim: set noet: -- 2.2.1

2 6