- Pacman-dev - lists.archlinux.org

[pacman-dev] [PATCH 1/3] checkupdates: show error when fakeroot is missing
by Evangelos Foutras 19 Dec '14

19 Dec '14

--- contrib/checkupdates.sh.in | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/contrib/checkupdates.sh.in b/contrib/checkupdates.sh.in index f4f36c0..a3a308b 100644 --- a/contrib/checkupdates.sh.in +++ b/contrib/checkupdates.sh.in @@ -21,6 +21,9 @@ declare -r myname='checkupdates' declare -r myver='@PACKAGE_VERSION@' +m4_include(../scripts/library/output_format.sh) +m4_include(../scripts/library/term_colors.sh) + if (( $# > 0 )); then echo "${myname} (pacman) v${myver}" echo @@ -32,6 +35,11 @@ if (( $# > 0 )); then exit 0 fi +if ! type -P fakeroot >/dev/null; then + error 'Cannot find the fakeroot binary.' + exit 1 +fi + if [[ -z $CHECKUPDATES_DB ]]; then CHECKUPDATES_DB="${TMPDIR:-/tmp}/checkup-db-${USER}/" fi -- 2.2.0

1 2

[pacman-dev] [PATCH] BUG: Fix realloc of 0 bytes
by tredaelli＠archlinux.info 19 Dec '14

19 Dec '14

From: Timothy Redaelli <timothy.redaelli(a)gmail.com> realloc with size == 0 can return NULL, and passing NULL to qsort will cause a SEGFAULT (CERT MEM04-C) --- lib/libalpm/be_local.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/libalpm/be_local.c b/lib/libalpm/be_local.c index 93763966..a734eba3 100644 --- a/lib/libalpm/be_local.c +++ b/lib/libalpm/be_local.c @@ -790,6 +790,9 @@ static int local_db_read(alpm_pkg_t *info, alpm_dbinfrq_t inforeq) memcpy(files[files_count].name, line, len); files_count++; } + if (files_count == 0) { + continue; + } /* attempt to hand back any memory we don't need */ files = realloc(files, sizeof(alpm_file_t) * files_count); /* make sure the list is sorted */ -- 2.2.0

2 1

[pacman-dev] [GIT] The official pacman repository annotated tag, v4.2.0, created. v4.2.0
by allan＠archlinux.org 19 Dec '14

19 Dec '14

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The annotated tag, v4.2.0 has been created at ef4df5595cce55fae35b3b6c068726a8460a2b87 (tag) tagging 565c931e2c684d4460ff65cbec9b097ee1d8f94d (commit) replaces v4.1.2 tagged by Allan McRae on Fri Dec 19 14:33:23 2014 +1000 - Log ----------------------------------------------------------------- One last bugfix -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAABCAAGBQJUk6qTAAoJEPmf/g/q6Zm9Q1IH/AiF8diW4fLfPL8ZmXgyGt+v XNydV660YfOl7BsxQNIz5rSD+zBXmFfF8eVOiarN05uvYzdhLNLKhC6079ZouI8g 8SwG8XWN1JlWshfn5yQt30uLygbudbOaBY1iD43025zCc/hXOseyFSBMPDy+aNAD LkdqXBGPdg7ZNXrIheE0g2cVGk0ZjYMQY8qrwSJg/pb4nU/i4/ewGfTtumJqzLOQ cWvf3elIWNFGAK39UpzZTw/+bGh+X5iG+v/I++zU8Y48TPJcpfwFlH3cnvYbr3lf xWqshf+u8cUOq4qVvqIyJRk79B8asKxrq4BL0+Lx8QEoNe88tEJOf3nJvDJ6MBA= =/rP6 -----END PGP SIGNATURE----- Aaron Lindsay (1): contrib: Unify quoting in error messages Allan McRae (119): Merge branch 'maint' Merge branch 'maint' makepkg: remove sourcing PKGBUILD from stdin makepkg: Add helper to test for functions in build script makepkg: remove support for PKGBUILDs without a package() function Clean partial downloads from cache Improve error message when package is missing required signature Merge branch 'maint' Document alpm_list files are to be stand alone paccache: make --help output look nice on 80 width terminal Merge branch 'maint' Merge branch 'maint' update to automake 1.14 Add missing header Hide unused parameter warnings when building without libcurl Remove autotools files Update gitignore files for use with autoreconf Use autoreconf in autogen.sh Patch ltmain on autoreconf Remove autoclean.sh Carry a copy of gpgme.m4 Clarify inter-conflicts message Fix typo Only note backup file changes with -Qkk Warn when directory ownership differs between filesystem and package Remove setlocale usage from the backend Report missing directory if we can not initialise alpm library Do not refer to FlySpray numbers Store fgetc output as an int. Clarify --repackage description Use $srcdir/ rather than src/ in makepkg help Remove makepkg license check Ignore failure to patch during autogen.sh Link non-vcs sources into $srcdir during extraction makepkg: do not refer to src/ or pkg/ makepkg: alphabetically order option variables makepkg: run locally with libtool style wrapper makepkg: add LIBRARY variable Report which package is missing a signature Fix progress bar overflow while checking package integrity proto: remove missed $srcdir redundancies contrib/pacdiff: error if diffprog is not found makepkg: use source_safe when resourcing BUILDFILE Ensure packages have a valid version Make functions to decode a signature and extract keyid public List signiture keyids in -Sii output Fix detection of joint --native and --foreign usage makepkg.8: document environmental variables that affect gpg signing makepkg.8: Document remaining environmental variables repo-add.8: Provide example usage Expose alpm_pkg_should_ignore Indicate ignored packages in -Qu output makepkg: do not allow badly formatted arch lines makepkg: Allow "static library" to be translated makepkg: only remove static libraries if they have a shared version Return zero from extract_file with local source file makepkg: move update_pkgver out of extract_sources Ignore makedepend and checkdepend entries when parsing .PKGINFO file paccache: clarify help output .gitignore: Add intl directory. Color output from pm_vasprintf Fix pactest README Fix build warnings with --disable-nls Update comment for local db entry creation Copy validation field in _alpm_pkg_dup Update copyright years for 2014 Fix build with --disable-gpgme Consistently use #ifdef HACKING: mention tab size and line width Consistently use 'directory' instead of 'folder' makepkg: Fix typo in variable name makepkg: remove unneeded "|| true" Give groups display text singular and plural forms Fix warnings with strict-overflow in gcc-4.9 Fix install order in scripts Makefile Use MALLOC throughtout libalpm makepkg: Remove --asroot option makepkg: enforce fakeroot usage makepkg: sign source packages with --sign Always supply base name and version info in .PKGFILE if needed repo-add: declare pkgbase as local Do not check makepkg-wrapper for standard options makepkg: Force buildscripts to be in startdir Clarify that -Ql prints a file list Add compatibility with gpgme-1.5.0 Use C locale for bsdtar calls during package creation Revert refactoring in fa0c1e14 makepkg: handle "epoch=" in PKGBUILD with pkgver function Add validpgpkeys to PKGBUILD prototypes. pacdiff: allow DIFFPROG to contain commandline options makepkg: ensure vcs download tool are installed when required makepkg: skip dependency checking with --verifysource Add Andrew to maintainers list. Update PKGBUILD documentation for removed override options pacman-key: stricter parsing for -verify Create local database directory if it is missing Add version file when creating local database directory Add version file to empty local database Check the version of the local database during validation There are not hooks! makepkg: improve stripping pkgdesc of whitespace for .PKGINFO makepkg: bzr: update existing sources in srcdir without removing them first. Fix crash when using external downloader Remove logging of NoExtract events makepkg: symlink files in noextract into $srcdir _alpm_backup_dup: fix memory leak in error case extract_single_file: fix memory leak in error condition Add alpm_option_match_noextract Do not warn about missing files in NoExtract Pull translation updates from Transifex Update po files to send to Transifex Fix translation error and remove empty po files checkupdates: do not print ignored packages Remove pacsysclean pacman-db-upgrade: fix issue with find argument list length overflow Update README for pacman-4.2 Update NEWS for pacman-4.2 release Update translations from transifex Release 4.2.0 Andrea Scarpino (1): Respect paths with spaces on --install Andrew DeMaria (1): makepkg: pass "--nocolor" to pacman Andrew Gregory (160): makepkg: remove extra ansi color codes pmpkg: default mode 0755 for dirs in sync packages util.py: replace file() with open() conflict.c: compare package pointers directly pmtest: set LC_ALL=C in subprocess.call add.c: refactor backup file modification checks pacman.8: document .pacorig files update tests for symlink support removal alpm_filelist: remove resolved_path conflict.c: do not ignore symlink<->dir conflicts conflict.c: exclude trailing slash from file path conflict.c: check for file -> dir replacements extract_single_file: consolidate symlink cases unlink_file: treat symlinks like normal files query_fileowner: remove symlink support improve dir->file transition conflict resolution die if '-' is given with empty stdin deps.c: check for indirect deps when ordering skip unknown repo names for pacman -Sl query_group: allow package filters query_fileowner: remove useless path variable query_fileowner: resolve trailing . or .. in paths use full path when checking for mountpoints query006: only set expectfailure on 32-bit systems convert test scripts to tap output pactest: treat unknown rules as failures convert pactest to TAP output provide default values for test scripts pactest: accept test names without a switch integrate tests with automake pactest: remove results summary conf.c: add parse_options to section_t conf.c: move repo parsing out of _parseconfig conf.c: move directive parsing out of _parseconfig conf.c: move section handling out of _parseconfig conf.c: pass _parse_directive as a callback conf.c: extract ini parsing code to separate files ini.c: reuse line buffer ini.c: make errors in includes fatal ini.c: give recursion limit file scope check.c: break backup file search loop after match conflict.c: fix directory ownership check Fix make distcheck TESTS: add missing tests Add make target for TESTS Makefile.am: remove old targets from .PHONY remove executable bit on paclog-pkglist.sh.in submitting-patches: address common mistakes pacman/util: remove strsplit use non-ascii identifiers for optflags imply --print from --print-format do not run scriptlets with --dbonly rename PKG_LOCALITY_LOCAL -> PKG_LOCALITY_NATIVE pacman: die on invalid option combinations include invalid options in error messages sortbydeps: include local pkgs in dep graph makepkg: allow empty source arrays libalpm/db.c: default to ALPM_DB_USAGE_ALL callback.c: check for negative xfered size check for -1 return value from getopt_long deps.c: pass alpm_list** to _alpm_recursedeps upgrade.c: use iterator variable support ALPM_SIG_USE_DEFAULT for file siglevels alpm_handle: store lock file descriptor Makefile.am: fix typo in LOG_DRIVER variable log important events from the backend alpm_sync_sysupgrade: skip packages being removed db.c: require unique database names remove useless continue trans_prepare: always sort trans->remove by deps conf.c: add missing newline to warning deps.c: remove filtered_depend functions valgrind.supp: suppress leak in gpgme_get_key check_keyring: plug memory leak create_verbose_row: free malloc'd strings Makefile.am: move test-suite.log into test/ package.h: convert scriptlet field to int base64.c: comment out unused variable sync_prepare: treat from_sync as a boolean pacman.c: remove unnecessary optarg checks pacman.c: free string commandline options valgrind.supp: add fakeroot/fakechroot errors pmtest: send valgrind output to var/log/valgrind pmtest: use --gen-suppression=all with valgrind pmtest: use valgrind --child-silent-after-fork enable_colors: always set color strings pacman: use exit status 0 for --help and --version local_db_populate: initialize empty pkgcache dump_pkg_full: fix optionalfor memory leak sync_prepare: manually set pm_errno _alpm_resolvedeps: free targ inside loop table_display: free memory on errors pmrule: add FILE_EMPTY rule pmtest: add memory check to tests with valgrind alpm: export *_free functions _alpm_sync_prepare: fix unresolvable packages leak restrict transaction package origins pmpkg.py: remove unused imports pactest: add prefix to temporary directory sync_prepare: ignore explicitly removed conflicts simplify check for leading "local/" remove check for unused ALPM_ERR_PKG_IGNORED check config_new return value conf.c: remove extra indentation register_syncdb: reject db names that contain / pmdb.py: change siglevel name to Required pactest: treat arguments as files instead of globs remove.c: downgrade TRANS_DUP_TARGET to warning use monotonic clock for progress updates filelist_intersection: manually compare paths pactest: parse options before environment setup pactest: check for pacman binary before running pactest: check for tests before environment setup add test for file type check with -Qk move _alpm_lstat into util-common llstat: modify path in place check_file_exists: replace lstat with llstat check_pkg_fast: check file type sync_prepare: remove useless check for replacers handle: factor out string list option handling pactest: only snapshot needed files pactest: delay test object creation dep_graph_init: filter ignored packages by name deps.c: use alpm_list_find_ptr signing.c: remove useless error check handle_unlock: log lock removal failure handle_unlock: log error when lock file is missing pacman.c: simplify stdin parsing sync.c: fix style violations replace strdup with STRDUP trans_commit: log beginning and end of transaction fix improper FREELIST calls pacman-db-upgrade: use pacman-style options Extend database upgrade script to handle alpm db version 9 alpm.h: remove outdated pkg_get_backup doxygen wrap fgets to retry on EINTR pacman: set SA_RESTART for signal handler Revert "Remove log_cb, add ALPM_EVENT_LOG instead" avoid line wrapping if not in a tty or COLUMNS=0 table_display: only check width when non-zero remove retry check from signature validation check_keyring: skip keys known to be missing _alpm_key_in_keychain: cache known keys pacman-db-upgrade: do not mangle file lists pmdb: include directories in package file lists pmrule: make backup file test more robust pmtest: allow tests to specify db version pacman: add --confirm option pmtest: allow tests to specify test binary sync.c: download packages before starting commit add pacman-db-upgrade test testdb: ignore ALPM_DB_VERSION pacman-db-upgrade: fix --config option typo pmtest: make test paths easily available to tests tests/pacman-db-upgrade-v9: set additional paths add pacman-db-upgrade-v9.py to check_SCRIPTS makepkg: do not strip bzr+ from bzr+ssh urls makepkg: only strip vcs prefixes from front of url add alpm_option_match_noupgrade remove.c: honor inverted patterns in noupgrade Ashley Whetter (2): Install makedepends and checkdepends together Corrected return codes for Sg flag Christian Hesse (6): dload: avoid renaming files downloaded via sync operations libalpm: check for valid public key algorithm be_sync: use effective URL for db file signature download dload: use better error message on exceeded file size dload: unlink file on filesize exceeded error dload: mark final_url as const Connor Behan (2): Unify front and backend responses for --print Remove ALPM_QUESTION_LOCAL_NEWER Dan McGee (8): Clear up definition of INFRQ_ALL Push down testing .gitignore entries Remove -fgnu89-inline from compile options Log more in search debug message Use O_CLOEXEC as much as possible when opening files Minor struct member reordering for packing concerns Reorder and reshape the package struct for better packing Fix compile warnings on systems without getmntent Dave Reisner (61): makepkg: avoid file|grep dependency for CRLF check do not check error from close(2) be_sync: avoid crashing on files in the root of a DB makepkg: allow make-style environment var overrides alpm: log errors for scriptlets terminated by a signal makepkg.8: fix typo in usage makepkg: unify list of known hash algorithms makepkg: add support for sha224 checksums proto: remove redundancy in cd for each function libalpm: introduce a usage level for repos pacman: add front end support for repo usage level pactree: set full usage on DBs when registering makepkg: cleanup a few format string injections makepkg: inline creation of checksum indenting makepkg: always use read's -r flag with filenames makepkg: use c-style for loops for integrity checks autogen.sh: remove useless shell flag and subshells makepkg: validate updated pkgver before replacement version: fix formatting in file to RPM upstream dload: allow curl to response to any auth challenge strtrim: reset pointer after trimming leading whitespace dload: avoid using CURLOPT_FAILONERROR cache terminal size, add SIGWINCH handler to reset makepkg: improve check and error message for buildfile location remove --destination-dir argument from a2x options makepkg: disallow pkgver/pkgrel/epoch overrides in packages makepkg: refactor check_sanity, give it some sanity of its own PKGBUILD: handle arch specific attributes makepkg: replace bare eval with var extraction functions PKGBUILD(5): arch-specific fields are always additional paccache: read default cachedir from pacman.conf updpkgsums: use a throwaway build dir makepkg: use correct terminology makepkg: let --source imply --ignorearch makepkg: disallow values of 'arch' which might be problematic makepkg: break out check_checksums to reasonably sized functions makepkg: break out checksum generation to its own function PKGBUILD: add support for arch-specific sources updpkgsums: update to recognize arch-specific sources makepkg: abort if we can't add install/changelog to package makepkg: move negation in inequality comparisons makepkg: allow less than the full fingerprint in validpgpkeys Revert "makepkg: allow less than the full fingerprint in validpgpkeys" makepkg: show full fingerprint on pgp failure makepkg: simplify attr matching in extract_function_var makepkg: reorder args to pkgbuild_get_attribute for consistency makepkg: always look for sources in source=() paccache: avoid spurious blank line written to stderr makepkg.8: fix typo in reference to other flag updpkgsums: avoid exec'ing awk, so the trap actually works bash_completion: add --noarchive to makepkg's completions makepkg.8: remove superfluous "::" in envvar description makepkg: ignore empty global attributes in extraction makepkg: simplify epoch handling makepkg: introduce .SRCINFO files for source packages version: fix memory leak in early return pacsort: parse inputs up front into control struct makepkg: correctly add changelog files shut up GCC on -Wmaybe-initialized warnings updpkgsums: drop in-place rewrite hack, use a tempfile updpkgsums: add more error checking before replacement Eric Bélanger (1): Add --noprepare option to makepkg Eric Schultz (1): Exit with 0/SUCCESS if there are no packages to remove Eric Toombs (1): Added list of mandatory options to PKGBUILD's man page Florian Pritz (20): Add makepkg-template makepkg-template: Add gettext support makepkg-template: Stop using given/when makepkg-template: add --version and some license info Display old and new version in pacman -Qu output pacman -Si/-Qi: Autodetect best fitting file size unit Remove ts and sw from vim modeline when noet is set Check if a file is in the package's file list before extracting util: Add _alpm_realloc() and _alpm_greedy_grow() be_package: Refactor handling of simple path checks be_package: Refactor code adding a file to the files list be_package: Build the file list from MTREE if possible be_local: Use alpm_greedy_grow util: Use off_t instead of int for size values Add test case for the perl 5.20 dependency breakage deps.c: split _alpm_depcmp into _alpm_depcmp_provides libalpm: export alpm_splitdep as alpm_dep_from_depstring and alpm_dep_free Add --assume-installed option Add --assume-installed to pacman --help Add --assume-installed to shell completion Hong Shick Pak (1): Move break to a new line for consistency Jason St. John (25): Quote sources in PKGBUILD prototypes and example PKGBUILD Update example PKGBUILD Revise PKGBUILD(5) Revise pacman(8) Fix whitespace in pacsort.c and pactree.c Fix whitespace in makepkg.sh.in and makepkg-template.pl.in Improve --help switch output for pacman utils Use title case for a heading in HACKING; fix capitalization of "Vim" in HACKING Remove spaces between the opening "if" and the opening parenthesis Fix minor grammatical issues in doc/index.txt Fix whitespace and other formatting issues Fix typo in pacman-optimize Replace "echo" command with "printf" in human_to_size_test.sh Improve --help switch output for pacman contrib and pacman scripts pacscripts: Improve error message when sudo binary is not found Fix misspellings and some grammar issues in output of some pacman contrib scripts Add missing optdepends to the main list of variables in the split PKGBUILD prototype proto: Remove recommendation of "makepkg -g" in comments makepkg.conf(5): Add missing backticks around vars, and use single quotes around "gpg" command Remove ChangeLog.proto and move important info to PKGBUILD(5) makepkg.conf(5): Fix and improve grammar and spelling issues pacman(8): Improve grammar and quoting man: Use uniform line spacing between sections man: Improve grammar and add missing single quotes around command options pkgdelta(8): Fix broken example of --min-pkg-size with human-readable values Jeremy Heiner (9): Jettison the truncation of the display of pmrules. Bail early with a clear error message if Python runtime isn't 2.7+. Use "exec" instead of "execfile" (deprecated in Python 3). Use Python's "0o#" octal literal instead of deprecated "0#". Use dict iteration methods common to both Python 2 and 3. Use Python's "range" instead of deprecated "xrange". Add parens around tuples in Python list comprehensions. Use the 'configure'd PYTHON to run pactest. Add the unit tests for -Qk and -Qkk that are possible now. Johannes Löthberg (3): makepkg: Remove redundant sig generation comment makepkg: Respect XDG_CONFIG_HOME pacman.c: Add -gg, -ii, and -yy to help summary Jonathan Frazier (9): pacdiff: Add quit to found pacnew options pacdiff: Search and give warnings for older pacsave.[0-9]* files pacdiff: clean up and reword --help pacdiff: allow multiple separated options pacdiff: add --nocolor option for the terminally challenged. pacdiff: rework search type handling, add --find option pacdiff: improve speed, accuracy finding active configs using pacmandb pacdiff: make pacmandb search the default type. pacdiff: provide an --output option to show any .pac* files Lars Gustäbel (1): Prevent makepkg creating armored signatures Lukáš Jirkovský (5): Add a -C, --cleanbuild option to clear the source directory before building a package. makepkg: git: update existing sources in srcdir without removing them first. makepkg: checkout a revision specified in SVN fragment in download_svn. makepkg: hg: update existing sources in srcdir without removing them first. makepkg: svn: update existing sources in srcdir without removing them first. Matthias Krüger (1): note that TotalDownload and XferCommand are incompatible. Maxim Andersson (2): paccache: add support for multiple cachedirs paccache: parse_filename bug fix Maxime Arthaud (1): makepkg: fix check for distcc Maxime Gauduin (1): Add PKGBUILD-vcs.proto Micah Saint Germain (1): Fix pointer declarations to be globally consistent Miguel de Val-Borro (4): doc/translation-help.txt: Remove link to tutorial on sarovar.org doc/translation-help.txt: Minor rewording of Transifex usage doc/translation-help.txt: Removed out-of-date paragraph doc/translation-help.txt: Transifex example usage Olivier Brunel (15): Make --unrequired filter packages that are optdep as well doc/repo-add: Add note on when signatures are added to the db alpm: Rename a variable for future clarity pacman: Fix delayed warnings/errors sent to stdout not stderr Rename ALPM_EVENT_OPTDEP_REQUIRED to _OPTDEP_REMOVAL Update the event callback Remove log_cb, add ALPM_EVENT_LOG instead Add events ALPM_EVENT_RETRIEVE_{DONE, FAILED} Add events _PKGDOWNLOAD_{START, DONE, FAILED} Add events on pacnew/pacsave/pacorig file creation alpm.h: Move alpm_errno_t definition up Update the question callback events: Make alpm_event_t an union of all event-specific struct Fix loading invalid package alpm: Fix wrong xferred/total sizes when resuming downloads Patrick Steinhardt (2): Install unchanged backup files to get correct timestamps. Enable inverted patterns in NoExtract and NoUpgrade. Phillip Smith (2): makepkg: add support for CARCH environment var repo-add; add option to remove existing package files from disk Pierre Neidhardt (18): pacsearch: Copyright year bump pacsearch: more accurate help message pacsearch: localized output pacsearch: Explicitly extract group information pacsearch: colors are portable (ANSI) and have natural variable names pacsearch: using pacman color theme pacsearch: CLI option to turn off colors pactree: removed 'provision' from linear output pacsearch: removed useless comment pacsearch: indexing by 'name version' instead of 'name' pacsearch: removed redundant sorting pacsearch: fields are treated uniformly when printing pacsearch: pattern arguments work as for pacman pacsearch: factored -Ss and -Qs parts into one single function makepkg.8: Fix typo makepkg: Comment on install_package() return code makepkg: Add a --noarchive option to inhibit archive creation makepkg: Reorder some entries in usage() and getopts Rafael Ferreira (1): Do not remove source code references in PO/POT files Ryo Munakata (1): filecache_find_url: dereference the 'filebase' pointer Sami Kerola (3): common: compare value rather than pointer address libalpm: avoid name space conflict pacman/util.c: use switch when there are fall through statements Silvan Jegen (5): Remove unneeded NULL check Another unneeded NULL check removed Another NULL check removed Move NULL check before dereference pacman: Correct signal handler comment and refactor Simon Gomizelj (1): Consolidate and improve table implementations Steven Noonan (2): makepkg: implement support for stripping kernel modules makepkg: use dash instead of underscore in /usr/lib/debug/.build-id Sébastien Luttringer (1): makepkg: fix consistency of downloaded sources permissions Sören Brinkmann (3): pacman/upgrade: Check malloc() return value pacman/upgrade: Refactor memory management pacman/upgrade: Fix memory leaks Thomas Bächler (4): makepkg: Support kernel.org's PGP signature scheme makepkg: Use read to parse status file during signature verification. makepkg: Treat a signature from an untrusted key as an error makepkg: Introduce validpgpkeys array Tobias Powalowski (1): pacman-key: compatibility with gnupg-2.1 Vasiliy Korchagin (1): pacdiff: do not remove pacfile after viewing Vladimir A. Nazarenko (1): Use getuid instead of geteuid William Giokas (1): makepkg: Allow using sources with :: in them Wolfgang Bumiller (2): Close file descirptor before fork replace --reference on chmod/chown commands Xyne (5): bacman: pass unshifted arguments to fakeroot bacman: update copyright information in version function bacman: optionally include unmodified backup files when available makepkg: include all hash types in integlist makepkg: redirect downloader output to STDERR Zulker Nayeen Nahiyan (1): clarified descriptions for pactree -r (--help) lolilolicon (1): makepkg: do not eval dlcmd slavomir vlcek (1): libalpm: move function pointer condition ----------------------------------------------------------------------- hooks/post-receive -- The official pacman repository

1 0

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v4.1.2-519-g565c931
by allan＠archlinux.org 19 Dec '14

19 Dec '14

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, master has been updated via 565c931e2c684d4460ff65cbec9b097ee1d8f94d (commit) from bc6ada0877010891e5c2336fd5c1242047e6a7a5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 565c931e2c684d4460ff65cbec9b097ee1d8f94d Author: Dave Reisner <dreisner(a)archlinux.org> Date: Thu Dec 18 23:20:22 2014 -0500 updpkgsums: add more error checking before replacement Re-add some paranoia which was inadvertently lost with 768b65e934. In case 'makepkg -g' fails to generate new sums (e.g. when a remote resource cannot be fetched), or awk fails to write the new file (i have no idea when this would happen), bail out with an error. Signed-off-by: Allan McRae <allan(a)archlinux.org> ----------------------------------------------------------------------- Summary of changes: contrib/updpkgsums.sh.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- The official pacman repository

1 0

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v4.1.2-518-gbc6ada0
by allan＠archlinux.org 19 Dec '14

19 Dec '14

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, master has been updated via bc6ada0877010891e5c2336fd5c1242047e6a7a5 (commit) from 54db3745d6890aba44fbe251aeae42a1938767d2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit bc6ada0877010891e5c2336fd5c1242047e6a7a5 Author: Allan McRae <allan(a)archlinux.org> Date: Fri Dec 19 13:57:21 2014 +1000 Release 4.2.0 Signed-off-by: Allan McRae <allan(a)archlinux.org> ----------------------------------------------------------------------- Summary of changes: configure.ac | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) hooks/post-receive -- The official pacman repository

1 0

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v4.1.2-517-g54db374
by allan＠archlinux.org 19 Dec '14

19 Dec '14

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, master has been updated via 54db3745d6890aba44fbe251aeae42a1938767d2 (commit) from 14dc3389fdaf520b0d9adb8e6b5d441163889519 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 54db3745d6890aba44fbe251aeae42a1938767d2 Author: Allan McRae <allan(a)archlinux.org> Date: Fri Dec 19 13:53:35 2014 +1000 Update translations from transifex Signed-off-by: Allan McRae <allan(a)archlinux.org> ----------------------------------------------------------------------- Summary of changes: lib/libalpm/po/LINGUAS | 1 + lib/libalpm/po/ar.po | 45 +- lib/libalpm/po/ast.po | 456 +++++++++---- lib/libalpm/po/bg.po | 246 ++++++- lib/libalpm/po/ca.po | 57 +- lib/libalpm/po/cs.po | 56 +- lib/libalpm/po/da.po | 53 +- lib/libalpm/po/de.po | 60 +- lib/libalpm/po/el.po | 87 ++- lib/libalpm/po/en_GB.po | 54 +- lib/libalpm/po/es.po | 91 ++- lib/libalpm/po/eu.po | 249 ++++++- lib/libalpm/po/fi.po | 57 +- lib/libalpm/po/fr.po | 57 +- lib/libalpm/po/gl.po | 59 +- lib/libalpm/po/hr.po | 61 +- lib/libalpm/po/hu.po | 64 +- lib/libalpm/po/id.po | 57 +- lib/libalpm/po/it.po | 57 +- lib/libalpm/po/ja.po | 54 +- lib/libalpm/po/kk.po | 111 ++-- lib/libalpm/po/ko.po | 56 +- lib/libalpm/po/{libalpm.pot => ko_KR.po} | 80 ++- lib/libalpm/po/lt.po | 54 +- lib/libalpm/po/nb.po | 55 +- lib/libalpm/po/nl.po | 57 +- lib/libalpm/po/pl.po | 59 +- lib/libalpm/po/pt.po | 60 +- lib/libalpm/po/pt_BR.po | 55 +- lib/libalpm/po/ro.po | 50 +- lib/libalpm/po/ru.po | 73 +-- lib/libalpm/po/sk.po | 56 +- lib/libalpm/po/sl.po | 59 +- lib/libalpm/po/sr.po | 46 +- lib/libalpm/po/sr(a)latin.po | 46 +- lib/libalpm/po/sv.po | 44 +- lib/libalpm/po/tr.po | 58 +- lib/libalpm/po/uk.po | 57 +- lib/libalpm/po/ur.po | 238 ++++++- lib/libalpm/po/uz.po | 239 ++++++- lib/libalpm/po/vi.po | 246 ++++++- lib/libalpm/po/zh_CN.po | 52 +- lib/libalpm/po/zh_TW.po | 142 ++-- scripts/po/LINGUAS | 3 + scripts/po/ar.po | 156 ++--- scripts/po/ast.po | 876 ++++++++++++++++++++----- scripts/po/bg.po | 762 +++++++++++++++++++--- scripts/po/ca.po | 281 +++----- scripts/po/cs.po | 309 ++++----- scripts/po/da.po | 269 +++----- scripts/po/de.po | 355 ++++------ scripts/po/el.po | 343 ++++------ scripts/po/en_GB.po | 302 ++++----- scripts/po/es.po | 352 ++++------ scripts/po/eu.po | 741 ++++++++++++++++++--- scripts/po/fi.po | 268 +++----- scripts/po/fr.po | 320 ++++----- scripts/po/gl.po | 247 ++----- scripts/po/hr.po | 185 +++--- scripts/po/hu.po | 311 ++++----- scripts/po/id.po | 320 ++++----- scripts/po/it.po | 295 ++++----- scripts/po/ja.po | 301 ++++----- scripts/po/kk.po | 160 ++--- scripts/po/ko.po | 254 +++----- scripts/po/{pacman-scripts.pot => ko_KR.po} | 136 ++-- scripts/po/lt.po | 247 ++----- scripts/po/nb.po | 310 ++++----- scripts/po/{pacman-scripts.pot => nl.po} | 225 +++---- scripts/po/pacman-scripts.pot | 78 +-- scripts/po/pl.po | 361 +++++------ scripts/po/pt.po | 316 ++++----- scripts/po/pt_BR.po | 331 ++++------ scripts/po/ro.po | 249 ++----- scripts/po/ru.po | 259 +++----- scripts/po/sk.po | 306 ++++----- scripts/po/sl.po | 494 +++++++------- scripts/po/sr.po | 243 ++----- scripts/po/sr(a)latin.po | 243 ++----- scripts/po/sv.po | 252 ++------ scripts/po/tr.po | 319 ++++----- scripts/po/uk.po | 307 ++++----- scripts/po/uz.po | 705 ++++++++++++++++++-- scripts/po/zh_CN.po | 294 +++------ scripts/po/{ar.po => zh_TW.po} | 965 ++++++++++++++-------------- src/pacman/po/LINGUAS | 2 + src/pacman/po/ar.po | 124 ++-- src/pacman/po/ast.po | 529 ++++++++++++--- src/pacman/po/bg.po | 498 ++++++++++++-- src/pacman/po/ca.po | 171 +++-- src/pacman/po/cs.po | 173 +++-- src/pacman/po/da.po | 169 +++-- src/pacman/po/de.po | 261 ++++---- src/pacman/po/el.po | 188 +++--- src/pacman/po/en_GB.po | 156 ++--- src/pacman/po/eo.po | 76 +-- src/pacman/po/es.po | 277 ++++---- src/pacman/po/eu.po | 497 ++++++++++++-- src/pacman/po/fa.po | 45 +- src/pacman/po/fi.po | 164 +++-- src/pacman/po/fr.po | 179 +++--- src/pacman/po/gl.po | 386 ++++++----- src/pacman/po/hr.po | 141 ++-- src/pacman/po/hu.po | 171 +++-- src/pacman/po/id.po | 167 +++-- src/pacman/po/it.po | 172 +++-- src/pacman/po/ja.po | 195 +++--- src/pacman/po/kk.po | 338 +++++----- src/pacman/po/ko.po | 152 ++--- src/pacman/po/{pacman.pot => ko_KR.po} | 52 +- src/pacman/po/lt.po | 139 ++-- src/pacman/po/nb.po | 169 +++-- src/pacman/po/nl.po | 181 +++--- src/pacman/po/pacman.pot | 24 +- src/pacman/po/pl.po | 171 +++-- src/pacman/po/pt.po | 175 +++-- src/pacman/po/pt_BR.po | 170 +++-- src/pacman/po/ro.po | 144 ++--- src/pacman/po/ru.po | 205 +++--- src/pacman/po/sk.po | 171 +++-- src/pacman/po/sl.po | 193 +++--- src/pacman/po/sr.po | 143 ++--- src/pacman/po/sr(a)latin.po | 143 ++--- src/pacman/po/sv.po | 138 ++-- src/pacman/po/tr.po | 174 +++-- src/pacman/po/uk.po | 174 +++-- src/pacman/po/ur.po | 458 +++++++++++-- src/pacman/po/uz.po | 468 ++++++++++++-- src/pacman/po/{pacman.pot => vi.po} | 52 +- src/pacman/po/zh_CN.po | 152 ++--- src/pacman/po/zh_TW.po | 284 ++++---- 131 files changed, 14321 insertions(+), 12854 deletions(-) copy lib/libalpm/po/{libalpm.pot => ko_KR.po} (85%) copy scripts/po/{pacman-scripts.pot => ko_KR.po} (94%) copy scripts/po/{pacman-scripts.pot => nl.po} (91%) copy scripts/po/{ar.po => zh_TW.po} (61%) copy src/pacman/po/{pacman.pot => ko_KR.po} (97%) copy src/pacman/po/{pacman.pot => vi.po} (97%) hooks/post-receive -- The official pacman repository

1 0

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v4.1.2-516-g14dc338
by allan＠archlinux.org 19 Dec '14

19 Dec '14

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, master has been updated via 14dc3389fdaf520b0d9adb8e6b5d441163889519 (commit) via c9e9c1ccfda919146a7f456a240e2287d9fc63fe (commit) via 3af0268fdbafbeb0a2e45d3555ef9d224d89c29d (commit) via df36fe2e79d5a5490b89c259bef7a1f150cff575 (commit) via 768b65e93472914c52cc1159c4932d4fc1438c14 (commit) via 16259d728e87c10533cd24f88aa7127fff48db2b (commit) via 0cd174efd5065dca26fcce180d853fe6323d3e12 (commit) via a4b23417f9868e14fddf0e6f35e57ba05f029623 (commit) via c54af84180d76c1d5c9febdae930dfe5379d7db5 (commit) from ed4032a90813ba29ee11c71ac6af3090d96789ce (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 14dc3389fdaf520b0d9adb8e6b5d441163889519 Author: Allan McRae <allan(a)archlinux.org> Date: Thu Dec 18 21:54:43 2014 +1000 Update NEWS for pacman-4.2 release Signed-off-by: Allan McRae <allan(a)archlinux.org> commit c9e9c1ccfda919146a7f456a240e2287d9fc63fe Author: Allan McRae <allan(a)archlinux.org> Date: Thu Dec 18 17:20:58 2014 +1000 Update README for pacman-4.2 Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 3af0268fdbafbeb0a2e45d3555ef9d224d89c29d Author: Andrew Gregory <andrew.gregory.8(a)gmail.com> Date: Sat Nov 29 18:02:56 2014 -0500 remove.c: honor inverted patterns in noupgrade Signed-off-by: Andrew Gregory <andrew.gregory.8(a)gmail.com> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit df36fe2e79d5a5490b89c259bef7a1f150cff575 Author: Andrew Gregory <andrew.gregory.8(a)gmail.com> Date: Sat Nov 29 18:02:55 2014 -0500 add alpm_option_match_noupgrade For parity with alpm_option_match_noextract. Signed-off-by: Andrew Gregory <andrew.gregory.8(a)gmail.com> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 768b65e93472914c52cc1159c4932d4fc1438c14 Author: Dave Reisner <dreisner(a)archlinux.org> Date: Sun Dec 14 13:45:06 2014 -0500 updpkgsums: drop in-place rewrite hack, use a tempfile This apparently exposes (what I think is) a subtle bug in cygwin's handling of subst'd drives. Let's just drop the hackery and use a tempfile, which should always work. Also, introduce a proper die() function which replaces previous hand-rolled error+exit pattern, but which wrote to stdout. Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 16259d728e87c10533cd24f88aa7127fff48db2b Author: Dave Reisner <dreisner(a)archlinux.org> Date: Sun Dec 14 12:35:00 2014 -0500 shut up GCC on -Wmaybe-initialized warnings Admittedly, these are totally bogus, but a clean build is a happy build. Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 0cd174efd5065dca26fcce180d853fe6323d3e12 Author: Dave Reisner <dreisner(a)archlinux.org> Date: Sun Dec 14 12:35:01 2014 -0500 makepkg: correctly add changelog files Before this, we'd see bizzare behavior of: -> Adding changelog file (systemd.install)... And, changelog files in the global section would not be added at all. The code is clearly wrong here, as it references 'install' within a loop of 'changelog' and 'install'. Let's use parameter indirection to ensure that the proper file is identified and added. Signed-off-by: Allan McRae <allan(a)archlinux.org> commit a4b23417f9868e14fddf0e6f35e57ba05f029623 Author: Micah Saint Germain <micah(a)lexme.org> Date: Sun Dec 14 21:01:22 2014 -0500 Fix pointer declarations to be globally consistent Refactored inconsistent pointer declarations to better improve consistency throughout the pacman codebase which will, in turn, increase readability to the user. Expected format of a pointer declaration: `typename *varname` Signed-off-by: Micah Saint Germain <micah(a)lexme.org> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit c54af84180d76c1d5c9febdae930dfe5379d7db5 Author: Miguel de Val-Borro <miguel(a)archlinux.net> Date: Sat Nov 29 19:32:55 2014 -0500 doc/translation-help.txt: Transifex example usage Replace harcoded language code in example Signed-off-by: Miguel de Val-Borro <miguel(a)archlinux.net> Signed-off-by: Allan McRae <allan(a)archlinux.org> ----------------------------------------------------------------------- Summary of changes: NEWS | 81 +++++++++++++++++++++++++++++++++ README | 53 +++++++++++++++++++++ contrib/updpkgsums.sh.in | 37 +++++++++------ doc/translation-help.txt | 4 +- lib/libalpm/alpm.h | 1 + lib/libalpm/handle.c | 5 ++ lib/libalpm/remove.c | 4 +- scripts/makepkg.sh.in | 2 +- src/pacman/callback.h | 2 +- src/pacman/conf.c | 2 +- src/pacman/pacman.c | 13 +++--- src/pacman/sync.c | 2 +- src/util/pactree.c | 2 +- test/pacman/tests/TESTS | 1 + test/pacman/tests/noupgrade-inverted.py | 19 ++++++++ 15 files changed, 198 insertions(+), 30 deletions(-) create mode 100644 test/pacman/tests/noupgrade-inverted.py hooks/post-receive -- The official pacman repository

1 0

[pacman-dev] [PATCH] Update NEWS for pacman-4.2 release
by Allan McRae 18 Dec '14

18 Dec '14

Signed-off-by: Allan McRae <allan(a)archlinux.org> --- NEWS | 81 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 81 insertions(+) diff --git a/NEWS b/NEWS index 02148d3..723664e 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,86 @@ VERSION DESCRIPTION ----------------------------------------------------------------------------- +4.2.0 - symlinks to directories on the filesystem are no longer + treated as directories + - pacman-db-upgrade - fix local database for files installed + into directory symlinks + - added --assume-installed option to help upgrades where not all + installed packages have been rebuilt + - --unrequired now filters needed optdepends too. Use twices + to only filter direct dependencies + - improved dependency resolving ensures correct ordering when + installing updates (FS#32764) + - A new configure keyword Usage can limit what operations a + repository is used for + - NoExtract and NoUpgrade can use inverted pattern matches + (FS#31749) + - Group queries can be filtered with --explict/--deps (FS#19716) + - Filesystem checking now only produces a warning for altered + backup files (FS#34739) + - pacman prints a warning if an installed directory has different + permission to that already on the filesystem (FS#34740) + - both current and new versions are displayed when querying + updates + - --print-format now implies --print + - package scriptlets are not run when using --dbonly + - invalid option combinations cause pacman to abort (FS#20950) + - improve output when a package is missing a required signature + (FS#28014) + - PGP signature key IDs are listed with -Sii (FS#34742) + - indicate ignored packages in -Qu output + - use appropriate file size units with -Si/-Qi + - plugged several memory leaks + - read filelists from a packages .MTEE file if possible + - ensure packages have all the required metadata before installing + (FS#35514) + - always remove lock file on exit (FS#35603) + - fix overflow in integrity checking progress bar (FS#36608) + - ensure downloads use correct filename even if the mirror uses a + redirect (FS#36791) + - cache PGP key IDs during availability checking (FS#38042) + - fix reading responses with leading whitespace (FS#39976) + - fix potential issues when handling of UTF8 filenames + (FS#40805, FS#40762) + - makepkg: + - PKGBUILDs can now specify architecture specific sources, + dependencies, etc. + - A .SRCINFO file is added to source packages for easy parsing + - VCS package building attempts to be incremental (FS#35050) + - bzr sources can have a '+' in them (FS#35244) + - allow sources containing "::" + - add --noprepare option + - add -C/--cleanbuild option (FS#17175) + - add --noarchive option + - remove --asroot and enforce fakeroot usage + - all PKGBUILDs require a package() function + - PKGBUILDs can no longer be read from stdin + - enable make style environmental overrides + - Read CARCH environmental variable (FS#35030) + - makedepends and checkdepends are installed together (FS#31557) + - added support for sha224 checksums (FS#36776) + - remove warning when license is not specified in PKGBUILD + (FS#37011) + - only remove static libraries if they have a shared version + - prevent makepkg creating armored signatures (FS#38503) + - support stripping kernel modules + - support the kernel.org PGP signing scheme (FS#31592) + - sign created source package when using --sign + - enforce source signatures to be trusted or have their full + fingerprint listed in the validpgpkeys array of the PKGBUILD + - look for configuration in XDG_CONFIG_HOME/pacman/makepkg.conf + (FS#43030) + - ensure vcs tools are available when source entries require + them + - disallow pkgver/pkgrel/epoch overrides in split packages + - improve parsing of PKGBUILD variables (FS#40361) + - makepkg-template - new package build templating utility + (FS#10375) + - repo-add: + - add option to remove package files from disk + - contrib: + - checkupdates: rename CHECKUPDATE_DB to CHECKUPDATES_DB + - pacdiff: add a "Quit" option, and many other improvements + - pacsysclean is removed 4.1.2 - validate %FILEPATH% when parsing repos to prevent arbitary file overwrites from malicious databases - makepkg: -- 2.2.0

1 0

[pacman-dev] [PATCH] Update README for pacman-4.2
by Allan McRae 18 Dec '14

18 Dec '14

Signed-off-by: Allan McRae <allan(a)archlinux.org> --- README | 50 ++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 50 insertions(+) diff --git a/README b/README index 35074d8..141bc9e 100644 --- a/README +++ b/README @@ -507,3 +507,53 @@ API CHANGES BETWEEN 4.0 AND 4.1 ALPM_EVENT_OPTDEP_REQUIRED, ALPM_EVENT_DATABASE_MISSING, ALPM_EVENT_KEYRING_START, ALPM_EVENT_KEYRING_DONE, ALPM_EVENT_KEY_DOWNLOAD_START, ALPM_EVENT_KEY_DOWNLOAD_DONE, ALPM_PROGRESS_KEYRING_START + + +API CHANGES BETWEEN 4.1 AND 4.2 +=============================== + +[CHANGED] +- alpm_filelist_t - removed member resolved_path +- alpm_filelist_contains - now returns alpm_file_t +- event callback + - alpm_event_t renamed to alpm_event_type_t + - alpm_event_t union added + - alpm_event_cb now takes only an alpm_event_t parameter + - alpm_event_any_t, alpm_package_operation_t, alpm_event_package_operation_t, + alpm_event_optdep_removal_t, alpm_event_delta_patch_t, alpm_event_scriptlet_info_t, + alpm_event_database_missing_t, alpm_event_pkgdownload_t, alpm_event_pacnew_created_t, + alpm_event_pacsave_created_t, alpm_event_pacorig_created_t added + - ALPM_EVENT_*_START -> ALPM_EVENT_PACKAGE_OPERATION_START + - ALPM_EVENT_*_DONE -> ALPM_EVENT_PACKAGE_OPERATION_DONE +- question callback + - alpm_question_t renamed to alpm_question_type_t + - alpm_question_t union added + - alpm_cb_question now takes only an alpm_question_t parameter + - alpm_question_any_t, alpm_question_install_ignorepkg_t, alpm_question_replace_t + alpm_question_conflict_t, alpm_question_corrupted_t, alpm_question_remove_pkgs_t, + alpm_question_select_provider_t, alpm_question_import_key_t added + +[ADDED] +- memory management + - alpm_fileconflict_free() + - alpm_depmissing_free() + - alpm_conflict_free() + - alpm_dep_free() +- database usage + - alpm_db_usage_t + - alpm_db_set_usage() + - alpm_db_get_usage() +- assume installed + - alpm_option_get_assumeinstalled() + - alpm_option_add_assumeinstalled() + - alpm_option_set_assumeinstalled() + - alpm_option_remove_assumeinstalled() +- utility funcitons + - alpm_dep_from_string() + - alpm_pkg_should_ignore() + - alpm_decode_signature() + - alpm_extract_keyid() +- flags + - ALPM_EVENT_RETRIEVE_DONE, ALPM_EVENT_RETRIEVE_FAILED, ALPM_EVENT_PKGDOWNLOAD_START, + ALPM_EVENT_PKGDOWNLOAD_DONE, ALPM_EVENT_PKGDOWNLOAD_FAILED, ALPM_EVENT_OPTDEP_REMOVAL, + ALPM_EVENT_PACNEW_CREATED, ALPM_EVENT_PACSVAE_CREATED, ALPM_EVENT_PACORIG_CREATED -- 2.2.0

1 0

[pacman-dev] [PATCH] Fix pointer declarations to be globally consistent
by Micah Saint Germain 15 Dec '14

15 Dec '14

From: Micah Saint Germain <micahsg(a)google.com> Refactored inconsistent pointer declarations to better improve consistency throughout the pacman codebase which will, in turn, increase readability to the user. Expected format of a pointer declaration: `typename *varname` Signed-off-by: Micah Saint Germain <micahsg(a)google.com> --- src/pacman/callback.h | 2 +- src/pacman/pacman.c | 10 +++++----- src/pacman/sync.c | 2 +- src/util/pactree.c | 2 +- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/pacman/callback.h b/src/pacman/callback.h index 5480c73..498536f 100644 --- a/src/pacman/callback.h +++ b/src/pacman/callback.h @@ -28,7 +28,7 @@ void cb_event(alpm_event_t *event); /* callback to handle questions from libalpm (yes/no) */ -void cb_question(alpm_question_t* question); +void cb_question(alpm_question_t *question); /* callback to handle display of progress */ void cb_progress(alpm_progress_t event, const char *pkgname, int percent, diff --git a/src/pacman/pacman.c b/src/pacman/pacman.c index 6161048..f43105a 100644 --- a/src/pacman/pacman.c +++ b/src/pacman/pacman.c @@ -97,11 +97,11 @@ static void usage(int op, const char * const myname) alpm_list_t *list = NULL, *i; /* prefetch some strings for usage below, which moves a lot of calls * out of gettext. */ - char const * const str_opt = _("options"); - char const * const str_file = _("file(s)"); - char const * const str_pkg = _("package(s)"); - char const * const str_usg = _("usage"); - char const * const str_opr = _("operation"); + char const *const str_opt = _("options"); + char const *const str_file = _("file(s)"); + char const *const str_pkg = _("package(s)"); + char const *const str_usg = _("usage"); + char const *const str_opr = _("operation"); /* please limit your strings to 80 characters in width */ if(op == PM_OP_MAIN) { diff --git a/src/pacman/sync.c b/src/pacman/sync.c index 4609186..215497f 100644 --- a/src/pacman/sync.c +++ b/src/pacman/sync.c @@ -230,7 +230,7 @@ static int sync_cleancache(int level) } if(level <= 1) { - static const char * const glob_skips[] = { + static const char *const glob_skips[] = { /* skip signature files - they are removed with their package file */ "*.sig", /* skip package database within the cache directory */ diff --git a/src/util/pactree.c b/src/util/pactree.c index 5c76542..14579e4 100644 --- a/src/util/pactree.c +++ b/src/util/pactree.c @@ -339,7 +339,7 @@ static void cleanup(void) static void print_text(const char *pkg, const char *provision, tdepth *depth, int last) { - const char* tip = ""; + const char *tip = ""; int level = 1; if(!pkg && !provision) { /* not much we can do */ -- 2.1.0

4 3