- Pacman-dev - lists.archlinux.org

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v4.1.2-519-g565c931
by allan＠archlinux.org 19 Dec '14

19 Dec '14

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, master has been updated via 565c931e2c684d4460ff65cbec9b097ee1d8f94d (commit) from bc6ada0877010891e5c2336fd5c1242047e6a7a5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 565c931e2c684d4460ff65cbec9b097ee1d8f94d Author: Dave Reisner <dreisner(a)archlinux.org> Date: Thu Dec 18 23:20:22 2014 -0500 updpkgsums: add more error checking before replacement Re-add some paranoia which was inadvertently lost with 768b65e934. In case 'makepkg -g' fails to generate new sums (e.g. when a remote resource cannot be fetched), or awk fails to write the new file (i have no idea when this would happen), bail out with an error. Signed-off-by: Allan McRae <allan(a)archlinux.org> ----------------------------------------------------------------------- Summary of changes: contrib/updpkgsums.sh.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- The official pacman repository

1 0

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v4.1.2-518-gbc6ada0
by allan＠archlinux.org 19 Dec '14

19 Dec '14

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, master has been updated via bc6ada0877010891e5c2336fd5c1242047e6a7a5 (commit) from 54db3745d6890aba44fbe251aeae42a1938767d2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit bc6ada0877010891e5c2336fd5c1242047e6a7a5 Author: Allan McRae <allan(a)archlinux.org> Date: Fri Dec 19 13:57:21 2014 +1000 Release 4.2.0 Signed-off-by: Allan McRae <allan(a)archlinux.org> ----------------------------------------------------------------------- Summary of changes: configure.ac | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) hooks/post-receive -- The official pacman repository

1 0

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v4.1.2-517-g54db374
by allan＠archlinux.org 19 Dec '14

19 Dec '14

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, master has been updated via 54db3745d6890aba44fbe251aeae42a1938767d2 (commit) from 14dc3389fdaf520b0d9adb8e6b5d441163889519 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 54db3745d6890aba44fbe251aeae42a1938767d2 Author: Allan McRae <allan(a)archlinux.org> Date: Fri Dec 19 13:53:35 2014 +1000 Update translations from transifex Signed-off-by: Allan McRae <allan(a)archlinux.org> ----------------------------------------------------------------------- Summary of changes: lib/libalpm/po/LINGUAS | 1 + lib/libalpm/po/ar.po | 45 +- lib/libalpm/po/ast.po | 456 +++++++++---- lib/libalpm/po/bg.po | 246 ++++++- lib/libalpm/po/ca.po | 57 +- lib/libalpm/po/cs.po | 56 +- lib/libalpm/po/da.po | 53 +- lib/libalpm/po/de.po | 60 +- lib/libalpm/po/el.po | 87 ++- lib/libalpm/po/en_GB.po | 54 +- lib/libalpm/po/es.po | 91 ++- lib/libalpm/po/eu.po | 249 ++++++- lib/libalpm/po/fi.po | 57 +- lib/libalpm/po/fr.po | 57 +- lib/libalpm/po/gl.po | 59 +- lib/libalpm/po/hr.po | 61 +- lib/libalpm/po/hu.po | 64 +- lib/libalpm/po/id.po | 57 +- lib/libalpm/po/it.po | 57 +- lib/libalpm/po/ja.po | 54 +- lib/libalpm/po/kk.po | 111 ++-- lib/libalpm/po/ko.po | 56 +- lib/libalpm/po/{libalpm.pot => ko_KR.po} | 80 ++- lib/libalpm/po/lt.po | 54 +- lib/libalpm/po/nb.po | 55 +- lib/libalpm/po/nl.po | 57 +- lib/libalpm/po/pl.po | 59 +- lib/libalpm/po/pt.po | 60 +- lib/libalpm/po/pt_BR.po | 55 +- lib/libalpm/po/ro.po | 50 +- lib/libalpm/po/ru.po | 73 +-- lib/libalpm/po/sk.po | 56 +- lib/libalpm/po/sl.po | 59 +- lib/libalpm/po/sr.po | 46 +- lib/libalpm/po/sr(a)latin.po | 46 +- lib/libalpm/po/sv.po | 44 +- lib/libalpm/po/tr.po | 58 +- lib/libalpm/po/uk.po | 57 +- lib/libalpm/po/ur.po | 238 ++++++- lib/libalpm/po/uz.po | 239 ++++++- lib/libalpm/po/vi.po | 246 ++++++- lib/libalpm/po/zh_CN.po | 52 +- lib/libalpm/po/zh_TW.po | 142 ++-- scripts/po/LINGUAS | 3 + scripts/po/ar.po | 156 ++--- scripts/po/ast.po | 876 ++++++++++++++++++++----- scripts/po/bg.po | 762 +++++++++++++++++++--- scripts/po/ca.po | 281 +++----- scripts/po/cs.po | 309 ++++----- scripts/po/da.po | 269 +++----- scripts/po/de.po | 355 ++++------ scripts/po/el.po | 343 ++++------ scripts/po/en_GB.po | 302 ++++----- scripts/po/es.po | 352 ++++------ scripts/po/eu.po | 741 ++++++++++++++++++--- scripts/po/fi.po | 268 +++----- scripts/po/fr.po | 320 ++++----- scripts/po/gl.po | 247 ++----- scripts/po/hr.po | 185 +++--- scripts/po/hu.po | 311 ++++----- scripts/po/id.po | 320 ++++----- scripts/po/it.po | 295 ++++----- scripts/po/ja.po | 301 ++++----- scripts/po/kk.po | 160 ++--- scripts/po/ko.po | 254 +++----- scripts/po/{pacman-scripts.pot => ko_KR.po} | 136 ++-- scripts/po/lt.po | 247 ++----- scripts/po/nb.po | 310 ++++----- scripts/po/{pacman-scripts.pot => nl.po} | 225 +++---- scripts/po/pacman-scripts.pot | 78 +-- scripts/po/pl.po | 361 +++++------ scripts/po/pt.po | 316 ++++----- scripts/po/pt_BR.po | 331 ++++------ scripts/po/ro.po | 249 ++----- scripts/po/ru.po | 259 +++----- scripts/po/sk.po | 306 ++++----- scripts/po/sl.po | 494 +++++++------- scripts/po/sr.po | 243 ++----- scripts/po/sr(a)latin.po | 243 ++----- scripts/po/sv.po | 252 ++------ scripts/po/tr.po | 319 ++++----- scripts/po/uk.po | 307 ++++----- scripts/po/uz.po | 705 ++++++++++++++++++-- scripts/po/zh_CN.po | 294 +++------ scripts/po/{ar.po => zh_TW.po} | 965 ++++++++++++++-------------- src/pacman/po/LINGUAS | 2 + src/pacman/po/ar.po | 124 ++-- src/pacman/po/ast.po | 529 ++++++++++++--- src/pacman/po/bg.po | 498 ++++++++++++-- src/pacman/po/ca.po | 171 +++-- src/pacman/po/cs.po | 173 +++-- src/pacman/po/da.po | 169 +++-- src/pacman/po/de.po | 261 ++++---- src/pacman/po/el.po | 188 +++--- src/pacman/po/en_GB.po | 156 ++--- src/pacman/po/eo.po | 76 +-- src/pacman/po/es.po | 277 ++++---- src/pacman/po/eu.po | 497 ++++++++++++-- src/pacman/po/fa.po | 45 +- src/pacman/po/fi.po | 164 +++-- src/pacman/po/fr.po | 179 +++--- src/pacman/po/gl.po | 386 ++++++----- src/pacman/po/hr.po | 141 ++-- src/pacman/po/hu.po | 171 +++-- src/pacman/po/id.po | 167 +++-- src/pacman/po/it.po | 172 +++-- src/pacman/po/ja.po | 195 +++--- src/pacman/po/kk.po | 338 +++++----- src/pacman/po/ko.po | 152 ++--- src/pacman/po/{pacman.pot => ko_KR.po} | 52 +- src/pacman/po/lt.po | 139 ++-- src/pacman/po/nb.po | 169 +++-- src/pacman/po/nl.po | 181 +++--- src/pacman/po/pacman.pot | 24 +- src/pacman/po/pl.po | 171 +++-- src/pacman/po/pt.po | 175 +++-- src/pacman/po/pt_BR.po | 170 +++-- src/pacman/po/ro.po | 144 ++--- src/pacman/po/ru.po | 205 +++--- src/pacman/po/sk.po | 171 +++-- src/pacman/po/sl.po | 193 +++--- src/pacman/po/sr.po | 143 ++--- src/pacman/po/sr(a)latin.po | 143 ++--- src/pacman/po/sv.po | 138 ++-- src/pacman/po/tr.po | 174 +++-- src/pacman/po/uk.po | 174 +++-- src/pacman/po/ur.po | 458 +++++++++++-- src/pacman/po/uz.po | 468 ++++++++++++-- src/pacman/po/{pacman.pot => vi.po} | 52 +- src/pacman/po/zh_CN.po | 152 ++--- src/pacman/po/zh_TW.po | 284 ++++---- 131 files changed, 14321 insertions(+), 12854 deletions(-) copy lib/libalpm/po/{libalpm.pot => ko_KR.po} (85%) copy scripts/po/{pacman-scripts.pot => ko_KR.po} (94%) copy scripts/po/{pacman-scripts.pot => nl.po} (91%) copy scripts/po/{ar.po => zh_TW.po} (61%) copy src/pacman/po/{pacman.pot => ko_KR.po} (97%) copy src/pacman/po/{pacman.pot => vi.po} (97%) hooks/post-receive -- The official pacman repository

1 0

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v4.1.2-516-g14dc338
by allan＠archlinux.org 19 Dec '14

19 Dec '14

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, master has been updated via 14dc3389fdaf520b0d9adb8e6b5d441163889519 (commit) via c9e9c1ccfda919146a7f456a240e2287d9fc63fe (commit) via 3af0268fdbafbeb0a2e45d3555ef9d224d89c29d (commit) via df36fe2e79d5a5490b89c259bef7a1f150cff575 (commit) via 768b65e93472914c52cc1159c4932d4fc1438c14 (commit) via 16259d728e87c10533cd24f88aa7127fff48db2b (commit) via 0cd174efd5065dca26fcce180d853fe6323d3e12 (commit) via a4b23417f9868e14fddf0e6f35e57ba05f029623 (commit) via c54af84180d76c1d5c9febdae930dfe5379d7db5 (commit) from ed4032a90813ba29ee11c71ac6af3090d96789ce (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 14dc3389fdaf520b0d9adb8e6b5d441163889519 Author: Allan McRae <allan(a)archlinux.org> Date: Thu Dec 18 21:54:43 2014 +1000 Update NEWS for pacman-4.2 release Signed-off-by: Allan McRae <allan(a)archlinux.org> commit c9e9c1ccfda919146a7f456a240e2287d9fc63fe Author: Allan McRae <allan(a)archlinux.org> Date: Thu Dec 18 17:20:58 2014 +1000 Update README for pacman-4.2 Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 3af0268fdbafbeb0a2e45d3555ef9d224d89c29d Author: Andrew Gregory <andrew.gregory.8(a)gmail.com> Date: Sat Nov 29 18:02:56 2014 -0500 remove.c: honor inverted patterns in noupgrade Signed-off-by: Andrew Gregory <andrew.gregory.8(a)gmail.com> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit df36fe2e79d5a5490b89c259bef7a1f150cff575 Author: Andrew Gregory <andrew.gregory.8(a)gmail.com> Date: Sat Nov 29 18:02:55 2014 -0500 add alpm_option_match_noupgrade For parity with alpm_option_match_noextract. Signed-off-by: Andrew Gregory <andrew.gregory.8(a)gmail.com> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 768b65e93472914c52cc1159c4932d4fc1438c14 Author: Dave Reisner <dreisner(a)archlinux.org> Date: Sun Dec 14 13:45:06 2014 -0500 updpkgsums: drop in-place rewrite hack, use a tempfile This apparently exposes (what I think is) a subtle bug in cygwin's handling of subst'd drives. Let's just drop the hackery and use a tempfile, which should always work. Also, introduce a proper die() function which replaces previous hand-rolled error+exit pattern, but which wrote to stdout. Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 16259d728e87c10533cd24f88aa7127fff48db2b Author: Dave Reisner <dreisner(a)archlinux.org> Date: Sun Dec 14 12:35:00 2014 -0500 shut up GCC on -Wmaybe-initialized warnings Admittedly, these are totally bogus, but a clean build is a happy build. Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 0cd174efd5065dca26fcce180d853fe6323d3e12 Author: Dave Reisner <dreisner(a)archlinux.org> Date: Sun Dec 14 12:35:01 2014 -0500 makepkg: correctly add changelog files Before this, we'd see bizzare behavior of: -> Adding changelog file (systemd.install)... And, changelog files in the global section would not be added at all. The code is clearly wrong here, as it references 'install' within a loop of 'changelog' and 'install'. Let's use parameter indirection to ensure that the proper file is identified and added. Signed-off-by: Allan McRae <allan(a)archlinux.org> commit a4b23417f9868e14fddf0e6f35e57ba05f029623 Author: Micah Saint Germain <micah(a)lexme.org> Date: Sun Dec 14 21:01:22 2014 -0500 Fix pointer declarations to be globally consistent Refactored inconsistent pointer declarations to better improve consistency throughout the pacman codebase which will, in turn, increase readability to the user. Expected format of a pointer declaration: `typename *varname` Signed-off-by: Micah Saint Germain <micah(a)lexme.org> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit c54af84180d76c1d5c9febdae930dfe5379d7db5 Author: Miguel de Val-Borro <miguel(a)archlinux.net> Date: Sat Nov 29 19:32:55 2014 -0500 doc/translation-help.txt: Transifex example usage Replace harcoded language code in example Signed-off-by: Miguel de Val-Borro <miguel(a)archlinux.net> Signed-off-by: Allan McRae <allan(a)archlinux.org> ----------------------------------------------------------------------- Summary of changes: NEWS | 81 +++++++++++++++++++++++++++++++++ README | 53 +++++++++++++++++++++ contrib/updpkgsums.sh.in | 37 +++++++++------ doc/translation-help.txt | 4 +- lib/libalpm/alpm.h | 1 + lib/libalpm/handle.c | 5 ++ lib/libalpm/remove.c | 4 +- scripts/makepkg.sh.in | 2 +- src/pacman/callback.h | 2 +- src/pacman/conf.c | 2 +- src/pacman/pacman.c | 13 +++--- src/pacman/sync.c | 2 +- src/util/pactree.c | 2 +- test/pacman/tests/TESTS | 1 + test/pacman/tests/noupgrade-inverted.py | 19 ++++++++ 15 files changed, 198 insertions(+), 30 deletions(-) create mode 100644 test/pacman/tests/noupgrade-inverted.py hooks/post-receive -- The official pacman repository

1 0

[pacman-dev] [PATCH] Update NEWS for pacman-4.2 release
by Allan McRae 18 Dec '14

18 Dec '14

Signed-off-by: Allan McRae <allan(a)archlinux.org> --- NEWS | 81 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 81 insertions(+) diff --git a/NEWS b/NEWS index 02148d3..723664e 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,86 @@ VERSION DESCRIPTION ----------------------------------------------------------------------------- +4.2.0 - symlinks to directories on the filesystem are no longer + treated as directories + - pacman-db-upgrade - fix local database for files installed + into directory symlinks + - added --assume-installed option to help upgrades where not all + installed packages have been rebuilt + - --unrequired now filters needed optdepends too. Use twices + to only filter direct dependencies + - improved dependency resolving ensures correct ordering when + installing updates (FS#32764) + - A new configure keyword Usage can limit what operations a + repository is used for + - NoExtract and NoUpgrade can use inverted pattern matches + (FS#31749) + - Group queries can be filtered with --explict/--deps (FS#19716) + - Filesystem checking now only produces a warning for altered + backup files (FS#34739) + - pacman prints a warning if an installed directory has different + permission to that already on the filesystem (FS#34740) + - both current and new versions are displayed when querying + updates + - --print-format now implies --print + - package scriptlets are not run when using --dbonly + - invalid option combinations cause pacman to abort (FS#20950) + - improve output when a package is missing a required signature + (FS#28014) + - PGP signature key IDs are listed with -Sii (FS#34742) + - indicate ignored packages in -Qu output + - use appropriate file size units with -Si/-Qi + - plugged several memory leaks + - read filelists from a packages .MTEE file if possible + - ensure packages have all the required metadata before installing + (FS#35514) + - always remove lock file on exit (FS#35603) + - fix overflow in integrity checking progress bar (FS#36608) + - ensure downloads use correct filename even if the mirror uses a + redirect (FS#36791) + - cache PGP key IDs during availability checking (FS#38042) + - fix reading responses with leading whitespace (FS#39976) + - fix potential issues when handling of UTF8 filenames + (FS#40805, FS#40762) + - makepkg: + - PKGBUILDs can now specify architecture specific sources, + dependencies, etc. + - A .SRCINFO file is added to source packages for easy parsing + - VCS package building attempts to be incremental (FS#35050) + - bzr sources can have a '+' in them (FS#35244) + - allow sources containing "::" + - add --noprepare option + - add -C/--cleanbuild option (FS#17175) + - add --noarchive option + - remove --asroot and enforce fakeroot usage + - all PKGBUILDs require a package() function + - PKGBUILDs can no longer be read from stdin + - enable make style environmental overrides + - Read CARCH environmental variable (FS#35030) + - makedepends and checkdepends are installed together (FS#31557) + - added support for sha224 checksums (FS#36776) + - remove warning when license is not specified in PKGBUILD + (FS#37011) + - only remove static libraries if they have a shared version + - prevent makepkg creating armored signatures (FS#38503) + - support stripping kernel modules + - support the kernel.org PGP signing scheme (FS#31592) + - sign created source package when using --sign + - enforce source signatures to be trusted or have their full + fingerprint listed in the validpgpkeys array of the PKGBUILD + - look for configuration in XDG_CONFIG_HOME/pacman/makepkg.conf + (FS#43030) + - ensure vcs tools are available when source entries require + them + - disallow pkgver/pkgrel/epoch overrides in split packages + - improve parsing of PKGBUILD variables (FS#40361) + - makepkg-template - new package build templating utility + (FS#10375) + - repo-add: + - add option to remove package files from disk + - contrib: + - checkupdates: rename CHECKUPDATE_DB to CHECKUPDATES_DB + - pacdiff: add a "Quit" option, and many other improvements + - pacsysclean is removed 4.1.2 - validate %FILEPATH% when parsing repos to prevent arbitary file overwrites from malicious databases - makepkg: -- 2.2.0

1 0

[pacman-dev] [PATCH] Update README for pacman-4.2
by Allan McRae 18 Dec '14

18 Dec '14

Signed-off-by: Allan McRae <allan(a)archlinux.org> --- README | 50 ++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 50 insertions(+) diff --git a/README b/README index 35074d8..141bc9e 100644 --- a/README +++ b/README @@ -507,3 +507,53 @@ API CHANGES BETWEEN 4.0 AND 4.1 ALPM_EVENT_OPTDEP_REQUIRED, ALPM_EVENT_DATABASE_MISSING, ALPM_EVENT_KEYRING_START, ALPM_EVENT_KEYRING_DONE, ALPM_EVENT_KEY_DOWNLOAD_START, ALPM_EVENT_KEY_DOWNLOAD_DONE, ALPM_PROGRESS_KEYRING_START + + +API CHANGES BETWEEN 4.1 AND 4.2 +=============================== + +[CHANGED] +- alpm_filelist_t - removed member resolved_path +- alpm_filelist_contains - now returns alpm_file_t +- event callback + - alpm_event_t renamed to alpm_event_type_t + - alpm_event_t union added + - alpm_event_cb now takes only an alpm_event_t parameter + - alpm_event_any_t, alpm_package_operation_t, alpm_event_package_operation_t, + alpm_event_optdep_removal_t, alpm_event_delta_patch_t, alpm_event_scriptlet_info_t, + alpm_event_database_missing_t, alpm_event_pkgdownload_t, alpm_event_pacnew_created_t, + alpm_event_pacsave_created_t, alpm_event_pacorig_created_t added + - ALPM_EVENT_*_START -> ALPM_EVENT_PACKAGE_OPERATION_START + - ALPM_EVENT_*_DONE -> ALPM_EVENT_PACKAGE_OPERATION_DONE +- question callback + - alpm_question_t renamed to alpm_question_type_t + - alpm_question_t union added + - alpm_cb_question now takes only an alpm_question_t parameter + - alpm_question_any_t, alpm_question_install_ignorepkg_t, alpm_question_replace_t + alpm_question_conflict_t, alpm_question_corrupted_t, alpm_question_remove_pkgs_t, + alpm_question_select_provider_t, alpm_question_import_key_t added + +[ADDED] +- memory management + - alpm_fileconflict_free() + - alpm_depmissing_free() + - alpm_conflict_free() + - alpm_dep_free() +- database usage + - alpm_db_usage_t + - alpm_db_set_usage() + - alpm_db_get_usage() +- assume installed + - alpm_option_get_assumeinstalled() + - alpm_option_add_assumeinstalled() + - alpm_option_set_assumeinstalled() + - alpm_option_remove_assumeinstalled() +- utility funcitons + - alpm_dep_from_string() + - alpm_pkg_should_ignore() + - alpm_decode_signature() + - alpm_extract_keyid() +- flags + - ALPM_EVENT_RETRIEVE_DONE, ALPM_EVENT_RETRIEVE_FAILED, ALPM_EVENT_PKGDOWNLOAD_START, + ALPM_EVENT_PKGDOWNLOAD_DONE, ALPM_EVENT_PKGDOWNLOAD_FAILED, ALPM_EVENT_OPTDEP_REMOVAL, + ALPM_EVENT_PACNEW_CREATED, ALPM_EVENT_PACSVAE_CREATED, ALPM_EVENT_PACORIG_CREATED -- 2.2.0

1 0

[pacman-dev] [PATCH] Fix pointer declarations to be globally consistent
by Micah Saint Germain 15 Dec '14

15 Dec '14

From: Micah Saint Germain <micahsg(a)google.com> Refactored inconsistent pointer declarations to better improve consistency throughout the pacman codebase which will, in turn, increase readability to the user. Expected format of a pointer declaration: `typename *varname` Signed-off-by: Micah Saint Germain <micahsg(a)google.com> --- src/pacman/callback.h | 2 +- src/pacman/pacman.c | 10 +++++----- src/pacman/sync.c | 2 +- src/util/pactree.c | 2 +- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/pacman/callback.h b/src/pacman/callback.h index 5480c73..498536f 100644 --- a/src/pacman/callback.h +++ b/src/pacman/callback.h @@ -28,7 +28,7 @@ void cb_event(alpm_event_t *event); /* callback to handle questions from libalpm (yes/no) */ -void cb_question(alpm_question_t* question); +void cb_question(alpm_question_t *question); /* callback to handle display of progress */ void cb_progress(alpm_progress_t event, const char *pkgname, int percent, diff --git a/src/pacman/pacman.c b/src/pacman/pacman.c index 6161048..f43105a 100644 --- a/src/pacman/pacman.c +++ b/src/pacman/pacman.c @@ -97,11 +97,11 @@ static void usage(int op, const char * const myname) alpm_list_t *list = NULL, *i; /* prefetch some strings for usage below, which moves a lot of calls * out of gettext. */ - char const * const str_opt = _("options"); - char const * const str_file = _("file(s)"); - char const * const str_pkg = _("package(s)"); - char const * const str_usg = _("usage"); - char const * const str_opr = _("operation"); + char const *const str_opt = _("options"); + char const *const str_file = _("file(s)"); + char const *const str_pkg = _("package(s)"); + char const *const str_usg = _("usage"); + char const *const str_opr = _("operation"); /* please limit your strings to 80 characters in width */ if(op == PM_OP_MAIN) { diff --git a/src/pacman/sync.c b/src/pacman/sync.c index 4609186..215497f 100644 --- a/src/pacman/sync.c +++ b/src/pacman/sync.c @@ -230,7 +230,7 @@ static int sync_cleancache(int level) } if(level <= 1) { - static const char * const glob_skips[] = { + static const char *const glob_skips[] = { /* skip signature files - they are removed with their package file */ "*.sig", /* skip package database within the cache directory */ diff --git a/src/util/pactree.c b/src/util/pactree.c index 5c76542..14579e4 100644 --- a/src/util/pactree.c +++ b/src/util/pactree.c @@ -339,7 +339,7 @@ static void cleanup(void) static void print_text(const char *pkg, const char *provision, tdepth *depth, int last) { - const char* tip = ""; + const char *tip = ""; int level = 1; if(!pkg && !provision) { /* not much we can do */ -- 2.1.0

4 3

[pacman-dev] [PATCH] Fix pointer declarations to be globally consistent
by micah＠lexme.org 15 Dec '14

15 Dec '14

From: Micah Saint Germain <micah(a)lexme.org> Refactored inconsistent pointer declarations to better improve consistency throughout the pacman codebase which will, in turn, increase readability to the user. Expected format of a pointer declaration: `typename *varname` Signed-off-by: Micah Saint Germain <micah(a)lexme.org> --- src/pacman/callback.h | 2 +- src/pacman/pacman.c | 10 +++++----- src/pacman/sync.c | 2 +- src/util/pactree.c | 2 +- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/pacman/callback.h b/src/pacman/callback.h index 5480c73..498536f 100644 --- a/src/pacman/callback.h +++ b/src/pacman/callback.h @@ -28,7 +28,7 @@ void cb_event(alpm_event_t *event); /* callback to handle questions from libalpm (yes/no) */ -void cb_question(alpm_question_t* question); +void cb_question(alpm_question_t *question); /* callback to handle display of progress */ void cb_progress(alpm_progress_t event, const char *pkgname, int percent, diff --git a/src/pacman/pacman.c b/src/pacman/pacman.c index 6161048..f43105a 100644 --- a/src/pacman/pacman.c +++ b/src/pacman/pacman.c @@ -97,11 +97,11 @@ static void usage(int op, const char * const myname) alpm_list_t *list = NULL, *i; /* prefetch some strings for usage below, which moves a lot of calls * out of gettext. */ - char const * const str_opt = _("options"); - char const * const str_file = _("file(s)"); - char const * const str_pkg = _("package(s)"); - char const * const str_usg = _("usage"); - char const * const str_opr = _("operation"); + char const *const str_opt = _("options"); + char const *const str_file = _("file(s)"); + char const *const str_pkg = _("package(s)"); + char const *const str_usg = _("usage"); + char const *const str_opr = _("operation"); /* please limit your strings to 80 characters in width */ if(op == PM_OP_MAIN) { diff --git a/src/pacman/sync.c b/src/pacman/sync.c index 4609186..215497f 100644 --- a/src/pacman/sync.c +++ b/src/pacman/sync.c @@ -230,7 +230,7 @@ static int sync_cleancache(int level) } if(level <= 1) { - static const char * const glob_skips[] = { + static const char *const glob_skips[] = { /* skip signature files - they are removed with their package file */ "*.sig", /* skip package database within the cache directory */ diff --git a/src/util/pactree.c b/src/util/pactree.c index 5c76542..14579e4 100644 --- a/src/util/pactree.c +++ b/src/util/pactree.c @@ -339,7 +339,7 @@ static void cleanup(void) static void print_text(const char *pkg, const char *provision, tdepth *depth, int last) { - const char* tip = ""; + const char *tip = ""; int level = 1; if(!pkg && !provision) { /* not much we can do */ -- 2.1.0

1 0

[pacman-dev] [PATCH 1/2] shut up GCC on -Wmaybe-initialized warnings
by Dave Reisner 15 Dec '14

15 Dec '14

Admittedly, these are totally bogus, but a clean build is a happy build. --- src/pacman/conf.c | 2 +- src/pacman/pacman.c | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/pacman/conf.c b/src/pacman/conf.c index 5028284..873ca0e 100644 --- a/src/pacman/conf.c +++ b/src/pacman/conf.c @@ -459,7 +459,7 @@ static int process_cleanmethods(alpm_list_t *values, static void setrepeatingoption(char *ptr, const char *option, alpm_list_t **list) { - char *val, *saveptr; + char *val, *saveptr = NULL; val = strtok_r(ptr, " ", &saveptr); while(val) { diff --git a/src/pacman/pacman.c b/src/pacman/pacman.c index 6161048..6234570 100644 --- a/src/pacman/pacman.c +++ b/src/pacman/pacman.c @@ -341,8 +341,7 @@ static void invalid_opt(int used, const char *opt1, const char *opt2) static int parsearg_util_addlist(alpm_list_t **list) { - char *i, *save; - + char *i, *save = NULL; for(i = strtok_r(optarg, ",", &save); i; i = strtok_r(NULL, ",", &save)) { *list = alpm_list_add(*list, strdup(i)); -- 2.1.3

3 3

[pacman-dev] [PATCH] updpkgsums: drop in-place rewrite hack, use a tempfile
by Dave Reisner 14 Dec '14

14 Dec '14

This apparently exposes (what I think is) a subtle bug in cygwin's handling of subst'd drives. Let's just drop the hackery and use a tempfile, which should always work. Also, introduce a proper die() function which replaces previous hand-rolled error+exit pattern, but which wrote to stdout. --- contrib/updpkgsums.sh.in | 37 +++++++++++++++++++++++-------------- 1 file changed, 23 insertions(+), 14 deletions(-) diff --git a/contrib/updpkgsums.sh.in b/contrib/updpkgsums.sh.in index e0524bd..a40845b 100644 --- a/contrib/updpkgsums.sh.in +++ b/contrib/updpkgsums.sh.in @@ -40,6 +40,11 @@ version() { echo 'Copyright (C) 2012-2013 Dave Reisner <dreisner(a)archlinux.org>' } +die() { + printf "==> ERROR: $1\n" "${@:2}" >&2 + exit 1 +} + case $1 in -h|--help) usage; exit ;; -V|--version) version; exit ;; @@ -47,8 +52,7 @@ esac buildfile=${1:-PKGBUILD} if [[ ! -f $buildfile ]]; then - printf "==> ERROR: %s not found or is not a file\n" "$buildfile" - exit 1 + die "%s not found or is not a file" "$buildfile" fi # Resolve any symlinks to avoid replacing the symlink with a file. But, we @@ -71,18 +75,19 @@ fi # Check $PWD/ for permission to unlink the $buildfile and write a new one if [[ ! -w . ]]; then - printf "==> ERROR: No write permission in '%s'\n" "$PWD" - exit 1 + die "No write permission in '%s'" "$PWD" fi -{ - # Generate the new sums and try to unlink the file before writing stdin back - # into it. This final precaution shouldn't fail based on the previous checks, - # but it's better to be extra careful before unlinking files. - export BUILDDIR=$(mktemp -d --tmpdir updpkgsums.XXXXXX) - trap "rm -rf '$BUILDDIR'" EXIT - newsums=$(makepkg -g -p "$buildfile") && rm -f "$buildfile" && - awk -v newsums="$newsums" ' +# Generate the new sums +export BUILDDIR=$(mktemp -d --tmpdir updpkgsums.XXXXXX) +newbuildfile=$(mktemp --tmpdir updpkgsums.XXXXXX) + +# In case the eventual replacement fails, we don't want to leave behind +# $newbuildfile as garbage in $TMPDIR. This fails silently if the replacement +# succeeds. +trap "rm -rf '$BUILDDIR' '$newbuildfile'" EXIT +newsums=$(makepkg -g -p "$buildfile") && +awk -v newsums="$newsums" ' /^[[:blank:]]*(md|sha)[[:digit:]]+sums(_[^=]+)?=/,/\)[[:blank:]]*(#.*)?$/ { if (!w) { print newsums @@ -93,7 +98,11 @@ fi 1 END { if (!w) print newsums } - ' > "$buildfile" -} < "$buildfile" +' "$buildfile" > "$newbuildfile" + +# Replace the original buildfile. +if ! mv -- "$newbuildfile" "$buildfile"; then + die "Failed to update %s. The file has not been modified." "$buildfile" +fi # vim: set noet: -- 2.1.3

1 0