- Pacman-dev - lists.archlinux.org

[pacman-dev] [PATCH] handle time changes during progress display
by Andrew Gregory 28 Jun '14

28 Jun '14

Previously, if the system time was adjusted backwards during a progress display, get_update_timediff return negative values prevent the progress bar from updating. Instead, on negative values, the saved time is reset. Additionally, the download callback ignores the amount downloaded to avoid skewing the rate. Fixes FS#36983 Signed-off-by: Andrew Gregory <andrew.gregory.8(a)gmail.com> --- src/pacman/callback.c | 33 +++++++++++++++++++-------------- 1 file changed, 19 insertions(+), 14 deletions(-) diff --git a/src/pacman/callback.c b/src/pacman/callback.c index a181fa5..0ffb2ef 100644 --- a/src/pacman/callback.c +++ b/src/pacman/callback.c @@ -73,8 +73,8 @@ static long get_update_timediff(int first_call) retval = (diff_sec * 1000) + (diff_usec / 1000); - /* do not update last_time if interval was too short */ - if(retval >= UPDATE_SPEED_MS) { + /* update last_time if it is in the future or interval was long enough */ + if(retval < 0 || retval >= UPDATE_SPEED_MS) { last_time = this_time; } } @@ -554,7 +554,7 @@ void cb_dl_progress(const char *filename, off_t file_xfered, off_t file_total) { static double rate_last; static off_t xfered_last; - static struct timeval initial_time; + static long elapsed_time = 0; int infolen; int filenamelen; char *fname, *p; @@ -616,25 +616,23 @@ void cb_dl_progress(const char *filename, off_t file_xfered, off_t file_total) /* set default starting values, ensure we only call this once * if TotalDownload is enabled */ if(!totaldownload || (totaldownload && list_xfered == 0)) { - gettimeofday(&initial_time, NULL); + elapsed_time = 0; xfered_last = (off_t)0; rate_last = 0.0; get_update_timediff(1); } } else if(file_xfered == file_total) { /* compute final values */ - struct timeval current_time; - time_t diff_sec; - suseconds_t diff_usec; + timediff = get_update_timediff(0); - gettimeofday(&current_time, NULL); - diff_sec = current_time.tv_sec - initial_time.tv_sec; - diff_usec = current_time.tv_usec - initial_time.tv_usec; - timediff = (diff_sec * 1000) + (diff_usec / 1000); if(timediff > 0) { - rate = (double)xfered / (timediff / 1000.0); + elapsed_time += timediff; + } + + if(elapsed_time > 0) { + rate = (double)xfered / (elapsed_time / 1000.0); /* round elapsed time (in ms) to the nearest second */ - eta_s = (unsigned int)(timediff + 500) / 1000; + eta_s = (unsigned int)(elapsed_time + 500) / 1000; } else { eta_s = 0; } @@ -642,10 +640,17 @@ void cb_dl_progress(const char *filename, off_t file_xfered, off_t file_total) /* compute current average values */ timediff = get_update_timediff(0); - if(timediff < UPDATE_SPEED_MS) { + if(timediff < 0) { + /* we lost a chunk of time due to a clock change, including the amount + * xfered during that period in the next update would skew the rate */ + xfered_last = xfered; + return; + } else if(timediff < UPDATE_SPEED_MS) { /* return if the calling interval was too short */ return; } + + elapsed_time += timediff; rate = (double)(xfered - xfered_last) / (timediff / 1000.0); /* average rate to reduce jumpiness */ rate = (rate + 2 * rate_last) / 3; -- 1.8.4.2

4 6

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v4.1.2-360-gfa0c1e1
by allan＠archlinux.org 24 Jun '14

24 Jun '14

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, master has been updated via fa0c1e1419b4a73b4a522bc6f4117b8bf337eabe (commit) via 8dbb80cfe9e80a5b70ada4e0b58c97a28a9fc7f7 (commit) via f1fadecfb34555cfac1c47f217253a535d64a28b (commit) via d06d993d56bda499be31042bd39aaea9b8b11e3d (commit) via 7b41952bfc812becdaba45f7823ec653ed905752 (commit) via 537a335cc724a5c7c97824d33a2406b5dcea162d (commit) via 9ff6dc93afd2c09a0ca79d3d43c2d496c1416ef8 (commit) via d920e7053c5be3325e40f504f56a37ac8c779ad2 (commit) via b9f98ae97c9419a55b609988fefc6d4fc357d350 (commit) via 4d65332ccdbb462e9fa522b3a4cb59fd4e3f44d3 (commit) via 235ce32563031ef5c01d27a4f67cadba37597921 (commit) via 2401468f5104fa6794589381cef9e970692d95e8 (commit) from ec01a22f7d13147a52ac8c0c1ee1b5fc2426de39 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit fa0c1e1419b4a73b4a522bc6f4117b8bf337eabe Author: Silvan Jegen <s.jegen(a)gmail.com> Date: Mon Jun 23 17:51:05 2014 +0200 pacman: Correct signal handler comment and refactor One of the comments for this function is out of sync with the code. Since the code exhibits the more sane behavior of treating SIGINT and SIGHUB the same way (by not exiting pacman when there is a commit in flight) we adjust the comment. Given this code flow, the if/else statements can be simplified somewhat as well. Signed-off-by: Silvan Jegen <s.jegen(a)gmail.com> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 8dbb80cfe9e80a5b70ada4e0b58c97a28a9fc7f7 Author: Olivier Brunel <jjk(a)jjacky.com> Date: Sun Jun 15 19:43:07 2014 +0200 events: Make alpm_event_t an union of all event-specific struct Signed-off-by: Olivier Brunel <jjk(a)jjacky.com> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit f1fadecfb34555cfac1c47f217253a535d64a28b Author: Olivier Brunel <jjk(a)jjacky.com> Date: Sun Jun 15 19:42:40 2014 +0200 Update the question callback Much like with events, instead of using a bunch of void* arguments for all questions, we now send one pointer to an alpm_question_t union. This contains the type of question that was triggered. With this information, a question-specific struct can be accessed in order to get additional arguments. Signed-off-by: Olivier Brunel <jjk(a)jjacky.com> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit d06d993d56bda499be31042bd39aaea9b8b11e3d Author: Olivier Brunel <jjk(a)jjacky.com> Date: Sun Mar 16 13:40:54 2014 +0100 alpm.h: Move alpm_errno_t definition up Because for the new question types, we'll need to use alpm_errno_t let's move its definition up. Of course to do so, we also need to move that of alpm_handle_t as well, so move all opaque structures on top. Signed-off-by: Olivier Brunel <jjk(a)jjacky.com> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 7b41952bfc812becdaba45f7823ec653ed905752 Author: Hong Shick Pak <hong(a)hspak.com> Date: Sat Jun 14 22:37:31 2014 -0400 Move break to a new line for consistency This was the only break that didn't have its own line in the function parsearg_query. Signed-off-by: Hong Shick Pak <hong(a)hspak.com> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 537a335cc724a5c7c97824d33a2406b5dcea162d Author: Allan McRae <allan(a)archlinux.org> Date: Thu Jun 12 12:50:15 2014 +1000 Use C locale for bsdtar calls during package creation This ensures packages build on a UTF-8 locale system with non-ASCII character names can be installed on non-UTF-8 systems. Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 9ff6dc93afd2c09a0ca79d3d43c2d496c1416ef8 Author: Johannes Löthberg <johannes(a)kyriasis.com> Date: Mon Jun 2 06:49:10 2014 +0200 makepkg: Remove redundant sig generation comment Remove the comment above the signature generation command as the command is self explanatory and no longer does what the comment says. Signed-off-by: Allan McRae <allan(a)archlinux.org> commit d920e7053c5be3325e40f504f56a37ac8c779ad2 Author: Florian Pritz <bluewind(a)xinu.at> Date: Mon Jun 9 14:21:04 2014 +0200 Add test case for the perl 5.20 dependency breakage This test currently fails. Signed-off-by: Florian Pritz <bluewind(a)xinu.at> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit b9f98ae97c9419a55b609988fefc6d4fc357d350 Author: Allan McRae <allan(a)archlinux.org> Date: Mon Jun 2 09:43:57 2014 +1000 Add compatibility with gpgme-1.5.0 Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 4d65332ccdbb462e9fa522b3a4cb59fd4e3f44d3 Author: Allan McRae <allan(a)archlinux.org> Date: Sun May 25 14:37:01 2014 +1000 Clarify that -Ql prints a file list FS#40234 Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 235ce32563031ef5c01d27a4f67cadba37597921 Author: Andrew DeMaria <lostonamountain(a)gmail.com> Date: Sun May 25 13:59:26 2014 +1000 makepkg: pass "--nocolor" to pacman FS#39982. Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 2401468f5104fa6794589381cef9e970692d95e8 Author: Allan McRae <allan(a)archlinux.org> Date: Sun May 25 13:53:19 2014 +1000 makepkg: Force buildscripts to be in startdir We expect all source file to lie in $startdir. However, using "makepkg -p <buildscript>" can currently allows people to specify buildscripts in other directories. This results in confusion about where other sources should lie (in startdir or in the directory that the buildscript is in). Explicitly disable using -p for files in other directories to avoid this issue. Fixes FS#40293. Signed-off-by: Allan McRae <allan(a)archlinux.org> ----------------------------------------------------------------------- Summary of changes: doc/makepkg.8.txt | 3 +- lib/libalpm/alpm.h | 304 ++++++++++++++------- lib/libalpm/deps.c | 38 ++- lib/libalpm/handle.h | 4 +- lib/libalpm/signing.c | 16 +- lib/libalpm/sync.c | 60 ++-- scripts/makepkg.sh.in | 15 +- src/pacman/callback.c | 135 ++++----- src/pacman/callback.h | 3 +- src/pacman/pacman.c | 11 +- test/pacman/tests/TESTS | 1 + ...nc-update-package-removing-required-provides.py | 23 ++ 12 files changed, 401 insertions(+), 212 deletions(-) create mode 100644 test/pacman/tests/sync-update-package-removing-required-provides.py hooks/post-receive -- The official pacman repository

1 0

[pacman-dev] [PATCH] pacman: Correct signal handler behavior
by Silvan Jegen 23 Jun '14

23 Jun '14

One of the comments for this function is out of sync with the code. If a SIGHUP is received the code calls the release function only if there is no transaction in flight (contrary to the comments). This change brings the code in line with the comment (and moves the comment for readability). Additionally, it changes the exit message to reflect the fact that the signal received was either a SIGHUP or a SIGTERM. Signed-off-by: Silvan Jegen <s.jegen(a)gmail.com> --- src/pacman/pacman.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/pacman/pacman.c b/src/pacman/pacman.c index ef86d39..599a141 100644 --- a/src/pacman/pacman.c +++ b/src/pacman/pacman.c @@ -301,20 +301,20 @@ static void handler(int signum) "Please submit a full bug report with --debug if appropriate.\n"; xwrite(err, msg, strlen(msg)); exit(signum); - } else if(signum == SIGINT || signum == SIGHUP) { - if(signum == SIGINT) { - msg = "\nInterrupt signal received\n"; - } else { - msg = "\nHangup signal received\n"; - } - xwrite(err, msg, strlen(msg)); + } + /* SIGINT: no committing transaction, release it now and then exit pacman + * SIGHUP, SIGTERM: release no matter what */ + if(signum == SIGINT) { + msg = "\nInterrupt signal received\n"; if(alpm_trans_interrupt(config->handle) == 0) { /* a transaction is being interrupted, don't exit pacman yet. */ return; } + } else { + msg = "\nHangup/Termination signal received\n"; } - /* SIGINT: no committing transaction, release it now and then exit pacman - * SIGHUP, SIGTERM: release no matter what */ + + xwrite(err, msg, strlen(msg)); alpm_trans_release(config->handle); /* output a newline to be sure we clear any line we may be on */ xwrite(out, "\n", 1); -- 2.0.0

3 7

[pacman-dev] [PATCH] events: Make alpm_event_t an union of all event-specific struct
by Olivier Brunel 23 Jun '14

23 Jun '14

Signed-off-by: Olivier Brunel <jjk(a)jjacky.com> --- Similar as changes done re: questions. lib/libalpm/alpm.h | 29 ++++++++++++++++++++++------- src/pacman/callback.c | 25 ++++++++++++------------- 2 files changed, 34 insertions(+), 20 deletions(-) diff --git a/lib/libalpm/alpm.h b/lib/libalpm/alpm.h index b0adb95..ffd71c6 100644 --- a/lib/libalpm/alpm.h +++ b/lib/libalpm/alpm.h @@ -361,15 +361,10 @@ typedef enum _alpm_event_type_t { ALPM_EVENT_PACORIG_CREATED } alpm_event_type_t; -/** Events. - * This is a generic struct this is passed to the callback, that allows the - * frontend to know which type of event was triggered. It is then possible to - * typecast the pointer to the right structure, in order to access - * event-specific data. */ -typedef struct _alpm_event_t { +typedef struct _alpm_event_any_t { /** Type of event. */ alpm_event_type_t type; -} alpm_event_t; +} alpm_event_any_t; typedef enum _alpm_package_operation_t { /** Package (to be) installed. (No oldpkg) */ @@ -481,6 +476,26 @@ typedef struct _alpm_event_pacorig_created_t { const char *file; } alpm_event_pacorig_created_t; +/** Events. + * This is an union passed to the callback, that allows the frontend to know + * which type of event was triggered (via type). It is then possible to + * typecast the pointer to the right structure, or use the union field, in order + * to access event-specific data. */ +typedef union _alpm_event_t { + alpm_event_type_t type; + alpm_event_any_t any; + alpm_event_package_operation_t package_operation; + alpm_event_optdep_removal_t optdep_removal; + alpm_event_delta_patch_t delta_patch; + alpm_event_scriptlet_info_t scriptlet_info; + alpm_event_database_missing_t database_missing; + alpm_event_log_t log; + alpm_event_pkgdownload_t pkgdownload; + alpm_event_pacnew_created_t pacnew_created; + alpm_event_pacsave_created_t pacsave_created; + alpm_event_pacorig_created_t pacorig_created; +} alpm_event_t; + /** Event callback. */ typedef void (*alpm_cb_event)(alpm_event_t *); diff --git a/src/pacman/callback.c b/src/pacman/callback.c index 340a3a1..88f5313 100644 --- a/src/pacman/callback.c +++ b/src/pacman/callback.c @@ -171,7 +171,7 @@ void cb_event(alpm_event_t *event) break; case ALPM_EVENT_PACKAGE_OPERATION_START: if(config->noprogressbar) { - alpm_event_package_operation_t *e = (alpm_event_package_operation_t *) event; + alpm_event_package_operation_t *e = &event->package_operation; switch(e->operation) { case ALPM_PACKAGE_INSTALL: printf(_("installing %s...\n"), alpm_pkg_get_name(e->newpkg)); @@ -193,7 +193,7 @@ void cb_event(alpm_event_t *event) break; case ALPM_EVENT_PACKAGE_OPERATION_DONE: { - alpm_event_package_operation_t *e = (alpm_event_package_operation_t *) event; + alpm_event_package_operation_t *e = &event->package_operation; switch(e->operation) { case ALPM_PACKAGE_INSTALL: display_optdepends(e->newpkg); @@ -233,10 +233,9 @@ void cb_event(alpm_event_t *event) printf(_("applying deltas...\n")); break; case ALPM_EVENT_DELTA_PATCH_START: - { - alpm_event_delta_patch_t *e = (alpm_event_delta_patch_t *) event; - printf(_("generating %s with %s... "), e->delta->to, e->delta->delta); - } + printf(_("generating %s with %s... "), + event->delta_patch.delta->to, + event->delta_patch.delta->delta); break; case ALPM_EVENT_DELTA_PATCH_DONE: printf(_("success!\n")); @@ -245,7 +244,7 @@ void cb_event(alpm_event_t *event) printf(_("failed.\n")); break; case ALPM_EVENT_SCRIPTLET_INFO: - fputs(((alpm_event_scriptlet_info_t *) event)->line, stdout); + fputs(event->scriptlet_info.line, stdout); break; case ALPM_EVENT_RETRIEVE_START: colon_printf(_("Retrieving packages ...\n")); @@ -257,7 +256,7 @@ void cb_event(alpm_event_t *event) break; case ALPM_EVENT_OPTDEP_REMOVAL: { - alpm_event_optdep_removal_t *e = (alpm_event_optdep_removal_t *) event; + alpm_event_optdep_removal_t *e = &event->optdep_removal; colon_printf(_("%s optionally requires %s\n"), alpm_pkg_get_name(e->pkg), alpm_dep_compute_string(e->optdep)); @@ -267,12 +266,12 @@ void cb_event(alpm_event_t *event) if(!config->op_s_sync) { pm_printf(ALPM_LOG_WARNING, "database file for '%s' does not exist\n", - ((alpm_event_database_missing_t *) event)->dbname); + event->database_missing.dbname); } break; case ALPM_EVENT_LOG: { - alpm_event_log_t *e = (alpm_event_log_t *) event; + alpm_event_log_t *e = &event->log; if(!e->fmt || strlen(e->fmt) == 0) { break; } @@ -290,7 +289,7 @@ void cb_event(alpm_event_t *event) break; case ALPM_EVENT_PACNEW_CREATED: { - alpm_event_pacnew_created_t *e = (alpm_event_pacnew_created_t *) event; + alpm_event_pacnew_created_t *e = &event->pacnew_created; if(on_progress) { char *string = NULL; pm_sprintf(&string, ALPM_LOG_WARNING, _("%s installed as %s.pacnew\n"), @@ -306,7 +305,7 @@ void cb_event(alpm_event_t *event) break; case ALPM_EVENT_PACSAVE_CREATED: { - alpm_event_pacsave_created_t *e = (alpm_event_pacsave_created_t *) event; + alpm_event_pacsave_created_t *e = &event->pacsave_created; if(on_progress) { char *string = NULL; pm_sprintf(&string, ALPM_LOG_WARNING, _("%s saved as %s.pacsave\n"), @@ -322,7 +321,7 @@ void cb_event(alpm_event_t *event) break; case ALPM_EVENT_PACORIG_CREATED: { - alpm_event_pacorig_created_t *e = (alpm_event_pacorig_created_t *) event; + alpm_event_pacorig_created_t *e = &event->pacorig_created; if(on_progress) { char *string = NULL; pm_sprintf(&string, ALPM_LOG_WARNING, _("%s saved as %s.pacorig\n"), -- 2.0.0

2 2

[pacman-dev] [PATCH] Move break to a new line for consistency
by Hong Shick Pak 23 Jun '14

23 Jun '14

This was the only break that didn't have its own line in the function parsearg_query. Signed-off-by: Hong Shick Pak <hong(a)hspak.com> --- src/pacman/pacman.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/pacman/pacman.c b/src/pacman/pacman.c index ef86d39..af43656 100644 --- a/src/pacman/pacman.c +++ b/src/pacman/pacman.c @@ -549,7 +549,8 @@ static int parsearg_query(int opt) break; case OP_UPGRADES: case 'u': - config->op_q_upgrade = 1; break; + config->op_q_upgrade = 1; + break; default: return 1; } -- 2.0.0

2 1

Re: [pacman-dev] [PATCH 1/1] libalpm: check for valid public key algorithm
by Allan McRae 23 Jun '14

23 Jun '14

Accidentally replied off-list. On 23/06/14 22:08, Allan McRae wrote: > On 12/06/14 16:48, Christian Hesse wrote: >> --- >> lib/libalpm/signing.c | 9 ++++++++- >> 1 file changed, 8 insertions(+), 1 deletion(-) >> >> diff --git a/lib/libalpm/signing.c b/lib/libalpm/signing.c >> index 8fb909d..f657110 100644 >> --- a/lib/libalpm/signing.c >> +++ b/lib/libalpm/signing.c >> @@ -350,7 +350,14 @@ static int key_search(alpm_handle_t *handle, const char *fpr, >> break; >> } >> >> - ret = 1; >> + /* We do not want to add a default case above to receive compiler >> + * error on new public key algorithm in gpgme. So check here if we >> + * have a valid pubkey_algo, should have been initialize with 0. */ >> + if (pgpkey->pubkey_algo != 0) { >> + ret = 1; >> + } else { >> + _alpm_log(handle, ALPM_LOG_DEBUG, "unknown public key algorithm\n"); >> + } >> > > If we set ret=1 here, at gpg_error: we try printing the error... > >> gpg_error: >> if(ret != 1) { >> > > How about adding "cleanup:" after the if(ret != 1) block and using this > after your comment: > > if (pgpkey->pubkey_algo == 0) { > _alpm_log(handle, ALPM_LOG_DEBUG, "unknown public key algorithm\n"); > ret = 1; > goto cleanup; > } >

1 0

[pacman-dev] [PATCH] [RFC] Add bacman manpage, fix #36419
by prflr88＠gmail.com 23 Jun '14

23 Jun '14

From: Pablo Lezaeta <prflr88(a)gmail.com> This add bacman manpage (if I'm not missing something) for bacman. I think this manpage could be improved, but for a first draft (and a RFC) is ok. Signed-off-by: Pablo Lezaeta <prflr88(a)gmail.com> --- doc/Makefile.am | 4 ++++ doc/bacman.8.txt | 36 ++++++++++++++++++++++++++++++++++++ doc/index.txt | 1 + 3 files changed, 41 insertions(+) create mode 100644 doc/bacman.8.txt diff --git a/doc/Makefile.am b/doc/Makefile.am index a7908df..30fc672 100644 --- a/doc/Makefile.am +++ b/doc/Makefile.am @@ -4,6 +4,7 @@ # man_MANS if --enable-asciidoc and/or --enable-doxygen are used. ASCIIDOC_MANS = \ + bacman.8 \ pacman.8 \ makepkg.8 \ makepkg-template.1 \ @@ -20,6 +21,7 @@ ASCIIDOC_MANS = \ DOXYGEN_MANS = $(wildcard man3/*.3) HTML_MANPAGES = \ + bacman.8.html \ pacman.8.html \ makepkg.8.html \ makepkg-template.1.html \ @@ -46,6 +48,7 @@ HTML_DOCS = \ EXTRA_DIST = \ asciidoc.conf \ asciidoc-override.css \ + bacman.8.txt \ pacman.8.txt \ makepkg.8.txt \ makepkg-template.1.txt \ @@ -148,6 +151,7 @@ $(HTML_OTHER): asciidoc.conf Makefile.am %.3.html: ASCIIDOC_OPTS += -d manpage # Dependency rules +bacman.8 bacman.8.html: bacman.8.txt pacman.8 pacman.8.html: pacman.8.txt makepkg.8 makepkg.8.html: makepkg.8.txt makepkg-template.1 makepkg-template.1.html: makepkg-template.1.txt diff --git a/doc/bacman.8.txt b/doc/bacman.8.txt new file mode 100644 index 0000000..c677fc0 --- /dev/null +++ b/doc/bacman.8.txt @@ -0,0 +1,36 @@ +///// +vim:set ts=4 sw=4 syntax=asciidoc noet spell spelllang=en_us: +///// +bacman(8) +========= + + +Name +---- +bacman - recreates a package using pacman's db and system files + + +Synopsis +-------- +'bacman' [options] installed-package-name + +Description +----------- +recreates a package using pacman's db and system files + +Options +------- +*-h, \--help*:: + Output syntax and command line options. + +*-v, \--version*:: + Output version of bacman and exit. + +*\--nocolor*:: + Output without colors. + +See Also +-------- +linkman:pacman[8] + +include::footer.txt[] \ No newline at end of file diff --git a/doc/index.txt b/doc/index.txt index ab1dc79..1b611bc 100644 --- a/doc/index.txt +++ b/doc/index.txt @@ -43,6 +43,7 @@ configuration files dealing with pacman. * linkman:libalpm[3] * linkman:makepkg[8] * linkman:makepkg.conf[5] +* linkman:bacman[8] * linkman:pacman[8] * linkman:pacman-key[8] * linkman:pacman.conf[5] -- 2.0.0

2 1

[pacman-dev] [PATCH] check_pkg_full: check user/group names
by Andrew Gregory 13 Jun '14

13 Jun '14

The effect on MTREE file size is negligible and this provides a more reliable way to verify file ownership given that user/group ids are not standardized. Signed-off-by: Andrew Gregory <andrew.gregory.8(a)gmail.com> --- scripts/makepkg.sh.in | 2 +- src/pacman/check.c | 24 ++++++++++++++++++++++++ 2 files changed, 25 insertions(+), 1 deletion(-) diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index e20b707..c77b28b 100644 --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in @@ -1999,7 +1999,7 @@ create_package() { msg2 "$(gettext "Generating .MTREE file...")" LANG=C bsdtar -czf .MTREE --format=mtree \ - --options='!all,use-set,type,uid,gid,mode,time,size,md5,sha256,link' \ + --options='!all,use-set,type,uid,uname,gid,gname,mode,time,size,md5,sha256,link' \ "${comp_files[@]}" * comp_files+=(".MTREE") diff --git a/src/pacman/check.c b/src/pacman/check.c index a7c66ba..d4a11a5 100644 --- a/src/pacman/check.c +++ b/src/pacman/check.c @@ -20,6 +20,8 @@ #include <limits.h> #include <string.h> #include <errno.h> +#include <grp.h> +#include <pwd.h> /* pacman */ #include "check.h" @@ -69,6 +71,10 @@ static int check_file_permissions(const char *pkgname, const char *filepath, { int errors = 0; mode_t fsmode; + struct passwd *pw = getpwuid(st->st_uid); + struct group *gr = getgrgid(st->st_gid); + const char *uname = archive_entry_uname(entry); + const char *gname = archive_entry_gname(entry); /* uid */ if(st->st_uid != archive_entry_uid(entry)) { @@ -79,6 +85,15 @@ static int check_file_permissions(const char *pkgname, const char *filepath, } } + /* owner name */ + if(uname && (!pw || strcmp(pw->pw_name, uname) != 0)) { + errors++; + if(!config->quiet) { + pm_printf(ALPM_LOG_WARNING, _("%s: %s (Owner mismatch)\n"), + pkgname, filepath); + } + } + /* gid */ if(st->st_gid != archive_entry_gid(entry)) { errors++; @@ -88,6 +103,15 @@ static int check_file_permissions(const char *pkgname, const char *filepath, } } + /* group name */ + if(gname && (!gr || strcmp(gr->gr_name, gname) != 0)) { + errors++; + if(!config->quiet) { + pm_printf(ALPM_LOG_WARNING, _("%s: %s (Group mismatch)\n"), + pkgname, filepath); + } + } + /* mode */ fsmode = st->st_mode & (S_ISUID | S_ISGID | S_ISVTX | S_IRWXU | S_IRWXG | S_IRWXO); if(fsmode != (~AE_IFMT & archive_entry_mode(entry))) { -- 2.0.0

2 2

Re: [pacman-dev] [PATCH 1/1] libalpm: add default switch case to handle unknown pubkey algorithm
by Allan McRae 12 Jun '14

12 Jun '14

On 11/06/14 23:37, Christian Hesse wrote: > --- > lib/libalpm/signing.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/lib/libalpm/signing.c b/lib/libalpm/signing.c > index 8fb909d..a7a70f6 100644 > --- a/lib/libalpm/signing.c > +++ b/lib/libalpm/signing.c > @@ -348,6 +348,11 @@ static int key_search(alpm_handle_t *handle, const char *fpr, > #endif > pgpkey->pubkey_algo = 'E'; > break; > + > + default: > + _alpm_log(handle, ALPM_LOG_DEBUG, "unknown public key algorithm\n"); > + ret = 0; > + goto gpg_error; > } > > ret = 1; > I like how we got a compile failure on the last gpgme update to flag we needed to deal with the new enum value. So I am not sure about adding the default here.

2 1

[pacman-dev] [PATCH] Use C locale for bsdtar calls during package creation
by Allan McRae 12 Jun '14

12 Jun '14

This ensures packages build on a UTF-8 locale system with non-ASCII character names can be installed on non-UTF-8 systems. Signed-off-by: Allan McRae <allan(a)archlinux.org> --- Arch Linux has been explicitly setting the C locale when packaging with devtools for a long time. I think it is best we address this at the source. bsdtar will give a warning when dealing with a file having non-ASCII characters during packaging, but the resulting package works. scripts/makepkg.sh.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index 4174ba5..e20b707 100644 --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in @@ -1998,7 +1998,7 @@ create_package() { shopt -s nullglob msg2 "$(gettext "Generating .MTREE file...")" - bsdtar -czf .MTREE --format=mtree \ + LANG=C bsdtar -czf .MTREE --format=mtree \ --options='!all,use-set,type,uid,gid,mode,time,size,md5,sha256,link' \ "${comp_files[@]}" * comp_files+=(".MTREE") @@ -2009,7 +2009,7 @@ create_package() { # bsdtar's gzip compression always saves the time stamp, making one # archive created using the same command line distinct from another. # Disable bsdtar compression and use gzip -n for now. - bsdtar -cf - "${comp_files[@]}" * | + LANG=C bsdtar -cf - "${comp_files[@]}" * | case "$PKGEXT" in *tar.gz) ${COMPRESSGZ[@]:-gzip -c -f -n} ;; *tar.bz2) ${COMPRESSBZ2[@]:-bzip2 -c -f} ;; @@ -2143,7 +2143,7 @@ create_srcpackage() { # tar it up msg2 "$(gettext "Compressing source package...")" cd_safe "${srclinks}" - if ! bsdtar -cL ${TAR_OPT} -f "$pkg_file" ${pkgbase}; then + if ! LANG=C bsdtar -cL ${TAR_OPT} -f "$pkg_file" ${pkgbase}; then error "$(gettext "Failed to create source package file.")" exit 1 # TODO: error code fi -- 2.0.0

1 0