- Pacman-dev - lists.archlinux.org

[pacman-dev] [PATCH v2] pacscripts: Improve error message when sudo binary is not found
by Jason St. John 16 Nov '13

16 Nov '13

Signed-off-by: Jason St. John <jstjohn(a)purdue.edu> --- This is a resubmit of my previous patch here: https://mailman.archlinux.org/pipermail/pacman-dev/2013-November/018212.html contrib/pacscripts.sh.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/contrib/pacscripts.sh.in b/contrib/pacscripts.sh.in index 8453f9c..da7c55a 100644 --- a/contrib/pacscripts.sh.in +++ b/contrib/pacscripts.sh.in @@ -71,8 +71,8 @@ spacman() { pacman "$@" else if ! type -p sudo; then - error "Cannot find the sudo binary! Is sudo installed?" - error "Otherwise, try to run the program as root" + error "Cannot find the sudo binary!" + error "${myname} requires root privileges. Either install \"sudo\" or run as root." exit 1 else sudo pacman "$@" -- 1.8.4.2

1 0

[pacman-dev] [PATCH] Close file descirptor before fork
by Allan McRae 15 Nov '13

15 Nov '13

From: Wolfgang Bumiller <wry.git(a)bumiller.com> FreeBSD chroot(2) fails with EPERM when a directory file descriptor is open with either `kern.chroot_allow_open_directories` being 0, or when the process already is inside a chroot. This is exposed in alpm_run_chroot that uses opendir() to open a file descriptor to the current directory before doing the forking and chrooting. Since the file descriptor is not used in the forked process, we close it. Fixes FS#36161. Signed-off-by: Allan McRae <allan(a)archlinux.org> --- lib/libalpm/util.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/libalpm/util.c b/lib/libalpm/util.c index f9fdb01..40a5ebd 100644 --- a/lib/libalpm/util.c +++ b/lib/libalpm/util.c @@ -542,6 +542,7 @@ int _alpm_run_chroot(alpm_handle_t *handle, const char *cmd, char *const argv[]) while(dup2(pipefd[1], 2) == -1 && errno == EINTR); close(pipefd[0]); close(pipefd[1]); + close(cwdfd); /* use fprintf instead of _alpm_log to send output through the parent */ if(chroot(handle->root) != 0) { -- 1.8.4.2

1 0

[pacman-dev] [PATCH] Fix misspellings and some grammar issues in output of some pacman contrib scripts
by Jason St. John 15 Nov '13

15 Nov '13

Affected files: -- contrib/bacman.sh.in -- contrib/paccache.sh.in -- contrib/pacdiff.sh.in -- contrib/rankmirrors.sh.in Signed-off-by: Jason St. John <jstjohn(a)purdue.edu> --- My Vim function to trim trailing whitespace caught some, but it seemed insignificant enough to not warrant an explicit mention in the commit message. contrib/bacman.sh.in | 4 ++-- contrib/paccache.sh.in | 4 ++-- contrib/pacdiff.sh.in | 10 +++++----- contrib/rankmirrors.sh.in | 41 +++++++++++++++++++++++++++++------------ 4 files changed, 38 insertions(+), 21 deletions(-) diff --git a/contrib/bacman.sh.in b/contrib/bacman.sh.in index a20c5e7..222b0f8 100644 --- a/contrib/bacman.sh.in +++ b/contrib/bacman.sh.in @@ -210,8 +210,8 @@ while read i; do # Workaround to bsdtar not reporting a missing file as an error if ! [[ -e $package_file || -L $package_file ]]; then error "unable to add $local_file to the package" - plain " If your user does not have permission to read this file then" - plain " you will need to run $myname as root" + plain " If your user does not have permission to read this file, then" + plain " you will need to run $myname as root." rm -rf "$work_dir" exit 1 fi diff --git a/contrib/paccache.sh.in b/contrib/paccache.sh.in index 10eab21..8db1eae 100644 --- a/contrib/paccache.sh.in +++ b/contrib/paccache.sh.in @@ -147,7 +147,7 @@ summarize() { fi printf '\n' >&2 - msg "$output (diskspace saved: %s)" "$(size_to_human "$totalsaved")" + msg "$output (disk space saved: %s)" "$(size_to_human "$totalsaved")" } usage() { @@ -269,7 +269,7 @@ esac die "cachedir '%s' does not exist or is not a directory" "$cachedir" [[ $movedir && ! -d $movedir ]] && - die "move-to directory '%s' does not exist or is not a directory" "$movedir" + die "destination directory '%s' does not exist or is not a directory" "$movedir" if (( move || delete )); then # make it an absolute path since we're about to chdir diff --git a/contrib/pacdiff.sh.in b/contrib/pacdiff.sh.in index 1bad0e4..8d43348 100644 --- a/contrib/pacdiff.sh.in +++ b/contrib/pacdiff.sh.in @@ -39,7 +39,7 @@ A simple program to merge or remove pacnew/pacorig/pacsave files. Usage: $myname [-l | -f | -p] [--nocolor] -Search Options: select one, default: pacmandb +Search Options: select one (default: --pacmandb) -l/--locate scan using locate -f/--find scan using find -p/--pacmandb scan active config files from pacman database @@ -73,7 +73,7 @@ print_existing_pacsave(){ for f in "${1}"?(.+([0-9])); do [[ -f $f ]] && printf '%s\0' "$f" done -} +} cmd() { if (( USE_LOCATE )); then @@ -94,7 +94,7 @@ cmd() { fi } -while [[ -n "$1" ]]; do +while [[ -n "$1" ]]; do case "$1" in -l|--locate) USE_LOCATE=1;; @@ -138,7 +138,7 @@ if (( USE_PACDB )); then eval $(awk '/DBPath/ {print $1$2$3}' @sysconfdir@/pacman.conf) pac_db="${DBPath:-@localstatedir@/lib/pacman/}local" if [[ ! -d "${pac_db}" ]]; then - error "unable to read pacman db %s". "${pac_db}" + error "unable to read pacman database %s". "${pac_db}" usage; exit 1 fi fi @@ -147,7 +147,7 @@ fi while IFS= read -u 3 -r -d '' pacfile; do file="${pacfile%.pac*}" file_type="pac${pacfile##*.pac}" - + if (( OUTPUTONLY )); then echo "$pacfile" continue diff --git a/contrib/rankmirrors.sh.in b/contrib/rankmirrors.sh.in index 0c4c734..453ebfb 100644 --- a/contrib/rankmirrors.sh.in +++ b/contrib/rankmirrors.sh.in @@ -130,8 +130,15 @@ while [[ $1 ]]; do version) version ;; times) TIMESONLY=1 ; shift ;; verbose) VERBOSE=1 ; shift ;; - url) CHECKURL=1; [[ $2 ]] || err "Must specify url."; URL="$2"; shift 2;; - repo) [[ $2 ]] || err "Must specify repo name."; TARGETREPO="$2"; shift 2;; + url) + CHECKURL=1; + [[ $2 ]] || err "Must specify URL."; + URL="$2"; + shift 2;; + repo) + [[ $2 ]] || err "Must specify repository name."; + TARGETREPO="$2"; + shift 2;; *) err "'$1' is an invalid argument." esac elif [[ ${1:0:1} = - ]]; then @@ -148,9 +155,19 @@ while [[ $1 ]]; do h) usage ;; t) TIMESONLY=1 ;; v) VERBOSE=1 ;; - u) CHECKURL=1; [[ $2 ]] || err "Must specify url."; URL="$2"; snum=2;; - r) [[ $2 ]] || err "Must specify repo name."; TARGETREPO="$2"; snum=2;; - n) [[ $2 ]] || err "Must specify number." ; NUM="$2" ; snum=2;; + u) + CHECKURL=1; + [[ $2 ]] || err "Must specify URL."; + URL="$2"; + snum=2;; + r) + [[ $2 ]] || err "Must specify repository name."; + TARGETREPO="$2"; + snum=2;; + n) + [[ $2 ]] || err "Must specify number."; + NUM="$2"; + snum=2;; *) err "'$1' is an invalid argument." ;; esac done @@ -168,22 +185,22 @@ done # Some sanity checks [[ $NUM ]] || NUM=0 -[[ $FILE && $CHECKURL ]] && err "Cannot specify a url and mirrorfile." -[[ $FILE || $CHECKURL || $STDIN ]] || err "Must specify url, mirrorfile, or stdin." +[[ $FILE && $CHECKURL ]] && err "Cannot specify a URL and mirrorfile." +[[ $FILE || $CHECKURL || $STDIN ]] || err "Must specify URL, mirrorfile, or stdin." -# Single url handling +# Single URL handling if [[ $CHECKURL ]]; then url="$(getfetchurl "$URL")" - [[ $url = fail ]] && err "url '$URL' is malformed." + [[ $url = fail ]] && err "URL '$URL' is malformed." [[ $VERBOSE ]] && echo "Testing $url..." time=$(gettime "$url") echo "$URL : $time" exit 0 fi -# Get url results from mirrorfile, fill up the array, and so on +# Get URL results from mirrorfile, fill up the array, and so on if [[ $TIMESONLY ]]; then - echo "Querying servers, this may take some time..." + echo "Querying servers. This may take some time..." elif [[ $FILE ]]; then echo "# Server list generated by rankmirrors on $(date +%Y-%m-%d)" fi @@ -198,7 +215,7 @@ for line in "${linearray[@]}"; do server="${line#*= }" server="${server%%#*}" url="$(getfetchurl "$server")" - [[ $url = fail ]] && err "url '$URL' is malformed." + [[ $url = fail ]] && err "URL '$URL' is malformed." time=$(gettime "$url") timesarray+=("$time $server") -- 1.8.4.2

1 0

[pacman-dev] [PATCH] .gitignore: Add intl directory.
by Allan McRae 15 Nov '13

15 Nov '13

Signed-off-by: Allan McRae <allan(a)archlinux.org> --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index f565b43..df0f138 100644 --- a/.gitignore +++ b/.gitignore @@ -13,6 +13,7 @@ configure.lineno cscope.in.out cscope.out cscope.po.out +intl libtool Makefile Makefile.in -- 1.8.4.2

1 0

[pacman-dev] [PATCH] paccache: clarify help output
by Allan McRae 15 Nov '13

15 Nov '13

The help output referred to variables in the script rather than what they were labelled in the parameter argument. Signed-off-by: Allan McRae <allan(a)archlinux.org> --- contrib/paccache.sh.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/contrib/paccache.sh.in b/contrib/paccache.sh.in index 10eab21..885193f 100644 --- a/contrib/paccache.sh.in +++ b/contrib/paccache.sh.in @@ -160,19 +160,19 @@ Usage: ${myname} <operation> [options] [targets...] Operations: -d, --dryrun perform a dry run, only finding candidate packages. - -m, --move <dir> move candidate packages to "movedir". + -m, --move <dir> move candidate packages to "dir". -r, --remove remove candidate packages. Options: -a, --arch <arch> scan for "arch" (default: all architectures). - -c, --cachedir <dir> scan "cachedir" for packages. + -c, --cachedir <dir> scan "dir" for packages. (default: @localstatedir@/cache/pacman/pkg). -f, --force apply force to mv(1) and rm(1) operations. -h, --help display this help message and exit. -i, --ignore <pkgs> ignore "pkgs", comma-separated. Alternatively, specify "-" to read package names from stdin, newline- delimited. - -k, --keep <num> keep "num" of each package in "cachedir" (default: 3). + -k, --keep <num> keep "num" of each package in the cache (default: 3). --nocolor remove color from output. -u, --uninstalled target uninstalled packages. -v, --verbose increase verbosity. specify up to 3 times. -- 1.8.4.2

1 0

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v4.1.2-207-ga15fd48
by allan＠archlinux.org 15 Nov '13

15 Nov '13

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, master has been updated via a15fd48016014249a13db7a437b5e4f5937f6158 (commit) via 7bfaa358ea45c5d527a382bb5fef734b3134bd6f (commit) via 1645dfd3d120f26f9d59a952c89ea35514f14992 (commit) via 230bd5c2fd11f6256e1ab16c2e5997a8d8228461 (commit) via b7b3f9c5e7903272bef32792ab28615f434d3ec8 (commit) via d78f45ae0c11fb19a1a0bf30728386e9febe0705 (commit) via ea6aeef8bae01d934cb4aab6d915e0e3e8276df1 (commit) via 0da98ec6bac17b4f56b67a6f5b2fa24896671a9f (commit) via 5273e38fb254d6bfb9bce9078d346f3c08a294b1 (commit) via da8cd388c4fd95d1748285e4d6bd549c776ef5e1 (commit) via 57090d8cba65988b822a215947a5fb44d55790d0 (commit) via af284d5fdb0ef15dbb7a2082380e2ec586599774 (commit) via 88df07717de868dc2bd2424afefaea6c77efa4c0 (commit) via 14cc790c59e55f4a3f4d7fc47a2f60c468c5887b (commit) via 0c180cb7cc890fdf162f3624d3fbeb6af95d2557 (commit) via fe824f87b9f1e40d88bd1a190a0bc1c80f2e91eb (commit) via 5c5b28833c0c47d31c58d40cd13b69227de6eb48 (commit) from d5acf7a44a41c0ac8224895a9f15f3d04e80811d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a15fd48016014249a13db7a437b5e4f5937f6158 Author: Jason St. John <jstjohn(a)purdue.edu> Date: Fri Nov 8 02:53:33 2013 -0500 Improve --help switch output for pacman contrib and pacman scripts Unify the formatting of the --help switch for pacman utils, if it exists. All of the pacman utils will now output help text using the following format: util-name (pacman) v<pacman version> one line description of util's purpose Usage: util-name [options] -b, --bar whatever --bar does -f, --foo whatever --foo does -h, --help display this help message Reported-by: Karol Błażewicz <karol.blazewicz at gmail.com> Signed-off-by: Jason St. John <jstjohn(a)purdue.edu> commit 7bfaa358ea45c5d527a382bb5fef734b3134bd6f Author: Jason St. John <jstjohn(a)purdue.edu> Date: Fri Nov 8 13:21:46 2013 -0500 Replace "echo" command with "printf" in human_to_size_test.sh Signed-off-by: Jason St. John <jstjohn(a)purdue.edu> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 1645dfd3d120f26f9d59a952c89ea35514f14992 Author: Jason St. John <jstjohn(a)purdue.edu> Date: Fri Nov 8 00:49:05 2013 -0500 Fix typo in pacman-optimize Signed-off-by: Jason St. John <jstjohn(a)purdue.edu> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 230bd5c2fd11f6256e1ab16c2e5997a8d8228461 Author: Jason St. John <jstjohn(a)purdue.edu> Date: Fri Nov 8 00:44:40 2013 -0500 Fix whitespace and other formatting issues This commit: -- replaces space-based indents with tabs per the coding standards -- removes extraneous whitespace (e.g. extra spaces between function args) -- adds missing braces for a one-line if statement Signed-off-by: Jason St. John <jstjohn(a)purdue.edu> commit b7b3f9c5e7903272bef32792ab28615f434d3ec8 Author: Jason St. John <jstjohn(a)purdue.edu> Date: Thu Nov 7 23:26:19 2013 -0500 Fix minor grammatical issues in doc/index.txt Signed-off-by: Jason St. John <jstjohn(a)purdue.edu> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit d78f45ae0c11fb19a1a0bf30728386e9febe0705 Author: Andrew Gregory <andrew.gregory.8(a)gmail.com> Date: Tue Nov 5 11:29:55 2013 -0500 log important events from the backend This ensures that important events will be logged and consistent regardless of the frontend. The need for global context in the event callback is also removed. The event is logged before any post_* scripts run, so this also moves the post_* script output underneath the event in the log. Fixes FS#36504 Signed-off-by: Andrew Gregory <andrew.gregory.8(a)gmail.com> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit ea6aeef8bae01d934cb4aab6d915e0e3e8276df1 Author: Andrew Gregory <andrew.gregory.8(a)gmail.com> Date: Tue Nov 5 08:50:44 2013 -0500 Makefile.am: fix typo in LOG_DRIVER variable Self-executing tests were not being run through the tap log driver. This caused `make check` to ignore discrepancies between the expected number of tests and the actual number of tests. Also, fix some uncommented output from test scripts that could confuse TAP parsers. Signed-off-by: Andrew Gregory <andrew.gregory.8(a)gmail.com> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 0da98ec6bac17b4f56b67a6f5b2fa24896671a9f Author: Allan McRae <allan(a)archlinux.org> Date: Fri Nov 1 22:13:46 2013 +1000 Ignore makedepend and checkdepend entries when parsing .PKGINFO file Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 5273e38fb254d6bfb9bce9078d346f3c08a294b1 Author: Allan McRae <allan(a)archlinux.org> Date: Fri Nov 1 21:24:46 2013 +1000 makepkg: move update_pkgver out of extract_sources The extract_sources function should be just extracting sources. Signed-off-by: Allan McRae <allan(a)archlinux.org> commit da8cd388c4fd95d1748285e4d6bd549c776ef5e1 Author: Allan McRae <allan(a)archlinux.org> Date: Fri Nov 1 21:48:17 2013 +1000 Return zero from extract_file with local source file The call to bsdtar to check if a file needs extracted returns 1 if it does not. We then propegate this return value accidentally which can cause makepkg to report an error later on. Explicitly return 0 in this case. Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 57090d8cba65988b822a215947a5fb44d55790d0 Author: Andrew Gregory <andrew.gregory.8(a)gmail.com> Date: Sat Oct 26 11:32:15 2013 -0400 alpm_handle: store lock file descriptor There was a brief window between opening the file descriptor and creating a stream to it. If the process was interrupted during that window the lock file would not be removed correctly. The pid is no longer printed to the lock file as this was virtually meaningless for lock files on NFS. Fixes FS#35603 Signed-off-by: Andrew Gregory <andrew.gregory.8(a)gmail.com> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit af284d5fdb0ef15dbb7a2082380e2ec586599774 Author: Andrew Gregory <andrew.gregory.8(a)gmail.com> Date: Mon Oct 28 09:58:28 2013 -0400 support ALPM_SIG_USE_DEFAULT for file siglevels This brings file siglevels in line with how db siglevels are handled. Signed-off-by: Andrew Gregory <andrew.gregory.8(a)gmail.com> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 88df07717de868dc2bd2424afefaea6c77efa4c0 Author: Jason St. John <jstjohn(a)purdue.edu> Date: Thu Oct 31 17:31:32 2013 -0400 Remove spaces between the opening "if" and the opening parenthesis Signed-off-by: Jason St. John <jstjohn(a)purdue.edu> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 14cc790c59e55f4a3f4d7fc47a2f60c468c5887b Author: Jason St. John <jstjohn(a)purdue.edu> Date: Thu Oct 31 17:55:54 2013 -0400 Use title case for a heading in HACKING; fix capitalization of "Vim" in HACKING Signed-off-by: Jason St. John <jstjohn(a)purdue.edu> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 0c180cb7cc890fdf162f3624d3fbeb6af95d2557 Author: Dave Reisner <dreisner(a)archlinux.org> Date: Thu Oct 31 17:42:47 2013 -0400 version: fix formatting in file to RPM upstream This reverts a portion of 86eefc1a3a341. Signed-off-by: Dave Reisner <dreisner(a)archlinux.org> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit fe824f87b9f1e40d88bd1a190a0bc1c80f2e91eb Author: Allan McRae <allan(a)archlinux.org> Date: Thu Oct 31 23:24:26 2013 +1000 makepkg: only remove static libraries if they have a shared version It is fairly common that packages contain static libraries with no shared counterpart. These should not be removed with !staticlibs. Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 5c5b28833c0c47d31c58d40cd13b69227de6eb48 Author: Allan McRae <allan(a)archlinux.org> Date: Thu Oct 31 22:28:55 2013 +1000 makepkg: Allow "static library" to be translated Signed-off-by: Allan McRae <allan(a)archlinux.org> ----------------------------------------------------------------------- Summary of changes: HACKING | 4 +-- Makefile.am | 2 +- contrib/bacman.sh.in | 10 +++++-- contrib/checkupdates.sh.in | 13 +++++++-- contrib/paccache.sh.in | 24 +++++++-------- contrib/pacdiff.sh.in | 8 +++-- contrib/paclist.sh.in | 10 +++++-- contrib/paclog-pkglist.sh.in | 12 ++++++-- contrib/pacscripts.sh.in | 16 +++++----- contrib/pacsearch.in | 5 ++-- contrib/pacsysclean.sh.in | 8 +++-- contrib/rankmirrors.sh.in | 15 ++++++---- contrib/updpkgsums.sh.in | 18 +++++++----- doc/PKGBUILD.5.txt | 2 +- doc/index.txt | 16 +++++----- doc/makepkg.conf.5.txt | 2 +- lib/libalpm/add.c | 24 ++++++++++++++- lib/libalpm/alpm.h | 14 ++++----- lib/libalpm/be_package.c | 6 +++- lib/libalpm/deps.c | 4 +-- lib/libalpm/diskspace.c | 2 +- lib/libalpm/dload.c | 4 +-- lib/libalpm/filelist.c | 2 +- lib/libalpm/handle.c | 37 +++++++++++------------ lib/libalpm/handle.h | 10 +++---- lib/libalpm/remove.c | 9 ++++-- lib/libalpm/signing.c | 24 +++++++-------- lib/libalpm/trans.c | 2 +- lib/libalpm/util.c | 6 ++-- lib/libalpm/version.c | 42 +++++++++++++------------- scripts/makepkg.sh.in | 28 +++++++++++------- scripts/pacman-db-upgrade.sh.in | 7 +++-- scripts/pacman-optimize.sh.in | 6 ++-- scripts/pkgdelta.sh.in | 11 ++++--- src/common/util-common.c | 19 ++++++------ src/pacman/callback.c | 36 ++++------------------- src/pacman/conf.c | 6 ++-- src/pacman/package.c | 4 +-- src/pacman/pacman.c | 2 +- src/pacman/query.c | 2 +- src/pacman/sync.c | 2 +- src/pacman/util.c | 4 +-- test/scripts/human_to_size_test.sh | 56 +++++++++++++++++------------------ test/scripts/parseopts_test.sh | 60 +++++++++++++++++++------------------- test/util/pacsorttest.sh | 4 +-- test/util/vercmptest.sh | 2 +- 46 files changed, 327 insertions(+), 273 deletions(-) hooks/post-receive -- The official pacman repository

1 0

[pacman-dev] Porting pacman to Windows
by Alexpux 12 Nov '13

12 Nov '13

Hi all! First, thanks for the great package manager - very flexible and fast. I’m successfully using pacman with some modifications under MSYS2 (Cygwin) to build and organize package development. Also I create my own online repository for MSYS2. I want to thank the developers for their work! Regards, Alexey.

1 0

[pacman-dev] [PATCH] Improve --help switch output for pacman contrib and pacman scripts
by Jason St. John 12 Nov '13

12 Nov '13

Unify the formatting of the --help switch for pacman utils, if it exists. All of the pacman utils will now output help text using the following format: util-name (pacman) v<pacman version> one line description of util's purpose Usage: util-name [options] -b, --bar whatever --bar does -f, --foo whatever --foo does -h, --help display this help message Reported-by: Karol Błażewicz <karol.blazewicz at gmail.com> Signed-off-by: Jason St. John <jstjohn(a)purdue.edu> --- This patch is analogous to commit a86015f except this one deals with pacman contrib and pacman scripts instead of pacman utils. Note: This is a resubmit based on Andrew's feedback on the ML here: https://mailman.archlinux.org/pipermail/pacman-dev/2013-October/018142.html contrib/bacman.sh.in | 10 +++++++--- contrib/checkupdates.sh.in | 13 ++++++++++--- contrib/paccache.sh.in | 20 ++++++++++---------- contrib/pacdiff.sh.in | 8 +++++--- contrib/paclist.sh.in | 10 +++++++--- contrib/paclog-pkglist.sh.in | 12 +++++++++--- contrib/pacscripts.sh.in | 16 +++++++++------- contrib/pacsearch.in | 5 +++-- contrib/pacsysclean.sh.in | 8 +++++--- contrib/rankmirrors.sh.in | 13 +++++++++---- contrib/updpkgsums.sh.in | 18 +++++++++++------- scripts/makepkg.sh.in | 2 ++ scripts/pacman-db-upgrade.sh.in | 7 +++++-- scripts/pkgdelta.sh.in | 11 +++++++---- 14 files changed, 99 insertions(+), 54 deletions(-) diff --git a/contrib/bacman.sh.in b/contrib/bacman.sh.in index 74a83bc..a20c5e7 100644 --- a/contrib/bacman.sh.in +++ b/contrib/bacman.sh.in @@ -37,9 +37,13 @@ m4_include(../scripts/library/output_format.sh) # User Friendliness # usage() { - echo "This program recreates a package using pacman's db and system files" - echo "Usage: $myname [--nocolor] [--pacnew] <installed package name>" - echo "Example: $myname kernel26" + echo "${myname} (pacman) v${myver}" + echo + echo "Recreate a package using pacman's database and system files" + echo + echo "Usage: ${myname} [--nocolor] [--pacnew] <installed package name>" + echo + echo "Example: ${myname} linux-headers" } version() { diff --git a/contrib/checkupdates.sh.in b/contrib/checkupdates.sh.in index 48ceff9..413b78a 100644 --- a/contrib/checkupdates.sh.in +++ b/contrib/checkupdates.sh.in @@ -18,10 +18,17 @@ # along with this program. If not, see <http://www.gnu.org/licenses/>. # +declare -r myname='checkupdates' +declare -r myver='@PACKAGE_VERSION@' + if (( $# > 0 )); then - echo "checkupdates: Safely print a list of pending updates." - echo "Use: checkupdates" - echo "Export the 'CHECKUPDATES_DB' variable to change the path of the temporary database." + echo "${myname} (pacman) v${myver}" + echo + echo "Safely print a list of pending updates" + echo + echo "Usage: ${myname}" + echo + echo 'Note: Export the "CHECKUPDATES_DB" variable to change the path of the temporary database.' exit 0 fi diff --git a/contrib/paccache.sh.in b/contrib/paccache.sh.in index 6b8df25..10eab21 100644 --- a/contrib/paccache.sh.in +++ b/contrib/paccache.sh.in @@ -152,27 +152,27 @@ summarize() { usage() { cat <<EOF -usage: $myname <operation> [options] [targets...] +${myname} (pacman) v${myver} -$myname is a flexible pacman cache cleaning utility, which has numerous -options to help control how much, and what, is deleted from any directory -containing pacman package tarballs. +A flexible pacman cache cleaning utility. + +Usage: ${myname} <operation> [options] [targets...] Operations: -d, --dryrun perform a dry run, only finding candidate packages. - -m, --move <dir> move candidate packages to 'movedir'. + -m, --move <dir> move candidate packages to "movedir". -r, --remove remove candidate packages. Options: - -a, --arch <arch> scan for 'arch' (default: all architectures). - -c, --cachedir <dir> scan 'cachedir' for packages. + -a, --arch <arch> scan for "arch" (default: all architectures). + -c, --cachedir <dir> scan "cachedir" for packages. (default: @localstatedir@/cache/pacman/pkg). -f, --force apply force to mv(1) and rm(1) operations. -h, --help display this help message and exit. - -i, --ignore <pkgs> ignore 'pkgs', comma separated. Alternatively, specify - '-' to read package names from stdin, newline + -i, --ignore <pkgs> ignore "pkgs", comma-separated. Alternatively, specify + "-" to read package names from stdin, newline- delimited. - -k, --keep <num> keep 'num' of each package in 'cachedir' (default: 3). + -k, --keep <num> keep "num" of each package in "cachedir" (default: 3). --nocolor remove color from output. -u, --uninstalled target uninstalled packages. -v, --verbose increase verbosity. specify up to 3 times. diff --git a/contrib/pacdiff.sh.in b/contrib/pacdiff.sh.in index 6e70fee..1bad0e4 100644 --- a/contrib/pacdiff.sh.in +++ b/contrib/pacdiff.sh.in @@ -33,20 +33,22 @@ m4_include(../scripts/library/output_format.sh) usage() { cat <<EOF -$myname is a simple pacnew/pacorig/pacsave updater. +${myname} (pacman) v${myver} + +A simple program to merge or remove pacnew/pacorig/pacsave files. Usage: $myname [-l | -f | -p] [--nocolor] Search Options: select one, default: pacmandb -l/--locate scan using locate -f/--find scan using find - -p/--pacmandb scan active config files from pacman db + -p/--pacmandb scan active config files from pacman database General Options: -o/--output print files instead of merging them --nocolor remove colors from output -Enviroment Variables: +Environment Variables: DIFFPROG override the merge program: (default: vimdiff) DIFFSEARCHPATH override the search path. (only when using find) (default: /etc) diff --git a/contrib/paclist.sh.in b/contrib/paclist.sh.in index 7883e21..319dcba 100644 --- a/contrib/paclist.sh.in +++ b/contrib/paclist.sh.in @@ -31,9 +31,13 @@ if ! type gettext &>/dev/null; then fi usage() { - printf '%s - List all packages installed from a given repo\n' "$myname" - printf 'Usage: %s <repo>\n' "$myname" - printf 'Example: %s testing\n' "$myname" + printf "%s (pacman) v%s\n" "${myname}" "myver" + echo + printf "List all packages installed from a given repository\n" "${myname}" + echo + printf "Usage: %s <repository>\n" "${myname}" + echo + printf "Example: %s testing\n" "${myname}" } version() { diff --git a/contrib/paclog-pkglist.sh.in b/contrib/paclog-pkglist.sh.in index 9b3abad..aaa7586 100644 --- a/contrib/paclog-pkglist.sh.in +++ b/contrib/paclog-pkglist.sh.in @@ -25,9 +25,15 @@ export TEXTDOMAINDIR='/usr/share/locale' declare logfile=${1:-@localstatedir@/log/pacman.log} usage() { - printf 'usage: %s [pacman log]\n' "$myname" - printf 'example: %s @localstatedir@/log/pacman.log\n' "$myname" - printf '\ndefaults to: @localstatedir@/log/pacman.log\n' + printf "%s (pacman) v%s\n" "${myname}" "${myver}" + echo + echo "Parse a log file into a list of currently installed packages" + echo + printf "Usage: %s [path to pacman log]\n" "${myname}" + echo + printf "Example: %s @localstatedir@/log/pacman.log\n" "${myname}" + echo + printf 'Defaults to: @localstatedir@/log/pacman.log' } version() { diff --git a/contrib/pacscripts.sh.in b/contrib/pacscripts.sh.in index 62c4e35..8453f9c 100644 --- a/contrib/pacscripts.sh.in +++ b/contrib/pacscripts.sh.in @@ -46,16 +46,18 @@ error() { } usage() { - echo "This program prints out the {pre,post}_{install,remove,upgrade} scripts" - echo "of a given package." - echo "Usage: $myname pkgname|pkgfile" + echo "${myname} (pacman) v${myver}" echo - echo " OPTIONS:" + echo "Prints the {pre,post}_{install,remove,upgrade} scripts of a given package." + echo + echo "Usage: ${myname} <pkgname|pkgfile>" + echo + echo " Options:" echo " -h, --help Print this help message" echo " -v, --version Print program name and version" echo - echo "Example: $myname gconf-editor" - echo "Example: $myname gconf-editor-2.24.1-1-x86_64.pkg.tar.gz" + echo "Example: ${myname} gconf-editor" + echo "Example: ${myname} gconf-editor-3.0.1-3-x86_64.pkg.tar.xz" } version() { @@ -70,7 +72,7 @@ spacman() { else if ! type -p sudo; then error "Cannot find the sudo binary! Is sudo installed?" - error "Otherwise try to run the program as root" + error "Otherwise, try to run the program as root" exit 1 else sudo pacman "$@" diff --git a/contrib/pacsearch.in b/contrib/pacsearch.in index b1db8ab..624f201 100644 --- a/contrib/pacsearch.in +++ b/contrib/pacsearch.in @@ -28,8 +28,9 @@ my $myname = 'pacsearch'; my $myver = '@PACKAGE_VERSION@'; sub usage { - print "$myname - Add color and install information to a pacman -Ss search\n"; - print "Usage: $myname <pattern>\n"; + print "$myname (pacman) v$myver\n\n"; + print "Add color and install information to a 'pacman -Ss' search\n\n"; + print "Usage: $myname <pattern>\n\n"; print "Example: $myname ^gnome\n"; } diff --git a/contrib/pacsysclean.sh.in b/contrib/pacsysclean.sh.in index 37219ab..3631921 100644 --- a/contrib/pacsysclean.sh.in +++ b/contrib/pacsysclean.sh.in @@ -8,9 +8,12 @@ declare -r myver='@PACKAGE_VERSION@' PACMAN_OPTS= usage() { - echo "$myname - Sort installed packages by increasing installed size." + echo "${myname} (pacman) v${myver}" echo - echo "Usage: $myname [options]" + echo "Sort installed packages by increasing installed size. Useful for" + echo "system clean-up." + echo + echo "Usage: ${myname} [options]" echo echo "Options:" echo " -o <options> Specify custom pacman query options (e.g., dt)" @@ -22,7 +25,6 @@ version() { echo 'Copyright (C) 2011 Eric Bélanger <snowmaniscool(a)gmail.com>' } - if [ -n "$1" ]; then case "$1" in -o) PACMAN_OPTS="${2}" ;; diff --git a/contrib/rankmirrors.sh.in b/contrib/rankmirrors.sh.in index 82bf9ae..0c4c734 100644 --- a/contrib/rankmirrors.sh.in +++ b/contrib/rankmirrors.sh.in @@ -21,26 +21,31 @@ # traps interrupt key to spit out pre-interrupt info trap finaloutput INT +declare -r myname='rankmirrors' +declare -r myver='@PACKAGE_VERSION@' + usage() { - echo "Usage: rankmirrors [options] MIRRORFILE | URL" + echo "${myname} (pacman) v${myver}" echo echo "Ranks pacman mirrors by their connection and opening speed. Pacman mirror" echo "files are located in @sysconfdir@/pacman.d/. It can also rank one mirror if the URL is" echo "provided." echo + echo "Usage: ${myname} [options] MIRRORFILE | URL" + echo echo "Options:" echo " --version show program's version number and exit" echo " -h, --help show this help message and exit" echo " -n NUM number of servers to output, 0 for all" echo " -t, --times only output mirrors and their response times" - echo " -u, --url test a specific url" + echo " -u, --url test a specific URL" echo " -v, --verbose be verbose in ouptut" - echo " -r, --repo specify a specific repo name instead of guessing" + echo " -r, --repo specify a repository name instead of guessing" exit 0 } version() { - echo "rankmirrors (pacman) @PACKAGE_VERSION@" + echo "${myname} (pacman) ${myver}" echo "Copyright (c) 2009 Matthew Bruenig <matthewbruenig(a)gmail.com>." echo echo "This is free software; see the source for copying conditions." diff --git a/contrib/updpkgsums.sh.in b/contrib/updpkgsums.sh.in index 4d35357..0f52db4 100644 --- a/contrib/updpkgsums.sh.in +++ b/contrib/updpkgsums.sh.in @@ -23,12 +23,16 @@ declare -r myname='updpkgsums' declare -r myver='@PACKAGE_VERSION@' usage() { - printf 'usage: %s [buildfile]\n\n' "$myname" - printf ' -h, --help display this help message and exit\n' - printf ' -V, --version display version information and exit\n\n' - printf '%s will perform an in place update the checksums in the\n' "$myname" - printf 'path specified by [buildfile], defaulting to PKGBUILD in the current\n' - printf 'working directory.\n' + printf "%s (pacman) v%s\n" "${myname}" "${myver}" + echo + printf "%s will perform an in place update of the checksums in the\n" "${myname}" + echo "path specified by [build file], defaulting to PKGBUILD in the current" + echo "working directory." + echo + printf "Usage: %s [build file]\n" "${myname}" + echo + echo " -h, --help display this help message and exit" + echo " -V, --version display version information and exit" } version() { @@ -43,7 +47,7 @@ esac buildfile=${1:-PKGBUILD} if [[ ! -f $buildfile ]]; then - printf '==> ERROR: %s not found or is not a file\n' "$buildfile" + printf "==> ERROR: %s not found or is not a file\n" "$buildfile" exit 1 fi diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index 387fadb..de9310f 100644 --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in @@ -2483,6 +2483,8 @@ m4_include(library/parseopts.sh) usage() { printf "makepkg (pacman) %s\n" "$makepkg_version" echo + printf -- "$(gettext "Make packages compatible for use with pacman")\n" + echo printf -- "$(gettext "Usage: %s [options]")\n" "$0" echo printf -- "$(gettext "Options:")\n" diff --git a/scripts/pacman-db-upgrade.sh.in b/scripts/pacman-db-upgrade.sh.in index a1630c5..2b39538 100644 --- a/scripts/pacman-db-upgrade.sh.in +++ b/scripts/pacman-db-upgrade.sh.in @@ -33,8 +33,11 @@ USE_COLOR='y' m4_include(library/output_format.sh) usage() { - printf "pacman-db-upgrade (pacman) %s\n\n" "$myver" - printf -- "$(gettext "Usage: %s [--nocolor] [pacman_db_root]")\n\n" "$0" + printf "pacman-db-upgrade (pacman) %s\n" "${myver}" + echo + printf -- "$(gettext "Upgrade the local pacman database to a newer format")\n" + echo + printf -- "$(gettext "Usage: %s [--nocolor] [pacman_db_root]")\n" "$0" } version() { diff --git a/scripts/pkgdelta.sh.in b/scripts/pkgdelta.sh.in index 39046b8..cc1f9ac 100644 --- a/scripts/pkgdelta.sh.in +++ b/scripts/pkgdelta.sh.in @@ -46,11 +46,14 @@ m4_include(library/output_format.sh) # print usage instructions usage() { - printf "pkgdelta (pacman) %s\n\n" "$myver" + printf "pkgdelta (pacman) %s\n" "${myver}" + echo printf -- "$(gettext "Usage: pkgdelta [options] <package1> <package2>\n")" + echo printf -- "$(gettext "\ - pkgdelta will create a delta file between two packages.\n\ -This delta file can then be added to a database using repo-add.\n\n")" +pkgdelta will create a delta file between two packages.\n\ +This delta file can then be added to a database using repo-add.\n")" + echo printf -- "$(gettext "Example: pkgdelta pacman-3.0.0.pkg.tar.gz pacman-3.0.1.pkg.tar.gz")\n" echo printf -- "$(gettext "Options:\n")" @@ -61,7 +64,7 @@ This delta file can then be added to a database using repo-add.\n\n")" } version() { - printf "pkgdelta (pacman) %s\n\n" "$myver" + printf "pkgdelta (pacman) %s\n" "$myver" printf -- "$(gettext "\ Copyright (c) 2009 Xavier Chantry <shiningxc(a)gmail.com>.\n\n\ This is free software; see the source for copying conditions.\n\ -- 1.8.4.2

2 3

[pacman-dev] [PATCH] pacsort: refactor version comparison for correctness
by Dave Reisner 11 Nov '13

11 Nov '13

This refactors the existing vercmp machinery in order to: 1) Correct a deficiency in files comparison. This was too lazily written and could produce incorrect results when a version contained an epoch. 2) Improve tarball detection. Calling fnmatch a second time for the uncompressed tarball case is not a noticeable performance hit, and is more correct. 3) Fix a bug in tarball detection. The glob pattern would match files with only a pkgver, e.g. foopkg-1.2.3-x86_64.pkg.tar.xz. 4) Be generally cleaner code, easier to follow. The test suite gets extended to validate my claims for the new behavior. Fixes FS#37631. Signed-off-by: Dave Reisner <dreisner(a)archlinux.org> --- This supersedes an earlier patch I sent against pacsort which was a bit more directed and less useful. src/util/pacsort.c | 164 ++++++++++++++++++++++++++++++++++------------- test/util/pacsorttest.sh | 31 ++++++++- 2 files changed, 150 insertions(+), 45 deletions(-) diff --git a/src/util/pacsort.c b/src/util/pacsort.c index 687e558..554352c 100644 --- a/src/util/pacsort.c +++ b/src/util/pacsort.c @@ -20,6 +20,7 @@ #include <errno.h> #include <fnmatch.h> #include <getopt.h> +#include <limits.h> #include <stdio.h> #include <stdlib.h> #include <string.h> @@ -40,6 +41,14 @@ struct list_t { size_t maxcount; }; +struct pkgmeta_t { + const char *pkgname; + size_t pkgname_len; + + const char *pkgver; + size_t pkgver_len; +}; + static struct options_t { int order; int sortkey; @@ -258,57 +267,124 @@ static const char *nth_column(const char *string) return prev; } -static int vercmp(const void *p1, const void *p2) +static void extract_pkgmeta(const char *path, struct pkgmeta_t *meta) { - const char *name1, *name2; - char *fn1 = NULL, *fn2 = NULL; - int r; - - name1 = *(const char **)p1; - name2 = *(const char **)p2; - - /* if we're operating in file mode, we modify the strings under certain - * conditions to appease alpm_pkg_vercmp(). If and only if both inputs end - * with a suffix that appears to be a package name, we strip the suffix and - * remove any leading paths. This means that strings such as: - * - * /var/cache/pacman/pkg/firefox-18.0-2-x86_64.pkg.tar.xz - * firefox-18.0-2-x86_64.pkg.tar.gz - * - * Will be considered equal by this version comparison - */ - if(opts.filemode) { - if(fnmatch("*-*.pkg.tar.?z", name1, 0) == 0 && - fnmatch("*-*.pkg.tar.?z", name2, 0) == 0) { - const char *start, *end; - - start = strrchr(name1, '/'); - start = start ? start + 1 : name1; - end = strrchr(name1, '-'); - fn1 = strndup(start, end - start); - - start = strrchr(name2, '/'); - start = start ? start + 1 : name2; - end = strrchr(name2, '-'); - fn2 = strndup(start, end - start); - - name1 = fn1; - name2 = fn2; - } - } + const char *pkgver_end; + const char *slash; + + /* Find the basename */ + slash = strrchr(path, '/'); + meta->pkgname = slash ? slash + 1 : path; + pkgver_end = strrchr(meta->pkgname, '-'); + + /* Read backwards through pkgrel */ + for(meta->pkgver = pkgver_end - 1; + meta->pkgver > meta->pkgname && *meta->pkgver != '-'; + --meta->pkgver) + ; + /* Read backwards through pkgver */ + for(--meta->pkgver; + meta->pkgver > meta->pkgname && *meta->pkgver != '-'; + --meta->pkgver) + ; + ++meta->pkgver; + + meta->pkgname_len = meta->pkgver - meta->pkgname - 1; + meta->pkgver_len = pkgver_end - meta->pkgver; +} + +static int is_pkgtar(const char *string) +{ + return fnmatch("*-*-*.pkg.tar.?z", string, 0) == 0 || + fnmatch("*-*-*.pkg.tar", string, 0) == 0; +} + +static int vercmp_versions(const char *ver1, const char *ver2) +{ + return alpm_pkg_vercmp(nth_column(ver1), nth_column(ver2)); +} + +static int pkgmeta_vercmp(struct pkgmeta_t *pkg1, struct pkgmeta_t *pkg2) +{ + char v1[PATH_MAX], v2[PATH_MAX]; + + memcpy(v1, pkg1->pkgname, pkg1->pkgname_len); + v1[pkg1->pkgname_len] = '\0'; + + memcpy(v2, pkg2->pkgname, pkg2->pkgname_len); + v2[pkg2->pkgname_len] = '\0'; - if(opts.sortkey == 0) { - r = opts.order * alpm_pkg_vercmp(name1, name2); + return alpm_pkg_vercmp(v1, v2); +} + +static int pkgmeta_namecmp(struct pkgmeta_t *pkg1, struct pkgmeta_t *pkg2) +{ + int cmp; + const size_t cmplen = (pkg1->pkgname_len < pkg2->pkgname_len) ? + pkg1->pkgname_len : pkg2->pkgname_len; + + cmp = memcmp(pkg1->pkgname, pkg2->pkgname, cmplen); + if(cmp != 0) { + return cmp; } else { - r = opts.order * alpm_pkg_vercmp(nth_column(name1), nth_column(name2)); + return pkg1->pkgname_len - pkg2->pkgname_len; } +} - if(opts.filemode) { - free(fn1); - free(fn2); +static int pkgmeta_trailercmp(struct pkgmeta_t *pkg1, struct pkgmeta_t *pkg2) +{ + return strcmp(&pkg1->pkgver[pkg1->pkgver_len], + &pkg2->pkgver[pkg2->pkgver_len]); +} + +static int pkgmeta_cmp(struct pkgmeta_t *pkg1, struct pkgmeta_t *pkg2) +{ + int cmp; + + /* 1) Compare the package names. */ + cmp = pkgmeta_namecmp(pkg1, pkg2); + if(cmp != 0) { + return cmp; + } + + /* 2) Compare the versions. */ + cmp = pkgmeta_vercmp(pkg1, pkg2); + if(cmp != 0) { + return cmp; + } + + /* 3) Nothing else to do, compare the remainder of the strings lexically. */ + return pkgmeta_trailercmp(pkg1, pkg2); +} + +static int vercmp_files(const char *file1, const char *file2) +{ + struct pkgmeta_t pkg1, pkg2; + + /* In order for 2 files to be considered equal, they must have the same + * basename. For example, the two follow strings are considered equal: + * /var/cache/pacman/pkg/pacman-4.1.1-1-x86_64.pkg.tar.gz + * /share/packages/pacman-4.1.1-1-x86_64.pkg.tar.gz + */ + + extract_pkgmeta(file1, &pkg1); + extract_pkgmeta(file2, &pkg2); + + return pkgmeta_cmp(&pkg1, &pkg2); +} + +static int vercmp(const void *v1, const void *v2) +{ + const char *s1 = *(const char **)v1, *s2 = *(const char **)v2; + int cmp; + + if(opts.filemode && is_pkgtar(s1) && is_pkgtar(s1)) { + cmp = vercmp_files(s1, s2); + } else { + cmp = vercmp_versions(s1, s2); } - return r; + return opts.order * cmp; } static char escape_char(const char *string) diff --git a/test/util/pacsorttest.sh b/test/util/pacsorttest.sh index ac16c45..dbd11d1 100755 --- a/test/util/pacsorttest.sh +++ b/test/util/pacsorttest.sh @@ -21,7 +21,7 @@ # default binary if one was not specified as $1 bin=${1:-${PMTEST_UTIL_DIR}pacsort} # holds counts of tests -total=23 +total=32 run=0 failure=0 @@ -89,6 +89,35 @@ runtest $in $in "filename sort with uneven leading path components" "--files" in="firefox-18.0-2-i686.pkg.tar.xz\nfirefox-18.0.1-1-x86_64.pkg.tar.gz\n" runtest $in $in "filename sort with different extensions" "--files" +in="/path1/path2/firefox-18.0.1-1-x86_64.pkg.tar.xz\n/path2/firefox-18.0-2-x86_64.pkg.tar.xz\n" +runtest $in $in "filename reverse sort" "--files --reverse" + +in="/packages/dialog-1.2_20131001-1-x86_64.pkg.tar.xz\n/packages/dialog-1:1.2_20130928-1-x86_64.pkg.tar.xz\n" +runtest $in $in "filename sort with epoch" "--files" + +in="/packages/dia-log-1:1.2_20130928-1-x86_64.pkg.tar.xz\n/packages/dialog-1.2_20131001-1-x86_64.pkg.tar.xz\n" +runtest $in $in "filename with different pkgname sort with epoch" "--files" + +in="/packages/dialog-1.2_20131001-1-x86_64.pkg.tar.xz\n/packages/dialoggg-1:1.2_20130928-1-x86_64.pkg.tar.xz\n" +runtest $in $in "filename with shared prefix sort with epoch" "--files" + +in="/packages/dialoggg-1:1.2_20130928-1-x86_64.pkg.tar.xz\n/packages/dialog-1.2_20131001-1-x86_64.pkg.tar.xz\n" +runtest $in $in "filename reverse sort with epoch" "--files --reverse" + +in="firefox-18.0-2-i686.pkg.tar.gz\nfirefox-18.0-2-x86_64.pkg.tar.gz\n" +runtest "$in" "$in" "filename sort with different architecture" "--files" + +in="firefox-18.0-2-x86_64.pkg.tar.gz\nfirefox-18.0-2-x86_64.pkg.tar.xz\n" +runtest "$in" "$in" "filename sort with different compression" "--files" + +in="10 3\n10 2\n10 1\n" +ex="10 1\n10 2\n10 3\n" +runtest "$in" "$ex" "sort on key" "--key 2" + +in="10 3 1000\n10 2 2000\n10 1\n" +ex="10 1\n10 3 1000\n10 2 2000\n" +runtest "$in" "$ex" "sort on key with uneven columns" "--key 3" + # generate some long input/expected for the next few tests declare normal reverse names_normal names_reverse for ((i=1; i<600; i++)); do -- 1.8.4.2

2 1

[pacman-dev] [PATCH 0/8] Wondering if Python 3 could run the tests?
by Jeremy Heiner 10 Nov '13

10 Nov '13

The short answer is: yes, it can. The slightly longer answer is: with these patches the test framework is compatible with any Python from 2.5 up to 3.3. Relax: none of these patches actually change which version gets used during a build. This is just an exploration of what is needed to get over the bump from Python 2 to 3. This experiment came about as I was working on the -Qk(k) unit tests. I realized that I had used a 2.7 specific feature, and I stopped to grep through the code and the mailing list to see if that was a no-no. That lead me to trying out 2.6 and then 2.5 to see what version the framework needed. Patch 1 is about that lower end of the scale. This naturally got me wondering about the upper end and how much pain it would be to move in that direction. Python offers tools to help migration. Patch 2 came from running "python2 -3". And patches 3 thru 7 came from "2to3" (split into commits by the specific issue). After those the code was syntactically acceptable to 3.3, and so the last two issues, fixed in Patch 8, came from runtime exceptions. Most of the difficult work was setting up a test environment for the pactest framework so I could be assured that the changes suggested by the migration tools wouldn't break anything. And splitting up what "2to3" reported into commits that would make sense. I am ambivalent on the prosepect of accepting these patches into the code base. Python 2.7 isn't going to disappear tomorrow, so there's no fire. There are no features in 3.x that are must-have solutions to a pain point. Nothing's really broken, so these patches aren't really fixing anything. All very true. The only advantage I can think of is that it might entice more people into writing more tests if they could use they shiny (overly hyped?) new 3.x features instead of that old boring 2.7 stuff. At the very least I would suggest that it would be very helpful to explicitly state somewhere in the test framework code the minimum version needed. I've determined it could be set to 2.5 (no, I did not check lower than that), but it would make much more sense to pick 2.7. Assuming, that is, that the consensus will be that jumping to 3.x is a bridge too far. Jeremy Heiner (8): Restore ability to run tests with version 2.5 of Python. Use Python's "exec" instead of deprecated "execfile". Python 3 octal literals broke backwards compatibility. Add shims to return views on Python dicts. Add shims to return a new Python StringIO instance. Use Python's "range" instead of deprecated "xrange". Add parens around tuples in Python for comprehensions. Allow tests to be run with either version 2 or 3 of Python. test/pacman/pmdb.py | 7 +++--- test/pacman/pmpkg.py | 11 +++++---- test/pacman/pmtest.py | 14 +++++++---- test/pacman/tests/depconflict100.py | 2 +- test/pacman/tests/depconflict120.py | 2 +- test/pacman/tests/epoch005.py | 2 +- test/pacman/tests/fileconflict001.py | 2 +- test/pacman/tests/fileconflict002.py | 2 +- test/pacman/tests/query006.py | 3 +-- test/pacman/tests/remove052.py | 2 +- test/pacman/tests/smoke001.py | 4 +-- test/pacman/tests/smoke003.py | 4 +-- test/pacman/tests/sync030.py | 2 +- test/pacman/tests/sync031.py | 2 +- test/pacman/tests/sync040.py | 2 +- test/pacman/tests/sync041.py | 2 +- test/pacman/tests/sync405.py | 2 +- test/pacman/tests/sync406.py | 2 +- test/pacman/tests/sync891.py | 2 +- test/pacman/tests/sync892.py | 2 +- test/pacman/tests/sync893.py | 2 +- test/pacman/tests/sync898.py | 2 +- test/pacman/tests/sync990.py | 2 +- test/pacman/tests/sync992.py | 2 +- test/pacman/tests/upgrade005.py | 2 +- test/pacman/tests/upgrade013.py | 2 +- test/pacman/tests/upgrade014.py | 2 +- test/pacman/tests/upgrade030.py | 2 +- test/pacman/tests/upgrade031.py | 2 +- test/pacman/tests/upgrade032.py | 2 +- test/pacman/tests/upgrade040.py | 2 +- test/pacman/tests/upgrade041.py | 2 +- test/pacman/tests/upgrade042.py | 2 +- test/pacman/tests/upgrade043.py | 2 +- test/pacman/tests/upgrade046.py | 2 +- test/pacman/tests/upgrade050.py | 2 +- test/pacman/tests/upgrade059.py | 2 +- test/pacman/tests/upgrade060.py | 2 +- test/pacman/tests/upgrade061.py | 2 +- test/pacman/tests/upgrade073.py | 2 +- test/pacman/tests/upgrade090.py | 2 +- test/pacman/tests/xfercommand001.py | 2 +- test/pacman/util.py | 47 ++++++++++++++++++++++++++++++------ 43 files changed, 99 insertions(+), 63 deletions(-) -- 1.8.4

5 44