- Pacman-dev - lists.archlinux.org

[PATCH] pacman: Add space before percent sign in download progress string.
by severoraz＠gmail.com 28 Sep '22

28 Sep '22

From: Severo Raz <severoraz(a)gmail.com> Also add explanatory comment and reduce use of magic numbers. Signed-off-by: Severo Raz <severoraz(a)gmail.com> --- src/pacman/callback.c | 32 ++++++++++++++++++++------------ 1 file changed, 20 insertions(+), 12 deletions(-) diff --git a/src/pacman/callback.c b/src/pacman/callback.c index aa6303bf..c48b887d 100644 --- a/src/pacman/callback.c +++ b/src/pacman/callback.c @@ -152,19 +152,28 @@ static int64_t get_update_timediff(int first_call) /* refactored from cb_trans_progress */ static void fill_progress(const int percent, const int proglen) { - /* 8 = 1 space + 1 [ + 1 ] + 5 for percent */ - const int hashlen = proglen > 8 ? proglen - 8 : 0; - const int hash = percent * hashlen / 100; - int i; + /* + * Format: + * " [###---] NNN %" + * where NNN is the space-padded percentage. + * + * thrshlen = strlen(" [] 100 %") = 9 + * perclen = strlen(" 100 %") = 6 + */ + const int threshlen = 9; + const int perclen = 6; + const int pbarlen = (proglen > threshlen) ? (proglen - threshlen) : 0; + + if(pbarlen > 0) { + const int remlen = (100 - percent) * pbarlen / 100; - if(hashlen > 0) { fputs(" [", stdout); - for(i = hashlen; i > 0; --i) { + for(int i = pbarlen; i > 0; --i) { /* if special progress bar enabled */ if(config->chomp) { - if(i > hashlen - hash) { + if(i > remlen) { putchar('-'); - } else if(i == hashlen - hash) { + } else if(i == remlen) { if(percent % 2 == 0) { fputs("\033[1;33mC\033[m", stdout); } else { @@ -176,7 +185,7 @@ static void fill_progress(const int percent, const int proglen) fputs("\033[0;37m \033[m", stdout); } } /* else regular progress bar */ - else if(i > hashlen - hash) { + else if(i > remlen) { putchar('#'); } else { putchar('-'); @@ -185,9 +194,8 @@ static void fill_progress(const int percent, const int proglen) putchar(']'); } /* print display percent after progress bar */ - /* 5 = 1 space + 3 digits + 1 % */ - if(proglen >= 5) { - printf(" %3d%%", percent); + if(proglen >= perclen) { + printf(" %3d %%", percent); } putchar('\r'); -- 2.37.3

4 5

[Git][pacman/pacman][master] 2 commits: Update Transifex config
by Allan McRae (＠allan) 26 Sep '22

26 Sep '22

Allan McRae pushed to branch master at Pacman / Pacman Commits: e10751a1 by Allan McRae at 2022-09-26T20:53:48+10:00 Update Transifex config Signed-off-by: Allan McRae <allan(a)archlinux.org> - - - - - 546433b4 by Allan McRae at 2022-09-26T21:10:54+10:00 Update Transifex client usage instructions Signed-off-by: Allan McRae <allan(a)archlinux.org> - - - - - 2 changed files: - .tx/config - RELEASE View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/compare/673ce1ab10a652948f4f62… -- View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/compare/673ce1ab10a652948f4f62… You're receiving this email because of your account on gitlab.archlinux.org.

1 0

[Git][pacman/pacman][release/6.0.x] 2 commits: Update Transifex config
by Allan McRae (＠allan) 26 Sep '22

26 Sep '22

Allan McRae pushed to branch release/6.0.x at Pacman / Pacman Commits: 6b1a8365 by Allan McRae at 2022-09-26T20:54:21+10:00 Update Transifex config Signed-off-by: Allan McRae <allan(a)archlinux.org> (cherry picked from commit e10751a1e05f19644bb444248bac2cfda3ddaf6a) - - - - - 77420fe5 by Allan McRae at 2022-09-26T21:09:49+10:00 Final update of 6.0.x translations from Transifex Signed-off-by: Allan McRae <allan(a)archlinux.org> - - - - - 30 changed files: - .tx/config - lib/libalpm/po/ar.po - lib/libalpm/po/ast.po - lib/libalpm/po/az_AZ.po - lib/libalpm/po/bg.po - lib/libalpm/po/br.po - lib/libalpm/po/ca.po - lib/libalpm/po/cs.po - lib/libalpm/po/da.po - lib/libalpm/po/de.po - lib/libalpm/po/el.po - lib/libalpm/po/en_GB.po - lib/libalpm/po/eo.po - lib/libalpm/po/es.po - lib/libalpm/po/es_419.po - lib/libalpm/po/eu.po - lib/libalpm/po/eu_ES.po - lib/libalpm/po/fi.po - lib/libalpm/po/fr.po - lib/libalpm/po/gl.po - lib/libalpm/po/hi.po - lib/libalpm/po/hr.po - lib/libalpm/po/hu.po - lib/libalpm/po/id.po - lib/libalpm/po/it.po - lib/libalpm/po/ja.po - lib/libalpm/po/kk.po - lib/libalpm/po/ko.po - lib/libalpm/po/libalpm.pot - lib/libalpm/po/lt.po View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/compare/0a6fecd07271a54d9009ea… -- View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/compare/0a6fecd07271a54d9009ea… You're receiving this email because of your account on gitlab.archlinux.org.

1 0

[Git][pacman/pacman][master] 2 commits: makepkg.8: add missing fullstop
by Allan McRae (＠allan) 26 Sep '22

26 Sep '22

Allan McRae pushed to branch master at Pacman / Pacman Commits: 53dd3e84 by Allan McRae at 2022-09-07T23:14:12+10:00 makepkg.8: add missing fullstop Fixes FS#75838 Signed-off-by: Allan McRae <allan(a)archlinux.org> - - - - - 673ce1ab by Kristian Klausen at 2022-09-26T20:22:11+10:00 pacman-key: Don't check gpg's trustdb after each key revocation The trustdb is marked as dirty when a key is revoked[1] and GPG will recheck it the next time. Checking the trustdb can take 300-500ms which with 52 revoked keys (and counting) adds up. This is very noticeable when initializing and populating pacman's keyring like archiso is doing[2]. It is also unnecessary as the trustdb is always checked as the last step when populating the keyring. [1] https://git.gnupg.org/cgi-bin/gitweb.cgi?p=gnupg.git;a=blob;f=g10/keyedit.c… [2] https://gitlab.archlinux.org/archlinux/archiso/-/issues/191 - - - - - 2 changed files: - doc/makepkg.8.asciidoc - scripts/pacman-key.sh.in View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/compare/656abdb256b65da13f82fb… -- View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/compare/656abdb256b65da13f82fb… You're receiving this email because of your account on gitlab.archlinux.org.

1 0

[PATCH] makepkg.8: add missing fullstop
by Allan McRae 07 Sep '22

07 Sep '22

Fixes FS#75838 Signed-off-by: Allan McRae <allan(a)archlinux.org> --- doc/makepkg.8.asciidoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/makepkg.8.asciidoc b/doc/makepkg.8.asciidoc index d023b038..a86c33f0 100644 --- a/doc/makepkg.8.asciidoc +++ b/doc/makepkg.8.asciidoc @@ -75,7 +75,7 @@ Options For each source file in the source array of PKGBUILD, download the file if required and generate integrity checks. The integrity checks generated are determined by the checks present in the PKGBUILD, falling back to the - value of the INTEGRITY_CHECK array in makepkg.conf(5) if these are absent + value of the INTEGRITY_CHECK array in makepkg.conf(5) if these are absent. This output can be redirected into your PKGBUILD for source validation using "`makepkg -g >> PKGBUILD`". -- 2.37.2

1 0

[Git][pacman/pacman][master] 3 commits: libmakepkg: Fix git clone command
by Allan McRae (＠allan) 30 Aug '22

30 Aug '22

Allan McRae pushed to branch master at Pacman / Pacman Commits: 184f5931 by soloturn at 2022-08-02T13:07:09+10:00 libmakepkg: Fix git clone command Commit e017a5975cfe3e53670848bd45c982524d6745af introduced the GITFLAGS environmental variable. While ensuring the default of "--mirror" was kept, there was a capitalisation mistake made. Handle the default for GITFLAGS directly in the git clone command. - - - - - 064e556c by Ben Westover at 2022-08-02T23:04:22+10:00 doc: Fix grammar in pacman.8.asciidoc Signed-off-by: Ben Westover <kwestover.kw(a)gmail.com> - - - - - 656abdb2 by Ben Westover at 2022-08-04T22:29:27+10:00 doc: Create documentation for pacman-db-upgrade and testpkg There are two "binaries" that are currently missing documentation, pacman-db-upgrade and testpkg. This patch adds that documentation. Signed-off-by: Ben Westover <kwestover.kw(a)gmail.com> Signed-off-by: Allan McRae <allan(a)archlinux.org> - - - - - 5 changed files: - doc/meson.build - + doc/pacman-db-upgrade.8.asciidoc - doc/pacman.8.asciidoc - + doc/testpkg.8.asciidoc - scripts/libmakepkg/source/git.sh.in View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/compare/e017a5975cfe3e53670848… -- View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/compare/e017a5975cfe3e53670848… You're receiving this email because of your account on gitlab.archlinux.org.

1 0

[PATCH 1/2] Diff color version strings
by David Gustavsson 18 Aug '22

18 Aug '22

In package table, with VerbosePkgLists and Color, color the part of package version strings that changes. Signed-off-by: David Gustavsson <david.e.gustavsson(a)gmail.com> --- src/pacman/conf.c | 4 ++++ src/pacman/conf.h | 2 ++ src/pacman/util.c | 35 +++++++++++++++++++++++++++++++---- src/pacman/util.h | 1 + 4 files changed, 38 insertions(+), 4 deletions(-) diff --git a/src/pacman/conf.c b/src/pacman/conf.c index f9edf75b..d5c598b9 100644 --- a/src/pacman/conf.c +++ b/src/pacman/conf.c @@ -80,6 +80,8 @@ void enable_colors(int colors) colstr->err = BOLDRED; colstr->faint = GREY46; colstr->nocolor = NOCOLOR; + colstr->diffrem = RED; + colstr->diffadd = GREEN; } else { colstr->colon = ":: "; colstr->title = ""; @@ -91,6 +93,8 @@ void enable_colors(int colors) colstr->err = ""; colstr->faint = ""; colstr->nocolor = ""; + colstr->diffrem = ""; + colstr->diffadd = ""; } } diff --git a/src/pacman/conf.h b/src/pacman/conf.h index f7916ca9..782b5758 100644 --- a/src/pacman/conf.h +++ b/src/pacman/conf.h @@ -33,6 +33,8 @@ typedef struct __colstr_t { const char *err; const char *faint; const char *nocolor; + const char *diffrem; + const char *diffadd; } colstr_t; typedef struct __config_repo_t { diff --git a/src/pacman/util.c b/src/pacman/util.c index 53833d6f..10d7c573 100644 --- a/src/pacman/util.c +++ b/src/pacman/util.c @@ -840,8 +840,10 @@ static alpm_list_t *create_verbose_row(pm_target_t *target) { char *str; off_t size = 0; + size_t i = 0; double human_size; const char *label; + const char *version; alpm_list_t *ret = NULL; /* a row consists of the package name, */ @@ -858,12 +860,28 @@ static alpm_list_t *create_verbose_row(pm_target_t *target) add_table_cell(&ret, str, CELL_NORMAL | CELL_FREE); /* old and new versions */ - pm_asprintf(&str, "%s", - target->remove != NULL ? alpm_pkg_get_version(target->remove) : ""); + version = alpm_pkg_get_version(target->remove); + char old_version[strlen(version) + strlen(config->colstr.diffrem) + strlen(config->colstr.nocolor) + 1]; + memcpy(old_version, (char *)version, strlen(version) + 1); + version = alpm_pkg_get_version(target->install); + char new_version[strlen(version) + strlen(config->colstr.diffadd) + strlen(config->colstr.nocolor) + 1]; + memcpy(new_version, (char *)version, strlen(version) + 1); + + i = 0; + while (old_version[i] != '\0' && new_version[i] != '\0' && old_version[i] == new_version[i]) { + i++; + } + insertstring(old_version, config->colstr.diffrem, i); + insertstring(new_version, config->colstr.diffadd, i); + snprintf(old_version + i + strlen(old_version + i), + strlen(config->colstr.nocolor) + 1, "%s", config->colstr.nocolor); + snprintf(new_version + i + strlen(new_version + i), + strlen(config->colstr.nocolor) + 1, "%s", config->colstr.nocolor); + + pm_asprintf(&str, "%s", old_version); add_table_cell(&ret, str, CELL_NORMAL | CELL_FREE); - pm_asprintf(&str, "%s", - target->install != NULL ? alpm_pkg_get_version(target->install) : ""); + pm_asprintf(&str, "%s", new_version); add_table_cell(&ret, str, CELL_NORMAL | CELL_FREE); /* and size */ @@ -1859,3 +1877,12 @@ void console_erase_line(void) { printf("\x1B[K"); } + +/* inserts string insert into string at index i, modifying string */ +void insertstring(char *string, const char *insert, size_t i) +{ + char temp[strlen(string) - i + 1]; + memcpy(temp, string + i, strlen(string + i) + 1); + memcpy(string + i, insert, strlen(insert) + 1); + memcpy(string + i + strlen(insert), temp, strlen(temp) + 1); +} diff --git a/src/pacman/util.h b/src/pacman/util.h index 52e79915..003961eb 100644 --- a/src/pacman/util.h +++ b/src/pacman/util.h @@ -88,6 +88,7 @@ void console_cursor_move_down(unsigned int lines); void console_cursor_move_end(void); /* Erases line from the current cursor position till the end of the line */ void console_erase_line(void); +void insertstring(char *string, const char *insert, size_t i); int pm_printf(alpm_loglevel_t level, const char *format, ...) __attribute__((format(printf,2,3))); int pm_asprintf(char **string, const char *format, ...) __attribute__((format(printf,2,3))); -- 2.35.1

2 3

[PATCH] doc: Create documentation for pacman-db-upgrade and testpkg
by Ben Westover 03 Aug '22

03 Aug '22

There are two "binaries" that are currently missing documentation, pacman-db-upgrade and testpkg. This patch adds that documentation. Signed-off-by: Ben Westover <kwestover.kw(a)gmail.com> --- doc/meson.build | 2 ++ doc/pacman-db-upgrade.8.asciidoc | 39 ++++++++++++++++++++++++++++++++ doc/testpkg.8.asciidoc | 21 +++++++++++++++++ 3 files changed, 62 insertions(+) create mode 100644 doc/pacman-db-upgrade.8.asciidoc create mode 100644 doc/testpkg.8.asciidoc diff --git a/doc/meson.build b/doc/meson.build index 06df92c9..a18e7f3f 100644 --- a/doc/meson.build +++ b/doc/meson.build @@ -5,7 +5,9 @@ manpages = [ { 'name': 'makepkg-template.1' }, { 'name': 'repo-add.8' }, { 'name': 'vercmp.8' }, + { 'name': 'testpkg.8' }, { 'name': 'pacman-key.8' }, + { 'name': 'pacman-db-upgrade.8' }, { 'name': 'PKGBUILD.5', 'extra_depends' : [ 'PKGBUILD-example.txt' ] }, { 'name': 'makepkg.conf.5' }, { 'name': 'pacman.conf.5' }, diff --git a/doc/pacman-db-upgrade.8.asciidoc b/doc/pacman-db-upgrade.8.asciidoc new file mode 100644 index 00000000..d984179b --- /dev/null +++ b/doc/pacman-db-upgrade.8.asciidoc @@ -0,0 +1,39 @@ +pacman-db-upgrade(8) +==================== + +Name +---- +pacman-db-upgrade - upgrade the local pacman database to a newer format + +Synopsis +-------- +'pacman-db-upgrade' [options] + +Description +----------- +'pacman-db-upgrade' is a script that upgrades the local database used +by linkman:pacman[8] to a newer format. + +Common Options +-------------- +*-h, \--help*:: +Show the built-in help message and exit. +*-V, \--version*:: +Show version information and exit. +*\--nocolor*:: +Remove color from output. + +pacman-db-upgrade Options +------------------------- +*-d, \--dbpath* <path>:: +Set an alternate database location. +*\--config* <path>:: +Set an alternate configuration file. +*-r, \--root* <path>:: +Sset an alternate installation root. + +See Also +-------- +linkman:pacman[8] + +include::footer.asciidoc[] diff --git a/doc/testpkg.8.asciidoc b/doc/testpkg.8.asciidoc new file mode 100644 index 00000000..6401a9be --- /dev/null +++ b/doc/testpkg.8.asciidoc @@ -0,0 +1,21 @@ +testpkg(8) +========== + +Name +---- +testpkg - test a pacman package for validity + +Synopsis +-------- +'testpkg' <package file> + +Description +----------- +'testpkg' is a script used to make sure packages produced by +linkman:makepkg[8] are valid. + +See Also +-------- +linkman:makepkg[8] + +include::footer.asciidoc[] -- 2.37.1

2 4

Runtime dependencies not required for building
by Hugo Osvaldo Barrera 02 Aug '22

02 Aug '22

Some packages I maintain have a lot of runtime dependencies that are not required at build time (this is common for packages which only ship scripts and have no tests). When building on a clean chroot, I have to wait for hundreds of megabytes in packages to be copied and installed. This is rather inefficient, since these are not required. However, the `makedepends` ARE required in this case, but there is no overlap. I'd like some way to indicate that a PKGBUILD does not require its runtime dependencies for building the package. Perhaps something like `options=(!depends)` I'd like to hear feedback on this, thoughts? -- Hugo Osvaldo Barrera

2 2

[Git][pacman/pacman][master] 5 commits: meson: replace deprecated get_pkgconfig_variable()
by Allan McRae (＠allan) 29 Jul '22

29 Jul '22

Allan McRae pushed to branch master at Pacman / Pacman Commits: daa2db6a by Joe Baldino at 2022-07-29T09:41:47+10:00 meson: replace deprecated get_pkgconfig_variable() Apparently that function was deprecated in 0.56, so use the generic getter introduced in 0.51 instead. This squashes a warning. Signed-off-by: Joe Baldino <pedanticdm(a)gmx.us> Signed-off-by: Allan McRae <allan(a)archlinux.org> - - - - - 5abe1455 by Alexander F. Rødseth at 2022-07-29T09:42:38+10:00 pacman: remove redundant argument The fill_progress function is called from two locations, and both locations pass in the same percentage value twice. This patch modifies the function signature to to receive the percentage value just once. Signed-off-by: Alexander F. Rødseth <xyproto(a)archlinux.org> Signed-off-by: Allan McRae <allan(a)archlinux.org> - - - - - 51b2e1c9 by Alexander F. Rødseth at 2022-07-29T09:44:04+10:00 pacman: let the progress bar "C"/"c" move up and down at a more regular rate For some terminal widths, the "C"/"c" character does not alternate at regular intervals, but may look like it is stuck at either lowercase or uppercase. The previous behavior toggled based on the character position, while this new behavior toggles the chomp alternation based on the progress percentage value. This leads to slightly improved chomping. Signed-off-by: Alexander F. Rødseth <xyproto(a)archlinux.org> Signed-off-by: Allan McRae <allan(a)archlinux.org> - - - - - 79bd5121 by Daan De Meyer at 2022-07-29T10:17:52+10:00 Add --keyringdir meson option to configure the keyring directory On Debian, keyrings are stored in /usr/share/keyrings. To support this, let's add a new --keyringdir option that allows configuring the directory under datarootdir where the keyrings should be imported from. We default to 'pacman/keyrings' for backwards compatibility. - - - - - e017a597 by soloturn at 2022-07-29T11:00:01+10:00 makepkg: Add GITFLAGS environmental variable to customise checkout The default flag used to clone a git repository when using makepkg is "--mirror". However, when working with huge repositories, the use of different flags during cloning can allow an faster checkout. For example, using "--filter=blob:none" allows for small checkouts, at the expense of requiring downloads during the build stage if anything but the HEAD commit is used for the build. In addition, this example would serve as a replacement for the often requested (but broken) addition of --depth=1. Add support for the environment variable GITFLAG to pass flags for the git clone command. Note that this overrides the default rather than adding to it in order to prevent incompatibilities. - - - - - 10 changed files: - build-aux/edit-script.sh.in - doc/makepkg.8.asciidoc - doc/meson.build - doc/pacman-key.8.asciidoc - meson.build - meson_options.txt - scripts/completion/zsh_completion.in - scripts/libmakepkg/source/git.sh.in - scripts/pacman-key.sh.in - src/pacman/callback.c View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/compare/ff7c6c8e570bcf5e078763… -- View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/compare/ff7c6c8e570bcf5e078763… You're receiving this email because of your account on gitlab.archlinux.org.

1 0