- Pacman-dev - lists.archlinux.org

[pacman-dev] [PATCH] Allow access to package origin data
by Dan McGee 29 Aug '11

29 Aug '11

Add new alpm_pkg_get_origin() method, use it in the front end now that the enum constants are publicly available. Signed-off-by: Dan McGee <dan(a)archlinux.org> --- README | 2 +- lib/libalpm/alpm.h | 5 +++++ lib/libalpm/package.c | 7 +++++++ src/pacman/package.c | 7 +++---- src/pacman/package.h | 2 +- src/pacman/query.c | 4 ++-- src/pacman/sync.c | 4 ++-- 7 files changed, 21 insertions(+), 10 deletions(-) diff --git a/README b/README index fbd40d2..c14fd3c 100644 --- a/README +++ b/README @@ -429,7 +429,7 @@ API CHANGES BETWEEN 3.5 AND 4.0 alpm_option_get_default_siglevel(), alpm_option_set_default_siglevel(), alpm_option_get_gpgdir(), alpm_option_set_gpgdir(), alpm_db_get_siglevel(), alpm_sigresult_cleanup(), alpm_db_check_pgp_signature(), alpm_pkg_check_pgp_signature(), - alpm_pkg_get_sha256sum(), alpm_pkg_get_base64_sig() + alpm_pkg_get_origin(), alpm_pkg_get_sha256sum(), alpm_pkg_get_base64_sig() - list functions: alpm_list_to_array(), alpm_list_previous() - structs: diff --git a/lib/libalpm/alpm.h b/lib/libalpm/alpm.h index 2f62565..42e6038 100644 --- a/lib/libalpm/alpm.h +++ b/lib/libalpm/alpm.h @@ -598,6 +598,11 @@ const char *alpm_pkg_get_name(alpm_pkg_t *pkg); */ const char *alpm_pkg_get_version(alpm_pkg_t *pkg); +/** Returns the origin of the package. + * @return a #alpm_pkgfrom_t constant, -1 on error + */ +alpm_pkgfrom_t alpm_pkg_get_origin(alpm_pkg_t *pkg); + /** Returns the package description. * @param pkg a pointer to package * @return a reference to an internal string diff --git a/lib/libalpm/package.c b/lib/libalpm/package.c index 3d73a43..487b56d 100644 --- a/lib/libalpm/package.c +++ b/lib/libalpm/package.c @@ -185,6 +185,13 @@ const char SYMEXPORT *alpm_pkg_get_version(alpm_pkg_t *pkg) return pkg->version; } +alpm_pkgfrom_t SYMEXPORT alpm_pkg_get_origin(alpm_pkg_t *pkg) +{ + ASSERT(pkg != NULL, return -1); + pkg->handle->pm_errno = 0; + return pkg->origin; +} + const char SYMEXPORT *alpm_pkg_get_desc(alpm_pkg_t *pkg) { ASSERT(pkg != NULL, return NULL); diff --git a/src/pacman/package.c b/src/pacman/package.c index f7065d5..5654944 100644 --- a/src/pacman/package.c +++ b/src/pacman/package.c @@ -61,7 +61,7 @@ static void deplist_display(const char *title, * @param from the type of package we are dealing with * @param extra should we show extra information */ -void dump_pkg_full(alpm_pkg_t *pkg, alpm_pkgfrom_t from, int extra) +void dump_pkg_full(alpm_pkg_t *pkg, int extra) { const char *reason; time_t bdate, idate; @@ -69,10 +69,9 @@ void dump_pkg_full(alpm_pkg_t *pkg, alpm_pkgfrom_t from, int extra) const char *label; double size; alpm_list_t *requiredby = NULL; + alpm_pkgfrom_t from; - if(pkg == NULL) { - return; - } + from = alpm_pkg_get_origin(pkg); /* set variables here, do all output below */ bdate = alpm_pkg_get_builddate(pkg); diff --git a/src/pacman/package.h b/src/pacman/package.h index 4bbc2ba..890b4fe 100644 --- a/src/pacman/package.h +++ b/src/pacman/package.h @@ -22,7 +22,7 @@ #include <alpm.h> -void dump_pkg_full(alpm_pkg_t *pkg, alpm_pkgfrom_t from, int extra); +void dump_pkg_full(alpm_pkg_t *pkg, int extra); void dump_pkg_backups(alpm_pkg_t *pkg); void dump_pkg_files(alpm_pkg_t *pkg, int quiet); diff --git a/src/pacman/query.c b/src/pacman/query.c index ec98c99..5f2b37e 100644 --- a/src/pacman/query.c +++ b/src/pacman/query.c @@ -460,9 +460,9 @@ static int display(alpm_pkg_t *pkg) if(config->op_q_info) { if(config->op_q_isfile) { - dump_pkg_full(pkg, PKG_FROM_FILE, 0); + dump_pkg_full(pkg, 0); } else { - dump_pkg_full(pkg, PKG_FROM_LOCALDB, config->op_q_info > 1); + dump_pkg_full(pkg, config->op_q_info > 1); } } if(config->op_q_list) { diff --git a/src/pacman/sync.c b/src/pacman/sync.c index a7fe5be..e97da37 100644 --- a/src/pacman/sync.c +++ b/src/pacman/sync.c @@ -469,7 +469,7 @@ static int sync_info(alpm_list_t *syncs, alpm_list_t *targets) alpm_pkg_t *pkg = alpm_list_getdata(k); if(strcmp(alpm_pkg_get_name(pkg), pkgstr) == 0) { - dump_pkg_full(pkg, PKG_FROM_SYNCDB, config->op_s_info > 1); + dump_pkg_full(pkg, config->op_s_info > 1); foundpkg = 1; break; } @@ -494,7 +494,7 @@ static int sync_info(alpm_list_t *syncs, alpm_list_t *targets) for(j = alpm_db_get_pkgcache(db); j; j = alpm_list_next(j)) { alpm_pkg_t *pkg = alpm_list_getdata(j); - dump_pkg_full(pkg, PKG_FROM_SYNCDB, config->op_s_info > 1); + dump_pkg_full(pkg, config->op_s_info > 1); } } } -- 1.7.6

1 0

[pacman-dev] [PATCH] Removed multiple definitions of pkgfrom_t
by Diogo Sousa 29 Aug '11

29 Aug '11

libalpm now exports type alpm_pkgfrom_t in alpm.h, which may be used by frontends. Pacman now uses alpm_pkgfrom_t instead of replicating that type (pkg_from as was in src/pacman/package.h) Updated API change in README. Signed-off-by: Diogo Sousa <diogogsousa(a)gmail.com> --- README | 2 +- lib/libalpm/alpm.h | 6 ++++++ lib/libalpm/package.h | 6 ------ src/pacman/package.c | 2 +- src/pacman/package.h | 9 +-------- 5 files changed, 9 insertions(+), 16 deletions(-) diff --git a/README b/README index d5071a9..fbd40d2 100644 --- a/README +++ b/README @@ -435,7 +435,7 @@ API CHANGES BETWEEN 3.5 AND 4.0 - structs: alpm_backup_t, alpm_file_t, alpm_filelist_t - enums: - alpm_siglevel_t, alpm_sigstatus_t, alpm_sigvalidity_t + alpm_siglevel_t, alpm_sigstatus_t, alpm_sigvalidity_t, alpm_pkgfrom_t - error codes: ALPM_ERR_DB_INVALID, ALPM_ERR_DB_INVALID_SIG, ALPM_ERR_GPGME, ALPM_ERR_PKG_INVALID_CHECKSUM, ALPM_ERR_PKG_INVALID_SIG, ALPM_ERR_SIG_INVALID, diff --git a/lib/libalpm/alpm.h b/lib/libalpm/alpm.h index c94cdf7..2f62565 100644 --- a/lib/libalpm/alpm.h +++ b/lib/libalpm/alpm.h @@ -60,6 +60,12 @@ typedef enum _alpm_pkgreason_t { ALPM_PKG_REASON_DEPEND = 1 } alpm_pkgreason_t; +typedef enum _alpm_pkgfrom_t { + PKG_FROM_FILE = 1, + PKG_FROM_LOCALDB, + PKG_FROM_SYNCDB +} alpm_pkgfrom_t; + /** Types of version constraints in dependency specs. */ typedef enum _alpm_depmod_t { /** No version constraint */ diff --git a/lib/libalpm/package.h b/lib/libalpm/package.h index 707405d..5962b1d 100644 --- a/lib/libalpm/package.h +++ b/lib/libalpm/package.h @@ -34,12 +34,6 @@ #include "db.h" #include "signing.h" -typedef enum _alpm_pkgfrom_t { - PKG_FROM_FILE = 1, - PKG_FROM_LOCALDB, - PKG_FROM_SYNCDB -} alpm_pkgfrom_t; - /** Package operations struct. This struct contains function pointers to * all methods used to access data in a package to allow for things such * as lazy package intialization (such as used by the file backend). Each diff --git a/src/pacman/package.c b/src/pacman/package.c index a8c15eb..f7065d5 100644 --- a/src/pacman/package.c +++ b/src/pacman/package.c @@ -61,7 +61,7 @@ static void deplist_display(const char *title, * @param from the type of package we are dealing with * @param extra should we show extra information */ -void dump_pkg_full(alpm_pkg_t *pkg, enum pkg_from from, int extra) +void dump_pkg_full(alpm_pkg_t *pkg, alpm_pkgfrom_t from, int extra) { const char *reason; time_t bdate, idate; diff --git a/src/pacman/package.h b/src/pacman/package.h index 6f71d20..4bbc2ba 100644 --- a/src/pacman/package.h +++ b/src/pacman/package.h @@ -22,14 +22,7 @@ #include <alpm.h> -/* TODO it would be nice if we didn't duplicate a backend type */ -enum pkg_from { - PKG_FROM_FILE = 1, - PKG_FROM_LOCALDB, - PKG_FROM_SYNCDB -}; - -void dump_pkg_full(alpm_pkg_t *pkg, enum pkg_from from, int extra); +void dump_pkg_full(alpm_pkg_t *pkg, alpm_pkgfrom_t from, int extra); void dump_pkg_backups(alpm_pkg_t *pkg); void dump_pkg_files(alpm_pkg_t *pkg, int quiet); -- 1.7.6.1

2 1

[pacman-dev] [PATCH] _alpm_splitdep(): don't pass bogus length value to strndup
by Dan McGee 29 Aug '11

29 Aug '11

If we fell through to the ALPM_DEP_MOD_ANY case, ptr would be NULL, and we would pass (0 - <str>), which is a rather large negative number or bogus positive number, depending on signed/unsigned. Just use strdup in the case where we don't have a ptr available. Signed-off-by: Dan McGee <dan(a)archlinux.org> --- lib/libalpm/deps.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/lib/libalpm/deps.c b/lib/libalpm/deps.c index 47b7637..e268157 100644 --- a/lib/libalpm/deps.c +++ b/lib/libalpm/deps.c @@ -441,7 +441,11 @@ alpm_depend_t *_alpm_splitdep(const char *depstring) } /* copy the right parts to the right places */ - STRNDUP(depend->name, depstring, ptr - depstring, return NULL); + if(ptr) { + STRNDUP(depend->name, depstring, ptr - depstring, return NULL); + } else { + STRDUP(depend->name, depstring, return NULL); + } depend->name_hash = _alpm_hash_sdbm(depend->name); if(version) { STRDUP(depend->version, version, return NULL); -- 1.7.6

1 0

[pacman-dev] [PATCH] Database read optimizations
by Dan McGee 29 Aug '11

29 Aug '11

Hard to believe there was still more room to improve on this, but I found an easily correctable oversight tonight. Our databases (both sync and local) contain many blank lines, and we were not moving onto the next line right away in these cases; instead we would proceed through our strcmp() conditional checks as normal. Some local numbers follow to show the effects of this patch: Sync `-Ss foobarbaz`: 71,709 blank lines skipped early ~1,505,889 strcmp() calls avoided (21 per line) ~15% speed improvement (.210 --> .179 sec) Local `-Qs foobarbaz`: 6,823 blank lines skipped early 115,991 strcmp() calls avoided (17 per line) ~6% speed improvement (.080 -> .071 sec) Signed-off-by: Dan McGee <dan(a)archlinux.org> --- lib/libalpm/be_local.c | 8 +++++++- lib/libalpm/be_sync.c | 5 ++++- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/lib/libalpm/be_local.c b/lib/libalpm/be_local.c index 1a46dfd..be02bb5 100644 --- a/lib/libalpm/be_local.c +++ b/lib/libalpm/be_local.c @@ -580,7 +580,13 @@ static int local_db_read(alpm_pkg_t *info, alpm_dbinfrq_t inforeq) goto error; } while(!feof(fp)) { - READ_NEXT(); + if(fgets(line, sizeof(line), fp) == NULL && !feof(fp)) { + goto error; + } + if(_alpm_strip_newline(line) == 0) { + /* length of stripped line was zero */ + continue; + } if(strcmp(line, "%NAME%") == 0) { READ_NEXT(); if(strcmp(line, info->name) != 0) { diff --git a/lib/libalpm/be_sync.c b/lib/libalpm/be_sync.c index ac99e05..12d5b7f 100644 --- a/lib/libalpm/be_sync.c +++ b/lib/libalpm/be_sync.c @@ -526,7 +526,10 @@ static int sync_db_read(alpm_db_t *db, struct archive *archive, int ret; while((ret = _alpm_archive_fgets(archive, &buf)) == ARCHIVE_OK) { char *line = buf.line; - _alpm_strip_newline(line); + if(_alpm_strip_newline(line) == 0) { + /* length of stripped line was zero */ + continue; + } if(strcmp(line, "%NAME%") == 0) { READ_NEXT(); -- 1.7.6

1 0

[pacman-dev] [PATCH] Removed multiple definitions of pkgfrom_t
by Diogo Sousa 29 Aug '11

29 Aug '11

libalpm now exports type alpm_pkgfrom_t in alpm.h, which may be used by frontends. Pacman now uses alpm_pkgfrom_t instead of replicating that type (pkg_from as was in src/pacman/package.h) Signed-off-by: Diogo Sousa <diogogsousa(a)gmail.com> --- lib/libalpm/alpm.h | 6 ++++++ lib/libalpm/package.h | 6 ------ src/pacman/package.c | 2 +- src/pacman/package.h | 9 +-------- 4 files changed, 8 insertions(+), 15 deletions(-) diff --git a/lib/libalpm/alpm.h b/lib/libalpm/alpm.h index fc8f0bc..b1e9a88 100644 --- a/lib/libalpm/alpm.h +++ b/lib/libalpm/alpm.h @@ -197,6 +197,12 @@ typedef struct _alpm_file_t { mode_t mode; } alpm_file_t; +typedef enum _alpm_pkgfrom_t { + PKG_FROM_FILE = 1, + PKG_FROM_LOCALDB, + PKG_FROM_SYNCDB +} alpm_pkgfrom_t; + /** Package filelist container */ typedef struct _alpm_filelist_t { size_t count; diff --git a/lib/libalpm/package.h b/lib/libalpm/package.h index 25d1b1a..a75f6ae 100644 --- a/lib/libalpm/package.h +++ b/lib/libalpm/package.h @@ -34,12 +34,6 @@ #include "db.h" #include "signing.h" -typedef enum _alpm_pkgfrom_t { - PKG_FROM_FILE = 1, - PKG_FROM_LOCALDB, - PKG_FROM_SYNCDB -} alpm_pkgfrom_t; - /** Package operations struct. This struct contains function pointers to * all methods used to access data in a package to allow for things such * as lazy package intialization (such as used by the file backend). Each diff --git a/src/pacman/package.c b/src/pacman/package.c index 80c6bf2..ef483ef 100644 --- a/src/pacman/package.c +++ b/src/pacman/package.c @@ -61,7 +61,7 @@ static void deplist_display(const char *title, * @param from the type of package we are dealing with * @param extra should we show extra information */ -void dump_pkg_full(alpm_pkg_t *pkg, enum pkg_from from, int extra) +void dump_pkg_full(alpm_pkg_t *pkg, alpm_pkgfrom_t from, int extra) { const char *reason; time_t bdate, idate; diff --git a/src/pacman/package.h b/src/pacman/package.h index 6f71d20..4bbc2ba 100644 --- a/src/pacman/package.h +++ b/src/pacman/package.h @@ -22,14 +22,7 @@ #include <alpm.h> -/* TODO it would be nice if we didn't duplicate a backend type */ -enum pkg_from { - PKG_FROM_FILE = 1, - PKG_FROM_LOCALDB, - PKG_FROM_SYNCDB -}; - -void dump_pkg_full(alpm_pkg_t *pkg, enum pkg_from from, int extra); +void dump_pkg_full(alpm_pkg_t *pkg, alpm_pkgfrom_t from, int extra); void dump_pkg_backups(alpm_pkg_t *pkg); void dump_pkg_files(alpm_pkg_t *pkg, int quiet); -- 1.7.6.1

3 3

[pacman-dev] [PATCH 1/3] lib/libalpm/signing.c: Fix memory leak in decode_signature() in case of error.
by Diogo Sousa 29 Aug '11

29 Aug '11

Signed-off-by: Diogo Sousa <diogogsousa(a)gmail.com> --- lib/libalpm/signing.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/lib/libalpm/signing.c b/lib/libalpm/signing.c index 8db4a7b..67f7adf 100644 --- a/lib/libalpm/signing.c +++ b/lib/libalpm/signing.c @@ -175,6 +175,7 @@ static int decode_signature(const char *base64_data, size_t destlen = len * 3 / 4; MALLOC(*data, destlen, goto error); if(base64_decode(*data, &destlen, usline, len)) { + free(*data); goto error; } *data_len = destlen; -- 1.7.6.1

2 4

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v4.0.0rc1-112-g2cfcc87
by dan＠archlinux.org 29 Aug '11

29 Aug '11

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, master has been updated via 2cfcc874b9332ad207398b9e20dc8880d93e8ae4 (commit) via dc3336c27728fc16d2f9e68cb818648e7ca88467 (commit) via c7e4005e5ced965db49d73067fe40c516b6c34df (commit) via de43d00db071a04653cff592607647bb9c01d025 (commit) via 12387ca4e5c16994bacad52c142ef94868ba545a (commit) via 0dad2f6e6223e2aa00c43b59f49bf83082a0d6bb (commit) via a12a4ea3960c98817aa60df5a8879d118a16e2a7 (commit) via 455ca55f4efecf48bf86904e4a67a4b124cf1838 (commit) via a2002b8f690e12a7e8c75a3a9184570d27709c71 (commit) via 87fb8f5d5795be9b2bcb025eac26c94d7bb1e7b3 (commit) via 84d6de806bd18f4a6c0940de5ee60904f650539c (commit) via 5a07b75b225cbc731fbfb915a9c9edf0c300ccc4 (commit) via be72e100159e6cd50ac64e3639f8e4f98218ccae (commit) via c5982a3eb5287afdec6c9b859f81795c773da8fe (commit) from e1dce078b247142f7db80bf2d338e431df34691e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2cfcc874b9332ad207398b9e20dc8880d93e8ae4 Author: Dan McGee <dan(a)archlinux.org> Date: Thu Aug 25 18:29:00 2011 -0500 Better error handling out of package load method There are many other ways to fail a package load other than "file not found". We should also use the correct error code in this case. Clean it up a bit in the various callers. Signed-off-by: Dan McGee <dan(a)archlinux.org> commit dc3336c27728fc16d2f9e68cb818648e7ca88467 Author: Dan McGee <dan(a)archlinux.org> Date: Thu Aug 25 16:40:39 2011 -0500 Refactor some args out of pkg_load_internal Just pass the entire sync package in if we have it; that way we can do any necessary operations involving it rather than have a parameter list growing endlessly. Signed-off-by: Dan McGee <dan(a)archlinux.org> commit c7e4005e5ced965db49d73067fe40c516b6c34df Author: Dan McGee <dan(a)archlinux.org> Date: Thu Aug 25 10:29:02 2011 -0500 Add more info to debug key display Signed-off-by: Dan McGee <dan(a)archlinux.org> commit de43d00db071a04653cff592607647bb9c01d025 Author: Dan McGee <dan(a)archlinux.org> Date: Wed Aug 24 13:24:42 2011 -0500 Refactor signature result return format I was trying to take a shortcut and not introduce a wrapper struct for the signature results, so packed it all into alpm_sigresult_t in the first iteration. However, this is painful when one wants to add new fields or only return information regarding a single signature. Refactor the type into a few components which are exposed to the end user, and will allow a lot more future flexibility. This also exposes more information regarding the key to the frontend than was previously available. The "private" void *data pointer is used by the library to store the actual key object returned by gpgme; it is typed this way so the frontend has no expectations of what is there, and so we don't have any hard gpgme requirement in our public API. Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 12387ca4e5c16994bacad52c142ef94868ba545a Author: Diogo Sousa <diogogsousa(a)gmail.com> Date: Sat Aug 27 22:03:45 2011 +0100 lib/libalpm/signing.c: Fix memory leak in decode_signature() in case of error. Signed-off-by: Diogo Sousa <diogogsousa(a)gmail.com> Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 0dad2f6e6223e2aa00c43b59f49bf83082a0d6bb Author: Lukas Fleischer <archlinux(a)cryptocrack.de> Date: Fri Aug 26 13:10:38 2011 +0200 lib/libalpm/util.c: Fix two memory leaks Free "md5sum" if md5_file() fails in alpm_compute_md5sum(). Free "sha256sum" if sha2_file() fails in alpm_compute_sha256sum(). Signed-off-by: Lukas Fleischer <archlinux(a)cryptocrack.de> Signed-off-by: Dan McGee <dan(a)archlinux.org> commit a12a4ea3960c98817aa60df5a8879d118a16e2a7 Author: Dan McGee <dan(a)archlinux.org> Date: Sun Aug 28 19:46:09 2011 -0500 Check local database status flag in db_write sanity check block Do all the checks at once; this also avoids the 'return' call after we have allocated memory for "pkgpath" as well as tweaked the umask. Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 455ca55f4efecf48bf86904e4a67a4b124cf1838 Author: Lukas Fleischer <archlinux(a)cryptocrack.de> Date: Fri Aug 26 13:10:37 2011 +0200 be_sync.c: Fix memory leak in alpm_db_update() Free "syncpath" and restore umask if we fail to grab a lock. Signed-off-by: Lukas Fleischer <archlinux(a)cryptocrack.de> Signed-off-by: Dan McGee <dan(a)archlinux.org> commit a2002b8f690e12a7e8c75a3a9184570d27709c71 Author: Lukas Fleischer <archlinux(a)cryptocrack.de> Date: Fri Aug 26 13:10:35 2011 +0200 pacman.c: Remove redundant strdup() in parsearg_global() config_set_arch() already calls strdup(). Remove strdup() from the config_set_arch() invocation to avoid a memory leak. Signed-off-by: Lukas Fleischer <archlinux(a)cryptocrack.de> Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 87fb8f5d5795be9b2bcb025eac26c94d7bb1e7b3 Author: Dan McGee <dan(a)archlinux.org> Date: Thu Aug 25 18:37:23 2011 -0500 Make sync error message smarter on unfound targets We had two issues here. One is a file with an absolute path passed to -S results in a cryptic error message due to the database name being '\0'. The second is not realizing you should be doing -U instead of -S. Fix both of these to transform this: $ sudo pacman -S /tmp/binutils-2.21.1-2-i686.pkg.tar.xz error: database not found: to this: $ sudo pacman -S /tmp/binutils-2.21.1-2-i686.pkg.tar.xz error: target not found: /tmp/binutils-2.21.1-2-i686.pkg.tar.xz warning: '/tmp/binutils-2.21.1-2-i686.pkg.tar.xz' is a file, did you mean -U/--upgrade instead of -S/--sync? Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 84d6de806bd18f4a6c0940de5ee60904f650539c Author: Dan McGee <dan(a)archlinux.org> Date: Sat Aug 27 08:45:39 2011 -0500 Fix possible mismatched type with several curl arguments After commit 2e7d0023150664, we use off_t rather than long variables. Use the _LARGE variants of the methods to indicate we are passing off_t sized variables, and cast using (curl_off_t) accordingly. Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 5a07b75b225cbc731fbfb915a9c9edf0c300ccc4 Author: Dan McGee <dan(a)archlinux.org> Date: Thu Aug 25 17:41:47 2011 -0500 Always process validity value returned by gpgme Don't force 'never'; you should be checking both the status and validity anyway. Signed-off-by: Dan McGee <dan(a)archlinux.org> commit be72e100159e6cd50ac64e3639f8e4f98218ccae Author: Dan McGee <dan(a)archlinux.org> Date: Thu Aug 25 17:41:27 2011 -0500 Fix small memory leak in sig check code Signed-off-by: Dan McGee <dan(a)archlinux.org> commit c5982a3eb5287afdec6c9b859f81795c773da8fe Author: Dan McGee <dan(a)archlinux.org> Date: Thu Aug 25 17:14:19 2011 -0500 strtrim: don't move empty string There were many cases where the string coming in was a blank line, e.g. "\n\0", length 1. The trim routine starts by trimming leading spaces, thus trimming everything. We would then proceed to do a memmove of the NULL byte, which is completely worthless as we can just assign it instead. Signed-off-by: Dan McGee <dan(a)archlinux.org> ----------------------------------------------------------------------- Summary of changes: lib/libalpm/alpm.h | 28 +++++++--- lib/libalpm/be_local.c | 6 +-- lib/libalpm/be_package.c | 68 ++++++++++++----------- lib/libalpm/be_sync.c | 2 + lib/libalpm/dload.c | 6 ++- lib/libalpm/package.h | 3 +- lib/libalpm/signing.c | 133 ++++++++++++++++++++++----------------------- lib/libalpm/signing.h | 2 +- lib/libalpm/sync.c | 3 +- lib/libalpm/util.c | 9 +++- src/pacman/package.c | 8 ++-- src/pacman/pacman.c | 2 +- src/pacman/query.c | 14 ++++- src/pacman/sync.c | 9 ++- src/pacman/util.c | 22 +++++--- src/pacman/util.h | 2 +- src/util/pactree.c | 7 ++- src/util/testpkg.c | 3 + valgrind.supp | 1 - 19 files changed, 186 insertions(+), 142 deletions(-) hooks/post-receive -- The official pacman repository

1 0

[pacman-dev] [PATCH 1/4] pacman.c: Remove redundant strdup() in parsearg_global()
by Lukas Fleischer 29 Aug '11

29 Aug '11

config_set_arch() already calls strdup(). Remove strdup() from the config_set_arch() invocation to avoid a memory leak. Signed-off-by: Lukas Fleischer <archlinux(a)cryptocrack.de> --- src/pacman/pacman.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/pacman/pacman.c b/src/pacman/pacman.c index 71413bd..d285a05 100644 --- a/src/pacman/pacman.c +++ b/src/pacman/pacman.c @@ -385,7 +385,7 @@ static int parsearg_global(int opt) switch(opt) { case OP_ARCH: check_optarg(); - config_set_arch(strdup(optarg)); + config_set_arch(optarg); break; case OP_ASK: check_optarg(); -- 1.7.6.1

2 7

[pacman-dev] Inconsistent output when db.lck present
by Allan McRae 28 Aug '11

28 Aug '11

For example: allan@mugen ~ > sudo touch /var/lib/pacman/db.lck Password: allan@mugen ~ > pacman -Syu :: Synchronizing package databases... error: failed to update allanbrokeit (unable to lock database) error: failed to update kernel64 (unable to lock database) error: failed to update testing (unable to lock database) error: failed to update core (unable to lock database) error: failed to update extra (unable to lock database) error: failed to update community-testing (unable to lock database) error: failed to update community (unable to lock database) error: failed to synchronize any databases allan@mugen ~ > pacman -U /var/abs/local/pacman-git/pacman-git-20110828-1-i686.pkg.tar.xz error: failed to init transaction (unable to lock database) if you're sure a package manager is not already running, you can remove /var/lib/pacman/db.lck Allan

3 2

[pacman-dev] [PATCH] Fix possible mismatched type with several curl arguments
by Dan McGee 27 Aug '11

27 Aug '11

After commit 2e7d0023150664, we use off_t rather than long variables. Use the _LARGE variants of the methods to indicate we are passing off_t sized variables, and cast using (curl_off_t) accordingly. Signed-off-by: Dan McGee <dan(a)archlinux.org> --- lib/libalpm/dload.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/libalpm/dload.c b/lib/libalpm/dload.c index 6ae6917..8cdb075 100644 --- a/lib/libalpm/dload.c +++ b/lib/libalpm/dload.c @@ -205,7 +205,8 @@ static void curl_set_handle_opts(struct dload_payload *payload, curl_easy_setopt(handle->curl, CURLOPT_WRITEHEADER, (void *)payload); if(payload->max_size) { - curl_easy_setopt(handle->curl, CURLOPT_MAXFILESIZE, payload->max_size); + curl_easy_setopt(handle->curl, CURLOPT_MAXFILESIZE_LARGE, + (curl_off_t)payload->max_size); } if(useragent != NULL) { @@ -220,7 +221,8 @@ static void curl_set_handle_opts(struct dload_payload *payload, } else if(stat(payload->tempfile_name, &st) == 0 && payload->allow_resume) { /* a previous partial download exists, resume from end of file. */ payload->tempfile_openmode = "ab"; - curl_easy_setopt(handle->curl, CURLOPT_RESUME_FROM, (long)st.st_size); + curl_easy_setopt(handle->curl, CURLOPT_RESUME_FROM_LARGE, + (curl_off_t)st.st_size); _alpm_log(handle, ALPM_LOG_DEBUG, "tempfile found, attempting continuation\n"); payload->initial_size = st.st_size; } -- 1.7.6

2 1