- Pacman-dev - lists.archlinux.org

[pacman-dev] Fwd: [arch-general] Makepkg $(srcdir) detection and false-positives
by Allan McRae 15 Sep '10

15 Sep '10

Forwarding to pacman-dev. The idea seems reasonable to me as this check was mainly to catch bad paths in configuration files. Allan -------- Original Message -------- Subject: [arch-general] Makepkg $(srcdir) detection and false-positives Date: Fri, 27 Aug 2010 08:58:28 +0100 From: Nathan Wayde <kumyco(a)konnichi.com> Reply-To: General Discussion about Arch Linux <arch-general(a)archlinux.org> Organization: Konnichi Computing To: General Discusson about Arch Linux <arch-general(a)archlinux.org> I'm not sure if this is the correct ML or not but whatever I'll post here anyway. I was just reading the ML where the quest? to finding why makepkg warns about $srcdir was brought up and a simple grep -R... seemed to be the method of detection. Anyway it reminded me of another message on the topic last week i think where someone said that it would warn on files with debugging symbols... TL;DR makepkg does a grep -q to decide if a package contains files that reference $(srcdir), this is inadequate as it causes a false-positive on files that contain debugging symbols. This can be eliminated by specifying the option `-I` a.k.a `--binary-files=without-match` to grep which makes prevents grep from matching binary files. Rationale: the only paths that binary files should contain based on buildtime setting are path such as '/usr/share/xyz'. If the pkgbuild *accidentally* uses a variable that resolves with $srcdir in it then I'd argue that the pkgbuild is broken and will most likely break the application in other ways and will be caught before sharing the pkgbuild. I can't be the only one that tests their packages before uploading to the AUR right? On another note, shouldn't there also be a check for $pkgdir. The only cases of this that I've ran into myself have been a reference to $pkgdir causing all sorts of nonsense such as broken symlinks and incorrect resource paths.

1 0

[pacman-dev] [GIT] The official pacman repository branch, maint, updated. v3.4.1-5-gc299319
by dan＠archlinux.org 15 Sep '10

15 Sep '10

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, maint has been updated via c2993197ea383aaeb4b0585bfe46235e8c14939d (commit) via 79541193f736c3b5a5d1f9a4b902608c8faaad37 (commit) via e29dde9157cadd0ce8bafb22e5157d853faf005a (commit) from 6d41da4086d658a3d416e7b23b7566e84fe0462f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- ----------------------------------------------------------------------- Summary of changes: doc/PKGBUILD-example.txt | 2 +- lib/libalpm/po/kk.po | 18 ++-- po/kk.po | 171 ++++++++++++++-------------- po/pt.po | 278 +++++++++++++++++++++++++--------------------- 4 files changed, 246 insertions(+), 223 deletions(-) hooks/post-receive -- The official pacman repository

1 0

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v3.4.1-63-gd201d1f
by dan＠archlinux.org 15 Sep '10

15 Sep '10

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, master has been updated via d201d1f312308b91eff78cb20a148146c3f1188c (commit) via c2993197ea383aaeb4b0585bfe46235e8c14939d (commit) via 79541193f736c3b5a5d1f9a4b902608c8faaad37 (commit) via e29dde9157cadd0ce8bafb22e5157d853faf005a (commit) via 31aed1243ec70632d4e319e67c09446f1a474a6e (commit) via e344fab3b12803b3a43aebe0b1a57c49631cc0ff (commit) via 6d41da4086d658a3d416e7b23b7566e84fe0462f (commit) via df15a8c4322d10393cf6fda5a5f29f4a1a299709 (commit) from fe788ee4a68d2a8ba3bc3f938172294589c36fc4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d201d1f312308b91eff78cb20a148146c3f1188c Merge: 31aed12 c299319 Author: Dan McGee <dan(a)archlinux.org> Date: Wed Sep 15 07:31:37 2010 -0500 Merge branch 'maint' commit 31aed1243ec70632d4e319e67c09446f1a474a6e Author: Dan McGee <dan(a)archlinux.org> Date: Tue Sep 7 08:27:25 2010 -0500 Remove quotes in remaining bash regexes After a8dcfeccfc, Allan noted that one more regular exprssion inside makepkg also contained quotes; these should not be there for the same reason as that commit. Signed-off-by: Dan McGee <dan(a)archlinux.org> commit e344fab3b12803b3a43aebe0b1a57c49631cc0ff Author: Dan McGee <dan(a)archlinux.org> Date: Tue Sep 7 08:24:36 2010 -0500 Restore trimming of db and pkg extensions These keep having to change because we are getting really good at changing the downloaded filename. Shorten the match sequences to just .db and .pkg and trim everything after and including these strings. Signed-off-by: Dan McGee <dan(a)archlinux.org> ----------------------------------------------------------------------- Summary of changes: NEWS | 6 +- doc/PKGBUILD-example.txt | 2 +- lib/libalpm/po/kk.po | 18 ++-- lib/libalpm/po/pt.po | 8 +- po/en_GB.po | 1 - po/fr.po | 1 - po/hu.po | 1 - po/it.po | 1 - po/kk.po | 171 ++++++++++++------------ po/pt.po | 335 +++++++++++++++++++++++----------------------- po/ru.po | 2 +- po/sk.po | 1 - scripts/makepkg.sh.in | 2 +- src/pacman/callback.c | 2 +- 14 files changed, 274 insertions(+), 277 deletions(-) hooks/post-receive -- The official pacman repository

1 0

[pacman-dev] Updated Kazakh translation on Transifex.net
by Baurzhan Muftakhidinov 15 Sep '10

15 Sep '10

Hi all! I've updated Kazakh translation of pacman and libalpm. http://www.transifex.net/projects/p/archlinux-pacman/ So, please commit it;) Thanks,

2 1

[pacman-dev] [PATCH 1/3] libalpm md5: use larger and dynamic buffer
by Dan McGee 12 Sep '10

12 Sep '10

This gave at least a 10% improvement on a few tested platforms due to the reduced number of read calls from files when computing the md5sum. It really is just a precursor to another patch to come which is to use MD5 functions that do the job a lot better than anything we can do. Signed-off-by: Dan McGee <dan(a)archlinux.org> --- lib/libalpm/md5.c | 13 +++++++++++-- 1 files changed, 11 insertions(+), 2 deletions(-) diff --git a/lib/libalpm/md5.c b/lib/libalpm/md5.c index 7d2716f..9063504 100644 --- a/lib/libalpm/md5.c +++ b/lib/libalpm/md5.c @@ -36,6 +36,8 @@ * int md5_file( char *path, unsigned char *output ) * to * int md5_file( const char *path, unsigned char *output ) + * * use a dynamically-allocated buffer in md5_file, and increase the size + * for performance reasons * * various static/inline changes * * NOTE: XySSL has been renamed to PolarSSL, which is available at @@ -44,6 +46,7 @@ #include <string.h> #include <stdio.h> +#include <stdlib.h> #include "md5.h" @@ -309,11 +312,16 @@ int md5_file( const char *path, unsigned char output[16] ) FILE *f; size_t n; md5_context ctx; - unsigned char buf[1024]; + unsigned char *buf; - if( ( f = fopen( path, "rb" ) ) == NULL ) + if( ( buf = calloc(8192, sizeof(unsigned char)) ) == NULL ) return( 1 ); + if( ( f = fopen( path, "rb" ) ) == NULL ) { + free( buf ); + return( 1 ); + } + md5_starts( &ctx ); while( ( n = fread( buf, 1, sizeof( buf ), f ) ) > 0 ) @@ -322,6 +330,7 @@ int md5_file( const char *path, unsigned char output[16] ) md5_finish( &ctx, output ); memset( &ctx, 0, sizeof( md5_context ) ); + free( buf ); if( ferror( f ) != 0 ) { -- 1.7.2.2

7 18

[pacman-dev] [PATCH] Restore trimming of db and pkg extensions
by Dan McGee 07 Sep '10

07 Sep '10

These keep having to change because we are getting really good at changing the downloaded filename. Shorten the match sequences to just .db and .pkg and trim everything after and including these strings. Signed-off-by: Dan McGee <dan(a)archlinux.org> --- src/pacman/callback.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/pacman/callback.c b/src/pacman/callback.c index 3696d3c..32dafb5 100644 --- a/src/pacman/callback.c +++ b/src/pacman/callback.c @@ -575,7 +575,7 @@ void cb_dl_progress(const char *filename, off_t file_xfered, off_t file_total) fname = strdup(filename); /* strip package or DB extension for cleaner look */ - if((p = strstr(fname, ".pkg.tar.")) || (p = strstr(fname, ".db.tar."))) { + if((p = strstr(fname, ".pkg")) || (p = strstr(fname, ".db"))) { *p = '\0'; } /* In order to deal with characters from all locales, we have to worry -- 1.7.2.3

3 2

[pacman-dev] [PATCH] Remove quotes in remaining bash regexes
by Dan McGee 07 Sep '10

07 Sep '10

After a8dcfeccfc, Allan noted that one more regular exprssion inside makepkg also contained quotes; these should not be there for the same reason as that commit. Signed-off-by: Dan McGee <dan(a)archlinux.org> --- scripts/makepkg.sh.in | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index aa85b85..de24338 100644 --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in @@ -1448,7 +1448,7 @@ parse_options() { elif [[ ${1:0:1} = '-' ]]; then for ((i=1; i<${#1}; i++)); do if [[ $short_options =~ ${1:i:1} ]]; then - if [[ $short_options =~ "${1:i:1}:" ]]; then + if [[ $short_options =~ ${1:i:1}: ]]; then if [[ -n ${1:$i+1} ]]; then printf ' -%s' "${1:i:1}" printf " '%s'" "${1:$i+1}" -- 1.7.2.3

1 0

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v3.4.1-55-gfe788ee
by dan＠archlinux.org 07 Sep '10

07 Sep '10

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, master has been updated via fe788ee4a68d2a8ba3bc3f938172294589c36fc4 (commit) from 881bf5c90f18cae47d4da06e570c934fdbdd4ecc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit fe788ee4a68d2a8ba3bc3f938172294589c36fc4 Author: Dan McGee <dan(a)archlinux.org> Date: Mon Sep 6 11:20:51 2010 -0500 Fix libfetch configure checking I don't know what I tested in commit 3e7b90ff6950, but it definitely wasn't working as advertised. Fix the checks in the source code itself to match the right define (HAVE_LIBFETCH), as well as make sure the configure check defaults to looking for the library but not bailing if it could not be found. Signed-off-by: Dan McGee <dan(a)archlinux.org> ----------------------------------------------------------------------- Summary of changes: configure.ac | 2 +- lib/libalpm/alpm.c | 6 +++--- lib/libalpm/dload.c | 6 +++--- lib/libalpm/error.c | 4 ++-- 4 files changed, 9 insertions(+), 9 deletions(-) hooks/post-receive -- The official pacman repository

1 0

[pacman-dev] Package pacman.
by Albino Biasutti Neto 07 Sep '10

07 Sep '10

Good Morning. The package 'pacman-3.4.1-1', is bug. For update any package, is needed do pacman -Sf. Thank you, sorry my english, -- - °v° Albino Biasutti Neto | Bino aka bino28 - /(_)\ GNU-Linux - Livre, Poderoso e Seguro - ^ ^ Linux User #511213 - Archlinux-br user - http://www.archlinux-br.org - Debian Brasil Member - KDE Brasil Member - GUBrO-ES - Grupo de Usuários de BrOffice.org do ES - Tux-ES member - www.tux-es.org - http://www.binoinformatica.com /blog On Mon, Sep 6, 2010 at 12:46 PM, <pacman-dev-request(a)archlinux.org> wrote: > Send pacman-dev mailing list submissions to > pacman-dev(a)archlinux.org > > To subscribe or unsubscribe via the World Wide Web, visit > http://mailman.archlinux.org/mailman/listinfo/pacman-dev > or, via email, send a message with subject or body 'help' to > pacman-dev-request(a)archlinux.org > > You can reach the person managing the list at > pacman-dev-owner(a)archlinux.org > > When replying, please edit your Subject line so it is more specific > than "Re: Contents of pacman-dev digest..." > > > Today's Topics: > > 1. Re: [PATCH 2/3] Use OpenSSL MD5 crypto functions if available > (Allan McRae) > 2. Re: [PATCH 2/3] Use OpenSSL MD5 crypto functions if available > (Dan McGee) > 3. Re: [PATCH 2/3] Use OpenSSL MD5 crypto functions if available > (Allan McRae) > > > ---------------------------------------------------------------------- > > Message: 1 > Date: Tue, 07 Sep 2010 01:04:48 +1000 > From: Allan McRae <allan(a)archlinux.org> > Subject: Re: [pacman-dev] [PATCH 2/3] Use OpenSSL MD5 crypto functions > if available > To: Bryce Gibson <bryce(a)gibson-consulting.com.au>, Discussion list > for pacman development <pacman-dev(a)archlinux.org> > Message-ID: <4C850310.3080304(a)archlinux.org> > Content-Type: text/plain; charset=UTF-8; format=flowed > > On 07/09/10 00:25, Bryce Gibson wrote: > > > > ----- Original message ----- > >> On 04/09/10 19:16, J?rgen H?tzel wrote: > >>> Hi Dan, > >>> > >>> 2010/9/2 Dan McGee<dan(a)archlinux.org>: > >>>> This does not remove the MD5 code from our codebase, but it does > >>>> enable linking against OpenSSL to get their much faster > >>>> implementation if it is available on whatever platform you are > >>>> using. At configure-time, we will default to using it if it is > >>>> available, but this can be easily changed by using the > >>>> `--with-openssl` or `--without-openssl` arguments to configure. > >>> > >>> What about just replacing the current MD5 implementation with the > >>> OpenSSL implementation? > >>> > >>> This would prevent conditional compilation and a direct OpenSSL > >>> dependency in libalpm. > >> > >> Can we do that? Openssl is BSD code. > >> > >> > >> Anyway, I have concerns... Think of an openssl upgrade. pacman is > in > >> SyncFirst and it pulls in all its deps. If that pulls in openssl with > a > >> soname bump, things may get interesting. I have not check, but I do > not > >> think --as-needed saves us there. > >> > >> Allan > >> > > The licenses that openssl is released under aren't compatible with the > gpl (according to the fsf) because of the advertising clause... So openssl > code can't really be used like that... (Unfortunately) > > How does the coreutils md5sum speed compare? That is GPL code so could > be included directly. Though I guess it is now GPL3 being a GNU project... > > Allan > > > > > > > ------------------------------ > > Message: 2 > Date: Mon, 6 Sep 2010 10:15:46 -0500 > From: Dan McGee <dpmcgee(a)gmail.com> > Subject: Re: [pacman-dev] [PATCH 2/3] Use OpenSSL MD5 crypto functions > if available > To: Discussion list for pacman development <pacman-dev(a)archlinux.org> > Message-ID: > <AANLkTimeBAidcjmAyJFsDzq40iru+gBRr0Yb7WnjcZ3V(a)mail.gmail.com<AANLkTimeBAidcjmAyJFsDzq40iru%2BgBRr0Yb7WnjcZ3V(a)mail.gmail.com> > > > Content-Type: text/plain; charset="utf-8" > > On Mon, Sep 6, 2010 at 10:04 AM, Allan McRae <allan(a)archlinux.org> wrote: > > On 07/09/10 00:25, Bryce Gibson wrote: > >> > >> ----- Original message ----- > >>> > >>> On 04/09/10 19:16, J?rgen H?tzel wrote: > >>>> > >>>> Hi Dan, > >>>> > >>>> 2010/9/2 Dan McGee<dan(a)archlinux.org>: > >>>>> > >>>>> This does not remove the MD5 code from our codebase, but it does > >>>>> enable linking against OpenSSL to get their much faster > >>>>> implementation if it is available on whatever platform you are > >>>>> using. At configure-time, we will default to using it if it is > >>>>> available, but this can be easily changed by using the > >>>>> `--with-openssl` or `--without-openssl` arguments to configure. > >>>> > >>>> What about just replacing the current MD5 implementation with the > >>>> OpenSSL implementation? > >>>> > >>>> This would prevent conditional compilation and a direct OpenSSL > >>>> dependency in libalpm. > >>> > >>> Can we do that? ? Openssl is BSD code. > >>> > >>> > >>> Anyway, I have concerns... ? ? Think of an openssl upgrade. ? pacman is > >>> in > >>> SyncFirst and it pulls in all its deps. ? If that pulls in openssl with > a > >>> soname bump, things may get interesting. ? I have not check, but I do > not > >>> think --as-needed saves us there. > >>> > >>> Allan > >>> > >> The licenses that openssl is released under aren't compatible with the > gpl > >> (according to the fsf) because of the advertising clause... So openssl > code > >> can't really be used like that... (Unfortunately) > > > > How does the coreutils md5sum speed compare? ?That is GPL code so could > be > > included directly. ?Though I guess it is now GPL3 being a GNU project... > > Quite a bit slower. Test results (for one platform, please test on > whatever you are running on, it is very machine-dependent) and the > test harness included below, run using ./md5-speed.sh <bigfile> > > Keep in mind that "including directly" more than likely is a drawback. > I wouldn't be surprised if there are assembly routines involved in > both of these codebases which just makes the build process that much > more involved and we have to work it into our code. Not that I think > these routines change much upstream, but it is one more thing to keep > up to date. > > -Dan > > > > dmcgee@dublin /tmp > $ ./md5-speed.sh ~/downloads/Fireworks.amb > path: /home/dmcgee/downloads/Fireworks.amb > md5(/home/dmcgee/downloads/Fireworks.amb) = > 987fef0281e0924977fc8d14f78f4cd4 > Version: i686 > real 0m9.019s > user 0m7.623s > sys 0m1.143s > > path: /home/dmcgee/downloads/Fireworks.amb > md5(/home/dmcgee/downloads/Fireworks.amb) = > 987fef0281e0924977fc8d14f78f4cd4 > Version: atom > real 0m9.082s > user 0m7.736s > sys 0m1.120s > > path: /home/dmcgee/downloads/Fireworks.amb > md5(/home/dmcgee/downloads/Fireworks.amb) = > 987fef0281e0924977fc8d14f78f4cd4 > Version: native > real 0m9.078s > user 0m7.739s > sys 0m1.103s > > 987fef0281e0924977fc8d14f78f4cd4 /home/dmcgee/downloads/Fireworks.amb > Program: md5sum > real 0m8.034s > user 0m6.963s > sys 0m0.870s > > MD5(/home/dmcgee/downloads/Fireworks.amb)= 987fef0281e0924977fc8d14f78f4cd4 > Program: openssl dgst -md5 > real 0m6.511s > user 0m5.356s > sys 0m0.980s >

2 1

[pacman-dev] [GIT] The official pacman repository annotated tag, v3.4.1, created. v3.4.1
by dan＠archlinux.org 05 Sep '10

05 Sep '10

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The annotated tag, v3.4.1 has been created at f02affee8956d51c2f790927f1ab679e9224beb9 (tag) tagging 3739e2c10c7c462859cb06f7fe42778fcaf36a45 (commit) replaces v3.4.0 tagged by Dan McGee on Fri Sep 3 20:01:07 2010 -0500 - Log ----------------------------------------------------------------- First maint release in 3.4.x series -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iEYEABECAAYFAkyBmlsACgkQXC5GoPU6du3IjgCbBVK2mwVdxJzLwP87bWPmyWdW NrAAnApPQKGvYxNcogCnX5k4IAu0SPhA =OR0c -----END PGP SIGNATURE----- Allan McRae (7): makepkg: fallback to sane defaults for library stripping makepkg: revert bash4-ism makepkg: prevent error trap activation in bash-3.2 makepkg: try standard paths for coreutils du makepkg: fix sudo/su calling of pacman makepkg: check tput support before using makepkg: add file to the list of needed utilities Andres P (6): rankmirrors: fix bogus variable assignment rankmirrors: fix bogus pacman configuration parsing rankmirrors: pipe errors to stderr bash_completion: fix bash 3.2 incompatibility makepkg: remove bash4-only parameter expansion in check_sanity PKGBUILD.5: document illegal variable contents Baurzhan Muftakhidinov (2): Small fix to Kazakh translation Small fixes to Kazakh translation Dan McGee (14): Revert disabling of make in doc/ dir by default Handle sync target + ignore properly repo-add: try symlink, then hardlink, then copy for DB file Fix some incorrect asciidoc syntax docs: Add a 'website' target Add two pactests for group and --needed interaction Maintain a list of seen packages when installing a group Mark sync_pkg and sync_target as static functions Fix compile error in certain cases repo-add: create relative DB symlinks Update NEWS for 3.4.1 release Update translation files for 3.4.1 freeze Add dir missing from autoclean.sh 3.4.1 version bump Dave Reisner (2): Always treat PKGLIST as an array. bash_completion: negate expression inside brackets Gaspar Santos (1): Add new European Portuguese translation Jonathan Conder (1): pactest: add shell to fake root environment Jozef Riha (1): Add Slovak translation Mateusz Herych (1): Updates for Polish translations Matthias Gorissen (1): German translation updates Thomas Bächler (1): makepkg: Only check regular files in $srcdir check Tobias Eriksson (1): libalpm Swedish translation update 甘露(Gan Lu) (2): Update Chinese translation to fix gettext positional params Update Chinese translation ----------------------------------------------------------------------- hooks/post-receive -- The official pacman repository

1 0