- Pacman-dev - lists.archlinux.org

[pacman-dev] [PATCH] libalpm: fix double free when importing key
by morganamilo 03 Jun '21

03 Jun '21

Comit 5151de30 tried to fix leaking memory when importing a key. However key_search_keyserver() writes to the key passed in, making the original uid and fingerprint unreachable, causing the new uid and fingerprint to double free. Fixes FS#71107 --- lib/libalpm/signing.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/libalpm/signing.c b/lib/libalpm/signing.c index b1b50bc8..a7be3a1a 100644 --- a/lib/libalpm/signing.c +++ b/lib/libalpm/signing.c @@ -513,6 +513,10 @@ int _alpm_key_import(alpm_handle_t *handle, const char *uid, const char *fpr) .key = &fetch_key }; QUESTION(handle, &question); + + free(fetch_key.uid); + free(fetch_key.fingerprint); + if(question.import) { /* Try to import the key from a WKD first */ if(email_from_uid(uid, &email) == 0) { @@ -538,9 +542,6 @@ int _alpm_key_import(alpm_handle_t *handle, const char *uid, const char *fpr) } } gpgme_key_unref(fetch_key.data); - free(fetch_key.uid); - free(fetch_key.fingerprint); - return ret; } -- 2.31.1

1 0

Re: [pacman-dev] "pacman --arch=i686 -Syu" results in "error: GPGME error: No data"
by stratus＠tuta.io 03 Jun '21

03 Jun '21

$ sudo pacman --arch=i686 -Syu :: Synchronising package databases... system is up to date world is up to date galaxy is up to date lib32 is up to date universe.db failed to download error: failed retrieving file 'system.db' from ftp.cc.uoc.gr : The requested URL returned error: 404 error: failed retrieving file 'system.db' from mirror.clarkson.edu : The requested URL returned error: 404 error: failed retrieving file 'system.db' from ftp.sh.cvut.cz : The requested URL returned error: 404 error: failed retrieving file 'system.db' from artix.wheaton.edu : The requested URL returned error: 404 error: failed retrieving file 'system.db' from mirrors.tuna.tsinghua.edu.cn : The requested URL returned error: 404 error: failed retrieving file 'world.db' from ftp.cc.uoc.gr : The requested URL returned error: 404 error: failed retrieving file 'world.db' from mirror.clarkson.edu : The requested URL returned error: 404 error: failed retrieving file 'world.db' from ftp.sh.cvut.cz : The requested URL returned error: 404 error: failed retrieving file 'world.db' from artix.wheaton.edu : The requested URL returned error: 404 error: failed retrieving file 'world.db' from mirrors.tuna.tsinghua.edu.cn : The requested URL returned error: 404 error: failed retrieving file 'galaxy.db' from ftp.cc.uoc.gr : The requested URL returned error: 404 warning: too many errors from ftp.cc.uoc.gr, skipping for the remainder of this transaction error: failed retrieving file 'galaxy.db' from mirror.clarkson.edu : The requested URL returned error: 404 warning: too many errors from mirror.clarkson.edu, skipping for the remainder of this transaction error: failed retrieving file 'galaxy.db' from ftp.sh.cvut.cz : The requested URL returned error: 404 warning: too many errors from ftp.sh.cvut.cz, skipping for the remainder of this transaction error: failed retrieving file 'galaxy.db' from artix.wheaton.edu : The requested URL returned error: 404 warning: too many errors from artix.wheaton.edu, skipping for the remainder of this transaction error: failed retrieving file 'galaxy.db' from mirrors.tuna.tsinghua.edu.cn : The requested URL returned error: 404 warning: too many errors from mirrors.tuna.tsinghua.edu.cn, skipping for the remainder of this transaction error: failed retrieving file 'universe.db' from universe.artixlinux.org : The requested URL returned error: 404 error: failed to synchronize all databases (failed to retrieve some files) $ sudo pacman -Syu error: GPGME error: No data error: GPGME error: No data error: GPGME error: No data error: GPGME error: No data :: Synchronising package databases... system 259.6 KiB 193 KiB/s 00:01 [--------------------------------------------------------] 100% world 1790.7 KiB 654 KiB/s 00:03 [--------------------------------------------------------] 100% galaxy 1734.6 KiB 544 KiB/s 00:03 [--------------------------------------------------------] 100% lib32 139.4 KiB 236 KiB/s 00:01 [--------------------------------------------------------] 100% universe 63.2 KiB 97.7 KiB/s 00:01 [--------------------------------------------------------] 100% extra 1550.9 KiB 818 KiB/s 00:02 [--------------------------------------------------------] 100% community 5.5 MiB 747 KiB/s 00:08 [--------------------------------------------------------] 100% multilib is up to date error: GPGME error: No data error: GPGME error: No data error: GPGME error: No data error: GPGME error: No data error: failed to synchronize all databases (unexpected error) $ sudo rm /var/lib/pacman/sync/* $ sudo pacman-key --init $ sudo pacman-key --populate archlinux artix ==> Appending keys from archlinux.gpg... ==> Appending keys from artix.gpg... ==> Locally signing trusted keys in keyring... ==> Importing owner trust values... ==> Disabling revoked keys in keyring... ==> Updating trust database... gpg: next trustdb check due at 2021-08-02 $ sudo pacman -Syy :: Synchronising package databases... system 259.6 KiB 263 KiB/s 00:01 [--------------------------------------------------------] 100% world 1790.7 KiB 482 KiB/s 00:04 [--------------------------------------------------------] 100% galaxy 1734.6 KiB 551 KiB/s 00:03 [--------------------------------------------------------] 100% lib32 139.4 KiB 230 KiB/s 00:01 [--------------------------------------------------------] 100% universe 63.2 KiB 99.3 KiB/s 00:01 [--------------------------------------------------------] 100% extra 1550.9 KiB 511 KiB/s 00:03 [--------------------------------------------------------] 100% community 5.5 MiB 675 KiB/s 00:08 [--------------------------------------------------------] 100% multilib 150.4 KiB 940 KiB/s 00:00 [--------------------------------------------------------] 100% Then it is back to normal. It looks like something specific to the Artix repos, community and extra are Arch Linux repos: Normal working situation: /var/lib/pacman/sync$ ls -lh total 12M -rw-r--r-- 1 root root 5.6M Jun 3 09:24 community.db -rw-r--r-- 1 root root 1.6M Jun 3 09:23 extra.db -rw-r--r-- 1 root root 1.7M Jun 2 20:51 galaxy.db -rw-r--r-- 1 root root 140K May 31 11:16 lib32.db -rw-r--r-- 1 root root 151K Jun 2 08:56 multilib.db -rw-r--r-- 1 root root 260K Jun 1 21:47 system.db -rw-r--r-- 1 root root 64K Jun 3 07:41 universe.db -rw-r--r-- 1 root root 1.8M Jun 2 19:59 world.db Faulty nonworking situation: /var/lib/pacman/sync$ ls -lh total 12M -rw-r--r-- 1 root root 5.6M Jun 3 09:24 community.db -rw-r--r-- 1 root root 1.6M Jun 3 09:23 extra.db -rw-r--r-- 1 root root 1.7M Jun 2 20:51 galaxy.db -rw-r--r-- 1 root root 114 Mar 1 08:11 galaxy.db.sig -rw-r--r-- 1 root root 140K May 31 11:16 lib32.db -rw-r--r-- 1 root root 114 Mar 1 08:11 lib32.db.sig -rw-r--r-- 1 root root 151K Jun 2 08:56 multilib.db -rw-r--r-- 1 root root 260K Jun 1 21:47 system.db -rw-r--r-- 1 root root 114 Mar 1 08:11 system.db.sig -rw-r--r-- 1 root root 64K Jun 3 07:41 universe.db -rw-r--r-- 1 root root 1.8M Jun 2 19:59 world.db -rw-r--r-- 1 root root 114 Mar 1 08:11 world.db.sig Also I can omit the pacman-key commands above to restore normal operation. Perhaps the db.sig things are obsolete and shouldn't be in the mirrors? But they don't seem to come from there anyway: https://ftp.cc.uoc.gr/mirrors/linux/artixlinux/galaxy/os/x86_64/ Or could it be that one of the Artix mirrors really has an old outdated os/i686 directory? I think there was some late 32 bit support after Arch had dropped it. Universe is a fairly new Artix repo and doesn't have a db.sig file in the error situation.

2 1

[pacman-dev] [PATCH v2] Print relevant information about file conflicts or corrupted packages to stderr instead of stdout.
by Oskar Roesler (bionade24) 03 Jun '21

03 Jun '21

Now using fprintf() instead of pm_printf() to prevent "ERROR:" prefix, changes in lib/libalpm/sync.c are removed. Still wonder why the error message in src/pacman/sync and lib/libalpm/sync.c are redundant. Could someone please explain it to me? Signed-off-by: Oskar Roesler (bionade24) <o.roesler(a)oscloud.info> --- src/pacman/sync.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/pacman/sync.c b/src/pacman/sync.c index b6da1a36..6558d4b4 100644 --- a/src/pacman/sync.c +++ b/src/pacman/sync.c @@ -836,15 +836,15 @@ int sync_prepare_execute(void) alpm_fileconflict_t *conflict = i->data; switch(conflict->type) { case ALPM_FILECONFLICT_TARGET: - printf(_("%s exists in both '%s' and '%s'\n"), + fprintf(stderr, _("%s exists in both '%s' and '%s'\n"), conflict->file, conflict->target, conflict->ctarget); break; case ALPM_FILECONFLICT_FILESYSTEM: if(conflict->ctarget[0]) { - printf(_("%s: %s exists in filesystem (owned by %s)\n"), + fprintf(stderr, _("%s: %s exists in filesystem (owned by %s)\n"), conflict->target, conflict->file, conflict->ctarget); } else { - printf(_("%s: %s exists in filesystem\n"), + fprintf(stderr, _("%s: %s exists in filesystem\n"), conflict->target, conflict->file); } break; @@ -857,7 +857,7 @@ int sync_prepare_execute(void) case ALPM_ERR_PKG_INVALID_SIG: for(i = data; i; i = alpm_list_next(i)) { char *filename = i->data; - printf(_("%s is invalid or corrupted\n"), filename); + fprintf(stderr, _("%s is invalid or corrupted\n"), filename); free(filename); } break; -- 2.31.1

1 0

[pacman-dev] [PATCH] Print relevant information about file conflicts or corrupted packages to stderr instead of stdout.
by Oskar Roesler (bionade24) 03 Jun '21

03 Jun '21

Signed-off-by: Oskar Roesler (bionade24) <o.roesler(a)oscloud.info> --- lib/libalpm/conflict.c | 4 ++-- src/pacman/sync.c | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/libalpm/conflict.c b/lib/libalpm/conflict.c index b471bf21..56d24a37 100644 --- a/lib/libalpm/conflict.c +++ b/lib/libalpm/conflict.c @@ -456,10 +456,10 @@ alpm_list_t *_alpm_db_find_fileconflicts(alpm_handle_t *handle, * conflicts as the path from p1 is returned */ if(_alpm_can_overwrite_file(handle, filename, path) && alpm_filelist_contains(p2_files, filename)) { - _alpm_log(handle, ALPM_LOG_DEBUG, + _alpm_log(handle, ALPM_LOG_ERROR, "%s exists in both '%s' and '%s'\n", filename, p1->name, p2->name); - _alpm_log(handle, ALPM_LOG_DEBUG, + _alpm_log(handle, ALPM_LOG_ERROR, "file-file conflict being forced\n"); continue; } diff --git a/src/pacman/sync.c b/src/pacman/sync.c index b6da1a36..b0507d84 100644 --- a/src/pacman/sync.c +++ b/src/pacman/sync.c @@ -836,15 +836,15 @@ int sync_prepare_execute(void) alpm_fileconflict_t *conflict = i->data; switch(conflict->type) { case ALPM_FILECONFLICT_TARGET: - printf(_("%s exists in both '%s' and '%s'\n"), + pm_printf(ALPM_LOG_ERROR, _("%s exists in both '%s' and '%s'\n"), conflict->file, conflict->target, conflict->ctarget); break; case ALPM_FILECONFLICT_FILESYSTEM: if(conflict->ctarget[0]) { - printf(_("%s: %s exists in filesystem (owned by %s)\n"), + pm_printf(ALPM_LOG_ERROR, _("%s: %s exists in filesystem (owned by %s)\n"), conflict->target, conflict->file, conflict->ctarget); } else { - printf(_("%s: %s exists in filesystem\n"), + pm_printf(ALPM_LOG_ERROR, _("%s: %s exists in filesystem\n"), conflict->target, conflict->file); } break; @@ -857,7 +857,7 @@ int sync_prepare_execute(void) case ALPM_ERR_PKG_INVALID_SIG: for(i = data; i; i = alpm_list_next(i)) { char *filename = i->data; - printf(_("%s is invalid or corrupted\n"), filename); + pm_printf(ALPM_LOG_ERROR, _("%s is invalid or corrupted\n"), filename); free(filename); } break; -- 2.31.1

3 2

[pacman-dev] [PATCH 1/2] libalpm: take alpm_trans_t out of the public API
by morganamilo 03 Jun '21

03 Jun '21

this type is only used internally by alpm --- lib/libalpm/alpm.h | 6 ------ lib/libalpm/handle.h | 1 + lib/libalpm/trans.h | 4 ++-- 3 files changed, 3 insertions(+), 8 deletions(-) diff --git a/lib/libalpm/alpm.h b/lib/libalpm/alpm.h index 101d686b..1413263b 100644 --- a/lib/libalpm/alpm.h +++ b/lib/libalpm/alpm.h @@ -113,12 +113,6 @@ typedef struct __alpm_db_t alpm_db_t; */ typedef struct __alpm_pkg_t alpm_pkg_t; -/** Transaction structure used internally by libalpm - * @ingroup libalpm_trans - * */ -typedef struct __alpm_trans_t alpm_trans_t; - - /** The time type used by libalpm. Represents a unix time stamp * @ingroup libalpm_misc */ typedef int64_t alpm_time_t; diff --git a/lib/libalpm/handle.h b/lib/libalpm/handle.h index b1526c67..f2602057 100644 --- a/lib/libalpm/handle.h +++ b/lib/libalpm/handle.h @@ -26,6 +26,7 @@ #include "alpm_list.h" #include "alpm.h" +#include "trans.h" #ifdef HAVE_LIBCURL #include <curl/curl.h> diff --git a/lib/libalpm/trans.h b/lib/libalpm/trans.h index 9e7fcbd7..d2ec0223 100644 --- a/lib/libalpm/trans.h +++ b/lib/libalpm/trans.h @@ -36,7 +36,7 @@ typedef enum _alpm_transstate_t { } alpm_transstate_t; /* Transaction */ -struct __alpm_trans_t { +typedef struct _alpm_trans_t { /* bitfield of alpm_transflag_t flags */ int flags; alpm_transstate_t state; @@ -44,7 +44,7 @@ struct __alpm_trans_t { alpm_list_t *add; /* list of (alpm_pkg_t *) */ alpm_list_t *remove; /* list of (alpm_pkg_t *) */ alpm_list_t *skip_remove; /* list of (char *) */ -}; +} alpm_trans_t; void _alpm_trans_free(alpm_trans_t *trans); /* flags is a bitfield of alpm_transflag_t flags */ -- 2.31.1

2 4

[pacman-dev] [PATCH v2] docs: Update submission to lists.archlinux.org
by Morten Linderud 03 Jun '21

03 Jun '21

From: Morten Linderud <morten(a)linderud.pw> Currently some overly aggressive spam filter is going to complain if there is a mismatch between the To and Reply-To header. Since Arch Linux has changed the mailing list domains this changes the documentation to reflect the change. https://archlinux.org/news/arch-linux-mailing-list-id-changes/ Signed-off-by: Morten Linderud <morten(a)linderud.pw> --- doc/index.asciidoc | 4 ++-- doc/translation-help.asciidoc | 4 ++-- lib/libalpm/po/meson.build | 2 +- scripts/po/meson.build | 2 +- src/pacman/po/meson.build | 2 +- 5 files changed, 7 insertions(+), 7 deletions(-) diff --git a/doc/index.asciidoc b/doc/index.asciidoc index 87f07dda..7200bc18 100644 --- a/doc/index.asciidoc +++ b/doc/index.asciidoc @@ -252,7 +252,7 @@ Utilities available: Bugs ---- If you find bugs (which is quite likely), please email them to the pacman-dev -mailing last at mailto:pacman-dev@archlinux.org[] with specific information +mailing last at mailto:pacman-dev@lists.archlinux.org[] with specific information such as your command-line, the nature of the bug, and even the package database if it helps. @@ -263,6 +263,6 @@ bugs under the Pacman project. Copyright --------- pacman is Copyright (C) 2006-2021 Pacman Development Team -<pacman-dev(a)archlinux.org> and Copyright (C) 2002-2006 Judd Vinet +<pacman-dev(a)lists.archlinux.org> and Copyright (C) 2002-2006 Judd Vinet <jvinet(a)zeroflux.org> and is licensed through the GNU General Public License, version 2 or later. diff --git a/doc/translation-help.asciidoc b/doc/translation-help.asciidoc index 5a67a2d6..fe020e92 100644 --- a/doc/translation-help.asciidoc +++ b/doc/translation-help.asciidoc @@ -55,7 +55,7 @@ Pre-release Updates ~~~~~~~~~~~~~~~~~~~ A week or two before each release, the codebase will go into a string freeze -and an email will be sent to the mailto:pacman-dev@archlinux.org[pacman-dev] +and an email will be sent to the mailto:pacman-dev@lists.archlinux.org[pacman-dev] mailing list asking for translations. This email will have a prefix of *[translation]* for anyone looking to set up an email filter. @@ -150,4 +150,4 @@ There are currently no efforts underway to include translated manual pages in the pacman codebase. However, this is not to say translations are unwelcome. If someone has experience with i18n man pages and how to best include them with our source, please contact the pacman-dev mailing list at -mailto:pacman-dev@archlinux.org[]. +mailto:pacman-dev@lists.archlinux.org[]. diff --git a/lib/libalpm/po/meson.build b/lib/libalpm/po/meson.build index cec28a15..61db9ed9 100644 --- a/lib/libalpm/po/meson.build +++ b/lib/libalpm/po/meson.build @@ -3,7 +3,7 @@ i18n.gettext( args : [ '--directory=@0@'.format(meson.current_source_dir()), '--msgid-bugs-address=http://bugs.archlinux.org/index.php?project=3', - '--copyright-holder="Pacman Development Team <pacman-dev(a)archlinux.org>"', + '--copyright-holder="Pacman Development Team <pacman-dev(a)lists.archlinux.org>"', '--language', 'c', '--keyword=_', diff --git a/scripts/po/meson.build b/scripts/po/meson.build index d8b8c51c..874b51dc 100644 --- a/scripts/po/meson.build +++ b/scripts/po/meson.build @@ -3,7 +3,7 @@ i18n.gettext( args : [ '--directory=@0@'.format(meson.current_source_dir()), '--msgid-bugs-address=http://bugs.archlinux.org/index.php?project=3', - '--copyright-holder="Pacman Development Team <pacman-dev(a)archlinux.org>"', + '--copyright-holder="Pacman Development Team <pacman-dev(a)lists.archlinux.org>"', '--language', 'shell', '--keyword=_', diff --git a/src/pacman/po/meson.build b/src/pacman/po/meson.build index eb45fa1c..78c0230f 100644 --- a/src/pacman/po/meson.build +++ b/src/pacman/po/meson.build @@ -3,7 +3,7 @@ i18n.gettext( args : [ '--directory=@0@'.format(meson.current_source_dir()), '--msgid-bugs-address=http://bugs.archlinux.org/index.php?project=3', - '--copyright-holder="Pacman Development Team <pacman-dev(a)archlinux.org>"', + '--copyright-holder="Pacman Development Team <pacman-dev(a)lists.archlinux.org>"', '--language', 'c', '--keyword=_', -- 2.31.1

3 2

[pacman-dev] [PATCH] repo-add: add --include-sigs option
by Allan McRae 03 Jun '21

03 Jun '21

Pacman now downloads the signature files for all packages when present in a repository. That makes distributing signatures within repository databases redundant and costly. Do not distribute the package signature files within the repo databases by default and add an --include-sigs to revert to the old behaviour. Signed-off-by: Allan McRae <allan(a)archlinux.org> --- Resubmit of this patch now we are post 6.0. pacman-6.1 is likely far enough away that there will be plenty of transition time. doc/repo-add.8.asciidoc | 2 ++ scripts/repo-add.sh.in | 6 +++++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/doc/repo-add.8.asciidoc b/doc/repo-add.8.asciidoc index 8de4485b..9b903ab1 100644 --- a/doc/repo-add.8.asciidoc +++ b/doc/repo-add.8.asciidoc @@ -70,6 +70,8 @@ repo-add Options Remove old package files from the disk when updating their entry in the database. +*\--include-sigs*:: + Include package PGP signatures in the repository database (if available) Example ------- diff --git a/scripts/repo-add.sh.in b/scripts/repo-add.sh.in index d3938396..ac501b1a 100644 --- a/scripts/repo-add.sh.in +++ b/scripts/repo-add.sh.in @@ -42,6 +42,7 @@ LOCKFILE= CLEAN_LOCK=0 USE_COLOR='y' PREVENT_DOWNGRADE=0 +INCLUDE_SIGS=0 # Import libmakepkg source "$LIBRARY"/util/compress.sh @@ -260,7 +261,7 @@ db_write_entry() { fi # compute base64'd PGP signature - if [[ -f "$pkgfile.sig" ]]; then + if (( INCLUDE_SIGS )) && [[ -f "$pkgfile.sig" ]]; then if grep -q 'BEGIN PGP SIGNATURE' "$pkgfile.sig"; then error "$(gettext "Cannot use armored signatures for packages: %s")" "$pkgfile.sig" return 1 @@ -622,6 +623,9 @@ while (( $# )); do -p|--prevent-downgrade) PREVENT_DOWNGRADE=1 ;; + --include-sigs) + INCLUDE_SIGS=1 + ;; *) args+=("$1") ;; -- 2.31.1

1 0

[pacman-dev] [PATCH] libalpm: add alpm_dbs_get_pkg
by morganamilo 03 Jun '21

03 Jun '21

This is a common function that pretty much every front end ends up implementing, searching for a package in the syncdbs. May as well add it here for every one to use. diff --git a/lib/libalpm/alpm.h b/lib/libalpm/alpm.h index a5f4a6ae..5fa34faa 100644 --- a/lib/libalpm/alpm.h +++ b/lib/libalpm/alpm.h @@ -1381,6 +1381,17 @@ int alpm_db_update(alpm_handle_t *handle, alpm_list_t *dbs, int force); */ alpm_pkg_t *alpm_db_get_pkg(alpm_db_t *db, const char *name); +/** Get a package entry from a list of databases. + * This is similar to \link alpm_dbs_get_pkg() get pkg \endlink except it will + * look through a list of databases instead of just one. The first matching + * package found will be returned. + * @param handle the context handle + * @param dbs list of databases to search through + * @param name name of the package + * @return the package entry on success, NULL on error + */ +alpm_pkg_t *alpm_dbs_get_pkg(alpm_handle_t *handle, alpm_list_t *dbs, const char *name); + /** Get the package cache of a package database. * This is a list of all packages the db contains. * @param db pointer to the package database to get the package from diff --git a/lib/libalpm/db.c b/lib/libalpm/db.c index b8d1b157..c3cfb13a 100644 --- a/lib/libalpm/db.c +++ b/lib/libalpm/db.c @@ -257,6 +257,16 @@ alpm_list_t SYMEXPORT *alpm_db_get_pkgcache(alpm_db_t *db) return _alpm_db_get_pkgcache(db); } +alpm_pkg_t SYMEXPORT *alpm_dbs_get_pkg(alpm_handle_t *handle, alpm_list_t *dbs, const char *name) +{ + CHECK_HANDLE(handle, return NULL); + ASSERT(name != NULL && strlen(name) != 0, + RET_ERR(handle, ALPM_ERR_WRONG_ARGS, NULL)); + alpm_pkg_t *pkg = _alpm_dbs_get_pkgfromcache(dbs, name); + ASSERT(pkg, RET_ERR(handle, ALPM_ERR_PKG_NOT_FOUND, NULL)); + return pkg; +} + alpm_group_t SYMEXPORT *alpm_db_get_group(alpm_db_t *db, const char *name) { ASSERT(db != NULL, return NULL); @@ -363,6 +373,16 @@ const char *_alpm_db_path(alpm_db_t *db) return db->_path; } +alpm_pkg_t *_alpm_dbs_get_pkgfromcache(alpm_list_t *dbs, const char *name) +{ + alpm_pkg_t *pkg = NULL; + for(alpm_list_t *i = dbs; !pkg && i; i = i->next) { + alpm_db_t *db = i->data; + pkg = _alpm_db_get_pkgfromcache(db, name); + } + return pkg; +} + int _alpm_db_cmp(const void *d1, const void *d2) { const alpm_db_t *db1 = d1; diff --git a/lib/libalpm/db.h b/lib/libalpm/db.h index 92c69ba7..dfb3212c 100644 --- a/lib/libalpm/db.h +++ b/lib/libalpm/db.h @@ -108,6 +108,7 @@ int _alpm_db_remove_pkgfromcache(alpm_db_t *db, alpm_pkg_t *pkg); alpm_pkghash_t *_alpm_db_get_pkgcache_hash(alpm_db_t *db); alpm_list_t *_alpm_db_get_pkgcache(alpm_db_t *db); alpm_pkg_t *_alpm_db_get_pkgfromcache(alpm_db_t *db, const char *target); +alpm_pkg_t *_alpm_dbs_get_pkgfromcache(alpm_list_t *dbs, const char *name); /* groups */ alpm_list_t *_alpm_db_get_groupcache(alpm_db_t *db); alpm_group_t *_alpm_db_get_groupfromcache(alpm_db_t *db, const char *target); diff --git a/lib/libalpm/sync.c b/lib/libalpm/sync.c index 7ef558c4..d934de73 100644 --- a/lib/libalpm/sync.c +++ b/lib/libalpm/sync.c @@ -55,16 +55,9 @@ struct keyinfo_t { alpm_pkg_t SYMEXPORT *alpm_sync_get_new_version(alpm_pkg_t *pkg, alpm_list_t *dbs_sync) { - alpm_list_t *i; - alpm_pkg_t *spkg = NULL; - ASSERT(pkg != NULL, return NULL); pkg->handle->pm_errno = ALPM_ERR_OK; - - for(i = dbs_sync; !spkg && i; i = i->next) { - alpm_db_t *db = i->data; - spkg = _alpm_db_get_pkgfromcache(db, pkg->name); - } + alpm_pkg_t *spkg = _alpm_dbs_get_pkgfromcache(dbs_sync, pkg->name); if(spkg == NULL) { _alpm_log(pkg->handle, ALPM_LOG_DEBUG, "'%s' not found in sync db => no upgrade\n", diff --git a/src/pacman/query.c b/src/pacman/query.c index e3e7d844..2fc2afd1 100644 --- a/src/pacman/query.c +++ b/src/pacman/query.c @@ -247,15 +247,9 @@ static int query_search(alpm_list_t *targets) static unsigned short pkg_get_locality(alpm_pkg_t *pkg) { const char *pkgname = alpm_pkg_get_name(pkg); - alpm_list_t *j; alpm_list_t *sync_dbs = alpm_get_syncdbs(config->handle); - - for(j = sync_dbs; j; j = alpm_list_next(j)) { - if(alpm_db_get_pkg(j->data, pkgname)) { - return PKG_LOCALITY_NATIVE; - } - } - return PKG_LOCALITY_FOREIGN; + alpm_pkg_t *repo_pkg = alpm_dbs_get_pkg(config->handle, sync_dbs, pkgname); + return repo_pkg ? PKG_LOCALITY_NATIVE : PKG_LOCALITY_FOREIGN; } static int is_unrequired(alpm_pkg_t *pkg, unsigned short level) -- 2.31.1

1 0

[pacman-dev] "pacman --arch=i686 -Syu" results in "error: GPGME error: No data"
by stratus＠tuta.io 03 Jun '21

03 Jun '21

# pacman --arch=i686 -Syu This is clearly not a sensible command, but trying it just to see what happened when using the --arch option out resulted in database corruption, then it was impossible to upgrade and pacman would not function: error: GPGME error: No data error: failed to synchronize all databases (unexpected error) until I did: # rm /var/lib/pacman/sync/* # pacman-key --init # pacman-key --populate archlinux artix # pacman -Syy I tried it again and it did the same thing, and thought you might be interested.

3 2

[pacman-dev] [PATCH 0/1] libalpm: fix resuming after HTTP error
by Hung-I Wang 02 Jun '21

02 Jun '21

Hi, there. When downloading packages, the libalpm may save a body of a unsuccessful HTTP response (e.g. 404). The saved part will then be treated as a partially download package, from where the download will be resumed, resulting in a corrupted package. Steps to reproduce: 1. Prepend a invalid mirror to mirrorlist, say http://example.com/$repo/os/$arch 2. Pick any package, say inkscape 3. (Re-)Install the chosen package with `pacman -S` 4. Pacman gets a HTTP 404 error when trying the newly added "mirror", saving its body as the partially downloaded package 5. Pacman retries the subsequent real mirrors, resuming its download 6. At last, pacman complains with "File ... corrupted (invalid or corrupted package (PGP signature))" This patch fixs the problem by letting curl fails on HTTP error, preventing it from accepting such an invalid HTTP body. Regards, Hung-I Wang --- Hung-I Wang (1): libalpm: fix resuming after HTTP error lib/libalpm/dload.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) -- 2.31.1

3 4