- Pacman-dev - lists.archlinux.org

[pacman-dev] Problem compiling pacman 3.0.6-2
by Karolina 18 Dec '07

18 Dec '07

It appears that pacman needs /usr/lib/libattr.la but the package "attr" has options=('!libtool') and does not provide that file. Setting options=('libtool') for the package "attr" solves the problem, but I don't know if that is the correct solution. Karolina

3 4

[pacman-dev] foo<2.0 dependency
by Nagy Gabor 17 Dec '07

17 Dec '07

Hi! First I refer to this old mail: http://www.archlinux.org/pipermail/pacman-dev/2007-July/008701.html (s/depend/requiredby in that subject <- this 'audacious-plugins depends on audacious logic' is so confusing to me;-) So how can we "predict" the future? A possible solution (from crazy@FW) we use foo<2.0 dependency of bar, which indicates that only foo 1.x dependency is expected to work with bar. For example, then the packager can add both foo>=1.3 and foo<1.4 dependencies to his bar 1.3 package (foo 1.4 may work, but probably won't). And this will prevent users from upgrading foo 1.3 to foo 1.4 without dependency break (see the confusing audacious example above: audacious-plugins 1.3.5 is not expected to work with audacious-player 1.4.x). So my definition of foo<2.0: foo<=2.0 holds, but foo=2.0 doesn't. Bye, ngaba PS: I don't know whether foo>1.0 would be useful or not, maybe with conflicts only (<- predicted conflict ;-), but if we implemented '<', then probably we would implement '>' to enjoy the symmetry.

2 1

[pacman-dev] Package name and version check
by Nagy Gabor 17 Dec '07

17 Dec '07

Hi! I refer to this thread: http://www.archlinux.org/pipermail/pacman-dev/2007-November/010252.html Well, I agree with Dan and Aaron, quote: "Maybe I want my packages just named pkgname.lol". However, I don't see the clear rules, where (pkgname,pkgver) comes from in case of repos. I would like make a little comment here: Packages in sync (and local) dbs are identified by their directory names, not by %NAME% and %VERSION% in desc (reason: speed-up): see line 220 in be_files.c: if(_alpm_db_splitname(ent->d_name, pkg->name, pkg->version) != 0)... So we should make sure, that directory name contains the valid %NAME% and %VERSION% (or %NAME% and %VERSION% is not needed in desc) And of course %FILENAME% should point to a package with the correct %NAME% and %VERSION% <- we may want to check the .PKGINFO content of the (downloaded) pointed file, not the filename itself. However, I'm not sure if this is needed: then we should also check %DEPENDS%, %PROVIDES% and other fields... (checkdeps might have been fooled for example) Bye

3 2

[pacman-dev] [PATCH] Updated Italian Translation for pacman 3.1
by Giovanni Scafora 16 Dec '07

16 Dec '07

Hi, here's an updated translation to fix 1 fuzzy translation and some improvements. Thanks. -- Giovanni Scafora Arch Linux Trusted User (voidnull) http://www.archlinux.org linuxmania(a)gmail.com

1 0

Re: [pacman-dev] [arch-general] Package group xorg-video-drivers: intel conflict
by Xavier 15 Dec '07

15 Dec '07

On Sat, Dec 08, 2007 at 10:16:19PM +0100, Michael Towers wrote: > Aaron Griffin wrote: >> On Dec 8, 2007 11:04 AM, Michael Towers <gradgrind(a)online.de> wrote: >>> Since the addition of xf86-video-intel it has become impossible to >>> install the xorg-video-drivers group via the group name (because of the >>> conflict with xf86-video-i810). >>> >>> I guess there is no guideline outlawing this - I suppose something like >>> this could, theoretically, happen more often. But it is a bit annoying >>> when doing installations which are supposed to run on various machines. >>> >>> I don't want to make a request or anything here - I don't know what I >>> could ask for. I just thought I'd point it out. >> >> Hmmm, I'd say in cases like this we pick one that we prefer, and keep >> that in the group. /me shrugs >> >> Maybe FR that regarding these two drivers and we can see how Alex >> feels about it? >> >> > > http://bugs.archlinux.org/task/8874 > > Why can't we do pacman -S xorg-video-drivers --ignore xf86-video-i810 ? Though, it's probably a bad idea to put conflicting packages in the same group in the first place, but still.. Suppose "target" is part of "group", and target is in IgnorePkg, it might make sense that : * pacman -S group doesn't install target * pacman -S target installs target (because explictly asked) Anyway, here is a sample session, how I like them (it may have been mentioned already, but I don't remember where) : > sudo pacman -S xorg-video-drivers :: group xorg-video-drivers: xf86-video-intel :: Install whole content? [Y/n] :: group xorg-video-drivers: xf86-video-amd xf86-video-apm xf86-video-ark xf86-video-ati xf86-video-chips xf86-video-cirrus xf86-video-dummy xf86-video-fbdev xf86-video-glint xf86-video-i128 xf86-video-i740 xf86-video-i810 xf86-video-imstt xf86-video-intel xf86-video-mga xf86-video-neomagic xf86-video-nv xf86-video-radeonhd xf86-video-rendition xf86-video-s3 xf86-video-s3virge xf86-video-savage xf86-video-siliconmotion xf86-video-sis xf86-video-sisusb xf86-video-tdfx xf86-video-trident xf86-video-tseng xf86-video-unichrome xf86-video-v4l xf86-video-vesa xf86-video-vga xf86-video-via xf86-video-vmware xf86-video-voodoo :: Install whole content? [Y/n] warning: xf86-video-intel-2.1.1-3 is up to date -- reinstalling warning: xf86-video-vesa-1.3.0-5 is up to date -- reinstalling resolving dependencies... looking for inter-conflicts... error: unresolvable package conflicts detected error: failed to prepare transaction (conflicting dependencies) :: xf86-video-intel: conflicts with xf86-video-i810 Ok, xf86-video-i810 is not a conflict, so we won't ask the whole content next time. > sudo pacman -S xorg-video-drivers :: group xorg-video-drivers: xf86-video-intel :: Install whole content? [Y/n] :: group xorg-video-drivers: xf86-video-amd xf86-video-apm xf86-video-ark xf86-video-ati xf86-video-chips xf86-video-cirrus xf86-video-dummy xf86-video-fbdev xf86-video-glint xf86-video-i128 xf86-video-i740 xf86-video-i810 xf86-video-imstt xf86-video-intel xf86-video-mga xf86-video-neomagic xf86-video-nv xf86-video-radeonhd xf86-video-rendition xf86-video-s3 xf86-video-s3virge xf86-video-savage xf86-video-siliconmotion xf86-video-sis xf86-video-sisusb xf86-video-tdfx xf86-video-trident xf86-video-tseng xf86-video-unichrome xf86-video-v4l xf86-video-vesa xf86-video-vga xf86-video-via xf86-video-vmware xf86-video-voodoo :: Install whole content? [Y/n] n :: Install xf86-video-amd from group xorg-video-drivers? [Y/n] :: Install xf86-video-apm from group xorg-video-drivers? [Y/n] :: Install xf86-video-ark from group xorg-video-drivers? [Y/n] :: Install xf86-video-ati from group xorg-video-drivers? [Y/n] :: Install xf86-video-chips from group xorg-video-drivers? [Y/n] :: Install xf86-video-cirrus from group xorg-video-drivers? [Y/n] :: Install xf86-video-dummy from group xorg-video-drivers? [Y/n] :: Install xf86-video-fbdev from group xorg-video-drivers? [Y/n] :: Install xf86-video-glint from group xorg-video-drivers? [Y/n] :: Install xf86-video-i128 from group xorg-video-drivers? [Y/n] :: Install xf86-video-i740 from group xorg-video-drivers? [Y/n] :: Install xf86-video-i810 from group xorg-video-drivers? [Y/n] n :: Install xf86-video-imstt from group xorg-video-drivers? [Y/n] :: Install xf86-video-intel from group xorg-video-drivers? [Y/n] :: Install xf86-video-mga from group xorg-video-drivers? [Y/n] :: Install xf86-video-neomagic from group xorg-video-drivers? [Y/n] :: Install xf86-video-nv from group xorg-video-drivers? [Y/n] :: Install xf86-video-radeonhd from group xorg-video-drivers? [Y/n] :: Install xf86-video-rendition from group xorg-video-drivers? [Y/n] :: Install xf86-video-s3 from group xorg-video-drivers? [Y/n] :: Install xf86-video-s3virge from group xorg-video-drivers? [Y/n] :: Install xf86-video-savage from group xorg-video-drivers? [Y/n] :: Install xf86-video-siliconmotion from group xorg-video-drivers? [Y/n] :: Install xf86-video-sis from group xorg-video-drivers? [Y/n] :: Install xf86-video-sisusb from group xorg-video-drivers? [Y/n] :: Install xf86-video-tdfx from group xorg-video-drivers? [Y/n] :: Install xf86-video-trident from group xorg-video-drivers? [Y/n] :: Install xf86-video-tseng from group xorg-video-drivers? [Y/n] :: Install xf86-video-unichrome from group xorg-video-drivers? [Y/n] :: Install xf86-video-v4l from group xorg-video-drivers? [Y/n] :: Install xf86-video-vesa from group xorg-video-drivers? [Y/n] :: Install xf86-video-vga from group xorg-video-drivers? [Y/n] :: Install xf86-video-via from group xorg-video-drivers? [Y/n] :: Install xf86-video-vmware from group xorg-video-drivers? [Y/n] :: Install xf86-video-voodoo from group xorg-video-drivers? [Y/n] warning: xf86-video-intel-2.1.1-3 is up to date -- reinstalling warning: xf86-video-vesa-1.3.0-5 is up to date -- reinstalling resolving dependencies... looking for inter-conflicts... error: unresolvable package conflicts detected error: failed to prepare transaction (conflicting dependencies) :: xf86-video-unichrome: conflicts with xf86-video-via Oh no, I have to start everything again. Seriously, how practical is that? Personally, I never used it, and I don't see the point of this interactivity. I just do pacman -S group, I have a look at all the targets it wants to pull. And then, either I accept, or I refuse, and I run pacman -S again by picking the few targets I want manually. But if instead of only picking a few targets, you just want to exclude a few ones, then IgnorePkg should probably apply here. What do you think? There might be some important and common use cases I'm forgetting, which is why I bring this up here for discussion.

4 6

[pacman-dev] [PATCH] Updated Hungarian translation
by Nagy Gabor 12 Dec '07

12 Dec '07

Hi! Patch attached. Note: As Giovanni noted, the call-for-translators .po files weren't fully up-to-date. ---------------------------------------------------- SZTE Egyetemi Könyvtár - http://www.bibl.u-szeged.hu This mail sent through IMP: http://horde.org/imp/

1 0

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v3.0.6-675-gf5478d6
by Dan McGee 11 Dec '07

11 Dec '07

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, master has been updated via f5478d68a67741236a2e9f42f2e524ee1bb26517 (commit) via 685a659656d670acb0d606f8e91c8984d47c98b5 (commit) via 9558639d8009483fbf422b138d020745986f82f1 (commit) via f8b113ed97652da62c217cef139c58ca1d75d647 (commit) via 565d2eeed5fdd85b516cbc76bc48be439e42c41f (commit) via 9781d0d637fb2a077b0c4b262af1e2fb4decc2a0 (commit) via 572bdb5c997846c426aba53392800e5866f725bd (commit) via bd83a1fd85c0e1e41be998b3633f613bce75f08c (commit) via 90d72bd24f67e1ec32525ca0c36fece4d6364eab (commit) via 7249c08bdf6beacc087607db558ef16d3527b9b6 (commit) via 815a2ead3ef2b8daedb9e93e5e141356d5003e6e (commit) from b6acb30aae5504736fd23f97402389baabbddb1b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f5478d68a67741236a2e9f42f2e524ee1bb26517 Author: Aaron Griffin <aaronmgriffin(a)gmail.com> Date: Thu Nov 29 23:39:51 2007 -0600 Add real scriptlet checking for pactest Due to commit da1222de2e30aabcae9d17bbfa10bbf0672338af, we can now use fakechroot to completely run scriptlet pactests Use "which" functionality so as not to REQUIRE it for all users Signed-off-by: Aaron Griffin <aaronmgriffin(a)gmail.com> Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 685a659656d670acb0d606f8e91c8984d47c98b5 Author: Aaron Griffin <aaronmgriffin(a)gmail.com> Date: Thu Nov 29 23:37:53 2007 -0600 Add "which" path searching functionality to pactest Signed-off-by: Aaron Griffin <aaronmgriffin(a)gmail.com> commit 9558639d8009483fbf422b138d020745986f82f1 Author: Aaron Griffin <aaronmgriffin(a)gmail.com> Date: Thu Nov 29 23:30:57 2007 -0600 popen does NOT require /bin/sh in a subchroot I appears that when chrooted, the /bin/sh used by popen is that of the parent process. This is true until the process forks once chrooted, which we do not want to do. As such, this actually makes things nicer. We don't need a /bin/sh in a chroot to run install scriptlets, and don't need to check for it in the root directory Signed-off-by: Aaron Griffin <aaronmgriffin(a)gmail.com> Signed-off-by: Dan McGee <dan(a)archlinux.org> commit f8b113ed97652da62c217cef139c58ca1d75d647 Author: Aaron Griffin <aaronmgriffin(a)gmail.com> Date: Thu Nov 29 22:33:45 2007 -0600 Fail sanely on OUTPUT rules when --nolog is passed Check for existence of the logfile first, and output an error if not found Signed-off-by: Aaron Griffin <aaronmgriffin(a)gmail.com> Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 565d2eeed5fdd85b516cbc76bc48be439e42c41f Author: Aaron Griffin <aaronmgriffin(a)gmail.com> Date: Thu Nov 29 13:58:00 2007 -0600 Correct scriptlet usage pattern The new pattern is as follows: . /path/to/scriptlet post_upgrade X Y This requires less frameworking in the install scripts (the three lines that shift and eval a function are nasty) Signed-off-by: Aaron Griffin <aaronmgriffin(a)gmail.com> Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 9781d0d637fb2a077b0c4b262af1e2fb4decc2a0 Author: Dan McGee <dan(a)archlinux.org> Date: Mon Dec 10 22:55:22 2007 -0600 Update GNU GPL boilerplate and copyright dates Update the GPL boilerplate to direct people to the GNU website for a copy of the license, as well as bump all of Judd's copyrights to 2007. Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 572bdb5c997846c426aba53392800e5866f725bd Author: Dan McGee <dan(a)archlinux.org> Date: Sun Nov 4 14:30:11 2007 -0600 pactest: if we are root, don't use fakeroot Signed-off-by: Dan McGee <dan(a)archlinux.org> commit bd83a1fd85c0e1e41be998b3633f613bce75f08c Author: Dan McGee <dan(a)archlinux.org> Date: Mon Dec 10 12:06:12 2007 -0600 Updates to PKGBUILD manpage Make the manpage a little more distro agnostic by referring to ABS in the context of Arch Linux, and saying that prototype files are also available with the pacman source. Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 90d72bd24f67e1ec32525ca0c36fece4d6364eab Author: Dan McGee <dan(a)archlinux.org> Date: Sun Dec 9 13:49:38 2007 -0600 Rename prototype install file Most (sane) people name their install file pkgname.install, and this move of the prototype reflects that. Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 7249c08bdf6beacc087607db558ef16d3527b9b6 Author: Dan McGee <dan(a)archlinux.org> Date: Sat Dec 8 23:42:04 2007 -0600 Improve changelog handling through addition of open/read/close functions Thanks to Allan for inspiring all this work on what was one little TODO item in the codebase. :) Change changelog handling so we can now dump a changelog from both installed packages and package files (fixes FS#7371). We do this by moving all of the machinery to the backend where it should have been in the first place. The changelog reading is now done through a open/read/close interface similar to the fopen/fread/fclose functions (can you guess how it is done?). It is buffered by the frontend, so programs using the library can read as much or as little as they want at a time. Unfortunately, I could not implement a changelog_feof function due to some shortcomings of libarchive. However, I left the stub code in there, commented out, in case it becomes possible later or anyone wants to take a stab at it. Original-work-by: Allan McRae <mcrae_allan(a)hotmail.com> Improved-by: Chantry Xavier <shiningxc(a)gmail.com> Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 815a2ead3ef2b8daedb9e93e5e141356d5003e6e Author: Giovanni Scafora <linuxmania(a)gmail.com> Date: Sun Dec 9 11:38:08 2007 +0100 Updated Italian Translation Signed-off-by: Giovanni Scafora <linuxmania(a)gmail.com> Signed-off-by: Dan McGee <dan(a)archlinux.org> ----------------------------------------------------------------------- Summary of changes: COPYING | 31 +- contrib/pacdiff | 4 +- contrib/pacsearch | 3 +- contrib/{install.proto => proto.install} | 4 - contrib/re-pacman | 4 +- doc/PKGBUILD.5.txt | 17 +- lib/libalpm/add.c | 4 +- lib/libalpm/add.h | 6 +- lib/libalpm/alpm.c | 4 +- lib/libalpm/alpm.h | 11 +- lib/libalpm/alpm_list.c | 6 +- lib/libalpm/alpm_list.h | 6 +- lib/libalpm/backup.c | 4 +- lib/libalpm/backup.h | 6 +- lib/libalpm/be_files.c | 4 +- lib/libalpm/cache.c | 6 +- lib/libalpm/cache.h | 6 +- lib/libalpm/conflict.c | 6 +- lib/libalpm/conflict.h | 6 +- lib/libalpm/db.c | 6 +- lib/libalpm/db.h | 6 +- lib/libalpm/delta.c | 4 +- lib/libalpm/delta.h | 4 +- lib/libalpm/deps.c | 6 +- lib/libalpm/deps.h | 6 +- lib/libalpm/error.c | 6 +- lib/libalpm/error.h | 6 +- lib/libalpm/group.c | 6 +- lib/libalpm/group.h | 6 +- lib/libalpm/handle.c | 6 +- lib/libalpm/handle.h | 6 +- lib/libalpm/log.c | 6 +- lib/libalpm/log.h | 6 +- lib/libalpm/md5.c | 5 +- lib/libalpm/md5.h | 5 +- lib/libalpm/package.c | 115 +++++++- lib/libalpm/package.h | 6 +- lib/libalpm/remove.c | 6 +- lib/libalpm/remove.h | 6 +- lib/libalpm/server.c | 4 +- lib/libalpm/server.h | 4 +- lib/libalpm/sync.c | 6 +- lib/libalpm/sync.h | 6 +- lib/libalpm/trans.c | 19 +- lib/libalpm/trans.h | 6 +- lib/libalpm/util.c | 6 +- lib/libalpm/util.h | 6 +- pactest/pactest.py | 4 +- pactest/pmdb.py | 4 +- pactest/pmenv.py | 4 +- pactest/pmfile.py | 4 +- pactest/pmpkg.py | 4 +- pactest/pmrule.py | 12 +- pactest/pmtest.py | 15 +- pactest/tests/scriptlet001.py | 17 +- pactest/tests/scriptlet002.py | 17 +- pactest/util.py | 12 +- po/it.po | 478 ++++++++++++++++-------------- scripts/abs.sh.in | 4 +- scripts/gensync.sh.in | 4 +- scripts/makepkg.sh.in | 4 +- scripts/makeworld.sh.in | 4 +- scripts/pacman-optimize.sh.in | 4 +- scripts/rankmirrors.py.in | 4 +- scripts/repo-add.sh.in | 4 +- scripts/repo-remove.sh.in | 4 +- scripts/updatesync.sh.in | 4 +- src/pacman/add.c | 4 +- src/pacman/callback.c | 4 +- src/pacman/callback.h | 4 +- src/pacman/conf.c | 6 +- src/pacman/conf.h | 6 +- src/pacman/deptest.c | 6 +- src/pacman/package.c | 44 ++-- src/pacman/package.h | 8 +- src/pacman/pacman.c | 4 +- src/pacman/pacman.h | 4 +- src/pacman/query.c | 13 +- src/pacman/remove.c | 6 +- src/pacman/sync.c | 4 +- src/pacman/util.c | 6 +- src/pacman/util.h | 4 +- src/util/testdb.c | 4 +- src/util/testpkg.c | 4 +- src/util/vercmp.c | 4 +- 85 files changed, 574 insertions(+), 586 deletions(-) rename contrib/{install.proto => proto.install} (91%) hooks/post-receive -- The official pacman repository

2 1

[pacman-dev] [PATCH] Database with index??
by JJDaNiMoTh 10 Dec '07

10 Dec '07

Hello to all. After 2 weeks of intensive work (:P) I'm glad to post the first proof-of-concept code about using index in our life. Do you remember the discussion Backend DB, where we talked about in November? If not, see http://archlinux.org/pipermail/pacman-dev/2007-November/009938.html : Mikos proposed to see how pacman works with a big database file, like pacman1, but with a smaller index, that contains some information ( like pkgname - pkgver ) and where an entries start and finish in the big database. So, I've thinked about the making of index every time that users do pacman -Sy; but we haven't time to re-make index all times; so, I've coded all on the "B-side" of pacman: repo-add. The result are two file: txtdb.idx ===> big, big database file; index.idx ===> smaller file, that has this format: pkgname - pkgver - line_start - line_end Example: chpax - 0.12 - 22 - 53 Reading the line that contains "chpax", I see that the entries in txtdb.idx starts on line 22 and ends on line 53. Note that this patch doesn't modify the old way to make database. It simply add a new one :D Now the only part that I need to code is the pacman-side. Why I haven't coded this yet? Because pacman-side is ( in my point of view ) the more difficult part, and ( last but no last ) I want to hear your opinion about this. Excuse my elementary english ( I have rewrited 3 times the introduction to the patch :D ) and excuse If I can't explain how patch works ( I don't write any comments.. ). I will do all ( comments and explain ) tomorrow.. now it's very late :) Thanks -- JJDaNiMoTh - ArchLinux Trusted User

2 2

[pacman-dev] [PATCH] Only query pacman upgrade when performing actual upgrade
by Allan McRae 10 Dec '07

10 Dec '07

Attached is a patch that fixes FS#7147. The query about upgrading pacman separately is not needed when the -p and -w flags are used. It is really only a one line patch... I wasn't sure whether to use "alpm_trans_get_flags()" or "config->flags" as this seems to vary across files. Allan From df921cc477d3c999bb8889b4c88cdb3867691c0c Mon Sep 17 00:00:00 2001 From: Allan McRae <mcrae_allan(a)hotmail.com> Date: Sun, 9 Dec 2007 19:44:30 +1000 Subject: [PATCH] Only query pacman upgrade when performing actual upgrade Fixes FS#7147. Do not ask about upgrading pacman when -w and -p flags are used. Signed-off-by: Allan McRae <mcrae_allan(a)hotmail.com> --- src/pacman/sync.c | 74 +++++++++++++++++++++++++++------------------------- 1 files changed, 38 insertions(+), 36 deletions(-) diff --git a/src/pacman/sync.c b/src/pacman/sync.c index df102af..c8c017a 100644 --- a/src/pacman/sync.c +++ b/src/pacman/sync.c @@ -514,43 +514,45 @@ static int sync_trans(alpm_list_t *targets, int sync_only) goto cleanup; } - /* check if pacman itself is one of the packages to upgrade. - * this can prevent some of the "syntax error" problems users can have - * when sysupgrade'ing with an older version of pacman. - */ - pkgs = alpm_trans_get_pkgs(); - for(i = pkgs; i; i = alpm_list_next(i)) { - pmsyncpkg_t *sync = alpm_list_getdata(i); - pmpkg_t *spkg = alpm_sync_get_pkg(sync); - /* TODO pacman name should probably not be hardcoded. In addition, we - * have problems on an -Syu if pacman has to pull in deps, so recommend - * an '-S pacman' operation */ - if(strcmp("pacman", alpm_pkg_get_name(spkg)) == 0) { - printf("\n"); - printf(_(":: pacman has detected a newer version of itself.\n" - ":: It is recommended that you upgrade pacman by itself\n" - ":: using 'pacman -S pacman', and then rerun the current\n" - ":: operation. If you wish to continue the operation and\n" - ":: not upgrade pacman separately, answer no.\n")); - if(yesno(_(":: Cancel current operation? [Y/n] "))) { - if(alpm_trans_release() == -1) { - fprintf(stderr, _("error: failed to release transaction (%s)\n"), - alpm_strerrorlast()); - retval = 1; - goto cleanup; - } - if(alpm_trans_init(PM_TRANS_TYPE_SYNC, config->flags, - cb_trans_evt, cb_trans_conv, cb_trans_progress) == -1) { - fprintf(stderr, _("error: failed to init transaction (%s)\n"), - alpm_strerrorlast()); - return(1); - } - if(alpm_trans_addtarget("pacman") == -1) { - fprintf(stderr, _("error: pacman: %s\n"), alpm_strerrorlast()); - retval = 1; - goto cleanup; + if(!(config->op_s_downloadonly) && !(alpm_trans_get_flags() & PM_TRANS_FLAG_PRINTURIS)) { + /* check if pacman itself is one of the packages to upgrade. + * this can prevent some of the "syntax error" problems users can have + * when sysupgrade'ing with an older version of pacman. + */ + pkgs = alpm_trans_get_pkgs(); + for(i = pkgs; i; i = alpm_list_next(i)) { + pmsyncpkg_t *sync = alpm_list_getdata(i); + pmpkg_t *spkg = alpm_sync_get_pkg(sync); + /* TODO pacman name should probably not be hardcoded. In addition, we + * have problems on an -Syu if pacman has to pull in deps, so recommend + * an '-S pacman' operation */ + if(strcmp("pacman", alpm_pkg_get_name(spkg)) == 0) { + printf("\n"); + printf(_(":: pacman has detected a newer version of itself.\n" + ":: It is recommended that you upgrade pacman by itself\n" + ":: using 'pacman -S pacman', and then rerun the current\n" + ":: operation. If you wish to continue the operation and\n" + ":: not upgrade pacman separately, answer no.\n")); + if(yesno(_(":: Cancel current operation? [Y/n] "))) { + if(alpm_trans_release() == -1) { + fprintf(stderr, _("error: failed to release transaction (%s)\n"), + alpm_strerrorlast()); + retval = 1; + goto cleanup; + } + if(alpm_trans_init(PM_TRANS_TYPE_SYNC, config->flags, + cb_trans_evt, cb_trans_conv, cb_trans_progress) == -1) { + fprintf(stderr, _("error: failed to init transaction (%s)\n"), + alpm_strerrorlast()); + return(1); + } + if(alpm_trans_addtarget("pacman") == -1) { + fprintf(stderr, _("error: pacman: %s\n"), alpm_strerrorlast()); + retval = 1; + goto cleanup; + } + break; } - break; } } } -- 1.5.3.7

3 2

[pacman-dev] [PATCH] Improve changelog handling
by Allan McRae 09 Dec '07

09 Dec '07

Hi all, Below is a patch that tries to improve the handling of changelog dumping. Now changelogs should also get dumped when using "pacman -Qcp <file>" syntax as well as "pacman -Qc <pkg>" (See http://bugs.archlinux.org/task/7321) This is my first patch to the pacman/libalpm code base so it probably needs lots of checking. I stared at the code for a couple of hours before I started but I am probably using some libalpm functions wrongly. I would pay particular attention to the entirely new "alpm_pkg_get_changelog" function in libalpm/package.c. The code builds cleanly but I can't test much more than that at the moment due to my testing box having what I think is RAM issues leaving me only my work laptop... Cheers, Allan From 47affca982ec2d449bd6d96846172052dbdd3da6 Mon Sep 17 00:00:00 2001 From: Allan McRae <mcrae_allan(a)hotmail.com> Date: Sat, 8 Dec 2007 02:35:00 +1000 Subject: [PATCH] Improve changelog handling Allows dumping of changelog for both installed packages and from package files (See FS#7321). Moves querying of changelog file in alpm backend. Signed-off-by: Allan McRae <mcrae_allan(a)hotmail.com> --- lib/libalpm/alpm.h | 1 + lib/libalpm/package.c | 71 +++++++++++++++++++++++++++++++++++++++++++++++++ src/pacman/package.c | 33 ++++++++++------------ src/pacman/package.h | 2 +- src/pacman/query.c | 9 +----- 5 files changed, 89 insertions(+), 27 deletions(-) diff --git a/lib/libalpm/alpm.h b/lib/libalpm/alpm.h index 1e18ad9..7f6c9eb 100644 --- a/lib/libalpm/alpm.h +++ b/lib/libalpm/alpm.h @@ -216,6 +216,7 @@ alpm_list_t *alpm_pkg_get_deltas(pmpkg_t *pkg); alpm_list_t *alpm_pkg_get_replaces(pmpkg_t *pkg); alpm_list_t *alpm_pkg_get_files(pmpkg_t *pkg); alpm_list_t *alpm_pkg_get_backup(pmpkg_t *pkg); +alpm_list_t *alpm_pkg_get_changelog(pmpkg_t *pkg); unsigned short alpm_pkg_has_scriptlet(pmpkg_t *pkg); unsigned long alpm_pkg_download_size(pmpkg_t *newpkg, pmdb_t *db_local); diff --git a/lib/libalpm/package.c b/lib/libalpm/package.c index 172456d..bbdb95d 100644 --- a/lib/libalpm/package.c +++ b/lib/libalpm/package.c @@ -491,6 +491,77 @@ alpm_list_t SYMEXPORT *alpm_pkg_get_backup(pmpkg_t *pkg) return pkg->backup; } +alpm_list_t SYMEXPORT *alpm_pkg_get_changelog(pmpkg_t *pkg) +{ + ALPM_LOG_FUNC; + + /* Sanity checks */ + ASSERT(handle != NULL, return(NULL)); + ASSERT(pkg != NULL, return(NULL)); + + int ret = ARCHIVE_OK; + alpm_list_t *cl = NULL; + char clfile[PATH_MAX]; + char *tmpfile = NULL; + struct archive *archive; + struct archive_entry *entry; + int fd = -1; + char line[PATH_MAX]; + + if(pkg->origin == PKG_FROM_CACHE) { + snprintf(clfile, PATH_MAX, "%s/%s/%s-%s/changelog", + alpm_option_get_dbpath(), + alpm_db_get_name(alpm_db_register_local()), + alpm_pkg_get_name(pkg), + alpm_pkg_get_version(pkg)); + } else if(pkg->origin == PKG_FROM_FILE) { + const char *pkgfile = pkg->origin_data.file; + + if((archive = archive_read_new()) == NULL) { + RET_ERR(PM_ERR_LIBARCHIVE_ERROR, NULL); + } + + archive_read_support_compression_all(archive); + archive_read_support_format_all(archive); + + if (archive_read_open_filename(archive, pkgfile, + ARCHIVE_DEFAULT_BYTES_PER_BLOCK) != ARCHIVE_OK) { + RET_ERR(PM_ERR_PKG_OPEN, NULL); + } + + while((ret = archive_read_next_header(archive, &entry)) == ARCHIVE_OK) { + const char *entry_name = archive_entry_pathname(entry); + + if(strcmp(entry_name, ".CHANGELOG") == 0) { + tmpfile = strdup("/tmp/alpm_XXXXXX"); + fd = mkstemp(tmpfile); + archive_read_data_into_fd(archive, fd); + break; + } + } + snprintf(clfile, PATH_MAX, "%s", tmpfile); + } + + FILE* fp = fopen(clfile, "r"); + if(fp == NULL){ + return cl; + } + + while(!feof(fp)) { + fgets(line, (int)PATH_MAX, fp); + cl = alpm_list_add(cl, strdup(line)); + } + fclose(fp); + + if(pkg->origin == PKG_FROM_FILE) { + unlink(tmpfile); + FREE(tmpfile); + close(fd); + } + + return cl; +} + unsigned short SYMEXPORT alpm_pkg_has_scriptlet(pmpkg_t *pkg) { ALPM_LOG_FUNC; diff --git a/src/pacman/package.c b/src/pacman/package.c index ac3f820..00c3535 100644 --- a/src/pacman/package.c +++ b/src/pacman/package.c @@ -232,29 +232,26 @@ void dump_pkg_files(pmpkg_t *pkg) fflush(stdout); } -/* Display the changelog of an installed package +/* Display the changelog of a package */ -void dump_pkg_changelog(char *clfile, const char *pkgname) +void dump_pkg_changelog(pmpkg_t *pkg) { - FILE* fp = NULL; - char line[PATH_MAX+1]; - - if((fp = fopen(clfile, "r")) == NULL) - { - fprintf(stderr, _("error: no changelog available for '%s'.\n"), pkgname); + alpm_list_t *changelog = NULL; + alpm_list_t *i; + char line[PATH_MAX]; + + changelog = alpm_pkg_get_changelog(pkg); + if(changelog == NULL) { + fprintf(stderr, _("error: no changelog available for '%s'.\n"), alpm_pkg_get_name(pkg)); return; - } - else - { - while(!feof(fp)) - { - fgets(line, (int)PATH_MAX, fp); - printf("%s", line); - line[0] = '\0'; + } else { + for(i = changelog; i; i = alpm_list_next(i)) { + snprintf(line, PATH_MAX-1, "%s", (char*)alpm_list_getdata(i)); + fprintf(stdout, "%s\n", line); } - fclose(fp); - return; } + + FREELIST(changelog); } /* vim: set ts=2 sw=2 noet: */ diff --git a/src/pacman/package.h b/src/pacman/package.h index 0e4bb0f..7dfc054 100644 --- a/src/pacman/package.h +++ b/src/pacman/package.h @@ -28,7 +28,7 @@ void dump_pkg_sync(pmpkg_t *pkg, const char *treename); void dump_pkg_backups(pmpkg_t *pkg); void dump_pkg_files(pmpkg_t *pkg); -void dump_pkg_changelog(char *clfile, const char *pkgname); +void dump_pkg_changelog(pmpkg_t *pkg); #endif /* _PM_PACKAGE_H */ diff --git a/src/pacman/query.c b/src/pacman/query.c index 8a8765b..1307077 100644 --- a/src/pacman/query.c +++ b/src/pacman/query.c @@ -312,14 +312,7 @@ static void display(pmpkg_t *pkg) dump_pkg_files(pkg); } if(config->op_q_changelog) { - char changelog[PATH_MAX]; - /* TODO should be done in the backend- no raw DB stuff up front */ - snprintf(changelog, PATH_MAX, "%s/%s/%s-%s/changelog", - alpm_option_get_dbpath(), - alpm_db_get_name(db_local), - alpm_pkg_get_name(pkg), - alpm_pkg_get_version(pkg)); - dump_pkg_changelog(changelog, alpm_pkg_get_name(pkg)); + dump_pkg_changelog(pkg); } if(!config->op_q_info && !config->op_q_list && !config->op_q_changelog) { if (!config->quiet) { -- 1.5.3.7

9 25