- Pacman-dev - lists.archlinux.org

[pacman-dev] FREELIST macros / little memleak fix
by Xavier 21 Nov '07

21 Nov '07

1) I remember having already asked that, but it was probably just on irc, and anyway I forgot what the answer was (if there was one ;)). It's about commit a57b2f233 : http://projects.archlinux.org/git/?p=pacman.git;a=commitdiff;h=a57b2f233f28… What was wrong / messy about these macros : -/* TODO we should do away with these... they're messy*/ -#define _FREELIST(p, f) do { alpm_list_free_inner(p, f); alpm_list_free(p); p = NULL; } while(0) -#define FREELIST(p) _FREELIST(p, free) -#define FREELISTPTR(p) do { alpm_list_free(p); p = NULL; } while(0) +#define FREELIST(p) do { alpm_list_free_inner(p, free); alpm_list_free(p); p = NULL; } while(0) Hm, actually while writing this mail, I realize this it not very problematic :P In the worst case, we just need two little additional calls. But I still don't find these very messy. 2) If I mentioning this, it's because I found a little memleak in _alpm_sync_free: a missing alpm_list_free call. So maybe the above _FREELIST(p, f) macro could have helped. Also, for some reasons, both _alpm_sync_free and _alpm_trans_free did the job of alpm_list_free_inner manually. So I changed that. 3) A little problem : all _alpm_*_free don't match the alpm_list_fn_free prototype except one : _alpm_graph_free . All others don't take a void * argument, so they need to be casted to alpm_list_fn_free for being used with alpm_list_free_inner . So should "static void _alpm_graph_free(void *data)" be changed to "static void _alpm_graph_free(pmgraph_t *graph)" ? >From fdf689932ca1fa919b95533a2469f797f22970f1 Mon Sep 17 00:00:00 2001 From: Chantry Xavier <shiningxc(a)gmail.com> Date: Wed, 21 Nov 2007 17:10:20 +0100 Subject: [PATCH] Fix a memleak in _alpm_sync_free. An alpm_list_free call was missing. Also make use of alpm_list_free_inner in both _alpm_sync_free and _alpm_trans_free. Signed-off-by: Chantry Xavier <shiningxc(a)gmail.com> --- lib/libalpm/sync.c | 7 ++----- lib/libalpm/trans.c | 10 ++-------- 2 files changed, 4 insertions(+), 13 deletions(-) diff --git a/lib/libalpm/sync.c b/lib/libalpm/sync.c index 16b1998..f03a78b 100644 --- a/lib/libalpm/sync.c +++ b/lib/libalpm/sync.c @@ -74,11 +74,8 @@ void _alpm_sync_free(pmsyncpkg_t *sync) /* TODO wow this is ugly */ if(sync->type == PM_SYNC_TYPE_REPLACE) { - alpm_list_t *tmp; - for(tmp = sync->data; tmp; tmp = alpm_list_next(tmp)) { - _alpm_pkg_free(tmp->data); - tmp->data = NULL; - } + alpm_list_free_inner(sync->data, (alpm_list_fn_free)_alpm_pkg_free); + alpm_list_free(sync->data); sync->data = NULL; } else { _alpm_pkg_free(sync->data); diff --git a/lib/libalpm/trans.c b/lib/libalpm/trans.c index 19ae2b6..d998826 100644 --- a/lib/libalpm/trans.c +++ b/lib/libalpm/trans.c @@ -246,8 +246,6 @@ pmtrans_t *_alpm_trans_new() void _alpm_trans_free(pmtrans_t *trans) { - alpm_list_t *i; - ALPM_LOG_FUNC; if(trans == NULL) { @@ -256,13 +254,9 @@ void _alpm_trans_free(pmtrans_t *trans) FREELIST(trans->targets); if(trans->type == PM_TRANS_TYPE_SYNC) { - for(i = trans->packages; i; i = alpm_list_next(i)) { - _alpm_sync_free(i->data); - } + alpm_list_free_inner(trans->packages, (alpm_list_fn_free)_alpm_sync_free); } else { - for(i = trans->packages; i; i = alpm_list_next(i)) { - _alpm_pkg_free(i->data); - } + alpm_list_free_inner(trans->packages, (alpm_list_fn_free)_alpm_pkg_free); } alpm_list_free(trans->packages); -- 1.5.3.6

2 1

[pacman-dev] pacman-git releases
by Dan McGee 21 Nov '07

21 Nov '07

I bumped the version of the i686 version again today, and I've also added an x86_64 build and DB at the same place. http://www.archlinux.org/~dan/pacman-git/ You should be able to figure out the DB name from there. For anyone using the 64-bit version, please let us know just so that we can feel like its actually been tested on that architecture. Aaron- the date on your machine is all messed up, thus the messed up version label on the 64-bit package. :) -Dan

2 1

[pacman-dev] [PATCH] Improved 'dependency cycle' warning
by Nagy Gabor 21 Nov '07

21 Nov '07

Hi! I did a -Su yesterday, and I got 4 dependency cycle warnings. I became curious and I made this little patch (English clarifiaction needed). So I found 4 dependency cycle in our repos; these are not necessarily bugs but imho they worth mentioning: glibc->tzdata->glibc readline->glibc->bash->readline coreutils->shadow->coreutils db->coreutils->pam->db Bye ---------------------------------------------------- SZTE Egyetemi Könyvtár - http://www.bibl.u-szeged.hu This mail sent through IMP: http://horde.org/imp/

3 2

[pacman-dev] Valgrind updated, blog article plug
by Dan McGee 21 Nov '07

21 Nov '07

I rebuilt valgrind tonight against glibc 2.7, so you may see improved performance using this tool with your pacman debugging and memleak-finding expeditions. I'm mainly letting you all know this because Xavier asked me to write up something on how I use valgrind with pacman. I threw up a short little article on my blog (http://toofishes.net/blog/) to help people get started, the actual article is here: http://toofishes.net/blog/using-valgrind-c-programming/ If you guys have any questions in the future about how I do stuff, whether its coding, algorithms, tools I use, etc. *please* feel free to ask and I will try to answer, either privately or publicly. -Dan P.S. I'm already number 5 on Google (OK, I had to cheat a bit with the search terms). :) http://www.google.com/search?source=ig&hl=en&rlz=&q=valgrind+c

1 0

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v3.0.0-612-g83fa6aa
by Dan McGee 21 Nov '07

21 Nov '07

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, master has been updated discards c419277dd2633b19a2a989f5b2a11cd9b4f4375b (commit) via 83fa6aa2896c0c940e8bf5b7499abc7ef955e658 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (c419277dd2633b19a2a989f5b2a11cd9b4f4375b) \ N -- N -- N (83fa6aa2896c0c940e8bf5b7499abc7ef955e658) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 83fa6aa2896c0c940e8bf5b7499abc7ef955e658 Author: Chantry Xavier <shiningxc(a)gmail.com> Date: Sat Aug 25 00:10:40 2007 +0200 Remove duplicated get_upgrades function, use sysupgrade instead. The alpm_get_upgrades was exactly the same as find_replacements + _alpm_sync_sysupgrade, except that it automatically made the eventual replacements, without asking the user : Replace %s with %s/%s? [Y/n] The replace question, asked in find_replacements. can now be skipped by using a NULL trans argument, so that we get the same behavior as with alpm_get_upgrades. So alpm_db_get_upgrades() can now be replaced by alpm_sync_sysupgrade(db_local, syncdbs). Signed-off-by: Chantry Xavier <shiningxc(a)gmail.com> Signed-off-by: Dan McGee <dan(a)archlinux.org> ----------------------------------------------------------------------- Summary of changes: hooks/post-receive -- The official pacman repository

1 0

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v3.0.0-612-gc419277
by Dan McGee 21 Nov '07

21 Nov '07

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, master has been updated via c419277dd2633b19a2a989f5b2a11cd9b4f4375b (commit) from 3e9c590480d7ec8fe576cf0a2216e1d3cb61db77 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c419277dd2633b19a2a989f5b2a11cd9b4f4375b Author: Chantry Xavier <shiningxc(a)gmail.com> Date: Sat Aug 25 00:10:40 2007 +0200 Remove duplicated get_upgrades function, use sysupgrade instead. The alpm_get_upgrades was exactly the same as find_replacements + _alpm_sync_sysupgrade, except that it automatically made the eventual replacements, without asking the user : Replace %s with %s/%s? [Y/n] The replace question, asked in find_replacements. can now be skipped by using a NULL trans argument, so that we get the same behavior as with alpm_get_upgrades. So alpm_db_get_upgrades() can now be replaced by alpm_sync_sysupgrade(db_local, syncdbs). Signed-off-by: Chantry Xavier <shiningxc(a)gmail.com> ----------------------------------------------------------------------- Summary of changes: lib/libalpm/alpm.h | 4 +- lib/libalpm/db.c | 144 --------------------------------- lib/libalpm/sync.c | 221 ++++++++++++++++++++++++++++++--------------------- lib/libalpm/sync.h | 4 +- lib/libalpm/trans.c | 3 +- src/pacman/query.c | 8 ++- 6 files changed, 142 insertions(+), 242 deletions(-) hooks/post-receive -- The official pacman repository

1 0

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v3.0.0-611-g3e9c590
by Dan McGee 21 Nov '07

21 Nov '07

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, master has been updated via 3e9c590480d7ec8fe576cf0a2216e1d3cb61db77 (commit) via 5f2899622070496eb7e918c9089c6a6327bacb41 (commit) via 4696ad6cad9c659728e9e061689728fc0417ad73 (commit) via 967a78f5e476030c2d13104a7dadc5ce4daf5882 (commit) via aa942a126bb7c229f7b94e5e0ab8de5241f77580 (commit) via 4576000c39ea350fc563163c4deb2e2e4031e386 (commit) via 84ebf8231985ff285f7995cd7ecaceb750a3c78b (commit) via 23b4e0270b1a1881b2daf362a398a3bdc20fab43 (commit) from 2aa7e69da91c1d7a18473cf05df98c92bd1dc747 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3e9c590480d7ec8fe576cf0a2216e1d3cb61db77 Author: Dan McGee <dan(a)archlinux.org> Date: Tue Nov 20 19:06:37 2007 -0600 doc: use source highlighter on PKGBUILD guide, update wrong example text Note that if you are building manpages with asciidoc now, you must also have source-highlight installed for it to correctly generate everything. Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 5f2899622070496eb7e918c9089c6a6327bacb41 Author: Dan McGee <dan(a)archlinux.org> Date: Tue Nov 20 18:58:09 2007 -0600 Turn HACKING into an asciidoc document Add some hints so we can use asciidoc on the HACKING document. It is still readable as text, but a simple 'asciidoc HACKING' command will give you a nice pretty guide now. Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 4696ad6cad9c659728e9e061689728fc0417ad73 Author: Nagy Gabor <ngaba(a)bibl.u-szeged.hu> Date: Tue Nov 20 09:11:40 2007 +0100 New alpm_list_join function This O(1) function joins 2 lists. Signed-off-by: Nagy Gabor <ngaba(a)bibl.u-szeged.hu> Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 967a78f5e476030c2d13104a7dadc5ce4daf5882 Author: Chantry Xavier <shiningxc(a)gmail.com> Date: Mon Nov 19 18:23:04 2007 +0100 Update PKGBUILD manpage with versioned conflicts. As the b96922679e4ed14aa687bf194b766d82a1d10577 commit showed with two pactests (which were renamed to depconflict110/111), versioned conflicts are now possible. Signed-off-by: Chantry Xavier <shiningxc(a)gmail.com> Signed-off-by: Dan McGee <dan(a)archlinux.org> commit aa942a126bb7c229f7b94e5e0ab8de5241f77580 Author: Dan McGee <dan(a)archlinux.org> Date: Tue Nov 20 11:01:56 2007 -0600 Add missing header includes for setlocale Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 4576000c39ea350fc563163c4deb2e2e4031e386 Author: Dan McGee <dan(a)archlinux.org> Date: Mon Nov 19 15:46:02 2007 -0600 Spruce up HACKING a bit Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 84ebf8231985ff285f7995cd7ecaceb750a3c78b Author: Nagy Gabor <ngaba(a)bibl.u-szeged.hu> Date: Fri Nov 16 22:37:57 2007 +0100 Versioned provisions. This patch introduces versioned provisions in "provision 1.0-1" format. _alpm_db_whatprovides was modified accordingly (added sync500.py), alpm_depcmp was modified accordingly (add043.py passes now; added add044.py and add045.py). Notes: alpm_db_search now uses the whole versioned %PROVIDES% string in its search. debug logging was simplified in alpm_depcmp. Signed-off-by: Nagy Gabor <ngaba(a)bibl.u-szeged.hu> [Xavier: fixed a few typos, duplicate const strings with strdup before modifying them, put some debugging back in alpm_depcmp, minor code cleanups (var/function renaming), added a note in PKGBUILD man page.] Signed-off-by: Chantry Xavier <shiningxc(a)gmail.com> [Dan: made strcmp checks clearer, added a comment] Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 23b4e0270b1a1881b2daf362a398a3bdc20fab43 Author: Dan McGee <dan(a)archlinux.org> Date: Sun Nov 18 16:49:02 2007 -0600 Fix sh and scriptlet interaction dash doesn't pass positional parameters to sourced scripts, causing install scripts to fail. Instead of sourcing the script, make it executable and call it directly which allows positional parameters to be passed correctly. Signed-off-by: Dan McGee <dan(a)archlinux.org> ----------------------------------------------------------------------- Summary of changes: HACKING | 107 ++++++++++++++++++++++---------- doc/PKGBUILD.5.txt | 13 +++-- lib/libalpm/alpm_list.c | 33 ++++++++++ lib/libalpm/alpm_list.h | 1 + lib/libalpm/be_files.c | 1 + lib/libalpm/db.c | 21 ++++++- lib/libalpm/db.h | 1 + lib/libalpm/deps.c | 51 +++++++++------- lib/libalpm/package.c | 1 + lib/libalpm/sync.c | 4 +- lib/libalpm/trans.c | 15 +++- pactest/tests/{add043.py => add044.py} | 8 +- pactest/tests/{add043.py => add045.py} | 4 +- pactest/tests/sync500.py | 10 +++ 14 files changed, 197 insertions(+), 73 deletions(-) copy pactest/tests/{add043.py => add044.py} (57%) copy pactest/tests/{add043.py => add045.py} (75%) create mode 100644 pactest/tests/sync500.py hooks/post-receive -- The official pacman repository

1 0

[pacman-dev] There is a "problem" with list->prev tail pointer
by Nagy Gabor 20 Nov '07

20 Nov '07

Look at the following code-part: for(i = list; i; i = i->next) { alpm_list_foo(i); /*WARNING!!*/ } Comment: So a node in a list (i in the example) is NOT a valid alpm_list_t: You can do alpm_list_getdata for example, but not alpm_list_add. This is very confusing to me. We should somehow differeniate between alpm_list_t and alpm_list_node_t types, so at least force the compiler to give a warning message. Bye ---------------------------------------------------- SZTE Egyetemi Könyvtár - http://www.bibl.u-szeged.hu This mail sent through IMP: http://horde.org/imp/

2 1

[pacman-dev] [PATCH] _alpm_checkconflicts split
by Nagy Gabor 20 Nov '07

20 Nov '07

Patch attached Bye PS: Xavier, this patch was created mainly for your sync repo and your shining[;-)] testdb. ---------------------------------------------------- SZTE Egyetemi Könyvtár - http://www.bibl.u-szeged.hu This mail sent through IMP: http://horde.org/imp/

2 2

[pacman-dev] [PATCH] Versioned provisions
by Nagy Gabor 20 Nov '07

20 Nov '07

Hi! Patch attached. Bye ---------------------------------------------------- SZTE Egyetemi Könyvtár - http://www.bibl.u-szeged.hu This mail sent through IMP: http://horde.org/imp/

5 44