- Pacman-dev - lists.archlinux.org

[pacman-dev] IgnorePkg, Holdpkg in libalpm/remove.c
by Nagy Gabor 26 Nov '07

26 Nov '07

Hi! Here is a pactest file derived from remove042.py [not to commit]: ---remove049.py--- self.description = "Cascade remove a package required by a HoldPkg package" lp1 = pmpkg("pkg1") lp1.depends = ["imaginary"] self.addpkg2db("local", lp1) lp2 = pmpkg("pkg2") lp2.provides = ["imaginary"] self.addpkg2db("local", lp2) self.option["holdpkg"] = ["pkg1"] self.args = "-Rc %s" % lp2.name self.addrule("PACMAN_RETCODE=0") self.addrule("!PKG_EXIST=pkg1") self.addrule("!PKG_EXIST=pkg2") ------------------- [Note: lp2.requiredby is not needed now.] As you see, -Rc simply elects a holdpkg for removal without any warning [but at least it prints a package summary before commit]. The same for -Rs <- this is "harder" to fix [elegantly], because alpm_recursedeps is a general-purpose deps.c function. You probably noticed IgnorePkg in the subject: -Rs and -Rc show, that this can be useful with -R too [we may differentiate between RemoveIgnorePkg, UpgradeIgnorePkg, and (transaction) IgnorePkg]. Bye ---------------------------------------------------- SZTE Egyetemi Könyvtár - http://www.bibl.u-szeged.hu This mail sent through IMP: http://horde.org/imp/

2 4

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v3.0.0-622-g1e9a1a0
by Dan McGee 25 Nov '07

25 Nov '07

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, master has been updated via 1e9a1a0292dbbf8039b8fb7536dbff2af28c7afb (commit) via c36b0f32c6f77cc363ed8f3ddc1a50625af944a9 (commit) via 6e8daa553bbd50ec541add9549bfd95030c335f5 (commit) via c7879e77a716edc725858e316ea9d2fa00056d4d (commit) via 7af1f664411d337d865b2b3bd876163f2b0fbac4 (commit) via 8d9ee923ec3860e3f1133a66a0dc94ce85644bb4 (commit) via 8bee526d28eaad45e0e1e210cd523e157c71cfae (commit) via f5d2150e9db9205a9f208d4144b6d0381f877ad3 (commit) via 0144b2ed29b3e3ae09fd8caeeffdadc10322cc1c (commit) via 7cf28a75959eac03a12c471a01f0a6111fbbd0ce (commit) from 83fa6aa2896c0c940e8bf5b7499abc7ef955e658 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1e9a1a0292dbbf8039b8fb7536dbff2af28c7afb Author: Artyom <smirnoffjr(a)gmail.com> Date: Wed Nov 7 01:05:33 2007 -0600 Add -q/--quiet option for controlling output. Currently this only affects -Ss, -Sl, and -Q to output less information (only package names). In the future, we can reuse this flag for other things as well. [Aaron: rewritten as a front-end flag] Signed-off-by: Aaron Griffin <aaronmgriffin(a)gmail.com> [Dan: squashed commits together] Signed-off-by: Dan McGee <dan(a)archlinux.org> commit c36b0f32c6f77cc363ed8f3ddc1a50625af944a9 Author: Dan McGee <dan(a)archlinux.org> Date: Sun Nov 25 14:12:00 2007 -0600 Fix memleak when querying package file(s) Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 6e8daa553bbd50ec541add9549bfd95030c335f5 Author: Aaron Griffin <aaronmgriffin(a)gmail.com> Date: Wed Nov 14 19:22:06 2007 -0600 Force mode of all database files to 644 In the case of a packaging error where install or changelog had bad permissions, pacman respected the original permissions without trying to fix it - this means that some operations (changelog) artificially required root permissions to run In addition, minor function housekeeping on _alpm_unpack Signed-off-by: Aaron Griffin <aaronmgriffin(a)gmail.com> commit c7879e77a716edc725858e316ea9d2fa00056d4d Author: Aaron Griffin <aaronmgriffin(a)gmail.com> Date: Thu Nov 15 00:07:31 2007 -0600 Additionally search for non-regex strings on a db search operation This closes out FS#6500 and covers cases where the package names contain regex characters (i.e. the case of dvd+rw-tools) Signed-off-by: Aaron Griffin <aaronmgriffin(a)gmail.com> commit 7af1f664411d337d865b2b3bd876163f2b0fbac4 Author: Aaron Griffin <aaronmgriffin(a)gmail.com> Date: Thu Nov 15 13:19:49 2007 -0600 Make the download failure message more clear Use the word "disk" in place of the host name for local files Signed-off-by: Aaron Griffin <aaronmgriffin(a)gmail.com> commit 8d9ee923ec3860e3f1133a66a0dc94ce85644bb4 Author: Chantry Xavier <shiningxc(a)gmail.com> Date: Wed Nov 21 19:51:46 2007 +0100 Fix several memleaks, mostly related to errors handling. * The frontend calls alpm_trans_prepare(&data), and in case of errors, receive the missing dependencies / conflicts / etc in the data pointer. It apparently needs to free this structure totally with : alpm_list_free_inner(data, free) alpm_list_free(data) So I added alpm_list_free_inner(data, free) in pacman/{sync.c,remove.c,add,c} * in _alpm_sync_prepare, the deps and asked lists were not freed in case of errors (unresolvable conflicts). Besides the code for handling this case was duplicated. * in _alpm_remove_commit, free was used instead of alpm_list_free for newfiles. * newline fix in pacman/sync.c Signed-off-by: Chantry Xavier <shiningxc(a)gmail.com> Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 8bee526d28eaad45e0e1e210cd523e157c71cfae Author: Chantry Xavier <shiningxc(a)gmail.com> Date: Wed Nov 21 17:10:20 2007 +0100 Fix a memleak in _alpm_sync_free. An alpm_list_free call was missing. Also make use of alpm_list_free_inner in both _alpm_sync_free and _alpm_trans_free. Signed-off-by: Chantry Xavier <shiningxc(a)gmail.com> Signed-off-by: Dan McGee <dan(a)archlinux.org> commit f5d2150e9db9205a9f208d4144b6d0381f877ad3 Author: Dan McGee <dan(a)archlinux.org> Date: Wed Nov 21 11:25:50 2007 -0600 Remove -F/--freshen operation This operation made sense in the days before sync DBs existed, but it no longer has the same usefulness it once did. Signed-off-by: Dan McGee <dan(a)archlinux.org> Signed-off-by: Chantry Xavier <shiningxc(a)gmail.com> Signed-off-by: Nagy Gabor <ngaba(a)bibl.u-szeged.hu> Signed-off-by: Aaron Griffin <aaronmgriffin(a)gmail.com> commit 0144b2ed29b3e3ae09fd8caeeffdadc10322cc1c Author: Dan McGee <dan(a)archlinux.org> Date: Wed Nov 21 10:35:27 2007 -0600 Add some additional files to .gitignore *.lineno - these show up when you use a shell less-featured than bash cscope.*.out - These show up when you build reverse databases using -q Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 7cf28a75959eac03a12c471a01f0a6111fbbd0ce Author: Nagy Gabor <ngaba(a)bibl.u-szeged.hu> Date: Wed Nov 21 01:03:08 2007 +0100 Improved 'dependency cycle' warning From now on libalpm informs user about packages which will be installed/removed in wrong order. Signed-off-by: Nagy Gabor <ngaba(a)bibl.u-szeged.hu> Signed-off-by: Dan McGee <dan(a)archlinux.org> ----------------------------------------------------------------------- Summary of changes: .gitignore | 4 +++ contrib/bash_completion | 6 +--- contrib/zsh_completion | 11 +--------- doc/pacman.8.txt | 4 --- lib/libalpm/add.c | 13 +---------- lib/libalpm/alpm.h | 2 +- lib/libalpm/db.c | 4 +++ lib/libalpm/deps.c | 9 +++++++- lib/libalpm/remove.c | 2 +- lib/libalpm/server.c | 6 ++++- lib/libalpm/sync.c | 49 +++++++++++++++++++--------------------------- lib/libalpm/trans.c | 10 +------- lib/libalpm/util.c | 35 +++++++++++++++++++++++---------- pactest/tests/add030.py | 18 ----------------- pactest/tests/add031.py | 18 ----------------- pactest/tests/add032.py | 18 ----------------- src/pacman/add.c | 1 + src/pacman/conf.h | 1 + src/pacman/pacman.c | 20 +++++++----------- src/pacman/query.c | 34 ++++++++++++++++++++++++-------- src/pacman/remove.c | 1 + src/pacman/sync.c | 31 ++++++++++++++++++++--------- 22 files changed, 131 insertions(+), 166 deletions(-) delete mode 100644 pactest/tests/add030.py delete mode 100644 pactest/tests/add031.py delete mode 100644 pactest/tests/add032.py hooks/post-receive -- The official pacman repository

1 0

[pacman-dev] "local version is up to date. Upgrade anyway?" question
by Xavier 23 Nov '07

23 Nov '07

For testing the last patch from Nagy that makes the "dependency cycle" warning more verbose, I wanted to do : pacman -S base But then cancel the operation. The problem is that, for every package, I got the following question : local version is up to date. Upgrade anyway? I couldn't use --noconfirm , because I didn't want to actually do the operation, only preview it. Also, --noconfirm will answer other questions than this one. Actually, this is exactly the issue that was mentioned in this thread : http://bbs.archlinux.org/viewtopic.php?id=35901 The only way was to use the --ask option, which was too complicated and has been removed. We probably don't need the power of this function anyway. But maybe we could have a replacement, just for this "local version is up to date" question. Or, is this question really useful anyway? How often do we try installing an already installed package, without the intention to reinstall it? Or maybe pacman could just print a warning instead : # pacman -S foo warning : foo is already installed ...

4 8

[pacman-dev] pacman-git releases
by fancris3 23 Nov '07

23 Nov '07

I use pacman-git from 1 or 2 weeks (local build from PKGBUILD) , its fast and stable,good job.Thank you. Name : pacman-git Version : 20071121-1 ... Architecture : x86_64 ... [~]:: pacman -Q|wc -l 1251 :) no problems for pacman [~]:: pacman -Ss|wc -l 9521 this its a feature or a bug? i have made a build for bsc-beta,i have a line: make PREFIX=$startdir/pkg/opt/bsc install || return 1 variable its wrong,makepkg make empty pkg and skip "return 1" make: Nothing to be done for `install'. ==> Tidying install... -> Removing info/doc files... -> Compressing man pages... -> Stripping debugging symbols from binarie ==> Creating package... -> Generating .FILELIST file... -> Generating .PKGINFO file... -> Compressing package... ==> Leaving fakeroot environment. ==> Finished making: bsc-beta (Thu Nov 22 19: in the stable version this thing is working correct and return an error ==> Removing info/doc files... ==> Compressing man pages... ==> Stripping debugging symbols from libraries... ==> Stripping symbols from binaries... ==> Generating .FILELIST file... tar: *: Cannot stat: No such file or directory tar: Error exit delayed from previous errors ==> Generating .PKGINFO file... ==> Compressing package... tar: *: Cannot stat: No such file or directory tar: Error exit delayed from previous errors ==> ERROR: Failed to create package file. also makepkg doesn't work with directory with spaces for example try to build pacman-git in "~/new\ folder/pacman-git"

4 6

[pacman-dev] Usefulness of -F option (was: "local version is up to date. Upgrade anyway?" question)
by Dan McGee 22 Nov '07

22 Nov '07

On Nov 21, 2007 11:46 AM, Xavier <shiningxc(a)gmail.com> wrote: > Except that -F apparently doesn't want to install new packages, only upgrade > existing but outdated ones. > While the option I had in mind for -S would either install new packages, or > upgrading existing but outdated ones. > > But I never used -F once in all the time I used Arch. Who uses this option? > I actually was surprised when I first saw it some times ago. And I already > forgot it existed, since I never see it mentioned anywhere. Does anyone even use -F anymore? I could see its usefullness before sync DBs were introduced, but I do have a hard time seeing its use anymore. Kill it? Any objections? I dislike stale crud sitting around. -Dan

7 12

[pacman-dev] [PATCH] New alpm_list_join function
by Nagy Gabor 22 Nov '07

22 Nov '07

Patch attached Bye ---------------------------------------------------- SZTE Egyetemi Könyvtár - http://www.bibl.u-szeged.hu This mail sent through IMP: http://horde.org/imp/

5 11

[pacman-dev] [PATCH 1/5] Two memleak fixes in pacman.
by Nagy Gabor 21 Nov '07

21 Nov '07

Both memleak was an unfreed alpm_db_whatprovides list. Signed-off-by: Nagy Gabor <ngaba(a)bibl.u-szeged.hu> --- src/pacman/deptest.c | 1 + src/pacman/sync.c | 1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/pacman/deptest.c b/src/pacman/deptest.c index 301558e..d17c821 100644 --- a/src/pacman/deptest.c +++ b/src/pacman/deptest.c @@ -70,6 +70,7 @@ int pacman_deptest(alpm_list_t *targets) break; } } + alpm_list_free(provides); } if(!found) { diff --git a/src/pacman/sync.c b/src/pacman/sync.c index 5f1072f..6f3c5d5 100644 --- a/src/pacman/sync.c +++ b/src/pacman/sync.c @@ -532,6 +532,7 @@ int sync_trans(alpm_list_t *targets, int sync_only) if(prov) { pmpkg_t *pkg = alpm_list_getdata(prov); pname = alpm_pkg_get_name(pkg); + alpm_list_free(prov); break; } } -- 1.5.3.5

6 6

[pacman-dev] FREELIST macros / little memleak fix
by Xavier 21 Nov '07

21 Nov '07

1) I remember having already asked that, but it was probably just on irc, and anyway I forgot what the answer was (if there was one ;)). It's about commit a57b2f233 : http://projects.archlinux.org/git/?p=pacman.git;a=commitdiff;h=a57b2f233f28… What was wrong / messy about these macros : -/* TODO we should do away with these... they're messy*/ -#define _FREELIST(p, f) do { alpm_list_free_inner(p, f); alpm_list_free(p); p = NULL; } while(0) -#define FREELIST(p) _FREELIST(p, free) -#define FREELISTPTR(p) do { alpm_list_free(p); p = NULL; } while(0) +#define FREELIST(p) do { alpm_list_free_inner(p, free); alpm_list_free(p); p = NULL; } while(0) Hm, actually while writing this mail, I realize this it not very problematic :P In the worst case, we just need two little additional calls. But I still don't find these very messy. 2) If I mentioning this, it's because I found a little memleak in _alpm_sync_free: a missing alpm_list_free call. So maybe the above _FREELIST(p, f) macro could have helped. Also, for some reasons, both _alpm_sync_free and _alpm_trans_free did the job of alpm_list_free_inner manually. So I changed that. 3) A little problem : all _alpm_*_free don't match the alpm_list_fn_free prototype except one : _alpm_graph_free . All others don't take a void * argument, so they need to be casted to alpm_list_fn_free for being used with alpm_list_free_inner . So should "static void _alpm_graph_free(void *data)" be changed to "static void _alpm_graph_free(pmgraph_t *graph)" ? >From fdf689932ca1fa919b95533a2469f797f22970f1 Mon Sep 17 00:00:00 2001 From: Chantry Xavier <shiningxc(a)gmail.com> Date: Wed, 21 Nov 2007 17:10:20 +0100 Subject: [PATCH] Fix a memleak in _alpm_sync_free. An alpm_list_free call was missing. Also make use of alpm_list_free_inner in both _alpm_sync_free and _alpm_trans_free. Signed-off-by: Chantry Xavier <shiningxc(a)gmail.com> --- lib/libalpm/sync.c | 7 ++----- lib/libalpm/trans.c | 10 ++-------- 2 files changed, 4 insertions(+), 13 deletions(-) diff --git a/lib/libalpm/sync.c b/lib/libalpm/sync.c index 16b1998..f03a78b 100644 --- a/lib/libalpm/sync.c +++ b/lib/libalpm/sync.c @@ -74,11 +74,8 @@ void _alpm_sync_free(pmsyncpkg_t *sync) /* TODO wow this is ugly */ if(sync->type == PM_SYNC_TYPE_REPLACE) { - alpm_list_t *tmp; - for(tmp = sync->data; tmp; tmp = alpm_list_next(tmp)) { - _alpm_pkg_free(tmp->data); - tmp->data = NULL; - } + alpm_list_free_inner(sync->data, (alpm_list_fn_free)_alpm_pkg_free); + alpm_list_free(sync->data); sync->data = NULL; } else { _alpm_pkg_free(sync->data); diff --git a/lib/libalpm/trans.c b/lib/libalpm/trans.c index 19ae2b6..d998826 100644 --- a/lib/libalpm/trans.c +++ b/lib/libalpm/trans.c @@ -246,8 +246,6 @@ pmtrans_t *_alpm_trans_new() void _alpm_trans_free(pmtrans_t *trans) { - alpm_list_t *i; - ALPM_LOG_FUNC; if(trans == NULL) { @@ -256,13 +254,9 @@ void _alpm_trans_free(pmtrans_t *trans) FREELIST(trans->targets); if(trans->type == PM_TRANS_TYPE_SYNC) { - for(i = trans->packages; i; i = alpm_list_next(i)) { - _alpm_sync_free(i->data); - } + alpm_list_free_inner(trans->packages, (alpm_list_fn_free)_alpm_sync_free); } else { - for(i = trans->packages; i; i = alpm_list_next(i)) { - _alpm_pkg_free(i->data); - } + alpm_list_free_inner(trans->packages, (alpm_list_fn_free)_alpm_pkg_free); } alpm_list_free(trans->packages); -- 1.5.3.6

2 1

[pacman-dev] pacman-git releases
by Dan McGee 21 Nov '07

21 Nov '07

I bumped the version of the i686 version again today, and I've also added an x86_64 build and DB at the same place. http://www.archlinux.org/~dan/pacman-git/ You should be able to figure out the DB name from there. For anyone using the 64-bit version, please let us know just so that we can feel like its actually been tested on that architecture. Aaron- the date on your machine is all messed up, thus the messed up version label on the 64-bit package. :) -Dan

2 1

[pacman-dev] [PATCH] Improved 'dependency cycle' warning
by Nagy Gabor 21 Nov '07

21 Nov '07

Hi! I did a -Su yesterday, and I got 4 dependency cycle warnings. I became curious and I made this little patch (English clarifiaction needed). So I found 4 dependency cycle in our repos; these are not necessarily bugs but imho they worth mentioning: glibc->tzdata->glibc readline->glibc->bash->readline coreutils->shadow->coreutils db->coreutils->pam->db Bye ---------------------------------------------------- SZTE Egyetemi Könyvtár - http://www.bibl.u-szeged.hu This mail sent through IMP: http://horde.org/imp/

3 2