- Pacman-dev - lists.archlinux.org

[pacman-dev] [patch] small speed-up and fix in conflict.c
by Nagy Gabor 13 Aug '07

13 Aug '07

Hi! Patch attached. ngaba

2 1

[pacman-dev] [patch] conflict.c memleak fix
by Nagy Gabor 13 Aug '07

13 Aug '07

Hi! This is just a small memleak fix. Bye, ngaba

3 2

[pacman-dev] [GIT] pacman branch, master now at v3.0.0-336-g47ee89a
by Dan McGee 13 Aug '07

13 Aug '07

Hello, This is an automated email from the git hooks/update script, it was generated because a ref change was pushed to the repository. Updating branch, master, via 47ee89ada9d13935510ef92541649901789c23c8 (commit) via f2c7187e432a3abc732d53e0a9d95f44f9338535 (commit) via 3a0a4db12936199efd0ee1714b7219fab3d83392 (commit) via ab06221521cd38299743f33c3c5a0d81cbd3f589 (commit) via b96922679e4ed14aa687bf194b766d82a1d10577 (commit) via dc5e6d5d87ceee61c38a8ecc2a87e99d49887b83 (commit) via e0ffc60c5310fbc0a8030fee86bf6f3931ba2d6e (commit) via e4f56298be2b2a4da16b1bdb61b08276cdabea27 (commit) via ce10b5f1e2552f2e2f0117b57c7305652ffd4fd1 (commit) via 178c1d228d5b910908e16f9c3715e318d6df4882 (commit) from ea9a756eeaca7398c0860b55f8abe2932ad195bd (commit) - Log ----------------------------------------------------------------- commit 47ee89ada9d13935510ef92541649901789c23c8 Author: Andrew Fyfe <andrew(a)neptune-one.net> Date: Sat Aug 4 01:17:54 2007 +0100 scripts/makepkg.sh.in: Fix 2 bugs - Downloaded files weren't being copied to $srcdir - Counter wasn't being incremented for checksum checks Signed-off-by: Andrew Fyfe <andrew(a)neptune-one.net> commit f2c7187e432a3abc732d53e0a9d95f44f9338535 Author: Chantry Xavier <shiningxc(a)gmail.com> Date: Thu Aug 9 09:36:20 2007 +0200 pacman/sync.c : return 0 on succesful search, 1 otherwise. Closes FS#7690. Signed-off-by: Chantry Xavier <shiningxc(a)gmail.com> commit 3a0a4db12936199efd0ee1714b7219fab3d83392 Author: Nagy Gabor <ngaba(a)petra.hos.u-szeged.hu> Date: Sun Aug 5 17:50:24 2007 +0200 libalpm/conflict.c : small speed-up and fix. Signed-off-by: Chantry Xavier <shiningxc(a)gmail.com> commit ab06221521cd38299743f33c3c5a0d81cbd3f589 Author: Nagy Gabor <ngaba(a)petra.hos.u-szeged.hu> Date: Sat Aug 4 17:11:03 2007 +0200 libalpm/conflict.c : small memleak fix. Signed-off-by: Chantry Xavier <shiningxc(a)gmail.com> commit b96922679e4ed14aa687bf194b766d82a1d10577 Author: Nagy Gabor <ngaba(a)petra.hos.u-szeged.hu> Date: Sat Aug 4 17:08:03 2007 +0200 Add two pactest for versioned conflicts. A side effect of the previous commit ( ea9a756eeaca7398c0860b55f8abe2932ad195bd ) is that it's now possible to use versioned conflicts. Add two new conflict pactests for showing it. Signed-off-by: Chantry Xavier <shiningxc(a)gmail.com> commit dc5e6d5d87ceee61c38a8ecc2a87e99d49887b83 Author: Dan McGee <dan(a)archlinux.org> Date: Mon Jul 30 23:11:32 2007 -0400 Update mtune/mcpu/march comments in makepkg.conf Signed-off-by: Dan McGee <dan(a)archlinux.org> commit e0ffc60c5310fbc0a8030fee86bf6f3931ba2d6e Author: Dan McGee <dan(a)archlinux.org> Date: Thu Jul 26 20:21:38 2007 -0400 Fix re-pacman locale issues Signed-off-by: Dan McGee <dan(a)archlinux.org> commit e4f56298be2b2a4da16b1bdb61b08276cdabea27 Author: Juan Pablo González Tognarelli <jotapesan(a)gmail.com> Date: Thu Jul 26 19:05:57 2007 -0400 Update Spanish translation Signed-off-by: Dan McGee <dan(a)archlinux.org> commit ce10b5f1e2552f2e2f0117b57c7305652ffd4fd1 Author: Andrew Fyfe <andrew(a)neptune-one.net> Date: Wed Jul 25 22:15:02 2007 +0100 Fix gettext output in repo-{add,remove} Signed-off-by: Andrew Fyfe <andrew(a)neptune-one.net> Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 178c1d228d5b910908e16f9c3715e318d6df4882 Author: Dan McGee <dan(a)archlinux.org> Date: Mon Jul 23 16:58:04 2007 -0400 Cleanup of pacman.c and addition of default paths to frontend Instead of barfing when the root path and db path haven't been defined, have pacman set them to some sane defaults when they aren't specified on either the command line or the config file. Also do some cleaning of error output and Doxygen comments. Signed-off-by: Dan McGee <dan(a)archlinux.org> ----------------------------------------------------------------------- Diffstat: contrib/re-pacman | 2 + etc/makepkg.conf.in | 4 +- lib/libalpm/conflict.c | 22 +++------- pactest/tests/conflict002.py | 13 ++++++ pactest/tests/conflict003.py | 13 ++++++ po/es.po | 23 +++++------ scripts/makepkg.sh.in | 3 + scripts/repo-add.sh.in | 29 ++++++------- scripts/repo-remove.sh.in | 21 +++++----- src/pacman/Makefile.am | 3 + src/pacman/pacman.c | 91 +++++++++++++++++++++++------------------ src/pacman/sync.c | 5 ++- 12 files changed, 133 insertions(+), 96 deletions(-) hooks/update --- Git Source Code Management System hooks/update refs/heads/master \ ea9a756eeaca7398c0860b55f8abe2932ad195bd \ 47ee89ada9d13935510ef92541649901789c23c8

1 0

[pacman-dev] [patch] for sync1003.py
by Nagy Gabor 06 Aug '07

06 Aug '07

Hi! Patch attached. NOTE: this affects resolvedeps too. TODO: I did a dirty hack in sync_prepare (now sync990.py fails), I will clean it up later. Bye, ngaba

4 10

Re: [pacman-dev] [patch] for sync1003.py
by ngaba＠bibl.u-szeged.hu 03 Aug '07

03 Aug '07

> TODO: I did a dirty hack in sync_prepare (now sync990.py fails), I will Well, that patch is broken: pkg3 should be installed (pkg1 needs it.) Bye, ngaba ---------------------------------------------------- SZTE Egyetemi Könyvtár - http://www.bibl.u-szeged.hu This mail sent through IMP: http://horde.org/imp/

1 0

[pacman-dev] sync_prepare clean-up III, TODO
by Nagy Gabor 30 Jul '07

30 Jul '07

Hi! Well, the remaining part is very messy and disappointing: The whole conflict checking should be refactored: as I assume this wants to do something similar to checkdeps(...TRANS_TYPE_UPDATE), but that is buggy: this should be fixed as deps.c (conflict001.py shows this.) However, as Xavier said earlier a new data stucture is needed for conflicts; and all conflict resolve stuff should be moved to conflict.c. The second pactest file shows checkdeps cannot get enough information from sync.c to figure out if there is any broken dependency: it should know BOTH the remove and upgrade list to decide properly. Well, both of this bugs needs hard work: a proper conflict resolution is a difficult (probably recursive) problem, it would be easier to let user do this work manually. Bye, ngaba PS: I don't like inefficient pmsyncpkg_t neither.

3 13

[pacman-dev] pacman_deptest function
by Xavier 28 Jul '07

28 Jul '07

I've benn looking at that function again, and here is what I saw in Andrew's commit : +/* TODO: This should use _alpm_checkdeps() */ int pacman_deptest(alpm_list_t *targets) As I tried to explain there : http://www.archlinux.org/pipermail/pacman-dev/2007-June/008654.html checkdeps isn't really what we want. Here, we just want to check that a list of dependencies from the PKGBUILD is already installed locally. checkdeps however checks if we can install a package, by checking its dependencies. And checkdeps gets this information from the sync or local databases, it can't really get the deps list from an external PKGBUILD. But there is at least one way to do that, it's creating a dummy package, with the same list of dependencies as in the PKGBUILD, and work with that in libalpm. I looked at the history of deptest(), and it's actually what Aurelien did at some point : http://projects.archlinux.org/git/?p=pacman.git;a=commit;h=0756af675d6b99a1… http://projects.archlinux.org/git/?p=pacman.git;a=commit;h=cda9c6671ced31a7… But it was rather messy, so Aaron cleaned that : http://projects.archlinux.org/git/?p=pacman.git;a=commit;h=4dd6c9222879198e… So well, I still have the same opinion that in my earlier answer to Andrew, what pacman_deptest does is just the mythic "search for satisfier" function that Nagy has been talked about for ages, and that is used everywhere in the code :)

2 2

[pacman-dev] Issue while testing largefile support
by Dan McGee 28 Jul '07

28 Jul '07

Interesting debug output while testing largefile support in pacman (http://bugs.archlinux.org/task/7578) [14:55:58] debug: config: finished parsing /usr/local/etc/pacman.conf [14:55:58] debug: registering database 'local' [14:55:58] debug: opening database 'local' [14:55:58] debug: opening database from path '/usr/local/var/lib/pacman/local/' loading package data... [14:55:58] debug: loading target 'largepackage-1-3-i686.pkg.tar.gz' [14:55:58] debug: reading 'largepackage' metadata done. checking dependencies... [14:56:58] debug: looking for unsatisfied dependencies [14:56:58] debug: loading package cache for repository 'local' [14:56:58] debug: cannot find package installed 'largepackage' [14:56:58] debug: looking for conflicts [14:56:58] debug: checkconflicts: db vs target 'largepackage' [14:56:59] debug: sorting by dependencies [14:56:59] debug: started sorting dependencies [14:56:59] debug: sorting dependencies finished done. checking for file conflicts... [14:56:59] debug: looking for file conflicts [14:56:59] debug: searching for filesystem conflicts: largepackage [14:56:59] debug: /opt/ is a directory, not a conflict [14:56:59] debug: /opt/largefile is a directory, not a conflict done. installing largepackage... [14:56:59] debug: adding package largepackage-1-3 [14:56:59] debug: extracting files [14:56:59] debug: decompression progress: 0.001907% (40960 / -2146827972) [14:56:59] debug: decompression progress: 0.001907% (40960 / -2146827972) [14:56:59] debug: decompression progress: 0.001907% (40960 / -2146827972) [14:56:59] debug: extracting /opt/ [14:56:59] debug: warning extracting opt/ (Already exists: File exists) [14:56:59] debug: decompression progress: 0.001907% (40960 / -2146827972) [14:56:59] debug: extracting /opt/largefile [14:59:25] debug: updating database [14:59:25] debug: adding database entry 'largepackage' [14:59:25] debug: writing largepackage-1-3 DESC information back to db [14:59:25] debug: writing largepackage-1-3 FILES information back to db [14:59:25] debug: writing largepackage-1-3 DEPENDS information back to db [14:59:25] debug: adding entry 'largepackage' in 'local' cache [14:59:25] debug: package has no dependencies, no other packages to update done. [14:59:25] debug: running "ldconfig -r /" Here is the package filelist: opt/ (directory) opt/largefile (a 2GB sized normal file) Notice what the above output says- that /opt/largefile is a directory, not a conflict. Clearly a problem here. This is pacman built off my working branch, so not including any recent patches from Andrew or Chantry with regards to the overwrite stuff. -Dan

4 9

[pacman-dev] Pointless public/private functions
by Andrew Fyfe 27 Jul '07

27 Jul '07

Throughout the libalpm and pacman code there's a lot of public functions that simply wrap a private function (maybe with some asserts). What's the point? Why not have the asserts in the private function and make the private function public reducing the number of function being called? Andrew

3 2

[pacman-dev] Parsing config file question
by Andrew Fyfe 27 Jul '07

27 Jul '07

Why does pacman do this... if(strcmp(key, "ShowSize") == 0 || strcmp(upperkey, "SHOWSIZE") == 0) Is there any reason why we can't do... if(strcmp(upperkey, "SHOWSIZE") == 0) Andrew PS Just found the ILoveCandy option :D

3 4