- Pacman-dev - lists.archlinux.org

[pacman-dev] Alternatives system
by Allan McRae 06 Dec '20

06 Dec '20

Hi all, I plan to finish implementing an alternatives system for pacman post 5.2 release: https://wiki.archlinux.org/index.php/User:Allan/Alternatives Any comments or suggestions? Thanks, Allan

6 7

[pacman-dev] [GIT] The official pacman repository tag, last-deltapkgs-commit, created. v5.1.1-144-g377d4714
by Allan McRae 04 Dec '20

04 Dec '20

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The tag, last-deltapkgs-commit has been created at 377d47142f7aaa01ca782e6587f2d4caf663865b (commit) - Log ----------------------------------------------------------------- commit 377d47142f7aaa01ca782e6587f2d4caf663865b Author: Jelle van der Waa <jelle(a)vdwaa.nl> Date: Thu Feb 21 13:20:19 2019 +0100 doc: add man page for pacman-conf Signed-off-by: Jelle van der Waa <jelle(a)vdwaa.nl> Signed-off-by: Allan McRae <allan(a)archlinux.org> ----------------------------------------------------------------------- hooks/post-receive -- The official pacman repository

2 2

[pacman-dev] [GIT] The official pacman repository annotated tag, v6.0.0alpha1, created. v6.0.0alpha1
by Allan McRae 04 Dec '20

04 Dec '20

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The annotated tag, v6.0.0alpha1 has been created at 09b67861d9c550b0de411f95f36421d48c524499 (tag) tagging a4240a55e448ffba15a5edbad1a31cb76f821231 (commit) replaces v5.2.1 tagged by Allan McRae on Fri Dec 4 13:36:09 2020 +1000 - Log ----------------------------------------------------------------- Time to road-test the new downloader code -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEZkWwqMcAXnjbHXhk+Z/+D+rpmb0FAl/Jrs8ACgkQ+Z/+D+rp mb3T8gf/e6W1zu0Uhs2HqzqTvZHCIHnROKNSMBH/h3iA1iavwqS6fvnZXqOcsIEC 02Nk8H9Tu4V0EIDWck9wjAGddtQNeR1w3/ljaEZmazILH8mUYbHu4t/VSJH68JgP EBF2BhEL6Ut2g2YuYOZSrIjC6cSdJ7j3uxM7ltuhZibCvux8Q2UxbFdncTvyB6ql 2L2cKWl9RURXu72+JGdGY5xyAv5KG5mwKyEPieWBV5+Mhb5iCDFfH9ILVO/XCwK8 Gv+bb4UT+IZ+UO9zj/rVl07lqqiGf8Ynj2DsdK6t7Vx1QIV+ms6ru27EqcKVkumr P2LRogLuerYf5CrO/I5saaf+B/LZtg== =4C8n -----END PGP SIGNATURE----- Allan McRae (31): Move update-copyright into build-aux Remove "Generated from ...; do not edit by hand" from scripts libalpm/sync.c: Do not download missing keys multiple times pactest: set package tar format to GNU_FORMAT Handle .part files that are the size of the correct package Add Eli to current maintainers Fix leak in _alpm_db_search on error condition Improved documentation for alpm_db_search() parameters Fix documentation of alpm_mtree_next and remove libarchive exposure tests: Fix typo in test description Increase meson test timeout Remove unneeded ltmain patch Increase maximum database size Fix "pacman -U <url>" operations Note that checksums from "makepkg -g" are not ideal makepkg: add CRC checksums and set these to be the default Add pacman-hooks.5 man page symlink build-aux/update-copyright 2019 2020 Remove unneeded goto cleanup Add file and line number to RET_ERR{,_VOID} Use STRDUP for error checking in more places Use GOTO_ERR throughout pacman.8: Fix typo Add Gitlab Runner configuration Convert gitlab valgrind runner to meson Remove autotools support libalpm/signing.c: Fix calculation of packet size in parse_subpacket Revert "makepkg: drop duplicate reporting of missing dependencies" pacman-key: change signing key to RSA4096 makepkg.conf: Reword "Defaults" Modify "pacman -h" output for files operations Anatol Pomozov (33): Eliminate extra loop over dbs_sync Simplify construction of payloads in download_files Do not download files if find_dl_candidates() fails Move flushing 'output' list into separate function Add GOTO_ERR() macro to set error and then goto a label Hide cursor while pacman is running Add config option to specify amount of parallel download streams Introduce alpm_dbs_update() function for parallel db updates Add multi_curl handle to ALPM global context Inline dload_payload->curlerr field into a local variable Implement _alpm_multi_download Implement multiplexed download using mCURL Introduce event types for start/end database list download Extend download callback interface with start/complete events Implement multibar UI Convert download packages logic to multiplexed API Convert downloading databases to the new multiplexed API Swap alpm_db_update() implementation to multiplexed version Convert '-U pkg1 pkg2' codepath to parallel download Cleanup the old sequential download code Move signature payload creation to download engine Do not use counter for error tracking Add a utility function to check whether a file exists in the cache FS#33992: force download *.sig file if it does not exist in the cache Fallback to detached signatures during keyring check Build signature remote name based on the main payload name Do not free payload fields in the middle of this structure use Check that destfile_name exists before using it Fix error during keyring checking Enable sha256/md5 hash verification if detached signatures are used FS#66472: Remove *.sig file if package corrupted Go to the end of screen if 'printonly' mode enabled Move cursor to the end of the screen at the SIGINT Carson Black (1): Dull version colour numbers in summary Chih-Hsuan Yen (1): util.c: table_print_line: properly align texts involving CJK Colin Woodbury (1): Restore usage line for -Fh Daniel T. Borelli (1): Dereference double pointer before assigning NULL Dave Reisner (5): Ensure regex object is always initialized Use c99 struct initialization to avoid memset calls makepkg: drop duplicate reporting of missing dependencies meson: handle XFAIL tests outside of TAP Avoid depending on side effects in assert(...) expressions Denton Liu (1): srcinfo.sh: remove trailing newline Earnestly (1): Use noextract with pacman-conf NoExtract Eli Schwartz (30): scripts/library: remove human_to_size build: remove use of handcrafted m4 in configuring scripts makepkg: fix regression that broke extraction of file:// sources meson: make non-symlink scripts install for real, and use a better wrapper pactest: add environment option to run tests with valgrind makepkg: add the $startdir to package .BUILDINFO autotools: emit error message when autoconf-archive is missing doc: clarify the format of a PKGBUILD source fragment doc: reformat intro to VCS sources to distinguish the grammar makepkg: make per-package files containing '$pkgname' consistently work meson: use better check for debug builds editorconfig: set meson indentation style doc: remove vim modelines from BUILDINFO(5) pacman-conf: add support for new ParallelDownloads config option pacman-conf: fix incomplete support for ILoveCandy Log invalid conf settings as an error libmakepkg/strip: don't re-add the same debug source multiple times build: add libintl dependency to meson and the .pc file makepkg: guard against undefined git pinned sources makepkg: correctly handle missing download clients libmakepkg: fix regression in sending plain() output to stderr makepkg/repo-add: handle GPGKEY with spaces makepkg/repo-add: do not accept public-only keys for signing doc/pacman.8: fix typo libmakepkg: extend compress.sh to also permit checking validity repo-add: use more libmakepkg to handle common compression routines remove more autotools files makepkg: libprovides: don't provide both versioned and unversioned sonames makepkg: fix signing of source packages makepkg: properly localize some internal function variables Ethan Sommer (5): libmakepkg: add optional argument support to parseopts libmakepkg: fix empty arguments in parseopts makepkg: replaces sed in-place with built in substitution repo-add: use wc -c on stdin instead of file to avoid use of cut libmakepkg: use readelf instead of file for finding ELF file types Filipe Laíns (1): ci: cache packages Ivy Foster (2): Add NoProgressbar to pacman.conf options Add fossil scm support to makepkg Levente Polyak (1): makepkg: deterministic PKGINFO libprovides for multiple library versions Matthew Sexton (2): pacman-key: hide lsign and revoke output behind --verbose pacman-key: ignore already lsigned/deleted keys Michael Straube (2): makepkg: emptydirs: fix typo libmakepkg: compress: fix tar extension Morten Linderud (1): doc/makepkg.8: Added punctuations. Rikard Falkeborn (2): Add REALLOC macro to simplify realloc error handling Constify some input pointers Ronan Pigott (1): Add pacman-conf zsh completions morganamilo (12): pacman: clarify error when alpm fails to init pacman: make exact_file an int pacman+libalpm: handle search errors pacman: print error when -Fx is given invalid regex libalpm: fix alpm_option_set_assumeinstalled Docs docs docs libalpm: set parallel_downloads to 1 when creating the handle libalpm: don't call dlcb when not set libalpm: clarify alpm_download_event_completed_t status libalpm: set errno when setting parallel downloads with an invalid number libalpm: add alpm_option_get_parallel_downloads libalpm: set ret in download files ----------------------------------------------------------------------- hooks/post-receive -- The official pacman repository

1 0

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v5.2.1-134-ga4240a55
by Allan McRae 03 Dec '20

03 Dec '20

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, master has been updated via a4240a55e448ffba15a5edbad1a31cb76f821231 (commit) via 20f2ae56eb4ae1affd274185c173524f5b4fb2f1 (commit) via 5c24f7dd11a241f6414e3ee6f95f224382ec27ce (commit) from 08f4ae709ca00ec9b4c56d92d3cdd7de4e6effc2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a4240a55e448ffba15a5edbad1a31cb76f821231 Author: Colin Woodbury <colin(a)fosskers.ca> Date: Wed Nov 25 12:53:11 2020 -0800 Restore usage line for -Fh Unlike the other main commands, -F was missing its top-level usage line in its help output. Signed-off-by: Colin Woodbury <colin(a)fosskers.ca> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 20f2ae56eb4ae1affd274185c173524f5b4fb2f1 Author: Allan McRae <allan(a)archlinux.org> Date: Thu Dec 3 21:34:01 2020 +1000 Modify "pacman -h" output for files operations pacman -F can take both a file(s) or a package(s) as arguments. Passing a file is more common, so adjust to show that in the help. Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 5c24f7dd11a241f6414e3ee6f95f224382ec27ce Author: morganamilo <morganamilo(a)archlinux.org> Date: Mon Nov 30 18:21:26 2020 +0000 libalpm: set ret in download files download_files never set ret on failiure, so even when downloading fails, the transaction goes on to commit and error out. :: Retrieving packages... python-packaging-20.4-4-any.pkg.tar.zst failed to download error: failed retrieving file 'python-packaging-20.4-4-any.pkg.tar.zst' from mirror.oldsql.cc : The requested URL returned error: 404 warning: failed to retrieve some files (1/1) checking keys in keyring (1/1) checking package integrity error: failed to commit transaction (wrong or NULL argument passed) Errors occurred, no packages were upgraded. Also make the ret checking more consistent. Signed-off-by: Allan McRae <allan(a)archlinux.org> ----------------------------------------------------------------------- Summary of changes: lib/libalpm/sync.c | 6 ++++-- src/pacman/pacman.c | 4 +++- 2 files changed, 7 insertions(+), 3 deletions(-) hooks/post-receive -- The official pacman repository

1 0

[pacman-dev] [PATCH] Restore usage line for -Fh
by Colin Woodbury 03 Dec '20

03 Dec '20

Unlike the other main commands, -F was missing its top-level usage line in its help output. Signed-off-by: Colin Woodbury <colin(a)fosskers.ca> --- src/pacman/pacman.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/pacman/pacman.c b/src/pacman/pacman.c index fefd3fa4..69e2e42a 100644 --- a/src/pacman/pacman.c +++ b/src/pacman/pacman.c @@ -176,6 +176,8 @@ static void usage(int op, const char * const myname) printf("%s: %s {-T --deptest} [%s] [%s]\n", str_usg, myname, str_opt, str_pkg); printf("%s:\n", str_opt); } else if(op == PM_OP_FILES) { + printf("%s: %s {-F --files} [%s] [%s]\n", str_usg, myname, str_opt, str_pkg); + printf("%s:\n", str_opt); addlist(_(" -l, --list list the files owned by the queried package\n")); addlist(_(" -q, --quiet show less information for query and search\n")); addlist(_(" -x, --regex enable searching using regular expressions\n")); -- 2.29.2

2 3

[pacman-dev] [PATCH] Modify "pacman -h" output for files operations
by Allan McRae 03 Dec '20

03 Dec '20

pacman -F can take both a file(s) or a package(s) as arguments. Passing a file is more common, so adjust to show that in the help. Signed-off-by: Allan McRae <allan(a)archlinux.org> --- src/pacman/pacman.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pacman/pacman.c b/src/pacman/pacman.c index fefd3fa4..f98c9a4a 100644 --- a/src/pacman/pacman.c +++ b/src/pacman/pacman.c @@ -110,7 +110,7 @@ static void usage(int op, const char * const myname) printf(" %s {-h --help}\n", myname); printf(" %s {-V --version}\n", myname); printf(" %s {-D --database} <%s> <%s>\n", myname, str_opt, str_pkg); - printf(" %s {-F --files} [%s] [%s]\n", myname, str_opt, str_pkg); + printf(" %s {-F --files} [%s] [%s]\n", myname, str_opt, str_file); printf(" %s {-Q --query} [%s] [%s]\n", myname, str_opt, str_pkg); printf(" %s {-R --remove} [%s] <%s>\n", myname, str_opt, str_pkg); printf(" %s {-S --sync} [%s] [%s]\n", myname, str_opt, str_pkg); -- 2.29.2

1 0

[pacman-dev] [PATCH] lock file may be left behind when a signal arrives while in cleanup
by lilydjwg 03 Dec '20

03 Dec '20

When a SIGINT or SIGHUP arrives before alpm_unlock (in alpm_release) but after remove_soft_interrupt_handler, the lock file will be left behind. Signed-off-by: lilydjwg <lilydjwg(a)gmail.com> --- src/pacman/pacman.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pacman/pacman.c b/src/pacman/pacman.c index fefd3fa4..2d2e41d2 100644 --- a/src/pacman/pacman.c +++ b/src/pacman/pacman.c @@ -287,7 +287,6 @@ static void setuseragent(void) */ static void cleanup(int ret) { - remove_soft_interrupt_handler(); if(config) { /* free alpm library resources */ if(config->handle && alpm_release(config->handle) == -1) { @@ -297,6 +296,7 @@ static void cleanup(int ret) config_free(config); config = NULL; } + remove_soft_interrupt_handler(); /* free memory */ FREELIST(pm_targets); -- 2.28.0

2 4

[pacman-dev] [PATCH] libalpm: set ret in download files
by morganamilo 30 Nov '20

30 Nov '20

download_files never set ret on failiure, so even when downloading fails, the transaction goes on to commit and error out. :: Retrieving packages... python-packaging-20.4-4-any.pkg.tar.zst failed to download error: failed retrieving file 'python-packaging-20.4-4-any.pkg.tar.zst' from mirror.oldsql.cc : The requested URL returned error: 404 warning: failed to retrieve some files (1/1) checking keys in keyring (1/1) checking package integrity error: failed to commit transaction (wrong or NULL argument passed) Errors occurred, no packages were upgraded. Also make the ret checking more consistent. diff --git a/lib/libalpm/sync.c b/lib/libalpm/sync.c index 601f1d69..5d8652a5 100644 --- a/lib/libalpm/sync.c +++ b/lib/libalpm/sync.c @@ -769,7 +769,7 @@ static int download_files(alpm_handle_t *handle) } ret = find_dl_candidates(handle, &files); - if(ret) { + if(ret != 0) { goto finish; } @@ -818,7 +818,9 @@ static int download_files(alpm_handle_t *handle) payloads = alpm_list_add(payloads, payload); } - if(_alpm_download(handle, payloads, cachedir) == -1) { + + ret = _alpm_download(handle, payloads, cachedir); + if(ret != 0) { event.type = ALPM_EVENT_PKG_RETRIEVE_FAILED; EVENT(handle, &event); _alpm_log(handle, ALPM_LOG_WARNING, _("failed to retrieve some files\n")); -- 2.29.2

3 2

[pacman-dev] [PATCH 1/5] libalpm: set parallel_downloads to 1 when creating the handle
by morganamilo 28 Nov '20

28 Nov '20

Fixes FS#68729 diff --git a/lib/libalpm/alpm.c b/lib/libalpm/alpm.c index 34c5b4b2..5d36136d 100644 --- a/lib/libalpm/alpm.c +++ b/lib/libalpm/alpm.c @@ -61,6 +61,8 @@ alpm_handle_t SYMEXPORT *alpm_initialize(const char *root, const char *dbpath, /* set default database extension */ STRDUP(myhandle->dbext, ".db", goto nomem); + myhandle->parallel_downloads = 1; + lockfilelen = strlen(myhandle->dbpath) + strlen(lf) + 1; MALLOC(myhandle->lockfile, lockfilelen, goto nomem); snprintf(myhandle->lockfile, lockfilelen, "%s%s", myhandle->dbpath, lf); -- 2.29.2

3 9

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v5.2.1-131-g08f4ae70
by Allan McRae 26 Nov '20

26 Nov '20

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, master has been updated via 08f4ae709ca00ec9b4c56d92d3cdd7de4e6effc2 (commit) via 73e0d7dedc197f71c4fd6b7c18d2b2f2d63bf013 (commit) via 66f9f315cf36a5b73c18c627f7cee060a1360abd (commit) via 75cfce94682fcd0e9bbeed5db1f97dbb5b1be9e7 (commit) via 4b8c274f7fc1ecd8cee9176471f081da3323b258 (commit) via 9dc29ebf5f3c6fe34b5a1b60f6f57f88668d9d20 (commit) via db4092e33dacc6a0bb8afd283a82e6f4327cb865 (commit) via 2859a6eefcb465a382267c6e5981192c6a54f5bb (commit) via 94ac3330dd3a42958ad5d9606ec254bc112936bf (commit) from 4d8f58d3b940f778b27c59e53ea9f3fab20a07ba (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 08f4ae709ca00ec9b4c56d92d3cdd7de4e6effc2 Author: Ivy Foster <escondida(a)iff.ink> Date: Wed Nov 25 22:38:24 2020 -0600 Add fossil scm support to makepkg Signed-off-by: Ivy Foster <escondida(a)iff.ink> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 73e0d7dedc197f71c4fd6b7c18d2b2f2d63bf013 Author: morganamilo <morganamilo(a)archlinux.org> Date: Tue Nov 24 12:39:08 2020 +0000 libalpm: add alpm_option_get_parallel_downloads Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 66f9f315cf36a5b73c18c627f7cee060a1360abd Author: morganamilo <morganamilo(a)archlinux.org> Date: Tue Nov 24 12:39:07 2020 +0000 libalpm: set errno when setting parallel downloads with an invalid number Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 75cfce94682fcd0e9bbeed5db1f97dbb5b1be9e7 Author: morganamilo <morganamilo(a)archlinux.org> Date: Tue Nov 24 12:39:06 2020 +0000 libalpm: clarify alpm_download_event_completed_t status The comment makes it seem that the result itself is an error code. But all it does is simply return -1 to indicate an error occured; Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 4b8c274f7fc1ecd8cee9176471f081da3323b258 Author: morganamilo <morganamilo(a)archlinux.org> Date: Tue Nov 24 12:39:05 2020 +0000 libalpm: don't call dlcb when not set Fixes FS#68728: Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 9dc29ebf5f3c6fe34b5a1b60f6f57f88668d9d20 Author: morganamilo <morganamilo(a)archlinux.org> Date: Tue Nov 24 12:39:04 2020 +0000 libalpm: set parallel_downloads to 1 when creating the handle Fixes FS#68729 Signed-off-by: Allan McRae <allan(a)archlinux.org> commit db4092e33dacc6a0bb8afd283a82e6f4327cb865 Author: Anatol Pomozov <anatol.pomozov(a)gmail.com> Date: Tue Nov 3 17:04:38 2020 -0800 Move cursor to the end of the screen at the SIGINT It requires exposing 'move cursor to the end' function in a pacman header file. We use it as a chance to make naming of the cursor management functions more consistent. Note that there is still possibility of a race condition in the cursor update logic. 'update cursor index variable' and 'send ASCII control symbols to console' is not an atomic operation. So if an SIGINT is received between these two action then cursor position is going to be screwed. Fixes FS#67973 Signed-off-by: Anatol Pomozov <anatol.pomozov(a)gmail.com> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 2859a6eefcb465a382267c6e5981192c6a54f5bb Author: Anatol Pomozov <anatol.pomozov(a)gmail.com> Date: Thu Oct 22 09:31:14 2020 -0700 Go to the end of screen if 'printonly' mode enabled At the end of download operation our code makes sure the cursor is moved to the end of the drawing area. But 'printonly' mode has its own if() branch that skips this cursor alignment. Add cursor_goto_end() to the 'printonly' codepath to make sure it does not clobber previous output. Fixes FS#68355 Signed-off-by: Anatol Pomozov <anatol.pomozov(a)gmail.com> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 94ac3330dd3a42958ad5d9606ec254bc112936bf Author: Michael Straube <michael.straubej(a)gmail.com> Date: Wed Oct 21 10:05:43 2020 +0200 libmakepkg: compress: fix tar extension With commit 74aacf44958e1343b910b3fbdcf753393857f070 creating uncompressed .tar packages fails. -> Compressing package... /usr/share/makepkg/util/compress.sh: line 70: COMPRESS.TAR[@]: invalid variable name bsdtar: Write error Empty the '$ext' variable for the '.tar' extension in get_compress_command() to fix this. We would fallback to cat for 'tar' anyways. Signed-off-by: Michael Straube <michael.straubej(a)gmail.com> Signed-off-by: Allan McRae <allan(a)archlinux.org> ----------------------------------------------------------------------- Summary of changes: doc/PKGBUILD.5.asciidoc | 3 + etc/makepkg.conf.in | 1 + lib/libalpm/alpm.c | 2 + lib/libalpm/alpm.h | 8 +- lib/libalpm/dload.c | 4 +- lib/libalpm/handle.c | 14 +++- scripts/libmakepkg/executable/vcs.sh.in | 2 +- .../libmakepkg/source/{git.sh.in => fossil.sh.in} | 96 ++++++++++------------ scripts/libmakepkg/source/meson.build | 1 + scripts/libmakepkg/util/compress.sh.in | 3 + scripts/libmakepkg/util/source.sh.in | 5 +- src/pacman/callback.c | 23 +++--- src/pacman/sighandler.c | 3 + src/pacman/util.h | 1 + 14 files changed, 91 insertions(+), 75 deletions(-) copy scripts/libmakepkg/source/{git.sh.in => fossil.sh.in} (51%) hooks/post-receive -- The official pacman repository

1 0