February 2007 - Pacman-dev - lists.archlinux.org

[pacman-dev] INFRQ_* confusion
by Nagy Gabor 10 Mar '07

10 Mar '07

Hi! The constants defined in db.h are not usual: First, it seems logical, that NONE==0x0, ALL=0xFF. However you may forget about this, like be_files.c (row 222): "if(info->infolevel & inforeq) { /* already loaded this info, do nothing */ return(0); }" As I see, the author thinks of inforeq as exactly one bit is set to 1. However, if inforeq=0xFF and infolevel!=0, this is a bug. And if inforeq=0, this condition is never true. Bye.

3 7

[pacman-dev] more efficient use of db_cache needed
by Nagy Gabor 04 Mar '07

04 Mar '07

Hi! It's common practise that you load pkgcache with INFRQ_DEPENDS or similar which is slow, because you must read the whole db directory. Instead it would be more optimal, if you'd load db_cache with INFRQ_NONE almost always (in case of thransactions where only few packages are affected), because that is very fast (name and version are computed from the directory name, so you need to read only the root directory of the repo). And if you find the required package by name, you can read the required info. So first _alpm_db_scan with INFRQ_NONE then _alpm_db_read Bye, Nagy Gabor

3 6

[pacman-dev] 20070228 Italian Translation patch
by Giovanni Scafora 01 Mar '07

01 Mar '07

Hi Dan, there is a new patch for libalpm italian translation with some corrections and improvements. Thanks. -- Giovanni Scafora Arch Linux Trusted User (voidnull) http://www.archlinux.org linuxmania(a)gmail.com

2 2

[pacman-dev] CVS update of pacman-lib/pactest (pmenv.py tests/upgrade056.py)
by Dan McGee 01 Mar '07

01 Mar '07

Date: Tuesday, February 27, 2007 @ 14:44:45 Author: dan Path: /home/cvs-pacman/pacman-lib/pactest Added: tests/upgrade056.py (1.1) Modified: pmenv.py (1.6 -> 1.7) * Added another test- I believe it is a possible situation and one we need to deal with. Currently, libalpm with AND without Nagy's patch fails it. * Slight spacing update to pmenv.py. ---------------------+ pmenv.py | 2 +- tests/upgrade056.py | 24 ++++++++++++++++++++++++ 2 files changed, 25 insertions(+), 1 deletion(-) Index: pacman-lib/pactest/pmenv.py diff -u pacman-lib/pactest/pmenv.py:1.6 pacman-lib/pactest/pmenv.py:1.7 --- pacman-lib/pactest/pmenv.py:1.6 Mon Feb 26 03:19:02 2007 +++ pacman-lib/pactest/pmenv.py Tue Feb 27 14:44:45 2007 @@ -107,7 +107,7 @@ print "[PASSED]", else: print "[FAILED]", - print "%s Rules:OK = %2u FAIL = %2u SKIP = %2u" \ + print "%s Rules: OK = %2u FAIL = %2u SKIP = %2u" \ % (test.testname.ljust(32), success, fail, rules - (success + fail)) print "=========="*8 Index: pacman-lib/pactest/tests/upgrade056.py diff -u /dev/null pacman-lib/pactest/tests/upgrade056.py:1.1 --- /dev/null Tue Feb 27 14:44:45 2007 +++ pacman-lib/pactest/tests/upgrade056.py Tue Feb 27 14:44:45 2007 @@ -0,0 +1,24 @@ +self.description = "Upgrade a package that removes a provide but another package still does" + +lp1 = pmpkg("pkg1") +lp1.depends = ["imaginary"] +self.addpkg2db("local", lp1) + +lp2 = pmpkg("pkg2") +lp2.provides = ["imaginary"] +lp2.requiredby = [ "pkg1" ] +self.addpkg2db("local", lp2) + +lp3 = pmpkg("pkg3") +lp3.provides = ["imaginary"] +self.addpkg2db("local", lp3) + +p = pmpkg("pkg2", "1.0-2") +self.addpkg(p) + +self.args = "-U %s" % p.filename() + +self.addrule("PACMAN_RETCODE=0") +self.addrule("PKG_EXIST=pkg1") +self.addrule("PKG_VERSION=pkg2|1.0-2") +self.addrule("PKG_EXIST=pkg3")

7 19

[pacman-dev] RC 2007.02.16
by Aaron Griffin 28 Feb '07

28 Feb '07

Latest and greatest. Not all that many changes here.. -Si works with the repo/package syntax, spacing on the "saving as .pacsave" output is fixed, etc Mostly minor. Test it out: http://archlinux.org/~aaron/pacman/pacman-rc-2007.02.16-1-i686.pkg.tar.gz There is only one pending bug here, it's listed in the bugcatcher here: http://bugs.archlinux.org/task/6316 If anyone can reproduce that, let me know. I'm still trying to track that one down. Thanks guys!

6 19

[pacman-dev] 'replaces' confusion
by Aaron Griffin 28 Feb '07

28 Feb '07

So it appears the backend and pactest are both a little confused about where 'replaces' belongs. If we look at a current repo, 'replaces' is listed in the /desc file: $ cat /var/lib/pacman/current/gawk-3.1.5-3/desc %NAME% gawk %VERSION% 3.1.5-3 %DESC% Gnu version of awk %CSIZE% 552398 %MD5SUM% 4f539bb7ba6bb3328a2891ecf4ad2caf %REPLACES% mawk However, it appears that libalpm actually *writes* this info to the /depends file - replaces info is NOT written to the local DB. Please note that it appears this code is never actually hit. The db_write routine is not currently used when unpacking a remote DB, it is mostly untarred directly. In the future, however, this routine WILL be used to write DB info, so it is important to figure this out now: Where does 'replaces' info belong? I leave the question open, because i have no opinion, but I'd like to do this right - where does it fit best? The /depends file seems more appropriate, as it contains all the "list" info already. Anyone have an opinion?

6 21

[pacman-dev] CVS update of pacman-lib (7 files)
by Dan McGee 28 Feb '07

28 Feb '07

Date: Wednesday, February 28, 2007 @ 11:37:24 Author: dan Path: /home/cvs-pacman/pacman-lib Modified: lib/libalpm/be_files.c (1.31 -> 1.32) lib/libalpm/package.c (1.78 -> 1.79) pactest/pmdb.py (1.4 -> 1.5) pactest/pmenv.py (1.7 -> 1.8) pactest/pmfile.py (1.3 -> 1.4) pactest/pmrule.py (1.4 -> 1.5) pactest/util.py (1.3 -> 1.4) * Unifying placement of REPLACES in desc file, as pacman2 does. We'll worry about bigger DB changes later, but lets not screw anything up for release. * Removed some weird uses of "not ... ==" usage in pactest- correct me if I'm wrong, but isn't "!=" a lot more clean and concise? * Print description of failed tests in the pactest summary. This could get dirty with a lot of failed tests though, so watch out. ------------------------+ lib/libalpm/be_files.c | 21 ++++++++++----------- lib/libalpm/package.c | 3 ++- pactest/pmdb.py | 25 ++++++++++++++----------- pactest/pmenv.py | 11 ++++++++--- pactest/pmfile.py | 4 ++-- pactest/pmrule.py | 2 +- pactest/util.py | 9 +++++---- 7 files changed, 42 insertions(+), 33 deletions(-) Index: pacman-lib/lib/libalpm/be_files.c diff -u pacman-lib/lib/libalpm/be_files.c:1.31 pacman-lib/lib/libalpm/be_files.c:1.32 --- pacman-lib/lib/libalpm/be_files.c:1.31 Mon Feb 26 03:38:48 2007 +++ pacman-lib/lib/libalpm/be_files.c Wed Feb 28 11:37:24 2007 @@ -365,10 +365,6 @@ if(fgets(info->md5sum, sizeof(info->md5sum), fp) == NULL) { goto error; } - /* XXX: these are only here as backwards-compatibility for pacman 2.x - * sync repos.... in pacman3, they have been moved to DEPENDS. - * Remove this when we move to pacman3 repos. - */ } else if(!strcmp(line, "%REPLACES%")) { /* the REPLACES tag is special -- it only appears in sync repositories, * not the local one. */ @@ -434,17 +430,20 @@ while(fgets(line, 512, fp) && strlen(_alpm_strtrim(line))) { info->provides = alpm_list_add(info->provides, strdup(line)); } - } else if(!strcmp(line, "%REPLACES%")) { - /* the REPLACES tag is special -- it only appears in sync repositories, - * not the local one. */ + } + /* TODO: we were going to move these things here, but it should wait. + * A better change would be to figure out how to restructure the DB. */ + /* else if(!strcmp(line, "%REPLACES%")) { + * the REPLACES tag is special -- it only appears in sync repositories, + * not the local one. * while(fgets(line, 512, fp) && strlen(_alpm_strtrim(line))) { info->replaces = alpm_list_add(info->replaces, strdup(line)); - } + } } else if(!strcmp(line, "%FORCE%")) { - /* FORCE tag only appears in sync repositories, - * not the local one. */ + * FORCE tag only appears in sync repositories, + * not the local one. * info->force = 1; - } + } */ } fclose(fp); fp = NULL; Index: pacman-lib/lib/libalpm/package.c diff -u pacman-lib/lib/libalpm/package.c:1.78 pacman-lib/lib/libalpm/package.c:1.79 --- pacman-lib/lib/libalpm/package.c:1.78 Mon Feb 26 03:38:48 2007 +++ pacman-lib/lib/libalpm/package.c Wed Feb 28 11:37:24 2007 @@ -178,7 +178,8 @@ } /* Parses the package description file for the current package - * + * TODO: this should ALL be in a backend interface (be_files), we should + * be dealing with the abstracted concepts only in this file * Returns: 0 on success, 1 on error * */ Index: pacman-lib/pactest/pmdb.py diff -u pacman-lib/pactest/pmdb.py:1.4 pacman-lib/pactest/pmdb.py:1.5 --- pacman-lib/pactest/pmdb.py:1.4 Mon Feb 26 03:33:48 2007 +++ pacman-lib/pactest/pmdb.py Wed Feb 28 11:37:24 2007 @@ -193,11 +193,12 @@ pkg.conflicts = _getsection(fd) elif line == "%PROVIDES%": pkg.provides = _getsection(fd) - elif line == "%REPLACES%": - pkg.replaces = _getsection(fd) - elif line == "%FORCE%": - fd.readline() - pkg.force = 1 + # TODO this was going to be changed, but isn't anymore + #elif line == "%REPLACES%": + # pkg.replaces = _getsection(fd) + #elif line == "%FORCE%": + # fd.readline() + # pkg.force = 1 fd.close() pkg.checksum["depends"] = getmd5sum(filename) pkg.mtime["depends"] = getmtime(filename) @@ -253,6 +254,8 @@ else: if pkg.replaces: data.append(_mksection("REPLACES", pkg.replaces)) + if pkg.force: + data.append(_mksection("FORCE", "")) if pkg.csize: data.append(_mksection("CSIZE", pkg.csize)) if pkg.md5sum: @@ -293,11 +296,11 @@ data.append(_mksection("CONFLICTS", pkg.conflicts)) if pkg.provides: data.append(_mksection("PROVIDES", pkg.provides)) - if not self.treename == "local": - if pkg.replaces: - data.append(_mksection("REPLACES", pkg.replaces)) - if pkg.force: - data.append(_mksection("FORCE", "")) + #if self.treename != "local": + # if pkg.replaces: + # data.append(_mksection("REPLACES", pkg.replaces)) + # if pkg.force: + # data.append(_mksection("FORCE", "")) if data: data.append("") filename = os.path.join(path, "depends") @@ -354,7 +357,7 @@ and oldpkg.mtime[key] == (0, 0, 0) \ and pkg.mtime[key] == (0, 0, 0): continue - if not oldpkg.mtime[key][1:3] == pkg.mtime[key][1:3]: + if oldpkg.mtime[key][1:3] != pkg.mtime[key][1:3]: modified += 1 return modified Index: pacman-lib/pactest/pmenv.py diff -u pacman-lib/pactest/pmenv.py:1.7 pacman-lib/pactest/pmenv.py:1.8 --- pacman-lib/pactest/pmenv.py:1.7 Tue Feb 27 14:44:45 2007 +++ pacman-lib/pactest/pmenv.py Wed Feb 28 11:37:24 2007 @@ -104,11 +104,16 @@ fail = test.result["fail"] rules = len(test.rules) if fail == 0: - print "[PASSED]", + result = "[PASSED]" else: - print "[FAILED]", + result = "[FAILED]" + print result, print "%s Rules: OK = %2u FAIL = %2u SKIP = %2u" \ - % (test.testname.ljust(32), success, fail, rules - (success + fail)) + % (test.testname.ljust(32), success, fail, \ + rules - (success + fail)) + if fail != 0: + # print test description if test failed + print " ", test.description print "=========="*8 print "Results" Index: pacman-lib/pactest/pmfile.py diff -u pacman-lib/pactest/pmfile.py:1.3 pacman-lib/pactest/pmfile.py:1.4 --- pacman-lib/pactest/pmfile.py:1.3 Mon Feb 26 03:19:02 2007 +++ pacman-lib/pactest/pmfile.py Wed Feb 28 11:37:24 2007 @@ -52,8 +52,8 @@ vprint("\t\told: %s / %s" % (self.checksum, self.mtime)) vprint("\t\tnew: %s / %s" % (checksum, mtime)) - if not self.checksum == checksum \ - or not (self.mtime[1], self.mtime[2]) == (mtime[1], mtime[2]): + if self.checksum != checksum \ + or (self.mtime[1], self.mtime[2]) != (mtime[1], mtime[2]): retval = 1 return retval Index: pacman-lib/pactest/pmrule.py diff -u pacman-lib/pactest/pmrule.py:1.4 pacman-lib/pactest/pmrule.py:1.5 --- pacman-lib/pactest/pmrule.py:1.4 Tue Feb 27 23:00:21 2007 +++ pacman-lib/pactest/pmrule.py Wed Feb 28 11:37:24 2007 @@ -86,7 +86,7 @@ if not value in newpkg.requiredby: success = 0 elif case == "REASON": - if not newpkg.reason == int(value): + if newpkg.reason != int(value): success = 0 elif case == "FILES": if not value in newpkg.files: Index: pacman-lib/pactest/util.py diff -u pacman-lib/pactest/util.py:1.3 pacman-lib/pactest/util.py:1.4 --- pacman-lib/pactest/util.py:1.3 Mon Feb 26 03:19:03 2007 +++ pacman-lib/pactest/util.py Wed Feb 28 11:37:24 2007 @@ -62,7 +62,7 @@ """ filename = "" link = "" - if not name.find(" -> ") == -1: + if name.find(" -> ") != -1: filename, link = name.split(" -> ") elif name[-1] == "*": filename = name.rstrip("*") @@ -80,7 +80,7 @@ link = "" filename = "" - if not name.find(" -> ") == -1: + if name.find(" -> ") != -1: islink = 1 filename, link = name.split(" -> ") elif name[-1] == "*": @@ -181,8 +181,9 @@ # Repositories data.extend(["[%s]\n" \ "server = file://%s\n" \ - % (value.treename, os.path.join(root, SYNCREPO, value.treename)) \ - for key, value in db.iteritems() if not key == "local"]) + % (value.treename, \ + os.path.join(root, SYNCREPO, value.treename)) \ + for key, value in db.iteritems() if key != "local"]) mkfile(os.path.join(root, filename), "\n".join(data))

1 0

[pacman-dev] Pacman, some thoughts
by Georg Grabler 28 Feb '07

28 Feb '07

Hello, I still spend some time looking a bit curious at pacman. It's rather the way it's coded, than the current features it provides. I mean, it's using quite everything marked as "bad style" in most books, and alot of those things could actually be avoided (Macros, goto). The 2nd thing is: You've been talking (and mentioning) ALPM documentation. I personally dislike manpages for interface documentation. I rather think about a interface documentation using Doxygen or similar tools. I've documented about 3 projects, more than 50.000 lines of code using doxygen the past week, and must say i'm happy with the result. Especially for the public SOAP interface it's nice having it, but also for internal reference and new developers who need some description about the functions in the code. And, hands (and heads) down, the code itself (functions etc.) isn't well inline documented. The last, but not least thing: SOURCE releases of RCs / nightly CVS checkouts. I've always been thinking about daily source tarballs. I've been thinking about providing such a script on my own, but my current provider forbids to have a public server running (sad but true, with cable 6mbit in/out). Why so? I'm often somewhere around the world, because of my job (italy, germany, ...), where i often connect in other infrastructures. I've to use a proxy, not supporting CVS. Since i havn't much to do in the evenings there, i actually want to do something - but can't. I don't think i'm the only one who would like nightly source checkouts being provided "as tarball".

3 2

[pacman-dev] Bug with pacman -Ss
by Douglas Soares de Andrade 28 Feb '07

28 Feb '07

Hi guys, I discovered a bug in pacman -Ss. Try in your consoles: pacman3 -Ss dvd+rw or pacman -Ss dvd+rw And the package exists: [douglas@ressonance ~]$ pacman3 -S dvd+rw-tools :: dvd+rw-tools-7.0-1: local version is up to date. Upgrade anyway? [Y/n] n warning: dvd+rw-tools-7.0-1 is up to date -- skipping local database is up to date [douglas@ressonance ~]$ Another doubt: Why it is giving me this response: warning: dvd+rw-tools-7.0-1 is up to date -- skipping local database is up to date About: warning: dvd+rw-tools-7.0-1 is up to date -- skipping I already know that it is up to date because of this line: :: dvd+rw-tools-7.0-1: local version is up to date. Upgrade anyway? [Y/n] n Why not keep the pacman2 behaviour ? -- Douglas Soares de Andrade Archlinux Brasil - http://archlinux-br.org Paradigma Internet - http://www.paradigma.com.br

4 5

[pacman-dev] CVS update of pacman-lib/scripts (makepkg)
by Dan McGee 28 Feb '07

28 Feb '07

Date: Wednesday, February 28, 2007 @ 00:08:25 Author: dan Path: /home/cvs-pacman/pacman-lib/scripts Modified: makepkg (1.54 -> 1.55) * Implemented Douglas' suggestion from the ML- print all integrity checks together while using makepkg -g. ---------+ makepkg | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) Index: pacman-lib/scripts/makepkg diff -u pacman-lib/scripts/makepkg:1.54 pacman-lib/scripts/makepkg:1.55 --- pacman-lib/scripts/makepkg:1.54 Mon Feb 26 03:43:02 2007 +++ pacman-lib/scripts/makepkg Wed Feb 28 00:08:25 2007 @@ -675,6 +675,12 @@ if [ "$NOEXTRACT" = "1" -o "$REPKG" = "1" ]; then warning "Skipping source integrity checks -- using existing src/ tree" else + # TODO we end up checking $GENINTEG 3 times, could probably be refactored + if [ "$GENINTEG" = "1" ]; then + msg "Generating checksums for source files" + plain "" + fi + for integ in ${INTEGRITY_CHECK[@]}; do integ="$(echo $integ | tr A-Z a-z)" case "$integ" in @@ -692,8 +698,6 @@ #Generate integrity checks if [ "$GENINTEG" = "1" ]; then - msg "Generating ${integrity_name}s for source files" - plain "" ct=0 numsrc=${#source[@]} for netfile in "${source[@]}"; do @@ -712,7 +716,6 @@ echo fi done - plain "" #Validate integrity checks else integrity_sums=($(eval echo \${${integrity_name}s[@]})) @@ -744,6 +747,7 @@ done if [ "$GENINTEG" = "1" ]; then + plain "" exit 0 fi fi

1 0