- Pacman-dev - lists.archlinux.org

[pacman-dev] [PATCH] pacman/util.c: Fix memory leak if realloc fails
by Rikard Falkeborn 08 Aug '15

08 Aug '15

--- src/pacman/util.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/pacman/util.c b/src/pacman/util.c index dd6e218..3d71d8b 100644 --- a/src/pacman/util.c +++ b/src/pacman/util.c @@ -1449,11 +1449,14 @@ int multiselect_question(char *array, int count) size_t len; /* handle buffer not being large enough to read full line case */ while(*lastchar == '\0' && lastchar[-1] != '\n') { + char *new_response; response_len += response_incr; - response = realloc(response, response_len); - if(!response) { + new_response = realloc(response, response_len); + if(!new_response) { + free(response); return -1; } + response = new_response; lastchar = response + response_len - 1; /* sentinel byte */ *lastchar = 1; -- 2.4.6

2 1

[pacman-dev] [PATCH] libmakepkg: check if PKGBUILD variables are arrays or not as appropriate
by Allan McRae 07 Aug '15

07 Aug '15

When extracting variables from PKGBUILD (e.g. for .SRCINFO creation) we make assumptions about whether variables are arrays or not. This adds a check to the PKGBUILD linter to ensure variables are arrays or not as appropriate. Signed-off-by: Allan McRae <allan(a)archlinux.org> --- scripts/Makefile.am | 1 + scripts/libmakepkg/lint_pkgbuild/array.sh.in | 62 ++++++++++++++++++++++++++++ scripts/po/POTFILES.in | 1 + 3 files changed, 64 insertions(+) create mode 100644 scripts/libmakepkg/lint_pkgbuild/array.sh.in diff --git a/scripts/Makefile.am b/scripts/Makefile.am index 907dc4f..e961d26 100644 --- a/scripts/Makefile.am +++ b/scripts/Makefile.am @@ -59,6 +59,7 @@ LIBMAKEPKG_IN = \ libmakepkg/lint_package/missing_backup.sh \ libmakepkg/lint_pkgbuild.sh \ libmakepkg/lint_pkgbuild/arch.sh \ + libmakepkg/lint_pkgbuild/array.sh \ libmakepkg/lint_pkgbuild/backup.sh \ libmakepkg/lint_pkgbuild/changelog.sh \ libmakepkg/lint_pkgbuild/epoch.sh \ diff --git a/scripts/libmakepkg/lint_pkgbuild/array.sh.in b/scripts/libmakepkg/lint_pkgbuild/array.sh.in new file mode 100644 index 0000000..64717e9 --- /dev/null +++ b/scripts/libmakepkg/lint_pkgbuild/array.sh.in @@ -0,0 +1,62 @@ +#!/bin/bash +# +# array.sh - Check that variables are or are not arrays as appropriate +# +# Copyright (c) 2014-2015 Pacman Development Team <pacman-dev(a)archlinux.org> +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see <http://www.gnu.org/licenses/>. +# + +[[ -n "$LIBMAKEPKG_LINT_PKGBUILD_ARRAY_SH" ]] && return +LIBMAKEPKG_LINT_PKGBUILD_ARRAY_SH=1 + +LIBRARY=${LIBRARY:-'@libmakepkgdir@'} + +source "$LIBRARY/util/message.sh" + + +lint_pkgbuild_functions+=('lint_array') + + +lint_array() { + array=(arch backup checkdepends groups license noextract options validpgpkeys) + arch_array=(conflicts depends makedepends md5sums optdepends provides replaces + sha1sums sha256sums sha384sums sha512sums source) + string=(changelog epoch install pkgdesc pkgrel pkgver url) + + for i in ${array[@]}; do + if grep -q "$i=[^(]" $BUILDSCRIPT; then + error "$(gettext "%s should be an array")" "$i" + ret=1 + fi + done + + for a in ${arch[@]}; do + [[ $a == "any" ]] && continue + + for i in ${arch_array[@]}; do + if grep -q "$i_$a=[^(]" $BUILDSCRIPT; then + error "$(gettext "%s_%s should be an array")" "$i" "$a" + ret=1 + fi + done + done + + for i in ${string[@]}; do + if grep -q "$i=(" $BUILDSCRIPT; then + error "$(gettext "%s should not be an array")" "$i" + ret=1 + fi + done +} diff --git a/scripts/po/POTFILES.in b/scripts/po/POTFILES.in index 00cb1b8..261374a 100644 --- a/scripts/po/POTFILES.in +++ b/scripts/po/POTFILES.in @@ -13,6 +13,7 @@ scripts/libmakepkg/lint_package/build_references.sh.in scripts/libmakepkg/lint_package/missing_backup.sh.in scripts/libmakepkg/lint_pkgbuild.sh.in scripts/libmakepkg/lint_pkgbuild/arch.sh.in +scripts/libmakepkg/lint_pkgbuild/array.sh.in scripts/libmakepkg/lint_pkgbuild/backup.sh.in scripts/libmakepkg/lint_pkgbuild/changelog.sh.in scripts/libmakepkg/lint_pkgbuild/epoch.sh.in -- 2.4.6

2 5

[pacman-dev] Patch-proposal for makepkg: be able to use su for installations even if sudo is installed
by Jonas Große Sundrup 28 Jul '15

28 Jul '15

Hi, at the moment makepkg will use sudo to obtain root privileges if it is installed, otherwise it will use su. This means that if sudo is configured to only allow special commands (and none of those is "pacman"), "makepkg -i" will fail to install the built package. Same goes for installing dependencies with "makepkg -s". The patch appended introduces a new variable into makepkg.conf named SUPER_USER_BINARY, which is set to "sudo" by default. With it being "sudo" makepkg will behave as it does currently, so there should be no breakages with updates. If not set to sudo, makepkg will ignore an installed sudo and use su right away. Comments on this? ~ Jonas >From d4d0e6914ce669123e77f6f470fdbe56e40b449a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonas=20Gro=C3=9Fe=20Sundrup?= <cherti(a)letopolis.de> Date: Sat, 25 Jul 2015 00:45:18 +0200 Subject: [PATCH] implemented option to use su even if sudo is installed --- etc/makepkg.conf.in | 9 +++++++++ scripts/makepkg.sh.in | 10 ++++++---- 2 files changed, 15 insertions(+), 4 deletions(-) diff --git a/etc/makepkg.conf.in b/etc/makepkg.conf.in index 71ec624..e466edc 100644 --- a/etc/makepkg.conf.in +++ b/etc/makepkg.conf.in @@ -142,4 +142,13 @@ COMPRESSZ=(compress -c -f) PKGEXT='@PKGEXT@' SRCEXT='@SRCEXT@' +######################################################################### +# SUPER USER BINARY +######################################################################### +# +# how to obtain root-privileges for installing packages +# can be either sudo or su +# +SUPER_USER_BINARY='sudo' + # vim: set ft=sh ts=2 sw=2 et: diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index 8b6557e..68edee5 100644 --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in @@ -229,7 +229,7 @@ run_pacman() { cmd=("$PACMAN_PATH" "$@") fi if [[ $1 != -@(T|Qq) ]]; then - if type -p sudo >/dev/null; then + if type -p sudo >/dev/null && [[ $SUPER_USER_BINARY == "sudo" ]]; then cmd=(sudo "${cmd[@]}") else cmd=(su root -c "$(printf '%q ' "${cmd[@]}")") @@ -1507,9 +1507,11 @@ check_software() { fi # check for sudo if we will need it during makepkg execution - if (( DEP_BIN || RMDEPS || INSTALL )); then - if ! type -p sudo >/dev/null; then - warning "$(gettext "Cannot find the %s binary. Will use %s to acquire root privileges.")" "sudo" "su" + if [[ $SUPER_USER_BINARY == "sudo" ]]; then + if (( DEP_BIN || RMDEPS || INSTALL )); then + if ! type -p sudo >/dev/null; then + warning "$(gettext "Cannot find the %s binary. Will use %s to acquire root privileges.")" "sudo" "su" + fi fi fi -- 2.4.6

5 7

[pacman-dev] Signature within repo databases?
by Allan McRae 22 Jul '15

22 Jul '15

I searched the archives, but I can not find why we stored the package PGP signatures base64'd in the repo database rather than downloading them as needed. Signatures are responsible for ~55% of the Arch repo database size, so I am guessing there must have been a tradeoff. Can anyone provide insight to this? It was 2008... Thanks, Allan

4 3

[pacman-dev] RFC: 'repo-add' command for repository discovery
by Tim Groeneveld 21 Jul '15

21 Jul '15

Hi Everyone, I have been thinking about the creation of a tool similar to Ubuntu's add-apt-repository, allowing some automation of the repository adding process inside Arch Linux. My thoughts at the moment would be to create a simple bash script (`repo-add`?) that would get the TXT record for the second command line argument. For example, I could run: repo-add packages.timg.ws The script would then get the TXT record for packages.timg.ws. That TXT record would point to a .conf file that contains all of the configuration for the "packages.timg.ws" repository. That .conf file would be downloaded, and then placed into /etc/pacman.d My thinking is that this command would set up the pacman configuration, and check that everything is OK. If the .conf file contains as a comment with the fingerprint and location of a public key, then `pacman-key` can additionally be automated, maybe showing a message showing what the fingerprint is and that the gpg key downloaded from the comment on the .conf file matches that of the public key. Additionally, a .conf file from the TXT record could also suggest that packages get installed straight after the repo-add command has been ran. If the second command is a URI, then either that file could be downloaded (skipping the "discovery" of a repository), or just the host could be extracted from the URI allowing the discovery to go back to the TXT record. Having this command use the TXT record has two awesome advantages: 1. My site (eg, packges.timg.ws) could be hosted on a different server to where the packages are. 2. No more copying & pasting a whole bunch of configuration to add a repository. Example Run: # repo-add packages.timg.ws 1. The script dig's the hostname that was entered as the second argument on the script: # dig TXT packages.timg.ws +short "http://timg.ws/archlinux/repo/timgws.conf" 2. The .conf file is downloaded. 3. The GPG key shown in the .conf file is downloaded 4. Fingerprint matched, OK (here there would be a warning if the fingerprint of key != fingerprint in conf) 5. Fingerprint shown, confirmation requested 6. conf added to pacman, if packages are suggested, show what they are, ask to run pacman -Su <packages> 7. ??? 8. Profit! Please let me know your thoughts. Tim

4 5

[pacman-dev] [PATCH] libmakepkg: move color settings to function
by Allan McRae 20 Jul '15

20 Jul '15

Signed-off-by: Allan McRae <allan(a)archlinux.org> --- scripts/libmakepkg/util/message.sh | 20 ++++++++++++++++++++ scripts/makepkg.sh.in | 22 ++++------------------ 2 files changed, 24 insertions(+), 18 deletions(-) diff --git a/scripts/libmakepkg/util/message.sh b/scripts/libmakepkg/util/message.sh index c2c1982..41a105a 100644 --- a/scripts/libmakepkg/util/message.sh +++ b/scripts/libmakepkg/util/message.sh @@ -23,6 +23,26 @@ LIBMAKEPKG_UTIL_MESSAGE_SH=1 +colorize() { + # prefer terminal safe colored and bold text when tput is supported + if tput setaf 0 &>/dev/null; then + ALL_OFF="$(tput sgr0)" + BOLD="$(tput bold)" + BLUE="${BOLD}$(tput setaf 4)" + GREEN="${BOLD}$(tput setaf 2)" + RED="${BOLD}$(tput setaf 1)" + YELLOW="${BOLD}$(tput setaf 3)" + else + ALL_OFF="\e[0m" + BOLD="\e[1m" + BLUE="${BOLD}\e[34m" + GREEN="${BOLD}\e[32m" + RED="${BOLD}\e[31m" + YELLOW="${BOLD}\e[33m" + fi + readonly ALL_OFF BOLD BLUE GREEN RED YELLOW +} + plain() { local mesg=$1; shift printf "${BOLD} ${mesg}${ALL_OFF}\n" "$@" >&2 diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index 8b6557e..ec8218f 100644 --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in @@ -1892,26 +1892,12 @@ PACMAN=${PACMAN:-pacman} PACMAN_PATH=$(type -P $PACMAN) # check if messages are to be printed using color -unset ALL_OFF BOLD BLUE GREEN RED YELLOW if [[ -t 2 && $USE_COLOR != "n" ]] && check_buildenv "color" "y"; then - # prefer terminal safe colored and bold text when tput is supported - if tput setaf 0 &>/dev/null; then - ALL_OFF="$(tput sgr0)" - BOLD="$(tput bold)" - BLUE="${BOLD}$(tput setaf 4)" - GREEN="${BOLD}$(tput setaf 2)" - RED="${BOLD}$(tput setaf 1)" - YELLOW="${BOLD}$(tput setaf 3)" - else - ALL_OFF="\e[0m" - BOLD="\e[1m" - BLUE="${BOLD}\e[34m" - GREEN="${BOLD}\e[32m" - RED="${BOLD}\e[31m" - YELLOW="${BOLD}\e[33m" - fi + colorize +else + unset ALL_OFF BOLD BLUE GREEN RED YELLOW fi -readonly ALL_OFF BOLD BLUE GREEN RED YELLOW + # override settings with an environment variable for batch processing BUILDDIR=${_BUILDDIR:-$BUILDDIR} -- 2.4.6

1 0

[pacman-dev] [PATCH] pacman/files.c: fix memory leak on regex error
by Allan McRae 20 Jul '15

20 Jul '15

Signed-off-by: Allan McRae <allan(a)archlinux.org> --- src/pacman/files.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/pacman/files.c b/src/pacman/files.c index 2250994..ceec342 100644 --- a/src/pacman/files.c +++ b/src/pacman/files.c @@ -102,6 +102,7 @@ static int files_search(alpm_list_t *syncs, alpm_list_t *targets, int regex) { if(regex) { if(regcomp(&reg, targ, REG_EXTENDED | REG_NOSUB | REG_ICASE | REG_NEWLINE) != 0) { /* TODO: error message */ + free(targ); goto notfound; } } -- 2.4.6

1 0

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v4.2.1-184-gdeac973
by allan＠archlinux.org 20 Jul '15

20 Jul '15

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, master has been updated via deac9731884a83ad91eab9f27b288f406f56c87b (commit) via 445aa3b52cfcd5630ec10d2ae2c8eeffa2b5c5de (commit) via bbab90836b2f7d8b03c862f35bc6e3ff2bd628d2 (commit) via 3c410309644ecc4800a9aa6d96693a5630515701 (commit) via fd9ff672b0010650297e645c4fd1bd1cc320e3ef (commit) via acf95f6b3b6e2bef174da51e799bd07ce9f4cfd0 (commit) via 137a4086de310e2d31cb719806e01cd9eb414ec0 (commit) via 488ca2426568163721153822af8269447e481c7d (commit) via 5782b8356c9b9d2c5e21694de22b1441277574b7 (commit) via e49abc9860cfe9470a5828d3bb0ad38fd57a0fad (commit) via b0dac754d27b45e4346b010e674f7faa466e0025 (commit) via 289fdf0d1d9c88f0c8a6502cc311599c63a04723 (commit) via f6c55b3c3f395839c0973c36b7a7e05984636a61 (commit) via 1ada16f0177f9bfcaed95cf3b71b7029290a5f1d (commit) via 2d7a41539b73b373b63d7e2d61ed519e19878799 (commit) from 94204d108984c46966c681a05f232d830812d440 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit deac9731884a83ad91eab9f27b288f406f56c87b Author: Levente Polyak <anthraxx(a)archlinux.org> Date: Sat Jul 18 17:58:23 2015 +0200 ensure matching database and package version While loading each package ensure that the internal version matches the expected database version to avoid the possibility to circumvent the version check. This issue can be used by an attacker to trick the software into installing an older version. The behavior can be exploited by a man-in-the-middle attack through specially crafted database tarball containing a higher version, yet actually delivering an older and vulnerable version, which was previously shipped. Signed-off-by: Levente Polyak <anthraxx(a)archlinux.org> Signed-off-by: Remi Gacogne <rgacogne(a)archlinux.org> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 445aa3b52cfcd5630ec10d2ae2c8eeffa2b5c5de Author: Dave Reisner <dreisner(a)archlinux.org> Date: Sun Jul 19 09:50:40 2015 -0400 dont remove x bit when marking pkgdir RO f170a94c137d355 potentially causes $pkgdirbase/$pkg to be undeleteable with -R or -C if a previous build was interrupted. We simply can't traverse to this directory, and rm blows up. Signed-off-by: Allan McRae <allan(a)archlinux.org> commit bbab90836b2f7d8b03c862f35bc6e3ff2bd628d2 Author: Allan McRae <allan(a)archlinux.org> Date: Mon Jul 20 11:43:27 2015 +1000 libmakepkg: lint_package requires cd_safe Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 3c410309644ecc4800a9aa6d96693a5630515701 Author: Allan McRae <allan(a)archlinux.org> Date: Sat Jun 20 17:26:22 2015 +1000 Handle repo/pkg style arguments to sync repo file listing Passing "-Fl pkg" will print the filelist for the first occurance of "pkg" in the sync repos. Other version of the package can be printed using "-Fl repo/pkg". Signed-off-by: Allan McRae <allan(a)archlinux.org> commit fd9ff672b0010650297e645c4fd1bd1cc320e3ef Author: Allan McRae <allan(a)archlinux.org> Date: Thu Jun 18 19:27:51 2015 +1000 Add regex search option to sync database file searching e.g. pacman -Fsx kcm.*print.*\.so Signed-off-by: Allan McRae <allan(a)archlinux.org> commit acf95f6b3b6e2bef174da51e799bd07ce9f4cfd0 Author: Allan McRae <allan(a)archlinux.org> Date: Thu Jun 18 18:28:13 2015 +1000 Implement searching for a file in the sync databases Locates all packages that contain the listed file e.g. pacman -Fs libpng.so Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 137a4086de310e2d31cb719806e01cd9eb414ec0 Author: Allan McRae <allan(a)archlinux.org> Date: Thu Jun 18 13:19:09 2015 +1000 Implement listing files from sync packages Does the equivalent of the -Ql option for local packages e.g. pacman -Fl glibc Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 488ca2426568163721153822af8269447e481c7d Author: Allan McRae <allan(a)archlinux.org> Date: Thu Jun 18 01:57:38 2015 +1000 Implement locating file owner in sync files database Equivalent to -Qo but for packages in the sync database e.g. pacman -Fo /usr/bin/pacman Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 5782b8356c9b9d2c5e21694de22b1441277574b7 Author: Allan McRae <allan(a)archlinux.org> Date: Wed Jun 17 23:56:21 2015 +1000 Prototype pacman files database operations Add the -F/--files operations, -s/--sync support and nd provide dummy functions for -s/--search, -l/-list and -o/--owns. Signed-off-by: Allan McRae <allan(a)archlinux.org> commit e49abc9860cfe9470a5828d3bb0ad38fd57a0fad Author: Allan McRae <allan(a)archlinux.org> Date: Thu Jun 18 00:12:14 2015 +1000 pacman: move database syncing to util.c Signed-off-by: Allan McRae <allan(a)archlinux.org> commit b0dac754d27b45e4346b010e674f7faa466e0025 Author: Allan McRae <allan(a)archlinux.org> Date: Wed Jun 17 22:27:50 2015 +1000 Add pacman support for .files databases Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 289fdf0d1d9c88f0c8a6502cc311599c63a04723 Author: Allan McRae <allan(a)archlinux.org> Date: Tue Jul 14 22:00:38 2015 +1000 Read file lists from databases If a sync database contains a "files" file, the file list will be read. Currently, there is no known demand for the file list to be lazy loaded by any libalpm frontend, so these files are read whenever present. Lazy loading can be implemented when a demand exists. Signed-off-by: Allan McRae <allan(a)archlinux.org> commit f6c55b3c3f395839c0973c36b7a7e05984636a61 Author: Allan McRae <allan(a)archlinux.org> Date: Tue Jul 14 21:45:59 2015 +1000 Allow frontends to specify the sync database extension This allows frontends to select between the .db and .files databases currently supplied by repo-add or any other compatible database. Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 1ada16f0177f9bfcaed95cf3b71b7029290a5f1d Author: Allan McRae <allan(a)archlinux.org> Date: Thu Jun 18 00:15:44 2015 +1000 Fix formatting in parsearg_upgrade Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 2d7a41539b73b373b63d7e2d61ed519e19878799 Author: Allan McRae <allan(a)archlinux.org> Date: Wed Jun 17 22:17:55 2015 +1000 Simplify sync_cleandb 1) Remove checks for removing pre-tardb files 2) Remove the long redundant keep_used parameter 3) Fix pacman error due to removing .sig file along with database Signed-off-by: Allan McRae <allan(a)archlinux.org> ----------------------------------------------------------------------- Summary of changes: lib/libalpm/alpm.c | 3 + lib/libalpm/alpm.h | 3 + lib/libalpm/be_sync.c | 55 ++++++- lib/libalpm/db.c | 6 +- lib/libalpm/handle.c | 22 +++ lib/libalpm/handle.h | 1 + lib/libalpm/sync.c | 18 +++ scripts/libmakepkg/lint_package.sh.in | 1 + scripts/makepkg.sh.in | 2 +- src/pacman/Makefile.am | 1 + src/pacman/callback.c | 2 +- src/pacman/conf.c | 4 + src/pacman/conf.h | 6 +- src/pacman/files.c | 271 ++++++++++++++++++++++++++++++++++ src/pacman/pacman.c | 88 ++++++++++- src/pacman/pacman.h | 2 + src/pacman/sync.c | 86 +++-------- src/pacman/util.c | 33 +++++ src/pacman/util.h | 1 + 19 files changed, 520 insertions(+), 85 deletions(-) create mode 100644 src/pacman/files.c hooks/post-receive -- The official pacman repository

1 0

[pacman-dev] [PATCH] libmakepkg: lint_package requires cd_safe
by Allan McRae 20 Jul '15

20 Jul '15

Signed-off-by: Allan McRae <allan(a)archlinux.org> --- scripts/libmakepkg/lint_package.sh.in | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/libmakepkg/lint_package.sh.in b/scripts/libmakepkg/lint_package.sh.in index 6255639..0f1c738 100644 --- a/scripts/libmakepkg/lint_package.sh.in +++ b/scripts/libmakepkg/lint_package.sh.in @@ -24,6 +24,7 @@ LIBMAKEPKG_LINT_PACKAGE_SH=1 LIBRARY=${LIBRARY:-'@libmakepkgdir@'} source "$LIBRARY/util/message.sh" +source "$LIBRARY/util/util.sh" declare -a lint_package_functions -- 2.4.6

1 0

[pacman-dev] [PATCH] dont remove x bit when marking pkgdir RO
by Dave Reisner 19 Jul '15

19 Jul '15

f170a94c137d355 potentially causes $pkgdirbase/$pkg to be undeleteable with -R or -C if a previous build was interrupted. We simply can't traverse to this directory, and rm blows up. --- scripts/makepkg.sh.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index c74e84a..ffe7fe5 100644 --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in @@ -2235,7 +2235,7 @@ else unset pkg fi mkdir -p "$pkgdirbase" - chmod a-srwx "$pkgdirbase" + chmod a-srw "$pkgdirbase" cd_safe "$startdir" if (( ! REPKG )); then -- 2.4.6

1 0