- Pacman-dev - lists.archlinux.org

[pacman-dev] [PATCH v2] pacman-db-upgrade: fix issue with find argument list length overflow
by Allan McRae 26 Nov '14

26 Nov '14

Signed-off-by: Allan McRae <allan(a)archlinux.org> --- scripts/pacman-db-upgrade.sh.in | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/scripts/pacman-db-upgrade.sh.in b/scripts/pacman-db-upgrade.sh.in index 2fced9b..7bb277b 100644 --- a/scripts/pacman-db-upgrade.sh.in +++ b/scripts/pacman-db-upgrade.sh.in @@ -174,7 +174,10 @@ if [[ -z "$db_version" ]]; then dirlist+=("${pacroot}${dir%/}") done < <(grep -h '/$' "$dbroot"/local/*/files | sort -ru) - mapfile -t dirlist < <(find "${dirlist[@]}" -maxdepth 0 -type l) + mapfile -t dirlist < <( + for dir in "${dirlist[@]}"; do + [[ -L "$dir" ]] && echo "$dir" + done) if [[ ${#dirlist[@]} != 0 ]]; then msg "$(gettext "Pre-4.2 database format detected - upgrading...")" -- 2.1.3

1 0

[pacman-dev] [PATCH] pacman-db-upgrade: fix issue with find argument list length overflow
by Allan McRae 25 Nov '14

25 Nov '14

Signed-off-by: Allan McRae <allan(a)archlinux.org> --- scripts/pacman-db-upgrade.sh.in | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/scripts/pacman-db-upgrade.sh.in b/scripts/pacman-db-upgrade.sh.in index 2fced9b..7e91ea6 100644 --- a/scripts/pacman-db-upgrade.sh.in +++ b/scripts/pacman-db-upgrade.sh.in @@ -174,7 +174,10 @@ if [[ -z "$db_version" ]]; then dirlist+=("${pacroot}${dir%/}") done < <(grep -h '/$' "$dbroot"/local/*/files | sort -ru) - mapfile -t dirlist < <(find "${dirlist[@]}" -maxdepth 0 -type l) + mapfile -t dirlist < <( + while IFS=$'\n' read -r dir; do + find $dir -maxdepth 0 -type l; + done < <(printf '%s\n' "${dirlist[@]}")) if [[ ${#dirlist[@]} != 0 ]]; then msg "$(gettext "Pre-4.2 database format detected - upgrading...")" -- 2.1.3

2 1

[pacman-dev] [PATCH] Clarify error message
by Allan McRae 24 Nov '14

24 Nov '14

The error message on failing to add an "assume installed" entry to the backend was not clear. Clarify by making "assume-installed" none translatable and adding a hyphen to match calling flag. Signed-off-by: Allan McRae <allan(a)archlinux.org> --- Noted by translators. I will push this after the 4.2 release. src/pacman/conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pacman/conf.c b/src/pacman/conf.c index 5028284..e8e7c03 100644 --- a/src/pacman/conf.c +++ b/src/pacman/conf.c @@ -754,7 +754,7 @@ static int setup_libalpm(void) ret = alpm_option_add_assumeinstalled(handle, dep); if(ret) { - pm_printf(ALPM_LOG_ERROR, _("Failed to pass assume installed entry to libalpm")); + pm_printf(ALPM_LOG_ERROR, _("Failed to pass %s entry to libalpm"), "assume-installed"); alpm_dep_free(dep); return ret; } -- 2.1.3

1 0

[pacman-dev] Code freeze for 4.2 release is in effect
by Allan McRae 23 Nov '14

23 Nov '14

Hi all, The pacman source is now frozen. I intend to make the release early in the week of the 8th of December. Only bug/regression fixes will be accepted. Clearly flag any submitted patch you think needs added before release. Cheers, Allan

1 0

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v4.1.2-506-g41c8263
by allan＠archlinux.org 23 Nov '14

23 Nov '14

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, master has been updated via 41c8263ba289dac191d7f74faaa62476baf41c28 (commit) via bb878217cda7a04ae2a866671cdd3df9094bc972 (commit) via 04bc3a24ebedc2529d814164fb356a5a33489e6d (commit) via c23ff87893de4f27c898b164c8586ce691fc370f (commit) from ef0577e3d5560c2d7f2869586219040beffdbb6b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 41c8263ba289dac191d7f74faaa62476baf41c28 Author: Tobias Powalowski <tpowa(a)archlinux.org> Date: Fri Nov 21 20:54:58 2014 +1000 pacman-key: compatibility with gnupg-2.1 GnuPG 2.1 no longer allow empty passphrases by default. Signed-off-by: Allan McRae <allan(a)archlinux.org> commit bb878217cda7a04ae2a866671cdd3df9094bc972 Author: Allan McRae <allan(a)archlinux.org> Date: Fri Nov 21 14:13:57 2014 +1000 Remove pacsysclean This script parsed pacman output and was broken by the change to the use of appropriate units for package sizes. Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 04bc3a24ebedc2529d814164fb356a5a33489e6d Author: Dave Reisner <dreisner(a)archlinux.org> Date: Tue Nov 18 09:02:06 2014 -0500 pacsort: parse inputs up front into control struct This moves most of the parsing work out of the sorting path. The explode and splitfile functions now call input_new and append input_t structs to the list of sort candidates instead of raw strings. This lets us make smarter and easier decisions in the sorting callbacks, which are now also split into the version and file comparison methods for clarity. This fixes two bugs: 1) Incorrect ordering with filenames containing epoch in the pkgver 2) Incorrect ordering with package names which are substrings of each other (e.g. "systemd" and "systemd-sysvcompat"). Performance of the --files mode degrades slightly as a result of this change, but not unreasonably. Sorting with small inputs (5-10) doubles in runtime, but larger inputs (4000+) only increase by 20%. ref: https://bugs.archlinux.org/task/37631 Signed-off-by: Allan McRae <allan(a)archlinux.org> commit c23ff87893de4f27c898b164c8586ce691fc370f Author: Allan McRae <allan(a)archlinux.org> Date: Wed Nov 19 17:09:55 2014 +1000 checkupdates: do not print ignored packages FS#41223 Signed-off-by: Allan McRae <allan(a)archlinux.org> ----------------------------------------------------------------------- Summary of changes: contrib/.gitignore | 1 - contrib/Makefile.am | 3 - contrib/README | 2 - contrib/checkupdates.sh.in | 2 +- contrib/pacsysclean.sh.in | 66 --------------- scripts/pacman-key.sh.in | 1 + src/util/pacsort.c | 204 ++++++++++++++++++++++++++++++++------------- test/util/pacsorttest.sh | 11 ++- 8 files changed, 158 insertions(+), 132 deletions(-) delete mode 100644 contrib/pacsysclean.sh.in hooks/post-receive -- The official pacman repository

1 0

[pacman-dev] [PATCH] pacman-key: compatibility with gnupg-2.1
by Allan McRae 21 Nov '14

21 Nov '14

From: Tobias Powalowski <tpowa(a)archlinux.org> GnuPG 2.1 no longer allow empty passphrases by default. Signed-off-by: Allan McRae <allan(a)archlinux.org> --- scripts/pacman-key.sh.in | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/pacman-key.sh.in b/scripts/pacman-key.sh.in index ba8d02e..5ba0ad8 100644 --- a/scripts/pacman-key.sh.in +++ b/scripts/pacman-key.sh.in @@ -151,6 +151,7 @@ Key-Usage: sign Name-Real: Pacman Keyring Master Key Name-Email: pacman@localhost Expire-Date: 0 +%no-protection %commit %echo Done EOF -- 2.1.3

1 0

[pacman-dev] What to do with pacsysclean and pacsize?
by Allan McRae 20 Nov '14

20 Nov '14

pacsysclean is broken... In short it only looks for KiB in output to assess file size, whereas pacman now outputs the correct thing. See [1]. No-one has bothered to fix this. pacsize was submitted as a replacement [2]. It currently works, but is another tool that parses pacman output. I think we should remove pacsysclean and not add pacsize. There is expac available (and potentially being added to the pacman codebase for the next release). [I am told expac can do the same thing but I don't know how...] Opinions? [1] https://bugs.archlinux.org/task/41531 [2] https://patchwork.archlinux.org/patch/2030/

3 3

[pacman-dev] [PATCH] checkupdates: do not print ignored packages
by Allan McRae 19 Nov '14

19 Nov '14

FS#41223 Signed-off-by: Allan McRae <allan(a)archlinux.org> --- contrib/checkupdates.sh.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/checkupdates.sh.in b/contrib/checkupdates.sh.in index 06e1b12..f4f36c0 100644 --- a/contrib/checkupdates.sh.in +++ b/contrib/checkupdates.sh.in @@ -44,7 +44,7 @@ eval $(awk -F' *= *' '$1 ~ /DBPath/ { print $1 "=" $2 }' @sysconfdir@/pacman.con mkdir -p "$CHECKUPDATES_DB" ln -s "${DBPath}/local" "$CHECKUPDATES_DB" &> /dev/null fakeroot pacman -Sy --dbpath "$CHECKUPDATES_DB" --logfile /dev/null &> /dev/null -pacman -Qqu --dbpath "$CHECKUPDATES_DB" 2> /dev/null +pacman -Qqu --dbpath "$CHECKUPDATES_DB" 2> /dev/null | grep -v '\[.*\]' exit 0 -- 2.1.3

1 0

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v4.1.2-502-gef0577e
by allan＠archlinux.org 19 Nov '14

19 Nov '14

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, master has been updated via ef0577e3d5560c2d7f2869586219040beffdbb6b (commit) via 3446453c72b7fea6e07d0e1f5a547a870bf60484 (commit) via 193b2b33f86e549f15feb5fe82a83de88b5c7e98 (commit) via db402d6029c77d6fa7d8295b529edf9ff0f605ce (commit) via eda65967ec6831515fdcc59adec1529da81cb521 (commit) via 96e9cf35f11f271e46af8d3c0f00c9664052fc74 (commit) via 5d11605958dd9d07f902287468104a996b3bddcc (commit) via 5d618438c4831af92e82251051a128e8591fef59 (commit) via a7298c36fdc58ae4d9007a69adea988fbb9cd0db (commit) via d9aa7025ea8c9441bfd50b339a7accc7b61637ab (commit) via 8c00dd7341e6df4ebe8c6ac9d9347acdcbb003b7 (commit) via 4c1f41a7c18355542d9d7f5c58ac5a026a71bb4d (commit) from 0d249949345e69fc1728df236569d1153582244c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ef0577e3d5560c2d7f2869586219040beffdbb6b Author: Dave Reisner <dreisner(a)archlinux.org> Date: Tue Nov 18 09:02:05 2014 -0500 version: fix memory leak in early return Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 3446453c72b7fea6e07d0e1f5a547a870bf60484 Author: Allan McRae <allan(a)archlinux.org> Date: Tue Nov 18 15:26:42 2014 +1000 Fix translation error and remove empty po files Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 193b2b33f86e549f15feb5fe82a83de88b5c7e98 Author: Allan McRae <allan(a)archlinux.org> Date: Tue Nov 18 15:14:51 2014 +1000 Update po files to send to Transifex Signed-off-by: Allan McRae <allan(a)archlinux.org> commit db402d6029c77d6fa7d8295b529edf9ff0f605ce Author: Allan McRae <allan(a)archlinux.org> Date: Tue Nov 18 15:06:30 2014 +1000 Pull translation updates from Transifex Signed-off-by: Allan McRae <allan(a)archlinux.org> commit eda65967ec6831515fdcc59adec1529da81cb521 Author: Allan McRae <allan(a)archlinux.org> Date: Tue Nov 18 12:50:56 2014 +1000 Do not warn about missing files in NoExtract When checking a packages files, ignore any missing files in NoExtract Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 96e9cf35f11f271e46af8d3c0f00c9664052fc74 Author: Allan McRae <allan(a)archlinux.org> Date: Tue Nov 18 12:31:30 2014 +1000 Add alpm_option_match_noextract This is useful for frontends testing whether a file is in NoExtract Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 5d11605958dd9d07f902287468104a996b3bddcc Author: Allan McRae <allan(a)archlinux.org> Date: Tue Nov 18 00:47:19 2014 +1000 extract_single_file: fix memory leak in error condition The memory assigned to checkfile was leaked in the error condition. Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 5d618438c4831af92e82251051a128e8591fef59 Author: Allan McRae <allan(a)archlinux.org> Date: Tue Nov 18 00:34:46 2014 +1000 _alpm_backup_dup: fix memory leak in error case Signed-off-by: Allan McRae <allan(a)archlinux.org> commit a7298c36fdc58ae4d9007a69adea988fbb9cd0db Author: Allan McRae <allan(a)archlinux.org> Date: Tue Nov 18 00:09:11 2014 +1000 makepkg: symlink files in noextract into $srcdir File in noextract should still be symlinked into $srcdir so that they can be accessed without using $SRCDEST. Using noextract on VCS files makes no sense as these are not being extracted, so now this does nothing. Signed-off-by: Allan McRae <allan(a)archlinux.org> commit d9aa7025ea8c9441bfd50b339a7accc7b61637ab Author: Allan McRae <allan(a)archlinux.org> Date: Mon Nov 17 23:39:31 2014 +1000 Remove logging of NoExtract events With globbing in NoExtract, these log events can quickly pile up hiding important information from the log. Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 8c00dd7341e6df4ebe8c6ac9d9347acdcbb003b7 Author: Allan McRae <allan(a)archlinux.org> Date: Mon Nov 17 17:13:48 2014 +1000 Fix crash when using external downloader Commit 9d96bed9 attempts to use the same effective URL for the db and its signature download. However, this information is not available when we use an external downloader, resulting in a crash. Fall back to the old method when the effective URL is unavailable. Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 4c1f41a7c18355542d9d7f5c58ac5a026a71bb4d Author: Lukáš Jirkovský <l.jirkovsky(a)gmail.com> Date: Mon Dec 9 20:31:21 2013 +0000 makepkg: svn: update existing sources in srcdir without removing them first. This matches the behaviour with non-VCS sources. It also allows incremental builds when subversion is used to obtain sources. Signed-off-by: Lukáš Jirkovský <l.jirkovsky(a)gmail.com> Signed-off-by: Allan McRae <allan(a)archlinux.org> ----------------------------------------------------------------------- Summary of changes: lib/libalpm/add.c | 4 +- lib/libalpm/alpm.h | 1 + lib/libalpm/backup.c | 9 +- lib/libalpm/be_sync.c | 21 +- lib/libalpm/handle.c | 5 + lib/libalpm/po/LINGUAS | 2 - lib/libalpm/po/ar.po | 527 +++++++++---- lib/libalpm/po/{eo.po => ast.po} | 55 +- lib/libalpm/po/bg.po | 616 +++++++++++++++ lib/libalpm/po/ca.po | 270 ++++++- lib/libalpm/po/cs.po | 261 ++++++- lib/libalpm/po/da.po | 264 ++++++- lib/libalpm/po/de.po | 279 ++++++- lib/libalpm/po/el.po | 265 ++++++- lib/libalpm/po/en_GB.po | 264 ++++++- lib/libalpm/po/es.po | 376 +++++++-- lib/libalpm/po/{en_GB.po => eu.po} | 313 ++++---- lib/libalpm/po/fi.po | 274 ++++++- lib/libalpm/po/fr.po | 267 ++++++- lib/libalpm/po/gl.po | 273 ++++++- lib/libalpm/po/hr.po | 283 ++++++- lib/libalpm/po/hu.po | 270 ++++++- lib/libalpm/po/id.po | 270 ++++++- lib/libalpm/po/it.po | 259 ++++++- lib/libalpm/po/ja.po | 259 ++++++- lib/libalpm/po/kk.po | 261 ++++++- lib/libalpm/po/ko.po | 279 ++++++- lib/libalpm/po/libalpm.pot | 235 +++++- lib/libalpm/po/lt.po | 259 ++++++- lib/libalpm/po/nb.po | 261 ++++++- lib/libalpm/po/nl.po | 259 ++++++- lib/libalpm/po/pl.po | 263 ++++++- lib/libalpm/po/pt.po | 260 ++++++- lib/libalpm/po/pt_BR.po | 259 ++++++- lib/libalpm/po/ro.po | 284 ++++++- lib/libalpm/po/ru.po | 259 ++++++- lib/libalpm/po/sk.po | 259 ++++++- lib/libalpm/po/sl.po | 508 +++++++++---- lib/libalpm/po/sr.po | 274 ++++++- lib%2Flibalpm%2Fpo%2Fsr(a)latin.po | 274 ++++++- lib/libalpm/po/sv.po | 288 ++++++- lib/libalpm/po/tr.po | 259 ++++++- lib/libalpm/po/uk.po | 259 ++++++- lib/libalpm/po/{eo.po => ur.po} | 118 +-- lib/libalpm/po/{fa.po => uz.po} | 36 +- lib/libalpm/po/{fa.po => vi.po} | 68 +- lib/libalpm/po/zh_CN.po | 261 ++++++- lib/libalpm/po/zh_TW.po | 264 ++++++- lib/libalpm/version.c | 3 +- scripts/makepkg.sh.in | 17 +- scripts/po/LINGUAS | 4 - scripts/po/ar.po | 944 ++++++++++++++++++----- scripts/po/{eo.po => ast.po} | 138 ++-- scripts/po/{nl.po => bg.po} | 211 +++--- scripts/po/ca.po | 838 ++++++++++++++++++--- scripts/po/cs.po | 826 +++++++++++++++++--- scripts/po/da.po | 838 ++++++++++++++++++--- scripts/po/de.po | 956 +++++++++++++++++++---- scripts/po/el.po | 832 +++++++++++++++++--- scripts/po/en_GB.po | 826 +++++++++++++++++--- scripts/po/es.po | 1466 +++++++++++++++++++++++++++--------- scripts/po/eu.po | 1214 +++++++++++++++++++++++++++++ scripts/po/fa.po | 1205 ----------------------------- scripts/po/fi.po | 874 ++++++++++++++++++--- scripts/po/fr.po | 852 ++++++++++++++++++--- scripts/po/gl.po | 1318 +++++++++++++++++++++++++------- scripts/po/hr.po | 810 +++++++++++++++++--- scripts/po/hu.po | 835 +++++++++++++++++--- scripts/po/id.po | 837 +++++++++++++++++--- scripts/po/it.po | 823 ++++++++++++++++++-- scripts/po/ja.po | 822 +++++++++++++++++--- scripts/po/kk.po | 765 +++++++++++++++++-- scripts/po/ko.po | 1453 ++++++++++++++++++++++++++--------- scripts/po/lt.po | 824 +++++++++++++++++--- scripts/po/nb.po | 832 +++++++++++++++++--- scripts/po/pacman-scripts.pot | 703 +++++++++++++++-- scripts/po/pl.po | 1067 +++++++++++++++++++++----- scripts/po/pt.po | 834 +++++++++++++++++--- scripts/po/pt_BR.po | 832 +++++++++++++++++--- scripts/po/ro.po | 863 ++++++++++++++++++--- scripts/po/ru.po | 830 +++++++++++++++++--- scripts/po/sk.po | 823 +++++++++++++++++--- scripts/po/sl.po | 958 +++++++++++++++++++---- scripts/po/sr.po | 830 +++++++++++++++++--- scripts%2Fpo%2Fsr(a)latin.po | 830 +++++++++++++++++--- scripts/po/sv.po | 1196 +++++++++++++++++++++++------ scripts/po/tr.po | 824 +++++++++++++++++--- scripts/po/uk.po | 826 +++++++++++++++++--- scripts/po/{zh_TW.po => uz.po} | 116 +-- scripts/po/zh_CN.po | 817 ++++++++++++++++++-- src/pacman/check.c | 30 +- src/pacman/po/ar.po | 777 ++++++++++++++----- src/pacman/po/{gl.po => ast.po} | 641 +++++++--------- src/pacman/po/bg.po | 1274 +++++++++++++++++++++++++++++++ src/pacman/po/ca.po | 554 ++++++++++++-- src/pacman/po/cs.po | 547 ++++++++++++-- src/pacman/po/da.po | 544 +++++++++++-- src/pacman/po/de.po | 591 ++++++++++++--- src/pacman/po/el.po | 539 +++++++++++-- src/pacman/po/en_GB.po | 539 +++++++++++-- src/pacman/po/eo.po | 507 +++++++++++-- src/pacman/po/es.po | 878 +++++++++++++++------ src/pacman/po/{da.po => eu.po} | 704 ++++++++--------- src/pacman/po/fa.po | 475 ++++++++++-- src/pacman/po/fi.po | 554 ++++++++++++-- src/pacman/po/fr.po | 556 ++++++++++++-- src/pacman/po/gl.po | 711 +++++++++++++---- src/pacman/po/hr.po | 592 ++++++++++++--- src/pacman/po/hu.po | 544 +++++++++++-- src/pacman/po/id.po | 541 +++++++++++-- src/pacman/po/it.po | 576 +++++++++++--- src/pacman/po/ja.po | 539 +++++++++++-- src/pacman/po/kk.po | 520 +++++++++++-- src/pacman/po/ko.po | 1079 ++++++++++++++++++-------- src/pacman/po/lt.po | 541 +++++++++++-- src/pacman/po/nb.po | 590 ++++++++++++--- src/pacman/po/nl.po | 1078 ++++++++++++++++++-------- src/pacman/po/pacman.pot | 455 +++++++++-- src/pacman/po/pl.po | 861 +++++++++++++++------ src/pacman/po/pt.po | 544 +++++++++++-- src/pacman/po/pt_BR.po | 543 +++++++++++-- src/pacman/po/ro.po | 600 ++++++++++++--- src/pacman/po/ru.po | 540 +++++++++++-- src/pacman/po/sk.po | 539 +++++++++++-- src/pacman/po/sl.po | 770 ++++++++++++++----- src/pacman/po/sr.po | 551 ++++++++++++-- src%2Fpacman%2Fpo%2Fsr(a)latin.po | 551 ++++++++++++-- src/pacman/po/sv.po | 632 +++++++++++++--- src/pacman/po/tr.po | 540 +++++++++++-- src/pacman/po/uk.po | 539 +++++++++++-- src/pacman/po/{ko.po => ur.po} | 63 +- src/pacman/po/{ko.po => uz.po} | 180 +++-- src/pacman/po/zh_CN.po | 547 ++++++++++++-- src/pacman/po/zh_TW.po | 536 +++++++++++-- 134 files changed, 58870 insertions(+), 12288 deletions(-) copy lib/libalpm/po/{eo.po => ast.po} (90%) create mode 100644 lib/libalpm/po/bg.po copy lib/libalpm/po/{en_GB.po => eu.po} (53%) rename lib/libalpm/po/{eo.po => ur.po} (72%) copy lib/libalpm/po/{fa.po => uz.po} (92%) rename lib/libalpm/po/{fa.po => vi.po} (82%) rename scripts/po/{eo.po => ast.po} (87%) rename scripts/po/{nl.po => bg.po} (80%) create mode 100644 scripts/po/eu.po delete mode 100644 scripts/po/fa.po rename scripts/po/{zh_TW.po => uz.po} (90%) copy src/pacman/po/{gl.po => ast.po} (57%) create mode 100644 src/pacman/po/bg.po copy src/pacman/po/{da.po => eu.po} (52%) copy src/pacman/po/{ko.po => ur.po} (95%) copy src/pacman/po/{ko.po => uz.po} (87%) hooks/post-receive -- The official pacman repository

1 0

[pacman-dev] [PATCH 1/2] version: fix memory leak in early return
by Dave Reisner 18 Nov '14

18 Nov '14

--- lib/libalpm/version.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/libalpm/version.c b/lib/libalpm/version.c index 0048167..6d68aac 100644 --- a/lib/libalpm/version.c +++ b/lib/libalpm/version.c @@ -109,7 +109,8 @@ static int rpmvercmp(const char *a, const char *b) /* If the separator lengths were different, we are also finished */ if ((one - ptr1) != (two - ptr2)) { - return (one - ptr1) < (two - ptr2) ? -1 : 1; + ret = (one - ptr1) < (two - ptr2) ? -1 : 1; + goto cleanup; } ptr1 = one; -- 2.1.3

1 1