- Pacman-dev - lists.archlinux.org

[pacman-dev] [PATCH] alpm: log errors for scriptlets terminated by a signal
by Dave Reisner 21 Aug '13

21 Aug '13

Fixes FS#36618. Signed-off-by: Dave Reisner <dreisner(a)archlinux.org> --- We *could* print the signal name here as well, but signal value-to-name can actually vary by architecture so it's not clear that it's something we necessarily want to get into.... lib/libalpm/util.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/libalpm/util.c b/lib/libalpm/util.c index f1f760a..4b708ff 100644 --- a/lib/libalpm/util.c +++ b/lib/libalpm/util.c @@ -599,6 +599,10 @@ int _alpm_run_chroot(alpm_handle_t *handle, const char *cmd, char *const argv[]) _alpm_log(handle, ALPM_LOG_ERROR, _("command failed to execute correctly\n")); retval = 1; } + } else if(WIFSIGNALED(status) != 0) { + _alpm_log(handle, ALPM_LOG_ERROR, _("command terminated by signal %d\n"), + WTERMSIG(status)); + retval = 1; } } -- 1.8.3.4

3 3

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v4.1.2-108-gce7456b
by allan＠archlinux.org 21 Aug '13

21 Aug '13

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, master has been updated via ce7456b4ccbe3ca7b06c9b50fe59ce7367172c4f (commit) via d8c2ab0e6f52d9a790b608c254761ab4888bd547 (commit) via 15b667ef36c1720e12160f2ca983f9783ddaf3e4 (commit) via 3d3c7ebb0dfef248c53f7cfc3730ed3fd89756a9 (commit) via 9085aa43224474bc2c943f4d268d8dd4b735a665 (commit) via 247b9af02bd0d40109cc0ca40116a960c9f530e7 (commit) from c02b16c4cc00f7b33aad79207c15fb651903e9ba (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ce7456b4ccbe3ca7b06c9b50fe59ce7367172c4f Author: Allan McRae <allan(a)archlinux.org> Date: Mon Aug 12 21:09:01 2013 +1000 Store fgetc output as an int. Bug exposed on ARM when char is unsigned resulting in the comparison to EOF always failing. Signed-off-by: Allan McRae <allan(a)archlinux.org> commit d8c2ab0e6f52d9a790b608c254761ab4888bd547 Author: Andrew Gregory <andrew.gregory.8(a)gmail.com> Date: Fri Aug 9 09:15:40 2013 -0400 conflict.c: fix directory ownership check * append "/" to directories before searching package file lists * use lstat over stat so symlinks aren't resolved * fix the inverted check for stat's return value Signed-off-by: Andrew Gregory <andrew.gregory.8(a)gmail.com> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 15b667ef36c1720e12160f2ca983f9783ddaf3e4 Author: Olivier Brunel <i.am.jack.mail(a)gmail.com> Date: Wed Aug 7 19:04:52 2013 +0200 doc/repo-add: Add note on when signatures are added to the db Signed-off-by: Olivier Brunel <i.am.jack.mail(a)gmail.com> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 3d3c7ebb0dfef248c53f7cfc3730ed3fd89756a9 Author: Dave Reisner <dreisner(a)archlinux.org> Date: Mon Aug 5 18:04:37 2013 -0400 makepkg: allow make-style environment var overrides This allows for VAR=value and VAR+=value variable declarations. Signed-off-by: Dave Reisner <dreisner(a)archlinux.org> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 9085aa43224474bc2c943f4d268d8dd4b735a665 Author: Andrew Gregory <andrew.gregory.8(a)gmail.com> Date: Sun Aug 4 17:18:08 2013 -0400 check.c: break backup file search loop after match Signed-off-by: Andrew Gregory <andrew.gregory.8(a)gmail.com> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 247b9af02bd0d40109cc0ca40116a960c9f530e7 Author: Allan McRae <allan(a)archlinux.org> Date: Mon Jul 15 14:14:46 2013 +1000 Do not refer to FlySpray numbers These references to bug numbers assume we will forever be using that bug tracker. It is better to properly comment the code instead (which was done in almost all cases anyway). Signed-off-by: Allan McRae <allan(a)archlinux.org> ----------------------------------------------------------------------- Summary of changes: doc/makepkg.8.txt | 2 +- doc/repo-add.8.txt | 3 +++ lib/libalpm/add.c | 2 +- lib/libalpm/conflict.c | 16 ++++++++++++---- lib/libalpm/dload.c | 2 +- scripts/makepkg.sh.in | 17 ++++++++++++++++- src/pacman/check.c | 2 +- src/pacman/pacman.c | 4 +++- src/pacman/sync.c | 2 +- src/pacman/util.c | 4 ++-- .../tests/{fileconflict030.py => fileconflict031.py} | 11 +++++------ .../tests/{fileconflict030.py => fileconflict032.py} | 14 +++++++------- 12 files changed, 53 insertions(+), 26 deletions(-) copy test/pacman/tests/{fileconflict030.py => fileconflict031.py} (61%) copy test/pacman/tests/{fileconflict030.py => fileconflict032.py} (54%) hooks/post-receive -- The official pacman repository

1 0

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v4.1.2-102-gc02b16c
by allan＠archlinux.org 21 Aug '13

21 Aug '13

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, master has been updated via c02b16c4cc00f7b33aad79207c15fb651903e9ba (commit) via 4d4f46ba2a9bb168f0e5f1139738c2cf4dc260ca (commit) via bf1c8e3a3c8d8becfb1f8c990d29ff459271b707 (commit) via 3d2c8e1fd0e2b1c74f82c6b2b667964768ea4cb0 (commit) via ab84249a58b0976c941860e48461956c57b67d10 (commit) via 26da037fd55040bcda834e2c95bf25e52f8a739e (commit) via 8287312c294b7e125cabe1bb0238156049a725cd (commit) via 36f702ba826f2d3bebb4df3232c1b2b64a03f8a5 (commit) via 74c8943682829329eaafa1e76482ca31877725fa (commit) from 12e00af5315135a29a66c9aaa01e141a32d4634b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c02b16c4cc00f7b33aad79207c15fb651903e9ba Author: Andrew Gregory <andrew.gregory.8(a)gmail.com> Date: Fri Aug 2 08:29:03 2013 -0400 ini.c: give recursion limit file scope The recursion limit is an artificial limitation imposed to prevent memory exhaustion in a recursive function. Giving it file-level scope increases its visibility. Signed-off-by: Andrew Gregory <andrew.gregory.8(a)gmail.com> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 4d4f46ba2a9bb168f0e5f1139738c2cf4dc260ca Author: Andrew Gregory <andrew.gregory.8(a)gmail.com> Date: Mon Jul 22 02:46:53 2013 -0400 ini.c: make errors in includes fatal If an error in the main file would be fatal there is little reason to ignore the error in an included file. Signed-off-by: Andrew Gregory <andrew.gregory.8(a)gmail.com> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit bf1c8e3a3c8d8becfb1f8c990d29ff459271b707 Author: Andrew Gregory <andrew.gregory.8(a)gmail.com> Date: Mon Jul 22 02:46:52 2013 -0400 ini.c: reuse line buffer By the time we make the recursive call we have already finished with the line buffer, making it safe to reuse. Signed-off-by: Andrew Gregory <andrew.gregory.8(a)gmail.com> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 3d2c8e1fd0e2b1c74f82c6b2b667964768ea4cb0 Author: Andrew Gregory <andrew.gregory.8(a)gmail.com> Date: Mon Jul 22 02:46:50 2013 -0400 conf.c: extract ini parsing code to separate files Move _parseconfig to ini.c as _parse_ini and create a convenient wrapper for the public API. Signed-off-by: Andrew Gregory <andrew.gregory.8(a)gmail.com> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit ab84249a58b0976c941860e48461956c57b67d10 Author: Andrew Gregory <andrew.gregory.8(a)gmail.com> Date: Mon Jul 22 02:46:49 2013 -0400 conf.c: pass _parse_directive as a callback This will allow passing arbitrary key/value handlers. Signed-off-by: Andrew Gregory <andrew.gregory.8(a)gmail.com> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 26da037fd55040bcda834e2c95bf25e52f8a739e Author: Andrew Gregory <andrew.gregory.8(a)gmail.com> Date: Mon Jul 22 02:46:48 2013 -0400 conf.c: move section handling out of _parseconfig _parseconfig now tracks the current section name directly so that the name stored in the section struct is just a pointer to the one stored by _parseconfig. Signed-off-by: Andrew Gregory <andrew.gregory.8(a)gmail.com> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 8287312c294b7e125cabe1bb0238156049a725cd Author: Andrew Gregory <andrew.gregory.8(a)gmail.com> Date: Mon Jul 22 02:46:47 2013 -0400 conf.c: move directive parsing out of _parseconfig Include directives no longer have to be within a section. Signed-off-by: Andrew Gregory <andrew.gregory.8(a)gmail.com> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 36f702ba826f2d3bebb4df3232c1b2b64a03f8a5 Author: Andrew Gregory <andrew.gregory.8(a)gmail.com> Date: Mon Jul 22 02:46:46 2013 -0400 conf.c: move repo parsing out of _parseconfig Signed-off-by: Andrew Gregory <andrew.gregory.8(a)gmail.com> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 74c8943682829329eaafa1e76482ca31877725fa Author: Andrew Gregory <andrew.gregory.8(a)gmail.com> Date: Mon Jul 22 02:46:45 2013 -0400 conf.c: add parse_options to section_t This consolidates all of our state information into a single variable. Signed-off-by: Andrew Gregory <andrew.gregory.8(a)gmail.com> Signed-off-by: Allan McRae <allan(a)archlinux.org> ----------------------------------------------------------------------- Summary of changes: src/pacman/Makefile.am | 1 + src/pacman/conf.c | 255 ++++++++--------------------- src/pacman/ini.c | 217 ++++++++++++++++++++++++ src/{common/util-common.h => pacman/ini.h} | 18 +- 4 files changed, 296 insertions(+), 195 deletions(-) create mode 100644 src/pacman/ini.c copy src/{common/util-common.h => pacman/ini.h} (68%) hooks/post-receive -- The official pacman repository

1 0

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v4.1.2-93-g12e00af
by allan＠archlinux.org 21 Aug '13

21 Aug '13

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, master has been updated via 12e00af5315135a29a66c9aaa01e141a32d4634b (commit) via 403c175dbc84a8198b92bbe76f66eade613cff48 (commit) via 228221003df40fa0782656d0e32d6ad072a4eec1 (commit) via 9263cc58747a1b2ed5a345e5b35014b44decd444 (commit) via 1152052b3e27e3252f6685a369fce8a426710015 (commit) via 429b956fb2d21309cae0560d6d98225969447737 (commit) via d3726bbd26769b1ab7cdbedda109db31bdfb0f78 (commit) via 2e2c614f0e35dfbf80c17d55377418c1ded3f065 (commit) from 48861f509a817649f6cbda63e5ed253bdebc4f56 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 12e00af5315135a29a66c9aaa01e141a32d4634b Author: Andrew Gregory <andrew.gregory.8(a)gmail.com> Date: Thu Aug 1 22:59:11 2013 -0400 pactest: remove results summary This functionality can be provided by a test harness. Having pactest output this information as well clutters the result log created by automake. Signed-off-by: Andrew Gregory <andrew.gregory.8(a)gmail.com> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 403c175dbc84a8198b92bbe76f66eade613cff48 Author: Andrew Gregory <andrew.gregory.8(a)gmail.com> Date: Thu Jul 18 03:43:51 2013 -0400 integrate tests with automake Signed-off-by: Andrew Gregory <andrew.gregory.8(a)gmail.com> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 228221003df40fa0782656d0e32d6ad072a4eec1 Author: Andrew Gregory <andrew.gregory.8(a)gmail.com> Date: Mon Jul 29 15:34:04 2013 -0400 pactest: accept test names without a switch This removes the --test switch, making it easier to call pactest from a test harness. Signed-off-by: Andrew Gregory <andrew.gregory.8(a)gmail.com> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 9263cc58747a1b2ed5a345e5b35014b44decd444 Author: Andrew Gregory <andrew.gregory.8(a)gmail.com> Date: Mon Jul 29 14:57:59 2013 -0400 provide default values for test scripts Our test scripts currently require that the first argument be the library or binary to be tested. This makes integrating them with automake which doesn't have a mechanism for passing specific arguments to individual tests. Instead, provide a default built from paths in the environment which can be provided to all test scripts by automake. Signed-off-by: Andrew Gregory <andrew.gregory.8(a)gmail.com> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 1152052b3e27e3252f6685a369fce8a426710015 Author: Andrew Gregory <andrew.gregory.8(a)gmail.com> Date: Mon Jul 29 15:22:07 2013 -0400 convert pactest to TAP output Each test produces a single TAP result with the rules run in a sub-test. This reduces output when run under automake and makes it possible to continue setting expectfailure at the test level rather than per-rule. Signed-off-by: Andrew Gregory <andrew.gregory.8(a)gmail.com> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 429b956fb2d21309cae0560d6d98225969447737 Author: Andrew Gregory <andrew.gregory.8(a)gmail.com> Date: Thu Aug 1 22:51:24 2013 -0400 pactest: treat unknown rules as failures Tests should only be skipped when they aren't relevant, not when the test itself is bad. Signed-off-by: Andrew Gregory <andrew.gregory.8(a)gmail.com> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit d3726bbd26769b1ab7cdbedda109db31bdfb0f78 Author: Andrew Gregory <andrew.gregory.8(a)gmail.com> Date: Thu Jul 18 03:41:08 2013 -0400 convert test scripts to tap output Signed-off-by: Andrew Gregory <andrew.gregory.8(a)gmail.com> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 2e2c614f0e35dfbf80c17d55377418c1ded3f065 Author: Andrew Gregory <andrew.gregory.8(a)gmail.com> Date: Sun Aug 18 15:06:30 2013 -0400 query006: only set expectfailure on 32-bit systems Use the architecture of the python interpreter running the test to detect 32bit systems. Signed-off-by: Andrew Gregory <andrew.gregory.8(a)gmail.com> Signed-off-by: Allan McRae <allan(a)archlinux.org> ----------------------------------------------------------------------- Summary of changes: .gitignore | 2 + Makefile.am | 36 +- build-aux/tap-driver.sh | 652 +++++++++++++++++++++++++++++++++++++ configure.ac | 1 + test/pacman/pactest.py | 29 +- test/pacman/pmdb.py | 5 +- test/pacman/pmenv.py | 87 +---- test/pacman/pmrule.py | 15 +- test/pacman/pmtest.py | 26 +- test/pacman/tap.py | 64 ++++ test/pacman/tests/TESTS | 288 ++++++++++++++++ test/pacman/tests/query006.py | 5 +- test/pacman/util.py | 4 +- test/scripts/human_to_size_test.sh | 29 +- test/scripts/parseopts_test.sh | 30 +- test/util/pacsorttest.sh | 41 +-- test/util/vercmptest.sh | 39 +-- 17 files changed, 1140 insertions(+), 213 deletions(-) create mode 100755 build-aux/tap-driver.sh create mode 100644 test/pacman/tap.py create mode 100644 test/pacman/tests/TESTS hooks/post-receive -- The official pacman repository

1 0

[pacman-dev] [PATCH] Use file locks (flock) to stop multiple pacman instances from running concurrently. This improves the current model by automatically removing locks held by programs has failed to remove the lock, for example at a crash, forced kill or power outage.
by Mattias Andrée 19 Aug '13

19 Aug '13

This allows for further improvement of pacman where shared locks could also be used, in cases there pacman only reads the database and does not edit it. File locks also makes it easy to let pacman wait until the block instance has finished, by just not using the LOCK_NB flag. --- lib/libalpm/be_sync.c | 5 +---- lib/libalpm/handle.c | 26 ++++++++++++++------------ lib/libalpm/handle.h | 2 +- lib/libalpm/trans.c | 7 +------ scripts/pacman-db-upgrade.sh.in | 9 +++++---- scripts/pacman-optimize.sh.in | 9 +++++---- 6 files changed, 27 insertions(+), 31 deletions(-) diff --git a/lib/libalpm/be_sync.c b/lib/libalpm/be_sync.c index 0b99684..e7c8c4b 100644 --- a/lib/libalpm/be_sync.c +++ b/lib/libalpm/be_sync.c @@ -284,10 +284,7 @@ int SYMEXPORT alpm_db_update(int force, alpm_db_t *db) cleanup: - if(_alpm_handle_unlock(handle)) { - _alpm_log(handle, ALPM_LOG_WARNING, _("could not remove lock file %s\n"), - handle->lockfile); - } + _alpm_handle_unlock(handle); free(syncpath); umask(oldmask); return ret; diff --git a/lib/libalpm/handle.c b/lib/libalpm/handle.c index 53c86c5..5d1cfb7 100644 --- a/lib/libalpm/handle.c +++ b/lib/libalpm/handle.c @@ -27,6 +27,7 @@ #include <sys/types.h> #include <syslog.h> #include <sys/stat.h> +#include <sys/file.h> #include <fcntl.h> /* libalpm */ @@ -44,6 +45,7 @@ alpm_handle_t *_alpm_handle_new(void) CALLOC(handle, 1, sizeof(alpm_handle_t), return NULL); handle->deltaratio = 0.0; + handle->lckstream = -1; return handle; } @@ -95,7 +97,7 @@ int _alpm_handle_lock(alpm_handle_t *handle) char *dir, *ptr; ASSERT(handle->lockfile != NULL, return -1); - ASSERT(handle->lckstream == NULL, return 0); + ASSERT(handle->lckstream < 0, return 0); /* create the dir of the lockfile first */ dir = strdup(handle->lockfile); @@ -110,14 +112,14 @@ int _alpm_handle_lock(alpm_handle_t *handle) FREE(dir); do { - fd = open(handle->lockfile, O_WRONLY | O_CREAT | O_EXCL, 0000); + fd = open(handle->lockfile, O_WRONLY | O_CREAT); } while(fd == -1 && errno == EINTR); if(fd >= 0) { - FILE *f = fdopen(fd, "w"); - fprintf(f, "%ld\n", (long)getpid()); - fflush(f); fsync(fd); - handle->lckstream = f; + if(flock(fd, LOCK_EX | LOCK_NB) < 0) { + return -1; + } + handle->lckstream = fd; return 0; } return -1; @@ -127,14 +129,14 @@ int _alpm_handle_lock(alpm_handle_t *handle) int _alpm_handle_unlock(alpm_handle_t *handle) { ASSERT(handle->lockfile != NULL, return -1); - ASSERT(handle->lckstream != NULL, return 0); - - fclose(handle->lckstream); - handle->lckstream = NULL; + ASSERT(handle->lckstream >= 0, return 0); - if(unlink(handle->lockfile) && errno != ENOENT) { - return -1; + flock(handle->lckstream, LOCK_UN); + if(flock(handle->lckstream, LOCK_EX | LOCK_NB) == 0) { + unlink(handle->lockfile); + flock(handle->lckstream, LOCK_UN); } + handle->lckstream = NULL; return 0; } diff --git a/lib/libalpm/handle.h b/lib/libalpm/handle.h index 5e84d58..7ca90ff 100644 --- a/lib/libalpm/handle.h +++ b/lib/libalpm/handle.h @@ -55,7 +55,7 @@ struct __alpm_handle_t { alpm_db_t *db_local; /* local db pointer */ alpm_list_t *dbs_sync; /* List of (alpm_db_t *) */ FILE *logstream; /* log file stream pointer */ - FILE *lckstream; /* lock file stream pointer if one exists */ + int lckstream; /* lock file file descriptor if one exists */ alpm_trans_t *trans; #ifdef HAVE_LIBCURL diff --git a/lib/libalpm/trans.c b/lib/libalpm/trans.c index 8d4e0e7..122f35b 100644 --- a/lib/libalpm/trans.c +++ b/lib/libalpm/trans.c @@ -215,12 +215,7 @@ int SYMEXPORT alpm_trans_release(alpm_handle_t *handle) /* unlock db */ if(!nolock_flag) { - if(_alpm_handle_unlock(handle)) { - _alpm_log(handle, ALPM_LOG_WARNING, _("could not remove lock file %s\n"), - handle->lockfile); - alpm_logaction(handle, ALPM_CALLER_PREFIX, - "warning: could not remove lock file %s\n", handle->lockfile); - } + _alpm_handle_unlock(handle); } return 0; diff --git a/scripts/pacman-db-upgrade.sh.in b/scripts/pacman-db-upgrade.sh.in index a1630c5..20cf035 100644 --- a/scripts/pacman-db-upgrade.sh.in +++ b/scripts/pacman-db-upgrade.sh.in @@ -102,12 +102,12 @@ dbroot="${dbroot%/}" # form the path to our lockfile location lockfile="${dbroot}/db.lck" -# make sure pacman isn't running -if [[ -f $lockfile ]]; then +# make sure pacman isn't running and stop other instances for starting +exec 100<>"$lockfile" +if ! flock -x --nonblock 100; then + flock --close 100 die "$(gettext "Pacman lock file was found. Cannot run while pacman is running.")" fi -# do not let pacman run while we do this -touch "$lockfile" # pacman-3.4 to 3.5 upgrade - merge depends into desc if [[ $(find "$dbroot"/local -name depends) ]]; then @@ -123,5 +123,6 @@ fi # remove the lock file rm -f "$lockfile" +flock --close 100 # vim: set ts=2 sw=2 noet: diff --git a/scripts/pacman-optimize.sh.in b/scripts/pacman-optimize.sh.in index 47fbb49..8c6e556 100644 --- a/scripts/pacman-optimize.sh.in +++ b/scripts/pacman-optimize.sh.in @@ -114,12 +114,12 @@ dbroot="${dbroot%/}" lockfile="${dbroot}/db.lck" localdb="${dbroot}/local" -# make sure pacman isn't running -if [[ -f $lockfile ]]; then +# make sure pacman isn't running and stop other instances for starting +exec 100<>"$lockfile" +if ! flock -x --nonblock 100; then + flock --close 100 die "$(gettext "Pacman lock file was found. Cannot run while pacman is running.")" fi -# do not let pacman run while we do this -touch "$lockfile" workdir=$(mktemp -d "${TMPDIR:-/tmp}/pacman-optimize.XXXXXXXXXX") || die_r "$(gettext "Can not create temp directory for database building.")\n" >&2 @@ -178,6 +178,7 @@ rm -rf "$localdb.old" # remove the lock file and our working directory with sums and tarfile rm -f "$lockfile" +flock --close 100 rm -rf "$workdir" echo -- 1.8.3.4

6 12

[pacman-dev] [PATCH 0/7] integrate test suite with automake
by Andrew Gregory 18 Aug '13

18 Aug '13

This patchset converts the output of all of our tests to tap [1] and fully integrates them with automake so that tests can be run in parallel with `make check`. The test suite may also be run with other test harnesses such as perl's prove which can do such interesting things as remember which tests failed and run only those on subsequent invocations. The documentation for integrating tests is here [2]. [1] http://podwiki.hexten.net/TAP/TAP.html?page=TAP [2] http://www.gnu.org/software/automake/manual/html_node/Parallel-Test-Harness… Andrew Gregory (7): convert test scripts to tap output pactest: treat unknown rules as failures convert pactest to TAP output provide default values for test scripts pactest: accept test names without a switch integrate tests with automake pactest: remove results summary .gitignore | 2 + Makefile.am | 36 +- build-aux/tap-driver.sh | 652 +++++++++++++++++++++++++++++++++++++ configure.ac | 1 + test/pacman/pactest.py | 29 +- test/pacman/pmdb.py | 5 +- test/pacman/pmenv.py | 87 +---- test/pacman/pmrule.py | 15 +- test/pacman/pmtest.py | 26 +- test/pacman/tap.py | 64 ++++ test/pacman/tests/TESTS | 288 ++++++++++++++++ test/pacman/util.py | 4 +- test/scripts/human_to_size_test.sh | 29 +- test/scripts/parseopts_test.sh | 30 +- test/util/pacsorttest.sh | 41 +-- test/util/vercmptest.sh | 39 +-- 16 files changed, 1136 insertions(+), 212 deletions(-) create mode 100755 build-aux/tap-driver.sh create mode 100644 test/pacman/tap.py create mode 100644 test/pacman/tests/TESTS -- 1.8.3.4

2 14

[pacman-dev] [PATCH] Add Doxygen documentation for add.c of libalpm
by Richard Pougnet 18 Aug '13

18 Aug '13

Signed-off-by: Richard Pougnet <richard(a)pougnet.ca> --- lib/libalpm/add.c | 52 +++++++++++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 49 insertions(+), 3 deletions(-) diff --git a/lib/libalpm/add.c b/lib/libalpm/add.c index 45c57b0..73112fc 100644 --- a/lib/libalpm/add.c +++ b/lib/libalpm/add.c @@ -47,7 +47,16 @@ #include "remove.h" #include "handle.h" -/** Add a package to the transaction. */ +/** Adds a package to transaction add list + * Finds the target package and compares + * to the local version (if it exists). + * If version is newer then cache, or downgrade + * is desired, the package is then added to the list + * and log file is updated. + * @param handle the context handle + * @param pkg the package to be added + * @return 0 on success, 1 on error + */ int SYMEXPORT alpm_add_pkg(alpm_handle_t *handle, alpm_pkg_t *pkg) { const char *pkgname, *pkgver; @@ -104,6 +113,18 @@ int SYMEXPORT alpm_add_pkg(alpm_handle_t *handle, alpm_pkg_t *pkg) return 0; } +/** Extracts a package. + * Loads the package archive, reads it + * and then extracts. + * If non critical error occured, logs and + * continues. Else, extract fails. + * @param handle the context handle + * @param archive the package archive + * @param entry the entry to be extracted + * @param filename the filename of the archive + * @param origname the name of the package + * @return 0 on success, 1 on error + */ static int perform_extraction(alpm_handle_t *handle, struct archive *archive, struct archive_entry *entry, const char *filename, const char *origname) { @@ -129,6 +150,12 @@ static int perform_extraction(alpm_handle_t *handle, struct archive *archive, } return 0; } +/** Attempts to rename an entry + * @param handle the context handler + * @param src the original name + * @param dest the final name + * @return 0 on success, 1 on error +*/ static int try_rename(alpm_handle_t *handle, const char *src, const char *dest) { @@ -141,7 +168,14 @@ static int try_rename(alpm_handle_t *handle, const char *src, const char *dest) } return 0; } - +/** Extracts a single file + * @param handle the context handler + * @param archive the package archive + * @param entry the archive entry + * @param newpkg the new package + * @param oldpkg the old package + * @return 0 on success, 1 on error +*/ static int extract_single_file(alpm_handle_t *handle, struct archive *archive, struct archive_entry *entry, alpm_pkg_t *newpkg, alpm_pkg_t *oldpkg) { @@ -450,7 +484,15 @@ needbackup_cleanup: free(entryname_orig); return errors; } - +/** Commits a package to the database + * Creates a database entry for a newly installed + * package. + * @param handle the context handler + * @param newpkg the package to be entered + * @param pkg_current the current package number + * @param pkg_count total number of packages to be committed + * @return 0 on success, -1 on error +*/ static int commit_single_pkg(alpm_handle_t *handle, alpm_pkg_t *newpkg, size_t pkg_current, size_t pkg_count) { @@ -667,6 +709,10 @@ cleanup: return ret; } +/** Upgrades a package + * @param handle the context handler + * @return 0 on success, -1 on error +*/ int _alpm_upgrade_packages(alpm_handle_t *handle) { size_t pkg_count, pkg_current; -- 1.8.3.4

2 1

[pacman-dev] [PATCH] Store fgetc output as an int.
by Allan McRae 12 Aug '13

12 Aug '13

Bug exposed on ARM when char is unsigned resulting in the comparison to EOF always failing. Signed-off-by: Allan McRae <allan(a)archlinux.org> --- src/pacman/pacman.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/pacman/pacman.c b/src/pacman/pacman.c index 5ce8747..24fd57f 100644 --- a/src/pacman/pacman.c +++ b/src/pacman/pacman.c @@ -830,13 +830,15 @@ int main(int argc, char *argv[]) int target_found = 0; size_t current_size = PATH_MAX; char *vdata, *line = malloc(current_size); + int c; /* remove the '-' from the list */ pm_targets = alpm_list_remove_str(pm_targets, "-", &vdata); free(vdata); i = 0; - while((line[i] = (char)fgetc(stdin)) != EOF) { + while((c = fgetc(stdin)) != EOF) { + line[i] = (char)c; if(isspace((unsigned char)line[i])) { /* avoid adding zero length arg when multiple spaces separate args */ if(i > 0) { -- 1.8.3.4

1 0

[pacman-dev] Conflict when replacing a folder with subfolders by a file in a package update
by Timothée Ravier 09 Aug '13

09 Aug '13

Hi, Pacman exits with a conflict error if the package updated is replacing a folder with subfolders inside by a single file with the same name. This may be a bug as I don't know any cases where this cloud make sense. But I may be wrong of course. I'll let you decide. Testing was done on fully updated Arch Linux system with the following repositories enabled: kf5, kde-unstable, testing, core, extra, community-testing, community, multilib-testing, multilib. Example PKGBUILDs to reproduce the issue: $ cat PKGBUILD.1 pkgname=testpkg pkgver=1 pkgrel=1 pkgdesc="Test package" arch=('i686' 'x86_64') license=('GPL') package() { cd "${pkgdir}" mkdir -p usr/test/test } $ cat PKGBUILD.2 pkgname=testpkg pkgver=1 pkgrel=2 pkgdesc="Test package" arch=('i686' 'x86_64') license=('GPL') package() { cd "${pkgdir}" mkdir usr touch usr/test } Pacman output: $ sudo pacman -U testpkg-1-2-x86_64.pkg.tar.xz loading packages... resolving dependencies... looking for inter-conflicts... Packages (1): Name Old Version New Version Net Change testpkg 1-1 1-2 0.00 MiB Total Installed Size: 0.00 MiB Net Upgrade Size: 0.00 MiB :: Proceed with installation? [Y/n] (1/1) checking keys in keyring [--------------------------------------] 100% (1/1) checking package integrity [--------------------------------------] 100% (1/1) loading package files [--------------------------------------] 100% (1/1) checking for file conflicts [--------------------------------------] 100% error: failed to commit transaction (conflicting files) testpkg: /usr/test exists in filesystem Errors occurred, no packages were upgraded. Cheers, Tim

3 3

[pacman-dev] [PATCH 0/5] Version the local database
by Allan McRae 08 Aug '13

08 Aug '13

With removing directory symlink support, we need to make an adjustment to the users local database to adjust any path that relied in that "feature". As this is not a readily detectable change, as was the case in our last local database adjustment, we need to add something to track the local database version. The file ".alpm_db_version" is added to the local database root. This file is automatically created whenever the local database directory is absent or empty. This store the current database version as an integer. I have chosen to use the (next) libalpm soname version so it is easy for us to track what versions are needed. Allan McRae (5): Create local database directory if it is missing Add version file when creating local database directory Add version file to empty local database Check the version of the local database during validation Extend database upgrade script to handle alpm db version 9 lib/libalpm/be_local.c | 118 +++++++++++++++++++++++++++------------- scripts/pacman-db-upgrade.sh.in | 46 ++++++++++++---- test/pacman/pmdb.py | 2 + test/pacman/pmtest.py | 3 + 4 files changed, 121 insertions(+), 48 deletions(-) -- 1.8.3.3

2 9