- Pacman-dev - lists.archlinux.org

[pacman-dev] My repo has moved
by Allan McRae 03 Sep '09

03 Sep '09

With the reinstall of the Arch server, my pacman working git repo has now moved to git://projects.archlinux.org/users/allan/pacman.git Allan

3 3

Re: [pacman-dev] makepkg -i should fail when packages cannot be installed
by Allan McRae 02 Sep '09

02 Sep '09

Pierre Schmitz wrote: > Hi, > > I would file a bug report but somehow... > > It seems makepkg -i just throws a warning if it cannot install the package > after build. I would prefer if it would at least return something different > from 0. > > My scripts assume that everything is fine if makepkg retuns 0 and an inter > package file conflict wasn't noticed due to the behaviour that makepkg did > return 0 even if something went wrong. > Hmmm... there was a bug report that was the opposite. The reasoning here is that makepkg did not fail, rather pacman failed to install the successfully built package. The same occurs when pacman fails to remove deps as asked by makepkg. Allan _________________________________________________________________ Use Hotmail to send and receive mail from your different email accounts. http://clk.atdmt.com/UKM/go/167688463/direct/01/

5 5

[pacman-dev] [PATCH] Removing strndup and a small typo fix
by Laszlo Papp 02 Sep '09

02 Sep '09

Code cleaning, removing strndup, because it's available with glibc in the same manner, and a small typo fix. Signed-off-by: Laszlo Papp <djszapi2(a)gmail.com> --- src/pacman/package.c | 2 +- src/pacman/util.c | 12 ------------ src/pacman/util.h | 4 ---- 3 files changed, 1 insertions(+), 17 deletions(-) diff --git a/src/pacman/package.c b/src/pacman/package.c index 328d5bf..3b14516 100644 --- a/src/pacman/package.c +++ b/src/pacman/package.c @@ -84,7 +84,7 @@ void dump_pkg_full(pmpkg_t *pkg, int level) } if(level>0) { - /* compute this here so we don't get a puase in the middle of output */ + /* compute this here so we don't get a pause in the middle of output */ requiredby = alpm_pkg_compute_requiredby(pkg); } diff --git a/src/pacman/util.c b/src/pacman/util.c index a02b43c..a95d82e 100644 --- a/src/pacman/util.c +++ b/src/pacman/util.c @@ -819,18 +819,6 @@ static size_t strnlen(const char *s, size_t max) for(p = s; *p && max--; ++p); return(p - s); } - -char *strndup(const char *s, size_t n) -{ - size_t len = strnlen(s, n); - char *new = (char *) malloc(len + 1); - - if (new == NULL) - return NULL; - - new[len] = '\0'; - return (char *) memcpy(new, s, len); -} #endif /* vim: set ts=2 sw=2 noet: */ diff --git a/src/pacman/util.h b/src/pacman/util.h index 1282422..ce5e019 100644 --- a/src/pacman/util.h +++ b/src/pacman/util.h @@ -64,10 +64,6 @@ int pm_fprintf(FILE *stream, pmloglevel_t level, const char *format, ...) __attr int pm_vfprintf(FILE *stream, pmloglevel_t level, const char *format, va_list args) __attribute__((format(printf,3,0))); int pm_vasprintf(char **string, pmloglevel_t level, const char *format, va_list args) __attribute__((format(printf,3,0))); -#ifndef HAVE_STRNDUP -char *strndup(const char *s, size_t n); -#endif - #endif /* _PM_UTIL_H */ /* vim: set ts=2 sw=2 noet: */ -- 1.6.4.1

3 3

[pacman-dev] makepkg -i should fail when packages cannot be installed
by Pierre Schmitz 01 Sep '09

01 Sep '09

Hi, I would file a bug report but somehow... It seems makepkg -i just throws a warning if it cannot install the package after build. I would prefer if it would at least return something different from 0. My scripts assume that everything is fine if makepkg retuns 0 and an inter package file conflict wasn't noticed due to the behaviour that makepkg did return 0 even if something went wrong. -- Pierre Schmitz, http://users.archlinux.de/~pierre

1 0

[pacman-dev] [PATCH] Add a new reason field to pmconflict_t struct
by Nagy Gabor 01 Sep '09

01 Sep '09

>From 841439f2d5d8c8e750d7abe186a22f53f7f87729 Mon Sep 17 00:00:00 2001 From: Nagy Gabor <ngaba(a)bibl.u-szeged.hu> Date: Mon, 31 Aug 2009 16:20:18 +0200 Subject: [PATCH] Add a new reason field to pmconflict_t struct Sometimes "foo conflicts with bar" information is not enough, see this thread: http://bbs.archlinux.org/viewtopic.php?id=77647. That's why I added a new reason field to our pmconflict_t struct that stores the packager- defined conflict that induced the fact that package1 conflicts with package2. I modified the front-end (in callback.c, sync.c, upgrade.c) to print this new information as well (only if reason differs from package2). Signed-off-by: Nagy Gabor <ngaba(a)bibl.u-szeged.hu> --- lib/libalpm/alpm.h | 1 + lib/libalpm/conflict.c | 24 +++++++++++++++++++----- lib/libalpm/conflict.h | 3 ++- lib/libalpm/sync.c | 2 +- src/pacman/callback.c | 18 ++++++++++++++---- src/pacman/sync.c | 13 ++++++++++--- src/pacman/upgrade.c | 11 +++++++++-- 7 files changed, 56 insertions(+), 16 deletions(-) diff --git a/lib/libalpm/alpm.h b/lib/libalpm/alpm.h index 1f33078..86dd621 100644 --- a/lib/libalpm/alpm.h +++ b/lib/libalpm/alpm.h @@ -443,6 +443,7 @@ alpm_list_t *alpm_checkconflicts(alpm_list_t *pkglist); const char *alpm_conflict_get_package1(pmconflict_t *conflict); const char *alpm_conflict_get_package2(pmconflict_t *conflict); +const char *alpm_conflict_get_reason(pmconflict_t *conflict); pmdepmod_t alpm_dep_get_mod(const pmdepend_t *dep); const char *alpm_dep_get_name(const pmdepend_t *dep); diff --git a/lib/libalpm/conflict.c b/lib/libalpm/conflict.c index 07ef73c..be97f00 100644 --- a/lib/libalpm/conflict.c +++ b/lib/libalpm/conflict.c @@ -41,7 +41,7 @@ #include "cache.h" #include "deps.h" -pmconflict_t *_alpm_conflict_new(const char *package1, const char *package2) +pmconflict_t *_alpm_conflict_new(const char *package1, const char *package2, const char *reason) { pmconflict_t *conflict; @@ -51,6 +51,7 @@ pmconflict_t *_alpm_conflict_new(const char *package1, const char *package2) STRDUP(conflict->package1, package1, RET_ERR(PM_ERR_MEMORY, NULL)); STRDUP(conflict->package2, package2, RET_ERR(PM_ERR_MEMORY, NULL)); + STRDUP(conflict->reason, reason, RET_ERR(PM_ERR_MEMORY, NULL)); return(conflict); } @@ -59,6 +60,7 @@ void _alpm_conflict_free(pmconflict_t *conflict) { FREE(conflict->package2); FREE(conflict->package1); + FREE(conflict->reason); FREE(conflict); } @@ -69,6 +71,7 @@ pmconflict_t *_alpm_conflict_dup(const pmconflict_t *conflict) STRDUP(newconflict->package1, conflict->package1, RET_ERR(PM_ERR_MEMORY, NULL)); STRDUP(newconflict->package2, conflict->package2, RET_ERR(PM_ERR_MEMORY, NULL)); + STRDUP(newconflict->reason, conflict->reason, RET_ERR(PM_ERR_MEMORY, NULL)); return(newconflict); } @@ -122,9 +125,9 @@ static int does_conflict(pmpkg_t *pkg1, const char *conflict, pmpkg_t *pkg2) * @param pkg2 package causing conflict */ static void add_conflict(alpm_list_t **baddeps, const char *pkg1, - const char *pkg2) + const char *pkg2, const char *reason) { - pmconflict_t *conflict = _alpm_conflict_new(pkg1, pkg2); + pmconflict_t *conflict = _alpm_conflict_new(pkg1, pkg2, reason); if(conflict && !_alpm_conflict_isin(conflict, *baddeps)) { *baddeps = alpm_list_add(*baddeps, conflict); } else { @@ -168,9 +171,9 @@ static void check_conflict(alpm_list_t *list1, alpm_list_t *list2, if(does_conflict(pkg1, conflict, pkg2)) { if(order >= 0) { - add_conflict(baddeps, pkg1name, pkg2name); + add_conflict(baddeps, pkg1name, pkg2name, conflict); } else { - add_conflict(baddeps, pkg2name, pkg1name); + add_conflict(baddeps, pkg2name, pkg1name, conflict); } } } @@ -578,6 +581,17 @@ const char SYMEXPORT *alpm_conflict_get_package2(pmconflict_t *conflict) return conflict->package2; } +const char SYMEXPORT *alpm_conflict_get_reason(pmconflict_t *conflict) +{ + ALPM_LOG_FUNC; + + /* Sanity checks */ + ASSERT(handle != NULL, return(NULL)); + ASSERT(conflict != NULL, return(NULL)); + + return conflict->reason; +} + const char SYMEXPORT *alpm_fileconflict_get_target(pmfileconflict_t *conflict) { ALPM_LOG_FUNC; diff --git a/lib/libalpm/conflict.h b/lib/libalpm/conflict.h index 149c728..73a6e95 100644 --- a/lib/libalpm/conflict.h +++ b/lib/libalpm/conflict.h @@ -27,6 +27,7 @@ struct __pmconflict_t { char *package1; char *package2; + char *reason; }; struct __pmfileconflict_t { @@ -36,7 +37,7 @@ struct __pmfileconflict_t { char *ctarget; }; -pmconflict_t *_alpm_conflict_new(const char *package1, const char *package2); +pmconflict_t *_alpm_conflict_new(const char *package1, const char *package2, const char *reason); pmconflict_t *_alpm_conflict_dup(const pmconflict_t *conflict); void _alpm_conflict_free(pmconflict_t *conflict); int _alpm_conflict_isin(pmconflict_t *needle, alpm_list_t *haystack); diff --git a/lib/libalpm/sync.c b/lib/libalpm/sync.c index 4763924..dda4953 100644 --- a/lib/libalpm/sync.c +++ b/lib/libalpm/sync.c @@ -504,7 +504,7 @@ int _alpm_sync_prepare(pmtrans_t *trans, pmdb_t *db_local, alpm_list_t *dbs_sync pmpkg_t *local = _alpm_db_get_pkgfromcache(db_local, conflict->package2); int doremove = 0; QUESTION(trans, PM_TRANS_CONV_CONFLICT_PKG, conflict->package1, - conflict->package2, NULL, &doremove); + conflict->package2, conflict->reason, &doremove); if(doremove) { /* append to the removes list */ _alpm_log(PM_LOG_DEBUG, "electing '%s' for removal\n", conflict->package2); diff --git a/src/pacman/callback.c b/src/pacman/callback.c index 8b611f1..3df3ef5 100644 --- a/src/pacman/callback.c +++ b/src/pacman/callback.c @@ -259,10 +259,20 @@ void cb_trans_conv(pmtransconv_t event, void *data1, void *data2, alpm_pkg_get_name(data2)); break; case PM_TRANS_CONV_CONFLICT_PKG: - *response = yesno(_(":: %s conflicts with %s. Remove %s?"), - (char *)data1, - (char *)data2, - (char *)data2); + /* data parameters: package1, package2, conflict (string) */ + /* print conflict only if it contains more information than package2 */ + if(!strcmp(data2, data3)) { + *response = yesno(_(":: %s conflicts with %s. Remove %s?"), + (char *)data1, + (char *)data2, + (char *)data2); + } else { + *response = yesno(_(":: %s conflicts with %s (%s). Remove %s?"), + (char *)data1, + (char *)data2, + (char *)data3, + (char *)data2); + } break; case PM_TRANS_CONV_REMOVE_PKGS: { diff --git a/src/pacman/sync.c b/src/pacman/sync.c index dc93621..3314545 100644 --- a/src/pacman/sync.c +++ b/src/pacman/sync.c @@ -650,10 +650,17 @@ static int sync_trans(alpm_list_t *targets) } break; case PM_ERR_CONFLICTING_DEPS: - for(i = data; i; i = alpm_list_next(i)) { + for(i = data; i; i = alpm_list_next(i)) { pmconflict_t *conflict = alpm_list_getdata(i); - printf(_(":: %s: conflicts with %s\n"), - alpm_conflict_get_package1(conflict), alpm_conflict_get_package2(conflict)); + const char *package1 = alpm_conflict_get_package1(conflict); + const char *package2 = alpm_conflict_get_package2(conflict); + const char *reason = alpm_conflict_get_reason(conflict); + /* only print reason if it contains more information than package2 */ + if(!strcmp(package2, reason)) { + printf(_(":: %s: conflicts with %s\n"), package1, package2); + } else { + printf(_(":: %s: conflicts with %s (%s)\n"), package1, package2, reason); + } } break; default: diff --git a/src/pacman/upgrade.c b/src/pacman/upgrade.c index 1570f95..9c3690d 100644 --- a/src/pacman/upgrade.c +++ b/src/pacman/upgrade.c @@ -104,8 +104,15 @@ int pacman_upgrade(alpm_list_t *targets) case PM_ERR_CONFLICTING_DEPS: for(i = data; i; i = alpm_list_next(i)) { pmconflict_t *conflict = alpm_list_getdata(i); - printf(_(":: %s: conflicts with %s\n"), - alpm_conflict_get_package1(conflict), alpm_conflict_get_package2(conflict)); + const char *package1 = alpm_conflict_get_package1(conflict); + const char *package2 = alpm_conflict_get_package2(conflict); + const char *reason = alpm_conflict_get_reason(conflict); + /* only print reason if it contains more information than package2 */ + if(!strcmp(package2, reason)) { + printf(_(":: %s: conflicts with %s\n"), package1, package2); + } else { + printf(_(":: %s: conflicts with %s (%s)\n"), package1, package2, reason); + } } break; case PM_ERR_FILE_CONFLICTS: -- 1.6.0.3

1 3

[pacman-dev] [PATCH] Do not remove conflict by default
by Nagy Gabor 31 Aug '09

31 Aug '09

>From 66cb7b5d48ae173944531318022d351f4e503172 Mon Sep 17 00:00:00 2001 From: Nagy Gabor <ngaba(a)bibl.u-szeged.hu> Date: Mon, 31 Aug 2009 23:54:51 +0200 Subject: [PATCH] Do not remove conflict by default When a conflict is detected, pacman asks if the user wants to remove the conflicting package. In many cases this is a bad idea. e.g. udev conflicts with initscripts (initscripts<2009.07). Remove initscripts [Y/n] This changes the query to [y/N]. The --noconfirm behavior has been also changed, because it chooses the default answer. Since the yes answer is more interesting in our pactests dealing with conflicts, I inserted '--ask=4' to all of them with one exception: sync042.py tests the no answer. Original-work-by: Allan McRae <allan(a)archlinux.org> Signed-off-by: Nagy Gabor <ngaba(a)bibl.u-szeged.hu> --- pactest/tests/sync042.py | 6 +++--- pactest/tests/sync043.py | 2 +- pactest/tests/sync044.py | 2 +- pactest/tests/sync1004.py | 2 +- pactest/tests/sync890.py | 2 +- pactest/tests/sync892.py | 2 +- pactest/tests/sync893.py | 2 +- pactest/tests/sync895.py | 2 +- pactest/tests/sync896.py | 2 +- pactest/tests/sync897.py | 2 +- pactest/tests/sync899.py | 2 +- pactest/tests/sync900.py | 2 +- pactest/tests/sync901.py | 2 +- pactest/tests/sync992.py | 2 +- pactest/tests/sync999.py | 2 +- src/pacman/callback.c | 4 ++-- 16 files changed, 19 insertions(+), 19 deletions(-) diff --git a/pactest/tests/sync042.py b/pactest/tests/sync042.py index 0aa7e37..7c3498d 100644 --- a/pactest/tests/sync042.py +++ b/pactest/tests/sync042.py @@ -9,6 +9,6 @@ self.addpkg2db("local", lp); self.args = "-S %s" % sp.name -self.addrule("PACMAN_RETCODE=0") -self.addrule("PKG_EXIST=pkg1") -self.addrule("!PKG_EXIST=pkg2") +self.addrule("PACMAN_RETCODE=1") +self.addrule("!PKG_EXIST=pkg1") +self.addrule("PKG_EXIST=pkg2") diff --git a/pactest/tests/sync043.py b/pactest/tests/sync043.py index 1302bf0..eb2f570 100644 --- a/pactest/tests/sync043.py +++ b/pactest/tests/sync043.py @@ -10,7 +10,7 @@ self.addpkg2db("local", lp1); lp1 = pmpkg("pkg3") self.addpkg2db("local", lp1); -self.args = "-S %s" % sp.name +self.args = "-S %s --ask=4" % sp.name self.addrule("PACMAN_RETCODE=0") self.addrule("PKG_EXIST=pkg1") diff --git a/pactest/tests/sync044.py b/pactest/tests/sync044.py index c4ff154..0c8fd2e 100644 --- a/pactest/tests/sync044.py +++ b/pactest/tests/sync044.py @@ -11,7 +11,7 @@ sp3 = pmpkg("pkg3") sp3.conflicts = ["pkg1"] self.addpkg2db("sync", sp3); -self.args = "-S pkg2" +self.args = "-S pkg2 --ask=4" self.addrule("PACMAN_RETCODE=0") self.addrule("!PKG_EXIST=pkg1") diff --git a/pactest/tests/sync1004.py b/pactest/tests/sync1004.py index f87bbe9..a9cee49 100644 --- a/pactest/tests/sync1004.py +++ b/pactest/tests/sync1004.py @@ -11,7 +11,7 @@ self.addpkg2db("sync", sp2) lp = pmpkg("depend") self.addpkg2db("local", lp) -self.args = "-S pkg1 pkg2" +self.args = "-S pkg1 pkg2 --ask=4" self.addrule("PACMAN_RETCODE=1") self.addrule("PKG_EXIST=depend") diff --git a/pactest/tests/sync890.py b/pactest/tests/sync890.py index 75947e9..e8380b7 100644 --- a/pactest/tests/sync890.py +++ b/pactest/tests/sync890.py @@ -12,7 +12,7 @@ lp2.conflicts = ["pkg3"] for p in lp1, lp2: self.addpkg2db("local", p) -self.args = "-S %s" % sp.name +self.args = "-S %s --ask=4" % sp.name self.addrule("PACMAN_RETCODE=0") self.addrule("PKG_EXIST=pkg1") diff --git a/pactest/tests/sync892.py b/pactest/tests/sync892.py index 04cc79c..dfd889e 100644 --- a/pactest/tests/sync892.py +++ b/pactest/tests/sync892.py @@ -16,7 +16,7 @@ lp2.conflicts = ["pkg3"] for p in lp1, lp2: self.addpkg2db("local", p) -self.args = "-S %s" % " ".join([p.name for p in sp1, sp2]) +self.args = "-S %s --ask=4" % " ".join([p.name for p in sp1, sp2]) self.addrule("PACMAN_RETCODE=0") self.addrule("!PKG_EXIST=pkg1") diff --git a/pactest/tests/sync893.py b/pactest/tests/sync893.py index 1c8494a..e96bb7b 100644 --- a/pactest/tests/sync893.py +++ b/pactest/tests/sync893.py @@ -13,7 +13,7 @@ self.addpkg2db("local", lp1) lp2 = pmpkg("pkg2") self.addpkg2db("local", lp2) -self.args = "-S %s" % " ".join([p.name for p in sp1, sp2]) +self.args = "-S %s --ask=4" % " ".join([p.name for p in sp1, sp2]) self.addrule("PACMAN_RETCODE=1") self.addrule("PKG_EXIST=pkg1") diff --git a/pactest/tests/sync895.py b/pactest/tests/sync895.py index 1b348c1..fd98786 100644 --- a/pactest/tests/sync895.py +++ b/pactest/tests/sync895.py @@ -12,7 +12,7 @@ lp2 = pmpkg("pkg2") lp2.depends = ["foo"] self.addpkg2db("local", lp2) -self.args = "-S %s" % sp.name +self.args = "-S %s --ask=4" % sp.name self.addrule("PACMAN_RETCODE=1") self.addrule("PKG_EXIST=pkg1") diff --git a/pactest/tests/sync896.py b/pactest/tests/sync896.py index a89b5c7..492bd7b 100644 --- a/pactest/tests/sync896.py +++ b/pactest/tests/sync896.py @@ -13,7 +13,7 @@ lp2 = pmpkg("pkg2") lp2.depends = ["foo"] self.addpkg2db("local", lp2) -self.args = "-S %s" % sp.name +self.args = "-S %s --ask=4" % sp.name self.addrule("PACMAN_RETCODE=0") self.addrule("!PKG_EXIST=pkg1") diff --git a/pactest/tests/sync897.py b/pactest/tests/sync897.py index f7bd3d7..8a1c5a7 100644 --- a/pactest/tests/sync897.py +++ b/pactest/tests/sync897.py @@ -16,7 +16,7 @@ self.addpkg2db("local", lp2) lp3 = pmpkg("pkg3") self.addpkg2db("local", lp3) -self.args = "-Su" +self.args = "-Su --ask=4" self.addrule("PACMAN_RETCODE=1") self.addrule("PKG_EXIST=pkg1") diff --git a/pactest/tests/sync899.py b/pactest/tests/sync899.py index a561ae6..fd30805 100644 --- a/pactest/tests/sync899.py +++ b/pactest/tests/sync899.py @@ -11,7 +11,7 @@ self.addpkg2db("local", lp1) lp2 = pmpkg("pkg2") self.addpkg2db("local", lp2) -self.args = "-Su" +self.args = "-Su --ask=4" self.addrule("PACMAN_RETCODE=0") self.addrule("PKG_EXIST=pkg1") diff --git a/pactest/tests/sync900.py b/pactest/tests/sync900.py index 16dfee1..744fad0 100644 --- a/pactest/tests/sync900.py +++ b/pactest/tests/sync900.py @@ -16,7 +16,7 @@ lp2 = pmpkg("pkg2") lp2.depends = ["foo"] self.addpkg2db("local", lp2) -self.args = "-S %s" % sp.name +self.args = "-S %s --ask=4" % sp.name self.addrule("PACMAN_RETCODE=0") self.addrule("!PKG_EXIST=foo") diff --git a/pactest/tests/sync901.py b/pactest/tests/sync901.py index bb420b7..f583453 100644 --- a/pactest/tests/sync901.py +++ b/pactest/tests/sync901.py @@ -16,7 +16,7 @@ lp2 = pmpkg("pkg2") lp2.depends = ["foo"] self.addpkg2db("local", lp2) -self.args = "-S %s" % sp.name +self.args = "-S %s --ask=4" % sp.name self.addrule("PACMAN_RETCODE=0") self.addrule("PKG_EXIST=foo") diff --git a/pactest/tests/sync992.py b/pactest/tests/sync992.py index a7ad111..63faaab 100644 --- a/pactest/tests/sync992.py +++ b/pactest/tests/sync992.py @@ -15,7 +15,7 @@ for p in sp1, sp2, sp3: lp1 = pmpkg("pkg2", "0.1-1") self.addpkg2db("local", lp1) -self.args = "-S %s" % " ".join([p.name for p in sp1, sp2]) +self.args = "-S %s --ask=4" % " ".join([p.name for p in sp1, sp2]) self.addrule("PACMAN_RETCODE=0") self.addrule("PKG_EXIST=pkg1") diff --git a/pactest/tests/sync999.py b/pactest/tests/sync999.py index 69089fa..89447ca 100644 --- a/pactest/tests/sync999.py +++ b/pactest/tests/sync999.py @@ -14,7 +14,7 @@ self.addpkg2db("local", lp1) lp2 = pmpkg("pkg2") self.addpkg2db("local", lp2) -self.args = "-Su" +self.args = "-Su --ask=4" self.addrule("PACMAN_RETCODE=0") self.addrule("PKG_EXIST=pkg1") diff --git a/src/pacman/callback.c b/src/pacman/callback.c index 4ec9b60..97dffc9 100644 --- a/src/pacman/callback.c +++ b/src/pacman/callback.c @@ -271,12 +271,12 @@ void cb_trans_conv(pmtransconv_t event, void *data1, void *data2, void *data3, /* data parameters: package1, package2, conflict (string) */ /* print conflict only if it contains more information than package2 */ if(!strcmp(data2, data3)) { - *response = yesno(_(":: %s conflicts with %s. Remove %s?"), + *response = noyes(_(":: %s conflicts with %s. Remove %s?"), (char *)data1, (char *)data2, (char *)data2); } else { - *response = yesno(_(":: %s conflicts with %s (%s). Remove %s?"), + *response = noyes(_(":: %s conflicts with %s (%s). Remove %s?"), (char *)data1, (char *)data2, (char *)data3, -- 1.6.0.3

1 0

[pacman-dev] [PATCH 2/2] s/removing (all|old)/Removing \1/
by Brendan Hide 31 Aug '09

31 Aug '09

More consistent capitalisation. Note that capitalisation for languages other than English have NOT been modified in any way as they would need to be done manually. Signed-off-by: Brendan Hide <brendan(a)swiftspirit.co.za> --- lib/libalpm/add.c | 2 +- po/cs.po | 4 ++-- po/de.po | 4 ++-- po/en_GB.po | 8 ++++---- po/es.po | 4 ++-- po/fr.po | 4 ++-- po/hu.po | 4 ++-- po/it.po | 4 ++-- po/pacman.pot | 4 ++-- po/pl.po | 4 ++-- po/pt_BR.po | 4 ++-- po/ru.po | 4 ++-- po/tr.po | 4 ++-- po/uk.po | 4 ++-- po/zh_CN.po | 4 ++-- src/pacman/sync.c | 4 ++-- 16 files changed, 33 insertions(+), 33 deletions(-) diff --git a/lib/libalpm/add.c b/lib/libalpm/add.c index 6eb2085..0931cd5 100644 --- a/lib/libalpm/add.c +++ b/lib/libalpm/add.c @@ -192,7 +192,7 @@ static int upgrade_remove(pmpkg_t *oldpkg, pmpkg_t *newpkg, pmtrans_t *trans, pm ALPM_LOG_FUNC; - _alpm_log(PM_LOG_DEBUG, "removing old package first (%s-%s)\n", + _alpm_log(PM_LOG_DEBUG, "Removing old package first (%s-%s)\n", oldpkg->name, oldpkg->version); if(!tr) { diff --git a/po/cs.po b/po/cs.po index cfbaf4c..a95bc11 100644 --- a/po/cs.po +++ b/po/cs.po @@ -719,7 +719,7 @@ msgid "Do you want to remove outdated packages from cache?" msgstr "Chcete odstranit staré balíčky z cache?" #, c-format -msgid "removing old packages from cache... " +msgid "Removing old packages from cache... " msgstr "odstraňují se staré balíčky z cache... " #, c-format @@ -735,7 +735,7 @@ msgid "Do you want to remove ALL packages from cache?" msgstr "Chcete odstranit VŠECHNY balíčky z cache?" #, c-format -msgid "removing all packages from cache... " +msgid "Removing all packages from cache... " msgstr "odstraňují se všechny balíčky z cache... " #, c-format diff --git a/po/de.po b/po/de.po index 5fdabdc..e78c3ae 100644 --- a/po/de.po +++ b/po/de.po @@ -748,7 +748,7 @@ msgid "Do you want to remove outdated packages from cache?" msgstr "Möchten Sie veraltete Pakete aus dem Puffer entfernen?" #, c-format -msgid "removing old packages from cache... " +msgid "Removing old packages from cache... " msgstr "Entferne alte Pakete aus dem Puffer... " #, c-format @@ -764,7 +764,7 @@ msgid "Do you want to remove ALL packages from cache?" msgstr "Möchten Sie ALLE Pakete aus dem Puffer entfernen? " #, c-format -msgid "removing all packages from cache... " +msgid "Removing all packages from cache... " msgstr "Entferne alle Pakete aus dem Puffer... " #, c-format diff --git a/po/en_GB.po b/po/en_GB.po index 74a74d9..af58c8d 100644 --- a/po/en_GB.po +++ b/po/en_GB.po @@ -714,8 +714,8 @@ msgid "Do you want to remove outdated packages from cache?" msgstr "Do you want to remove outdated packages from cache?" #, c-format -msgid "removing old packages from cache... " -msgstr "removing old packages from cache... " +msgid "Removing old packages from cache... " +msgstr "Removing old packages from cache... " #, c-format msgid "could not access cache directory\n" @@ -730,8 +730,8 @@ msgid "Do you want to remove ALL packages from cache?" msgstr "Do you want to remove ALL packages from cache?" #, c-format -msgid "removing all packages from cache... " -msgstr "removing all packages from cache... " +msgid "Removing all packages from cache... " +msgstr "Removing all packages from cache... " #, c-format msgid "could not remove cache directory\n" diff --git a/po/es.po b/po/es.po index aa3e7eb..d385b0f 100644 --- a/po/es.po +++ b/po/es.po @@ -767,7 +767,7 @@ msgid "Do you want to remove outdated packages from cache?" msgstr "Desea borrar todos los paquetes desactualizados de la cache? " #, c-format -msgid "removing old packages from cache... " +msgid "Removing old packages from cache... " msgstr "quitando paquetes antiguos de la cache..." #, c-format @@ -783,7 +783,7 @@ msgid "Do you want to remove ALL packages from cache?" msgstr "Desea quitar TODOS los paquetes de la cache?" #, c-format -msgid "removing all packages from cache... " +msgid "Removing all packages from cache... " msgstr "quitando todos los paquetes de la cache... " #, c-format diff --git a/po/fr.po b/po/fr.po index eb69b94..2d2d17d 100644 --- a/po/fr.po +++ b/po/fr.po @@ -773,7 +773,7 @@ msgid "Do you want to remove outdated packages from cache?" msgstr "Voulez-vous supprimer tous les paquets non installés du cache?" #, c-format -msgid "removing old packages from cache... " +msgid "Removing old packages from cache... " msgstr "Suppression du cache des paquets obsolètes... " #, c-format @@ -790,7 +790,7 @@ msgid "Do you want to remove ALL packages from cache?" msgstr "Voulez vous supprimer TOUS les paquets du cache?" #, c-format -msgid "removing all packages from cache... " +msgid "Removing all packages from cache... " msgstr "Suppression du cache de tous les paquets... " #, c-format diff --git a/po/hu.po b/po/hu.po index 743f333..a9b18c3 100644 --- a/po/hu.po +++ b/po/hu.po @@ -723,7 +723,7 @@ msgid "Do you want to remove outdated packages from cache?" msgstr "Törölni kívánja az elavult csomagokat a gyorsítótárból?" #, c-format -msgid "removing old packages from cache... " +msgid "Removing old packages from cache... " msgstr "a régi csomagok törlése a gyorsítótárból... " #, c-format @@ -739,7 +739,7 @@ msgid "Do you want to remove ALL packages from cache?" msgstr "Törölni kívánja az ÖSSZES csomagot a gyorsítótárból?" #, c-format -msgid "removing all packages from cache... " +msgid "Removing all packages from cache... " msgstr "az összes csomag törlése a gyorsítótárból... " #, c-format diff --git a/po/it.po b/po/it.po index fd74bfb..5f0950d 100644 --- a/po/it.po +++ b/po/it.po @@ -734,7 +734,7 @@ msgid "Do you want to remove outdated packages from cache?" msgstr "Vuoi rimuovere dalla cache i pacchetti non aggiornati?" #, c-format -msgid "removing old packages from cache... " +msgid "Removing old packages from cache... " msgstr "rimozione dei vecchi pacchetti dalla cache in corso... " #, c-format @@ -750,7 +750,7 @@ msgid "Do you want to remove ALL packages from cache?" msgstr "Vuoi rimuovere dalla cache TUTTI i pacchetti?" #, c-format -msgid "removing all packages from cache... " +msgid "Removing all packages from cache... " msgstr "rimozione di tutti i pacchetti dalla cache in corso... " #, c-format diff --git a/po/pacman.pot b/po/pacman.pot index f4cc3e1..b6dbb3d 100644 --- a/po/pacman.pot +++ b/po/pacman.pot @@ -685,7 +685,7 @@ msgid "Do you want to remove outdated packages from cache?" msgstr "" #, c-format -msgid "removing old packages from cache... " +msgid "Removing old packages from cache... " msgstr "" #, c-format @@ -701,7 +701,7 @@ msgid "Do you want to remove ALL packages from cache?" msgstr "" #, c-format -msgid "removing all packages from cache... " +msgid "Removing all packages from cache... " msgstr "" #, c-format diff --git a/po/pl.po b/po/pl.po index cf027ac..fbedd33 100644 --- a/po/pl.po +++ b/po/pl.po @@ -739,7 +739,7 @@ msgid "Do you want to remove outdated packages from cache?" msgstr "Czy chcesz usunąć odinstalowane pakiety z pamięci podręcznej?" #, c-format -msgid "removing old packages from cache... " +msgid "Removing old packages from cache... " msgstr "usuwanie starych pakietów z pamięci podręcznej... " #, c-format @@ -755,7 +755,7 @@ msgid "Do you want to remove ALL packages from cache?" msgstr "Czy chcesz usunąć WSZYSTKIE pakiety z pamięci podręcznej?" #, c-format -msgid "removing all packages from cache... " +msgid "Removing all packages from cache... " msgstr "usuwanie wszystkich pakietów z pamięci podręcznej... " #, c-format diff --git a/po/pt_BR.po b/po/pt_BR.po index c540aaf..55e93d1 100644 --- a/po/pt_BR.po +++ b/po/pt_BR.po @@ -756,7 +756,7 @@ msgid "Do you want to remove outdated packages from cache?" msgstr "Deseja remover os pacotes desatualizados do cache?" #, c-format -msgid "removing old packages from cache... " +msgid "Removing old packages from cache... " msgstr "removendo pacotes antigos do cache... " #, c-format @@ -772,7 +772,7 @@ msgid "Do you want to remove ALL packages from cache?" msgstr "Deseja remover TODOS os pacotes do cache?" #, c-format -msgid "removing all packages from cache... " +msgid "Removing all packages from cache... " msgstr "removendo todos os pacotes do cache... " #, c-format diff --git a/po/ru.po b/po/ru.po index 067f739..8efaa59 100644 --- a/po/ru.po +++ b/po/ru.po @@ -728,7 +728,7 @@ msgid "Do you want to remove outdated packages from cache?" msgstr "Хотите удалить устаревшие пакеты из кэша?" #, c-format -msgid "removing old packages from cache... " +msgid "Removing old packages from cache... " msgstr "удаляю старые пакеты из кэша... " #, c-format @@ -744,7 +744,7 @@ msgid "Do you want to remove ALL packages from cache?" msgstr "Хотите удалить ВСЕ пакеты из кэша?" #, c-format -msgid "removing all packages from cache... " +msgid "Removing all packages from cache... " msgstr "удаляю все пакеты из кэша... " #, c-format diff --git a/po/tr.po b/po/tr.po index 07d877a..9d9dce9 100644 --- a/po/tr.po +++ b/po/tr.po @@ -722,7 +722,7 @@ msgid "Do you want to remove outdated packages from cache?" msgstr "Kaldırılan paketleri önbellekten silmek istiyor musunuz?" #, c-format -msgid "removing old packages from cache... " +msgid "Removing old packages from cache... " msgstr "önbellekteki eski paketler siliniyor... " #, c-format @@ -738,7 +738,7 @@ msgid "Do you want to remove ALL packages from cache?" msgstr "Önbellekteki TÜM paketleri silmek istiyor musunuz?" #, c-format -msgid "removing all packages from cache... " +msgid "Removing all packages from cache... " msgstr "önbellekteki tüm paketler siliniyor... " #, c-format diff --git a/po/uk.po b/po/uk.po index ffd22a0..d472f53 100644 --- a/po/uk.po +++ b/po/uk.po @@ -732,7 +732,7 @@ msgid "Do you want to remove outdated packages from cache?" msgstr "Ви хочете видалити старі пакунки з кешу?" #, c-format -msgid "removing old packages from cache... " +msgid "Removing old packages from cache... " msgstr "видалення старих пакунків з кешу... " #, c-format @@ -748,7 +748,7 @@ msgid "Do you want to remove ALL packages from cache?" msgstr "Ви хочете видалити ВСІ пакунки з кешу?" #, c-format -msgid "removing all packages from cache... " +msgid "Removing all packages from cache... " msgstr "видалення всіх пакунків з кешу... " #, c-format diff --git a/po/zh_CN.po b/po/zh_CN.po index 8727aad..f2cb240 100644 --- a/po/zh_CN.po +++ b/po/zh_CN.po @@ -673,7 +673,7 @@ msgid "Do you want to remove outdated packages from cache?" msgstr "打算从缓存中删除过期的软件包吗？" #, c-format -msgid "removing old packages from cache... " +msgid "Removing old packages from cache... " msgstr "正在从缓存中删除旧软件包..." #, c-format @@ -689,7 +689,7 @@ msgid "Do you want to remove ALL packages from cache?" msgstr "打算从缓存中删除所有软件包吗？" #, c-format -msgid "removing all packages from cache... " +msgid "Removing all packages from cache... " msgstr "正在从缓存中删除所有软件包..." #, c-format diff --git a/src/pacman/sync.c b/src/pacman/sync.c index d8a6348..261f2d1 100644 --- a/src/pacman/sync.c +++ b/src/pacman/sync.c @@ -148,7 +148,7 @@ static int sync_cleancache(int level) /* this should not happen : the config parsing doesn't set any other value */ return(1); } - printf(_("removing old packages from cache... ")); + printf(_("Removing old packages from cache... ")); dir = opendir(cachedir); if(dir == NULL) { @@ -218,7 +218,7 @@ static int sync_cleancache(int level) if(!noyes(_("Do you want to remove ALL packages from cache?"))) { return(0); } - printf(_("removing all packages from cache... ")); + printf(_("Removing all packages from cache... ")); if(rmrf(cachedir)) { pm_fprintf(stderr, PM_LOG_ERROR, _("could not remove cache directory\n")); -- 1.6.3.1

3 4

[pacman-dev] [PATCH] Do not remove conflict by default
by Allan McRae 31 Aug '09

31 Aug '09

When a conflict is detected, pacman asks if the user wants to remove the conflicting package. In many cases this is a bad idea. e.g. udev conflicts with initscripts. Remove initscripts [Y/n] util-linux-ng conflicts with e2fsprogs. Remove e2fsprogs? [Y/n] This changes the query to [y/N]. Signed-off-by: Allan McRae <allan(a)archlinux.org> --- src/pacman/callback.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/pacman/callback.c b/src/pacman/callback.c index e83a97d..0f52343 100644 --- a/src/pacman/callback.c +++ b/src/pacman/callback.c @@ -259,7 +259,7 @@ void cb_trans_conv(pmtransconv_t event, void *data1, void *data2, alpm_pkg_get_name(data2)); break; case PM_TRANS_CONV_CONFLICT_PKG: - *response = yesno(_(":: %s conflicts with %s. Remove %s?"), + *response = noyes(_(":: %s conflicts with %s. Remove %s?"), (char *)data1, (char *)data2, (char *)data2); -- 1.6.4.1

3 3

[pacman-dev] [PATCH] '-Spp and -Supp' options were added to be able to generate uri list without the downloaded package uris and for all too
by Laszlo Papp 31 Aug '09

31 Aug '09

I tried to modify as Gabor advised, if any problem exists now too, please write a feedback. Signed-off-by: Laszlo Papp <djszapi2(a)gmail.com> --- doc/pacman.8.txt | 6 ++++-- src/pacman/pacman.c | 4 ++-- src/pacman/sync.c | 3 +++ 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/doc/pacman.8.txt b/doc/pacman.8.txt index b288a59..961b9d5 100644 --- a/doc/pacman.8.txt +++ b/doc/pacman.8.txt @@ -305,8 +305,10 @@ linkman:pacman.conf[5]. *-p, \--print-uris*:: Print out URIs for each package that will be installed, including any - dependencies yet to be installed. These can be piped to a file and - downloaded at a later time, using a program like wget. + dependencies yet to be installed, excluding which are in the cachedir. + These can be piped to a file and downloaded at a later time, using a + program like wget. Passing two '\--print-uris' or '-p' flags will + force a print-uris of all package lists even if they are in the cachedir. *-q, \--quiet*:: Show less information for certain sync operations. (This is useful when diff --git a/src/pacman/pacman.c b/src/pacman/pacman.c index 25647b5..1a49303 100644 --- a/src/pacman/pacman.c +++ b/src/pacman/pacman.c @@ -128,7 +128,7 @@ static void usage(int op, const char * const myname) printf(_(" -g, --groups view all members of a package group\n")); printf(_(" -i, --info view package information\n")); printf(_(" -l, --list <repo> view a list of packages in a repo\n")); - printf(_(" -p, --print-uris print out URIs for given packages and their dependencies\n")); + printf(_(" -p, --print-uris print URIs for packages and their dependencies(-pp for all)\n")); printf(_(" -s, --search <regex> search remote repositories for matching strings\n")); printf(_(" -u, --sysupgrade upgrade all outdated packages (-uu enables downgrade)\n")); printf(_(" -w, --downloadonly download packages but do not install/upgrade anything\n")); @@ -485,7 +485,7 @@ static int parseargs(int argc, char *argv[]) case 'o': config->op_q_owns = 1; break; case 'p': config->op_q_isfile = 1; - config->op_s_printuris = 1; + config->op_s_printuris++; config->flags |= PM_TRANS_FLAG_NOCONFLICTS; config->flags |= PM_TRANS_FLAG_NOLOCK; break; diff --git a/src/pacman/sync.c b/src/pacman/sync.c index dc93621..90f5bb8 100644 --- a/src/pacman/sync.c +++ b/src/pacman/sync.c @@ -678,6 +678,9 @@ static int sync_trans(alpm_list_t *targets) pmpkg_t *pkg = alpm_list_getdata(i); pmdb_t *db = alpm_pkg_get_db(pkg); const char *dburl = alpm_db_get_url(db); + if ((config->op_s_printuris == 1) && !alpm_pkg_download_size(pkg)) { + continue; + } if(dburl) { printf("%s/%s\n", dburl, alpm_pkg_get_filename(pkg)); } else { -- 1.6.4.1

2 1

[pacman-dev] [PATCH] makepkg : refactor run_build and run_package
by Xavier Chantry 29 Aug '09

29 Aug '09

These two functions were very similar. Signed-off-by: Xavier Chantry <shiningxc(a)gmail.com> --- scripts/makepkg.sh.in | 117 ++++++++++++++++-------------------------------- 1 files changed, 39 insertions(+), 78 deletions(-) diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index ba45609..422c950 100644 --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in @@ -674,94 +674,23 @@ extract_sources() { fi } -error_build() { - # first exit all subshells, then print the error - if [ $BASH_SUBSHELL -eq 0 ]; then - error "$(gettext "Build Failed.")" - plain "$(gettext "Aborting...")" - remove_deps - fi - exit 2 # $E_BUILD_FAILED -} - -run_build() { - # use distcc if it is requested (check buildenv and PKGBUILD opts) - if [ "$(check_buildenv distcc)" = "y" -a "$(check_option distcc)" != "n" ]; then - [ -d /usr/lib/distcc/bin ] && export PATH="/usr/lib/distcc/bin:$PATH" - export DISTCC_HOSTS - elif [ "$(check_option distcc)" = "n" ]; then - # if it is not wanted, clear the makeflags too - MAKEFLAGS="" - fi - - # use ccache if it is requested (check buildenv and PKGBUILD opts) - if [ "$(check_buildenv ccache)" = "y" -a "$(check_option ccache)" != "n" ]; then - [ -d /usr/lib/ccache/bin ] && export PATH="/usr/lib/ccache/bin:$PATH" - fi - - # clear user-specified makeflags if requested - if [ "$(check_option makeflags)" = "n" ]; then - MAKEFLAGS="" - fi - - msg "$(gettext "Starting build()...")" - cd "$srcdir" - - # ensure all necessary build variables are exported - export CFLAGS CXXFLAGS MAKEFLAGS LDFLAGS CHOST - # save our shell options so build() can't override what we need - local shellopts=$(shopt -p) - - local ret=0 - if [ "$LOGGING" -eq 1 ]; then - BUILDLOG="${startdir}/${pkgbase}-${pkgver}-${pkgrel}-${CARCH}-build.log" - if [ -f "$BUILDLOG" ]; then - local i=1 - while true; do - if [ -f "$BUILDLOG.$i" ]; then - i=$(($i +1)) - else - break - fi - done - mv "$BUILDLOG" "$BUILDLOG.$i" - fi - - set +E - build 2>&1 | tee "$BUILDLOG"; ret=${PIPESTATUS[0]} - set -E - if [ $ret -gt 0 ]; then error_build; fi - else - restoretrap=$(trap -p ERR) - trap 'error_build' ERR - build 2>&1 - eval $restoretrap - fi - # reset our shell options - eval "$shellopts" -} - -error_package() { +error_function() { if [ -p "$logpipe" ]; then rm "$logpipe" fi # first exit all subshells, then print the error if [ $BASH_SUBSHELL -eq 0 ]; then - error "$(gettext "Packaging Failed.")" plain "$(gettext "Aborting...")" remove_deps fi exit 2 # $E_BUILD_FAILED } -run_package() { +run_function() { if [ -z "$1" ]; then - pkgfunc="package" - nameofpkg="$pkgname" - else - pkgfunc="package_$1" - nameofpkg="$1" + return 1 fi + pkgfunc="$1" # clear user-specified makeflags if requested if [ "$(check_option makeflags)" = "n" ]; then @@ -773,10 +702,12 @@ run_package() { # ensure all necessary build variables are exported export CFLAGS CXXFLAGS LDFLAGS MAKEFLAGS CHOST + # save our shell options so pkgfunc() can't override what we need + local shellopts=$(shopt -p) local ret=0 if [ "$LOGGING" -eq 1 ]; then - BUILDLOG="${startdir}/${nameofpkg}-${pkgver}-${pkgrel}-${CARCH}-package.log" + BUILDLOG="${startdir}/${pkgname}-${pkgver}-${pkgrel}-${CARCH}-$pkgfunc.log" if [ -f "$BUILDLOG" ]; then local i=1 while true; do @@ -796,7 +727,7 @@ run_package() { tee "$BUILDLOG" < "$logpipe" & exec 1>"$logpipe" 2>"$logpipe" restoretrap=$(trap -p ERR) - trap 'error_package' ERR + trap 'error_function' ERR $pkgfunc 2>&1 eval $restoretrap sync @@ -804,10 +735,40 @@ run_package() { rm "$logpipe" else restoretrap=$(trap -p ERR) - trap 'error_package' ERR + trap 'error_function' ERR $pkgfunc 2>&1 eval $restoretrap fi + # reset our shell options + eval "$shellopts" +} + +run_build() { + # use distcc if it is requested (check buildenv and PKGBUILD opts) + if [ "$(check_buildenv distcc)" = "y" -a "$(check_option distcc)" != "n" ]; then + [ -d /usr/lib/distcc/bin ] && export PATH="/usr/lib/distcc/bin:$PATH" + export DISTCC_HOSTS + elif [ "$(check_option distcc)" = "n" ]; then + # if it is not wanted, clear the makeflags too + MAKEFLAGS="" + fi + + # use ccache if it is requested (check buildenv and PKGBUILD opts) + if [ "$(check_buildenv ccache)" = "y" -a "$(check_option ccache)" != "n" ]; then + [ -d /usr/lib/ccache/bin ] && export PATH="/usr/lib/ccache/bin:$PATH" + fi + + run_function "build" +} + +run_package() { + if [ -z "$1" ]; then + pkgfunc="package" + else + pkgfunc="package_$1" + fi + + run_function "$pkgfunc" } tidy_install() { -- 1.6.4.1

2 1