- Pacman-dev - lists.archlinux.org

[pacman-dev] [PATCH] src/pacman : rework the display_targets function.
by Xavier Chantry 25 Jul '08

25 Jul '08

We had a lot of duplicated code here. The code handling the showsize option needed to be there three times : 1) for install part of -S 2) for remove part of -S (conflict removal) 3) for -R This patch introduce a new display_targets(pkglist, install) function which can handle the 3 cases above. We pass install == 1 for case 1), and install == 0 for case 2) and 3). Now we can finally get the benefit of an old patch which handled the ShowSize option consistently in the 3 cases above, without an awful lot of duplicated code : http://www.archlinux.org/pipermail/pacman-dev/2008-January/011029.html Signed-off-by: Xavier Chantry <shiningxc(a)gmail.com> --- src/pacman/query.c | 2 +- src/pacman/remove.c | 15 +++----- src/pacman/sync.c | 2 +- src/pacman/util.c | 100 ++++++++++++++++++++++++++++----------------------- src/pacman/util.h | 3 +- 5 files changed, 64 insertions(+), 58 deletions(-) diff --git a/src/pacman/query.c b/src/pacman/query.c index bd2d8c5..d899539 100644 --- a/src/pacman/query.c +++ b/src/pacman/query.c @@ -261,7 +261,7 @@ static int query_upgrades(void) return(-1); } if(syncpkgs) { - display_targets(syncpkgs, db_local); + display_synctargets(syncpkgs); return(0); } diff --git a/src/pacman/remove.c b/src/pacman/remove.c index 83947ca..f091fa4 100644 --- a/src/pacman/remove.c +++ b/src/pacman/remove.c @@ -125,21 +125,16 @@ int pacman_remove(alpm_list_t *targets) if(config->flags & PM_TRANS_FLAG_RECURSE || config->flags & PM_TRANS_FLAG_CASCADE) { /* list transaction targets */ - alpm_list_t *lst = NULL; - /* create a new list of package names only */ - for(i = alpm_trans_get_pkgs(); i; i = alpm_list_next(i)) { - pmpkg_t *pkg = alpm_list_getdata(i); - lst = alpm_list_add(lst, strdup(alpm_pkg_get_name(pkg))); - } + alpm_list_t *pkglist = alpm_trans_get_pkgs(); + + display_targets(pkglist, 0); printf("\n"); - list_display(_("Targets:"), lst); - FREELIST(lst); + /* get confirmation */ - if(yesno(1, _("\nDo you want to remove these packages?")) == 0) { + if(yesno(1, _("Do you want to remove these packages?")) == 0) { retval = 1; goto cleanup; } - printf("\n"); } /* Step 3: actually perform the removal */ diff --git a/src/pacman/sync.c b/src/pacman/sync.c index 87bd5be..8d0c529 100644 --- a/src/pacman/sync.c +++ b/src/pacman/sync.c @@ -669,7 +669,7 @@ static int sync_trans(alpm_list_t *targets) if(!(alpm_trans_get_flags() & PM_TRANS_FLAG_PRINTURIS)) { int confirm; - display_targets(packages, db_local); + display_synctargets(packages); printf("\n"); if(config->op_s_downloadonly) { diff --git a/src/pacman/util.c b/src/pacman/util.c index d7ac9e3..efe8e6a 100644 --- a/src/pacman/util.c +++ b/src/pacman/util.c @@ -480,49 +480,33 @@ void list_display(const char *title, const alpm_list_t *list) } } -/* Display a list of transaction targets. - * `pkgs` should be a list of pmsyncpkg_t's, - * retrieved from a transaction object - */ -/* TODO move to output.c? or just combine util and output */ -void display_targets(const alpm_list_t *syncpkgs, pmdb_t *db_local) +/* prepare a list of pkgs to display */ +void display_targets(const alpm_list_t *pkgs, int install) { char *str; - const alpm_list_t *i, *j; - alpm_list_t *targets = NULL, *to_remove = NULL; - /* TODO these are some messy variable names */ - off_t isize = 0, rsize = 0, dispsize = 0, dlsize = 0; - double mbisize = 0.0, mbrsize = 0.0, mbdispsize = 0.0, mbdlsize = 0.0; - - for(i = syncpkgs; i; i = alpm_list_next(i)) { - pmsyncpkg_t *sync = alpm_list_getdata(i); - pmpkg_t *pkg = alpm_sync_get_pkg(sync); - - /* The removes member contains a list of packages to be removed - * due to the package that is being installed. */ - alpm_list_t *to_replace = alpm_sync_get_removes(sync); + const alpm_list_t *i; + off_t isize = 0, dlsize = 0; + double mbisize = 0.0, mbdlsize = 0.0; + alpm_list_t *targets = NULL; - for(j = to_replace; j; j = alpm_list_next(j)) { - pmpkg_t *rp = alpm_list_getdata(j); - const char *name = alpm_pkg_get_name(rp); + if(!pkgs) { + return; + } - if(!alpm_list_find_str(to_remove, name)) { - rsize += alpm_pkg_get_isize(rp); - to_remove = alpm_list_add(to_remove, strdup(name)); - } - } + printf("\n"); + for(i = pkgs; i; i = alpm_list_next(i)) { + pmpkg_t *pkg = alpm_list_getdata(i); - dispsize = alpm_pkg_get_size(pkg); dlsize += alpm_pkg_download_size(pkg); isize += alpm_pkg_get_isize(pkg); /* print the package size with the output if ShowSize option set */ if(config->showsize) { - /* Convert byte size to MB */ - mbdispsize = dispsize / (1024.0 * 1024.0); + double mbsize = 0.0; + mbsize = alpm_pkg_get_size(pkg) / (1024.0 * 1024.0); asprintf(&str, "%s-%s [%.2f MB]", alpm_pkg_get_name(pkg), - alpm_pkg_get_version(pkg), mbdispsize); + alpm_pkg_get_version(pkg), mbsize); } else { asprintf(&str, "%s-%s", alpm_pkg_get_name(pkg), alpm_pkg_get_version(pkg)); @@ -531,29 +515,55 @@ void display_targets(const alpm_list_t *syncpkgs, pmdb_t *db_local) } /* Convert byte sizes to MB */ - mbisize = isize / (1024.0 * 1024.0); - mbrsize = rsize / (1024.0 * 1024.0); mbdlsize = dlsize / (1024.0 * 1024.0); + mbisize = isize / (1024.0 * 1024.0); - /* start displaying information */ - printf("\n"); - - if(to_remove) { - list_display(_("Remove:"), to_remove); + if(install) { + list_display(_("Targets:"), targets); printf("\n"); - FREELIST(to_remove); - printf(_("Total Removed Size: %.2f MB\n"), mbrsize); + printf(_("Total Download Size: %.2f MB\n"), mbdlsize); + printf(_("Total Installed Size: %.2f MB\n"), mbisize); + } else { + list_display(_("Remove:"), targets); printf("\n"); + + printf(_("Total Removed Size: %.2f MB\n"), mbisize); } - list_display(_("Targets:"), targets); - printf("\n"); + FREELIST(targets); +} - printf(_("Total Download Size: %.2f MB\n"), mbdlsize); - printf(_("Total Installed Size: %.2f MB\n"), mbisize); +/* Display a list of transaction targets. + * `pkgs` should be a list of pmsyncpkg_t's, + * retrieved from a transaction object + */ +void display_synctargets(const alpm_list_t *syncpkgs) +{ + const alpm_list_t *i, *j; + alpm_list_t *pkglist = NULL, *rpkglist = NULL; - FREELIST(targets); + for(i = syncpkgs; i; i = alpm_list_next(i)) { + pmsyncpkg_t *sync = alpm_list_getdata(i); + pmpkg_t *pkg = alpm_sync_get_pkg(sync); + pkglist = alpm_list_add(pkglist, pkg); + + /* The removes member contains a list of packages to be removed + * due to the package that is being installed. */ + alpm_list_t *to_replace = alpm_sync_get_removes(sync); + + for(j = to_replace; j; j = alpm_list_next(j)) { + pmpkg_t *rp = alpm_list_getdata(j); + rpkglist = alpm_list_add(rpkglist, rp); + } + } + + /* start displaying information */ + display_targets(rpkglist, 0); + display_targets(pkglist, 1); + + alpm_list_free(pkglist); + alpm_list_free(rpkglist); } /* presents a prompt and gets a Y/N answer */ diff --git a/src/pacman/util.h b/src/pacman/util.h index 722e4ab..2ddc1b5 100644 --- a/src/pacman/util.h +++ b/src/pacman/util.h @@ -51,7 +51,8 @@ char *strreplace(const char *str, const char *needle, const char *replace); alpm_list_t *strsplit(const char *str, const char splitchar); void string_display(const char *title, const char *string); void list_display(const char *title, const alpm_list_t *list); -void display_targets(const alpm_list_t *syncpkgs, pmdb_t *db_local); +void display_targets(const alpm_list_t *pkgs, int install); +void display_synctargets(const alpm_list_t *syncpkgs); int yesno(short preset, char *fmt, ...); int pm_printf(pmloglevel_t level, const char *format, ...) __attribute__((format(printf,2,3))); int pm_fprintf(FILE *stream, pmloglevel_t level, const char *format, ...) __attribute__((format(printf,3,4))); -- 1.5.6.4

1 1

[pacman-dev] [PATCH] Implement AND based package searching.
by Xavier Chantry 25 Jul '08

25 Jul '08

This fixes FS#2334. Signed-off-by: Xavier Chantry <shiningxc(a)gmail.com> --- lib/libalpm/db.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/lib/libalpm/db.c b/lib/libalpm/db.c index 0be81cb..3dfd3bf 100644 --- a/lib/libalpm/db.c +++ b/lib/libalpm/db.c @@ -357,6 +357,7 @@ alpm_list_t *_alpm_db_search(pmdb_t *db, const alpm_list_t *needles) { const alpm_list_t *i, *j, *k; alpm_list_t *ret = NULL; + alpm_list_t *list = alpm_list_copy(_alpm_db_get_pkgcache(db)); ALPM_LOG_FUNC; @@ -367,6 +368,7 @@ alpm_list_t *_alpm_db_search(pmdb_t *db, const alpm_list_t *needles) if(i->data == NULL) { continue; } + ret = NULL; targ = i->data; _alpm_log(PM_LOG_DEBUG, "searching for target '%s'\n", targ); @@ -374,7 +376,7 @@ alpm_list_t *_alpm_db_search(pmdb_t *db, const alpm_list_t *needles) RET_ERR(PM_ERR_INVALID_REGEX, NULL); } - for(j = _alpm_db_get_pkgcache(db); j; j = j->next) { + for(j = list; j; j = j->next) { pmpkg_t *pkg = j->data; const char *matched = NULL; const char *name = alpm_pkg_get_name(pkg); @@ -407,6 +409,8 @@ alpm_list_t *_alpm_db_search(pmdb_t *db, const alpm_list_t *needles) } } + alpm_list_free(list); + list = ret; regfree(&reg); } -- 1.5.6.4

1 0

[pacman-dev] awful bug in pkg_dup
by Xavier 25 Jul '08

25 Jul '08

I wasted two hours of my precious sleep while playing with the display targets and ShowSize code. Suppose you have a package loaded with INFRQ_BASE (only name and version), then you duplicate it with pkg_dup function. All this stuff is done first : newpkg->size = pkg->size; newpkg->isize = pkg->isize; newpkg->scriptlet = pkg->scriptlet; newpkg->force = pkg->force; newpkg->reason = pkg->reason; Then when calling this accessor and all the following ones: newpkg->licenses = alpm_list_strdup(alpm_pkg_get_licenses(pkg)); ... the INFRQ_DESC level will be loaded with all the infos, including the size / isize / etc stuff above. And finally we have this : newpkg->infolevel = pkg->infolevel; The amazing result is that you end up with a pkg with many empty fields, but with the INFRQ_DESC level. So once this is done, it is simply impossible to access all this precious information from the frontend. We should never ever use all these alpm_pkg_get accessors here, it doesn't make sense to fill a package while it is being duplicated.

1 0

[pacman-dev] [PATCH] Update NEWS file for 3.2.0 release
by Allan McRae 24 Jul '08

24 Jul '08

Signed-off-by: Allan McRae <allan(a)archlinux.org> --- NEWS | 76 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 76 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index 5a9157a..6429695 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,81 @@ VERSION DESCRIPTION ----------------------------------------------------------------------------- +3.2.0 + - many patches to greatly reduce memory usage + - added --asexplicit option + - new remove option --unneeded + - removed -A/--add option from pacman frontend + - add -Rss option to remove all dependencies + - removed useless -e/--dependsonly option + - config options are now case sensitive + - added CleanMethod option for variety in cache cleaning + - handle multiple groups in -Ss and -Qs operations + - allow -q/--quiet option with -o/--own option + - removed hack for packages with unknown installed size + - add SyncFirst option to pacman.conf + - add --enable-git-version configure flag to identify + developmental build version + - do not duplicate packages in required by list + - pacman.static is no longer built + - improve yesno function which removes need to translate + y/n all the time + - all error messages use pm_fprintf + - disable geteuid in cygwin + - use off_t type for large file support + - add vercmp test script + - moved gensync and updatesync to contrib + - rewrote pacsearch script in perl + - paclist script to list installed packages from a repo + - bacman script to make backup of package from filesystem + - combined repo-add and repo-remove to one script + - removed force option from repo-add + - add quiet option to repo-add/repo-remove + - update libtool version to 1.5.26 + - allow disabling of internal download with new configure + flag --disable-internal-download + - pactest can now check file permissions + - libalpm-specific changes: + - use dynamic string allocation in package structure + - new functions for manipulating pmdepend_t objects + - store replaces and force in local database + - moved deptest functionality to backend + - add alpm_checkdbconflicts function + - cleanup of conflict resolution + - removed synlist_free function + - fix PM_ERR_CONFLICTING_DEPS handling + - cleanup of pmsyncpkg_t + - add alpm_sync_newversion function + - removed alpm_sync_get_newversion function + - pmgraph_t struct and functions get their own header file + - cleanup of alpm_list code + - refactor of download code + - removed test_delta_md5sum and test_pkg_md5sum functions + - add alpm_version function + - avoid adding duplicate target names + - add _alpm_archive_fgets function to read line-by-line from + an archive + - read .PKGINFO directly from package file + - remove error.h header file + - refactor of _alpm_remove_prepare into two new functions + - native support for both libdownload and libfetch + - rework delta alogorithm + - swap parameters of alpm_pkg_find for consistency with + other find functions + - fix removing multiple items in dependency chain + - makepkg-specific changes: + - support for resuming source downloads + - added zipman option + - removed -b/--builddeps + - various portability fixes for BSD/Mac OSX + - check for valid options in PKGBUILD + - add --allsource option + - remove depreciated --usesudo option + - handle spaces in build directory + - made keeping docs the default option + - use pacman version dep resolving + - fix regression in library striping + - make the strip paths configurable + - MANY other bug fixes and small improvements 3.1.4 - various small code cleanups and fixes - small documentation updates - improvements to PKGBUILD.vim -- 1.5.6.4

7 14

[pacman-dev] [PATCH] added pactree
by Carlo Bersani 24 Jul '08

24 Jul '08

Pactree is a dependency tree viewer for installed packages. It features both textual and graphic (through graphviz) output. --- contrib/pactree | 314 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 314 insertions(+), 0 deletions(-) create mode 100755 contrib/pactree diff --git a/contrib/pactree b/contrib/pactree new file mode 100755 index 0000000..c186595 --- /dev/null +++ b/contrib/pactree @@ -0,0 +1,314 @@ +#!/bin/bash + +# here you can set the colors +branch1_color="\033[0;33m" #Brown +branch2_color="\033[0;37m" #Gray +leaf_color="\033[1;32m" #Light green +leaf2_color="\033[0;32m" #Green + +# here you can set the separators +separator=" " +branch_tip1="|--" +branch_tip2="+--" +provides="provides " + +# here you can set the graphviz options. +# http://www.graphviz.org/doc/info/output.html for available output formats +# http://www.graphviz.org/doc/info/colors.html for available colors +gformat="png" #output format +start_color="red" #START color +nodes_color="green" #color of the nodes +arrow1_color="chocolate4" #color of the normal arrow +arrow2_color="grey" #color of the "provided by" headless arrow + +########----------------END-OF-CONFIGURABLE-PART----------------####### + +# pactree : a simple dependency tree viewer +# +# Copyright (c) 2008 Carlo "carlocci" Bersani <carlocci(a)gmail.com> +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see <http://www.gnu.org/licenses/>. +# + +# Original http://carlocci.ngi.it/arch/pactree +# Credit to scj for the graphviz idea + +####################################################################### +# User friendly part # +####################################################################### +readonly prog_name="pactree" +readonly prog_ver="0.2" + +_usage(){ + echo "This program generates the dependency tree of an installed package" + echo "Usage: $prog_name [OPTIONS] <installed packages>" + echo + echo " OPTIONS:" + echo " -c, --color Enable color output" + echo " -d, --depth INT Limit the shown dependencies depth" + echo " -g, --graph Use graphviz to make an image of the tree" + echo " -l, --linear Enable linear output" + echo " -s, --silent Shh, let me hear those errors!" + echo " -u, --unique Print the dependency list with no duplicates" + echo + echo " -h, --help Print this help message" + echo " -v, --version Print the program name and version" + echo + echo "Example: $prog_name -c -d 2 readline" +} + +_version(){ + echo "$prog_name version $prog_ver" + echo "Copyright (C) 2008 locci" +} +# end of the friendliness + + +####################################################################### +# grab a field from the database: $1=path/to/file, $2=field to grab # +####################################################################### +_grabfield(){ + for line in $(cat "$1" 2>/dev/null ); do + if [ -z "$line" ]; then + continue; + fi; + if [[ "$line" =~ %[A-Z]*% ]]; then + current="$line" + continue; + fi; + if [ "$current" = "$2" ]; then + echo "$line" + fi; + done +} + + +####################################################################### +# find a dep in the db: $1=dep, $2=field, $3=dbfile, ret=file list # +####################################################################### +_finddep(){ + for line in $(awk 'BEGIN{RS=""} {if ($1=="'"$2"'") {for (i=2 ; i<=NF ; ++i){ if ($i ~ /^'"$1"'([<>=]+.*|)$/ ) {print FILENAME}}}}' $(find $pac_db -name $3)); do + echo "${line%/*}" + done +} + + +####################################################################### +# Recursive function: does all of the work, pays all of the taxes # +####################################################################### +_tree(){ + pkg_name="$1" + pkg_dirs="$(echo $pac_db/$pkg_name-[0-9]*)" + + # Is $pkg_name real or provided? + [ ! -d "$pkg_dirs" ] && pkg_dirs="$(_finddep $pkg_name %PROVIDES% depends)" + + for pkg_dir in $pkg_dirs ; do + spaces="$2" + unset provided + branch_tip="$branch_tip1" + branch_color="$branch1_color" + pkg_name="$(_grabfield "$pkg_dir/desc" %NAME%)" + if [ ! "$pkg_name" = "$1" ]; then + provided="$leaf2_color $provides$leaf_color$1" + branch_tip="$branch_tip2" + branch_color="$branch2_color" + if [ $graphviz -eq 1 ] && [[ ! "${dep_list[@]}" =~ _$1_ ]] && [ $spaces -ne $((max_depth+1)) ]; then + echo "\"$1\" -> \"$pkg_name\" [arrowhead=none, color=$arrow2_color];" + dep_list=( "${dep_list[@]}" "_$1_" ) + _tree "$pkg_name" $((spaces+1)) + continue + fi + fi + + # Generate the spacer + spacer="" + for each in $(seq 1 $spaces); do + spacer="$spacer$separator" + done + spacer="$spacer$branch_tip" + + [ $silent -ne 1 ] && echo -e "$branch_color$spacer$leaf_color$pkg_name$provided" + + [ ! -d "$pkg_dir" ] && echo "No $pkg_name in the database (inconsistent database?)" >&2 + + if [[ ! " ${dep_list[@]} " =~ " $pkg_name " ]] && [ $spaces -ne $max_depth ]; then + dep_list=( "${dep_list[@]}" "$pkg_name" ) + for dep_pkg in $(_grabfield "$pkg_dir/depends" %DEPENDS%); do + spaces=$2 #Bash scoping ;_; + if [ $graphviz -eq 1 ]; then + echo "\"$1\" -> \"${dep_pkg%%[<>=]*}\" [color=$arrow1_color];" + fi + _tree "${dep_pkg%%[<>=]*}" $((spaces+1)) + done + fi + done + +} + + +####################################################################### +# Main program: gets all of the money, pays none of the taxes # +####################################################################### + +# Command line parameters parser -------------------------------------- +# --------------------------------------------------------------------- +if [ $# -eq 0 ]; then + _usage + exit 1 +fi + +options=( "$@" ) +len_options=${#options[@]} +for (( n=0 ; n < $len_options ; n++ )); do + if [ "${options[$n]}" = "--" ]; then + unset options[$n] + break + fi + if [ "${options[$n]}" = "-h" -o "${options[$n]}" = "--help" ]; then + _usage + exit 0 + fi + + if [ "${options[$n]}" = "-v" -o "${options[$n]}" = "--version" ]; then + _version + exit 0 + fi + + if [ "${options[$n]}" = "-l" -o "${options[$n]}" = "--linear" ]; then + unset options[$n] + linear=1 + continue + fi + + if [ "${options[$n]}" = "-s" -o "${options[$n]}" = "--silent" ]; then + unset options[$n] + silent=1 + continue + fi + + if [ "${options[$n]}" = "-u" -o "${options[$n]}" = "--unique" ]; then + unset options[$n] + silent=1 + nodup=1 + continue + fi + + if [ "${options[$n]}" = "-g" -o "${options[$n]}" = "--graph" ]; then + unset options[$n] + graphviz=1 + continue + fi + + if [ "${options[$n]}" = "-c" -o "${options[$n]}" = "--color" ]; then + unset options[$n] + colored=1 + continue + fi + + if [[ "${options[$n]}" =~ -d[[:digit:]]* || "${options[$n]}" == "--depth" ]]; then + if [[ "${options[$n]#-d}" =~ [[:digit:]]+ ]]; then + max_depth="${options[$n]#-d}" + elif [[ ${options[$((n+1))]} =~ [[:digit:]]+ ]]; then +# if [ ${options[$((n+1))]} -eq ${options[$((n+1))]} 2>/dev/null ]; then + max_depth="${options[$((n+1))]}" + unset options[$((n+1))] + ((++n)) + fi + unset options[$n] + continue + fi +done +# End of the dumb command line parser --------------------------------- + + +# Env ----------------------------------------------------------------- +# --------------------------------------------------------------------- +colored=${colored:-0} +max_depth=${max_depth:--10} +linear=${linear:-0} +silent=${silent:-0} +nodup=${nodup:-0} +graphviz=${graphviz:-0} + +if [ $colored -ne 1 ]; then + unset branch1_color + unset leaf_color + unset leaf2_color + unset branch2_color +fi + +if [ $linear -eq 1 ]; then + unset separator + unset branch_tip1 + unset branch_tip2 + unset provides +fi + +if [ $graphviz -eq 1 ]; then + silent=1 + nodup=0 + if [ ! -f /usr/bin/dot ]; then + echo "ERROR: package graphviz is not installed" + echo " Run pacman -S graphviz to install it" + exit 1 + fi +fi + +if [ ! -r /etc/pacman.conf ]; then + echo "ERROR: unable to read /etc/pacman.conf" + exit 1 +else + eval $(awk '/DBPath/ {print $1$2$3}' /etc/pacman.conf) +fi + +pac_db="${DBPath:-/var/lib/pacman}/local" + +if [ ! -d "$pac_db" ] ; then + echo "ERROR: pacman database directory ${pac_db} not found" + exit 1 +fi +# Env End ------------------------------------------------------------- + +# Program starts ------------------------------------------------------ +# --------------------------------------------------------------------- + +_main(){ + for pkg_name in ${options[@]} ; do + [ $graphviz -eq 1 ] && echo -e "\"START\" -> \"$pkg_name\" ;" + _tree "$pkg_name" 0 + if [ $nodup -eq 1 ]; then + for pkg_tree in ${dep_list[@]} ; do + echo "$pkg_tree" + done + fi + done + if [ $silent -eq 0 ]; then + echo -ne '\033[0m' # return colors to normal? + echo -ne '\033[?25h' #return cursor to normal? + fi +} + + +if [ $graphviz -eq 1 ]; then + root_pkgs="${options[@]}" + # Uncomment for the "generated by pactree" node in graphviz + #advert="xyz [height=0.07, fontsize=8.0, label=\"GENERATED WITH PACTREE\",shape=box,color="black",style=filled,fontcolor="white"];\n" + + echo -e "digraph G { START [color=$start_color, style=filled];\n node [style=filled, color=$nodes_color];\n$(_main)\n$advert}" | dot -T$gformat -o "${root_pkgs// /_}.deps.$gformat" +else _main +fi +# Program Ends -------------------------------------------------------- + +# vim: set ts=2 sw=2 noet: -- 1.5.6.4

3 9

[pacman-dev] [PATCH] makepkg: add packages to pkgdeps list only after successful install
by Allan McRae 23 Jul '08

23 Jul '08

This fixed FS#9403. With this you can use "makepkg -sr", install the dependencies, Ctrl+c during the makedepends installation and have makepkg remove the installed packages on the exit. Previously makepkg tried to also remove the makedepends which were not installed. The deplist="" line in remove_deps is due to an obscure bug where local varaibles from the handle_deps function seem stay in scope because we never formally exited it. Signed-off-by: Allan McRae <allan(a)archlinux.org> --- scripts/makepkg.sh.in | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index ae19983..379e9d8 100644 --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in @@ -362,11 +362,10 @@ resolve_deps() { local deplist="$(check_deps $*)" if [ "$deplist" = "" ]; then return $R_DEPS_SATISFIED - else - pkgdeps="$pkgdeps $deplist" fi if handledeps $deplist; then + pkgdeps="$pkgdeps $deplist" # check deps again to make sure they were resolved deplist="$(check_deps $*)" [ "$deplist" = "" ] && return $R_DEPS_SATISFIED @@ -390,6 +389,7 @@ remove_deps() { [ "$pkgdeps" = "" ] && return local dep depstrip deplist + deplist="" for dep in $pkgdeps; do depstrip=$(echo $dep | sed -e 's|=.*$||' -e 's|>.*$||' -e 's|<.*$||') deplist="$deplist $depstrip" -- 1.5.6.4

1 1

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v3.1.4-266-g075b244
by Dan McGee 23 Jul '08

23 Jul '08

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, master has been updated via 075b244be23aa788ae21e8c5d50cb99a1296c37f (commit) via 69f00385a9932458ddad199e1b215aba989804af (commit) via 06a4a5bd6827fc300669c0237c26ae979eb7c1c0 (commit) via 22722261cc5bd2276e657300ea7dcbcec5381970 (commit) via 24783e6b6b6833678fec289ec89198db691b1b63 (commit) via c9550e9655af0216b26c6f48b9ee474b13ccdb5f (commit) via a7ee8f90f9a01af2443139c787ca984e03c7b006 (commit) via 12e804511a2f3af4c032903538e456e50f24a2fb (commit) via 6d4f235af9754a5f67b61999eac75026b5e408f3 (commit) via 441c2dd550c79f4ea34893fe36bd4f672c301cc4 (commit) via 27f56304d6fedec0d89f5fe926225684f3e0db31 (commit) via 501ce943e64e653ddcb148a98b1044f7e7ff22bf (commit) via b169925c1e4a4ab4fc036fe1a8626a7a89b3013a (commit) via c1a648137e04599af019c52a3d368e3369691070 (commit) via 4ebad47ae7dff0f006c885c303563cb8550fb658 (commit) via ad697d2fd5af10439266b3350b3de3c9400913f5 (commit) via 991dfca90e99826be10c4a60319b8297c665d752 (commit) via ae9e33ed88849bfdf4a9530f674701cc32d72563 (commit) from b4f2cb53ef568534e672a877f3d47f85ca18f2af (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 075b244be23aa788ae21e8c5d50cb99a1296c37f Author: Nagy Gabor <ngaba(a)bibl.u-szeged.hu> Date: Wed Jul 16 14:42:25 2008 +0200 -Sqg and -Qqg With --quiet, "pacman -Sg grp" and "pacman -Qg grp" don't list group names. Note that "pacman -Qgq" and "pacman -Sggq" (without targets) still list group names becuase their output would not be very useful without them. Signed-off-by: Nagy Gabor <ngaba(a)bibl.u-szeged.hu> Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 69f00385a9932458ddad199e1b215aba989804af Author: Nagy Gabor <ngaba(a)bibl.u-szeged.hu> Date: Tue Jul 22 13:15:02 2008 +0200 Update pactest README Signed-off-by: Nagy Gabor <ngaba(a)bibl.u-szeged.hu> Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 06a4a5bd6827fc300669c0237c26ae979eb7c1c0 Author: Nagy Gabor <ngaba(a)bibl.u-szeged.hu> Date: Mon Jul 21 13:57:02 2008 +0200 Re-enable --debug with -Sw and -Sp Commit 874190827676e3a974e8c5fef6c51b9e9d6b60fa disabled --debug in these cases. We just clear PM_LOG_WARNING flag now. Signed-off-by: Nagy Gabor <ngaba(a)bibl.u-szeged.hu> Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 22722261cc5bd2276e657300ea7dcbcec5381970 Author: Nagy Gabor <ngaba(a)bibl.u-szeged.hu> Date: Tue Jul 22 12:48:59 2008 +0200 New fileconflict004.py pactest Thread: http://www.archlinux.org/pipermail/pacman-dev/2008-July/012465.html Signed-off-by: Nagy Gabor <ngaba(a)bibl.u-szeged.hu> commit 24783e6b6b6833678fec289ec89198db691b1b63 Author: Hugo Doria <hugo(a)archlinux.org> Date: Mon Jul 21 14:13:13 2008 +0200 Update Portuguese (Brazil) translation Signed-off-by: Xavier Chantry <shiningxc(a)gmail.com> commit c9550e9655af0216b26c6f48b9ee474b13ccdb5f Author: Mateusz Herych <heniekk(a)gmail.com> Date: Sat Jul 19 21:01:40 2008 +0200 Update Polish translation Signed-off-by: Xavier Chantry <shiningxc(a)gmail.com> commit a7ee8f90f9a01af2443139c787ca984e03c7b006 Author: Sergey Tereschenko <serg.partizan(a)gmail.com> Date: Sat Jul 19 14:23:03 2008 +0200 Update Russian translation Signed-off-by: Xavier Chantry <shiningxc(a)gmail.com> commit 12e804511a2f3af4c032903538e456e50f24a2fb Author: Vojtěch Gondžala <vojtech.gondzala(a)gmail.com> Date: Sat Jul 19 14:14:01 2008 +0200 Update Czech translation Signed-off-by: Xavier Chantry <shiningxc(a)gmail.com> commit 6d4f235af9754a5f67b61999eac75026b5e408f3 Author: Jeff Bailes <thepizzaking(a)gmail.com> Date: Sat Jul 19 14:09:52 2008 +0200 Update British English translation Signed-off-by: Xavier Chantry <shiningxc(a)gmail.com> commit 441c2dd550c79f4ea34893fe36bd4f672c301cc4 Author: Samed Beyribey <ras0ir(a)eventualis.org> Date: Thu Jul 17 23:29:45 2008 +0200 Update Turkish translation Signed-off-by: Xavier Chantry <shiningxc(a)gmail.com> commit 27f56304d6fedec0d89f5fe926225684f3e0db31 Author: 甘露(Lu.Gan) <rhythm.gan(a)gmail.com> Date: Wed Jul 16 22:57:49 2008 -0500 Update Chinese Simplified translation Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 501ce943e64e653ddcb148a98b1044f7e7ff22bf Author: Nagy Gabor <ngaba(a)bibl.u-szeged.hu> Date: Wed Jul 16 22:55:55 2008 -0500 Update Hungarian translation Signed-off-by: Dan McGee <dan(a)archlinux.org> commit b169925c1e4a4ab4fc036fe1a8626a7a89b3013a Author: Juan Pablo González Tognarelli <lord_jotape(a)yahoo.com.ar> Date: Wed Jul 16 22:54:55 2008 -0500 Update Spanish translation Signed-off-by: Dan McGee <dan(a)archlinux.org> commit c1a648137e04599af019c52a3d368e3369691070 Author: Giovanni Scafora <linuxmania(a)gmail.com> Date: Wed Jul 16 22:52:25 2008 -0500 Update Italian translation Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 4ebad47ae7dff0f006c885c303563cb8550fb658 Author: Matthias Gorissen <matthias(a)archlinux.de> Date: Wed Jul 16 22:51:35 2008 -0500 Update German translation Signed-off-by: Dan McGee <dan(a)archlinux.org> commit ad697d2fd5af10439266b3350b3de3c9400913f5 Author: Xavier Chantry <shiningxc(a)gmail.com> Date: Wed Jul 16 22:50:19 2008 -0500 Update French translation Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 991dfca90e99826be10c4a60319b8297c665d752 Author: Xavier Chantry <shiningxc(a)gmail.com> Date: Sat Jul 19 17:12:23 2008 +0200 Update pot files. Signed-off-by: Xavier Chantry <shiningxc(a)gmail.com> commit ae9e33ed88849bfdf4a9530f674701cc32d72563 Author: Allan McRae <allan(a)archlinux.org> Date: Sun Jul 20 15:57:03 2008 +1000 Make strip paths configurable This patch introduces a new STRIP_DIRS makepkg.conf option to change makepkg's search path when stripping binaries. Original work by: Thomas Bächler <thomas(a)archlinux.org> Signed-off-by: Allan McRae <allan(a)archlinux.org> Signed-off-by: Dan McGee <dan(a)archlinux.org> ----------------------------------------------------------------------- Summary of changes: TRANSLATORS | 8 +- doc/makepkg.conf.5.txt | 7 + etc/makepkg.conf.in | 2 + lib/libalpm/po/cs.po | 250 ++++----- lib/libalpm/po/de.po | 252 +++++----- lib/libalpm/po/en_GB.po | 248 ++++----- lib/libalpm/po/es.po | 55 ++- lib/libalpm/po/fr.po | 250 ++++----- lib/libalpm/po/hu.po | 258 +++++------ lib/libalpm/po/it.po | 277 +++++------ lib/libalpm/po/libalpm.pot | 210 ++++----- lib/libalpm/po/pl.po | 296 ++++------- lib/libalpm/po/pt_BR.po | 279 +++++------ lib/libalpm/po/ru.po | 273 ++++------ lib/libalpm/po/tr.po | 282 +++++------ lib/libalpm/po/zh_CN.po | 300 +++++------ pactest/README | 4 +- pactest/tests/fileconflict004.py | 19 + po/cs.po | 716 +++++++++++--------------- po/de.po | 731 +++++++++++---------------- po/en_GB.po | 733 +++++++++++---------------- po/es.po | 338 +++++++------ po/fr.po | 720 +++++++++++---------------- po/hu.po | 640 ++++++++++------------- po/it.po | 776 ++++++++++++----------------- po/pacman.pot | 477 +++++++----------- po/pl.po | 719 +++++++++++--------------- po/pt_BR.po | 844 +++++++++++++------------------ po/ru.po | 890 +++++++++++---------------------- po/tr.po | 1033 ++++++++++++++++++-------------------- po/zh_CN.po | 905 +++++++++++++++------------------- scripts/makepkg.sh.in | 9 +- src/pacman/query.c | 7 +- src/pacman/sync.c | 10 +- 34 files changed, 5484 insertions(+), 7334 deletions(-) create mode 100644 pactest/tests/fileconflict004.py hooks/post-receive -- The official pacman repository

1 0

[pacman-dev] [PATCH 1/1] To use in cross-compile environments we need a special strip-binary.
by silvio＠port1024.net--thread 22 Jul '08

22 Jul '08

From: Silvio fricke <silvio(a)port1024.net> In most cross-compile environment there is a environment-variable $CROSS_COMPILE which reflects the toolchain. Signed-off-by: Silvio fricke <silvio(a)port1024.net> --- scripts/makepkg.sh.in | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index 2777102..9292b1b 100644 --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in @@ -736,11 +736,11 @@ tidy_install() { find ${bindirs} -type f 2>/dev/null | while read binary ; do case "$(file -biz "$binary")" in *application/x-sharedlib*) # Libraries (.so) - /usr/bin/strip --strip-debug "$binary";; + ${CROSS_COMPILE}strip --strip-debug "$binary";; *application/x-archive*) # Libraries (.a) - /usr/bin/strip --strip-debug "$binary";; + ${CROSS_COMPILE}strip --strip-debug "$binary";; *application/x-executable*) # Binaries - /usr/bin/strip "$binary";; + ${CROSS_COMPILE}strip "$binary";; esac done fi -- 1.5.6.4

5 6

[pacman-dev] [PATCH] Update pactest README
by Nagy Gabor 22 Jul '08

22 Jul '08

From ad3056757dcc675ee48324cf479b34a1c40dcd0c Mon Sep 17 00:00:00 2001 From: Nagy Gabor <ngaba(a)bibl.u-szeged.hu> Date: Tue, 22 Jul 2008 13:15:02 +0200 Subject: [PATCH] Update pactest README Signed-off-by: Nagy Gabor <ngaba(a)bibl.u-szeged.hu> --- pactest/README | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/pactest/README b/pactest/README index b995edc..5d4e47f 100644 --- a/pactest/README +++ b/pactest/README @@ -288,7 +288,7 @@ Possible rules are: PKG_GROUPS=name|group PKG_PROVIDES=name|providename PKG_DEPENDS=name|depname - PKG_REQUIREDBY=name|reqbyname + PKG_OPTDEPENDS=name|depname PKG_REASON=name|intvalue PKG_FILES=name|filename PKG_BACKUP=name|backupname @@ -303,6 +303,8 @@ its DEPENDS field. FILE_EXIST=path/to/file FILE_MODIFIED=path/to/file + FILE_MODE=path/to/file|octal + FILE_TYPE=path/to/file|type (possible types: dir, file, link) FILE_PACNEW=path/to/file FILE_PACSAVE=path/to/file FILE_PACORIG=path/to/file -- 1.5.6.4

1 0

[pacman-dev] [PATCH] New fileconflict004.py pactest
by Nagy Gabor 22 Jul '08

22 Jul '08

From 92d5c1dbe3b1ecdb4a011a67a4c7719e240d861a Mon Sep 17 00:00:00 2001 From: Nagy Gabor <ngaba(a)bibl.u-szeged.hu> Date: Tue, 22 Jul 2008 12:48:59 +0200 Subject: [PATCH] New fileconflict004.py pactest Thread: http://www.archlinux.org/pipermail/pacman-dev/2008-July/012465.html Signed-off-by: Nagy Gabor <ngaba(a)bibl.u-szeged.hu> --- pactest/tests/fileconflict004.py | 19 +++++++++++++++++++ 1 files changed, 19 insertions(+), 0 deletions(-) create mode 100644 pactest/tests/fileconflict004.py diff --git a/pactest/tests/fileconflict004.py b/pactest/tests/fileconflict004.py new file mode 100644 index 0000000..a5347cc --- /dev/null +++ b/pactest/tests/fileconflict004.py @@ -0,0 +1,19 @@ +self.description = "dir->symlink change during package upgrade (no conflict)" + +p1 = pmpkg("pkg1", "1.0-1") +p1.files = ["test/", + "test/file"] +self.addpkg2db("local", p1) + +p2 = pmpkg("pkg1", "2.0-1") +p2.files = ["test2/", + "test2/file2", + "test -> test2"] +self.addpkg2db("sync", p2) + +self.args = "-S pkg1" + +self.addrule("PACMAN_RETCODE=0") +self.addrule("PKG_EXIST=pkg1") +self.addrule("PKG_VERSION=pkg1|2.0-1") +self.addrule("FILE_TYPE=test|link") -- 1.5.6.4

1 0