- Pacman-dev - lists.archlinux.org

[pacman-dev] Fwd: Problem installing pacman-4.2.0 and 4.2.1
by Michaila Goula-Dimitriou 15 Jan '16

15 Jan '16

Hello, I am not sure if this is a bug but trying the "make" command on both 4.2.0 and 4.2.1 versions of packman gave me the exact same error: callback.o: In function `get_time_ms': /home/mixa/pacman-4.2.1/src/pacman/callback.c:59: undefined reference to `clock_gettime' collect2: ld returned 1 exit status make[3]: *** [pacman] Error 1 make[2]: *** [all-recursive] Error 1 make[1]: *** [all-recursive] Error 1 make: *** [all] Error 2 Is there something to do in order to fix this? Thank you. Goula-Dimitriou Michaila

3 3

[pacman-dev] Clang warnings
by Rikard Falkeborn 15 Jan '16

15 Jan '16

There are some warnings recently introduced when compiling with Clang (with --enable-warningflags) for x86_64. The warnings are related to casting of specific alpm_event-types to alpm_event_t where the required alignment differs between the types. On x86, it shouldn't be a problem, but maybe there are other architectures pacman should work on where this is a real issue? Either way, I think it would be good if pacman built cleanly with Clang. Any suggestions on how to fix this? For reference, the warnings are: hook.c:732:3: warning: cast from 'alpm_event_hook_t *' (aka 'struct _alpm_event_hook_t *') to 'alpm_event_t *' (aka 'union _alpm_event_t *') increases required alignment from 4 to 8 [-Wcast-align] EVENT(handle, &event); ^~~~~~~~~~~~~~~~~~~~~ ./handle.h:37:16: note: expanded from macro 'EVENT' (h)->eventcb((alpm_event_t *) (e)); \ ^~~~~~~~~~~~~~~~~~~~ hook.c:761:3: warning: cast from 'alpm_event_hook_t *' (aka 'struct _alpm_event_hook_t *') to 'alpm_event_t *' (aka 'union _alpm_event_t *') increases required alignment from 4 to 8 [-Wcast-align] EVENT(handle, &event); ^~~~~~~~~~~~~~~~~~~~~ ./handle.h:37:16: note: expanded from macro 'EVENT' (h)->eventcb((alpm_event_t *) (e)); \ ^~~~~~~~~~~~~~~~~~~~ 2 warnings generated. trans.c:202:2: warning: cast from 'alpm_event_any_t *' (aka 'struct _alpm_event_any_t *') to 'alpm_event_t *' (aka 'union _alpm_event_t *') increases required alignment from 4 to 8 [-Wcast-align] EVENT(handle, &event); ^~~~~~~~~~~~~~~~~~~~~ ./handle.h:37:16: note: expanded from macro 'EVENT' (h)->eventcb((alpm_event_t *) (e)); \ ^~~~~~~~~~~~~~~~~~~~ trans.c:226:3: warning: cast from 'alpm_event_any_t *' (aka 'struct _alpm_event_any_t *') to 'alpm_event_t *' (aka 'union _alpm_event_t *') increases required alignment from 4 to 8 [-Wcast-align] EVENT(handle, &event); ^~~~~~~~~~~~~~~~~~~~~ ./handle.h:37:16: note: expanded from macro 'EVENT' (h)->eventcb((alpm_event_t *) (e)); \ ^~~~~~~~~~~~~~~~~~~~

4 12

[pacman-dev] [PATCH] add alpm_list_append
by Andrew Gregory 11 Jan '16

11 Jan '16

alpm_list_add always returns the provided list making it impossible for callers to check whether or not the operation actually succeeded without manually comparing the list length before and after. alpm_list_append instead returns a pointer to the newly created list item so that success can be checked. Signed-off-by: Andrew Gregory <andrew.gregory.8(a)gmail.com> --- lib/libalpm/alpm_list.c | 34 ++++++++++++++++++++++++---------- lib/libalpm/alpm_list.h | 1 + 2 files changed, 25 insertions(+), 10 deletions(-) diff --git a/lib/libalpm/alpm_list.c b/lib/libalpm/alpm_list.c index 62b2843..f3effc7 100644 --- a/lib/libalpm/alpm_list.c +++ b/lib/libalpm/alpm_list.c @@ -93,28 +93,42 @@ void SYMEXPORT alpm_list_free_inner(alpm_list_t *list, alpm_list_fn_free fn) */ alpm_list_t SYMEXPORT *alpm_list_add(alpm_list_t *list, void *data) { - alpm_list_t *ptr, *lp; + alpm_list_append(&list, data); + return list; +} + +/** + * @brief Add a new item to the end of the list. + * + * @param list the list to add to + * @param data the new item to be added to the list + * + * @return the newly added item + */ +alpm_list_t SYMEXPORT *alpm_list_append(alpm_list_t **list, void *data) +{ + alpm_list_t *ptr; ptr = malloc(sizeof(alpm_list_t)); if(ptr == NULL) { - return list; + return NULL; } ptr->data = data; ptr->next = NULL; /* Special case: the input list is empty */ - if(list == NULL) { + if(*list == NULL) { + *list = ptr; ptr->prev = ptr; - return ptr; + } else { + alpm_list_t *lp = alpm_list_last(*list); + lp->next = ptr; + ptr->prev = lp; + (*list)->prev = ptr; } - lp = alpm_list_last(list); - lp->next = ptr; - ptr->prev = lp; - list->prev = ptr; - - return list; + return ptr; } /** diff --git a/lib/libalpm/alpm_list.h b/lib/libalpm/alpm_list.h index 801f4a0..5af84e1 100644 --- a/lib/libalpm/alpm_list.h +++ b/lib/libalpm/alpm_list.h @@ -57,6 +57,7 @@ void alpm_list_free_inner(alpm_list_t *list, alpm_list_fn_free fn); /* item mutators */ alpm_list_t *alpm_list_add(alpm_list_t *list, void *data); +alpm_list_t *alpm_list_append(alpm_list_t **list, void *data); alpm_list_t *alpm_list_add_sorted(alpm_list_t *list, void *data, alpm_list_fn_cmp fn); alpm_list_t *alpm_list_join(alpm_list_t *first, alpm_list_t *second); alpm_list_t *alpm_list_mmerge(alpm_list_t *left, alpm_list_t *right, alpm_list_fn_cmp fn); -- 2.7.0

1 0

[pacman-dev] Why is FS#30993 still open?
by Alastair Hughes 11 Jan '16

11 Jan '16

pacman can obviously be built statically, so I've probably missed the point; why is FS#30993 still open? What functionality is broken (if any) in the static version? I haven't found anything yet, but... Regards, Alastair Hughes

2 1

[pacman-dev] [PATCH] doc: alpm-hooks.5: Fix missing space before Description
by Johannes Löthberg 04 Jan '16

04 Jan '16

Signed-off-by: Johannes Löthberg <johannes(a)kyriasis.com> --- doc/alpm-hooks.5.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/alpm-hooks.5.txt b/doc/alpm-hooks.5.txt index f33ff8c..aee2ff8 100644 --- a/doc/alpm-hooks.5.txt +++ b/doc/alpm-hooks.5.txt @@ -64,7 +64,7 @@ defined the hook will run if the transaction matches *any* of the triggers. ACTIONS ------- -* Description =* ...:: +*Description =* ...:: An optional description that describes the action being taken by the hook for use in front-end output. -- 2.6.4

1 1

[pacman-dev] [PATCH] libalpm, fix leak if malloc fails in be_sync
by Rikard Falkeborn 04 Jan '16

04 Jan '16

--- lib/libalpm/be_sync.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/libalpm/be_sync.c b/lib/libalpm/be_sync.c index b09b060..9229622 100644 --- a/lib/libalpm/be_sync.c +++ b/lib/libalpm/be_sync.c @@ -178,6 +178,7 @@ int SYMEXPORT alpm_db_update(int force, alpm_db_t *db) const char *dbext; alpm_list_t *i; int ret = -1; + int memory_error = 0; mode_t oldmask; alpm_handle_t *handle; alpm_siglevel_t level; @@ -230,8 +231,7 @@ int SYMEXPORT alpm_db_update(int force, alpm_db_t *db) /* print server + filename into a buffer */ len = strlen(server) + strlen(db->treename) + strlen(dbext) + 2; - /* TODO fix leak syncpath and umask unset */ - MALLOC(payload.fileurl, len, RET_ERR(handle, ALPM_ERR_MEMORY, -1)); + MALLOC(payload.fileurl, len, memory_error = 1; goto cleanup); snprintf(payload.fileurl, len, "%s/%s%s", server, db->treename, dbext); payload.handle = handle; payload.force = force; @@ -269,8 +269,7 @@ int SYMEXPORT alpm_db_update(int force, alpm_db_t *db) len = strlen(server) + strlen(db->treename) + strlen(dbext) + 6; } - /* TODO fix leak syncpath and umask unset */ - MALLOC(payload.fileurl, len, RET_ERR(handle, ALPM_ERR_MEMORY, -1)); + MALLOC(payload.fileurl, len, memory_error = 1; goto cleanup); if(final_db_url != NULL) { snprintf(payload.fileurl, len, "%s.sig", final_db_url); @@ -322,9 +321,10 @@ int SYMEXPORT alpm_db_update(int force, alpm_db_t *db) } cleanup: - _alpm_handle_unlock(handle); free(syncpath); umask(oldmask); + ASSERT(memory_error == 0, RET_ERR(handle, ALPM_ERR_MEMORY, -1)); + _alpm_handle_unlock(handle); return ret; } -- 2.6.2

3 2

[pacman-dev] [PATCH 0/3] Char signedness issues
by Rikard Falkeborn 04 Jan '16

04 Jan '16

I tried compiling pacman on my RPi (Arm), where char is unsigned by default. That leads to some things not working the way they are expected too. The problem is as follows: char a = -1; if (a == -1) { ... } If char is unsigned, we will not enter the if-statement (a is converted to int) before making the comparisson. Gcc will warn about these comparissons. The first two patches fixes the cases I (and Gcc) could find, and the third one is a couple of tests I wrote to convince myself there was a problem in pacsort (and more importantly, that the changes actually fixes something). After doing this, I realize that the simplest solution probably would be to add -fsigned-char as an argument to the compiler... thoughts? Rikard Falkeborn (3): Make alpm_graph state signedness explicit pacsort, introduce define for escape_char error code Add pacsort tests with invalid input lib/libalpm/graph.h | 2 +- src/util/pacsort.c | 11 ++++++----- test/util/pacsorttest.sh | 18 +++++++++++++++++- 3 files changed, 24 insertions(+), 7 deletions(-) -- 2.6.4

2 5

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v4.2.1-303-gfa72c2c
by allan＠archlinux.org 04 Jan '16

04 Jan '16

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, master has been updated via fa72c2cdc2682eb55edd0d8b19fb1eba4e061670 (commit) via 4742f5929dda4a7418781bc4b3d834a9f22b2d62 (commit) via 8ca96447ddb6f5b3f8bbb4a7ed946fc9a2907524 (commit) via 6aee32102f667a18b050e934759585260cae9ae6 (commit) via 774c7eb24dde6d72d7a9d9e7d6ae248a5a35f480 (commit) from a671fa497c7317e240e014e93bddfdbf1d270b2b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit fa72c2cdc2682eb55edd0d8b19fb1eba4e061670 Author: Allan McRae <allan(a)archlinux.org> Date: Mon Dec 21 15:07:49 2015 +1000 Update README for pacman-5.0 Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 4742f5929dda4a7418781bc4b3d834a9f22b2d62 Author: Allan McRae <allan(a)archlinux.org> Date: Sun Jan 3 13:48:43 2016 +1000 Update copyright years for 2016 make update-copyright OLD=2015 NEW=2016 Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 8ca96447ddb6f5b3f8bbb4a7ed946fc9a2907524 Author: Daniel Hahler <git(a)thequod.de> Date: Wed Dec 23 19:56:51 2015 +0100 zsh_completion: add -q/--quiet for -Q/-S This should also be added for "-Fh", but that is missing completely in zsh_completion. 1: https://lists.archlinux.org/pipermail/pacman-dev/2015-November/020538.html Signed-off-by: Daniel Hahler <git(a)thequod.de> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 6aee32102f667a18b050e934759585260cae9ae6 Author: Alastair Hughes <hobbitalastair(a)gmail.com> Date: Thu Dec 31 13:10:21 2015 +1300 Replace mktemp's --tmpdir option with shell code. bacman and updpkgsums used GNU mktemp's --tmpdir option, which is not supported by some other implementations (including busybox). Replace that with shell code. Signed-off-by: Alastair Hughes <hobbitalastair(a)gmail.com> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 774c7eb24dde6d72d7a9d9e7d6ae248a5a35f480 Author: Allan McRae <allan(a)archlinux.org> Date: Mon Dec 21 16:58:36 2015 +1000 Do not warn about missing files in NoExtract The CheckSpace option checks the size of all files in a package being replaced and gives a warning when it can not read the file. However, files in NoExtract are expected to be missing and should not be warned about. Fixes FS#47470. Signed-off-by: Allan McRae <allan(a)archlinux.org> ----------------------------------------------------------------------- Summary of changes: README | 25 ++++++++++++++++++---- contrib/bacman.sh.in | 6 +++--- contrib/pacdiff.sh.in | 4 ++-- contrib/pacscripts.sh.in | 2 +- contrib/updpkgsums.sh.in | 4 ++-- contrib/zsh_completion.in | 2 ++ doc/index.txt | 2 +- lib/libalpm/add.c | 2 +- lib/libalpm/add.h | 2 +- lib/libalpm/alpm.c | 2 +- lib/libalpm/alpm.h | 2 +- lib/libalpm/alpm_list.c | 2 +- lib/libalpm/alpm_list.h | 2 +- lib/libalpm/backup.c | 2 +- lib/libalpm/backup.h | 2 +- lib/libalpm/be_local.c | 2 +- lib/libalpm/be_package.c | 2 +- lib/libalpm/be_sync.c | 2 +- lib/libalpm/conflict.c | 2 +- lib/libalpm/conflict.h | 2 +- lib/libalpm/db.c | 2 +- lib/libalpm/db.h | 2 +- lib/libalpm/delta.c | 2 +- lib/libalpm/delta.h | 2 +- lib/libalpm/deps.c | 2 +- lib/libalpm/deps.h | 2 +- lib/libalpm/diskspace.c | 8 ++++--- lib/libalpm/diskspace.h | 2 +- lib/libalpm/dload.c | 2 +- lib/libalpm/dload.h | 2 +- lib/libalpm/error.c | 2 +- lib/libalpm/filelist.c | 2 +- lib/libalpm/filelist.h | 2 +- lib/libalpm/graph.c | 2 +- lib/libalpm/graph.h | 2 +- lib/libalpm/group.c | 2 +- lib/libalpm/group.h | 2 +- lib/libalpm/handle.c | 2 +- lib/libalpm/handle.h | 2 +- lib/libalpm/hook.c | 2 +- lib/libalpm/hook.h | 2 +- lib/libalpm/libarchive-compat.h | 2 +- lib/libalpm/log.c | 2 +- lib/libalpm/log.h | 2 +- lib/libalpm/package.c | 2 +- lib/libalpm/package.h | 2 +- lib/libalpm/pkghash.c | 2 +- lib/libalpm/pkghash.h | 2 +- lib/libalpm/remove.c | 2 +- lib/libalpm/remove.h | 2 +- lib/libalpm/signing.c | 2 +- lib/libalpm/signing.h | 2 +- lib/libalpm/sync.c | 2 +- lib/libalpm/sync.h | 2 +- lib/libalpm/trans.c | 2 +- lib/libalpm/trans.h | 2 +- lib/libalpm/util.c | 2 +- lib/libalpm/util.h | 2 +- lib/libalpm/version.c | 2 +- scripts/libmakepkg/lint_package.sh.in | 2 +- .../libmakepkg/lint_package/build_references.sh.in | 2 +- .../libmakepkg/lint_package/missing_backup.sh.in | 2 +- scripts/libmakepkg/lint_pkgbuild.sh.in | 2 +- scripts/libmakepkg/lint_pkgbuild/arch.sh.in | 2 +- scripts/libmakepkg/lint_pkgbuild/backup.sh.in | 2 +- scripts/libmakepkg/lint_pkgbuild/changelog.sh.in | 2 +- scripts/libmakepkg/lint_pkgbuild/epoch.sh.in | 2 +- scripts/libmakepkg/lint_pkgbuild/install.sh.in | 2 +- scripts/libmakepkg/lint_pkgbuild/optdepends.sh.in | 2 +- scripts/libmakepkg/lint_pkgbuild/options.sh.in | 2 +- .../lint_pkgbuild/package_function.sh.in | 2 +- scripts/libmakepkg/lint_pkgbuild/pkgbase.sh.in | 2 +- scripts/libmakepkg/lint_pkgbuild/pkglist.sh.in | 2 +- scripts/libmakepkg/lint_pkgbuild/pkgname.sh.in | 2 +- scripts/libmakepkg/lint_pkgbuild/pkgrel.sh.in | 2 +- scripts/libmakepkg/lint_pkgbuild/pkgver.sh.in | 2 +- scripts/libmakepkg/lint_pkgbuild/provides.sh.in | 2 +- scripts/libmakepkg/lint_pkgbuild/source.sh.in | 2 +- scripts/libmakepkg/lint_pkgbuild/util.sh.in | 2 +- scripts/libmakepkg/lint_pkgbuild/variable.sh.in | 2 +- scripts/libmakepkg/source.sh.in | 2 +- scripts/libmakepkg/source/bzr.sh.in | 2 +- scripts/libmakepkg/source/file.sh.in | 2 +- scripts/libmakepkg/source/git.sh.in | 2 +- scripts/libmakepkg/source/hg.sh.in | 2 +- scripts/libmakepkg/source/local.sh.in | 2 +- scripts/libmakepkg/source/svn.sh.in | 2 +- scripts/libmakepkg/tidy.sh.in | 2 +- scripts/libmakepkg/tidy/docs.sh.in | 2 +- scripts/libmakepkg/tidy/emptydirs.sh.in | 2 +- scripts/libmakepkg/tidy/libtool.sh.in | 2 +- scripts/libmakepkg/tidy/optipng.sh.in | 2 +- scripts/libmakepkg/tidy/purge.sh.in | 2 +- scripts/libmakepkg/tidy/staticlibs.sh.in | 2 +- scripts/libmakepkg/tidy/strip.sh.in | 2 +- scripts/libmakepkg/tidy/upx.sh.in | 2 +- scripts/libmakepkg/tidy/zipman.sh.in | 2 +- scripts/libmakepkg/util.sh.in | 2 +- scripts/libmakepkg/util/message.sh | 2 +- scripts/libmakepkg/util/option.sh | 2 +- scripts/libmakepkg/util/pkgbuild.sh.in | 2 +- scripts/libmakepkg/util/source.sh.in | 2 +- scripts/libmakepkg/util/util.sh | 2 +- scripts/makepkg-template.pl.in | 4 ++-- scripts/makepkg-wrapper.sh.in | 2 +- scripts/makepkg.sh.in | 4 ++-- scripts/pacman-db-upgrade.sh.in | 4 ++-- scripts/pacman-key.sh.in | 4 ++-- scripts/pacman-optimize.sh.in | 4 ++-- scripts/repo-add.sh.in | 4 ++-- src/common/ini.c | 2 +- src/common/ini.h | 2 +- src/common/util-common.c | 2 +- src/common/util-common.h | 2 +- src/pacman/callback.c | 2 +- src/pacman/callback.h | 2 +- src/pacman/check.c | 2 +- src/pacman/check.h | 2 +- src/pacman/conf.c | 2 +- src/pacman/conf.h | 2 +- src/pacman/database.c | 2 +- src/pacman/deptest.c | 2 +- src/pacman/files.c | 2 +- src/pacman/package.c | 2 +- src/pacman/package.h | 2 +- src/pacman/pacman.c | 4 ++-- src/pacman/pacman.h | 2 +- src/pacman/query.c | 2 +- src/pacman/remove.c | 2 +- src/pacman/sighandler.c | 2 +- src/pacman/sighandler.h | 2 +- src/pacman/sync.c | 2 +- src/pacman/upgrade.c | 2 +- src/pacman/util.c | 2 +- src/pacman/util.h | 2 +- src/util/cleanupdelta.c | 2 +- src/util/pacsort.c | 2 +- src/util/pactree.c | 2 +- src/util/testpkg.c | 2 +- src/util/vercmp.c | 2 +- test/pacman/pactest.py | 2 +- test/pacman/pmdb.py | 2 +- test/pacman/pmenv.py | 2 +- test/pacman/pmfile.py | 2 +- test/pacman/pmpkg.py | 2 +- test/pacman/pmrule.py | 2 +- test/pacman/pmtest.py | 2 +- test/pacman/tap.py | 2 +- test/pacman/util.py | 2 +- test/util/pacsorttest.sh | 2 +- test/util/vercmptest.sh | 2 +- 151 files changed, 187 insertions(+), 166 deletions(-) hooks/post-receive -- The official pacman repository

1 0

03 Jan '16

1 0

[pacman-dev] Updating bash and zsh completion
by Allan McRae 01 Jan '16

01 Jan '16

Does anyone want to look at updating our bash adn zsh completion to include the new options for -D and -F (and anything else that is missing)? There is a patch for zsh here: https://bugs.archlinux.org/index.php?do=details&task_id=47559 And an issue for bash completion here: https://bugs.archlinux.org/index.php?do=details&task_id=47333 Allan

2 1