- Pacman-dev - lists.archlinux.org

[pacman-dev] Fetch callback patch, take 2
by Dario Freddi 18 Jul '09

18 Jul '09

Hello people, Here goes another chapter of the fetch callback saga. I finally managed to get a patch working on my copy and completed the integration with Shaman. I have attached a patch that is almost completely based upon Sebastian's one, however it does not abstract the logic of xfercommand out to pacman. Now alpm works this way: 1. If the frontend registered a fetch callback, use that 2. If there is a xfercommand, use that 3. If there's nothing, usual behavior You can pull aqpm+shaman master and check out how things work well. In the shaman land, now it works like this. 1. Shaman creates the queue and streams it to Aqpm 2. Aqpm authentifies itself through Policykit 3. Aqpm spawns an helper, running as root (remember that shaman now doesn't run as root or suid) 4. The helper checks for the caller's authorization, and then registers its own callback. It will then stream progress back to Aqpm through DBus In case the patch doesn't cut out, I was thinking about shipping along with Aqpm a bundled alpm with this patch in, and I would appreciate some opinions on that too. -- ------------------- Dario Freddi KDE Developer GPG Key Signature: 511A9A3B

2 3

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v3.2.2-204-g8ebc077
by dan＠archlinux.org 16 Jul '09

16 Jul '09

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, master has been updated via 8ebc07744ac58ed1e42af3a52d998587fca85f8b (commit) via 2e043aae36bdb8a7591646db00a95dd21f1f368f (commit) from 41a55d4effecfb2914e96ed4a99eb621557c6d2f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8ebc07744ac58ed1e42af3a52d998587fca85f8b Author: Xavier Chantry <shiningxc(a)gmail.com> Date: Wed Jul 8 14:00:25 2009 +0200 Offer to clean up non-package files in cache directory. This implements FS#15142. Signed-off-by: Xavier Chantry <shiningxc(a)gmail.com> Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 2e043aae36bdb8a7591646db00a95dd21f1f368f Author: Xavier Chantry <shiningxc(a)gmail.com> Date: Wed Jul 8 11:08:32 2009 +0200 Run ldconfig inside chroot. This fixes FS#15294. The code to run a command inside a chroot was refactored from the _alpm_runscriptlet function to _alpm_run_chroot. Signed-off-by: Xavier Chantry <shiningxc(a)gmail.com> ----------------------------------------------------------------------- Summary of changes: lib/libalpm/add.c | 1 - lib/libalpm/remove.c | 1 - lib/libalpm/trans.c | 88 +------------------------------------------ lib/libalpm/util.c | 103 ++++++++++++++++++++++++++++++++++++++++++++++++- lib/libalpm/util.h | 1 + src/pacman/sync.c | 14 ++++--- 6 files changed, 110 insertions(+), 98 deletions(-) hooks/post-receive -- The official pacman repository

1 0

[pacman-dev] questions about pmhandle and pmtrans
by Xavier 16 Jul '09

16 Jul '09

The handle contains the current transaction and the local database : typedef struct _pmhandle_t { /* internal usage */ pmdb_t *db_local; /* local db pointer */ alpm_list_t *dbs_sync; /* List of (pmdb_t *) */ FILE *logstream; /* log file stream pointer */ int lckfd; /* lock file descriptor if one exists */ pmtrans_t *trans; Yet we pass the trans or db_local param to many many functions : $ egrep "pmtrans_t|db_local" lib/libalpm/*.h lib/libalpm/add.h:int _alpm_add_loadtarget(pmtrans_t *trans, pmdb_t *db, char *name); lib/libalpm/add.h:int _alpm_upgrade_packages(pmtrans_t *trans, pmdb_t *db); lib/libalpm/alpm.h:typedef struct __pmtrans_t pmtrans_t; lib/libalpm/conflict.h:alpm_list_t *_alpm_db_find_fileconflicts(pmdb_t *db, pmtrans_t *trans, lib/libalpm/handle.h: pmdb_t *db_local; /* local db pointer */ lib/libalpm/handle.h: pmtrans_t *trans; lib/libalpm/remove.h:int _alpm_remove_loadtarget(pmtrans_t *trans, pmdb_t *db, char *name); lib/libalpm/remove.h:int _alpm_remove_prepare(pmtrans_t *trans, pmdb_t *db, alpm_list_t **data); lib/libalpm/remove.h:int _alpm_remove_commit(pmtrans_t *trans, pmdb_t *db); lib/libalpm/remove.h:int _alpm_remove_packages(pmtrans_t *trans, pmdb_t *db); lib/libalpm/sync.h:int _alpm_sync_sysupgrade(pmtrans_t *trans, pmdb_t *db_local, alpm_list_t *dbs_sync, int enable_downgrade); lib/libalpm/sync.h:int _alpm_sync_addtarget(pmtrans_t *trans, pmdb_t *db_local, alpm_list_t *dbs_sync, char *name); lib/libalpm/sync.h:int _alpm_sync_prepare(pmtrans_t *trans, pmdb_t *db_local, alpm_list_t *dbs_sync, alpm_list_t **data); lib/libalpm/sync.h:int _alpm_sync_commit(pmtrans_t *trans, pmdb_t *db_local, alpm_list_t **data); lib/libalpm/trans.h:struct __pmtrans_t { lib/libalpm/trans.h:pmtrans_t *_alpm_trans_new(void); lib/libalpm/trans.h:void _alpm_trans_free(pmtrans_t *trans); lib/libalpm/trans.h:int _alpm_trans_init(pmtrans_t *trans, pmtransflag_t flags, lib/libalpm/trans.h:int _alpm_trans_prepare(pmtrans_t *trans, alpm_list_t **data); lib/libalpm/trans.h:int _alpm_trans_commit(pmtrans_t *trans, alpm_list_t **data); lib/libalpm/trans.h: const char *oldver, pmtrans_t *trans); So what is the preferred way here? Since we use handle->trans or handle->db_local in some places, why not everywhere? Another thing I am wondering, why these 3 callbacks are part of pmtrans : alpm_trans_cb_event cb_event; alpm_trans_cb_conv cb_conv; alpm_trans_cb_progress cb_progress; and the other callbacks are in pmhandle : /* callback functions */ alpm_cb_log logcb; /* Log callback function */ alpm_cb_download dlcb; /* Download callback function */ alpm_cb_totaldl totaldlcb; /* Total download callback function */ Why not having all callbacks in the handle? At least in pacman frontend, cb_event, cb_conv and cb_progress are the same for all transactions.

1 1

[pacman-dev] nautilus extension for packages
by K. Piche 16 Jul '09

16 Jul '09

Hi, Aaron suggested I send this here to put in contrib. Haven't made any changes since the original announcement on arch-dev-public. Regards, k -- K. Piche <kpiche(a)rogers.com>

2 2

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v3.2.2-202-g41a55d4
by dan＠archlinux.org 16 Jul '09

16 Jul '09

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, master has been updated via 41a55d4effecfb2914e96ed4a99eb621557c6d2f (commit) via 5dc0b80c2683551c10b96157ba34b277db25b82d (commit) via 104daa16a69708c9b16fc59ac895f2932ea509d4 (commit) via caa0f2205a62344c4df6e286e14a0d89cd1d10f2 (commit) via 68c10690eae369928b6cdc2d658588ad06e4b1a5 (commit) via 8d7764abaecb89a5baa6b4afe25f4db8e8a40465 (commit) via 6092dda1775a3d887d557c0e4961645a4ed67064 (commit) via e72cce352a4f43e371998dc8985b5fa2e0102216 (commit) via 621aa26e26fcf578221051e896d6440a0095b8a3 (commit) via b312c820c8c8ed98a8b8f927b948bca8a3a22632 (commit) via 617e7d512ff6fb7d6c5e5232091b528148cc40c7 (commit) from c72b4543b69f5a80d254a3f408748e19db758947 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 41a55d4effecfb2914e96ed4a99eb621557c6d2f Author: Volodia Macovei <blog(a)volodia.ro> Date: Wed Jul 1 11:06:02 2009 -0500 Update Romanian translation Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 5dc0b80c2683551c10b96157ba34b277db25b82d Author: Allan McRae <allan(a)archlinux.org> Date: Sun Jul 12 17:10:11 2009 +1000 makepkg: clean up BUILDSCRIPT usage FS#15448 (which is made worse by the "fix" for FS#14727...), highlighted some deficiencies in the usage of the BUILDSCRIPT variable. In particular, only relative paths worked with "-p" and some output was very strange in combination with the "-p" flag or reading from /dev/stdin. e.g. "Please add a license line to your /dev/stdin!". This patch adds a new variable, BUILDFILE, which contains the full path to the BUILDSCRIPT. This defaults to $startdir/$BUILDSCRIPT. Also, fix a missed quoting of $BUILD{SCRIPT->FILE} and remove warning about missing BUILDSCRIPT definition in makepkg.conf as the default BUILDSCRIPT value is now specified during configure. Add check that BUILDFILE is writable before updating VCS PKGBUILDs. When making a source package, the BUILDSCRIPT always gets given the default name, regardless of what it was originally called. Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 104daa16a69708c9b16fc59ac895f2932ea509d4 Author: Allan McRae <allan(a)archlinux.org> Date: Sun Jul 12 01:07:46 2009 +1000 makepkg: allow spaces in source file names The download command failed with sources that contained spaces. Remainder of fix for FS#15323. Signed-off-by: Allan McRae <allan(a)archlinux.org> commit caa0f2205a62344c4df6e286e14a0d89cd1d10f2 Author: Dan McGee <dan(a)archlinux.org> Date: Wed Jul 1 02:31:59 2009 -0500 makepkg: fix breakage with '%' in source filenames Ensure we don't pass a bare filename to printf that might contain a lookalike '%' escape sequence. Fixes part of FS#15323. Signed-off-by: Dan McGee <dan(a)archlinux.org> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 68c10690eae369928b6cdc2d658588ad06e4b1a5 Author: Dan McGee <dan(a)archlinux.org> Date: Wed Jul 1 02:26:27 2009 -0500 makepkg: quote filenames when extracting We currently fall apart on files with spaces in the names. Signed-off-by: Dan McGee <dan(a)archlinux.org> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 8d7764abaecb89a5baa6b4afe25f4db8e8a40465 Author: Allan McRae <allan(a)archlinux.org> Date: Fri Jul 10 00:31:20 2009 +1000 Quote values in the arch array in example PKGBUILD Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 6092dda1775a3d887d557c0e4961645a4ed67064 Author: Allan McRae <allan(a)archlinux.org> Date: Sat Jul 4 03:16:14 2009 +1000 makepkg: check for package functions when package splitting Makes sure the required package functions are present when using package splitting. Also moves setting of pkgbase variable outside the check_sanity function to somewhere more appropriate. Signed-off-by: Allan McRae <allan(a)archlinux.org> commit e72cce352a4f43e371998dc8985b5fa2e0102216 Author: Allan McRae <allan(a)archlinux.org> Date: Sat Jul 4 02:28:03 2009 +1000 makepkg: fix pkgdesc restoration with split packaging A pkgdesc with spaces in it would get restored to an array and thus only the first word would be restored (FS#15210). Convert that array back to a string. Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 621aa26e26fcf578221051e896d6440a0095b8a3 Author: Allan McRae <allan(a)archlinux.org> Date: Sat Jul 4 01:52:28 2009 +1000 makepkg: Exit on failure within build() or package() functions Errors in build() functions were only fatal, if "--log" was enabled. Errors in package() functions were never fatal. Piping these functions through "cat -" triggers error trapping. This prevents the need for "|| return 1" usage in PKGBUILDs. Original-patch-by: Juergen Hoetzel <juergen(a)archlinux.org> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit b312c820c8c8ed98a8b8f927b948bca8a3a22632 Author: Allan McRae <allan(a)archlinux.org> Date: Thu Jul 2 13:53:29 2009 +1000 makepkg: fix check for previously built packages with package splitting Checks if some or all packages are built before overwriting/installing. Adds some new strings for translation. Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 617e7d512ff6fb7d6c5e5232091b528148cc40c7 Author: Allan McRae <allan(a)archlinux.org> Date: Wed Jul 1 13:52:52 2009 +1000 makepkg: clean up moving PKGINFO creation to a function Someone forgot to commit this when pulling in the original patch to his working branch... Signed-off-by: Allan McRae <allan(a)archlinux.org> ----------------------------------------------------------------------- Summary of changes: doc/PKGBUILD-example.txt | 2 +- po/ro.po | 8 +- scripts/makepkg.sh.in | 137 ++++++++++++++++++++++++++++++---------------- 3 files changed, 95 insertions(+), 52 deletions(-) hooks/post-receive -- The official pacman repository

1 0

[pacman-dev] [PATCH] makepkg: clean up BUILDSCRIPT usage
by Allan McRae 12 Jul '09

12 Jul '09

FS#15448 (which is made worse by the "fix" for FS#14727...), highlighted some deficiencies in the usage of the BUILDSCRIPT variable. In particular, only relative paths worked with "-p" and some output was very strange in combination with the "-p" flag or reading from /dev/stdin. e.g. "Please add a license line to your /dev/stdin!". This patch adds a new variable, BUILDFILE, which contains the full path to the BUILDSCRIPT. This defaults to $startdir/$BUILDSCRIPT. Also, fix a missed quoting of $BUILD{SCRIPT->FILE} and remove warning about missing BUILDSCRIPT definition in makepkg.conf as the default BUILDSCRIPT value is not specified during configure. Add check that BUILDFILE is writeable before udpating VCS PKGBUILDs. When making a source package, the BUILDSCRIPT always gets given the default name, regardless of what it was originally called. Signed-off-by: Allan McRae <allan(a)archlinux.org> --- scripts/makepkg.sh.in | 40 ++++++++++++++++++++-------------------- 1 files changed, 20 insertions(+), 20 deletions(-) diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index 8998e0d..50cf54d 100644 --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in @@ -1032,7 +1032,7 @@ create_srcpackage() { mkdir "${srclinks}"/${pkgbase} msg2 "$(gettext "Adding %s...")" "$BUILDSCRIPT" - ln -s "${startdir}/${BUILDSCRIPT}" "${srclinks}/${pkgbase}/" + ln -s "${BUILDFILE}" "${srclinks}/${pkgbase}/${BUILDSCRIPT}" if [ -n "$install" ]; then if [ -f $install ]; then @@ -1192,8 +1192,9 @@ devel_check() { newpkgver="" # Do not update pkgver if --holdver is set, when building a source package, - # or when reading PKGBUILD from pipe - if [ "$HOLDVER" -eq 1 -o "$SOURCEONLY" -ne 0 -o ! -f "./$BUILDSCRIPT" ]; then + # when reading PKGBUILD from pipe (-f), or if we cannot write to the file (-w) + if [ "$HOLDVER" -eq 1 -o "$SOURCEONLY" -ne 0 -o ! -f "$BUILDFILE" \ + -o ! -w "$BUILDFILE" ]; then return fi @@ -1262,10 +1263,10 @@ devel_update() { # if [ -n "$newpkgver" ]; then if [ "$newpkgver" != "$pkgver" ]; then - if [ -f "./$BUILDSCRIPT" ]; then - @SEDINPLACE@ "s/^pkgver=[^ ]*/pkgver=$newpkgver/" "./$BUILDSCRIPT" - @SEDINPLACE@ "s/^pkgrel=[^ ]*/pkgrel=1/" "./$BUILDSCRIPT" - source "$BUILDSCRIPT" + if [ -f "$BUILDFILE" -a -w "$BUILDFILE" ]; then + @SEDINPLACE@ "s/^pkgver=[^ ]*/pkgver=$newpkgver/" "$BUILDFILE" + @SEDINPLACE@ "s/^pkgrel=[^ ]*/pkgrel=1/" "$BUILDFILE" + source "$BUILDFILE" fi fi fi @@ -1480,7 +1481,7 @@ while true; do -L|--log) LOGGING=1 ;; -m|--nocolor) USE_COLOR='n' ;; -o|--nobuild) NOBUILD=1 ;; - -p) shift; BUILDSCRIPT=$1 ;; + -p) shift; BUILDFILE=$1 ;; -r|--rmdeps) RMDEPS=1 ;; -R|--repackage) REPKG=1 ;; --source) SOURCEONLY=1 ;; @@ -1565,11 +1566,6 @@ if [ "$CLEANCACHE" -eq 1 ]; then fi fi -if [ -z "$BUILDSCRIPT" ]; then - error "$(gettext "BUILDSCRIPT is undefined! Ensure you have updated %s.")" "$MAKEPKG_CONF" - exit 1 -fi - if [ "$INFAKEROOT" -eq 0 ]; then if [ $EUID -eq 0 -a "$ASROOT" -eq 0 ]; then # Warn those who like to live dangerously. @@ -1616,23 +1612,27 @@ unset pkgname pkgbase pkgver pkgrel pkgdesc url license groups provides unset md5sums replaces depends conflicts backup source install build unset makedepends optdepends options noextract -if [ ! -f "$BUILDSCRIPT" ]; then +BUILDFILE=${BUILDFILE:-$BUILDSCRIPT} +if [ ! -f "$BUILDFILE" ]; then if [ -t 0 ]; then - error "$(gettext "%s does not exist.")" "$BUILDSCRIPT" + error "$(gettext "%s does not exist.")" "$BUILDFILE" exit 1 else # PKGBUILD passed through a pipe - BUILDSCRIPT=/dev/stdin - source "$BUILDSCRIPT" + BUILDFILE=/dev/stdin + source "$BUILDFILE" fi else - crlftest=$(file $BUILDSCRIPT | grep -F 'CRLF' || true) + crlftest=$(file "$BUILDFILE" | grep -F 'CRLF' || true) if [ -n "$crlftest" ]; then - error "$(gettext "%s contains CRLF characters and cannot be sourced.")" "$BUILDSCRIPT" + error "$(gettext "%s contains CRLF characters and cannot be sourced.")" "$BUILDFILE" exit 1 fi - source ./"$BUILDSCRIPT" + if [ "${BUILDFILE:0:1}" != "/" ]; then + BUILDFILE="$startdir/$BUILDFILE" + fi + source "$BUILDFILE" fi if [ "$GENINTEG" -eq 1 ]; then -- 1.6.3.3

1 0

[pacman-dev] makepkg security
by Thomas Bächler 11 Jul '09

11 Jul '09

This continues a thread on arch-general: Thomas Bächler schrieb: >>> I agree. The question is not about makepkg security, but about sudo >>> security. And frankly, sudo is a security desaster in its default >>> configuration. >> >> Any suggestions for changing / shipping a better default config file? >> I know little about the security implications of this, but I think we >> should ship a decent default if possible. > > Our policy is usually to ship whatever upstream ships. IMO, a good > default would be to set sudo to require the root password (not the user > password) and not cache any passwords at all. > > Also, I think instead of using sudo in makepkg, we should use su by > default (with an option to enable sudo). su always has a good default > configuration requiring the root password (it's also possible to set it > to allow password-less su in the pam configuration, but everyone who > does that is crazy anyway). The original complaint was that when using makepkg -sic, the sudo password is cached after dependency installation and malicious sudo commands might be executed during build() as the password is cached. My opinion on this is that we should not encourage people to use sudo, Aaron suggested to move it here for further discussion. What do you think?

5 4

[pacman-dev] [PATCH] Quote values in the arch array in example PKGBUILD
by Allan McRae 09 Jul '09

09 Jul '09

Signed-off-by: Allan McRae <allan(a)archlinux.org> --- doc/PKGBUILD-example.txt | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/doc/PKGBUILD-example.txt b/doc/PKGBUILD-example.txt index 0477cb1..7245228 100644 --- a/doc/PKGBUILD-example.txt +++ b/doc/PKGBUILD-example.txt @@ -4,7 +4,7 @@ pkgname=patch pkgver=2.5.4 pkgrel=3 pkgdesc="A utility to apply patch files to original sources" -arch=(i686 x86_64) +arch=('i686' 'x86_64') url="http://www.gnu.org/software/patch/patch.html" license=('GPL') groups=('base-devel') -- 1.6.3.3

2 3

[pacman-dev] [PATCH] New sync070.py pactest
by Nagy Gabor 09 Jul '09

09 Jul '09

From cfcaa50b83d6ce09a026e8275f19ce0665365e31 Mon Sep 17 00:00:00 2001 From: Nagy Gabor <ngaba(a)bibl.u-szeged.hu> Date: Wed, 2 Jul 2008 17:04:29 +0200 Subject: [PATCH] New sync070.py pactest This pactest tests the cooperation between front-end and back-end in case of "-S provision" operation. Signed-off-by: Nagy Gabor <ngaba(a)bibl.u-szeged.hu> --- pactest/tests/sync070.py | 15 +++++++++++++++ 1 files changed, 15 insertions(+), 0 deletions(-) create mode 100644 pactest/tests/sync070.py diff --git a/pactest/tests/sync070.py b/pactest/tests/sync070.py new file mode 100644 index 0000000..2177ea7 --- /dev/null +++ b/pactest/tests/sync070.py @@ -0,0 +1,15 @@ +self.description = "Advanced -S provision test" + +sp1 = pmpkg("pkg", "1.0-1") +self.addpkg2db("sync2", sp1) + +sp2 = pmpkg("pkg", "2.0-1") +sp2.provides = [ "provision" ] +sp2.conflicts = [ "pkg1=1.0-1" ] +self.addpkg2db("sync1", sp2) + +self.args = "-S provision" + +self.addrule("PACMAN_RETCODE=0") +self.addrule("PKG_EXIST=pkg") +self.addrule("PKG_VERSION=pkg|2.0-1") -- 1.5.6.1

2 6

[pacman-dev] Idea: Merge -U and -S (half universal transaction)?
by Nagy Gabor 09 Jul '09

09 Jul '09

Hi! After killing pmsyncpkg_t, there is not much difference between -S and -U transactions. The only difference is that trans->packages come from pkgcache (-S) or they are loaded from file (-U). And of course, with -S we have an extra step, we have to actually download the packages. However, -U is much more "stupid" than -S atm. Now the removes field is attached to pmpkg_t, so we could implement FS#3492 without pain, the conflict resolving part from sync.c can be reused without any modification*. Or if we allow "mixed" trans->packages list (pkg->origin can indicate that we have a file[-U] or repo[-S] package), even the implementaion of FS#5798 should be also straightforward. The only difference between PKG_FROM_CACHE and PKG_FROM_FILE packages, that PKG_FROM_CACHE needs to be downloaded. Then -U would become a sync transaction (internally), and add_commit would be a helper function only. *: I started to work on the implementation of mixed target list, and I realised that the most annoying "difference" is that PKG_FROM_CACHE packages are not duplicated, so they are mustn't be freed (the new _alpm_pkg_free_trans should be used), but PKG_FROM_FILE packages must be freed. How much memory can we spare by not duplicating sync packages (not calling _alpm_pkg_dup when adding them to transaction target)? The whole base repo is <0.5 MB atm. Does this hack "worth"? With the old behaviour, implementing this idea (and so FS#3492 and FS#5798) would be really nice. With the new behaviour it would not. (And I don't really like the need for _alpm_pkg_free_trans neither.) Bye

3 3