- Pacman-dev - lists.archlinux.org

Future of GITFLAGS
by Allan McRae 01 May '24

01 May '24

Hi all, Posting here as I want some opinions. With pacman 6.1, we introduced the GITFLAGS variable that controls how makepkg clones a git repo. To quote Douglas Adams: "This has made a lot of people very angry and been widely regarded as a bad move" Maybe that is just my opinion! Essentially all git source features (i.e. build refs) supported by makepkg do not work using popular things like GITFLAGS="--mirror --filter=tree:0" or GITFLAGS="--depth=1". So no building from branches, or specific commits, or.... This has resulted in bug reports and increasingly complicated suggestions for "fixes". We can get around a few issues using a worktree instead of a clone for making the copy of the repo in $srcdir. This actually worth doing anyway, as it will also help with LFS retrieval. However, properly supporting all options that could be passed to GITFLAGS appears to be a never-ending / impossible task. It also means we can not assume our checkout is bare, which has already had implications for other fixes we are working on. I am proposing two possible solutions: 1) Document that any use of GITFLAGS that breaks makepkg features is not our problem. 2) Remove GITFLAGS. Note that people wanting specific GITFLAGS can readily overwrite the relevant function in libmakepkg, so #2 is really not the end of the world... I'm seeking options on which option to take. Or is there a third option? Option #2 would bring me joy, but I'd accept #1 if that is the prevailing opinion. Cheers, Allan

2 1

[Git][pacman/pacman][master] makepkg: fix git checksumming depends on user config
by Allan McRae (＠allan) 22 Apr '24

22 Apr '24

Allan McRae pushed to branch master at Pacman / Pacman Commits: 8e30cd4e by lilydjwg at 2024-04-22T04:48:19+00:00 makepkg: fix git checksumming depends on user config - - - - - 1 changed file: - scripts/libmakepkg/source/git.sh.in View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/8e30cd4e38b15cb20f0ec89… -- This project does not include diff previews in email notifications. View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/8e30cd4e38b15cb20f0ec89… You're receiving this email because of your account on gitlab.archlinux.org.

1 0

[Git][pacman/pacman][master] repo-add: handle lack of newline at end of .PKGINFO
by Allan McRae (＠allan) 22 Apr '24

22 Apr '24

Allan McRae pushed to branch master at Pacman / Pacman Commits: 03d884d7 by Allan McRae at 2024-04-22T04:46:30+00:00 repo-add: handle lack of newline at end of .PKGINFO Work around the final line not being parsed in .PKGINFO if there was a lack of newline at the end of the file. This could occur due to utilising a tool other than makepkg to create packages. The missed line created a difference in the parsing of .PKGINFO between repo-add and pacman, causing packages to be seen as invalidwith pacman-6.1. Signed-off-by: Allan McRae <allan(a)archlinux.org> - - - - - 1 changed file: - scripts/repo-add.sh.in View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/03d884d7ff43a474c1670db… -- This project does not include diff previews in email notifications. View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/03d884d7ff43a474c1670db… You're receiving this email because of your account on gitlab.archlinux.org.

1 0

[Git][pacman/pacman][master] libmakepkg: do not unset CHOST with !buildflags
by Allan McRae (＠allan) 22 Apr '24

22 Apr '24

Allan McRae pushed to branch master at Pacman / Pacman Commits: 7dcf9a2b by Allan McRae at 2024-04-20T11:37:54+10:00 libmakepkg: do not unset CHOST with !buildflags Also ensure CHOST and MAKEFLAGS are exported. Signed-off-by: Allan McRae <allan(a)archlinux.org> - - - - - 1 changed file: - scripts/libmakepkg/buildenv.sh.in View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/7dcf9a2b49226af8fcb4320… -- This project does not include diff previews in email notifications. View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/7dcf9a2b49226af8fcb4320… You're receiving this email because of your account on gitlab.archlinux.org.

1 0

[Git][pacman/pacman][master] _alpm_archive_fgets(): bail early if reached end of block
by Allan McRae (＠allan) 08 Apr '24

08 Apr '24

Allan McRae pushed to branch master at Pacman / Pacman Commits: 4dc21b96 by Allan McRae at 2024-04-08T10:34:10+00:00 _alpm_archive_fgets(): bail early if reached end of block Bailing early when there are 0 blocks remaining means that we do not call memchr on a NULL string (although with a 0 size parameter). Fixes issues reported using -fsanitise=address,undefined Signed-off-by: Allan McRae <allan(a)archlinux.org> - - - - - 1 changed file: - lib/libalpm/util.c View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/4dc21b965b891042edc951d… -- View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/4dc21b965b891042edc951d… You're receiving this email because of your account on gitlab.archlinux.org.

1 0

[Git][pacman/pacman][master] Add guidelines for managing release branches
by Allan McRae (＠allan) 07 Apr '24

07 Apr '24

Allan McRae pushed to branch master at Pacman / Pacman Commits: 936eff63 by Allan McRae at 2024-04-05T12:02:40+10:00 Add guidelines for managing release branches Signed-off-by: Allan McRae <allan(a)archlinux.org> - - - - - 1 changed file: - RELEASE View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/936eff63bf814ffb95139c7… -- View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/936eff63bf814ffb95139c7… You're receiving this email because of your account on gitlab.archlinux.org.

1 0

[Git][pacman/pacman][master] unlink_file: restore trailing slash on directory before checking mountpoint
by Allan McRae (＠allan) 05 Apr '24

05 Apr '24

Allan McRae pushed to branch master at Pacman / Pacman Commits: f86c15e7 by Allan McRae at 2024-04-05T00:51:13+00:00 unlink_file: restore trailing slash on directory before checking mountpoint The dir_is_mountpoint() function has the explicit requirement that the trailing slash of the directory is present. We strip the trailing slash in unlink_file() to handle directories replaced with symlinks, but that then affects the dir_is_mountpoint() check. Add the trailing slash when we have established we are dealing with a directory. Note this may fail in the case of a file managed by pacmane with name length of PATH_MAX that has been replaced by a directory on the file system. Bail on this unlikely scenario. In addtion, be less fancy with adjusting length of the file char array. Signed-off-by: Allan McRae <allan(a)archlinux.org> - - - - - 1 changed file: - lib/libalpm/remove.c View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/f86c15e7804311df6469e02… -- View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/f86c15e7804311df6469e02… You're receiving this email because of your account on gitlab.archlinux.org.

1 0

[Git][pacman/pacman][master] pacman-key: fix permission checks for non-root operations
by Allan McRae (＠allan) 05 Apr '24

05 Apr '24

Allan McRae pushed to branch master at Pacman / Pacman Commits: 49ebd856 by Allan McRae at 2024-04-05T00:47:45+00:00 pacman-key: fix permission checks for non-root operations Removing lock-never from the default gpg.conf file exposed a couple of bugs in the permission checks in pacman-key. Signed-off-by: Allan McRae <allan(a)archlinux.org> - - - - - 1 changed file: - scripts/pacman-key.sh.in View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/49ebd856ec09b2a7d87d36d… -- View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/49ebd856ec09b2a7d87d36d… You're receiving this email because of your account on gitlab.archlinux.org.

1 0

[Git][pacman/pacman][master] libmakepkg: remove MAKEFLAGS from buildenv_vars
by Allan McRae (＠allan) 05 Apr '24

05 Apr '24

Allan McRae pushed to branch master at Pacman / Pacman Commits: 027ecbc7 by Allan McRae at 2024-04-05T00:43:57+00:00 libmakepkg: remove MAKEFLAGS from buildenv_vars MAKEFLAGS should not be cleared by options=(!buildenv). Regression introduced in commit 09e82f01ea824f9203b0ed7238d98b612669b1a9 Signed-off-by: Allan McRae <allan(a)archlinux.org> - - - - - 1 changed file: - scripts/libmakepkg/buildenv.sh.in View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/027ecbc7b8503b58eb055ad… -- View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/027ecbc7b8503b58eb055ad… You're receiving this email because of your account on gitlab.archlinux.org.

1 0

[Git][pacman/pacman][master] Fix leak in total progress bar
by Allan McRae (＠allan) 05 Apr '24

05 Apr '24

Allan McRae pushed to branch master at Pacman / Pacman Commits: f763ff77 by Allan McRae at 2024-04-05T00:39:29+00:00 Fix leak in total progress bar Signed-off-by: Allan McRae <allan(a)archlinux.org> - - - - - 1 changed file: - src/pacman/callback.c View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/f763ff774a5c3f7db89b010… -- View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/f763ff774a5c3f7db89b010… You're receiving this email because of your account on gitlab.archlinux.org.

1 0