April 2011 - Aur-dev - lists.archlinux.org

[aur-dev] some patches to gendummydata
by elij 06 Apr '11

06 Apr '11

Some patches for gendummydata script. - remove need for sql connection. this allows someone to run the script on a dev box with no sql connection (for example) and then ship the output sql wherever needed. - remove need to have category names. only the actual numbers are needed, and if you are using dummy data, you are likely using the base schema. even if that is not the case, as long as the base number of categories _at least_ are present, the dummy data is still 'fine' (eg. if more categories are added, then no dummy packages will just use those categories until the counter in the script is incremented) - use logging module - remove 'progress' logging output. the script doesn't run slow enough to warrant the extra noise - use spaces in the python script. spaces in python are _a damn good idea_

3 14

[aur-dev] Some optimization patches
by elij 04 Apr '11

04 Apr '11

Trying to send these patches one final time, using 'inline' at Aaron's suggestion. Here goes. --- My apologies for splitting these changes into so many patches, but apparently the Arch mailman instance will not let anything larger than 40k though (and I got feedback that there is something amiss regarding the mailman setup -- this is here nor there though). These patches are mostly optimizations for content delivery. - merge css into fewer files to reduce number of files. this makes for faster end user delivery as there are fewer http requests (fewer tcp connections, whether the response is 200/ok or 304/not-modified). - created minimized versions of css. this reduced css size by 3.3K (24%) the originals are retained for ease of editing and reference - split out ie6 css into a separate file, and use 'conditional stylesheet inclusion' so that only ie6 fetches that stylesheet. - optimize logo png file -- this was a 22% (1K)

1 7

[aur-dev] Some optimzation patches
by elij 04 Apr '11

04 Apr '11

Here are some patches that optimze a few things: - combine css for faster delivery (fewer tcp connections) - minimize css (faster delivery, bandwidth reduction) note: originals are retained for later editing and re-minimization - optimize png file - specific image dimensions in a few places where they were missing - move ie specific style (archnav bg image) to a separate stylesheet and include conditionally

2 4

[aur-dev] Some optimization patches
by elij 04 Apr '11

04 Apr '11

My apologies for splitting these changes into so many patches, but apparently the Arch mailman instance will not let anything larger than 40k though (and I got feedback that there is something amiss regarding the mailman setup -- this is here nor there though). These patches are mostly optimizations for content delivery. - merge css into fewer files to reduce number of files. this makes for faster end user delivery as there are fewer http requests (fewer tcp connections, whether the response is 200/ok or 304/not-modified). - created minimized versions of css. this reduced css size by 3.3K (24%) the originals are retained for ease of editing and reference - split out ie6 css into a separate file, and use 'conditional stylesheet inclusion' so that only ie6 fetches that stylesheet. - optimize logo png file -- this was a 22% (1K)

1 8

[aur-dev] [PATCH 1/5] Submission process code refactor
by Dan McGee 04 Apr '11

04 Apr '11

We had a ton of duplicate code shared between the insert and update cases. Do a refactor so we can pull this stuff out below the if/else block and only need it there once, saving some headaches. Signed-off-by: Dan McGee <dan(a)archlinux.org> --- web/html/pkgsubmit.php | 96 +++++++++++++++++------------------------------ 1 files changed, 35 insertions(+), 61 deletions(-) diff --git a/web/html/pkgsubmit.php b/web/html/pkgsubmit.php index 05cc866..131bf37 100644 --- a/web/html/pkgsubmit.php +++ b/web/html/pkgsubmit.php @@ -303,11 +303,12 @@ if ($_COOKIE["AURSID"]): # This is an overwrite of an existing package, the database ID # needs to be preserved so that any votes are retained. However, # PackageDepends and PackageSources can be purged. + $packageID = $pdata["ID"]; # Flush out old data that will be replaced with new data - $q = "DELETE FROM PackageDepends WHERE PackageID = " . $pdata["ID"]; + $q = "DELETE FROM PackageDepends WHERE PackageID = " . $packageID; db_query($q, $dbh); - $q = "DELETE FROM PackageSources WHERE PackageID = " . $pdata["ID"]; + $q = "DELETE FROM PackageSources WHERE PackageID = " . $packageID; db_query($q, $dbh); # If the package was a dummy, undummy it @@ -315,7 +316,7 @@ if ($_COOKIE["AURSID"]): $q = sprintf( "UPDATE Packages SET DummyPkg = 0, SubmitterUID = %d, MaintainerUID = %d, SubmittedTS = UNIX_TIMESTAMP() WHERE ID = %d", $uid, $uid, - $pdata["ID"]); + $packageID); db_query($q, $dbh); } @@ -324,7 +325,7 @@ if ($_COOKIE["AURSID"]): if ($_POST['category'] > 1) { $q = sprintf( "UPDATE Packages SET CategoryID = %d WHERE ID = %d", mysql_real_escape_string($_REQUEST['category']), - $pdata["ID"]); + $packageID); db_query($q, $dbh); } @@ -338,41 +339,10 @@ if ($_COOKIE["AURSID"]): mysql_real_escape_string($new_pkgbuild['pkgdesc']), mysql_real_escape_string($new_pkgbuild['url']), uid_from_sid($_COOKIE["AURSID"]), - $pdata["ID"]); + $packageID); db_query($q, $dbh); - # Update package depends - $depends = explode(" ", $new_pkgbuild['depends']); - foreach ($depends as $dep) { - $q = "INSERT INTO PackageDepends (PackageID, DepPkgID, DepCondition) VALUES ("; - $deppkgname = preg_replace("/(<|<=|=|>=|>).*/", "", $dep); - $depcondition = str_replace($deppkgname, "", $dep); - - if ($deppkgname == "#") { - break; - } - - $deppkgid = create_dummy($deppkgname, $_COOKIE['AURSID']); - $q .= $pdata["ID"] . ", " . $deppkgid . ", '" . mysql_real_escape_string($depcondition) . "')"; - - db_query($q, $dbh); - } - - # Insert sources - $sources = explode(" ", $new_pkgbuild['source']); - foreach ($sources as $src) { - if ($src != "" ) { - $q = "INSERT INTO PackageSources (PackageID, Source) VALUES ("; - $q .= $pdata["ID"] . ", '" . mysql_real_escape_string($src) . "')"; - db_query($q, $dbh); - } - } - - if ($pdata["MaintainerUID"] === NULL) pkg_notify(account_from_sid($_COOKIE["AURSID"]), array($pdata["ID"])); - - header('Location: packages.php?ID=' . $pdata['ID']); - } else { $uid = uid_from_sid($_COOKIE["AURSID"]); @@ -388,41 +358,45 @@ if ($_COOKIE["AURSID"]): $uid, $uid); - $result = db_query($q, $dbh); + db_query($q, $dbh); $packageID = mysql_insert_id($dbh); - # Update package depends - $depends = explode(" ", $new_pkgbuild['depends']); - foreach ($depends as $dep) { - $q = "INSERT INTO PackageDepends (PackageID, DepPkgID, DepCondition) VALUES ("; - $deppkgname = preg_replace("/(<|<=|=|>=|>).*/", "", $dep); - $depcondition = str_replace($deppkgname, "", $dep); - - if ($deppkgname == "#") { - break; - } + } - $deppkgid = create_dummy($deppkgname, $_COOKIE['AURSID']); - $q .= $packageID . ", " . $deppkgid . ", '" . mysql_real_escape_string($depcondition) . "')"; + # Update package depends + $depends = explode(" ", $new_pkgbuild['depends']); + foreach ($depends as $dep) { + $q = "INSERT INTO PackageDepends (PackageID, DepPkgID, DepCondition) VALUES ("; + $deppkgname = preg_replace("/(<|<=|=|>=|>).*/", "", $dep); + $depcondition = str_replace($deppkgname, "", $dep); - db_query($q, $dbh); + if ($deppkgname == "#") { + break; } - # Insert sources - $sources = explode(" ", $new_pkgbuild['source']); - foreach ($sources as $src) { - if ($src != "" ) { - $q = "INSERT INTO PackageSources (PackageID, Source) VALUES ("; - $q .= $packageID . ", '" . mysql_real_escape_string($src) . "')"; - db_query($q, $dbh); - } - } + $deppkgid = create_dummy($deppkgname, $_COOKIE['AURSID']); + $q .= $packageID . ", " . $deppkgid . ", '" . mysql_real_escape_string($depcondition) . "')"; - pkg_notify(account_from_sid($_COOKIE["AURSID"]), array($packageID)); + db_query($q, $dbh); + } - header('Location: packages.php?ID=' . $packageID); + # Insert sources + $sources = explode(" ", $new_pkgbuild['source']); + foreach ($sources as $src) { + if ($src != "" ) { + $q = "INSERT INTO PackageSources (PackageID, Source) VALUES ("; + $q .= $packageID . ", '" . mysql_real_escape_string($src) . "')"; + db_query($q, $dbh); + } + } + # If we just created this package, or it was an orphan and we + # auto-adopted, add submitting user to the notification list. + if (!$pdata || $pdata["MaintainerUID"] === NULL) { + pkg_notify(account_from_sid($_COOKIE["AURSID"]), array($packageID)); } + + header('Location: packages.php?ID=' . $packageID); } chdir($cwd); -- 1.7.4.2

4 8

[aur-dev] [PATCH 3/3] specify dimensions for images
by elij 03 Apr '11

03 Apr '11

- some html renderers work faster/better if you specify image dimensions to avoid reflow/repaits --- web/template/stats/updates_table.php | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)

1 0

[aur-dev] [PATCH 2/3] optimize png file
by elij 03 Apr '11

03 Apr '11

- savings of about 1K (22%) --- web/html/css/archnavbar/archlogo.png | Bin 4192 -> 3258 bytes 1 files changed, 0 insertions(+), 0 deletions(-)

1 0