January 2013 - Aur-dev - lists.archlinux.org

[aur-dev] Missing translations for AUR 2.0.1
by rafael ff1 30 Jan '13

30 Jan '13

Hi all. In the transition 2.0.0 to 2.0.1, a few non-translated strings in AUR webui were found and fixed in source code, however the PO files were not updated. In consequence, the translators didn't made the webui 100% translated (e.g. "Package Search" in pt_BR in main screen is in english). While this is not a big issue, it is always nice to have the interface all translated. Having that said, *if there is no plan for soon releasing next version*, please consider uploading translations to Transifex, giving a time frame for translation and releasing the translatings. Thanks in advance, Rafael Ferreira

3 2

[aur-dev] [PATCH 4/4] acctfuncs.inc.php: Change wording of account editing message
by canyonknight 22 Jan '13

22 Jan '13

An error message is printed when the number of affected rows is 0 for an edited account. A count of 0 doesn't imply an error, only that no changes were made in the database. Signed-off-by: canyonknight <canyonknight(a)gmail.com> --- web/lib/acctfuncs.inc.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/lib/acctfuncs.inc.php b/web/lib/acctfuncs.inc.php index b2bf03b..96fd9f6 100644 --- a/web/lib/acctfuncs.inc.php +++ b/web/lib/acctfuncs.inc.php @@ -248,7 +248,7 @@ function process_account_form($UTYPE,$TYPE,$A,$U="",$T="",$S="",$E="", $q.= " WHERE ID = ".intval($UID); $result = $dbh->exec($q); if (!$result) { - print __("Error trying to modify account, %s%s%s.", + print __("No changes were made to the account, %s%s%s.", "<strong>", htmlspecialchars($U,ENT_QUOTES), "</strong>"); } else { print __("The account, %s%s%s, has been successfully modified.", -- 1.8.1.1

1 0

[aur-dev] [PATCH] Clear a user's active sessions following account suspension
by canyonknight 22 Jan '13

22 Jan '13

A suspended user can stay in active sessions. Introduce new function delete_user_sessions to remove all open sessions for a specific user. Allows suspensions to take effect immediately. Signed-off-by: canyonknight <canyonknight(a)gmail.com> --- web/lib/acctfuncs.inc.php | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/web/lib/acctfuncs.inc.php b/web/lib/acctfuncs.inc.php index cdf4af6..b2bf03b 100644 --- a/web/lib/acctfuncs.inc.php +++ b/web/lib/acctfuncs.inc.php @@ -229,6 +229,8 @@ function process_account_form($UTYPE,$TYPE,$A,$U="",$T="",$S="",$E="", $q.= ", AccountTypeID = ".intval($T); } if ($S) { + /* Ensure suspended users can't keep an active session */ + delete_user_sessions($UID, $dbh); $q.= ", Suspended = 1"; } else { $q.= ", Suspended = 0"; @@ -797,6 +799,23 @@ function delete_session_id($sid, $dbh=NULL) { } /** + * Remove all sessions belonging to a particular user + * + * @param int $uid ID of user to remove all sessions for + * @param \PDO $dbh An already established database connection + * + * @return void + */ +function delete_user_sessions($uid, $dbh=NULL) { + if (!$dbh) { + $dbh = db_connect(); + } + + $q = "DELETE FROM Sessions WHERE UsersID = " . intval($uid); + $dbh->exec($q); +} + +/** * Remove sessions from the database that have exceed the timeout * * @global int $LOGIN_TIMEOUT Time until session expires -- 1.8.1.1

1 0

[aur-dev] [PATCH] Replace permission check code with can_edit_account()
by canyonknight 22 Jan '13

22 Jan '13

Signed-off-by: canyonknight <canyonknight(a)gmail.com> --- web/html/account.php | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/web/html/account.php b/web/html/account.php index cccdd76..2133734 100644 --- a/web/html/account.php +++ b/web/html/account.php @@ -48,11 +48,8 @@ if (isset($_COOKIE["AURSID"])) { if (empty($row)) { print __("Could not retrieve information for the specified user."); } else { - # double check to make sure logged in user can edit this account - # - if ($atype == "Developer" || ($atype == "Trusted User" && - $row["AccountType"] != "Developer") || - ($row["ID"] == uid_from_sid($_COOKIE["AURSID"]))) { + /* Verify user has permission to edit the account */ + if (can_edit_account($atype, $row, uid_from_sid($_COOKIE["AURSID"]))) { display_account_form($atype, "UpdateAccount", $row["Username"], $row["AccountType"], $row["Suspended"], $row["Email"], "", "", $row["RealName"], $row["LangPreference"], -- 1.8.1.1

1 0

[aur-dev] [PATCH] acctfuncs.inc.php: Change return type of valid_username function
by canyonknight 22 Jan '13

22 Jan '13

The function is only determining whether a username is valid, so it makes more sense to simply return a boolean value. Signed-off-by: canyonknight <canyonknight(a)gmail.com> --- web/lib/acctfuncs.inc.php | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/web/lib/acctfuncs.inc.php b/web/lib/acctfuncs.inc.php index a41659e..cdf4af6 100644 --- a/web/lib/acctfuncs.inc.php +++ b/web/lib/acctfuncs.inc.php @@ -480,12 +480,12 @@ function try_login($dbh=NULL) { * * The username must be longer or equal to USERNAME_MIN_LEN. It must be shorter * or equal to USERNAME_MAX_LEN. It must start and end with either a letter or - * a number. It can contain one period, hypen, or underscore. Returns username - * if it meets all of those rules. + * a number. It can contain one period, hypen, or underscore. Returns boolean + * of whether name is valid. * * @param string $user Username to validate * - * @return string|void Return username if it meets criteria, otherwise void + * @return bool True if username meets criteria, otherwise false */ function valid_username($user) { if (!empty($user)) { @@ -500,13 +500,12 @@ function valid_username($user) { # contain only letters and numbers, # and at most has one dash, period, or underscore if ( preg_match("/^[a-z0-9]+[.\-_]?[a-z0-9]+$/", $user) ) { - #All is good return the username - return $user; + return true; } } } - return; + return false; } /** -- 1.8.1.1

1 0

[aur-dev] [PATCH] aur.inc.php: Fix PHP undefined index notice for AURSID
by canyonknight 22 Jan '13

22 Jan '13

Occurs in the rare situation where a logged out user tries to POST a CSRF token. Signed-off-by: canyonknight <canyonknight(a)gmail.com> --- web/lib/aur.inc.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/lib/aur.inc.php b/web/lib/aur.inc.php index 387d81d..e02c835 100644 --- a/web/lib/aur.inc.php +++ b/web/lib/aur.inc.php @@ -94,7 +94,7 @@ function check_sid($dbh=NULL) { * @return bool True if the CSRF token is the same as the cookie SID, otherwise false */ function check_token() { - if (isset($_POST['token'])) { + if (isset($_POST['token']) && isset($_COOKIE['AURSID'])) { return ($_POST['token'] == $_COOKIE['AURSID']); } else { return false; -- 1.8.1.1

1 0

[aur-dev] [PATCH] pkg_details.php: Add missing translatable string
by canyonknight 22 Jan '13

22 Jan '13

Signed-off-by: canyonknight <canyonknight(a)gmail.com> --- web/template/pkg_details.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/web/template/pkg_details.php b/web/template/pkg_details.php index b5d8a9f..0973448 100644 --- a/web/template/pkg_details.php +++ b/web/template/pkg_details.php @@ -137,7 +137,7 @@ if ($row["SubmitterUID"]): <td><?= htmlspecialchars($submitter) ?></td> <?php endif; ?> <?php else: ?> - <td>None</td> + <td><?= __('None') ?></td> <?php endif; ?> </tr> <tr> @@ -155,7 +155,7 @@ if ($row["MaintainerUID"]): <td><?= htmlspecialchars($maintainer) ?></td> <?php endif; ?> <?php else: ?> - <td>None</td> + <td><?= __('None') ?></td> <?php endif; ?> </tr> <tr> -- 1.8.1.1

1 0

[aur-dev] How can I Upload a new vesion of the vidyo package to AUR?
by Fernando Monticelli 17 Jan '13

17 Jan '13

Hi all, Current vidyo (a CERN video conferencing tool) package in AUR doesn' t work for me. But I found a hack here (https://bugzilla.mozilla.org/show_bug.cgi?id=701083#c7) which makes vidyo believes is running under ubuntu. That actually works. It s just the package in that hack is an old version of Vidyo. So I made up a new PKGBUILD for the latest version of vidyo. This PKGBUILD is a modification of the one currently in AUR (https://aur.archlinux.org/packages/vidyo/) plus the hack I found. In any case, I can' t upload it to AUR because vidyo belongs to another maintanier. How can I proceed? Should I ask the other maintainer to modify his PKGBUILD? Thanks a lot! Cheers, Fernando

3 3

[aur-dev] [PATCH] stats.inc.php: Remove unnecessary account type lookup
by canyonknight 14 Jan '13

14 Jan '13

Signed-off-by: canyonknight <canyonknight(a)gmail.com> --- web/lib/stats.inc.php | 3 --- 1 file changed, 3 deletions(-) diff --git a/web/lib/stats.inc.php b/web/lib/stats.inc.php index 60973e9..cfae794 100644 --- a/web/lib/stats.inc.php +++ b/web/lib/stats.inc.php @@ -43,9 +43,6 @@ function user_table($userid, $dbh) { $flagged_outdated = db_cache_value($q, $dbh, 'user_flagged_outdated:' . $userid); - # If the user is a TU calculate the number of the packages - $atype = account_from_sid($_COOKIE["AURSID"]); - include('stats/user_table.php'); } -- 1.8.1

1 0

[aur-dev] [PATCH] user_table.php: Remove unused link parameter
by canyonknight 14 Jan '13

14 Jan '13

Signed-off-by: canyonknight <canyonknight(a)gmail.com> --- web/template/stats/user_table.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/template/stats/user_table.php b/web/template/stats/user_table.php index ba6751f..284d5b9 100644 --- a/web/template/stats/user_table.php +++ b/web/template/stats/user_table.php @@ -7,7 +7,7 @@ $username = username_from_sid($_COOKIE["AURSID"]); <table> <tr> <td> - <a href="<?= get_uri('/packages/'); ?>?SeB=m&L=2&K=<?= $username; ?>"> + <a href="<?= get_uri('/packages/'); ?>?SeB=m&K=<?= $username; ?>"> <?= __("Packages in unsupported"); ?></a> </td> <td><?= $maintainer_unsupported_count; ?></td> -- 1.8.1

1 0