- Aur-dev - lists.archlinux.org

[aur-dev] AUR2 Direction
by Sebastian 16 Feb '09

16 Feb '09

Hi guys, I've picked up AUR2 development once again, and made it work with Django 1.0+. I want to start working on binary package support, but I'm unsure as to how to go about it. The current AUR depends on background scripts which populate the database. I really don't like this idea. It's fine for them to exist, but AUR2 should not depend on them. I was thinking of writing a parser for binary packages[1] and using the same upload interface for binary packages as for PKGBUILD packages. Permissions to upload would obviously be restricted to specific groups. This generalization would also allow me to get get rid of some hard coded logic for the "unsupported" repository, and make AUR2 a generic pacman package/PKGBUILD web interface, allowing more than one binary/PKGBUILD repository. [1] http://www.github.com/sebnow/parched

3 2

[aur-dev] [PATCH] Fix: FS#13189, infinite variable replacement cycle
by Gergely Imreh 15 Feb '09

15 Feb '09

Hi, Bug report FS#13189 brought to light a situation when certain lines in the PKGBUILD would cause the pkgbuild.php end up in an infinite cycle. Example is a line such as: foo=$foo or as in the bug report: CXXFLAGS=$CXXFLAGS' -fpic' In the first case, e.g. $foo would be recognized as a call for replacement for "foo", and then replaced with "$foo", then checked again for values to replace.... you can guess how well it goes... This patch removes this situation by setting the variable value to empty (to ""), if it recognizes that there would be such a cycle. This behaviour is not exactly what bash would do, since e.g. if there are two lines in the PKGBUILD such as: foo=something foo=$foo then in bash in the end foo would have a proper value ("something"), while in our case it would be empty. In my opinion this is not a problem, since generally these kind of PKGBUILDs could be considered malformed..... The eval type parameter substitution is not changed at the moment, since even if does not give the same value as bash, it does not cause such cycle as the normal substitution. Cheers, Greg

3 7

[aur-dev] [PATCH] rpc: delay getting DB connection until absolutely necessary
by Dan McGee 15 Feb '09

15 Feb '09

Signed-off-by: Dan McGee <dan(a)archlinux.org> --- web/lib/aurjson.class.php | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/web/lib/aurjson.class.php b/web/lib/aurjson.class.php index 81c0831..425748d 100644 --- a/web/lib/aurjson.class.php +++ b/web/lib/aurjson.class.php @@ -33,8 +33,6 @@ class AurJSON { public function handle($http_data) { // set content type header to json header('content-type: application/json'); - // set up db connection. - $this->dbh = db_connect(); // handle error states if ( !isset($http_data['type']) || !isset($http_data['arg']) ) { @@ -43,6 +41,9 @@ class AurJSON { // do the routing if ( in_array($http_data['type'], $this->exposed_methods) ) { + // set up db connection. + $this->dbh = db_connect(); + // ugh. this works. I hate you php. $json = call_user_func_array(array(&$this,$http_data['type']), $http_data['arg']); @@ -103,7 +104,7 @@ class AurJSON { $search_data = array(); while ( $row = mysql_fetch_assoc($result) ) { array_push($search_data, $row); - } + } mysql_free_result($result); return $this->json_results('search', $search_data); -- 1.6.1.3

2 1

[aur-dev] Patch: Who voted on a Prosal
by Angel Velásquez 13 Feb '09

13 Feb '09

Hi, First of all I would like to discuss this patch. The idea of this patch is to know who voted on a proposal, not "not to know who voted for that", the vote should be secret. Why do I think this feature is necessary? Because it will help to determine who is voting on the SVP and who isn't, is every TU's job to vote on all SVP even though there is an abstain vote option for every TU that might feel unsecure about his vote. If this patch is considered a good feature, I propose to change the line if (mysql_num_rows($result) > 0) by something like if (mysql_num_rows($result) >= $n) and $n should be a variable returned by the query SELECT COUNT(*) .... which should return the total numbers of TUs.. Comments? -- Angel Velásquez angvp @ irc.freenode.net Linux Counter: #359909 Arch Linux Trusted User

3 3

[aur-dev] Roadmap for version 1.5.7
by Loui Chang 07 Feb '09

07 Feb '09

I've been fooling around on the bug tracker and put together a list of issues that should be addressed for the next release. http://bugs.archlinux.org/roadmap/proj2

1 0

[aur-dev] [PATCH] Change pagination style
by Callan Barrett 06 Feb '09

06 Feb '09

Looks different now, next and previous on their own sides and elips for both Signed-off-by: Callan Barrett <wizzomafizzo(a)gmail.com> --- web/html/css/arch.css | 7 ++++++ web/template/pkg_search_results.php | 40 ++++++++++++++++++++-------------- 2 files changed, 30 insertions(+), 17 deletions(-) diff --git a/web/html/css/arch.css b/web/html/css/arch.css index da670ee..80bbc92 100644 --- a/web/html/css/arch.css +++ b/web/html/css/arch.css @@ -451,3 +451,10 @@ textarea.vLargeTextField { text-decoration: none; } +#pages { margin: 5px; } +#pages .page_num { + border: 1px solid #ddd; + padding: 2px; + color: #0771a6; +} +#pages #page_sel { color: #555; } diff --git a/web/template/pkg_search_results.php b/web/template/pkg_search_results.php index 71b6a63..87bd02a 100644 --- a/web/template/pkg_search_results.php +++ b/web/template/pkg_search_results.php @@ -116,6 +116,19 @@ for ($i = 0; $row = mysql_fetch_assoc($result); $i++) { <?php print __("Showing results %s - %s of %s", $first, $last, $total) ?> + + <div id="pages"> + <?php + if ($_GET['O'] > 0): + $O = $_GET['O'] - $_GET['PP']; + + if ($_GET['O'] < $_GET['PP']) { + $O = 0; + } + ?> + <a href="packages.php?<?php print mkurl("O=$O") ?>"><?php echo '< ' . __('Previous') ?></a> + <?php endif; ?> + <?php if ($_GET['PP'] > 0) { $pages = ceil($total / $_GET['PP']); @@ -131,6 +144,8 @@ for ($i = 0; $row = mysql_fetch_assoc($result); $i++) { $morepages = $currentpage + 5; + print (($currentpage-5) > 1) ? '...' : ''; + # Display links for more search results. for ($i = ($currentpage - 5); $i <= $morepages && $i <= $pages; $i++) { if ($i < 1) { @@ -141,29 +156,20 @@ for ($i = 0; $row = mysql_fetch_assoc($result); $i++) { if ($i <> $currentpage) : ?> - <a href='packages.php?<?php print mkurl('O=' . ($pagestart))?>'><?php print "$i " ?></a> - <?php else : print "[$i] "; + <a href='packages.php?<?php print mkurl('O=' . ($pagestart))?>'><?php print "$i" ?></a> + <?php else : print ''.$i.' '; endif; } - # Indicate that there are more pages. - if ($pages > $morepages) { - echo "<a href=\"packages.php?" . mkurl('O=' . ($pagestart + $_GET['PP'])) . '">... </a>'; - } - - if ($_GET['O'] > 0): - $O = $_GET['O'] - $_GET['PP']; + print ($pages > $morepages) ? '...' : ''; - if ($_GET['O'] < $_GET['PP']) { - $O = 0; - } - ?> - <a href="packages.php?<?php print mkurl("O=$O") ?>"><?php echo __('Previous') ?></a> - <?php endif; ?> + ?> - <?php if ($total - $_GET['PP'] - $_GET['O'] > 0): ?> - <a href='packages.php?<?php print mkurl('O=' . ($_GET['O'] + $_GET['PP'])) ?>'><?php echo __('Next') ?></a> + <?php if ($total - $_GET['PP'] - $_GET['O'] > 0): ?> + <a href='packages.php?<?php print mkurl('O=' . ($_GET['O'] + $_GET['PP'])) ?>'><?php echo __('Next') . ' >' ?></a> <?php endif; ?> + + </div> </td> </tr> -- 1.6.0.4

2 1

[aur-dev] [PATCH] Change how pagination looks, add start and end buttons
by Callan Barrett 30 Jan '09

30 Jan '09

Got rid of the links in elipsis, added elips to start, changed next and prev buttons to > and <, added begin and end buttons Signed-off-by: Callan Barrett <wizzomafizzo(a)gmail.com> --- web/template/pkg_search_results.php | 39 ++++++++++++++++++++-------------- 1 files changed, 23 insertions(+), 16 deletions(-) diff --git a/web/template/pkg_search_results.php b/web/template/pkg_search_results.php index 71b6a63..ba0398c 100644 --- a/web/template/pkg_search_results.php +++ b/web/template/pkg_search_results.php @@ -116,6 +116,20 @@ for ($i = 0; $row = mysql_fetch_assoc($result); $i++) { <?php print __("Showing results %s - %s of %s", $first, $last, $total) ?> + + <?php if ($_GET['O'] != 0): ?><a href="packages.php?<?php print mkurl("O=0") ?>"><?php echo '<<' ?></a><?php endif; ?> + + <?php + if ($_GET['O'] > 0): + $O = $_GET['O'] - $_GET['PP']; + + if ($_GET['O'] < $_GET['PP']) { + $O = 0; + } + ?> + <a href="packages.php?<?php print mkurl("O=$O") ?>"><?php echo '<' ?></a> + <?php endif; ?> + <?php if ($_GET['PP'] > 0) { $pages = ceil($total / $_GET['PP']); @@ -131,6 +145,8 @@ for ($i = 0; $row = mysql_fetch_assoc($result); $i++) { $morepages = $currentpage + 5; + print (($currentpage-5) > 1) ? '...' : ''; + # Display links for more search results. for ($i = ($currentpage - 5); $i <= $morepages && $i <= $pages; $i++) { if ($i < 1) { @@ -141,30 +157,21 @@ for ($i = 0; $row = mysql_fetch_assoc($result); $i++) { if ($i <> $currentpage) : ?> - <a href='packages.php?<?php print mkurl('O=' . ($pagestart))?>'><?php print "$i " ?></a> + <a href='packages.php?<?php print mkurl('O=' . ($pagestart))?>'><?php print "$i" ?></a> <?php else : print "[$i] "; endif; } - # Indicate that there are more pages. - if ($pages > $morepages) { - echo "<a href=\"packages.php?" . mkurl('O=' . ($pagestart + $_GET['PP'])) . '">... </a>'; - } + print ($pages > $morepages) ? '...' : ''; - if ($_GET['O'] > 0): - $O = $_GET['O'] - $_GET['PP']; + ?> - if ($_GET['O'] < $_GET['PP']) { - $O = 0; - } - ?> - <a href="packages.php?<?php print mkurl("O=$O") ?>"><?php echo __('Previous') ?></a> - <?php endif; ?> - - <?php if ($total - $_GET['PP'] - $_GET['O'] > 0): ?> - <a href='packages.php?<?php print mkurl('O=' . ($_GET['O'] + $_GET['PP'])) ?>'><?php echo __('Next') ?></a> + <?php if ($total - $_GET['PP'] - $_GET['O'] > 0): ?> + <a href='packages.php?<?php print mkurl('O=' . ($_GET['O'] + $_GET['PP'])) ?>'><?php echo '>' ?></a> <?php endif; ?> + <?php if ($_GET['O'] < ($total-$_GET['PP'])): ?><a href="packages.php?<?php print mkurl("O=" . ($total-$_GET['PP'])) ?>"><?php echo '>>' ?></a><?php endif; ?> + </td> </tr> -- 1.6.0.4

1 0

[aur-dev] [PATCH] Update Italian translation and some improvements
by Giovanni Scafora 29 Jan '09

29 Jan '09

Hi guys, there is an update Italian translation and some improvements. Please, apply that as soon as possible. Thanks. -- Arch Linux Developer (voidnull) AUR & Pacman Italian Translations Microdia Developer http://www.archlinux.it

2 1

[aur-dev] AUR 1.5.6 Release
by Loui Chang 29 Jan '09

29 Jan '09

Hey everyone. I'd like to do a new release by weekend. So if there are any simple patches that can't wait until the next release here's the chance. Cheers!

2 2

[aur-dev] Bugs FS#2649,FS#12645: variable substitution revisited
by Gergely Imreh 28 Jan '09

28 Jan '09

Hi, Attached a patch to do a more complete variable substitution (not just pkgver and pkgname). Also, since it seems that some of official packages like to use "eval" for multiple-replacement, let's handle that in the same time. Checked functionality with these packages: core/kernel26 (arbitrary simple substitution), extra/firefox-i18n (eval). This patch should also close bugs FS#2649 and FS#12645. There are some quirky bash variable substitution types that this cannot handle but those usually fall into the "not well formed package" category. E.g. when there's a simple variable with quotes but with extra spaces inside the quotes, like _myvar=("something "). Then if there's, say, a substitution source=(from/$_myvar/code.tar.gz), bash will give: "from/something". If there's no extra space, it will give "from/something/code.tar.gz" For properly doing this on AUR, the way quotation marks are removed has to be changed. But probably we don't need to do that, until some uses this bash "feature" in an official package (since I recently learned, that the definition of the PKGBUILD format is just one line: "whatever makepkg can handle".) Cheers, Greg

2 1