- Aur-dev - lists.archlinux.org

Search by provides in RPC interface
by Guillaume Benoit 26 Oct '18

26 Oct '18

Hi, knowing you already added the possibility to search by depends, optdepends, makedepends and checkdepends in the AUR RPC interface, could you think about also add the possibility to search by provides: https://aur.archlinux.org/rpc/?v=5&type=search&by=provides&arg=<keyword> It could be very useful for AUR helpers to solve AUR dependencies this way. If you point me to the relevant code, I can try to provide a patch. Regards, Guillaume.

4 4

[PATCH] pkg_comments.php: Make comment timestamps link to the comment
by Vladimir Panteleev 23 Oct '18

23 Oct '18

As of today, there is no easy way to obtain a link to a specific comment on a package page. Many implementations of forums and comment systems today seem to follow a convention where a comment's timestamp is an unobtrusive link to the comment itself. Some examples are: - phpBB (e.g. bbs.archlinux.org) - GitHub - Disqus - Discourse This patch adopts this convention as well, by making the comment timestamp an unobtrusive link to the comment itself. --- web/html/css/aurweb.css | 2 +- web/template/pkg_comments.php | 12 +++++++----- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/web/html/css/aurweb.css b/web/html/css/aurweb.css index 593c9ae..d587dc6 100644 --- a/web/html/css/aurweb.css +++ b/web/html/css/aurweb.css @@ -122,7 +122,7 @@ top: 4px; } -.flagged a { +.flagged a, a.date { color: inherit; } diff --git a/web/template/pkg_comments.php b/web/template/pkg_comments.php index 3001a34..3bcf1a3 100644 --- a/web/template/pkg_comments.php +++ b/web/template/pkg_comments.php @@ -53,17 +53,19 @@ if ($comment_section == "package") { $pkgbase_name = $row["PackageBaseName"]; } + $anchor = (isset($pinned) ? "pinned-" : "comment-") . $row['ID']; $date_fmtd = date('Y-m-d H:i', $row['CommentTS']); + $date_link = '<a href="#' . $anchor . '" class="date">' . $date_fmtd . '</a>'; if ($comment_section == "package") { if ($row['UserName']) { $user_fmtd = html_format_username($row['UserName']); - $heading = __('%s commented on %s', $user_fmtd, $date_fmtd); + $heading = __('%s commented on %s', $user_fmtd, $date_link); } else { - $heading = __('Anonymous comment on %s', $date_fmtd); + $heading = __('Anonymous comment on %s', $date_link); } } elseif ($comment_section == "account") { $pkg_uri = '<a href=' . htmlspecialchars(get_pkg_uri($row['PackageBaseName']), ENT_QUOTES) . '>' . htmlspecialchars($row['PackageBaseName']) . '</a></td>'; - $heading = __('Commented on package %s on %s', $pkg_uri, $date_fmtd); + $heading = __('Commented on package %s on %s', $pkg_uri, $date_link); } $is_deleted = $row['DelTS']; @@ -97,7 +99,7 @@ if ($comment_section == "package") { $comment_classes .= " comment-deleted"; } ?> - <h4 id="<?= isset($pinned) ? "pinned-" : "comment-" ?><?= $row['ID'] ?>" class="<?= $comment_classes ?>"> + <h4 id="<?= $anchor ?>" class="<?= $comment_classes ?>"> <?= $heading ?> <?php if ($is_deleted && has_credential(CRED_COMMENT_UNDELETE)): ?> <form class="undelete-comment-form" method="post" action="<?= htmlspecialchars(get_pkgbase_uri($pkgbase_name), ENT_QUOTES); ?>"> @@ -152,7 +154,7 @@ if ($comment_section == "package") { </form> <?php endif; ?> </h4> - <div id="<?= isset($pinned) ? "pinned-" : "comment-" ?><?= $row['ID'] ?>-content" class="article-content<?php if ($is_deleted): ?> comment-deleted<?php endif; ?>"> + <div id="<?= $anchor ?>-content" class="article-content<?php if ($is_deleted): ?> comment-deleted<?php endif; ?>"> <div> <?php if (!empty($row['RenderedComment'])): ?> <?= $row['RenderedComment'] ?> -- 2.19.0

3 7

[PATCH v2] Add "Enable notifications" checkbox in "Add Comment" form
by Vladimir Panteleev 16 Oct '18

16 Oct '18

Currently, it is a little to easy to forget to enable notifications for a package after leaving a comment, thus never being notified of a reply. Even though the "Enable notifications" link is on the same page, it is not part of the flow for posting a new comment, and so, easy to miss. Most web forums and comment systems include a checkbox to enable notifications when posting for the first time in a thread. This patch implements this in aurweb, as well. --- Following Eli's comment, this version only allows enabling notifications - the checkbox is simply not displayed when they are already enabled. The corresponding server-side code is also simplified. web/html/css/aurweb.css | 5 +++++ web/html/pkgbase.php | 3 +++ web/template/pkg_comment_form.php | 6 ++++++ 3 files changed, 14 insertions(+) diff --git a/web/html/css/aurweb.css b/web/html/css/aurweb.css index 593c9ae..ef37bf5 100644 --- a/web/html/css/aurweb.css +++ b/web/html/css/aurweb.css @@ -104,6 +104,11 @@ top: 1px; } +.comment-enable-notifications { + display: inline-block; + margin-left: 1em; +} + .rss-icon, .delete-comment, .undelete-comment, .edit-comment, .pin-comment { -webkit-filter: grayscale(100%); filter: grayscale(100%); diff --git a/web/html/pkgbase.php b/web/html/pkgbase.php index 46ad77e..b716644 100644 --- a/web/html/pkgbase.php +++ b/web/html/pkgbase.php @@ -120,6 +120,9 @@ if (check_token()) { } elseif (current_action("do_AddComment")) { $uid = uid_from_sid($_COOKIE["AURSID"]); list($ret, $output) = pkgbase_add_comment($base_id, $uid, $_REQUEST['comment']); + if ($ret && isset($_REQUEST['enable_notifications'])) { + list($ret, $output) = pkgbase_notify(array($base_id)); + } $fragment = '#news'; } elseif (current_action("do_EditComment")) { list($ret, $output) = pkgbase_edit_comment($_REQUEST['comment']); diff --git a/web/template/pkg_comment_form.php b/web/template/pkg_comment_form.php index c450c4b..3feee8f 100644 --- a/web/template/pkg_comment_form.php +++ b/web/template/pkg_comment_form.php @@ -13,6 +13,12 @@ </p> <p> <input type="submit" value="<?= (isset($comment_id)) ? __("Save") : __("Add Comment") ?>" /> + <?php if (!isset($comment_id) && !pkgbase_user_notify($uid, $base_id)): ?> + <span class="comment-enable-notifications"> + <input type="checkbox" name="enable_notifications" id="id_enable_notifications" /> + <label for="id_enable_notifications"><?= __("Enable notifications") ?></label> + </span> + <?php endif; ?> </p> </fieldset> </form> -- 2.19.0

1 0

[PATCH] Add "Enable notifications" checkbox in "Add Comment" form
by Vladimir Panteleev 16 Oct '18

16 Oct '18

Currently, it is a little to easy to forget to enable notifications for a package after leaving a comment, thus never being notified of a reply. Even though the "Enable notifications" link is on the same page, it is not part of the flow for posting a new comment, and so, easy to miss. Most web forums and comment systems include a checkbox to enable notifications when posting for the first time in a thread. This patch implements this in aurweb, as well. --- web/html/css/aurweb.css | 5 +++++ web/html/pkgbase.php | 4 ++++ web/template/pkg_comment_form.php | 6 ++++++ 3 files changed, 15 insertions(+) diff --git a/web/html/css/aurweb.css b/web/html/css/aurweb.css index 593c9ae..ef37bf5 100644 --- a/web/html/css/aurweb.css +++ b/web/html/css/aurweb.css @@ -104,6 +104,11 @@ top: 1px; } +.comment-enable-notifications { + display: inline-block; + margin-left: 1em; +} + .rss-icon, .delete-comment, .undelete-comment, .edit-comment, .pin-comment { -webkit-filter: grayscale(100%); filter: grayscale(100%); diff --git a/web/html/pkgbase.php b/web/html/pkgbase.php index 46ad77e..0fec858 100644 --- a/web/html/pkgbase.php +++ b/web/html/pkgbase.php @@ -120,6 +120,10 @@ if (check_token()) { } elseif (current_action("do_AddComment")) { $uid = uid_from_sid($_COOKIE["AURSID"]); list($ret, $output) = pkgbase_add_comment($base_id, $uid, $_REQUEST['comment']); + $enable_notifications = isset($_REQUEST['enable_notifications']); + if ($ret && $enable_notifications != pkgbase_user_notify($uid, $base_id)) { + list($ret, $output) = pkgbase_notify(array($base_id), $enable_notifications); + } $fragment = '#news'; } elseif (current_action("do_EditComment")) { list($ret, $output) = pkgbase_edit_comment($_REQUEST['comment']); diff --git a/web/template/pkg_comment_form.php b/web/template/pkg_comment_form.php index c450c4b..41c0e1c 100644 --- a/web/template/pkg_comment_form.php +++ b/web/template/pkg_comment_form.php @@ -13,6 +13,12 @@ </p> <p> <input type="submit" value="<?= (isset($comment_id)) ? __("Save") : __("Add Comment") ?>" /> + <?php if (!isset($comment_id)): ?> + <span class="comment-enable-notifications"> + <input type="checkbox" name="enable_notifications" id="id_enable_notifications" <?= pkgbase_user_notify($uid, $base_id) ? "checked" : "" ?> /> + <label for="id_enable_notifications"><?= __("Enable notifications") ?></label> + </span> + <?php endif; ?> </p> </fieldset> </form> -- 2.19.0

2 1

[PATCH 0/2] Mention users' relationship to packages in comment notifications
by Vladimir Panteleev 16 Oct '18

16 Oct '18

Generally, it's useful to distinguish actionable vs. non-actionable notifications. When receiving a comment notification on a package a user maintains, it can be easy to miss it in a flood of comment notifications for packages the user merely follows. To this end, this patch series adds code to mention the user's relationship to the package when sending a comment notification email. Comments: - I'm not too happy about how intrusive the changes in the first refactoring comment are. Using a Python dictionary instead of introducing a new class would have allowed to avoid declaring the new classes, but that's not where the bulk of changes is. Much of the diff is cluttered from rewrapping to fit within 80 columns. Open to suggestions. - We could also do this for other notification types, but the comment notification is by far the most common one, so I've implemented this only for comment notifications for now. Should we decide otherwise, it is doable without introducing or updating translatable strings. - I'm not including .pot changes, as I've been told this is not being done simultaneously with changes that affect it; though, I've checked the diff after `make update-pot` and it looks okay to me. Vladimir Panteleev (2): notify.py: Encapsulate individual message recipient into a new class notify.py: Mention users' relationship to packages in comment notifications aurweb/scripts/notify.py | 216 ++++++++++++++++++++++++++------------- test/t2500-notify.sh | 150 +++++++++++++++++++++++++++ 2 files changed, 293 insertions(+), 73 deletions(-) -- 2.19.0

1 2

[aur-dev][PATCH] notify: add X-AUR-Reason header to allow conveniently filtering emails
by Eli Schwartz 05 Oct '18

05 Oct '18

Because filtering by matching the sender && regular expressions on the subject is awkward. Signed-off-by: Eli Schwartz <eschwartz(a)archlinux.org> --- In order to remain generic enough to allow the notify script to be imported from and used elsewhere, we cannot just use sys.argv[1] as the reason. aurweb/scripts/notify.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/aurweb/scripts/notify.py b/aurweb/scripts/notify.py index 44eec84..d975086 100755 --- a/aurweb/scripts/notify.py +++ b/aurweb/scripts/notify.py @@ -63,6 +63,9 @@ class Notification: sendmail = aurweb.config.get('notifications', 'sendmail') sender = aurweb.config.get('notifications', 'sender') reply_to = aurweb.config.get('notifications', 'reply-to') + reason = self.__class__.__name__ + if reason.endswith('Notification'): + reason = reason[:-len('Notification')] for recipient in self.get_recipients(): to, lang = recipient @@ -72,6 +75,7 @@ class Notification: msg['From'] = sender msg['Reply-to'] = reply_to msg['To'] = to + msg['X-AUR-Reason'] = reason for key, value in self.get_headers().items(): msg[key] = value -- 2.19.0

1 0

[aur-dev][PATCH] Fix notifications emails going to the right people
by Eli Schwartz 30 Aug '18

30 Aug '18

The notify script expects to see the userid followed by additional arguments like the pkgbase id, however, these were getting sent swapped around (presumably due to the similarity with the db connection which expects them in the other order when processing SQL statements). As a result, some random userid with the same id as the pkgbase, got sent a notification regarding some package with the same id as the real user's id. Signed-off-by: Eli Schwartz <eschwartz(a)archlinux.org> --- aurweb/git/serve.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/aurweb/git/serve.py b/aurweb/git/serve.py index 93ff34c..2882780 100755 --- a/aurweb/git/serve.py +++ b/aurweb/git/serve.py @@ -107,7 +107,7 @@ def pkgbase_adopt(pkgbase, user, privileged): [pkgbase_id, userid]) conn.commit() - subprocess.Popen((notify_cmd, 'adopt', str(pkgbase_id), str(userid))) + subprocess.Popen((notify_cmd, 'adopt', str(userid), str(pkgbase_id))) conn.close() @@ -165,8 +165,8 @@ def pkgbase_set_comaintainers(pkgbase, userlist, user, privileged): cur = conn.execute("INSERT INTO PackageComaintainers " + "(PackageBaseID, UsersID, Priority) " + "VALUES (?, ?, ?)", [pkgbase_id, userid, i]) - subprocess.Popen((notify_cmd, 'comaintainer-add', str(pkgbase_id), - str(userid))) + subprocess.Popen((notify_cmd, 'comaintainer-add', str(userid), + str(pkgbase_id))) else: cur = conn.execute("UPDATE PackageComaintainers " + "SET Priority = ? " + @@ -179,7 +179,7 @@ def pkgbase_set_comaintainers(pkgbase, userlist, user, privileged): "WHERE PackageBaseID = ? AND UsersID = ?", [pkgbase_id, userid]) subprocess.Popen((notify_cmd, 'comaintainer-remove', - str(pkgbase_id), str(userid))) + str(userid), str(pkgbase_id))) conn.commit() conn.close() @@ -266,7 +266,7 @@ def pkgbase_disown(pkgbase, user, privileged): if userid == 0: raise aurweb.exceptions.InvalidUserException(user) - subprocess.Popen((notify_cmd, 'disown', str(pkgbase_id), str(userid))) + subprocess.Popen((notify_cmd, 'disown', str(userid), str(pkgbase_id))) conn.close() -- 2.18.0

2 3

[PATCH 1/2] t2500: use unique identifiers
by Lukas Fleischer 12 Aug '18

12 Aug '18

Use disjoint sets of IDs for users, package bases, package comments and package requests to ensure the notification script expects the parameters in the same order we pass them. Signed-off-by: Lukas Fleischer <lfleischer(a)archlinux.org> --- test/t2500-notify.sh | 75 +++++++++++++++++++++++--------------------- 1 file changed, 39 insertions(+), 36 deletions(-) diff --git a/test/t2500-notify.sh b/test/t2500-notify.sh index b2bad1c..3f5a09c 100755 --- a/test/t2500-notify.sh +++ b/test/t2500-notify.sh @@ -6,18 +6,19 @@ test_description='notify tests' test_expect_success 'Test out-of-date notifications.' ' cat <<-EOD | sqlite3 aur.db && - INSERT INTO PackageBases (ID, Name, MaintainerUID, SubmittedTS, ModifiedTS, FlaggerComment) VALUES (1, "foobar", 1, 0, 0, "This is a test OOD comment."); - INSERT INTO PackageBases (ID, Name, MaintainerUID, SubmittedTS, ModifiedTS, FlaggerComment) VALUES (2, "foobar2", 2, 0, 0, ""); - INSERT INTO PackageBases (ID, Name, MaintainerUID, SubmittedTS, ModifiedTS, FlaggerComment) VALUES (3, "foobar3", NULL, 0, 0, ""); - INSERT INTO PackageBases (ID, Name, MaintainerUID, SubmittedTS, ModifiedTS, FlaggerComment) VALUES (4, "foobar4", 1, 0, 0, ""); - INSERT INTO PackageComaintainers (PackageBaseID, UsersID, Priority) VALUES (1, 2, 1); - INSERT INTO PackageComaintainers (PackageBaseID, UsersID, Priority) VALUES (1, 4, 2); - INSERT INTO PackageComaintainers (PackageBaseID, UsersID, Priority) VALUES (2, 3, 1); - INSERT INTO PackageComaintainers (PackageBaseID, UsersID, Priority) VALUES (2, 5, 2); - INSERT INTO PackageComaintainers (PackageBaseID, UsersID, Priority) VALUES (3, 4, 1); + /* Use package base IDs which can be distinguished from user IDs. */ + INSERT INTO PackageBases (ID, Name, MaintainerUID, SubmittedTS, ModifiedTS, FlaggerComment) VALUES (1001, "foobar", 1, 0, 0, "This is a test OOD comment."); + INSERT INTO PackageBases (ID, Name, MaintainerUID, SubmittedTS, ModifiedTS, FlaggerComment) VALUES (1002, "foobar2", 2, 0, 0, ""); + INSERT INTO PackageBases (ID, Name, MaintainerUID, SubmittedTS, ModifiedTS, FlaggerComment) VALUES (1003, "foobar3", NULL, 0, 0, ""); + INSERT INTO PackageBases (ID, Name, MaintainerUID, SubmittedTS, ModifiedTS, FlaggerComment) VALUES (1004, "foobar4", 1, 0, 0, ""); + INSERT INTO PackageComaintainers (PackageBaseID, UsersID, Priority) VALUES (1001, 2, 1); + INSERT INTO PackageComaintainers (PackageBaseID, UsersID, Priority) VALUES (1001, 4, 2); + INSERT INTO PackageComaintainers (PackageBaseID, UsersID, Priority) VALUES (1002, 3, 1); + INSERT INTO PackageComaintainers (PackageBaseID, UsersID, Priority) VALUES (1002, 5, 2); + INSERT INTO PackageComaintainers (PackageBaseID, UsersID, Priority) VALUES (1003, 4, 1); EOD >sendmail.out && - "$NOTIFY" flag 1 1 && + "$NOTIFY" flag 1 1001 && cat <<-EOD >expected && Subject: AUR Out-of-date Notification for foobar To: tu@localhost @@ -81,12 +82,13 @@ test_expect_success 'Test subject and body of welcome notifications.' ' test_expect_success 'Test subject and body of comment notifications.' ' cat <<-EOD | sqlite3 aur.db && - INSERT INTO PackageComments (ID, PackageBaseID, UsersID, Comments, RenderedComment) VALUES (1, 1, 1, "This is a test comment.", "This is a test comment."); - INSERT INTO PackageNotifications (PackageBaseID, UserID) VALUES (1, 2); + /* Use package comments IDs which can be distinguished from other IDs. */ + INSERT INTO PackageComments (ID, PackageBaseID, UsersID, Comments, RenderedComment) VALUES (2001, 1001, 1, "This is a test comment.", "This is a test comment."); + INSERT INTO PackageNotifications (PackageBaseID, UserID) VALUES (1001, 2); UPDATE Users SET CommentNotify = 1 WHERE ID = 2; EOD >sendmail.out && - "$NOTIFY" comment 1 1 1 && + "$NOTIFY" comment 1 1001 2001 && grep ^Subject: sendmail.out >actual && cat <<-EOD >expected && Subject: AUR Comment for foobar @@ -113,7 +115,7 @@ test_expect_success 'Test subject and body of update notifications.' ' UPDATE Users SET UpdateNotify = 1 WHERE ID = 2; EOD >sendmail.out && - "$NOTIFY" update 1 1 && + "$NOTIFY" update 1 1001 && grep ^Subject: sendmail.out >actual && cat <<-EOD >expected && Subject: AUR Package Update: foobar @@ -135,7 +137,7 @@ test_expect_success 'Test subject and body of update notifications.' ' test_expect_success 'Test subject and body of out-of-date notifications.' ' >sendmail.out && - "$NOTIFY" flag 1 1 && + "$NOTIFY" flag 1 1001 && grep ^Subject: sendmail.out >actual && cat <<-EOD >expected && Subject: AUR Out-of-date Notification for foobar @@ -156,7 +158,7 @@ test_expect_success 'Test subject and body of out-of-date notifications.' ' test_expect_success 'Test subject and body of adopt notifications.' ' >sendmail.out && - "$NOTIFY" adopt 1 1 && + "$NOTIFY" adopt 1 1001 && grep ^Subject: sendmail.out >actual && cat <<-EOD >expected && Subject: AUR Ownership Notification for foobar @@ -175,7 +177,7 @@ test_expect_success 'Test subject and body of adopt notifications.' ' test_expect_success 'Test subject and body of co-maintainer addition notifications.' ' >sendmail.out && - "$NOTIFY" comaintainer-add 1 1 && + "$NOTIFY" comaintainer-add 1 1001 && grep ^Subject: sendmail.out >actual && cat <<-EOD >expected && Subject: AUR Co-Maintainer Notification for foobar @@ -193,7 +195,7 @@ test_expect_success 'Test subject and body of co-maintainer addition notificatio test_expect_success 'Test subject and body of co-maintainer removal notifications.' ' >sendmail.out && - "$NOTIFY" comaintainer-remove 1 1 && + "$NOTIFY" comaintainer-remove 1 1001 && grep ^Subject: sendmail.out >actual && cat <<-EOD >expected && Subject: AUR Co-Maintainer Notification for foobar @@ -211,7 +213,7 @@ test_expect_success 'Test subject and body of co-maintainer removal notification test_expect_success 'Test subject and body of delete notifications.' ' >sendmail.out && - "$NOTIFY" delete 1 1 && + "$NOTIFY" delete 1 1001 && grep ^Subject: sendmail.out >actual && cat <<-EOD >expected && Subject: AUR Package deleted: foobar @@ -232,7 +234,7 @@ test_expect_success 'Test subject and body of delete notifications.' ' test_expect_success 'Test subject and body of merge notifications.' ' >sendmail.out && - "$NOTIFY" delete 1 1 2 && + "$NOTIFY" delete 1 1001 1002 && grep ^Subject: sendmail.out >actual && cat <<-EOD >expected && Subject: AUR Package deleted: foobar @@ -255,13 +257,14 @@ test_expect_success 'Test subject and body of merge notifications.' ' test_expect_success 'Test subject and body of request open notifications.' ' cat <<-EOD | sqlite3 aur.db && - INSERT INTO PackageRequests (ID, PackageBaseID, PackageBaseName, UsersID, ReqTypeID, Comments, ClosureComment) VALUES (1, 1, "foobar", 1, 1, "This is a request test comment.", ""); + /* Use package request IDs which can be distinguished from other IDs. */ + INSERT INTO PackageRequests (ID, PackageBaseID, PackageBaseName, UsersID, ReqTypeID, Comments, ClosureComment) VALUES (3001, 1001, "foobar", 1, 1, "This is a request test comment.", ""); EOD >sendmail.out && - "$NOTIFY" request-open 1 1 orphan 1 && + "$NOTIFY" request-open 1 3001 orphan 1001 && grep ^Subject: sendmail.out >actual && cat <<-EOD >expected && - Subject: [PRQ#1] Orphan Request for foobar + Subject: [PRQ#3001] Orphan Request for foobar EOD test_cmp actual expected && sed -n "/^\$/,\$p" sendmail.out | base64 -d >actual && @@ -279,10 +282,10 @@ test_expect_success 'Test subject and body of request open notifications.' ' test_expect_success 'Test subject and body of request open notifications for merge requests.' ' >sendmail.out && - "$NOTIFY" request-open 1 1 merge 1 foobar2 && + "$NOTIFY" request-open 1 3001 merge 1001 foobar2 && grep ^Subject: sendmail.out >actual && cat <<-EOD >expected && - Subject: [PRQ#1] Merge Request for foobar + Subject: [PRQ#3001] Merge Request for foobar EOD test_cmp actual expected && sed -n "/^\$/,\$p" sendmail.out | base64 -d >actual && @@ -301,16 +304,16 @@ test_expect_success 'Test subject and body of request open notifications for mer test_expect_success 'Test subject and body of request close notifications.' ' >sendmail.out && - "$NOTIFY" request-close 1 1 accepted && + "$NOTIFY" request-close 1 3001 accepted && grep ^Subject: sendmail.out >actual && cat <<-EOD >expected && - Subject: [PRQ#1] Deletion Request for foobar Accepted + Subject: [PRQ#3001] Deletion Request for foobar Accepted EOD test_cmp actual expected && sed -n "/^\$/,\$p" sendmail.out | base64 -d >actual && echo >>actual && cat <<-EOD >expected && - Request #1 has been accepted by user [1]. + Request #3001 has been accepted by user [1]. [1] https://aur.archlinux.org/account/user/ EOD @@ -319,36 +322,36 @@ test_expect_success 'Test subject and body of request close notifications.' ' test_expect_success 'Test subject and body of request close notifications (auto-accept).' ' >sendmail.out && - "$NOTIFY" request-close 0 1 accepted && + "$NOTIFY" request-close 0 3001 accepted && grep ^Subject: sendmail.out >actual && cat <<-EOD >expected && - Subject: [PRQ#1] Deletion Request for foobar Accepted + Subject: [PRQ#3001] Deletion Request for foobar Accepted EOD test_cmp actual expected && sed -n "/^\$/,\$p" sendmail.out | base64 -d >actual && echo >>actual && cat <<-EOD >expected && - Request #1 has been accepted automatically by the Arch User Repository - package request system. + Request #3001 has been accepted automatically by the Arch User + Repository package request system. EOD test_cmp actual expected ' test_expect_success 'Test subject and body of request close notifications with closure comment.' ' cat <<-EOD | sqlite3 aur.db && - UPDATE PackageRequests SET ClosureComment = "This is a test closure comment." WHERE ID = 1; + UPDATE PackageRequests SET ClosureComment = "This is a test closure comment." WHERE ID = 3001; EOD >sendmail.out && - "$NOTIFY" request-close 1 1 accepted && + "$NOTIFY" request-close 1 3001 accepted && grep ^Subject: sendmail.out >actual && cat <<-EOD >expected && - Subject: [PRQ#1] Deletion Request for foobar Accepted + Subject: [PRQ#3001] Deletion Request for foobar Accepted EOD test_cmp actual expected && sed -n "/^\$/,\$p" sendmail.out | base64 -d >actual && echo >>actual && cat <<-EOD >expected && - Request #1 has been accepted by user [1]: + Request #3001 has been accepted by user [1]: This is a test closure comment. -- 2.18.0

1 1

[PATCH] Initialize locale directory for tests
by Lukas Fleischer 12 Aug '18

12 Aug '18

Since commit a7865ef (Make the locale directory configurable, 2018-07-22), we need to specify the locale directory in the configuration file. Signed-off-by: Lukas Fleischer <lfleischer(a)archlinux.org> --- test/setup.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/test/setup.sh b/test/setup.sh index 535e819..5c761f2 100644 --- a/test/setup.sh +++ b/test/setup.sh @@ -31,6 +31,7 @@ aur_request_ml = aur-requests(a)archlinux.org enable-maintenance = 0 maintenance-exceptions = 127.0.0.1 commit_uri = https://aur.archlinux.org/cgit/aur.git/log/?h=%s&id=%s +localedir = $TOPLEVEL/web/locale/ [notifications] notify-cmd = $NOTIFY -- 2.18.0

1 0

[PATCH] Add page for seeing all of a user's comments
by Johannes Löthberg 06 Aug '18

06 Aug '18

Signed-off-by: Johannes Löthberg <johannes(a)kyriasis.com> --- web/html/account.php | 69 +++++++++++++++++++++++++++++- web/html/css/aurweb.css | 17 ++++++++ web/html/index.php | 2 + web/html/pkgbase.php | 7 ++- web/lib/acctfuncs.inc.php | 41 ++++++++++++++++++ web/lib/credentials.inc.php | 2 + web/template/account_edit_form.php | 1 + 7 files changed, 136 insertions(+), 3 deletions(-) diff --git a/web/html/account.php b/web/html/account.php index c30a89a..955aa4d 100644 --- a/web/html/account.php +++ b/web/html/account.php @@ -8,7 +8,7 @@ include_once('acctfuncs.inc.php'); # access Account specific functions $action = in_request("Action"); $need_userinfo = array( - "DisplayAccount", "DeleteAccount", "AccountInfo", "UpdateAccount" + "DisplayAccount", "DeleteAccount", "AccountInfo", "UpdateAccount", "ListComments" ); if (in_array($action, $need_userinfo)) { @@ -54,6 +54,8 @@ if ($action == "UpdateAccount") { if ($action == "AccountInfo") { html_header(__('Account') . ' ' . $row['Username']); +} elseif ($action == "ListComments") { + html_header(__('Comments for') . ' ' . $row['Username']); } else { html_header(__('Accounts')); } @@ -61,7 +63,11 @@ if ($action == "AccountInfo") { # Main page processing here # echo "<div class=\"box\">\n"; -echo " <h2>".__("Accounts")."</h2>\n"; +if ($action == "ListComments") { + echo " <h2>".__("Comments for").' '.$row['Username']."</h2>\n"; +} else { + echo " <h2>".__("Accounts")."</h2>\n"; +} if (isset($_COOKIE["AURSID"])) { if ($action == "SearchAccounts") { @@ -166,6 +172,65 @@ if (isset($_COOKIE["AURSID"])) { $row["Username"]); } + } elseif ($action == "ListComments") { + if (has_credential(CRED_ACCOUNT_LIST_COMMENTS)) { + # display the comment list if they're a TU/dev + # + + /* Sanitize paging variables. */ + if (isset($_GET["O"])) { + $_GET["O"] = max(intval($_GET["O"]), 0); + } else { + $_GET["O"] = 0; + } + + if (isset($_GET["PP"])) { + $_GET["PP"] = bound(intval($_GET["PP"]), 5, 250); + } else { + $_GET["PP"] = 10; + } + + $total = account_comments_count($row["ID"]); + + /* Calculate the results to use. */ + $first = $_GET['O'] + 1; + + /* Calculation of pagination links. */ + $per_page = ($_GET['PP'] > 0) ? $_GET['PP'] : 50; + $current = ceil($first / $per_page); + $pages = ceil($total / $per_page); + $templ_pages = array(); + + if ($current > 1) { + $templ_pages['« ' . __('First')] = 0; + $templ_pages['&lsaquo; ' . __('Previous')] = ($current - 2) * $per_page; + } + + if ($current - 5 > 1) + $templ_pages["..."] = false; + + for ($i = max($current - 5, 1); $i <= min($pages, $current + 5); $i++) { + $templ_pages[$i] = ($i - 1) * $per_page; + } + + if ($current + 5 < $pages) + $templ_pages["... "] = false; + + if ($current < $pages) { + $templ_pages[__('Next') . ' &rsaquo;'] = $current * $per_page; + $templ_pages[__('Last') . ' »'] = ($pages - 1) * $per_page; + } + + $username = $row["Username"]; + $userid = $row["ID"]; + $comments = account_comments($row["ID"], $_GET["PP"], $_GET["O"]); + + include('account_comments.php'); + + } else { + print __("You are not allowed to access this area."); + } + } else { if (has_credential(CRED_ACCOUNT_SEARCH)) { # display the search page if they're a TU/dev diff --git a/web/html/css/aurweb.css b/web/html/css/aurweb.css index f5e1037..ce54a28 100644 --- a/web/html/css/aurweb.css +++ b/web/html/css/aurweb.css @@ -148,3 +148,20 @@ label.confirmation, color: red; font-weight: bold; } + +.commentlist-nav .page { + margin: 0 .25em; +} + +#commentlist-results .commentlist-nav { + float: right; + margin-top: -2.2em; +} + +.commentlist-nav .prev { + margin-right: 1em; +} + +.commentlist-nav .next { + margin-right: 1em; +} diff --git a/web/html/index.php b/web/html/index.php index 2c53cdd..b2cd840 100644 --- a/web/html/index.php +++ b/web/html/index.php @@ -142,6 +142,8 @@ if (!empty($tokens[1]) && '/' . $tokens[1] == get_pkg_route()) { $_REQUEST['Action'] = "UpdateAccount"; } elseif ($tokens[3] == 'delete') { $_REQUEST['Action'] = "DeleteAccount"; + } elseif ($tokens[3] == 'comments') { + $_REQUEST['Action'] = "ListComments"; } else { header("HTTP/1.0 404 Not Found"); include "./404.php"; diff --git a/web/html/pkgbase.php b/web/html/pkgbase.php index cf9a6c6..8a0c363 100644 --- a/web/html/pkgbase.php +++ b/web/html/pkgbase.php @@ -43,6 +43,7 @@ if (isset($_POST['IDs'])) { /* Perform package base actions. */ $via = isset($_POST['via']) ? $_POST['via'] : NULL; +$return_to = isset($_POST['return_to']) ? $_POST['return_to'] : NULL; $ret = false; $output = ""; $fragment = ""; @@ -133,7 +134,11 @@ if (check_token()) { /* Redirect back to package request page on success. */ header('Location: ' . get_pkgreq_route()); exit(); - } if (isset($base_id)) { + } elseif ((current_action("do_DeleteComment") || + current_action("do_UndeleteComment")) && $return_to) { + header('Location: ' . $return_to); + exit(); + } elseif (isset($base_id)) { /* Redirect back to package base page on success. */ header('Location: ' . get_pkgbase_uri($pkgbase_name) . $fragment); exit(); diff --git a/web/lib/acctfuncs.inc.php b/web/lib/acctfuncs.inc.php index df57375..9536139 100644 --- a/web/lib/acctfuncs.inc.php +++ b/web/lib/acctfuncs.inc.php @@ -1403,3 +1403,44 @@ function accept_terms($uid, $termrev) { $dbh->exec($q); } } + +function account_comments($uid, $limit, $offset=0) { + $dbh = DB::connect(); + $q = "SELECT PackageComments.ID, Comments, "; + $q.= "PackageBaseId, CommentTS, DelTS, EditedTS, B.UserName AS EditUserName, "; + $q.= "C.UserName as DelUserName, RenderedComment, "; + $q.= "PB.ID as PackageBaseID, PB.Name as PackageBaseName "; + $q.= "FROM PackageComments "; + $q.= "LEFT JOIN PackageBases PB ON PackageComments.PackageBaseID = PB.ID "; + $q.= "LEFT JOIN Users A ON PackageComments.UsersID = A.ID "; + $q.= "LEFT JOIN Users B ON PackageComments.EditedUsersID = B.ID "; + $q.= "LEFT JOIN Users C ON PackageComments.DelUsersID = C.ID "; + $q.= "WHERE A.ID = " . $dbh->quote($uid) . " "; + $q.= "ORDER BY CommentTS DESC"; + + if ($limit > 0) { + $q.=" LIMIT " . $limit; + } + + if ($offset > 0) { + $q.=" OFFSET " . $offset; + } + + $result = $dbh->query($q); + if (!$result) { + return null; + } + + return $result->fetchAll(); +} + +function account_comments_count($uid) { + $dbh = DB::connect(); + $q = "SELECT COUNT(*) "; + $q.= "FROM PackageComments "; + $q.= "LEFT JOIN Users A ON PackageComments.UsersID = A.ID "; + $q.= "WHERE A.ID = " . $dbh->quote($uid); + + $result = $dbh->query($q); + return $result->fetch(PDO::FETCH_NUM)[0]; +} diff --git a/web/lib/credentials.inc.php b/web/lib/credentials.inc.php index d8698a8..5d90cfc 100644 --- a/web/lib/credentials.inc.php +++ b/web/lib/credentials.inc.php @@ -5,6 +5,7 @@ define("CRED_ACCOUNT_EDIT", 2); define("CRED_ACCOUNT_EDIT_DEV", 3); define("CRED_ACCOUNT_LAST_LOGIN", 4); define("CRED_ACCOUNT_SEARCH", 5); +define("CRED_ACCOUNT_LIST_COMMENTS", 28); define("CRED_COMMENT_DELETE", 6); define("CRED_COMMENT_UNDELETE", 27); define("CRED_COMMENT_VIEW_DELETED", 22); @@ -59,6 +60,7 @@ function has_credential($credential, $approved_users=array()) { case CRED_ACCOUNT_EDIT: case CRED_ACCOUNT_LAST_LOGIN: case CRED_ACCOUNT_SEARCH: + case CRED_ACCOUNT_LIST_COMMENTS: case CRED_COMMENT_DELETE: case CRED_COMMENT_UNDELETE: case CRED_COMMENT_VIEW_DELETED: diff --git a/web/template/account_edit_form.php b/web/template/account_edit_form.php index 6eff81b..38d5274 100644 --- a/web/template/account_edit_form.php +++ b/web/template/account_edit_form.php @@ -2,6 +2,7 @@ <p> <?= __('Click %shere%s if you want to permanently delete this account.', '<a href="' . get_user_uri($N) . 'delete/' . '">', '</a>') ?> <?= __('Click %shere%s for user details.', '<a href="' . get_user_uri($N) . '">', '</a>') ?> + <?= __('Click %shere%s to list the comments made by this account.', '<a href="' . get_user_uri($N) . 'comments/' . '">', '</a>') ?> </p> <form id="edit-profile-form" action="<?= get_user_uri($N) . 'update/'; ?>" method="post"> -- 2.18.0

2 11