- Aur-dev - lists.archlinux.org

[aur-dev] Dashboard
by Lukas Fleischer 15 Feb '17

15 Feb '17

Hi, One of the new features of the upcoming aurweb release is a dashboard which will be displayed in place of the regular home page after login. Right now, it includes * a list of flagged packages the logged in user (co-)maintains, * a list of package requests affecting the logged in user, * the list of packages the logged in user maintains and * the list of packages the logged in user co-maintains. You can already test the new feature under [1]. Note that you will need to ignore the warning your browser might show because the aur-dev subdomain is not part of our SSL/TLS certificate (and least with Firefox, this is not easily possible, because of HSTS; Chromium seems to work, though). What are your thoughts on this? Are there any other suggestions for useful things to display on that page? Regards and have a nice Sunday, Lukas [1] https://aur-dev.archlinux.org/

4 7

[aur-dev] [PATCH] Fix several PHP short open tags
by Lukas Fleischer 15 Feb '17

15 Feb '17

Use "<?=" instead of "<?" for printing. Fixes a regression introduced in a9048bb (Dedupe translatable strings, 2015-11-25). Signed-off-by: Lukas Fleischer <lfleischer(a)archlinux.org> --- web/html/pkgdel.php | 2 +- web/html/pkgdisown.php | 2 +- web/html/pkgflag.php | 2 +- web/html/pkgmerge.php | 2 +- web/template/comaintainers_form.php | 2 +- web/template/pkgreq_close_form.php | 2 +- web/template/pkgreq_form.php | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) diff --git a/web/html/pkgdel.php b/web/html/pkgdel.php index 21a2677..591ccce 100644 --- a/web/html/pkgdel.php +++ b/web/html/pkgdel.php @@ -12,7 +12,7 @@ html_header(__("Package Deletion")); if (has_credential(CRED_PKGBASE_DELETE)): ?> <div class="box"> - <h2><?= __('Delete Package') ?>: <? htmlspecialchars($pkgbase_name) ?></h2> + <h2><?= __('Delete Package') ?>: <?= htmlspecialchars($pkgbase_name) ?></h2> <p> <?= __('Use this form to delete the package base %s%s%s and the following packages from the AUR: ', '<strong>', htmlspecialchars($pkgbase_name), '</strong>'); ?> diff --git a/web/html/pkgdisown.php b/web/html/pkgdisown.php index f24a2d6..036fe6d 100644 --- a/web/html/pkgdisown.php +++ b/web/html/pkgdisown.php @@ -15,7 +15,7 @@ $comaintainers = pkgbase_get_comaintainers($base_id); if (has_credential(CRED_PKGBASE_DISOWN, $maintainer_uids)): ?> <div class="box"> - <h2><?= __('Disown Package') ?>: <? htmlspecialchars($pkgbase_name) ?></h2> + <h2><?= __('Disown Package') ?>: <?= htmlspecialchars($pkgbase_name) ?></h2> <p> <?= __('Use this form to disown the package base %s%s%s which includes the following packages: ', '<strong>', htmlspecialchars($pkgbase_name), '</strong>'); ?> diff --git a/web/html/pkgflag.php b/web/html/pkgflag.php index f50c208..44849d8 100644 --- a/web/html/pkgflag.php +++ b/web/html/pkgflag.php @@ -43,7 +43,7 @@ html_header(__("Flag Package Out-Of-Date")); if (has_credential(CRED_PKGBASE_FLAG)): ?> <div class="box"> - <h2><?= __('Flag Package Out-Of-Date') ?>: <? htmlspecialchars($pkgbase_name) ?></h2> + <h2><?= __('Flag Package Out-Of-Date') ?>: <?= htmlspecialchars($pkgbase_name) ?></h2> <p> <?= __('Use this form to flag the package base %s%s%s and the following packages out-of-date: ', '<strong>', htmlspecialchars($pkgbase_name), '</strong>'); ?> diff --git a/web/html/pkgmerge.php b/web/html/pkgmerge.php index c0ce655..e8e7ca9 100644 --- a/web/html/pkgmerge.php +++ b/web/html/pkgmerge.php @@ -12,7 +12,7 @@ html_header(__("Package Merging")); if (has_credential(CRED_PKGBASE_DELETE)): ?> <div class="box"> - <h2><?= __('Merge Package') ?>: <? htmlspecialchars($pkgbase_name) ?></h2> + <h2><?= __('Merge Package') ?>: <?= htmlspecialchars($pkgbase_name) ?></h2> <p> <?= __('Use this form to merge the package base %s%s%s into another package. ', '<strong>', htmlspecialchars($pkgbase_name), '</strong>'); ?> diff --git a/web/template/comaintainers_form.php b/web/template/comaintainers_form.php index 70a7464..79e2b52 100644 --- a/web/template/comaintainers_form.php +++ b/web/template/comaintainers_form.php @@ -1,5 +1,5 @@ <div class="box"> - <h2><?= __('Manage Co-maintainers') ?>: <? htmlspecialchars($pkgbase_name) ?></h2> + <h2><?= __('Manage Co-maintainers') ?>: <?= htmlspecialchars($pkgbase_name) ?></h2> <p> <?= __('Use this form to add co-maintainers for %s%s%s (one user name per line):', '<strong>', htmlspecialchars($pkgbase_name), '</strong>'); ?> diff --git a/web/template/pkgreq_close_form.php b/web/template/pkgreq_close_form.php index 59e9c8f..6077b32 100644 --- a/web/template/pkgreq_close_form.php +++ b/web/template/pkgreq_close_form.php @@ -1,5 +1,5 @@ <div class="box"> - <h2><?= __('Close Request') ?>: <? htmlspecialchars($pkgbase_name) ?></h2> + <h2><?= __('Close Request') ?>: <?= htmlspecialchars($pkgbase_name) ?></h2> <p> <?= __('Use this form to close the request for package base %s%s%s.', '<strong>', htmlspecialchars($pkgbase_name), '</strong>'); ?> diff --git a/web/template/pkgreq_form.php b/web/template/pkgreq_form.php index 35dbef5..904ab48 100644 --- a/web/template/pkgreq_form.php +++ b/web/template/pkgreq_form.php @@ -1,5 +1,5 @@ <div class="box"> - <h2><?= __('Submit Request') ?>: <? htmlspecialchars($pkgbase_name) ?></h2> + <h2><?= __('Submit Request') ?>: <?= htmlspecialchars($pkgbase_name) ?></h2> <p> <?= __('Use this form to file a request against package base %s%s%s which includes the following packages:', '<strong>', htmlspecialchars($pkgbase_name), '</strong>'); ?> -- 2.11.1

1 0

[aur-dev] [PATCH] pkgbase.php: Add default title
by Lukas Fleischer 15 Feb '17

15 Feb '17

Instead of triggering a PHP warning and using an empty title if no package base is specified, use a default title. Signed-off-by: Lukas Fleischer <lfleischer(a)archlinux.org> --- web/html/pkgbase.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/html/pkgbase.php b/web/html/pkgbase.php index 11fdf74..23aa6c8 100644 --- a/web/html/pkgbase.php +++ b/web/html/pkgbase.php @@ -30,7 +30,7 @@ if (!isset($base_id) || !isset($pkgbase_name)) { } /* Set the title to package base name. */ -$title = $pkgbase_name; +$title = isset($pkgbase_name) ? $pkgbase_name : __("Package Bases"); /* Grab the list of package base IDs to be operated on. */ $ids = array(); -- 2.11.1

1 0

[aur-dev] [PATCH 1/2] Add a parameter to skip old requests to pkgreq_list()
by Lukas Fleischer 15 Feb '17

15 Feb '17

Allow for hiding requests which were opened before a given time stamp. Signed-off-by: Lukas Fleischer <lfleischer(a)archlinux.org> --- web/lib/pkgreqfuncs.inc.php | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/web/lib/pkgreqfuncs.inc.php b/web/lib/pkgreqfuncs.inc.php index 7dcab13..774ebe7 100644 --- a/web/lib/pkgreqfuncs.inc.php +++ b/web/lib/pkgreqfuncs.inc.php @@ -20,10 +20,11 @@ function pkgreq_count() { * @param int $offset The index of the first request to return * @param int $limit The maximum number of requests to return * @param int $uid Only return packages affecting the given user + * @param int $from Do not return packages older than the given date * - * @return array List of pacakge requests with details + * @return array List of package requests with details */ -function pkgreq_list($offset, $limit, $uid=false) { +function pkgreq_list($offset, $limit, $uid=false, $from=false) { $dbh = DB::connect(); $q = "SELECT PackageRequests.ID, "; @@ -37,9 +38,15 @@ function pkgreq_list($offset, $limit, $uid=false) { $q.= "RequestTypes.ID = PackageRequests.ReqTypeID "; $q.= "INNER JOIN Users ON Users.ID = PackageRequests.UsersID "; - if ($uid) { - $q.= "WHERE PackageRequests.UsersID = " . intval($uid). " "; - $q.= "OR Users.ID = " . intval($uid) . " "; + if ($uid || $from) { + $q.= "WHERE "; + if ($uid) { + $q.= "(PackageRequests.UsersID = " . intval($uid). " "; + $q.= "OR Users.ID = " . intval($uid) . ") AND "; + } + if ($from) { + $q.= "RequestTS >= " . intval($from). " "; + } } $q.= "ORDER BY Open DESC, RequestTS DESC "; -- 2.11.1

1 1

[aur-dev] [PATCH] Make aurjson error messages consistent
by Michael Straube 14 Feb '17

14 Feb '17

All error messages in aurjson except two end with a period. Add the missing periods to make the messages consistent. Signed-off-by: Michael Straube <straubem(a)gmx.de> --- web/lib/aurjson.class.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/web/lib/aurjson.class.php b/web/lib/aurjson.class.php index 3bd9179..e07522d 100644 --- a/web/lib/aurjson.class.php +++ b/web/lib/aurjson.class.php @@ -387,7 +387,7 @@ class AurJSON { if ($search_by === 'name' || $search_by === 'name-desc') { if (strlen($keyword_string) < 2) { - return $this->json_error('Query arg too small'); + return $this->json_error('Query arg too small.'); } $keyword_string = $this->dbh->quote("%" . addcslashes($keyword_string, '%_') . "%"); @@ -441,7 +441,7 @@ class AurJSON { $names = $args['names']; if (!$ids && !$names) { - return $this->json_error('Invalid query arguments'); + return $this->json_error('Invalid query arguments.'); } $where_condition = ""; -- 2.11.1

2 1

[aur-dev] [PATCH] Add direct links to each source file
by Janne Heß 12 Feb '17

12 Feb '17

Currently, each source file which is an external link (http://, https://, ...) is a clickable link. This commit extends the behaviour by making files from the repository clickable as well. The link brings the user to the corresponding cgit page. Also, the link to the PKGBUILD is altered to make the configuration more consistent. --- conf/config.proto | 2 +- web/lib/pkgfuncs.inc.php | 6 ++++-- web/template/pkg_details.php | 3 ++- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/conf/config.proto b/conf/config.proto index c1be281..01a907a 100644 --- a/conf/config.proto +++ b/conf/config.proto @@ -27,7 +27,7 @@ aur_request_ml = aur-requests(a)archlinux.org request_idle_time = 1209600 auto_orphan_age = 15552000 auto_delete_age = 86400 -pkgbuild_uri = https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=%s +source_file_uri = https://aur.archlinux.org/cgit/aur.git/tree/%s?h=%s log_uri = https://aur.archlinux.org/cgit/aur.git/log/?h=%s snapshot_uri = /cgit/aur.git/snapshot/%s.tar.gz enable-maintenance = 1 diff --git a/web/lib/pkgfuncs.inc.php b/web/lib/pkgfuncs.inc.php index 8ca8835..dce0721 100644 --- a/web/lib/pkgfuncs.inc.php +++ b/web/lib/pkgfuncs.inc.php @@ -481,17 +481,19 @@ function pkg_rel_html($name, $cond, $arch) { * * @param string $url The URL of the source * @param string $arch The source architecture + * @param string $package The name of the package * * @return string The HTML code of the label to display */ -function pkg_source_link($url, $arch) { +function pkg_source_link($url, $arch, $package) { $url = explode('::', $url); $parsed_url = parse_url($url[0]); if (isset($parsed_url['scheme']) || isset($url[1])) { $link = '<a href="' . htmlspecialchars((isset($url[1]) ? $url[1] : $url[0]), ENT_QUOTES) . '">' . htmlspecialchars($url[0]) . '</a>'; } else { - $link = htmlspecialchars($url[0]); + $file_url = sprintf(config_get('options', 'source_file_uri'), htmlspecialchars($url[0]), $package); + $link = '<a href="' . $file_url . '">' . htmlspecialchars($url[0]) . '</a>'; } if ($arch) { diff --git a/web/template/pkg_details.php b/web/template/pkg_details.php index 3269394..2fbdabf 100644 --- a/web/template/pkg_details.php +++ b/web/template/pkg_details.php @@ -1,6 +1,6 @@ <?php -$pkgbuild_uri = sprintf(config_get('options', 'pkgbuild_uri'), urlencode($row['BaseName'])); +$pkgbuild_uri = sprintf(config_get('options', 'source_file_uri'), 'PKGBUILD', urlencode($row['BaseName'])); $log_uri = sprintf(config_get('options', 'log_uri'), urlencode($row['BaseName'])); $snapshot_uri = sprintf(config_get('options', 'snapshot_uri'), urlencode($row['BaseName'])); $git_clone_uri_anon = sprintf(config_get('options', 'git_clone_uri_anon'), htmlspecialchars($row['BaseName'])); @@ -300,6 +300,7 @@ endif; <ul id="pkgsrcslist"> <?php while (list($k, $src) = each($sources)): ?> <li><?= pkg_source_link($src[0], $src[1]) ?></li> + <li><?= pkg_source_link($src[0], $src[1], urlencode($row['BaseName'])) ?></li> <?php endwhile; ?> </ul> </div> -- 2.11.1

2 6

[aur-dev] [PATCH] Add check for if PATH_INFO exists
by Mark Weiman 12 Feb '17

12 Feb '17

When running aurweb with the command line php server and / is visited, it will give an undefined index notice. This will add a check if it exists and will prevent the notice. Signed-off-by: Mark Weiman <mark.weiman(a)markzz.com> --- web/html/index.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/html/index.php b/web/html/index.php index 78ab6ad..3bdf281 100644 --- a/web/html/index.php +++ b/web/html/index.php @@ -4,7 +4,7 @@ set_include_path(get_include_path() . PATH_SEPARATOR . '../lib'); include_once("aur.inc.php"); include_once("pkgfuncs.inc.php"); -$path = $_SERVER['PATH_INFO']; +$path = isset($_SERVER['PATH_INFO']) ? $_SERVER['PATH_INFO'] : "/"; $tokens = explode('/', $path); if (config_get_bool('options', 'enable-maintenance') && (empty($tokens[1]) || ($tokens[1] != "css" && $tokens[1] != "images"))) { -- 2.11.0

2 5

[aur-dev] [PATCH] Move package search links on the dashboard
by Lukas Fleischer 12 Feb '17

12 Feb '17

Move the package search links below the section headings. Signed-off-by: Lukas Fleischer <lfleischer(a)archlinux.org> --- web/html/home.php | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/web/html/home.php b/web/html/home.php index 1652541..ee7caf7 100644 --- a/web/html/home.php +++ b/web/html/home.php @@ -41,7 +41,8 @@ if (isset($_COOKIE["AURSID"])) { ?> </div> <div id="intro" class="box"> - <h2><?= __("My Packages"); ?> <span class="more">(<a href="<?= get_uri('/packages/') ?>?SeB=m&K=<?= username_from_sid($_COOKIE["AURSID"]); ?>"><?= __('more') ?></a>)</span></h2> + <h2><?= __("My Packages"); ?></h2> + <p><a href="<?= get_uri('/packages/') ?>?SeB=m&K=<?= username_from_sid($_COOKIE["AURSID"]); ?>"><?= __('Search for packages I maintain') ?></a></p> <?php $params = array( 'PP' => 50, @@ -54,7 +55,8 @@ if (isset($_COOKIE["AURSID"])) { ?> </div> <div id="intro" class="box"> - <h2><?= __("Co-Maintained Packages"); ?> <span class="more">(<a href="<?= get_uri('/packages/') ?>?SeB=c&K=<?= username_from_sid($_COOKIE["AURSID"]); ?>"><?= __('more') ?></a>)</span></h2> + <h2><?= __("Co-Maintained Packages"); ?></h2> + <p><a href="<?= get_uri('/packages/') ?>?SeB=c&K=<?= username_from_sid($_COOKIE["AURSID"]); ?>"><?= __('Search for packages I co-maintain') ?></a></p> <?php $params = array( 'PP' => 50, -- 2.11.1

1 0

[aur-dev] [PATCH 1/3] Hide the table sorting links on the dashboard
by Lukas Fleischer 08 Feb '17

08 Feb '17

The tables on the dashboard always show the 50 most recent packages, ordered by last update. Do not make the table headers of these tables clickable. Signed-off-by: Lukas Fleischer <lfleischer(a)archlinux.org> --- web/template/pkg_search_results.php | 29 +++++++++++++++++++++-------- 1 file changed, 21 insertions(+), 8 deletions(-) diff --git a/web/template/pkg_search_results.php b/web/template/pkg_search_results.php index d596ec2..8a2e8d3 100644 --- a/web/template/pkg_search_results.php +++ b/web/template/pkg_search_results.php @@ -1,4 +1,17 @@ <?php +function fmtth($title, $sb=false, $so=false, $hint=false) { + echo '<th>'; + if ($sb) { + echo '<a href="' . mkurl('SB=' . $sb . '&SO = ' . $so) . '">' . $title . '</a>'; + } else { + echo $title; + } + if ($hint) { + echo '<span title="' . $hint . '" class="hover-help"><sup>?</sup></span>'; + } + echo '</th>'; +} + if (!$result): ?> <p><?= __("Error retrieving package list.") ?></p> <?php elseif ($total == 0): ?> @@ -33,16 +46,16 @@ if (!$result): ?> <?php if ($SID && $show_headers): ?> <th> </th> <?php endif; ?> - <th><a href="?<?= mkurl('SB=n&SO=' . $SO_next) ?>"><?= __("Name") ?></a></th> - <th><?= __("Version") ?></th> - <th><a href="?<?= mkurl('SB=v&SO=' . $SO_next) ?>"><?= __("Votes") ?></a></th> - <th><a href="?<?= mkurl('SB=p&SO=' . $SO_next) ?>"><?= __("Popularity") ?></a><span title="<?= __('Popularity is calculated as the sum of all votes with each vote being weighted with a factor of %.2f per day since its creation.', 0.98) ?>" class="hover-help"><sup>?</sup></span></th> + <?php fmtth(__('Name'), $show_headers ? 'n' : false, $SO_next) ?> + <?php fmtth(__('Version')) ?> + <?php fmtth(__('Votes'), $show_headers ? 'v' : false, $SO_next) ?> + <?php fmtth(__('Popularity'), $show_headers ? 'p' : false, $SO_next, __('Popularity is calculated as the sum of all votes with each vote being weighted with a factor of %.2f per day since its creation.', 0.98)) ?> <?php if ($SID): ?> - <th><a href="?<?= mkurl('SB=w&SO=' . $SO_next) ?>"><?= __("Voted") ?></a></th> - <th><a href="?<?= mkurl('SB=o&SO=' . $SO_next) ?>"><?= __("Notify") ?></a></th> + <?php fmtth(__('Voted'), $show_headers ? 'w' : false, $SO_next) ?> + <?php fmtth(__('Notify'), $show_headers ? 'o' : false, $SO_next) ?> <?php endif; ?> - <th><?= __("Description") ?></th> - <th><a href="?<?= mkurl('SB=m&SO=' . $SO_next) ?>"><?= __("Maintainer") ?></a></th> + <?php fmtth(__('Description')) ?> + <?php fmtth(__('Maintainer'), $show_headers ? 'm' : false, $SO_next) ?> </tr> </thead> <tbody> -- 2.11.1

2 4

[aur-dev] [PATCH] Add direct links to each source file
by Janne Heß 08 Feb '17

08 Feb '17

Currently, each source file which is an external link (http://, https://, ...) is a clickable link. This commit extends the behaviour by making files from the repository clickable as well. The link brings the user to the corresponding cgit page. Also, the link to the PKGBUILD was altered to make the configuration more consistent. --- conf/config.proto | 2 +- web/lib/pkgfuncs.inc.php | 6 ++++-- web/template/pkg_details.php | 4 ++-- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/conf/config.proto b/conf/config.proto index 63e2458..4cc294f 100644 --- a/conf/config.proto +++ b/conf/config.proto @@ -26,7 +26,7 @@ aur_request_ml = aur-requests(a)archlinux.org request_idle_time = 1209600 auto_orphan_age = 15552000 auto_delete_age = 86400 -pkgbuild_uri = https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=%s +source_file_uri = https://aur.archlinux.org/cgit/aur.git/tree/%s?h=%s log_uri = https://aur.archlinux.org/cgit/aur.git/log/?h=%s snapshot_uri = /cgit/aur.git/snapshot/%s.tar.gz enable-maintenance = 1 diff --git a/web/lib/pkgfuncs.inc.php b/web/lib/pkgfuncs.inc.php index 4b0fdba..d4b3465 100644 --- a/web/lib/pkgfuncs.inc.php +++ b/web/lib/pkgfuncs.inc.php @@ -481,17 +481,19 @@ function pkg_rel_html($name, $cond, $arch) { * * @param string $url The URL of the source * @param string $arch The source architecture + * @param string $package The name of the package * * @return string The HTML code of the label to display */ -function pkg_source_link($url, $arch) { +function pkg_source_link($url, $arch, $package) { $url = explode('::', $url); $parsed_url = parse_url($url[0]); if (isset($parsed_url['scheme']) || isset($url[1])) { $link = '<a href="' . htmlspecialchars((isset($url[1]) ? $url[1] : $url[0]), ENT_QUOTES) . '">' . htmlspecialchars($url[0]) . '</a>'; } else { - $link = htmlspecialchars($url[0]); + $file_url = sprintf(config_get('options', 'source_file_uri'), htmlspecialchars($url[0]), $package); + $link = '<a href="' . $file_url . '">' . htmlspecialchars($url[0]) . '</a>'; } if ($arch) { diff --git a/web/template/pkg_details.php b/web/template/pkg_details.php index b9c66d4..69f37e9 100644 --- a/web/template/pkg_details.php +++ b/web/template/pkg_details.php @@ -1,6 +1,6 @@ <?php -$pkgbuild_uri = sprintf(config_get('options', 'pkgbuild_uri'), urlencode($row['BaseName'])); +$pkgbuild_uri = sprintf(config_get('options', 'source_file_uri'), 'PKGBUILD', urlencode($row['BaseName'])); $log_uri = sprintf(config_get('options', 'log_uri'), urlencode($row['BaseName'])); $snapshot_uri = sprintf(config_get('options', 'snapshot_uri'), urlencode($row['BaseName'])); $git_clone_uri_anon = sprintf(config_get('options', 'git_clone_uri_anon'), htmlspecialchars($row['BaseName'])); @@ -299,7 +299,7 @@ endif; <div> <ul id="pkgsrcslist"> <?php while (list($k, $src) = each($sources)): ?> - <li><?= pkg_source_link($src[0], $src[1]) ?></li> + <li><?= pkg_source_link($src[0], $src[1], urlencode($row['BaseName'])) ?></li> <?php endwhile; ?> </ul> </div> -- 2.11.0

3 2