- Aur-dev - lists.archlinux.org

[aur-dev] AUR 3.4.1 released
by Lukas Fleischer 29 Jul '14

29 Jul '14

Hello, I am pleased to announce that AUR 3.4.1 has been released. The official AUR setup [1] has already been updated. This release includes bug fixes regarding the account registration form and translations. For a comprehensive list of changes, please consult the Git log [2]. As usual, bugs should be reported to the AUR bug tracker [3]. [1] https://aur.archlinux.org/ [2] https://projects.archlinux.org/aur.git/log/?id=v3.4.1 [3] https://bugs.archlinux.org/index.php?project=2

1 0

[aur-dev] [PATCH 1/3] Do not show deletion link on the registration page
by Lukas Fleischer 29 Jul '14

29 Jul '14

In 7df8dc8 (Add support for deleting user accounts, 2014-07-25), a link to the account deletion page was added to the account edit form. Make sure we only show this link if the user actually wants to edit an account and do not show this link on the account registration page. Signed-off-by: Lukas Fleischer <archlinux(a)cryptocrack.de> --- web/template/account_edit_form.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/template/account_edit_form.php b/web/template/account_edit_form.php index 3733985..17dd937 100644 --- a/web/template/account_edit_form.php +++ b/web/template/account_edit_form.php @@ -1,8 +1,8 @@ +<?php if ($A == "UpdateAccount"): ?> <p> <?= __('Click %shere%s if you want to permanently delete this account.', '<a href="' . get_user_uri($U) . 'delete/' . '">', '</a>') ?> </p> -<?php if ($A == "UpdateAccount"): ?> <form id="edit-profile-form" action="<?= get_user_uri($U) . 'update/'; ?>" method="post"> <?php else: ?> <form id="edit-profile-form" action="<?= get_uri('/register/'); ?>" method="post"> -- 2.0.3

1 2

[aur-dev] [PATCH] Make deleted comments visible to Trusted Users
by Lukas Fleischer 28 Jul '14

28 Jul '14

This allows Trusted Users to check whether a user posted a politically incorrect comment, even if he already deleted it. Signed-off-by: Lukas Fleischer <archlinux(a)cryptocrack.de> --- web/html/css/aur.css | 4 ++++ web/lib/credentials.inc.php | 2 ++ web/lib/pkgbasefuncs.inc.php | 20 ++++++++++++++------ web/lib/pkgfuncs.inc.php | 3 ++- web/template/pkg_comments.php | 12 ++++++++---- 5 files changed, 30 insertions(+), 11 deletions(-) diff --git a/web/html/css/aur.css b/web/html/css/aur.css index 9435e22..654116a 100644 --- a/web/html/css/aur.css +++ b/web/html/css/aur.css @@ -68,3 +68,7 @@ padding: 0; border: none; } + +.comment-deleted { + color: #999; +} diff --git a/web/lib/credentials.inc.php b/web/lib/credentials.inc.php index 47dd3fd..efc203d 100644 --- a/web/lib/credentials.inc.php +++ b/web/lib/credentials.inc.php @@ -7,6 +7,7 @@ define("CRED_ACCOUNT_EDIT_DEV", 3); define("CRED_ACCOUNT_LAST_LOGIN", 4); define("CRED_ACCOUNT_SEARCH", 5); define("CRED_COMMENT_DELETE", 6); +define("CRED_COMMENT_VIEW_DELETED", 22); define("CRED_PKGBASE_ADOPT", 7); define("CRED_PKGBASE_CHANGE_CATEGORY", 8); define("CRED_PKGBASE_DELETE", 9); @@ -55,6 +56,7 @@ function has_credential($credential, $approved_users=array()) { case CRED_ACCOUNT_LAST_LOGIN: case CRED_ACCOUNT_SEARCH: case CRED_COMMENT_DELETE: + case CRED_COMMENT_VIEW_DELETED: case CRED_PKGBASE_ADOPT: case CRED_PKGBASE_CHANGE_CATEGORY: case CRED_PKGBASE_DELETE: diff --git a/web/lib/pkgbasefuncs.inc.php b/web/lib/pkgbasefuncs.inc.php index 0d6b22b..cf0b09b 100644 --- a/web/lib/pkgbasefuncs.inc.php +++ b/web/lib/pkgbasefuncs.inc.php @@ -25,10 +25,11 @@ function pkgbase_categories() { * Get the number of non-deleted comments for a specific package base * * @param string $base_id The package base ID to get comment count for + * @param bool $include_deleted True if deleted comments should be included * * @return string The number of comments left for a specific package */ -function pkgbase_comments_count($base_id) { +function pkgbase_comments_count($base_id, $include_deleted) { $base_id = intval($base_id); if (!$base_id) { return null; @@ -37,7 +38,9 @@ function pkgbase_comments_count($base_id) { $dbh = DB::connect(); $q = "SELECT COUNT(*) FROM PackageComments "; $q.= "WHERE PackageBaseID = " . $base_id . " "; - $q.= "AND DelUsersID IS NULL"; + if (!$include_deleted) { + $q.= "AND DelUsersID IS NULL"; + } $result = $dbh->query($q); if (!$result) { return null; @@ -51,10 +54,11 @@ function pkgbase_comments_count($base_id) { * * @param int $base_id The package base ID to get comments for * @param int $limit Maximum number of comments to return (0 means unlimited) + * @param bool $include_deleted True if deleted comments should be included * * @return array All package comment information for a specific package base */ -function pkgbase_comments($base_id, $limit) { +function pkgbase_comments($base_id, $limit, $include_deleted) { $base_id = intval($base_id); $limit = intval($limit); if (!$base_id) { @@ -63,10 +67,13 @@ function pkgbase_comments($base_id, $limit) { $dbh = DB::connect(); $q = "SELECT PackageComments.ID, UserName, UsersID, Comments, "; - $q.= "CommentTS FROM PackageComments LEFT JOIN Users "; + $q.= "CommentTS, DelUsersID FROM PackageComments LEFT JOIN Users "; $q.= "ON PackageComments.UsersID = Users.ID "; $q.= "WHERE PackageBaseID = " . $base_id . " "; - $q.= "AND DelUsersID IS NULL ORDER BY CommentTS DESC"; + if (!$include_deleted) { + $q.= "AND DelUsersID IS NULL "; + } + $q.= "ORDER BY CommentTS DESC"; if ($limit > 0) { $q.=" LIMIT " . $limit; } @@ -242,7 +249,8 @@ function pkgbase_display_details($base_id, $row, $SID="") { } $limit = isset($_GET['comments']) ? 0 : 10; - $comments = pkgbase_comments($base_id, $limit); + $include_deleted = has_credential(CRED_COMMENT_VIEW_DELETED); + $comments = pkgbase_comments($base_id, $limit, $include_deleted); if (!empty($comments)) { include('pkg_comments.php'); } diff --git a/web/lib/pkgfuncs.inc.php b/web/lib/pkgfuncs.inc.php index 8c2a67d..69b1c94 100644 --- a/web/lib/pkgfuncs.inc.php +++ b/web/lib/pkgfuncs.inc.php @@ -436,7 +436,8 @@ function pkg_display_details($id=0, $row, $SID="") { } $limit = isset($_GET['comments']) ? 0 : 10; - $comments = pkgbase_comments($base_id, $limit); + $include_deleted = has_credential(CRED_COMMENT_VIEW_DELETED); + $comments = pkgbase_comments($base_id, $limit, $include_deleted); if (!empty($comments)) { include('pkg_comments.php'); } diff --git a/web/template/pkg_comments.php b/web/template/pkg_comments.php index 9961554..3e99d9b 100644 --- a/web/template/pkg_comments.php +++ b/web/template/pkg_comments.php @@ -6,7 +6,8 @@ if (isset($row['BaseID'])) { /* On a package base details page. */ $base_id = $row['ID']; } -$count = pkgbase_comments_count($base_id); +$include_deleted = has_credential(CRED_COMMENT_VIEW_DELETED); +$count = pkgbase_comments_count($base_id, $include_deleted); ?> <div id="news"> <h3> @@ -18,8 +19,8 @@ $count = pkgbase_comments_count($base_id); <?php if ($row['UserName'] && $SID): $row['UserName'] = "<a href=\"" . get_user_uri($row['UserName']) . "\">{$row['UserName']}</a>"; endif; ?> - <h4> - <?php if (can_delete_comment_array($row)): ?> + <h4<?php if ($row['DelUsersID']): ?> class="comment-deleted"<?php endif; ?>> + <?php if (!$row['DelUsersID'] && can_delete_comment_array($row)): ?> <form method="post" action="<?= htmlspecialchars(get_pkgbase_uri($pkgbase_name), ENT_QUOTES); ?>"> <fieldset style="display:inline;"> <input type="hidden" name="action" value="do_DeleteComment" /> @@ -39,10 +40,13 @@ $count = pkgbase_comments_count($base_id); <?php else: ?> <?= __('Anonymous comment') ?> <?php endif; ?> + <?php if ($row['DelUsersID']): ?> + (<?= __('deleted') ?>) + <?php endif; ?> <?php endif; ?> </h4> <p class="timestamp"><?= gmdate('Y-m-d H:i', $row['CommentTS']) ?></p> - <div class="article-content"> + <div class="article-content<?php if ($row['DelUsersID']): ?> comment-deleted<?php endif; ?>"> <p> <?= parse_comment($row['Comments']) ?> </p> -- 2.0.2

4 9

[aur-dev] AUR 3.4.0 released
by Lukas Fleischer 28 Jul '14

28 Jul '14

Hello, I am pleased to announce that AUR 3.4.0 has been released. The official AUR setup [1] has already been updated. This release includes several improvements to the package request feature and a couple of bug fixes. The PKGBUILD parser has been dropped, you can no longer upload source packages without meta data. Also, a new user group "Trusted User & Developer" was added. I already converted a couple of accounts to the new group; please let me know if I missed anyone. For a comprehensive list of changes, please consult the Git log [2]. As usual, bugs should be reported to the AUR bug tracker [3]. [1] https://aur.archlinux.org/ [2] https://projects.archlinux.org/aur.git/log/?id=v3.4.0 [3] https://bugs.archlinux.org/index.php?project=2

1 0

[aur-dev] [PATCH] Auto-generate po/POTFILES
by Lukas Fleischer 27 Jul '14

27 Jul '14

Reduce maintenance costs by auto-generating po/POTFILES in the Makefile. Signed-off-by: Lukas Fleischer <archlinux(a)cryptocrack.de> --- .gitignore | 1 + po/Makefile | 7 +++++-- po/POTFILES | 58 ---------------------------------------------------------- 3 files changed, 6 insertions(+), 60 deletions(-) delete mode 100644 po/POTFILES diff --git a/.gitignore b/.gitignore index 11e9b7e..ed22497 100644 --- a/.gitignore +++ b/.gitignore @@ -9,3 +9,4 @@ dummy-data.sql* web/locale/*/ po/*.mo po/*.po~ +po/POTFILES diff --git a/po/Makefile b/po/Makefile index 97e1822..49eab32 100644 --- a/po/Makefile +++ b/po/Makefile @@ -44,7 +44,10 @@ all: ${MOFILES} lang=`echo $@ | sed -e 's/\.po-update$$//'`; \ msgmerge -U --no-location --lang="$$lang" $< aur.pot -update-pot: +POTFILES: + find ../web -type f -name '*.php' -printf '%P\n' | sort >POTFILES + +update-pot: POTFILES pkgname=AUR; \ pkgver=`sed -n 's/.*"AUR_VERSION", "$.*$".*/\1/p' ../web/lib/version.inc.php`; \ xgettext --default-domain=aur -L php --keyword=__ --keyword=_n:1,2 \ @@ -57,7 +60,7 @@ update-po: ${MAKE} ${UPDATEPOFILES} clean: - rm -f *.mo *.po\~ + rm -f *.mo *.po\~ POTFILES install: all for l in ${LOCALES}; do mkdir -p ${DESTDIR}${PREFIX}/$$l/LC_MESSAGES/; done diff --git a/po/POTFILES b/po/POTFILES deleted file mode 100644 index 2b9322b..0000000 --- a/po/POTFILES +++ /dev/null @@ -1,58 +0,0 @@ -html/404.php -html/account.php -html/addvote.php -html/home.php -html/index.php -html/login.php -html/logout.php -html/packages.php -html/passreset.php -html/pkgbase.php -html/pkgdel.php -html/pkgmerge.php -html/pkgreq.php -html/pkgsubmit.php -html/rpc.php -html/rss.php -html/tu.php -html/voters.php -lib/acctfuncs.inc.php -lib/Archive/PEAR5.php -lib/Archive/PEAR.php -lib/Archive/Tar.php -lib/aur.inc.php -lib/aurjson.class.php -lib/cachefuncs.inc.php -lib/DB.class.php -lib/feedcreator.class.php -lib/gettext.php -lib/pkgbasefuncs.inc.php -lib/pkgfuncs.inc.php -lib/pkgreqfuncs.inc.php -lib/routing.inc.php -lib/stats.inc.php -lib/streams.php -lib/translator.inc.php -lib/version.inc.php -template/account_delete.php -template/account_details.php -template/account_edit_form.php -template/account_search_results.php -template/actions_form.php -template/footer.php -template/header.php -template/pkgbase_details.php -template/pkg_comment_form.php -template/pkg_comments.php -template/pkg_details.php -template/pkgreq_form.php -template/pkgreq_results.php -template/pkg_search_form.php -template/pkg_search_results.php -template/search_accounts_form.php -template/stats/general_stats_table.php -template/stats/updates_table.php -template/stats/user_table.php -template/tu_details.php -template/tu_last_votes_list.php -template/tu_list.php -- 2.0.3

1 0

[aur-dev] [HEADS-UP] Meta data and split package support in the AUR
by Lukas Fleischer 27 Jul '14

27 Jul '14

Hello, I plan to do the next major AUR release by late May or June and I thought this might be a good time to let people know what is going on behind the scenes. AUR 3.0.0 will be able to read metadata from source packages. These metadata will be read from a file called .AURINFO (contained in the source tarball). Dave wrote several tools [1], including mkaurball which can be used to automatically build a source tarball with metadata so you don't need to worry about creating this file on your own. Having this information available means that: 1. We can drop the PKGBUILD parser from the AUR. The parser will still be available in the upcoming release but it will be marked as deprecated and a warning will be displayed whenever someone tries to upload a source tarball without metadata. 2. We can implement other things that were blocked by the AUR PKGBUILD parser being incomplete and inaccurate. Specifically, the next release will support split packages. Things that are on our TODO list: * Test the new AUR code. The split package code is still experimental. * Fix and extend the AUR RPC interface. * Test Dave's pkgbuild-introspection. * Move pkgbuild-introspection (or at least mkaurball) to [community]. It would also be nice to get metadata generation integrated into makepkg so that people no longer need to install mkaurball to generate source tarballs for the AUR. Regards, Lukas [1] https://github.com/falconindy/pkgbuild-introspection

1 1

[aur-dev] [PATCH] Do not allow regular users to edit all accounts
by Lukas Fleischer 25 Jul '14

25 Jul '14

Fixes a regression introduced in 03c6304 (Rework permission handling, 2014-07-15). Signed-off-by: Lukas Fleischer <archlinux(a)cryptocrack.de> --- web/lib/acctfuncs.inc.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/lib/acctfuncs.inc.php b/web/lib/acctfuncs.inc.php index 943e80b..6232f83 100644 --- a/web/lib/acctfuncs.inc.php +++ b/web/lib/acctfuncs.inc.php @@ -1123,6 +1123,6 @@ function can_edit_account($acctinfo) { return has_credential(CRED_ACCOUNT_EDIT_DEV); } - $uid = uid_from_sid($_COOKIE['AURSID']); + $uid = $acctinfo['ID']; return has_credential(CRED_ACCOUNT_EDIT, array($uid)); } -- 2.0.2

1 0

[aur-dev] [PATCH 1/2] Clean up user references in user_delete()
by Lukas Fleischer 25 Jul '14

25 Jul '14

Explicitly clean up all references before deleting a user. Signed-off-by: Lukas Fleischer <archlinux(a)cryptocrack.de> --- web/lib/acctfuncs.inc.php | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) diff --git a/web/lib/acctfuncs.inc.php b/web/lib/acctfuncs.inc.php index 73d01a5..943e80b 100644 --- a/web/lib/acctfuncs.inc.php +++ b/web/lib/acctfuncs.inc.php @@ -829,6 +829,41 @@ function user_suspended($id) { */ function user_delete($id) { $dbh = DB::connect(); + $id = intval($id); + + /* + * These are normally already taken care of by propagation constraints + * but it is better to be explicit here. + */ + $fields_delete = array( + array("Sessions", "UsersID"), + array("PackageVotes", "UsersID"), + array("CommentNotify", "UsersID") + ); + + $fields_set_null = array( + array("PackageBases", "SubmitterUID"), + array("PackageBases", "MaintainerUID"), + array("PackageBases", "SubmitterUID"), + array("PackageComments", "UsersID"), + array("PackageComments", "DelUsersID"), + array("PackageRequests", "UsersID"), + array("TU_VoteInfo", "SubmitterID"), + array("TU_Votes", "UserID") + ); + + foreach($fields_delete as list($table, $field)) { + $q = "DELETE FROM " . $table . " "; + $q.= "WHERE " . $field . " = " . $id; + $dbh->query($q); + } + + foreach($fields_set_null as list($table, $field)) { + $q = "UPDATE " . $table . " SET " . $field . " = NULL "; + $q.= "WHERE " . $field . " = " . $id; + $dbh->query($q); + } + $q = "DELETE FROM Users WHERE ID = " . $id; $dbh->query($q); return; -- 2.0.2

1 1

[aur-dev] [PATCH] po/POTFILES: Remove pkgbuild-parser.inc.php
by Lukas Fleischer 23 Jul '14

23 Jul '14

Signed-off-by: Lukas Fleischer <archlinux(a)cryptocrack.de> --- po/POTFILES | 1 - 1 file changed, 1 deletion(-) diff --git a/po/POTFILES b/po/POTFILES index a37384e..1b4d6a6 100644 --- a/po/POTFILES +++ b/po/POTFILES @@ -27,7 +27,6 @@ lib/DB.class.php lib/feedcreator.class.php lib/gettext.php lib/pkgbasefuncs.inc.php -lib/pkgbuild-parser.inc.php lib/pkgfuncs.inc.php lib/pkgreqfuncs.inc.php lib/routing.inc.php -- 2.0.2

1 0

[aur-dev] [PATCH] Prevent from merging a package base with itself
by Lukas Fleischer 23 Jul '14

23 Jul '14

Instead of deleting the package, show an error message if a user tries to merge a package base with itself. Signed-off-by: Lukas Fleischer <archlinux(a)cryptocrack.de> --- web/html/pkgbase.php | 11 +++++++---- web/lib/pkgreqfuncs.inc.php | 4 ++++ 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/web/html/pkgbase.php b/web/html/pkgbase.php index 4f35a67..691639c 100644 --- a/web/html/pkgbase.php +++ b/web/html/pkgbase.php @@ -69,12 +69,15 @@ if (check_token()) { } else { $merge_base_id = pkgbase_from_name($_POST['merge_Into']); - if ($merge_base_id) { - list($ret, $output) = pkgbase_delete($ids, $merge_base_id, $via); - unset($_GET['ID']); - } else { + if (!$merge_base_id) { $output = __("Cannot find package to merge votes and comments into."); $ret = false; + } elseif (in_array($merge_base_id, $ids)) { + $output = __("Cannot merge a package base with itself."); + $ret = false; + } else { + list($ret, $output) = pkgbase_delete($ids, $merge_base_id, $via); + unset($_GET['ID']); } } } diff --git a/web/lib/pkgreqfuncs.inc.php b/web/lib/pkgreqfuncs.inc.php index 41d1515..8fba838 100644 --- a/web/lib/pkgreqfuncs.inc.php +++ b/web/lib/pkgreqfuncs.inc.php @@ -110,6 +110,10 @@ function pkgreq_file($ids, $type, $merge_into, $comments) { $base_id = intval($ids[0]); $pkgbase_name = pkgbase_name_from_id($base_id); + if ($merge_into == $pkgbase_name) { + return array(false, __("Cannot merge a package base with itself.")); + } + $q = "SELECT ID FROM RequestTypes WHERE Name = " . $dbh->quote($type); $result = $dbh->query($q); if ($row = $result->fetch(PDO::FETCH_ASSOC)) { -- 2.0.2

1 0