June 2015 - Aur-dev - lists.archlinux.org

[aur-dev] [PATCH] aurjson.class.php: Exclude hidden package bases
by Lukas Fleischer 09 Jun '15

09 Jun '15

Do not return packages belonging to hidden package bases in RPC results. Fixes FS#45271. Signed-off-by: Lukas Fleischer <lfleischer(a)archlinux.org> --- web/lib/aurjson.class.php | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/web/lib/aurjson.class.php b/web/lib/aurjson.class.php index 745947e..5fb89a9 100644 --- a/web/lib/aurjson.class.php +++ b/web/lib/aurjson.class.php @@ -207,6 +207,7 @@ class AurJSON { "LEFT JOIN Licenses " . "ON Licenses.ID = PackageLicenses.LicenseID " . "WHERE ${where_condition} " . + "AND PackageBases.PackagerUID IS NOT NULL " . "GROUP BY Packages.ID " . "LIMIT $max_results"; } elseif ($this->version >= 2) { @@ -217,6 +218,7 @@ class AurJSON { "LEFT JOIN Users " . "ON PackageBases.MaintainerUID = Users.ID " . "WHERE ${where_condition} " . + "AND PackageBases.PackagerUID IS NOT NULL " . "LIMIT $max_results"; } $result = $this->dbh->query($query); @@ -391,9 +393,13 @@ class AurJSON { * @return string The JSON formatted response data. */ private function suggest($search) { - $query = 'SELECT Name FROM Packages WHERE Name LIKE ' . - $this->dbh->quote(addcslashes($search, '%_') . '%') . - ' ORDER BY Name ASC LIMIT 20'; + $query = "SELECT Packages.Name FROM Packages "; + $query.= "LEFT JOIN PackageBases "; + $query.= "ON PackageBases.ID = Packages.PackageBaseID "; + $query.= "WHERE Packages.Name LIKE "; + $query.= $this->dbh->quote(addcslashes($search, '%_') . '%'); + $query.= " AND PackageBases.PackagerUID IS NOT NULL "; + $query.= "ORDER BY Name ASC LIMIT 20"; $result = $this->dbh->query($query); $result_array = array(); @@ -413,9 +419,10 @@ class AurJSON { * @return string The JSON formatted response data. */ private function suggest_pkgbase($search) { - $query = 'SELECT Name FROM PackageBases WHERE Name LIKE ' . - $this->dbh->quote(addcslashes($search, '%_') . '%') . - ' ORDER BY Name ASC LIMIT 20'; + $query = "SELECT Name FROM PackageBases WHERE Name LIKE "; + $query.= $this->dbh->quote(addcslashes($search, '%_') . '%'); + $query.= " AND PackageBases.PackagerUID IS NOT NULL "; + $query.= "ORDER BY Name ASC LIMIT 20"; $result = $this->dbh->query($query); $result_array = array(); -- 2.4.2

1 0

[aur-dev] [PATCH] git-update: Avoid duplicate notifications
by Lukas Fleischer 08 Jun '15

08 Jun '15

Fixes FS#45254. Signed-off-by: Lukas Fleischer <lfleischer(a)archlinux.org> --- git-interface/git-update.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/git-interface/git-update.py b/git-interface/git-update.py index 215848e..958fa7a 100755 --- a/git-interface/git-update.py +++ b/git-interface/git-update.py @@ -144,8 +144,12 @@ def save_srcinfo(srcinfo, db, cur, user): # Add user to notification list on adoption. if was_orphan: - cur.execute("INSERT INTO CommentNotify (PackageBaseID, UserID) " + - "VALUES (%s, %s)", [pkgbase_id, user_id]) + cur.execute("SELECT COUNT(*) FROM CommentNotify WHERE " + + "PackageBaseID = %s AND UserID = %s", + [pkgbase_id, user_id]) + if cur.fetchone()[0] == 0: + cur.execute("INSERT INTO CommentNotify (PackageBaseID, UserID) " + + "VALUES (%s, %s)", [pkgbase_id, user_id]) db.commit() -- 2.4.2

1 0

[aur-dev] [PATCH] Fix searching for an empty string
by Lukas Fleischer 08 Jun '15

08 Jun '15

Return all packages when an empty search term is used with keyword search. Reported-by: G. Schlisio <g.schlisio(a)dukun.de> Signed-off-by: Lukas Fleischer <lfleischer(a)archlinux.org> --- web/lib/pkgfuncs.inc.php | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/web/lib/pkgfuncs.inc.php b/web/lib/pkgfuncs.inc.php index ee63e42..1178550 100644 --- a/web/lib/pkgfuncs.inc.php +++ b/web/lib/pkgfuncs.inc.php @@ -602,7 +602,7 @@ function pkg_search_page($SID="") { else { /* Search by name and description (default). */ $count = 0; - $q_where .= "AND ("; + $q_keywords = ""; $op = ""; foreach (str_getcsv($_GET['K'], ' ') as $term) { @@ -623,8 +623,8 @@ function pkg_search_page($SID="") { } $term = "%" . addcslashes($term, '%_') . "%"; - $q_where .= $op . " (Packages.Name LIKE " . $dbh->quote($term) . " OR "; - $q_where .= "Description LIKE " . $dbh->quote($term) . ") "; + $q_keywords .= $op . " (Packages.Name LIKE " . $dbh->quote($term) . " OR "; + $q_keywords .= "Description LIKE " . $dbh->quote($term) . ") "; $count++; if ($count >= 20) { @@ -633,7 +633,9 @@ function pkg_search_page($SID="") { $op = "AND "; } - $q_where .= ") "; + if (!empty($q_keywords)) { + $q_where .= "AND (" . $q_keywords . ") "; + } } } -- 2.4.2

1 0

[aur-dev] [PATCH] pkg_details: Use correct clone URL
by Johannes Löthberg 08 Jun '15

08 Jun '15

The clone URLs should use the pkgbase name, not the pkgname itself Reported-by: Jonathan Steel <jsteel(a)archlinux.org> Signed-off-by: Johannes Löthberg <johannes(a)kyriasis.com> --- web/template/pkg_details.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/web/template/pkg_details.php b/web/template/pkg_details.php index ceece87..14f8847 100644 --- a/web/template/pkg_details.php +++ b/web/template/pkg_details.php @@ -1,8 +1,8 @@ <?php $cgit_uri = config_get('options', 'cgit_uri'); -$git_clone_uri_anon = sprintf(config_get('options', 'git_clone_uri_anon'), htmlspecialchars($row['Name'])); -$git_clone_uri_priv = sprintf(config_get('options', 'git_clone_uri_priv'), htmlspecialchars($row['Name'])); +$git_clone_uri_anon = sprintf(config_get('options', 'git_clone_uri_anon'), htmlspecialchars($row['BaseName'])); +$git_clone_uri_priv = sprintf(config_get('options', 'git_clone_uri_priv'), htmlspecialchars($row['BaseName'])); $uid = uid_from_sid($SID); -- 2.4.2

2 1

[aur-dev] [PATCH] git-update: Drop writing git description file
by Johannes Löthberg 08 Jun '15

08 Jun '15

All PKGBUILDs are stored in a single repository now, so there is no use for writing out a description file for the repo anymore. This fixes a bug where pkgdescs containing UTF-8 characters are rejected due to it trying to write the file out using ASCII. Signed-off-by: Johannes Löthberg <johannes(a)kyriasis.com> --- git-interface/git-update.py | 6 ------ 1 file changed, 6 deletions(-) diff --git a/git-interface/git-update.py b/git-interface/git-update.py index 92953f6..2407188 100755 --- a/git-interface/git-update.py +++ b/git-interface/git-update.py @@ -280,9 +280,3 @@ for pkgname in srcinfo.GetPackageNames(): save_srcinfo(srcinfo, db, cur, user) db.close() - -pkglist = list(srcinfo.GetPackageNames()) -if len(pkglist) > 0: - with open(repo_path + '/description', 'w') as f: - pkginfo = srcinfo.GetMergedPackage(pkglist[0]) - f.write(pkginfo['pkgdesc']) -- 2.4.2

2 1

[aur-dev] [PATCH] Fix package statistics
by Lukas Fleischer 08 Jun '15

08 Jun '15

Exclude hidden package bases from the package statistics. Reported-by: Johannes Löthberg <johannes(a)kyriasis.com> Signed-off-by: Lukas Fleischer <lfleischer(a)archlinux.org> --- web/lib/stats.inc.php | 34 ++++++++++++++++++++++++++-------- 1 file changed, 26 insertions(+), 8 deletions(-) diff --git a/web/lib/stats.inc.php b/web/lib/stats.inc.php index 1dcb9b9..6ca5011 100644 --- a/web/lib/stats.inc.php +++ b/web/lib/stats.inc.php @@ -35,12 +35,17 @@ function updates_table() { * @return void */ function user_table($userid) { - $base_q = "SELECT COUNT(*) FROM PackageBases WHERE MaintainerUID = " . $userid; + $base_q = "SELECT COUNT(*) FROM PackageBases "; + $base_q.= "WHERE MaintainerUID = " . $userid . " "; + $base_q.= "AND PackagerUID IS NOT NULL"; $maintainer_unsupported_count = db_cache_value($base_q, 'user_unsupported_count:' . $userid); - $q = "SELECT COUNT(*) FROM PackageBases WHERE OutOfDateTS IS NOT NULL AND MaintainerUID = " . $userid; + $q = "SELECT COUNT(*) FROM PackageBases "; + $q.= "WHERE OutOfDateTS IS NOT NULL "; + $q.= "AND MaintainerUID = " . $userid . " "; + $q.= "AND PackagerUID IS NOT NULL"; $flagged_outdated = db_cache_value($q, 'user_flagged_outdated:' . $userid); @@ -54,10 +59,12 @@ function user_table($userid) { */ function general_stats_table() { # AUR statistics - $q = "SELECT COUNT(*) FROM PackageBases"; + $q = "SELECT COUNT(*) FROM PackageBases WHERE PackagerUID IS NOT NULL"; $unsupported_count = db_cache_value($q, 'unsupported_count'); - $q = "SELECT COUNT(*) FROM PackageBases WHERE MaintainerUID IS NULL"; + $q = "SELECT COUNT(*) FROM PackageBases "; + $q.= "WHERE MaintainerUID IS NULL "; + $q.= "AND PackagerUID IS NOT NULL"; $orphan_count = db_cache_value($q, 'orphan_count'); $q = "SELECT count(*) FROM Users"; @@ -69,16 +76,27 @@ function general_stats_table() { $targstamp = intval(strtotime("-7 days")); $yearstamp = intval(strtotime("-1 year")); - $q = "SELECT COUNT(*) FROM PackageBases WHERE ModifiedTS >= $targstamp AND ModifiedTS = SubmittedTS"; + $q = "SELECT COUNT(*) FROM PackageBases "; + $q.= "WHERE ModifiedTS >= $targstamp "; + $q.= "AND ModifiedTS = SubmittedTS "; + $q.= "AND PackagerUID IS NOT NULL"; $add_count = db_cache_value($q, 'add_count'); - $q = "SELECT COUNT(*) FROM PackageBases WHERE ModifiedTS >= $targstamp AND ModifiedTS != SubmittedTS"; + $q = "SELECT COUNT(*) FROM PackageBases "; + $q.= "WHERE ModifiedTS >= $targstamp "; + $q.= "AND ModifiedTS != SubmittedTS "; + $q.= "AND PackagerUID IS NOT NULL"; $update_count = db_cache_value($q, 'update_count'); - $q = "SELECT COUNT(*) FROM PackageBases WHERE ModifiedTS >= $yearstamp AND ModifiedTS != SubmittedTS"; + $q = "SELECT COUNT(*) FROM PackageBases "; + $q.= "WHERE ModifiedTS >= $yearstamp "; + $q.= "AND ModifiedTS != SubmittedTS "; + $q.= "AND PackagerUID IS NOT NULL"; $update_year_count = db_cache_value($q, 'update_year_count'); - $q = "SELECT COUNT(*) FROM PackageBases WHERE ModifiedTS = SubmittedTS"; + $q = "SELECT COUNT(*) FROM PackageBases "; + $q.= "WHERE ModifiedTS = SubmittedTS "; + $q.= "AND PackagerUID IS NOT NULL"; $never_update_count = db_cache_value($q, 'never_update_count'); include('stats/general_stats_table.php'); -- 2.4.2

1 0

[aur-dev] [PATCH] Fix bug with extracting sources introduced in c7203066c
by Johannes Löthberg 08 Jun '15

08 Jun '15

In c7203066ce git-update was changed to use extract_arch_fields to get the list of sources instead of looking up them up in the pkginfo dict manually. This was done to solve a bug where only source=() sources were unconditionally checked for, ignoring arch-specific sources. The extract_arch_fields function returns a list of dicts however, so we need to extract the 'value' key from that dict before using it, which was missed in the previous commit. Fixes FS#45261 Signed-off-by: Johannes Löthberg <johannes(a)kyriasis.com> --- git-interface/git-update.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/git-interface/git-update.py b/git-interface/git-update.py index 92953f6..4177e53 100755 --- a/git-interface/git-update.py +++ b/git-interface/git-update.py @@ -247,7 +247,8 @@ for commit in walker: die_commit('missing %s file: %s' % (field, pkginfo[field]), commit.id) - for fname in extract_arch_fields(pkginfo, 'source'): + for field in extract_arch_fields(pkginfo, 'source'): + fname = field['value'] if "://" in fname or "lp:" in fname: continue if not fname in commit.tree: -- 2.4.2

2 1

[aur-dev] [PATCH] Show official language names in the drop-down list
by Lukas Fleischer 08 Jun '15

08 Jun '15

We already store the native language names. Display them in the drop-down list instead of using language codes. Signed-off-by: Lukas Fleischer <lfleischer(a)archlinux.org> --- web/template/header.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/template/header.php b/web/template/header.php index 3567536..874109a 100644 --- a/web/template/header.php +++ b/web/template/header.php @@ -42,7 +42,7 @@ print '<option value="' . htmlspecialchars($lang, ENT_QUOTES) . '"' . ($lang == $LANG ? ' selected="selected"' : '') . - '>' . htmlspecialchars($lang) . "</option>\n"; + '>' . htmlspecialchars($lang_name) . "</option>\n"; } ?> </select> -- 2.4.2

1 0

[aur-dev] [PATCH] git-update: Improve error message for non-blob objects
by Lukas Fleischer 08 Jun '15

08 Jun '15

When a repository contains a directory, a user is currently faced with the following error message: remote: Traceback (most recent call last): remote: File "hooks/update", line 194, in <module> remote: if repo[treeobj.id].size > 250000: remote: AttributeError: '_pygit2.Tree' object has no attribute 'size' remote: error: hook declined to update refs/heads/master Explicitly check for directories and other non-blob objects and display a more intuitive message. Signed-off-by: Lukas Fleischer <lfleischer(a)archlinux.org> --- git-interface/git-update.py | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/git-interface/git-update.py b/git-interface/git-update.py index 7ecffeb..92953f6 100755 --- a/git-interface/git-update.py +++ b/git-interface/git-update.py @@ -191,7 +191,16 @@ for commit in walker: die_commit("missing .SRCINFO", commit.id) for treeobj in commit.tree: - if repo[treeobj.id].size > 250000: + blob = repo[treeobj.id] + + if isinstance(blob, pygit2.Tree): + die_commit("the repository must not contain subdirectories", + commit.id) + + if not isinstance(blob, pygit2.Blob): + die_commit("not a blob object: %s" % (treeobj), commit.id) + + if blob.size > 250000: die_commit("maximum blob size (250kB) exceeded", commit.id) srcinfo_raw = repo[commit.tree['.SRCINFO'].id].data.decode() -- 2.4.2

1 0

[aur-dev] Please enable zh_TW locale on AUR
by 黃柏諺 08 Jun '15

08 Jun '15

As title says,please enable AUR's zh_TW locale,it should be 100% on Transifex now. :D

3 3