- Aur-dev - lists.archlinux.org

[aur-dev] Moving packages to Community
by Martti Kühne 07 Feb '11

07 Feb '11

Hello official and inofficial maintainers and AUR devs. Following the discussion in aur-general, I think some automation could solve many issues at once here. Justin Davis' community-blacklist patch is an approach in about the right direction.... although in relation to the discussion concerning these prevailing [more-official repo] adoption issues, it seems that it does not yet go far enough at the moment. There should be a redirection or at least a [we're-now-official] error page showing sort of "congratulations and sorry for the late notice" to the yet uninformed aur maintainer, if his package is not reachable any more because it was adopted in said [more-official repo] - along with this could be displayed the comments of the former package. As well, it could just become invisible in the package's search, and marked with a "I saw this" button in the former AUR maintainer's package list. When that button is clicked, the package would sink quietly into the official repo without anyone needing to complain. The only hurdle remaining is, that a package isn't up for deletion any more when it gets adopted to [more-official repo], because that could just be automated by the repo's backend maybe? I'm probably going to download the aur source inclusively Justin's approach to look into this a bit further. Even though my development skills aren't exactly in line with such a task, and if someone feels more confident, one may look into it h{im,er}self. I'd like to hear your comments on this well. cheers! mar77i

1 0

[aur-dev] AUR slow queries, stale database columns, etc.
by Dan McGee 04 Feb '11

04 Feb '11

LocationID, DummyPkg- are these used anymore on the Packages table? If not, getting rid of these would do wonders toward actually allowing MySQL to use indexes for some queries, which it has been unable to do for a long time. I've pasted some of the slow query log analysis below from stuff this month, it is pretty obvious where work should be focused. Killing these two fields and then replacing the SQL_CALC_FOUND_ROWS with a second count query should take care of nearly every slow query that currently happens. Also potentially worth attacking is the use of GREATEST(SubmittedTS,ModifiedTS) - since the wonderful MySQL has no functional indexes using this in a query as an order by clause results in full table scans. -Dan $ mysqldumpslow -s c sigurd-slow.log | head -n 100 Reading mysql slow query log from sigurd-slow.log Count: 3550 Time=2.08s (7390s) Lock=0.00s (3s) Rows=26.7 (94644), aur[aur]@localhost SELECT SQL_CALC_FOUND_ROWS Users.Username AS Maintainer, PackageCategories.Category, PackageLocations.Location, Packages.Name, Packages.Version, Packages.Description, Packages.NumVotes, Packages.ID, Packages.OutOfDate FROM Packages LEFT JOIN Users ON (Packages.MaintainerUID = Users.ID) LEFT JOIN PackageCategories ON (Packages.CategoryID = PackageCategories.ID) LEFT JOIN PackageLocations ON (Packages.LocationID = PackageLocations.ID) WHERE Packages.DummyPkg = N ORDER BY NumVotes DESC, Name ASC, CategoryID DESC LIMIT N, N Count: 2275 Time=1.38s (3143s) Lock=0.00s (0s) Rows=25.4 (57680), aur[aur]@localhost SELECT SQL_CALC_FOUND_ROWS CommentNotify.UserID AS Notify, PackageVotes.UsersID AS Voted, Users.Username AS Maintainer, PackageCategories.Category, PackageLocations.Location, Packages.Name, Packages.Version, Packages.Description, Packages.NumVotes, Packages.ID, Packages.OutOfDate FROM Packages LEFT JOIN Users ON (Packages.MaintainerUID = Users.ID) LEFT JOIN PackageVotes ON (Packages.ID = PackageVotes.PackageID AND PackageVotes.UsersID = N) LEFT JOIN CommentNotify ON (Packages.ID = CommentNotify.PkgID AND CommentNotify.UserID = N) LEFT JOIN PackageCategories ON (Packages.CategoryID = PackageCategories.ID) LEFT JOIN PackageLocations ON (Packages.LocationID = PackageLocations.ID) WHERE Packages.DummyPkg = N ORDER BY NumVotes DESC, Name ASC, CategoryID DESC LIMIT N, N Count: 350 Time=1.62s (566s) Lock=0.01s (1s) Rows=27.4 (9591), aur[aur]@localhost SELECT SQL_CALC_FOUND_ROWS Users.Username AS Maintainer, PackageCategories.Category, PackageLocations.Location, Packages.Name, Packages.Version, Packages.Description, Packages.NumVotes, Packages.ID, Packages.OutOfDate FROM Packages LEFT JOIN Users ON (Packages.MaintainerUID = Users.ID) LEFT JOIN PackageCategories ON (Packages.CategoryID = PackageCategories.ID) LEFT JOIN PackageLocations ON (Packages.LocationID = PackageLocations.ID) WHERE Packages.DummyPkg = N ORDER BY NumVotes ASC, Name ASC, CategoryID DESC LIMIT N, N Count: 307 Time=1.20s (368s) Lock=0.00s (0s) Rows=65.8 (20200), aur[aur]@localhost SELECT SQL_CALC_FOUND_ROWS CommentNotify.UserID AS Notify, PackageVotes.UsersID AS Voted, Users.Username AS Maintainer, PackageCategories.Category, PackageLocations.Location, Packages.Name, Packages.Version, Packages.Description, Packages.NumVotes, Packages.ID, Packages.OutOfDate FROM Packages LEFT JOIN Users ON (Packages.MaintainerUID = Users.ID) LEFT JOIN PackageVotes ON (Packages.ID = PackageVotes.PackageID AND PackageVotes.UsersID = N) LEFT JOIN CommentNotify ON (Packages.ID = CommentNotify.PkgID AND CommentNotify.UserID = N) LEFT JOIN PackageCategories ON (Packages.CategoryID = PackageCategories.ID) LEFT JOIN PackageLocations ON (Packages.LocationID = PackageLocations.ID) WHERE Packages.DummyPkg = N ORDER BY GREATEST(SubmittedTS,ModifiedTS) DESC, Name ASC, LocationID ASC LIMIT N, N Count: 220 Time=1.76s (386s) Lock=0.00s (0s) Rows=29.9 (6585), aur[aur]@localhost SELECT SQL_CALC_FOUND_ROWS Users.Username AS Maintainer, PackageCategories.Category, PackageLocations.Location, Packages.Name, Packages.Version, Packages.Description, Packages.NumVotes, Packages.ID, Packages.OutOfDate FROM Packages LEFT JOIN Users ON (Packages.MaintainerUID = Users.ID) LEFT JOIN PackageCategories ON (Packages.CategoryID = PackageCategories.ID) LEFT JOIN PackageLocations ON (Packages.LocationID = PackageLocations.ID) WHERE Packages.DummyPkg = N ORDER BY Name DESC, LocationID ASC, CategoryID DESC LIMIT N, N Count: 218 Time=1.31s (286s) Lock=0.00s (0s) Rows=28.1 (6122), aur[aur]@localhost SELECT SQL_CALC_FOUND_ROWS Users.Username AS Maintainer, PackageCategories.Category, PackageLocations.Location, Packages.Name, Packages.Version, Packages.Description, Packages.NumVotes, Packages.ID, Packages.OutOfDate FROM Packages LEFT JOIN Users ON (Packages.MaintainerUID = Users.ID) LEFT JOIN PackageCategories ON (Packages.CategoryID = PackageCategories.ID) LEFT JOIN PackageLocations ON (Packages.LocationID = PackageLocations.ID) WHERE Packages.DummyPkg = N ORDER BY Name ASC, LocationID ASC, CategoryID DESC LIMIT N, N Count: 187 Time=2.21s (413s) Lock=0.00s (0s) Rows=26.9 (5034), aur[aur]@localhost SELECT SQL_CALC_FOUND_ROWS Users.Username AS Maintainer, PackageCategories.Category, PackageLocations.Location, Packages.Name, Packages.Version, Packages.Description, Packages.NumVotes, Packages.ID, Packages.OutOfDate FROM Packages LEFT JOIN Users ON (Packages.MaintainerUID = Users.ID) LEFT JOIN PackageCategories ON (Packages.CategoryID = PackageCategories.ID) LEFT JOIN PackageLocations ON (Packages.LocationID = PackageLocations.ID) WHERE Packages.DummyPkg = N ORDER BY LocationID ASC, Name ASC, CategoryID DESC LIMIT N, N

3 6

[aur-dev] OpenSearch Description
by Cilyan Olowen 30 Jan '11

30 Jan '11

Hello everyone! It's been a long time that I wanted to do an OpenSearch shortcut to the AUR. I do an extensive use of search engines and keywords in my daily navigation and I was really missing one for AUR. So I wrote one, that was not so complex. :) I tested it using Firefox 3.6, so please test it a little bit more. To include the search engine in a web page for auto discovery, the HTML <head/> element should include a "profile" attribute that contains the value "http://a9.com/-/spec/opensearch/1.1/", and a <link/> tag such as <link rel="search" type="application/opensearchdescription+xml" href="http://path/to/aur-osd.xml" title="AUR Packages" /> (href must contain a complete uri, relative path doesn't seem to be supported) I set up a page so you can test it: http://www.cilyan.org/aurosd/aur-osd-link.html Once an appropriate keyword is set up in Ff "Manage search engines", finding a package on AUR is now as simple as typing "aur <package>" in the address bar! Best regards, Cilyan

2 2

[aur-dev] [PATCH] Do not overwrite package details when adding comments (fixes FS#22075).
by Lukas Fleischer 25 Jan '11

25 Jan '11

Ensure that the "$row" variable isn't overwritten in "web/template/pkg_comment_form.php" during sending mail notifications when adding a comment. --- web/template/pkg_comment_form.php | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/web/template/pkg_comment_form.php b/web/template/pkg_comment_form.php index 70570da..368d49b 100644 --- a/web/template/pkg_comment_form.php +++ b/web/template/pkg_comment_form.php @@ -25,7 +25,7 @@ if (isset($_REQUEST['comment'])) { array_push($bcc, $row['Email']); } - $q = 'SELECT Packages.Name '; + $q = 'SELECT Packages.* '; $q.= 'FROM Packages '; $q.= 'WHERE Packages.ID = ' . intval($_REQUEST['ID']); $result = db_query($q, $dbh); -- 1.7.3.5

1 1

[aur-dev] [PATCH] Make external links in comments clickable (FS#20137).
by Lukas Fleischer 25 Jan '11

25 Jan '11

This is a bit hacky patch to make links in AUR comments clickable (fixes FS#20137 [1]). Huge parts of this code are ripped from the DokuWiki plugin that is also used in Flyspray. I didn't have any time to test it extensively so I'd suggest to do some more tests if this will be commited. [1] https://bugs.archlinux.org/task/20137 --- web/lib/aur.inc | 45 +++++++++++++++++++++++++++++++++++++++++ web/template/pkg_comments.php | 2 +- 2 files changed, 46 insertions(+), 1 deletions(-) diff --git a/web/lib/aur.inc b/web/lib/aur.inc index bd69c4c..b0cfdc8 100644 --- a/web/lib/aur.inc +++ b/web/lib/aur.inc @@ -494,3 +494,48 @@ function salted_hash($passwd, $salt) } return md5($salt . $passwd); } + +function parse_link($matches) +{ + $name = $url = $matches[0]; + + if(substr($url, 0, 3) == 'ftp' && (substr($url, 0, 6) != 'ftp://')) { + $url = 'ftp://'.$url; + } + elseif (substr($url, 0, 3) == 'www') { + $url = 'http://'.$url; + } + + $url = str_replace('&', '&', $url); + $url = str_replace('&amp;', '&', $url); + $url = strtr($url, array('>' => '%3E', '<' => '%3C', '"' => '%22')); + + return '<a href="' . $url . '">' . $name . '</a>'; +} + +function parse_comment($comment) +{ + $schemes = array('http', 'https', 'ftp'); + $ltrs = '\w'; + $gunk = '\/\#~:.?+=&%@!\-'; + $punc = '.:?\-;,'; + $host = $ltrs . $punc; + $any = $ltrs . $gunk . $punc; + + $patterns = array(); + + foreach ($schemes as $scheme) { + $patterns[] = '(\b(?i)' . $scheme . '(?-i):\/\/[' . $any . ']+?(?=[' . $punc . ']*[^' . $any . ']))'; + } + + $patterns[] = '(\b(?i)www?(?-i)\.[' . $host . ']+?\.[' . $host . ']+?[' . $any . ']+?(?=[' . $punc . ']*[^' . $any . ']))'; + $patterns[] = '(\b(?i)ftp?(?-i)\.['. $host . ']+?\.[' . $host . ']+?[' . $any . ']+?(?=[' . $punc . ']*[^' . $any . ']))'; + + $regex = '/' . implode('|', $patterns) . '/msS'; + + $comment = htmlspecialchars($comment); + $comment = preg_replace_callback($regex, parse_link, $comment . "\n"); + $comment = nl2br($comment); + + return $comment; +} diff --git a/web/template/pkg_comments.php b/web/template/pkg_comments.php index 02171a0..2ca9bf0 100644 --- a/web/template/pkg_comments.php +++ b/web/template/pkg_comments.php @@ -20,7 +20,7 @@ while (list($indx, $carr) = each($comments)) { ?> ?></div> <blockquote class="comment-body"> <div> -<?php echo nl2br(htmlspecialchars($carr['Comments'])) ?> +<?php echo parse_comment($carr['Comments']) ?> </div> </blockquote> <?php -- 1.7.3

4 15

Re: [aur-dev] Request to drop keditbookmarks-svn
by Konor John 04 Jan '11

04 Jan '11

keditbookmarks is too small and not active developed application, so i think that keditbookmarks-svn isn't needed in aur. Additionally, PKGBUILD code is too ugly 04.01.2011, 14:24, "Andrea Scarpino" <andrea(a)archlinux.org>: > On Tuesday 04 January 2011 21:18:21 Joker-jar wrote: > >> Today i recieve mail: >>> AUR Comment for keditbookmarks >>> >>> duplicate of kdebase-keditbookmarks. deleted >> So, delete keditbookmarks-svn also. I'm author of package. Thanks > > keditbookmarks-svn is keditbookmarks from SVN not the stable version thus I > didn't delete it. > Are you sure you want to delete it? > > PS. Moving to aur-general which is the right place for these things. > > -- > Andrea Scarpino > Arch Linux Developer

1 0

[aur-dev] Request to drop keditbookmarks-svn
by Joker-jar 04 Jan '11

04 Jan '11

Today i recieve mail: > AUR Comment for keditbookmarks > > duplicate of kdebase-keditbookmarks. deleted So, delete keditbookmarks-svn also. I'm author of package. Thanks

2 1

Re: [aur-dev] Checking packages names against official repos in the AUR when uploading
by Loui Chang 18 Dec '10

18 Dec '10

On Thu 16 Dec 2010 10:35 +0100, Lukas Fleischer wrote: > Hi, Loui! > > I'm recently having a look at FS#12902 [1]. It's about comparing names > to the official repo databases when uploading a package. I think that > would be really easy to implement if we have an additional directory > where we put repo databases and keep them in sync using a `pacman -Sy` > cronjob or something similar. Parsing the databases is very easy using > Archive_Tar (which we already use anyways) as well. Only thing I don't > like about that is the delay caused by mirrors and the cronjob which > will be a problem if we decide to move a package from the official repos > to [unsupported]. > > What do you think about that? Should we implement this at all? :) > > [1] https://bugs.archlinux.org/task/12902 Hello Mr Fleischer! Yeah I think it should be implemented. We can check the local sync database (or point it to any arbitrary pacman database in config.inc) and create dummy entries for packages that are already in the binary repos. To get around the problem of moving packages to [unsupported] we can make the upload restriction exempt for Trusted Users, since they'll probably be the ones moving the packages and should be trusted to check the binary repos before submitting to the AUR. You should send this to the mailing list too! CCd Cheers.

1 0

[aur-dev] [PATCH] Do not display current votes in All Votes
by Andrea Scarpino 05 Dec '10

05 Dec '10

Subject says everything. -- Andrea Scarpino Arch Linux Developer

3 4

[aur-dev] genpopo, translation_tool python2
by jesse jaara 04 Dec '10

04 Dec '10

Make genpopo and translation_tool scripts to use python2 instead of now default python3. Hopely someone will convert these to python3 compliant form. -- (\_ /) copy the bunny to your profile (0.o ) to help him achieve world domination. (> <) come join the dark side. /_|_\ (we have cookies.)

2 1