- Aur-dev - lists.archlinux.org

[aur-dev] incorrect info in some old database entries?
by Christopher Brannon 02 Nov '10

02 Nov '10

Hello, I'm looking at two bug reports: <https://bugs.archlinux.org/task/15308> and <https://bugs.archlinux.org/task/19327>. The latter is a duplicate of the former. Apparently, URLpath is incorrect for several packages in the Packages table. Would someone with access to the AUR database mind running the attached Python script? It'll produce a file named bad_pkgs.txt, which I want to see. -- Chris

1 0

[aur-dev] bold title bar
by Martti Kühne 30 Oct '10

30 Oct '10

btw... when is the title bar update to be made? this is still irritating, and also users who have non-white background colors will be confused by the current layout. just to bring in my own shards of critics, aur is pretty cool so far... keep up the greatest repo ever! mar77i

3 2

[aur-dev] vim-vimoutliner
by karl 20 Oct '10

20 Oct '10

Dear all, I just wanted to update and takeover vim-vimoutliner. But instead I found out, the project is dead and the software can't be downloaded anymore from http://vimdownload.org. The AUR package for it's installation should be deleted. http://aur.archlinux.org/packages.php?ID=30302 Kind regards, Karl

2 1

[aur-dev] TRANSLATION: zh_CN updated
by Mod Gao 09 Oct '10

09 Oct '10

Hi, this is updated zh_CN translation, many strings changed and some string leave un-translated since last time, so today i think it's time to update it:) I tested with localhost:80 LAMP and everything seems perfect. and there is a problem: the "Bad username or password." string in web/lib/acctfuncs.inc don't got translated. and i changed my e-mail address to usrgdd (b) gmail, so i changed it in translation file also, just as proof:) attachment is git patch.

4 4

[aur-dev] [PATCH] Move deletion proposal code from pkgfuncs.inc to pkgedit.php and add mechanism for dealing with reasons for deletion.
by Peter Lewis 08 Oct '10

08 Oct '10

--- web/html/pkgedit.php | 210 ++++++++++++++++++++++++++++++++++++++++++++++++++ web/lib/pkgfuncs.inc | 42 ++-------- 2 files changed, 218 insertions(+), 34 deletions(-) diff --git a/web/html/pkgedit.php b/web/html/pkgedit.php index 0339d00..f04e816 100644 --- a/web/html/pkgedit.php +++ b/web/html/pkgedit.php @@ -103,6 +103,216 @@ if ($_REQUEST["change_Category"]) { exit(); } +# Propose deletion of package +# +# valid reasons are: +# - sources no longer available [nosource], +# - no longer builds on current systems (and cannot reasonably be patched) [wontbuild], +# - duplicated elsewhere in the repos [dupe], +# - name or source control system changed (e.g. from svn to git) [namechange] +# +if ($_REQUEST["propose_Deletion"]) { + + if ($_REQUEST["CONFIRM"] && ($_REQUEST["NOSOURCE"] || $_REQUEST["WONTBUILD"] || $_REQUEST["DUPE"] || $_REQUEST["NAMECHANGE"]) ) { + # The user confirmed and we have at least one reason - go ahead and do it + + $dbh = db_connect(); + + # Get details of the user who proposed the deletion + $f_name = username_from_sid($_COOKIE['AURSID']); + $f_email = email_from_sid($_COOKIE['AURSID']); + $f_uid = uid_from_sid($_COOKIE['AURSID']); + + # Get package name + $q = "SELECT Packages.Name "; + $q.= "FROM Packages "; + $q.= "WHERE Packages.ID = " . $_REQUEST['ID']; + + $result = db_query($q, $dbh); + + # If this is false, then something has gone wrong (i.e. the package got deleted while you were doing this) + if (!mysql_num_rows($result)) { + print __("Oops, something went wrong and the package no longer seems to exist!"); + exit(); + } + + $row = mysql_fetch_assoc($result); + + # Send a message to aur-general + $body = "The AUR package " . $row['Name'] . " has been proposed for deletion by " . $f_name . " [1].\n\n"; + $body.= "You may view the package at:\nhttp://aur.archlinux.org/packages.php?ID=" . $_REQUEST['ID'] . "\n\n"; + + $body.= "The reason(s) given were:\n"; + if ($_REQUEST['NOSOURCE']) { + $body.= " - The sources are no longer available.\n"; + } + if ($_REQUEST['WONTBUILD']) { + $body.= " - The package no longer builds on current systems.\n"; + } + if ($_REQUEST['DUPE']) { + $body.= " - The package is duplicated elsewhere.\n"; + } + if ($_REQUEST['NAMECHANGE']) { + $body.= " - The package's name has changed, and a new package replaces it.\n"; + } + + $body.= "\nThe proposer added the following details:\n"; + $body.= $_REQUEST['REASONTEXT']."\n\n"; + + + $body.= "[1] - http://aur.archlinux.org/account.php?Action=AccountInfo&ID=" . $f_uid; + + + $body = wordwrap($body, 70); + $headers = "Reply-to: nobody@archlinux.org\nFrom:aur-notify@archlinux.org\nX-Mailer: PHP\nX-MimeOLE: Produced By AUR\n"; + + # TODO: add the real aur-general(a)archlinux.org address here when done with testing + @mail('aur-general(a)__REMOVE_ME__archlinux.org', "AUR Package Deletion Proposal for ".$row['Name'], $body, $headers); + + + + # Notify maintainer of package by email + $q = "SELECT Packages.Name, Users.Email "; + $q.= "FROM Packages, Users "; + $q.= "WHERE Packages.ID = " . $_REQUEST['ID'] ." "; + $q.= "AND Users.ID = Packages.MaintainerUID"; + + $result = db_query($q, $dbh); + + # If this is false, then the package has no maintainer, so there's no email to send + if (mysql_num_rows($result)) { + $row = mysql_fetch_assoc($result); + + # construct email - maintainer + $body = "Your AUR package " . $row['Name'] . " has been proposed for deletion by " . $f_name . " [1].\n\n"; + $body.= "You may view your package at:\nhttp://aur.archlinux.org/packages.php?ID=" . $_REQUEST['ID'] . "\n\n"; + + $body.= "The reason(s) given were:\n"; + if ($_REQUEST['NOSOURCE']) { + $body.= " - The sources are no longer available.\n"; + } + if ($_REQUEST['WONTBUILD']) { + $body.= " - The package no longer builds on current systems.\n"; + } + if ($_REQUEST['DUPE']) { + $body.= " - The package is duplicated elsewhere.\n"; + } + if ($_REQUEST['NAMECHANGE']) { + $body.= " - The package's name has changed, and a new package replaces it.\n"; + } + + $body.= "\nThe proposer added the following details:\n"; + $body.= $_REQUEST['REASONTEXT']."\n\n"; + + $body.= "[1] - http://aur.archlinux.org/account.php?Action=AccountInfo&ID=" . $f_uid; + + $body = wordwrap($body, 70); + $headers = "Reply-to: nobody@archlinux.org\nFrom:aur-notify@archlinux.org\nX-Mailer: PHP\nX-MimeOLE: Produced By AUR\n"; + + @mail($row['Email'], "AUR Package Deletion Proposal for ".$row['Name'], $body, $headers); + } + + + # Send messages to those on the notify list as well (but not the maintainer again) + + $q = "SELECT Packages.Name, Users.Email "; + $q.= "FROM Packages, Users "; + $q.= "WHERE Packages.ID = " . $_REQUEST['ID'] . " "; + $q.= "AND Packages.MaintainerUID != Users.ID"; + $result = db_query($q, $dbh); + + # If this is false, then the package has no-one to notify, so there's no email to send + if (mysql_num_rows($result)) { + while($row = mysql_fetch_assoc($result)) { + + # construct email - maintainer + $body = "The AUR package " . $row['Name'] . " has been proposed for deletion by " . $f_name . " [1].\n\n"; + $body.= "You may view the package at:\nhttp://aur.archlinux.org/packages.php?ID=" . $_REQUEST['ID'] . "\n\n"; + + $body.= "The reason(s) given were:\n"; + if ($_REQUEST['NOSOURCE']) { + $body.= " - The sources are no longer available.\n"; + } + if ($_REQUEST['WONTBUILD']) { + $body.= " - The package no longer builds on current systems.\n"; + } + if ($_REQUEST['DUPE']) { + $body.= " - The package is duplicated elsewhere.\n"; + } + if ($_REQUEST['NAMECHANGE']) { + $body.= " - The package's name has changed, and a new package replaces it.\n"; + } + + $body.= "\nThe proposer added the following details:\n"; + $body.= $_REQUEST['REASONTEXT']."\n\n"; + + + $body.= "[1] - http://aur.archlinux.org/account.php?Action=AccountInfo&ID=" . $f_uid; + + + $body = wordwrap($body, 70); + $headers = "Reply-to: nobody@archlinux.org\nFrom:aur-notify@archlinux.org\nX-Mailer: PHP\nX-MimeOLE: Produced By AUR\n"; + + @mail($row['Email'], "AUR Package Deletion Proposal for ".$row['Name'], $body, $headers); + } + } + + + + # Update the database to know that deletion has been proposed + $q = "UPDATE Packages SET DeletionProposed = 1"; + $q.= " WHERE ID = " . $_REQUEST['ID']; + db_query($q, $dbh); + + + print __("Package successfully proposed for deletion. Check the aur-general list for this proposal's progress.")."<br />\n"; + print "<a href='packages.php?ID=" . $_REQUEST["ID"] . ">" . __("Back to the package page") . "</a>"; + + } else { + + # We can be here because both of these aren't true: + + if (!$_REQUEST["CONFIRM"]) { + # The user gave a reason, but didn't hit confirm + print __("You must check the last box to confirm that you wish to propose the package for deletion.") . "<br /><br />"; + } + + if ($_REQUEST["CONFIRM"]) { + print __("You must give at least one valid reason when proposing a package deletion.") . "<br /><br />"; + } + + + + # Prompt visitor for reasons for the deletion + + print "<form action='pkgedit.php' method='post'>\n"; + print "<input type='hidden' name='propose_Deletion' value='1'>\n"; + print "<input type='hidden' name='ID' value=\"".$_REQUEST["ID"]."\">\n"; + print __("Please select the reason(s) why you think this package should be deleted.")."<br />\n"; + + print " <input type='checkbox' name='NOSOURCE' value='1' /> " .__("The sources are no longer available")."<br />\n"; + print " <input type='checkbox' name='WONTBUILD' value='1' /> " .__("The package no longer builds on a current system")."<br />\n"; + print " <input type='checkbox' name='DUPE' value='1' /> " .__("The package is duplicated in the AUR or another repository")."<br />\n"; + print " <input type='checkbox' name='NAMECHANGE' value='1' /> " .__("The package's name has changed (including a -vcs suffix)")."<br />\n"; + print "<br />\n"; + print " ".__("Please give further details here. For example, if the package is duplicated, please post a link to where. If the name has changed, please say where the new package is.")."\n"; + print " <textarea rows='10' cols='90' name='REASONTEXT'></textarea>"; + + print "<br /> <br />\n"; + + print " <input type='checkbox' name='CONFIRM' value='1' /> " .__("Check this box to confirm that you want to propose the deletion.")."<br />\n"; + + print "<br /> <br />\n"; + print "<input type='submit' value=\"".__("Submit")."\">\n"; + print "<input type='reset' value=\"".__("Reset")."\">\n"; + print "</form>\n"; + + } + html_footer(AUR_VERSION); + exit(); +} + + print __("You've found a bug if you see this....")."<br />\n"; html_footer(AUR_VERSION); diff --git a/web/lib/pkgfuncs.inc b/web/lib/pkgfuncs.inc index 386662c..36fd13c 100644 --- a/web/lib/pkgfuncs.inc +++ b/web/lib/pkgfuncs.inc @@ -714,6 +714,11 @@ function pkg_propose_deletion ($atype, $ids, $action = True) { } } + # For now, we don't allow deletion proposals through this mechanism, since we require a reason + if ($action) { + return __("Deletion proposals are not currently allowed without giving a reason."); + } + $dbh = db_connect(); $first = 1; @@ -730,45 +735,14 @@ function pkg_propose_deletion ($atype, $ids, $action = True) { $q = "UPDATE Packages SET DeletionProposed = " . $ood; $q.= " WHERE ID IN (" . $propose . ")"; - if (!$action) { - echo "Undeleting!!!!"; - } - db_query($q, $dbh); if ($action) { - # Notify maintainer and aur-general of proposal by email - $f_name = username_from_sid($_COOKIE['AURSID']); - $f_email = email_from_sid($_COOKIE['AURSID']); - $f_uid = uid_from_sid($_COOKIE['AURSID']); - $q = "SELECT Packages.Name, Users.Email, Packages.ID "; - $q.= "FROM Packages, Users "; - $q.= "WHERE Packages.ID IN (" . $propose .") "; - $q.= "AND Users.ID = Packages.MaintainerUID "; - $q.= "AND Users.ID != " . $f_uid; - $result = db_query($q, $dbh); - if (mysql_num_rows($result)) { - while ($row = mysql_fetch_assoc($result)) { - # construct email - maintainer - $body = "Your package " . $row['Name'] . " has been proposed for deletion by " . $f_name . " [1]. You may view your package at:\nhttp://aur.archlinux.org/packages.php?ID=" . $row['ID'] . "\n\n[1] - http://aur.archlinux.org/account.php?Action=AccountInfo&ID=" . $f_uid; - $body = wordwrap($body, 70); - $headers = "Reply-to: nobody@archlinux.org\nFrom:aur-notify@archlinux.org\nX-Mailer: PHP\nX-MimeOLE: Produced By AUR\n"; - @mail($row['Email'], "AUR Package Deletion Proposal for ".$row['Name'], $body, $headers); - - # construct email - aur-general - $body = "The AUR package " . $row['Name'] . " has been proposed for deletion by " . $f_name . " [1]. You may view the package at:\nhttp://aur.archlinux.org/packages.php?ID=" . $row['ID'] . "\n\n[1] - http://aur.archlinux.org/account.php?Action=AccountInfo&ID=" . $f_uid; - $body = wordwrap($body, 70); - $headers = "Reply-to: nobody@archlinux.org\nFrom:aur-notify@archlinux.org\nX-Mailer: PHP\nX-MimeOLE: Produced By AUR\n"; - @mail('aur-general(a)archlinux.org', "AUR Package Deletion Proposal for ".$row['Name'], $body, $headers); - - } - } - } - - if ($action) { + # If we wanted to allow deletion propsals without reasons, we'd do it here. + # And we'd then say... return __("The selected packages have been proposed for deletion."); } else { - return __("The deletion proposals have been cancelled for the selection packages."); + return __("The deletion proposals have been cancelled for the selected packages."); } } -- 1.7.3

2 1

[aur-dev] [PATCH] PKGBUILD syntax highlight
by Manuel Tortosa 05 Oct '10

05 Oct '10

This is another approach. Greez.

4 4

[aur-dev] Displaying stats from pkgstats
by Rémy Oudompheng 04 Oct '10

04 Oct '10

Hello, With pkgstats, we have some idea about what AUR packages are often used [*]. I think it would be interesting to display usage statistics in AUR, as it would be a good complement to the vote statistics. Are we interested in such a feature, or do you think it is unnecessary due to the existence of the vote feature ? [*] https://www.archlinux.de/?page=PackageStatistics -- Rémy

6 5

[aur-dev] [PATCH] Add smilies to comments
by Manuel Tortosa 03 Oct '10

03 Oct '10

The images you can get them from here: wget www.chakra-project.org/temp/manutortosa/smilies.tar.gz or use your own, those are licemsed under gpl2 and are exactly the same you've in your forums. Best Regards.

6 5

Re: [aur-dev] Hello all
by Ángel Velásquez 03 Oct '10

03 Oct '10

2010/9/23 Manuel Tortosa <manutortosa(a)gmail.com>: > Hello all, i'm Manuel Tortosa, from the Chakra Project and i work in the > Chakra Webpage developement ( i'm the pacman Catalan translator :P ) Hi Manuel, > > where can i send these patches? > All the paches will be prepared using the AUR source code and template > agnostic to fit the ARCH look even if this means double work for me. > > Thanks a lot for your work. Keep Arch rolling! > You should send your patches to aur-general(a)archlinux.org in git format then Loui or Callan could apply them :D Thanks for you work -- Angel Velásquez angvp @ irc.freenode.net Arch Linux Developer / Trusted User / Equipo Hispano Linux Counter: #359909 http://www.angvp.com -- Angel Velásquez angvp @ irc.freenode.net Arch Linux Developer / Trusted User Linux Counter: #359909 http://www.angvp.com

3 6

[aur-dev] [PATCH] Fix headers in pkg_search_results.php
by Manuel Tortosa 03 Oct '10

03 Oct '10

This patch fix this issue in the table headers: CategoryName VotesDescription centering Name and Description columns headers, fix the issue. Best regards.

2 1